Derrell Lipman [Sun, 2 Mar 2008 01:44:21 +0000 (20:44 -0500)]
Additional revamped libsmbclient documentation
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
Derrell Lipman [Fri, 29 Feb 2008 18:34:35 +0000 (13:34 -0500)]
Modified revamp of the libsmbclient interface.
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
Derrell Lipman [Thu, 28 Feb 2008 16:23:20 +0000 (11:23 -0500)]
Initial revamp of the libsmbclient interface.
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
Günther Deschner [Sat, 1 Mar 2008 15:13:25 +0000 (16:13 +0100)]
Make sure we are still able to join Windows 2008.
Guenther
Volker Lendecke [Sat, 1 Mar 2008 08:26:43 +0000 (09:26 +0100)]
Revert "Add basic infrastructure for general async requests"
This reverts commit
ae254cb61f4b9331755848c47ebc34e90dd80390.
Volker Lendecke [Sat, 1 Mar 2008 08:26:27 +0000 (09:26 +0100)]
Revert "Add infrastructure to support async SMB requests"
This reverts commit
f5356825698a02df2d400b51dd95d1f857c83e81.
Volker Lendecke [Sat, 1 Mar 2008 08:26:18 +0000 (09:26 +0100)]
Revert "Add async cli_pull support"
This reverts commit
844a163458c7585e4306a21ffdae5d08e03d6e4d.
Volker Lendecke [Sat, 1 Mar 2008 08:26:06 +0000 (09:26 +0100)]
Revert "Convert cli_read to use cli_pull"
This reverts commit
719527f55e88f0c5fdceda5c807475aba299c79f.
Volker Lendecke [Sat, 1 Mar 2008 08:25:52 +0000 (09:25 +0100)]
Revert "Fix warnings"
This reverts commit
9a966e5593ae4474014aec5d8c68c489ac8ce0c9.
Günther Deschner [Fri, 29 Feb 2008 23:32:36 +0000 (00:32 +0100)]
Fix init_registry_data for subkeyless top-level keys.
On a fresh install with no existing registry.tdb, make sure we are able to
create our initial top-level entries.
Michael, Volker, please check.
Guenther
Volker Lendecke [Fri, 29 Feb 2008 21:38:10 +0000 (22:38 +0100)]
Restore 3.0 behaviour with empty /etc/hosts
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.
This restores the 3.0 behaviour.
Comments?
Volker
Volker Lendecke [Fri, 29 Feb 2008 21:33:35 +0000 (22:33 +0100)]
Check the right variable for being NULL
Günther Deschner [Fri, 29 Feb 2008 19:52:35 +0000 (20:52 +0100)]
Fix the build w/o ldap.
Guenther
Günther Deschner [Fri, 29 Feb 2008 17:23:53 +0000 (18:23 +0100)]
Add gp_get_machine_token().
Guenther
Günther Deschner [Fri, 29 Feb 2008 17:19:06 +0000 (18:19 +0100)]
Revert "what a wurst."
That commit message was just too silly, this happens to me during interactive
rebase all the time...
This reverts commit
ab687104c1371c84c510eca7ef2caad7c21ea8fc.
Günther Deschner [Fri, 29 Feb 2008 16:45:25 +0000 (17:45 +0100)]
what a wurst.
Günther Deschner [Fri, 29 Feb 2008 16:06:22 +0000 (17:06 +0100)]
Add "registry" Group Policy extension.
Guenther
Günther Deschner [Fri, 29 Feb 2008 15:03:23 +0000 (16:03 +0100)]
Add Group Policy extension infrastructure.
Guenther
Jeremy Allison [Fri, 29 Feb 2008 14:56:06 +0000 (06:56 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 29 Feb 2008 14:55:33 +0000 (06:55 -0800)]
Patch to fix the "Invalid read of size 4" errors. Bug #3617.
Jeremy.
Günther Deschner [Fri, 29 Feb 2008 14:46:14 +0000 (15:46 +0100)]
Add infrastructure for reading/storing Group Policy state and control data in the registry.
Guenther
Volker Lendecke [Fri, 29 Feb 2008 14:13:02 +0000 (15:13 +0100)]
Fix warnings
Günther Deschner [Fri, 29 Feb 2008 13:51:37 +0000 (14:51 +0100)]
Pure cosmetics, trying to get my group policy diff smaller.
Gunther
Jeremy Allison [Fri, 29 Feb 2008 13:51:09 +0000 (05:51 -0800)]
Fix part of bug #3617 from valgrind trace.
"Invalid read of size 1" errors.
Jeremy.
Michael Adam [Fri, 29 Feb 2008 12:35:16 +0000 (13:35 +0100)]
Eliminate tons of build warnings on non-IPV6 system.
Michael
Michael Adam [Fri, 29 Feb 2008 12:17:18 +0000 (13:17 +0100)]
Revert "make idl: Only compile idl files newer than the output to be generated."
This reverts commit
79c199d16e565eabd9fd971247f8df62689bb92a.
Revert this until pidl is capable of doing decent dependency tracking
itself (importing types from imported idls).
Michael
Michael Adam [Fri, 29 Feb 2008 12:15:56 +0000 (13:15 +0100)]
Revert "Add libnet_join.idl to the IDL files to be processed by "make idl"."
This reverts commit
9b47a7329091b2bfe7cd9b2112ac8fa652ed9f60.
libnet_join.idl should not be processed along with the other idl files
since it should not produce server and client code, just the header.
Michael
Andreas Schneider [Thu, 28 Feb 2008 13:06:11 +0000 (14:06 +0100)]
Rename the 'hidden' variable to 'administrative share'.
Michael Adam [Fri, 29 Feb 2008 11:38:29 +0000 (12:38 +0100)]
Fix linking of smbget when there is no shared library support.
smbget needs libwbclient.
Michael
Günther Deschner [Fri, 29 Feb 2008 10:43:06 +0000 (11:43 +0100)]
Fill in WHATSNEW.txt.
Guenther
Volker Lendecke [Fri, 29 Feb 2008 09:17:35 +0000 (10:17 +0100)]
Attempt to fix the build
Stefan Metzmacher [Fri, 29 Feb 2008 08:58:37 +0000 (09:58 +0100)]
configure: only build vfs_syncops if dirfd() is available
This hopefully fixes the build on HP-UX.
metze
Stefan Metzmacher [Fri, 29 Feb 2008 08:25:18 +0000 (09:25 +0100)]
configure: Remove lib/repdir.c and related stuff
It was only used in configure, but lib/replace already
has a much better version of it.
metze
Volker Lendecke [Thu, 21 Feb 2008 15:14:08 +0000 (16:14 +0100)]
Add vfs_aio_fork
This is used for two purposes:
First, I'm using it to test the async I/O code. In the forked process it is
pretty easy to delay a reply for a random amount of time. See the
BUILD_FARM_HACKS snippet.
Second, there are systems around that claim to have Posix AIO but which is
broken. This might be some help for those systems.
Also add tests how to pass file descriptors
Michael Adam [Fri, 29 Feb 2008 08:40:09 +0000 (09:40 +0100)]
Fix creation of replacetort.
Forgot to git add Makefile.in before doing git commit --amend
in previous commit...
Michael
Michael Adam [Fri, 29 Feb 2008 01:46:14 +0000 (02:46 +0100)]
libreplace: add snprintf.c to test code for getifaddrs - needed on some systems.
Michael
(cherry picked from commit
0aff54a12e20d5e91fcdec7aaec103fb9a371a23)
Michael Adam [Fri, 29 Feb 2008 01:43:24 +0000 (02:43 +0100)]
libreplace: ifdef out ip6 code if unsupported.
Michael
(cherry picked from commit
54cc0df4dbf6d63a9b94e1ac6af4ec7f7803bc30)
Michael Adam [Fri, 29 Feb 2008 01:23:29 +0000 (02:23 +0100)]
libreplace: fix rep_freeifaddrs to not segfault on NULL input.
Michael
(cherry picked from commit
0cbb87453beb52c6b0bc3a48791f49678f4030c5)
Michael Adam [Fri, 29 Feb 2008 01:22:02 +0000 (02:22 +0100)]
libreplace: fix silly crashbug in getifaddrs_test().
Michael
(cherry picked from commit
523626908d25f974fd1ae6d7306b1d4bc8414162)
Michael Adam [Fri, 29 Feb 2008 00:49:30 +0000 (01:49 +0100)]
libreplace: add missing newline in output of getifaddrs test.
Michael
(cherry picked from commit
f8243cfc47c7414bab7f249d0e5d1c85e8ca7d64)
Michael Adam [Fri, 29 Feb 2008 00:25:54 +0000 (01:25 +0100)]
libreplace: add missing semicolon to getifaddrs.
Michael
(cherry picked from commit
29818a07de826fd687003ff25865d77939ecaa9a)
Michael Adam [Thu, 28 Feb 2008 23:06:55 +0000 (00:06 +0100)]
libreplace: try and fix rep_getifaddrs() for Tru64.
Don't fail when there is no address assigned to the interface.
Put NULL into the ifaddrs structure instead.
Michael
(cherry picked from commit
ee170c85e0e76411bd752de5fe51db6940dab929)
Michael Adam [Thu, 28 Feb 2008 20:44:31 +0000 (21:44 +0100)]
libreplace: use the new getifaddrs test also for autoconf.
Michael
(cherry picked from commit
a2a506ff0eae2a64ebe2ddbb81a6c2a5fa7fe3da)
Michael Adam [Thu, 28 Feb 2008 20:43:06 +0000 (21:43 +0100)]
libreplace: add extended getifaddrs test that prints out the interfaces.
Michael
cherry-picked from libreplace-part of
9d2bab09aac22c00fe23f1e1265a2dbd0901e9ce
and adapted replacetort creation
Günther Deschner [Fri, 29 Feb 2008 01:49:27 +0000 (02:49 +0100)]
Trying to fix libnetapi examples Makefile.in.
Guenther
Günther Deschner [Fri, 29 Feb 2008 00:27:52 +0000 (01:27 +0100)]
libnetjoin: add fallback to level 24 samr setinfo so that libnet can join NT4.
Guenther
Günther Deschner [Fri, 29 Feb 2008 00:25:45 +0000 (01:25 +0100)]
libnetjoin: Trying to avoid confusion between acct_flags, acb_info and
access_desired.
Guenther
Günther Deschner [Thu, 28 Feb 2008 22:37:47 +0000 (23:37 +0100)]
Fix samr querydispinfo w.r.t. lsa_AsciiStringLarge.
Thanks metze for the fix.
Guenther
Günther Deschner [Thu, 28 Feb 2008 22:37:18 +0000 (23:37 +0100)]
Re-run make idl.
Guenther
Stefan Metzmacher [Fri, 15 Feb 2008 13:56:35 +0000 (14:56 +0100)]
samr.idl: windows uses lsa_AsciiStringLarge in QueryDisplayInfo
Tested with nt4 and w2k3.
metze
Stefan Metzmacher [Tue, 19 Feb 2008 13:47:22 +0000 (14:47 +0100)]
lsa.idl: strlen_m*() also for the lsa_AsciiString* versions
We already did this before
b994f899b42d294c0418bdc82660a2f7510667d6.
This is needed to handle NULL strings, where strlen() would crash...
Maybe we should add a strlen_a() and strlen_a_term() later...
metze
Stefan Metzmacher [Tue, 19 Feb 2008 13:44:50 +0000 (14:44 +0100)]
lsa.idl: use strlen_m_term() in lsa_StringLarge to support NULL strings
metze
Stefan Metzmacher [Fri, 15 Feb 2008 13:56:07 +0000 (14:56 +0100)]
lsa.idl: add lsa_AsciiStringLarge
metze
Stefan Metzmacher [Thu, 14 Feb 2008 15:08:50 +0000 (16:08 +0100)]
lsa.idl: don't use ascstr_noterm anymore
metze
Günther Deschner [Thu, 28 Feb 2008 11:48:08 +0000 (12:48 +0100)]
Remove DomainControllerAddressType which we now have in IDL.
Guenther
Günther Deschner [Thu, 28 Feb 2008 22:15:11 +0000 (23:15 +0100)]
Fix memleak in netsamlogon_cache_get().
Guenther
Stefan Metzmacher [Thu, 28 Feb 2008 12:29:47 +0000 (13:29 +0100)]
winbind: use a struct element for WBFLAG_PAM_UNIX_NAME
To not conflict with WBFLAG_PAM_INFO3_TEXT.
This should fix pam_winbind.
metze
Günther Deschner [Thu, 28 Feb 2008 20:55:01 +0000 (21:55 +0100)]
While we are at it: add _wkssvc_NetrUnjoinDomain2 implementation.
This can be tested with e.g. "netdom remove SAMBAHOST" from windows.
Guenther
Günther Deschner [Thu, 28 Feb 2008 19:01:32 +0000 (20:01 +0100)]
Re-enable _wkssvc_NetrJoinDomain2 remote join implementation now that we are ready for it.
"netdom join SAMBAHOST" from a windows workstation nicely demonstrates it.
Guenther
Günther Deschner [Thu, 28 Feb 2008 18:54:35 +0000 (19:54 +0100)]
Remove original copy of now redundant join code.
Jerry, I checked this very carefully that nothing got lost. The only thing I need to
re-add still is the normalized DN handling for account precreation in "net ads join".
Guenther
Günther Deschner [Thu, 28 Feb 2008 18:44:34 +0000 (19:44 +0100)]
libnetjoin: Merge in comments, debugs and missing code from original join code.
Guenther
Gerald W. Carter [Thu, 28 Feb 2008 17:58:05 +0000 (11:58 -0600)]
Fix macro name (no 's' in ifr_addr).
Interface detection on Solaris still failing due to items pointed out here:
http://lists.samba.org/archive/samba-technical/2007-November/056701.html
Günther Deschner [Thu, 28 Feb 2008 16:09:47 +0000 (17:09 +0100)]
Only set DEBUGLEVEL to 0 in libnetapi when not set already.
Guenther
Günther Deschner [Thu, 28 Feb 2008 16:02:14 +0000 (17:02 +0100)]
Add some more error handling in libnetjoin.
Guenther
Günther Deschner [Thu, 28 Feb 2008 15:56:35 +0000 (16:56 +0100)]
Use libnetapi_get_error_string() in "net dom" commands.
Guenther
Karolin Seeger [Thu, 28 Feb 2008 14:52:06 +0000 (15:52 +0100)]
Update WHATSNEW.
Karolin
Karolin Seeger [Thu, 28 Feb 2008 14:49:57 +0000 (15:49 +0100)]
Remove smbmount.
Karolin
Karolin Seeger [Thu, 28 Feb 2008 14:45:28 +0000 (15:45 +0100)]
Add mount.cifs as a wrapper for mount.cifs.
Karolin
Volker Lendecke [Thu, 28 Feb 2008 14:26:01 +0000 (15:26 +0100)]
Convert cli_read to use cli_pull
Volker Lendecke [Thu, 28 Feb 2008 14:21:33 +0000 (15:21 +0100)]
Add async cli_pull support
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
Volker Lendecke [Thu, 28 Feb 2008 13:41:25 +0000 (14:41 +0100)]
Add infrastructure to support async SMB requests
Volker Lendecke [Thu, 28 Feb 2008 12:55:53 +0000 (13:55 +0100)]
Add basic infrastructure for general async requests
Jeremy Allison [Thu, 28 Feb 2008 14:01:09 +0000 (06:01 -0800)]
Fix the build - don't use SMB_TRANS_ENC_GSS without
KRB5.
Jeremy.
Jeremy Allison [Thu, 28 Feb 2008 13:54:50 +0000 (05:54 -0800)]
Don't define SMB_TRANS_ENC_GSS if we don't have KRB5.
Jeremy.
Günther Deschner [Thu, 28 Feb 2008 13:29:44 +0000 (14:29 +0100)]
Some fixes for net ads join (uninitialized vars).
Guenther
Günther Deschner [Thu, 28 Feb 2008 13:18:03 +0000 (14:18 +0100)]
Use libnet_Join() for "net ads join".
Guenther
Volker Lendecke [Thu, 28 Feb 2008 13:04:54 +0000 (14:04 +0100)]
Add cli_setup_packet_buf
This is == cli_setup_packet but takes an explicit buffer argument
Volker Lendecke [Thu, 28 Feb 2008 13:03:38 +0000 (14:03 +0100)]
Make cli_struct a talloc parent
Günther Deschner [Thu, 28 Feb 2008 13:08:32 +0000 (14:08 +0100)]
Nicen error output in net_ads_leave.
Guenther
Günther Deschner [Thu, 28 Feb 2008 12:58:34 +0000 (13:58 +0100)]
Add WERR_TIME_SKEW to werror mapping tables.
Guenther
Karolin Seeger [Thu, 28 Feb 2008 12:32:34 +0000 (13:32 +0100)]
Add missing full stops and blank lines.
Karolin
Volker Lendecke [Tue, 12 Feb 2008 22:16:37 +0000 (23:16 +0100)]
Add explicit buf arg to cli_check_sign_mac
Volker Lendecke [Tue, 12 Feb 2008 10:54:37 +0000 (11:54 +0100)]
Add explicit buf arg to cli_encrypt_message and cli_calculate_sign_mac
Günther Deschner [Thu, 28 Feb 2008 12:04:30 +0000 (13:04 +0100)]
Re-arrange dns update block during "net ads join" a little.
Guenther
Günther Deschner [Thu, 28 Feb 2008 11:51:45 +0000 (12:51 +0100)]
Fix one dsgetdcname call in wkssvc rpc server.
Guenther
Michael Adam [Thu, 28 Feb 2008 11:53:14 +0000 (12:53 +0100)]
WHATSNEW: Add changes by Andreas Schneider.
Michael
Günther Deschner [Thu, 28 Feb 2008 11:43:43 +0000 (12:43 +0100)]
Remove unused display_ds_domain_controller_info() function.
Guenther
Volker Lendecke [Thu, 28 Feb 2008 11:47:44 +0000 (12:47 +0100)]
Add another WHATSNEW
Günther Deschner [Thu, 28 Feb 2008 11:30:18 +0000 (12:30 +0100)]
Let dsgetdcname() return a struct netr_DsRGetDCNameInfo.
Guenther
Jeremy Allison [Thu, 28 Feb 2008 11:28:31 +0000 (03:28 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 28 Feb 2008 11:27:55 +0000 (03:27 -0800)]
Updated comments on the encryption support.
Jeremy.
Michael Adam [Thu, 28 Feb 2008 11:26:37 +0000 (12:26 +0100)]
WHATSNEW: add another change.
Michael
Michael Adam [Thu, 28 Feb 2008 11:19:30 +0000 (12:19 +0100)]
WHATSNEW: add two more items to my changes.
Michael
Michael Adam [Thu, 28 Feb 2008 11:13:59 +0000 (12:13 +0100)]
WHATSNEW: Also merge changes in "Major enhancements" section from v3-2-stable.
Michael
Michael Adam [Thu, 28 Feb 2008 11:13:22 +0000 (12:13 +0100)]
WHATSNEW: give a new date for the upcoming prerelease.
Michael
Michael Adam [Thu, 28 Feb 2008 11:11:58 +0000 (12:11 +0100)]
WHATSNEW: Fix spacings
Michael
Michael Adam [Thu, 28 Feb 2008 11:11:21 +0000 (12:11 +0100)]
WHATSNEW: fix a typo and spacings
Michael
Michael Adam [Thu, 28 Feb 2008 11:08:11 +0000 (12:08 +0100)]
WHATSNEW: Merge additions from v3-2-stable's WHATSNEW. :-}
Michael
Michael Adam [Thu, 28 Feb 2008 10:59:11 +0000 (11:59 +0100)]
WHATSNEW: Move Volker's post pre1 changes to the appropriate section.
Michael
Michael Adam [Thu, 28 Feb 2008 10:58:09 +0000 (11:58 +0100)]
WHATSNEW: adapt section on registry configuration to new facts.
Also add to smb.conf changes.
Michael