15 years agor4417: Reply to samr_QueryDomainInfo with the same static value as level2 does.
Volker Lendecke [Thu, 30 Dec 2004 19:11:25 +0000 (19:11 +0000)]
r4417: Reply to samr_QueryDomainInfo with the same static value as level2 does.

(This used to be commit 04cf580ef30ac38f3f312184a7b18551195a17ce)

15 years agor4416: [in,out] variables do have an r->out component...
Volker Lendecke [Thu, 30 Dec 2004 19:08:32 +0000 (19:08 +0000)]
r4416: [in,out] variables do have an r->out component...

(This used to be commit 97247c902962b7c0ac69691ae8d7300321de41d5)

15 years agor4415: Implement samr_RemoveMemberFromForeignDomain. This is needed to delete a user
Volker Lendecke [Thu, 30 Dec 2004 18:50:15 +0000 (18:50 +0000)]
r4415: Implement samr_RemoveMemberFromForeignDomain. This is needed to delete a user
with usrmgr.exe.

To fix: Remove domain group membership attrib values when a user is deleted.

(This used to be commit 83d180c732ba73cf50072ef73ccdd60e72bc9910)

15 years agor4414: Various bits&pieces:
Volker Lendecke [Thu, 30 Dec 2004 17:01:49 +0000 (17:01 +0000)]
r4414: Various bits&pieces:

* Implement samr_search_domain, filter out all elements with no "objectSid"
  attribute and all objects outside a specified domain sid.

* Minor cleanups in dcerpc_samr.c due to that.

* Implement srvsvc_NetSrvGetInfo level 100. A quick hack to get usrmgr.exe
  one step further.

* Same for samr_info_DomInfo1.

(This used to be commit cdec89611355fb75d253ecf5b658d0e23de8e440)

15 years agor4413: login failure doesn't warrant a level 1 debug (its filling my logs during...
Andrew Tridgell [Thu, 30 Dec 2004 11:24:49 +0000 (11:24 +0000)]
r4413: login failure doesn't warrant a level 1 debug (its filling my logs during torture tests)
(This used to be commit b9284c16dc37bf14fceeaa694e82f36a38b0dd93)

15 years agor4412: SEC_FILE_READ_ATTRIBUTE is always granted, even if not requested. This was...
Andrew Tridgell [Thu, 30 Dec 2004 07:10:31 +0000 (07:10 +0000)]
r4412: SEC_FILE_READ_ATTRIBUTE is always granted, even if not requested. This was being done
in the full ACL code, but not in the unix access check code, which meant that qfileinfo
was failing for some parameters
(This used to be commit 96d017e521f5a996a7a274682838855d077834bc)

15 years agor4411: when checking for create permissions, we need to check the parent, not the...
Andrew Tridgell [Thu, 30 Dec 2004 06:51:13 +0000 (06:51 +0000)]
r4411: when checking for create permissions, we need to check the parent, not the child!
(This used to be commit 30b4c20b1c9aea94dd2a0611b58860797d244e5a)

15 years agor4410: pvfs_rename_one() should not check for create permissions, as the rename
Andrew Tridgell [Thu, 30 Dec 2004 06:37:37 +0000 (06:37 +0000)]
r4410: pvfs_rename_one() should not check for create permissions, as the rename
is always in the same directory
(This used to be commit babf3480a4c29ce28d9a4525c4174a3d765dcbab)

15 years agor4409: fixed handling of zero access masks for the POSITION_INFORMATION query/set...
Andrew Tridgell [Thu, 30 Dec 2004 06:02:54 +0000 (06:02 +0000)]
r4409: fixed handling of zero access masks for the POSITION_INFORMATION query/set levels
(This used to be commit 75e7229476e1af6ab78fa5b41a7bb67df8e3d2dd)

15 years agor4408: added the remaining access check hooks into pvfs. All calls should now have...
Andrew Tridgell [Thu, 30 Dec 2004 05:50:23 +0000 (05:50 +0000)]
r4408: added the remaining access check hooks into pvfs. All calls should now have acl checking,
and obey the various inheritance rules.
(This used to be commit 5fe51807d6b97e68b65f152c0f405e5c5a025d21)

15 years agor4407: stricter checking of parameters on hard link creation in the RAW-RENAME test
Andrew Tridgell [Thu, 30 Dec 2004 05:48:32 +0000 (05:48 +0000)]
r4407: stricter checking of parameters on hard link creation in the RAW-RENAME test
(This used to be commit b239589b00e673ae2d6254083cd324bc3b54bcdf)

15 years agor4406: - don't call the xattr unlink hook on unlink unless the link count is 1, otherwise
Andrew Tridgell [Thu, 30 Dec 2004 03:19:27 +0000 (03:19 +0000)]
r4406: - don't call the xattr unlink hook on unlink unless the link count is 1, otherwise
  the xattrs of the remaining link are removed

- fix the handling of attribute set on directories
(This used to be commit fa44e3cce00b75656c85378c7825960540d2f282)

15 years agor4405: added acl inheritance to the mkdir and t2mkdir backends.
Andrew Tridgell [Thu, 30 Dec 2004 02:38:44 +0000 (02:38 +0000)]
r4405: added acl inheritance to the mkdir and t2mkdir backends.
(This used to be commit b44d4d17df8af4941740e5d5e0842ca01d8f403c)

15 years agor4404: check for SEC_ACE_FLAG_INHERIT_ONLY in the "maximum allowed" logic
Andrew Tridgell [Thu, 30 Dec 2004 02:27:16 +0000 (02:27 +0000)]
r4404: check for SEC_ACE_FLAG_INHERIT_ONLY in the "maximum allowed" logic
(This used to be commit e4ee8b776ba164a89afca43de20c166ccbfddb99)

15 years agor4403: - added ACL inheritance in the pvfs backend. ACLs are now inherited on
Andrew Tridgell [Thu, 30 Dec 2004 02:25:20 +0000 (02:25 +0000)]
r4403: - added ACL inheritance in the pvfs backend. ACLs are now inherited on
  file and directory creation via ntcreatex. pvfs now passes the
  inheritance test in RAW-ACLS

- cleaned up the error handling a bit in pvfs_open()
(This used to be commit f4dfb63d5395a365961a21388639809fcd3112d0)

15 years agor4402: use __location__ instead of __LINE__ in the RAW-RENAME test
Andrew Tridgell [Thu, 30 Dec 2004 02:22:29 +0000 (02:22 +0000)]
r4402: use __location__ instead of __LINE__ in the RAW-RENAME test
(This used to be commit 09ac1338209b0d0878173cfef3dca5603271b1a8)

15 years agor4401: stricter test for correct ACL inheritance in RAW-ACLS
Andrew Tridgell [Thu, 30 Dec 2004 02:22:03 +0000 (02:22 +0000)]
r4401: stricter test for correct ACL inheritance in RAW-ACLS
(This used to be commit 1bb769196377772326151210309ff12362eb0f2f)

15 years agor4400: Pass rootdse.ldif past the subst code.
Andrew Bartlett [Wed, 29 Dec 2004 22:59:28 +0000 (22:59 +0000)]
r4400: Pass rootdse.ldif past the subst code.

Andrew Bartlett
(This used to be commit d901c8fb64440fd8f966cc3d8929bb63551019fd)

15 years agor4399: Implement samr_GetAliasMembership and samr_GetGroupsForUser. With these two,
Volker Lendecke [Wed, 29 Dec 2004 22:57:20 +0000 (22:57 +0000)]
r4399: Implement samr_GetAliasMembership and samr_GetGroupsForUser. With these two,
usrmgr.exe seems to become usable. Some quirks, but it's worth a try.

(This used to be commit 9c62a239cd609092654ad653972153a3a71e7279)

15 years agor4398: Make usrmgr.exe believe we're a DC. Otherwise it will not show global groups.
Volker Lendecke [Wed, 29 Dec 2004 22:54:24 +0000 (22:54 +0000)]
r4398: Make usrmgr.exe believe we're a DC. Otherwise it will not show global groups.

Index on "key" attribute.

(This used to be commit 9c23d73ec213c3ef6e0afd671570b431a66f55c0)

15 years agor4397: Fix a bug where '(&(objectclass=domain)(!(objectclass=builtindomain)))' fell
Volker Lendecke [Wed, 29 Dec 2004 22:25:46 +0000 (22:25 +0000)]
r4397: Fix a bug where '(&(objectclass=domain)(!(objectclass=builtindomain)))' fell
back to a full search.

(This used to be commit 55c9fbd4f4afdde30a0d92bfd31f5c9ebb98c59b)

15 years agor4396: Generate newrootdse.ldb in as well
Jelmer Vernooij [Wed, 29 Dec 2004 21:41:17 +0000 (21:41 +0000)]
r4396: Generate newrootdse.ldb in as well
(This used to be commit 3ebaec6edb68e9dce90981d96516fcf541c3c670)

15 years agor4395: Generate "newhklm.ldb" using
Jelmer Vernooij [Wed, 29 Dec 2004 21:21:14 +0000 (21:21 +0000)]
r4395: Generate "newhklm.ldb" using
(This used to be commit fa53c56236ddc7f86cdab85f95f6be6fcfb0909b)

15 years agor4394: Use 'raw' protocol towers in the lists in the endpoint rather then
Jelmer Vernooij [Wed, 29 Dec 2004 15:36:45 +0000 (15:36 +0000)]
r4394: Use 'raw' protocol towers in the lists in the endpoint rather then
dcerpc_binding structs.
(This used to be commit 9175b729724fb7b747e7e4072dda733277f0f414)

15 years agor4393: Trivial bugfix for a silly bug
Volker Lendecke [Wed, 29 Dec 2004 13:22:00 +0000 (13:22 +0000)]
r4393: Trivial bugfix for a silly bug
(This used to be commit ae3c329e9d718cdc011f8f291ccc68abad6b9cc7)

15 years agor4392: Fix samr_GetAliasMembership idl
Volker Lendecke [Wed, 29 Dec 2004 13:20:17 +0000 (13:20 +0000)]
r4392: Fix samr_GetAliasMembership idl
(This used to be commit b0b9332519ab6461967a5fe10698dcf4e9950834)

15 years agor4391: bring the default ACL inline with what w2k3 uses
Andrew Tridgell [Wed, 29 Dec 2004 12:41:27 +0000 (12:41 +0000)]
r4391: bring the default ACL inline with what w2k3 uses
(This used to be commit 16967f7502ea6d2efa0fc08decc955a1516c3a02)

15 years agor4390: Registry value and key names are case-insensitive
Jelmer Vernooij [Wed, 29 Dec 2004 12:28:35 +0000 (12:28 +0000)]
r4390: Registry value and key names are case-insensitive
Nicer menu layout in gregedit
(This used to be commit 2948b9750d756880c3af7fb352f0a684a1fae9c9)

15 years agor4389: added checking for the default inherited ACL, which is used when no ACEs
Andrew Tridgell [Wed, 29 Dec 2004 07:28:03 +0000 (07:28 +0000)]
r4389: added checking for the default inherited ACL, which is used when no ACEs
are inheritable
(This used to be commit e30b8d5783e073a31f738a36400fe866c970464b)

15 years agor4388: - allow ACE flags to be specified in security_descriptor_create()
Andrew Tridgell [Wed, 29 Dec 2004 06:53:15 +0000 (06:53 +0000)]
r4388: - allow ACE flags to be specified in security_descriptor_create()

- added a test for all combinations of the inheritance ACE flags and how
  they are propogated to child directories and files
(This used to be commit fdb38c8e4b6279137892402b21d2d52e1921e456)

15 years agor4387: added a TODO about the NTCREATEX_FLAGS_OPEN_DIRECTORY flag - it seems to open
Andrew Tridgell [Wed, 29 Dec 2004 06:52:06 +0000 (06:52 +0000)]
r4387: added a TODO about the NTCREATEX_FLAGS_OPEN_DIRECTORY flag - it seems to open
the parent of the specified directory ?!
(This used to be commit a012d1c978a478fe8debf0c546ed770047dbfbcf)

15 years agor4386: Grr, fix copy-and-paste bug.
Andrew Bartlett [Wed, 29 Dec 2004 00:03:34 +0000 (00:03 +0000)]
r4386: Grr, fix copy-and-paste bug.

Andrew Bartlett
(This used to be commit 13aa88ed65a8914000cccbecf80929db3df65037)

15 years agor4385: Set the correct target service.
Andrew Bartlett [Tue, 28 Dec 2004 23:59:22 +0000 (23:59 +0000)]
r4385: Set the correct target service.

Andrew Bartlett
(This used to be commit 722f59c7c8d09f548d9325c6051d6687d7aa16c2)

15 years agor4384: Try again to fix compiling against a specified KRB5 library.
Andrew Bartlett [Tue, 28 Dec 2004 23:55:58 +0000 (23:55 +0000)]
r4384: Try again to fix compiling against a specified KRB5 library.

The strong feeling I get is that this is just not possible, if as
Fedora has, the MIT installation is in /usr/lib, but this is one step
closer anyway.

Andrew Bartlett
(This used to be commit da4cf53767ca567497c4c7f341795246bb306892)

15 years agor4383: in order to cope with overfilled buffers on trans2 findfirst we need to use...
Andrew Tridgell [Tue, 28 Dec 2004 23:28:02 +0000 (23:28 +0000)]
r4383: in order to cope with overfilled buffers on trans2 findfirst we need to use 32 bit offsets and lengths
in trans2 fill code, even though the packets themselves can only use 16 bit lengths. This prevents
the overflow detection code from failing due to 16 bit length wrap.
(This used to be commit 5cd74c22e99bc78e1f3ddf3f098790c4b4b87b4f)

15 years agor4382: check for bad tid in SMBtdis
Andrew Tridgell [Tue, 28 Dec 2004 23:26:29 +0000 (23:26 +0000)]
r4382: check for bad tid in SMBtdis
(This used to be commit 44ca3f41cc835e22e6adca48ddfd84f246b22bfb)

15 years agor4381: Add my copyright
Volker Lendecke [Tue, 28 Dec 2004 23:05:48 +0000 (23:05 +0000)]
r4381: Add my copyright
(This used to be commit 9e27a83ac3b1470ba52df01743d9a64fcbecc64b)

15 years agor4380: Implement samr_QueryDisplayInfo. This probably needs some polishing (Do we
Volker Lendecke [Tue, 28 Dec 2004 23:01:34 +0000 (23:01 +0000)]
r4380: Implement samr_QueryDisplayInfo. This probably needs some polishing (Do we
have to sort the entries?)

(This used to be commit 26d21bb5cc26964f2d790aa83149ba399ac50db2)

15 years agor4379: Merge more Kerberos related configure checks (by jra, gd and Lars
Andrew Bartlett [Tue, 28 Dec 2004 22:29:48 +0000 (22:29 +0000)]
r4379: Merge more Kerberos related configure checks (by jra, gd and Lars
Mueller <>) from 3.0 to Samba4.

Andrew Bartlett
(This used to be commit 9c74e04098d50427f93219a6a451c44a2373db46)

15 years agor4378: Implement samr_EnumDomainGroups and samr_EnumDomainAliases.
Volker Lendecke [Tue, 28 Dec 2004 07:57:31 +0000 (07:57 +0000)]
r4378: Implement samr_EnumDomainGroups and samr_EnumDomainAliases.

Hmmm. How do I tell ldb not to descend into cn=Builtin?

(This used to be commit c95d20cd7c18fbfb5e6e9a5efac07354117610c5)

15 years agor4377: Fix default groupType attributes.
Volker Lendecke [Tue, 28 Dec 2004 07:54:30 +0000 (07:54 +0000)]
r4377: Fix default groupType attributes.

(This used to be commit 15d50350b596068643fb8e28d2a8cb45ac4d6204)

15 years agor4376: Implement samr_AddAliasMember, samr_DeleteAliasMember and
Volker Lendecke [Mon, 27 Dec 2004 22:20:17 +0000 (22:20 +0000)]
r4376: Implement samr_AddAliasMember, samr_DeleteAliasMember and

(This used to be commit 78802720ae922cf8ad19bf2e8be23a64435c4673)

15 years agor4375: Implement samr_OpenAlias, samr_QueryAliasInfo and samr_SetAliasInfo. Fix IDL
Volker Lendecke [Mon, 27 Dec 2004 11:27:30 +0000 (11:27 +0000)]
r4375: Implement samr_OpenAlias, samr_QueryAliasInfo and samr_SetAliasInfo. Fix IDL
for samr_SetAliasInfo.

(This used to be commit d70e2371903fb21e24ab2e23d04ee4b0b2ef55e5)

15 years agor4374: Follow metzes hint, change LookupRids a bit
Volker Lendecke [Mon, 27 Dec 2004 09:48:49 +0000 (09:48 +0000)]
r4374: Follow metzes hint, change LookupRids a bit
(This used to be commit b8fa5b9419c6397a4266bfdce3a31b1e016d7faa)

15 years agor4373: Support setting values and fix a segfault
Jelmer Vernooij [Mon, 27 Dec 2004 00:32:13 +0000 (00:32 +0000)]
r4373: Support setting values and fix a segfault
(This used to be commit cdb6980cdcf4b093e98b3b025f784333d46ac957)

15 years agor4372: Implement samr_LookupRids
Volker Lendecke [Sun, 26 Dec 2004 23:31:19 +0000 (23:31 +0000)]
r4372: Implement samr_LookupRids
(This used to be commit 1bab3254f6a27144c6f76edf66573f7fa25b3173)

15 years agor4371: Add "Create Key", "Delete Key" and "Delete Value" buttons.
Jelmer Vernooij [Sun, 26 Dec 2004 22:41:38 +0000 (22:41 +0000)]
r4371: Add "Create Key", "Delete Key" and "Delete Value" buttons.
gregedit now can do the same things as regedt32 except for finding
data and setting values. (and a few segfaults...)
(This used to be commit ada16f31e4da919731767ce31000aa270f22ffd5)

15 years agor4367: Implement samr_AddGroupMember, samr_DeleteGroupMember and
Volker Lendecke [Sun, 26 Dec 2004 18:02:18 +0000 (18:02 +0000)]
r4367: Implement samr_AddGroupMember, samr_DeleteGroupMember and

(This used to be commit 43581c3711d2eeb901094acebea294a3b87d4c0b)

15 years agor4366: Fix ldb_modify_internal: Adding values to an existing attribute you could end
Volker Lendecke [Sun, 26 Dec 2004 17:30:27 +0000 (17:30 +0000)]
r4366: Fix ldb_modify_internal: Adding values to an existing attribute you could end
up with a corrupt data structure on disk, namely with two attribute structures
for the same attribute name.

(This used to be commit 284044b5b20102894a8128f84ab41d59cfcc9285)

15 years agor4365: added command 'eainfo' to smbclient for displaying binary EA contents
Andrew Tridgell [Sun, 26 Dec 2004 08:41:11 +0000 (08:41 +0000)]
r4365: added command 'eainfo' to smbclient for displaying binary EA contents
(This used to be commit 268edcdb4a95240662102faef4126449f286d49d)

15 years agor4364: - added support for testing of chained SMB operations in smbtorture
Andrew Tridgell [Sun, 26 Dec 2004 08:13:01 +0000 (08:13 +0000)]
r4364: - added support for testing of chained SMB operations in smbtorture

- added test for chained OpenX/ReadX, simulating the OS/2 workplace shell

- fixed a bug in handling chained fnum in openx and ntcreatex in the server

(yes, I'm on holiday, but this bug was annoying me ....)
(This used to be commit b3b8958a18e302b815d98c0e3879e404bced6a08)

15 years agor4363: value "none required" is set if no library is needed (autoconf does this the...
Jelmer Vernooij [Sat, 25 Dec 2004 22:18:12 +0000 (22:18 +0000)]
r4363: value "none required" is set if no library is needed (autoconf does this the same way)
(This used to be commit 8cf15704101e5957e15a0401e4832faf1346f12e)

15 years agor4362: dlopen() doesn't imply -ldl
Jelmer Vernooij [Sat, 25 Dec 2004 21:49:21 +0000 (21:49 +0000)]
r4362: dlopen() doesn't imply -ldl
Should fix the build on several *BSD systems that have dlopen() in libc
(This used to be commit 6d2b8e71c177d1d35a8b975cd5f24089aaa2bb49)

15 years agor4361: fix the build
Stefan Metzmacher [Sat, 25 Dec 2004 14:12:31 +0000 (14:12 +0000)]
r4361: fix the build

(This used to be commit 78b2af77e9e4b97c698d6d9e680207b1df289cb4)

15 years agor4360: destroy the gensec context
Stefan Metzmacher [Sat, 25 Dec 2004 14:06:55 +0000 (14:06 +0000)]
r4360: destroy the gensec context

(This used to be commit a25770983b34bac5bd7dcce69241716386dc8509)

15 years agor4359: using talloc_free() of a child struct in a talloc_destructor is useless
Stefan Metzmacher [Sat, 25 Dec 2004 14:01:19 +0000 (14:01 +0000)]
r4359: using talloc_free() of a child struct in a talloc_destructor is useless

(This used to be commit e51f2cf43f2cbcf3c3bbb00abc99f1bddb9f7f35)

15 years agor4358: At metze's request, the Christmas elves have removed gensec_end in
Andrew Bartlett [Fri, 24 Dec 2004 23:02:39 +0000 (23:02 +0000)]
r4358: At metze's request, the Christmas elves have removed gensec_end in
favor of talloc_free().

Andrew Bartlett
(This used to be commit 1933cd12fbaed56e13f2386b19de6ade99bf9478)

15 years agor4357: Return a more sensible error code if a NULL (as opposed to the valid
Andrew Bartlett [Fri, 24 Dec 2004 10:56:23 +0000 (10:56 +0000)]
r4357: Return a more sensible error code if a NULL (as opposed to the valid
"") username is asked for.

Andrew Bartlett
(This used to be commit 9c9055603e1171e204f67b019900339f88414841)

15 years agor4356: Allow anonymous connections to use NTLMSSP. The silly bugs that
Andrew Bartlett [Fri, 24 Dec 2004 09:57:44 +0000 (09:57 +0000)]
r4356: Allow anonymous connections to use NTLMSSP.  The silly bugs that
prevented this are gone.

Andrew Bartlett
(This used to be commit 87dad5ec538abad93d621078a82f162675847f9f)

15 years agor4355: More work from the elves on Christmas eve:
Andrew Bartlett [Fri, 24 Dec 2004 09:54:23 +0000 (09:54 +0000)]
r4355: More work from the elves on Christmas eve:

 - Update Samba4's kerberos code to match the 'salting' changes in
   Samba3 (and many other cleanups by jra).

 - Move GENSEC into the modern era of talloc destructors.  This avoids
   many of the memory leaks in this code, as we now can't somehow
   'forget' to call the end routine.
  - This required fixing some of the talloc hierarchies.

 - The new krb5 seems more sensitive to getting the service name
   right, so start actually setting the service name on the krb5 context.

Andrew Bartlett
(This used to be commit 278bf1a61a6da6ef955a12c13d7b1a0357cebf1f)

15 years agor4354: The ldb databases do not go in lib/private, but in private/ under PREFIX
Andrew Bartlett [Fri, 24 Dec 2004 06:39:18 +0000 (06:39 +0000)]
r4354: The ldb databases do not go in lib/private, but in private/ under PREFIX

Andrew Bartlett
(This used to be commit 9ccb2a39c34766d620059a56a925cb749a0ad6f4)

15 years agor4349: Start to fix the long-standing pain that --with-krb5 would be ignored if krb5...
Andrew Bartlett [Thu, 23 Dec 2004 21:48:32 +0000 (21:48 +0000)]
r4349: Start to fix the long-standing pain that --with-krb5 would be ignored if krb5-config was in the path.

I'll merge this to Samba3, before trying to merge all of the Samba3
changes to Samba4.

Andrew Bartlett
(This used to be commit 906ba7cb8af02d44c868805e0b108b966f3221af)

15 years agor4345: Unify the representation of grouptype and samaccounttype to hex. Without any
Volker Lendecke [Thu, 23 Dec 2004 12:14:12 +0000 (12:14 +0000)]
r4345: Unify the representation of grouptype and samaccounttype to hex. Without any
kind of schema support we only have string comparisons (Hmm. Is this true?)
and must agree upon a common representation for integers. I suspect that we
might sooner or later need a search filter for "This bit in this integer
attrib is being set".

(This used to be commit 5f2d93b66bc89d499c91638f9b71394768d135af)

15 years agor4344: Unify memory handling in dcerpc_samr.c a bit
Volker Lendecke [Thu, 23 Dec 2004 12:02:55 +0000 (12:02 +0000)]
r4344: Unify memory handling in dcerpc_samr.c a bit
(This used to be commit 79ec28ade826c6a36e129abbe1e0a207074c676f)

15 years agor4342: Fix a memory leak in init_globals().
Andrew Bartlett [Thu, 23 Dec 2004 06:39:58 +0000 (06:39 +0000)]
r4342: Fix a memory leak in init_globals().

Andrew Bartlett
(This used to be commit cc47b4c6fc932f8257506276eaa1a98a41055f8b)

15 years agor4341: Fix const warning.
Tim Potter [Thu, 23 Dec 2004 04:09:25 +0000 (04:09 +0000)]
r4341: Fix const warning.
(This used to be commit d8b1ba93a8ed0d5d01cb05b1c14353a0eca4de3e)

15 years agor4340: - simplify lsa_GetUserName() server code,
Stefan Metzmacher [Thu, 23 Dec 2004 03:02:57 +0000 (03:02 +0000)]
r4340: - simplify lsa_GetUserName() server code,
  we don't need to do db lookups as we already known who the user is

(This used to be commit cef0d1eb29c6c5d41591a5c0beaed1dc26961211)

15 years agor4339: - rename auth_guest to auth_anonymous
Stefan Metzmacher [Thu, 23 Dec 2004 03:00:55 +0000 (03:00 +0000)]
r4339: - rename auth_guest to auth_anonymous

- don't use static const strings in the server_info

- fix segfault when auth_sam gets "" as username

(This used to be commit 7fcbd483d4977cf6483f34ddd28e6c0182897ba2)

15 years agor4338: reuse netlogon structs in the krb5 PAC
Stefan Metzmacher [Thu, 23 Dec 2004 02:23:42 +0000 (02:23 +0000)]
r4338: reuse netlogon structs in the krb5 PAC
that simplifies the code a lot...

also add a note: we should fail the krb5 auth if there's no
PAC present (when heimdal is ready for that:-)

(This used to be commit 532641a7003d23b034a253d166482f18c2de6191)

15 years agor4335: Fix some potential memleaks, implement CreateDomAlias. Hmmmm. Isn't there
Volker Lendecke [Wed, 22 Dec 2004 22:19:54 +0000 (22:19 +0000)]
r4335: Fix some potential memleaks, implement CreateDomAlias. Hmmmm. Isn't there
enough stuff to do in 3_0??? ;-)

(This used to be commit c0fa7a92d9f602dc50801a9827e121c2b095a336)

15 years agor4332: Fix a potential memleak.
Volker Lendecke [Wed, 22 Dec 2004 21:20:12 +0000 (21:20 +0000)]
r4332: Fix a potential memleak.

(This used to be commit 8f2b9c9d320dbea197808081528477d7e4c816d1)

15 years agor4328: mark the talloc data as DATA_BLOB
Stefan Metzmacher [Tue, 21 Dec 2004 15:23:33 +0000 (15:23 +0000)]
r4328: mark the talloc data as DATA_BLOB

(This used to be commit ad84e3b2e3b48406576a8ba2ebfd218cddae135d)

15 years agor4327: add usefull function if you don't want that the data will talloc_memdup()'ed
Stefan Metzmacher [Tue, 21 Dec 2004 15:15:49 +0000 (15:15 +0000)]
r4327: add usefull function if you don't want that the data will talloc_memdup()'ed

(This used to be commit 1f01e370b192fc8fa51eb3a46e7b45c993aa9b80)

15 years agor4326: fix memory leak
Stefan Metzmacher [Tue, 21 Dec 2004 15:01:53 +0000 (15:01 +0000)]
r4326: fix memory leak

(This used to be commit 1ceeb77fc716729c69f2dba4a84579c366eefa1c)

15 years agor4325: add the GENSEC_FEATURE_DCE_STYLE flag
Stefan Metzmacher [Tue, 21 Dec 2004 12:39:39 +0000 (12:39 +0000)]
r4325: add the GENSEC_FEATURE_DCE_STYLE flag
this will be used by krb5 dcerpc auth

(This used to be commit 04dc7fb9b24a1e38f31559ec6032701a176209ae)

15 years agor4324: add some more ads constants before I forget them
Stefan Metzmacher [Tue, 21 Dec 2004 12:26:12 +0000 (12:26 +0000)]
r4324: add some more ads constants before I forget them

(This used to be commit 705af52cb163de780c4ba5a1d84acd6c53909918)

15 years agor4323: - implement the lsa_GetUserName() server call
Stefan Metzmacher [Tue, 21 Dec 2004 12:22:57 +0000 (12:22 +0000)]
r4323: - implement the lsa_GetUserName() server call

- give lsa_lookup_sid() a chance with foreign SIDS
  returning NT_STATUS_NO_MEMORY makes no sense here
  as the ldb_msg_find_string() doesn't allocate the string

(This used to be commit b43f34e87354c82a3392a0ba99b38b4c7185e47c)

15 years agor4322: use a nicer name
Stefan Metzmacher [Tue, 21 Dec 2004 12:00:30 +0000 (12:00 +0000)]
r4322: use a nicer name

(This used to be commit f8ea82cbd1856f589132e2a96b8d658745036b3e)

15 years agor4321: objectClass trustedDomain uses "securityIdentifier" for the sid
Stefan Metzmacher [Tue, 21 Dec 2004 11:52:53 +0000 (11:52 +0000)]
r4321: objectClass trustedDomain uses "securityIdentifier" for the sid

also explicit tell the fill_info code what kind of object the current
result is.

(This used to be commit 6d74d31e50cd8f9d37fca53ef32bd50952a3a759)

15 years agor4320: fix locations of new trusting domains and domsin controller
Stefan Metzmacher [Tue, 21 Dec 2004 11:49:36 +0000 (11:49 +0000)]
r4320: fix locations of new trusting domains and domsin controller
computer accounts

(This used to be commit f75c2004a0fc889ce5d96790f7d1d5031bce3992)

15 years agor4319: make it easy to use valgrind in the test suite
Andrew Tridgell [Tue, 21 Dec 2004 11:49:01 +0000 (11:49 +0000)]
r4319: make it easy to use valgrind in the test suite
(This used to be commit 7c09a3ea581e08bb34972d657d11d7e03b832b65)

15 years agor4318: add missing template for trusting domains
Stefan Metzmacher [Tue, 21 Dec 2004 11:48:32 +0000 (11:48 +0000)]
r4318: add missing template for trusting domains

(This used to be commit 32264c6c30c67372ce6f0b2f0914c43a1a6eb5ea)

15 years agor4317: check the count of replies in the os2 ea_list torture test
Andrew Tridgell [Tue, 21 Dec 2004 11:48:13 +0000 (11:48 +0000)]
r4317: check the count of replies in the os2 ea_list torture test
(This used to be commit 10861b3fa0cbba7f5e0ec3377431a85608a13a32)

15 years agor4316: - now that the trans2 code properly supports multi-part requests, we can set
Andrew Tridgell [Tue, 21 Dec 2004 11:47:08 +0000 (11:47 +0000)]
r4316: - now that the trans2 code properly supports multi-part requests, we can set
  a maximum sized max_data in libcli trans2 code

- fixed string termination in the EA_LIST trans2 findfirst level
(This used to be commit a2a5f147f4faac8a48ff8f1b3e5f1334c92575bb)

15 years agor4315: use the remote hosts max_xmit, not the local hosts, in calculating max trans2...
Andrew Tridgell [Tue, 21 Dec 2004 11:45:37 +0000 (11:45 +0000)]
r4315: use the remote hosts max_xmit, not the local hosts, in calculating max trans2 data sizes
(This used to be commit 827008cfebf29d081b457ba7162d89c8150cb24b)

15 years agor4314: added ACL checking on unlink
Andrew Tridgell [Tue, 21 Dec 2004 11:44:32 +0000 (11:44 +0000)]
r4314: added ACL checking on unlink
(This used to be commit f25c469693517ed993e0379d8b07cd7eb235a669)

15 years agor4313: fixed a bug in handling new xattrs in the tdb xattr backend
Andrew Tridgell [Tue, 21 Dec 2004 11:43:46 +0000 (11:43 +0000)]
r4313: fixed a bug in handling new xattrs in the tdb xattr backend
(This used to be commit c66b5a100c1b83adf034087fe2ce49fc77d84161)

15 years agor4310: fixed the authority_name field in lsa_GetUserName()
Andrew Tridgell [Tue, 21 Dec 2004 10:05:02 +0000 (10:05 +0000)]
r4310: fixed the authority_name field in lsa_GetUserName()
(This used to be commit f78506697ad23456fcac6e8916d0dad05b0df6cc)

15 years agor4309: idl and torture test for lsa_GetUserName()
Stefan Metzmacher [Tue, 21 Dec 2004 09:41:21 +0000 (09:41 +0000)]
r4309: idl and torture test for lsa_GetUserName()

why does samba3 return domain_name as in the unknown_name field in the code
and on the wire it returns DCERPC_FAULT_OP_RNG_ERROR?

all of my test machines NT4,W2K,W2K3,XP returned NULL

and if I file the string in the .in.* the server echos the strings back

(This used to be commit 67e765b7e984d7aac2a7786b5bd0c80d10d6de5d)

15 years agor4308: [out,ref] pointer needs to set (don't corrupt the stack and segfault)
Stefan Metzmacher [Tue, 21 Dec 2004 09:33:12 +0000 (09:33 +0000)]
r4308: [out,ref] pointer needs to set (don't corrupt the stack and segfault)


PS: <tridge> "silly tridge forgot a out [ref] var" :-)
(This used to be commit a46c68a80001f5fe9d37cc4ce374071b6fe63076)

15 years agor4303: a bit more consistent help on privileges commands in smbclient
Andrew Tridgell [Tue, 21 Dec 2004 03:29:09 +0000 (03:29 +0000)]
r4303: a bit more consistent help on privileges commands in smbclient
(This used to be commit 2d2e9e6373be153f991ee899e9d66cd3979e309f)

15 years agor4302: fixed all of the annoying gtk warnings. The code all seems to still work, but
Andrew Tridgell [Tue, 21 Dec 2004 03:28:26 +0000 (03:28 +0000)]
r4302: fixed all of the annoying gtk warnings. The code all seems to still work, but
given my lack of gtk experience, there are no guarantees.
(This used to be commit 11277b38a473022eb59f896d5e23aa1e56786008)

15 years agor4299: Store REG_SZ, REG_EXPAND_SZ and REG_DWORD values in human-readable (and human...
Jelmer Vernooij [Tue, 21 Dec 2004 00:31:18 +0000 (00:31 +0000)]
r4299: Store REG_SZ, REG_EXPAND_SZ and REG_DWORD values in human-readable (and human-editable) format in
the ldb registry backend.
(This used to be commit 6eafd055d1a7d45734a0112228e18ee59d1f7867)

15 years agor4298: Update to credentials.h after feedback from Andrew Bartlett
Jelmer Vernooij [Tue, 21 Dec 2004 00:01:02 +0000 (00:01 +0000)]
r4298: Update to credentials.h after feedback from Andrew Bartlett
Move pack/unpack of values in ldb registry backend to seperate functions
(This used to be commit ceb4e92735f6dae96bb0b9d98211c9808159e56a)

15 years agor4288: don't use struct dcerpc_interface_table anymore in the
Stefan Metzmacher [Mon, 20 Dec 2004 14:37:54 +0000 (14:37 +0000)]
r4288: don't use struct dcerpc_interface_table anymore in the
main rpc server code. let the backends specify a ndr_push/ndr_pull function
like we already do with the dispatch() function.

this allows an interface implmentation to work as real proxy
without needing to know the idl for an interface that means
just the plain decrypted payload can be forwarded

If someone want to write such a backend, patches are wellcome

(This used to be commit a150bdf140d9165a05cbc7cac40b6e3c03a7bd3c)

15 years agor4284: fixed a problem with very large EA lists and OS/2 clients. These
Andrew Tridgell [Mon, 20 Dec 2004 03:12:09 +0000 (03:12 +0000)]
r4284: fixed a problem with very large EA lists and OS/2 clients. These
checks on allocations need to go in a lot more places, but at least
this is a start.
(This used to be commit 99b0dac2292d72e3a77f105e8f2ef5a3838d7e1b)

15 years agor4283: adding a privilege that an account already has is not an error
Andrew Tridgell [Sun, 19 Dec 2004 11:34:19 +0000 (11:34 +0000)]
r4283: adding a privilege that an account already has is not an error
(This used to be commit 2a4c562896aabe391d6f675433db2e519f0ce4b0)

15 years agor4282: removed a spurious error message now we remove index entries in the modify...
Andrew Tridgell [Sun, 19 Dec 2004 10:58:36 +0000 (10:58 +0000)]
r4282: removed a spurious error message now we remove index entries in the modify call
(This used to be commit 58fcc326241e73cc8a122e6130b5ff0d6a3b9232)

15 years agor4281: fixed an ldb indexing bug in ldb found by volker.
Andrew Tridgell [Sun, 19 Dec 2004 10:56:29 +0000 (10:56 +0000)]
r4281: fixed an ldb indexing bug in ldb found by volker.

index entries were not always being removed on modify
(This used to be commit 9c668e7b43dc2d82d3d639b64c53e887723ccba7)

15 years agor4280: added server side support for lsa_AddPrivilegesToAccount() and lsa_RemovePrivi...
Andrew Tridgell [Sun, 19 Dec 2004 07:50:19 +0000 (07:50 +0000)]
r4280: added server side support for lsa_AddPrivilegesToAccount() and lsa_RemovePrivilegesFromAccount()

these are the last of the server side privileges functions. We should
now have a complete privileges implementation.
(This used to be commit 76db300232f5557377dca059d17ea3c28a0a425c)