samba.git
4 years agowinbind client: avoid vicious cycle created by client retry
Uri Simchoni [Tue, 2 Jun 2015 21:36:27 +0000 (00:36 +0300)]
winbind client: avoid vicious cycle created by client retry

This patch cancels the retry policy of the winbind client.

When winbindd fails to respond to a request within 30 seconds,
the winbind client closes the connection and retries up to 10
times.

In some cases, delayed response is a result of multiple
requests from multiple clients piling up on the winbind domain
child process. Retrying just piles more and more requests,
creating a vicious cycle.

Even in the case of a single request taking long to complete,
there's no point in retrying because the retry request would just
wait for the current request to complete. Better to wait patiently.

There's one possible benefit in the retry, namely that winbindd typically
caches the results, and therefore a retry might take a cached result, so
the net effect of the retry may be to increase the timeout to 300 seconds.
But a more straightforward way to have a 300 second timeout is to modify the
timeout. Therefore the timeout is modified from 30 seconds to 300 seconds

(IMHO 300 seconds is too much, but we have "winbind rquest timeout"
with a default of 60 to make sure the request completes or fails
within 60 seconds)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agowinbindd: verify that client has closed the connection
Uri Simchoni [Thu, 25 Jun 2015 07:12:37 +0000 (10:12 +0300)]
winbindd: verify that client has closed the connection

A recent change was to remove a client if the client socket
has become readable. In this change, a check is added to
determine the source of the readbility (actual readability,
closed connection, or some other error), and a suitable
debug message is printed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agoasync_req: check for errors when monitoring socket for readability
Uri Simchoni [Thu, 25 Jun 2015 06:46:24 +0000 (09:46 +0300)]
async_req: check for errors when monitoring socket for readability

Add an option to wait_for_read_send(), so that the request, upon
calling back, report whether the socket actually contains data
or is in EOF/error state. EOF is signalled via the EPIPE error.

This is useful for clients which do not expect data to arrive but
wait for readability to detect a closed socket (i.e. they do not
intend to actually read the socket when it's readable). Actual data
arrival would indicate a bug in this case, so the check can
be used to print an error message.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agowinbindd: cleanup client connection if the client closes the connection
Uri Simchoni [Thu, 25 Jun 2015 05:59:20 +0000 (08:59 +0300)]
winbindd: cleanup client connection if the client closes the connection

This patch allows for early cleanup of client connections if the client
has given up.
Before this patch, any received request would be processed, and then only
upon transmitting the result to the client would winbindd find out the
client is no longer with us, possibly leading to a situation where the
same client tries over and over and increases the number of client
connections.

This patch monitors the client socket for readability while the request
is being processed, and closes the client connection if the socket
becomes readable. The client is not supposed to be writing anything to
the socket while it is waiting, so readability means either that the client
has closed the connection, or that it has broken the protocol.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agowinbindd: set file descriptor limit according to configuration
Uri Simchoni [Mon, 22 Jun 2015 03:38:04 +0000 (06:38 +0300)]
winbindd: set file descriptor limit according to configuration

Set the winbindd process file descriptor limit according to
the values that affect it in the configuration:
- Maximum number of clients
- Number of outgoing connections per domain

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11397

Signed-off-by: Uri Simchoni <urisimchoni@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agodocs:smb.conf: fix typo in 'smb encrypt' text.
Michael Adam [Wed, 15 Jul 2015 14:23:12 +0000 (16:23 +0200)]
docs:smb.conf: fix typo in 'smb encrypt' text.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Wed Jul 15 22:40:54 CEST 2015 on sn-devel-104

4 years agodocs: Documents length limitations for NetBIOS name
Andreas Schneider [Wed, 15 Jul 2015 11:22:40 +0000 (13:22 +0200)]
docs: Documents length limitations for NetBIOS name

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11401

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jul 15 19:35:48 CEST 2015 on sn-devel-104

4 years agoauth/credentials: if credentials have principal set, they are not anonymous anymore
Alexander Bokovoy [Thu, 7 May 2015 14:12:03 +0000 (14:12 +0000)]
auth/credentials: if credentials have principal set, they are not anonymous anymore

When dealing with Kerberos, we cannot consider credentials anonymous
if credentials were obtained properly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11265

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Stefan (metze) Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Wed Jul 15 16:32:55 CEST 2015 on sn-devel-104

4 years agoCID 1311772: Fix null pointer check
Andreas Schneider [Tue, 14 Jul 2015 09:46:22 +0000 (11:46 +0200)]
CID 1311772: Fix null pointer check

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 15 04:50:36 CEST 2015 on sn-devel-104

4 years agoCID 1311771: Fix a null pointer dereference
Andreas Schneider [Tue, 14 Jul 2015 09:44:58 +0000 (11:44 +0200)]
CID 1311771: Fix a null pointer dereference

We check for dir == NULL but dereference it during variable declaration.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoCID 1311767: Cast enum type to avoid compiler warnings
Andreas Schneider [Tue, 14 Jul 2015 09:40:31 +0000 (11:40 +0200)]
CID 1311767: Cast enum type to avoid compiler warnings

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoCID 1311764: Fix logical compare in if clause
Andreas Schneider [Tue, 14 Jul 2015 09:34:45 +0000 (11:34 +0200)]
CID 1311764: Fix logical compare in if clause

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoCID 1311763: Fix incorrect return value
Andreas Schneider [Tue, 14 Jul 2015 09:33:35 +0000 (11:33 +0200)]
CID 1311763: Fix incorrect return value

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4-torture: add test for ClusterControl to clusapi testsuite.
Günther Deschner [Thu, 9 Jul 2015 13:44:41 +0000 (15:44 +0200)]
s4-torture: add test for ClusterControl to clusapi testsuite.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
Autobuild-User(master): José A. Rivera <jarrpa@samba.org>
Autobuild-Date(master): Wed Jul 15 00:25:38 CEST 2015 on sn-devel-104

4 years agoclusapi: add and use clusapi_ClusterControlCode to IDL.
Günther Deschner [Thu, 9 Jul 2015 13:12:58 +0000 (15:12 +0200)]
clusapi: add and use clusapi_ClusterControlCode to IDL.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos3-rpcclient: add cmd_clusapi_get_cluster_version2.
Günther Deschner [Thu, 9 Jul 2015 13:56:44 +0000 (15:56 +0200)]
s3-rpcclient: add cmd_clusapi_get_cluster_version2.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: add test for clusapi_QueryValue.
Günther Deschner [Mon, 6 Jul 2015 11:59:27 +0000 (13:59 +0200)]
s4-torture: add test for clusapi_QueryValue.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agoclusapi: use winreg_AccessMask in clusapi.idl.
Günther Deschner [Fri, 3 Jul 2015 23:26:44 +0000 (01:26 +0200)]
clusapi: use winreg_AccessMask in clusapi.idl.

Make winreg_AccessMask public to access it outside winreg.idl.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: add more tests for dcerpc_clusapi_CreateEnum.
Günther Deschner [Fri, 3 Jul 2015 23:26:01 +0000 (01:26 +0200)]
s4-torture: add more tests for dcerpc_clusapi_CreateEnum.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: make sure to always seal the clusapi connection in witness test.
Günther Deschner [Wed, 1 Jul 2015 17:29:28 +0000 (19:29 +0200)]
s4-torture: make sure to always seal the clusapi connection in witness test.

clusapi only works via DCE/RPC sealed connections in Windows 2012R2.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: do some more inspection on expected witness_AsyncNotify replies.
Günther Deschner [Wed, 1 Jul 2015 13:40:06 +0000 (15:40 +0200)]
s4-torture: do some more inspection on expected witness_AsyncNotify replies.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: add test for ClusterControl to clusapi testsuite.
Günther Deschner [Wed, 1 Jul 2015 13:14:19 +0000 (15:14 +0200)]
s4-torture: add test for ClusterControl to clusapi testsuite.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>
4 years agos4-torture: use smb_krb5_principal_set_type() in lsa forest krb5 tests.
Günther Deschner [Thu, 9 Jul 2015 16:05:12 +0000 (18:05 +0200)]
s4-torture: use smb_krb5_principal_set_type() in lsa forest krb5 tests.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Jul 14 19:15:59 CEST 2015 on sn-devel-104

4 years agos4-torture: use krb5_error in lsa forest trust tests.
Günther Deschner [Thu, 9 Jul 2015 16:02:31 +0000 (18:02 +0200)]
s4-torture: use krb5_error in lsa forest trust tests.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos4-torture: use smb_krb5_free_error() in lsa forest krb5 tests.
Günther Deschner [Thu, 9 Jul 2015 16:01:34 +0000 (18:01 +0200)]
s4-torture: use smb_krb5_free_error() in lsa forest krb5 tests.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agolib/krb5: add new KRB5_ERROR_CODE() abstraction macro.
Günther Deschner [Thu, 9 Jul 2015 16:00:49 +0000 (18:00 +0200)]
lib/krb5: add new KRB5_ERROR_CODE() abstraction macro.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos4-torture: use smb_krb5_principal_get_type in lsa forest krb5 tests.
Günther Deschner [Thu, 9 Jul 2015 16:00:13 +0000 (18:00 +0200)]
s4-torture: use smb_krb5_principal_get_type in lsa forest krb5 tests.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos4-torture: use smb_krb5_make_principal() in lsa forest krb5 tests.
Günther Deschner [Thu, 9 Jul 2015 15:59:28 +0000 (17:59 +0200)]
s4-torture: use smb_krb5_make_principal() in lsa forest krb5 tests.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agos3: tests: Add blackbox test for scopy.
Jeremy Allison [Mon, 13 Jul 2015 21:15:45 +0000 (14:15 -0700)]
s3: tests: Add blackbox test for scopy.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Jul 14 16:10:44 CEST 2015 on sn-devel-104

4 years agodocs: Document new scopy command.
Jeremy Allison [Fri, 10 Jul 2015 17:29:01 +0000 (10:29 -0700)]
docs: Document new scopy command.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agos3:client: Add "scopy" cmd to perform Server Side copy using smbclient.
Anubhav Rakshit [Thu, 25 Jun 2015 06:07:18 +0000 (11:37 +0530)]
s3:client: Add "scopy" cmd to perform Server Side copy using smbclient.

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agoctdb-daemon: Return correct sequence number for CONTROL_GET_DB_SEQNUM
Amitay Isaacs [Tue, 14 Jul 2015 06:54:59 +0000 (16:54 +1000)]
ctdb-daemon: Return correct sequence number for CONTROL_GET_DB_SEQNUM

Due to the missing cast of uint64_t, CONTROL_GET_DB_SEQNUM always returned
seqnum <= 256.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11398

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Jul 14 13:03:25 CEST 2015 on sn-devel-104

4 years agoctdb-scripts: Implement registration in nfs-linux-kernel-callout
Martin Schwenke [Tue, 14 Jul 2015 02:13:58 +0000 (12:13 +1000)]
ctdb-scripts: Implement registration in nfs-linux-kernel-callout

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Add registration for CTDB_NFS_CALLOUT operations
Martin Schwenke [Tue, 14 Jul 2015 02:11:39 +0000 (12:11 +1000)]
ctdb-scripts: Add registration for CTDB_NFS_CALLOUT operations

This is an optimisation to avoid forking the callout for operations
that are not implemented.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Add some simple tests for CTDB_NFS_CALLOUT
Martin Schwenke [Tue, 14 Jul 2015 00:59:55 +0000 (10:59 +1000)]
ctdb-tests: Add some simple tests for CTDB_NFS_CALLOUT

One always passes, the other fails early.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Add portmapper NFS .check file
Martin Schwenke [Mon, 13 Jul 2015 11:00:29 +0000 (21:00 +1000)]
ctdb-scripts: Add portmapper NFS .check file

Unhealthy after 1 failed attempt to contact the portmapper.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Move NFS support functions to 60.nfs
Martin Schwenke [Mon, 13 Jul 2015 05:22:23 +0000 (15:22 +1000)]
ctdb-scripts: Move NFS support functions to 60.nfs

Now that there is only a single NFS eventscript, other eventscripts no
longer need to load all of this.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Drop configuration variable CTDB_NFS_DUMP_STUCK_THREADS
Martin Schwenke [Mon, 13 Jul 2015 04:54:07 +0000 (14:54 +1000)]
ctdb-scripts: Drop configuration variable CTDB_NFS_DUMP_STUCK_THREADS

This is now handled by passing the desired number of threads to the
command specified in the dump_stuck_threads variable in .check files.

Remove unused function nfs_dump_some_threads().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Remove unused function startstop_ganesha()
Martin Schwenke [Mon, 13 Jul 2015 04:49:02 +0000 (14:49 +1000)]
ctdb-scripts: Remove unused function startstop_ganesha()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Remove 60.ganesha, replace with callout for 60.nfs
Martin Schwenke [Wed, 1 Jul 2015 08:32:35 +0000 (18:32 +1000)]
ctdb-scripts: Remove 60.ganesha, replace with callout for 60.nfs

This isn't a straightforward move of code from 60.ganesha to the
callout.  Simplifications have been made to allow better
interoperation with the new NFS checking logic.

The following configuration variables have been removed:

  CTDB_GANESHA_REC_SUBDIR

    Edit NFS ganesha callout to change this location

  CTDB_NFS_SERVER_MODE, NFS_SERVER_MODE

    Use CTDB_NFS_CALLOUT instead

  CTDB_NFS_SKIP_KNFSD_ALIVE_CHECK, CTDB_SKIP_GANESHA_NFSD_CHECK

    Disable the corresponding .check file instead

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Extend NFS .check files with service_check_cmd variable
Martin Schwenke [Mon, 13 Jul 2015 01:30:51 +0000 (11:30 +1000)]
ctdb-scripts: Extend NFS .check files with service_check_cmd variable

$service_check_cmd specifies a command to run instead of the regular
rpcinfo-based check.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Remove functions startstop_nfs() and startstop_nfslock()
Martin Schwenke [Wed, 24 Jun 2015 12:28:33 +0000 (22:28 +1000)]
ctdb-scripts: Remove functions startstop_nfs() and startstop_nfslock()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Remove configuration variable CTDB_MONITOR_NFS_THREAD_COUNT
Martin Schwenke [Mon, 13 Jul 2015 05:02:48 +0000 (15:02 +1000)]
ctdb-scripts: Remove configuration variable CTDB_MONITOR_NFS_THREAD_COUNT

This is now always enabled.  If nfsd thread monitoring is not required
then make CTDB_NFS_CALLOUT point to a wrapper around
nfs-linux-kernel-callout that does not implement "monitor-post".

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Parameterise 60.nfs with $CTDB_NFS_CALLOUT
Martin Schwenke [Wed, 24 Jun 2015 11:36:14 +0000 (21:36 +1000)]
ctdb-scripts: Parameterise 60.nfs with $CTDB_NFS_CALLOUT

The goal is to have a single NFS eventscript.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Remove old NFS checking code
Martin Schwenke [Fri, 19 Jun 2015 06:54:33 +0000 (16:54 +1000)]
ctdb-scripts: Remove old NFS checking code

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Switch NFS checks to new style
Martin Schwenke [Fri, 19 Jun 2015 06:35:12 +0000 (16:35 +1000)]
ctdb-scripts: Switch NFS checks to new style

Note that the 60.ganesha RPC checks need to be identical to those in
the nfs-checks.d/ directory.  This is because the NFS unit test
infrastructure checks output against what should be produced by the
checks in nfs-checks.d/.  This is a minor issue, since one of the aims
of this work is to remove the need for a separate 60.ganesha.

In most cases configuration variable CTDB_NFS_DUMP_STUCK_THREADS is
now ignored.  This is now handled by passing the desired number of
threads to the command specified in the service_debug_cmd variable in
a .check file.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Add new NFS service checking infrastructure
Martin Schwenke [Wed, 17 Jun 2015 10:53:12 +0000 (20:53 +1000)]
ctdb-scripts: Add new NFS service checking infrastructure

Provides a new extensible format for .check files, using simple
variables instead of the unwieldy extended test(1) syntax now used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Factor out new function ctdb_counter_get()
Martin Schwenke [Sat, 11 Jul 2015 01:02:54 +0000 (11:02 +1000)]
ctdb-scripts: Factor out new function ctdb_counter_get()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Move "ERROR:" prefix out of ctdb_check_rpc()
Martin Schwenke [Mon, 29 Jun 2015 01:22:48 +0000 (11:22 +1000)]
ctdb-scripts: Move "ERROR:" prefix out of ctdb_check_rpc()

There will be warnings in addition to errors.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Clean up ctdb_check_rpc()
Martin Schwenke [Wed, 17 Jun 2015 10:24:33 +0000 (20:24 +1000)]
ctdb-scripts: Clean up ctdb_check_rpc()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: NFS RPC checks should be simple and consistent
Martin Schwenke [Wed, 17 Jun 2015 09:35:21 +0000 (19:35 +1000)]
ctdb-scripts: NFS RPC checks should be simple and consistent

Change status, nlockmgr, mountd, rquotad to be unhealthy after 6
rpcinfo check failures and do a verbose restart after every 2
failures.  Change 60.ganesha for consistency, since 60.ganesha tests
are broken and depend on the consistency.

Apart from the consistency aspect, the check infrastructure will soon
be simplified so that it only allows the equivalent of "unhealthy" and
"verbose restart:b" actions.

Update tests to have a corresponding numbers of iterations.  Run 1
extra iteration in most tests to check there are no unexpected
behaviour changes after the designated number of iterations completes.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: setup_nfs() should mark nfslock as started/stopped
Martin Schwenke [Wed, 17 Jun 2015 10:51:23 +0000 (20:51 +1000)]
ctdb-tests: setup_nfs() should mark nfslock as started/stopped

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Remove function iterate_test()
Martin Schwenke [Wed, 17 Jun 2015 07:26:21 +0000 (17:26 +1000)]
ctdb-tests: Remove function iterate_test()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Remove remaining uses of iterate_test()
Martin Schwenke [Wed, 17 Jun 2015 07:25:02 +0000 (17:25 +1000)]
ctdb-tests: Remove remaining uses of iterate_test()

They are contrived and hard to read.  Better to just enumerate the few
sub-tests in these testcases.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: New NFS test with all services up and 10 iterations
Martin Schwenke [Thu, 18 Jun 2015 04:11:55 +0000 (14:11 +1000)]
ctdb-tests: New NFS test with all services up and 10 iterations

A useful baseline test to ensure that certain things (e.g. rpcinfo)
aren't consistently broken.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Allow 2nd argument of nfs_iterate_test() to be null
Martin Schwenke [Thu, 18 Jun 2015 04:08:02 +0000 (14:08 +1000)]
ctdb-tests: Allow 2nd argument of nfs_iterate_test() to be null

This means that required result will not be calculated on each
iteration.  This is useful in baseline tests where, say, all
iterations should succeed and produce no output.  This is useful for
confirming that the eventscript and test infrastructure is working
correctly.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Automate expected NFS test results instead of hard-coding
Martin Schwenke [Wed, 17 Jun 2015 07:13:31 +0000 (17:13 +1000)]
ctdb-tests: Automate expected NFS test results instead of hard-coding

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Update NFS tests to use nfs_iterate_test()
Martin Schwenke [Wed, 17 Jun 2015 07:12:25 +0000 (17:12 +1000)]
ctdb-tests: Update NFS tests to use nfs_iterate_test()

... instead of iterate_test()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: New function nfs_iterate_test()
Martin Schwenke [Wed, 17 Jun 2015 07:05:44 +0000 (17:05 +1000)]
ctdb-tests: New function nfs_iterate_test()

Much clearer than using iterate_test() for this purpose.  This also
does failover counting by calling rpcinfo in each iteration.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: rpc_set_service_failure_response() should take RPC service name
Martin Schwenke [Wed, 17 Jun 2015 06:45:28 +0000 (16:45 +1000)]
ctdb-tests: rpc_set_service_failure_response() should take RPC service name

... not a process name

Update the tests that matter.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Don't flag failure when there are no rpcinfo check failures
Martin Schwenke [Wed, 17 Jun 2015 06:44:20 +0000 (16:44 +1000)]
ctdb-tests: Don't flag failure when there are no rpcinfo check failures

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Default fail count for rpc_set_service_failure_response() is 1
Martin Schwenke [Mon, 15 Jun 2015 10:12:31 +0000 (20:12 +1000)]
ctdb-tests: Default fail count for rpc_set_service_failure_response() is 1

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Factor out stack dumping and background marking code
Martin Schwenke [Mon, 15 Jun 2015 10:04:16 +0000 (20:04 +1000)]
ctdb-tests: Factor out stack dumping and background marking code

This makes the code that uses it easier to modify.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Allow a new monitor event to cancel one already in progress
Martin Schwenke [Tue, 14 Jul 2015 03:43:14 +0000 (13:43 +1000)]
ctdb-daemon: Allow a new monitor event to cancel one already in progress

Before commit cbffbb7c2f406fc1d8ebad3c531cc2757232690e this was
possible and some users depend on this behaviour.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Improve error messages when eventscript control is cancelled
Martin Schwenke [Mon, 6 Jul 2015 02:02:00 +0000 (12:02 +1000)]
ctdb-daemon: Improve error messages when eventscript control is cancelled

Warn specifically about cancellation instead of printing a generic
error message.  Also pass back an error message for the tool - it
could just rely on the status but it already looks at the error
message.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tools: Avoiding printing "(null)" on "ctdb eventscript" error
Martin Schwenke [Mon, 6 Jul 2015 01:48:28 +0000 (11:48 +1000)]
ctdb-tools: Avoiding printing "(null)" on "ctdb eventscript" error

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-daemon: Avoid double-free during monitor cancellation
Amitay Isaacs [Fri, 10 Jul 2015 04:02:29 +0000 (14:02 +1000)]
ctdb-daemon: Avoid double-free during monitor cancellation

The eventscript state should never be freed externally, so it should
never be allocated off a temporary context.  It will either be freed
by the handler or in the cancellation code.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Pair-programmed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agoctdb-tests: Add some 10.interfaces VLAN tests
Martin Schwenke [Wed, 8 Jul 2015 12:22:09 +0000 (22:22 +1000)]
ctdb-tests: Add some 10.interfaces VLAN tests

One without a bond, one with a bond.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Add VLAN support to the "ip link" stub
Martin Schwenke [Wed, 8 Jul 2015 12:14:51 +0000 (22:14 +1000)]
ctdb-tests: Add VLAN support to the "ip link" stub

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: Interface number in "ip link show" stub defaults to 42
Martin Schwenke [Wed, 8 Jul 2015 11:39:51 +0000 (21:39 +1000)]
ctdb-tests: Interface number in "ip link show" stub defaults to 42

It needs to have a default for the standalone case, when it is not run
in a loop inside "ip addr show".

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Support monitoring of interestingly named VLANs on bonds
Martin Schwenke [Wed, 8 Jul 2015 11:23:48 +0000 (21:23 +1000)]
ctdb-scripts: Support monitoring of interestingly named VLANs on bonds

VLAN interfaces on bonds with a name other than <iface>.<id>@<iface>
are not currently supported.  That is, where the VLAN name isn't based
on the underlying bond name.  Such VLAN interfaces can be created with
the "ip link" command, as opposed to the "vconfig" command, or by
renaming a VLAN interface.

This is improved by determining the underlying interface name for a
VLAN from the output of "ip link".

No serious attempt is made to support VLANs with '@' in their name,
although this seems to be legal.  Why would you do that?

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Fix regression in VLAN interface support
Martin Schwenke [Tue, 7 Jul 2015 10:49:38 +0000 (20:49 +1000)]
ctdb-scripts: Fix regression in VLAN interface support

Commit 6471541d6d2bc9f2af0ff92b280abbd1d933cf88 broke support for VLAN
interfaces.  Releasing a public IP address depends on
ip_maskbits_iface() and for a VLAN interface this will return an
interface of the form <vlan>@<iface>, which can't be fed back into
"ip" commands.

Update ip_maskbits_iface() to drop the '@' and everything after it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reported-by: Jan Schwaratzki <jschwaratzki@ddn.com>
4 years agoctdbd_conn: Move release_ip handling into process.c
Volker Lendecke [Tue, 23 Jun 2015 17:07:44 +0000 (19:07 +0200)]
ctdbd_conn: Move release_ip handling into process.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Jul 14 09:56:25 CEST 2015 on sn-devel-104

4 years agoctdbd_conn: Do an early return from ctdb_read_req
Volker Lendecke [Tue, 23 Jun 2015 15:04:59 +0000 (17:04 +0200)]
ctdbd_conn: Do an early return from ctdb_read_req

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Return early from ctdbd_msg_call_back
Volker Lendecke [Tue, 23 Jun 2015 14:59:00 +0000 (16:59 +0200)]
ctdbd_conn: Return early from ctdbd_msg_call_back

... if the callback returns != 0

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Make register_with_ctdbd use an int-returning callback
Volker Lendecke [Tue, 23 Jun 2015 14:55:09 +0000 (16:55 +0200)]
ctdbd_conn: Make register_with_ctdbd use an int-returning callback

This will allow an early return from ctdbd_msg_call_back so that we can also
handle CTDB_SRVID_RELEASE_IP via register_with_ctdbd.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Convert ctdb_read_req to return 0/errno
Volker Lendecke [Fri, 19 Jun 2015 09:47:01 +0000 (11:47 +0200)]
ctdbd_conn: Convert ctdb_read_req to return 0/errno

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Convert ctdb_handle_message to return 0/errno
Volker Lendecke [Fri, 19 Jun 2015 09:47:01 +0000 (11:47 +0200)]
ctdbd_conn: Convert ctdb_handle_message to return 0/errno

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Make ctdb_read_packet return 0/errno
Volker Lendecke [Sat, 11 Jul 2015 10:23:22 +0000 (12:23 +0200)]
ctdbd_conn: Make ctdb_read_packet return 0/errno

A little less dependencies

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Rename "ret"->"ok"
Volker Lendecke [Sat, 11 Jul 2015 10:21:55 +0000 (12:21 +0200)]
ctdbd_conn: Rename "ret"->"ok"

We'll need "ret" soon

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdbd_conn: Fix a memleak
Volker Lendecke [Wed, 1 Jul 2015 15:00:43 +0000 (17:00 +0200)]
ctdbd_conn: Fix a memleak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib/util/charset: reduce loglevel for push_ucs2_talloc error
Ralph Boehme [Mon, 13 Jul 2015 10:51:46 +0000 (12:51 +0200)]
lib/util/charset: reduce loglevel for push_ucs2_talloc error

push_ucs2_talloc() may have failed because of EILSEQ, not a failing
malloc. Log the failure with DBG_WARNING instead of level 0.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 14 03:59:05 CEST 2015 on sn-devel-104

4 years agotorture-notify: Give nonrecursive updates 200ms
Volker Lendecke [Sun, 12 Jul 2015 08:59:38 +0000 (10:59 +0200)]
torture-notify: Give nonrecursive updates 200ms

This is in line with the recursive updates before.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Jul 13 15:00:26 CEST 2015 on sn-devel-104

4 years agovfs_fruit: Fix the 32-bit build
Volker Lendecke [Sat, 11 Jul 2015 11:44:05 +0000 (13:44 +0200)]
vfs_fruit: Fix the 32-bit build

"z" is only for size_t, here we have off_t

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jul 13 11:53:47 CEST 2015 on sn-devel-104

4 years agoctdb-daemon: Remove control CTDB_CONTROL_SET_CALL
Amitay Isaacs [Thu, 9 Jul 2015 12:33:23 +0000 (22:33 +1000)]
ctdb-daemon: Remove control CTDB_CONTROL_SET_CALL

This has not been used for a long time.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jul 10 23:41:18 CEST 2015 on sn-devel-104

4 years agoctdb-daemon: Fix valgrind invalid read error in db_statistics control
Amitay Isaacs [Thu, 9 Jul 2015 04:55:59 +0000 (14:55 +1000)]
ctdb-daemon: Fix valgrind invalid read error in db_statistics control

  ==20761== Invalid read of size 8
  ==20761==    at 0x11BE30: ctdb_ctrl_dbstatistics (ctdb_client.c:1286)
  ==20761==    by 0x12BA89: control_dbstatistics (ctdb.c:713)
  ==20761==    by 0x1312E0: main (ctdb.c:6543)
  ==20761==  Address 0x713b0d0 is 0 bytes after a block of size 560 alloc'd
  ==20761==    at 0x4C27A2E: malloc (vg_replace_malloc.c:270)
  ==20761==    by 0x5CB0954: _talloc_memdup (talloc.c:615)
  ==20761==    by 0x11395C: ctdb_control_recv (ctdb_client.c:1146)
  ==20761==    by 0x11BDD7: ctdb_ctrl_dbstatistics (ctdb_client.c:1265)
  ==20761==    by 0x12BA89: control_dbstatistics (ctdb.c:713)
  ==20761==    by 0x1312E0: main (ctdb.c:6543)

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
4 years agodfs_server: Use multi-byte string handling
Robin McCorkell [Thu, 9 Jul 2015 20:20:13 +0000 (21:20 +0100)]
dfs_server: Use multi-byte string handling

Pre-empt a bug with multi-byte DFS pathname handling by using strchr_m()

Signed-off-by: Robin McCorkell <rmccorkell@karoshi.org.uk>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Jul 10 20:35:47 CEST 2015 on sn-devel-104

4 years agoFix MSDFS with POSIX paths in vfs_dfs_samba4
Robin McCorkell [Thu, 9 Jul 2015 20:20:12 +0000 (21:20 +0100)]
Fix MSDFS with POSIX paths in vfs_dfs_samba4

Allow for POSIX path separators when parsing a DFS query string

Signed-off-by: Robin McCorkell <rmccorkell@karoshi.org.uk>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
4 years agoscript/librelease.sh: use download-master.samba.org:~ftp/pub/ for uploading
Stefan Metzmacher [Fri, 10 Jul 2015 09:47:31 +0000 (11:47 +0200)]
script/librelease.sh: use download-samba.org:~ftp/pub/ for uploading

master.samba.org might be removed in future.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jul 10 16:38:20 CEST 2015 on sn-devel-104

4 years agolibsmb: Implement smbc_notify
Volker Lendecke [Fri, 26 Jun 2015 11:36:43 +0000 (13:36 +0200)]
libsmb: Implement smbc_notify

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jul 10 09:35:13 CEST 2015 on sn-devel-104

4 years agodfs_server: Fix whitespace
Robin McCorkell [Thu, 9 Jul 2015 14:28:05 +0000 (15:28 +0100)]
dfs_server: Fix whitespace

Signed-off-by: Robin McCorkell <rmccorkell@karoshi.org.uk>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoReplace random() and related calls with generate_random_buffer()
Robin McCorkell [Thu, 9 Jul 2015 14:28:05 +0000 (15:28 +0100)]
Replace random() and related calls with generate_random_buffer()

Result: better seeded random numbers that are cryptographically secure
(not that it matters in this case)

Please let it be right this time...

Signed-off-by: Robin McCorkell <rmccorkell@karoshi.org.uk>
Reviewed-by: Volker Lendecke <Volker.Lendecke@SerNet.DE>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcontrol: Set internal log level to 0
Christof Schmitt [Wed, 8 Jul 2015 22:16:33 +0000 (15:16 -0700)]
smbcontrol: Set internal log level to 0

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbstatus: Set internal log level to 0
Christof Schmitt [Wed, 8 Jul 2015 22:15:38 +0000 (15:15 -0700)]
smbstatus: Set internal log level to 0

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agorpcclient: Set internal log level to 0
Christof Schmitt [Wed, 8 Jul 2015 22:14:54 +0000 (15:14 -0700)]
rpcclient: Set internal log level to 0

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agorpc_server: Fix CID 1311342 Null pointer dereferences (REVERSE_INULL)
Volker Lendecke [Thu, 9 Jul 2015 17:30:07 +0000 (19:30 +0200)]
rpc_server: Fix CID 1311342 Null pointer dereferences (REVERSE_INULL)

elem was dereferenced already a few lines above

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Fri Jul 10 01:01:36 CEST 2015 on sn-devel-104

4 years agorpc_server: Fix CID 1311341 Integer handling issues (OVERFLOW_BEFORE_WIDEN)
Volker Lendecke [Thu, 9 Jul 2015 17:27:41 +0000 (19:27 +0200)]
rpc_server: Fix CID 1311341 Integer handling issues (OVERFLOW_BEFORE_WIDEN)

Quoting the full message:

Potentially overflowing expression "total_octets * 8U" with type "unsigned int"
(32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a
context that expects an expression of type "uint64_t" (64 bits, unsigned).

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agorpc_server: Fix CID 1311340 Null pointer dereferences (NULL_RETURNS)
Volker Lendecke [Thu, 9 Jul 2015 17:24:18 +0000 (19:24 +0200)]
rpc_server: Fix CID 1311340 Null pointer dereferences (NULL_RETURNS)

In practice this might not be relevant, but better be safe.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agorpc_server: Fix CID 1311339 Error handling issues (CHECKED_RETURN)
Volker Lendecke [Thu, 9 Jul 2015 17:22:59 +0000 (19:22 +0200)]
rpc_server: Fix CID 1311339 Error handling issues (CHECKED_RETURN)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
4 years agosmbd: Fix CID 1311338 Error handling issues (CHECKED_RETURN)
Volker Lendecke [Thu, 9 Jul 2015 17:20:46 +0000 (19:20 +0200)]
smbd: Fix CID 1311338 Error handling issues (CHECKED_RETURN)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>