samba.git
17 years agoAdd bin/libbigballofmud.a non-shared library. A bit easier to link to
Martin Pool [Thu, 13 Mar 2003 07:05:10 +0000 (07:05 +0000)]
Add bin/libbigballofmud.a non-shared library.  A bit easier to link to
for testing than the .so.  (http://www.laputan.org/mud/mud.html)
(This used to be commit 386087d77f836b8133afc977c9c3e8e7845125dc)

17 years agoIn Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
Martin Pool [Thu, 13 Mar 2003 06:18:18 +0000 (06:18 +0000)]
In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
etc.  So check for that as well as the old names when including macros
and conditionally defining -DVALGRIND.
(This used to be commit c9151c7b1113e2f01bd33d4dd301a2e7e2040b35)

17 years agoIn Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
Martin Pool [Thu, 13 Mar 2003 06:16:51 +0000 (06:16 +0000)]
In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
etc.  So check for that as well as the old names.
(This used to be commit 1ffa4d75b75979b8abb409634212ce43a0826467)

17 years agoAdded chainlock, chainunlock, lock_bystring and unlock_bystring methods.
Tim Potter [Thu, 13 Mar 2003 06:09:18 +0000 (06:09 +0000)]
Added chainlock, chainunlock, lock_bystring and unlock_bystring methods.
(This used to be commit cd5c47f47379a8c4021771ec28a9da0085f80d98)

17 years agoFixed crash bug when calling tdb_unlockkeys() with no locked keys.
Tim Potter [Thu, 13 Mar 2003 05:52:49 +0000 (05:52 +0000)]
Fixed crash bug when calling tdb_unlockkeys() with no locked keys.

woot!
(This used to be commit eb432700c0010e536be3a0703f152c533357b851)

17 years agoshow which files we fail to create in the casetable test
Andrew Tridgell [Thu, 13 Mar 2003 04:36:32 +0000 (04:36 +0000)]
show which files we fail to create in the casetable test
(This used to be commit d40e3747cfa2994349aa84568f7b79457341a058)

17 years agofixed the unmarshalling of the queryaliasmem SAMR call
Andrew Tridgell [Thu, 13 Mar 2003 04:35:15 +0000 (04:35 +0000)]
fixed the unmarshalling of the queryaliasmem SAMR call
(This used to be commit 80c45434092a881fe2c9ae7f90856deea4722cb0)

17 years agowin2000 can take much longer than the specified time to respond to a
Andrew Tridgell [Thu, 13 Mar 2003 04:34:31 +0000 (04:34 +0000)]
win2000 can take much longer than the specified time to respond to a
lock - so to make the torture tests valid I give it a grace time of 10
seconds instead of 2
(This used to be commit c9c9e9eb26ec3042395637d14a6661d04a629ccc)

17 years agoChange size parameters from signed to unsigned to fix up warnings.
Jeremy Allison [Wed, 12 Mar 2003 22:24:12 +0000 (22:24 +0000)]
Change size parameters from signed to unsigned to fix up warnings.
Jeremy.
(This used to be commit 2e9880ef7c259b67eb75edc8098b734c3b7b22c1)

17 years agofixed a strcat noticed by metze
Andrew Tridgell [Wed, 12 Mar 2003 21:01:25 +0000 (21:01 +0000)]
fixed a strcat noticed by metze
(This used to be commit db3ad0dbe0bca729f98ca5d5a698388fe086daf2)

17 years agoEnsure we count the length correctly in mangle_map.
Jeremy Allison [Wed, 12 Mar 2003 19:08:01 +0000 (19:08 +0000)]
Ensure we count the length correctly in mangle_map.
Jeremy.
(This used to be commit 596705198c555568da208f59008ab87c5164bfb4)

17 years agoadding some initiaial code to sert %a to Win2K3 (using Native LanMan string from...
Gerald Carter [Wed, 12 Mar 2003 15:40:43 +0000 (15:40 +0000)]
adding some initiaial code to sert %a to Win2K3 (using Native LanMan string from .NET RC2)
(This used to be commit 4c823e61d14a33344deb887043b60b2e3c83416f)

17 years agoAdd const
Andrew Bartlett [Wed, 12 Mar 2003 11:00:02 +0000 (11:00 +0000)]
Add const
(This used to be commit 147a0c8b13d20e06c557fb817a36fddf9a920d65)

17 years ago - Fix a double-free (I can't say I understand the code, but it matches the other
Andrew Bartlett [Wed, 12 Mar 2003 10:56:55 +0000 (10:56 +0000)]
 - Fix a double-free (I can't say I understand the code, but it matches the other
cases and keeps valgrind quiet).

 - Add static

Andrew Bartlett
(This used to be commit e9da9c500b96a828d744e7a1c64427fc01153310)

17 years agoPatch from Ken Cross <kcross@nssolutions.com> to take a username in the form
Andrew Bartlett [Wed, 12 Mar 2003 10:36:14 +0000 (10:36 +0000)]
Patch from Ken Cross <kcross@nssolutions.com> to take a username in the form
of user@realm for kerberos logins.

Andrew Bartlett
(This used to be commit ce013dc13e9e77b5cb9b2d5a4b76d54f91614e6c)

17 years agoUpdate for new version of ComfyChair: some methods are renamed to be
Martin Pool [Wed, 12 Mar 2003 07:17:39 +0000 (07:17 +0000)]
Update for new version of ComfyChair: some methods are renamed to be
more consistent, and it now looks at command-line arguments to work
out what to do.

Run this program to get a quick demonstration of what ComfyChair does.
(This used to be commit 9b0c59a10707b2bbe3837d718e5030a6cdf19bfa)

17 years agoNew import of ComfyChair, many changes
Martin Pool [Wed, 12 Mar 2003 07:14:03 +0000 (07:14 +0000)]
New import of ComfyChair, many changes
(This used to be commit e84046e769a518fa1970827f4dcb8284ba9b9952)

17 years agoImport Samba Testing Framework code from private CVS module.
Martin Pool [Wed, 12 Mar 2003 03:08:28 +0000 (03:08 +0000)]
Import Samba Testing Framework code from private CVS module.
(This used to be commit 0effe832a48f0c51d50675558cc2744e815d68c7)

17 years agoImport design notes by martin and tpot from ComfyChair and stf modules.
Martin Pool [Wed, 12 Mar 2003 03:07:46 +0000 (03:07 +0000)]
Import design notes by martin and tpot from ComfyChair and stf modules.
(This used to be commit f923729ca37c18fd58943015a530607c05e96659)

17 years agoImport ComfyChair framework from trunk.
Martin Pool [Wed, 12 Mar 2003 03:06:42 +0000 (03:06 +0000)]
Import ComfyChair framework from trunk.
(This used to be commit a7fb1fcc72ffe3cc2aa9c5abfcbd8197e7610167)

17 years agoStart importing the Python testing framework that Tim and I have been
Martin Pool [Wed, 12 Mar 2003 03:04:37 +0000 (03:04 +0000)]
Start importing the Python testing framework that Tim and I have been
working on into the main Samba tree.
(This used to be commit f3b77aae13df2559a81db6453d04e0fe8004cd52)

17 years agoUpdate usage message.
Martin Pool [Wed, 12 Mar 2003 02:58:45 +0000 (02:58 +0000)]
Update usage message.
(This used to be commit 17f01f6959fb79ba11a56d6869ec9789e3ee2f74)

17 years agoAdd example of string overflow which is now caught in developer mode.
Martin Pool [Wed, 12 Mar 2003 02:57:48 +0000 (02:57 +0000)]
Add example of string overflow which is now caught in developer mode.
(This used to be commit dcf1705782f5d589120624c90b695b81a0332e6b)

17 years agoWe use unsigned now, so use %u.
Jeremy Allison [Tue, 11 Mar 2003 20:57:41 +0000 (20:57 +0000)]
We use unsigned now, so use %u.
Jeremy.
(This used to be commit 01727b0296ee407e49444b9d9c4e7993892cb537)

17 years agoFix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.
Jeremy Allison [Tue, 11 Mar 2003 18:10:36 +0000 (18:10 +0000)]
Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.
Jeremy.
(This used to be commit 69becdb563b2620513931811a6695481bebcceed)

17 years agoThis patch attemptes to clean up winbindd's mutex locking.
Andrew Bartlett [Tue, 11 Mar 2003 11:28:59 +0000 (11:28 +0000)]
This patch attemptes to clean up winbindd's mutex locking.

The current locking scheme in winbind is a complete mess - indeed, the
next step should be to push the locking into cli_full_connection(), but
I'll leave it for now.

This patch works on the noted behaviour that 2 parts of the connection
process need protection - and independent protection.  Tim Potter did
some work on this a little while back, verifying the second case.

The two cases are:
 - between connect() and first session setup
 - during the auth2 phase of the netlogon pipe setup.

I've removed the counter on the lock, as I fail to see what it gains us.

This patch also adds 'anonymous fallback' to our winbindd -> DC connection.

If the authenticated connection fails (wbinfo -A specifed) - say that
account isn't trusted by a trusted DC - then we try an anonymous.

Both tpot and mbp like the patch.

Andrew Bartlett
(This used to be commit 0620320002082298a15cbba72bd79aecfc607947)

17 years agosecurity=domain and domain logons = yes should be a BDC (of sorts).
Andrew Bartlett [Tue, 11 Mar 2003 10:53:46 +0000 (10:53 +0000)]
security=domain and domain logons = yes should be a BDC (of sorts).

Matches 2.2

Andrew Bartlett
(This used to be commit f6497fd639c5bb7d61eda0286c4c3c38609933b0)

17 years agoSome further tought on the server role issue - try not to break it compeatly.
Andrew Bartlett [Tue, 11 Mar 2003 10:13:57 +0000 (10:13 +0000)]
Some further tought on the server role issue - try not to break it compeatly.

Andrew Bartlett
(This used to be commit 4c6a2d8d28d1752d7fee52d253ce2829bd0a0671)

17 years agoAfter 'consultation' with idra, this is how I think the server roles should work...
Andrew Bartlett [Tue, 11 Mar 2003 10:06:34 +0000 (10:06 +0000)]
After 'consultation' with idra, this is how I think the server roles should work...

Andrew Bartlett
(This used to be commit 5c1f1005907bf50b809dfae1f8251c7122103098)

17 years agoThis is how combination of domain logons and security parameter best combine.
Simo Sorce [Tue, 11 Mar 2003 09:16:37 +0000 (09:16 +0000)]
This is how combination of domain logons and security parameter best combine.
Comments wellcome.

Simo.
(This used to be commit e1431424e7603d946f63cfe7fe669b0b32ac8095)

17 years agoRemove valgrind_strlen function, hopefully no longer needed with
Martin Pool [Tue, 11 Mar 2003 07:25:48 +0000 (07:25 +0000)]
Remove valgrind_strlen function, hopefully no longer needed with
recent Valgrind relases and clashing with -DVALGRIND.
(This used to be commit 98479f1315cf8968152e1566966ac57e171008c3)

17 years agoNote about using Valgrind with tdbs.
Martin Pool [Tue, 11 Mar 2003 07:23:43 +0000 (07:23 +0000)]
Note about using Valgrind with tdbs.
(This used to be commit 36c6f67d4af50d8fc4c8bd54486df315861d55c2)

17 years agohaving sticky create times is not a bug
Andrew Tridgell [Tue, 11 Mar 2003 06:53:44 +0000 (06:53 +0000)]
having sticky create times is not a bug
(This used to be commit f283f71104319fa9f1e7d22fc91b8d7224ae157a)

17 years agofixed the MANGLE smbtorture test with the new paranoid string code
Andrew Tridgell [Tue, 11 Mar 2003 06:53:10 +0000 (06:53 +0000)]
fixed the MANGLE smbtorture test with the new paranoid string code
(This used to be commit 7be44dbe009a8d831c0720a2649fc871b067beef)

17 years agomake sure we have an empty directory when we start the utable test
Andrew Tridgell [Tue, 11 Mar 2003 06:31:23 +0000 (06:31 +0000)]
make sure we have an empty directory when we start the utable test
(This used to be commit af415842b80f024ca26b4e3bc52fd73fce0a28f3)

17 years agoIf using --enable-developer and valgrind.h is present, define VALGRIND.
Martin Pool [Tue, 11 Mar 2003 05:57:53 +0000 (05:57 +0000)]
If using --enable-developer and valgrind.h is present, define VALGRIND.
(This used to be commit 71c8e90117f00f168416f2f35a1c25755e2d0ed4)

17 years agoWhen opening an existing DB, don't require the hash_size specified to
Martin Pool [Tue, 11 Mar 2003 04:21:14 +0000 (04:21 +0000)]
When opening an existing DB, don't require the hash_size specified to
the open call to be the same as that of the existing tdb.  The
specified hash_size is only used if the tdb needs to be (re)created.

With this patch in place, tdbtool can open the printing tdbs, which
are created with a hash_size of 5000.  Before it would fail with EIO.
(This used to be commit e412dd6d7e5a41de94c07c64b186390ccce104cc)

17 years agoRemove obsolete file.
Tim Potter [Tue, 11 Mar 2003 02:30:17 +0000 (02:30 +0000)]
Remove obsolete file.
(This used to be commit c5c1a7979385778c08d6dd7796cfe8be1815992f)

17 years agoPatch from Ronan Waide:
Martin Pool [Tue, 11 Mar 2003 00:14:55 +0000 (00:14 +0000)]
Patch from Ronan Waide:

> when doing "enumdomusers", rpcclient prints each one preceded by the
> word "group" instead of "user"
(This used to be commit 17567dd1d510d4cf1dffa67be78510ae51571ec6)

17 years agoSome conversion to pstrcpy_base.
Volker Lendecke [Mon, 10 Mar 2003 16:59:29 +0000 (16:59 +0000)]
Some conversion to pstrcpy_base.

Volker
(This used to be commit 329911e43681b724cb0579aad77b4a658759d7ba)

17 years agocheck a pointer before dereferencing it; not sure why userdata == NULL though
Gerald Carter [Mon, 10 Mar 2003 15:05:06 +0000 (15:05 +0000)]
check a pointer before dereferencing it; not sure why userdata == NULL though
(This used to be commit 6fca29ddcdb111af24ee051b555ab4eec8cadd1d)

17 years agoDon't segfault on make_server_info_guest() failure - instead return the
Andrew Bartlett [Mon, 10 Mar 2003 12:08:32 +0000 (12:08 +0000)]
Don't segfault on make_server_info_guest() failure - instead return the
error code.

make_server_info_guest() requires an entry in the SAM at the moment, but
this will change before release.

Andrew Bartlett
(This used to be commit 6a956390fa253e87e38b3f1909f13595fbf2767a)

17 years agoUse "$@" to preserve shell quoting in case somebody passes an escaped
Martin Pool [Mon, 10 Mar 2003 03:04:47 +0000 (03:04 +0000)]
Use "$@" to preserve shell quoting in case somebody passes an escaped
string as a configure parameter.
(This used to be commit 3285c80cb0e41d6736b4f74b01a65d55753a7920)

17 years agofixed use_oplocks and the timeout in smbtorture startup
Andrew Tridgell [Mon, 10 Mar 2003 02:51:30 +0000 (02:51 +0000)]
fixed use_oplocks and the timeout in smbtorture startup
(This used to be commit cec1ef09e5009cdac22e6c9ca101a49c5ef36b1a)

17 years agoadded -i option for ignoring dot errors in masktest
Andrew Tridgell [Mon, 10 Mar 2003 02:49:52 +0000 (02:49 +0000)]
added -i option for ignoring dot errors in masktest
(This used to be commit 0f4d1172a6add3f490fca22a45975d2588485146)

17 years agoMakefile.in for NTLMSSP singing update
Andrew Bartlett [Mon, 10 Mar 2003 02:48:32 +0000 (02:48 +0000)]
Makefile.in for NTLMSSP singing update
(This used to be commit 7717555438e4d74bb63d12abde3573933c15342a)

17 years agoFurther work on NTLMSSP-based SMB signing. Current status is that I cannnot
Andrew Bartlett [Mon, 10 Mar 2003 02:14:35 +0000 (02:14 +0000)]
Further work on NTLMSSP-based SMB signing.  Current status is that I cannnot
get Win2k to send a valid signiture in it's session setup reply - which it will
give to win2k clients.

So, I need to look at becoming 'more like MS', but for now I'll get this code
into the tree.  It's actually based on the TNG cli_pipe_ntlmssp.c, as it was
slightly easier to understand than our own (but only the utility functions
remain in any way intact...).

This includes the mysical 'NTLM2' code - I have no idea if it actually works.

(I couldn't get TNG to use it for its pipes either).

Andrew Bartlett
(This used to be commit a034a5e381ba5612be21e2ba640d11f82cd945da)

17 years agoClobber strings with 0xf1f1f1f1 before writing to them to check buffer
Martin Pool [Mon, 10 Mar 2003 01:10:45 +0000 (01:10 +0000)]
Clobber strings with 0xf1f1f1f1 before writing to them to check buffer
lengths are correct.  Attempts to pstrcpy into an fstring or allocated
string should fail in developer builds.

This builds on abartlet's earlier overflow probe for safe_strcpy, but
by clobbering the whole string with a nonzero value is more likely to
find overflows on the stack.

This is only used in -DDEVELOPER mode.

Reviewed by abartlet, tpot.
(This used to be commit 8d915e266cd8ccc8b27e9c7ea8e9d003d05f8182)

17 years agoInclude valgrind.h if present on the system.
Martin Pool [Mon, 10 Mar 2003 00:45:28 +0000 (00:45 +0000)]
Include valgrind.h if present on the system.
(This used to be commit 65ba78c6bd4c5ab7ec9bf4d15e4410482e82588d)

17 years agoCheck for valgrind.h
Martin Pool [Mon, 10 Mar 2003 00:37:25 +0000 (00:37 +0000)]
Check for valgrind.h
(This used to be commit 0ece70d631bf095bf9c8819180b6c59990159cd0)

17 years agoTry not to clobber the session request.
Andrew Bartlett [Sun, 9 Mar 2003 21:09:28 +0000 (21:09 +0000)]
Try not to clobber the session request.
(This used to be commit 05cffbee56f0556f550b4d14f3111bd7db972621)

17 years agoAdd Ronan Waide's info about the setdriver call.
Jelmer Vernooij [Sun, 9 Mar 2003 16:39:34 +0000 (16:39 +0000)]
Add Ronan Waide's info about the setdriver call.
(This used to be commit ef6cb3ec1aa943d4e52ea08e7b43a47d781d3273)

17 years agoAdd some printing question & answers
Jelmer Vernooij [Sun, 9 Mar 2003 12:08:36 +0000 (12:08 +0000)]
Add some printing question & answers
(This used to be commit 998537ca398100974075d11e28d5199997424f15)

17 years agoChange the way we sign SMB packets, to a function pointer interface.
Andrew Bartlett [Sun, 9 Mar 2003 09:23:09 +0000 (09:23 +0000)]
Change the way we sign SMB packets, to a function pointer interface.

The intention is to allow for NTLMSSP and kerberos signing of packets, but
for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA
spec)

Andrew Bartlett
(This used to be commit b9cf95c3dc04a45de71fb16e85c1bfbae50e6d8f)

17 years agoDon't fault on error returns (ptr == 0) for this LSA query.
Andrew Bartlett [Sun, 9 Mar 2003 01:13:41 +0000 (01:13 +0000)]
Don't fault on error returns (ptr == 0) for this LSA query.

(for example, query to non-dc)

Andrew Bartlett
(This used to be commit d1dde5f684652f86e63ac6cfa34ff42a680693de)

17 years agoThis is C, not C++
Andrew Bartlett [Sat, 8 Mar 2003 23:39:44 +0000 (23:39 +0000)]
This is C, not C++
(This used to be commit 25d210b90b6c0377046d89a1dce7a32f94fd7859)

17 years agomore on idmap
Simo Sorce [Sat, 8 Mar 2003 17:29:40 +0000 (17:29 +0000)]
more on idmap
two layers structure with
- local tdb cache
- remote idmap repository

compiles
(This used to be commit 8fb4e210bc7564ed491d121c20d598ba0bfbddff)

17 years agoAdd Q&A for people having trouble trying to log in without a proper
Jelmer Vernooij [Sat, 8 Mar 2003 17:29:00 +0000 (17:29 +0000)]
Add Q&A for people having trouble trying to log in without a proper
samba user database.
(This used to be commit 957c11e40e0aedc24d2dce2aaae9888673d68e01)

17 years agoAdd notes on increasing performance on AIX, based on an email from William Jojo
Jelmer Vernooij [Sat, 8 Mar 2003 15:27:54 +0000 (15:27 +0000)]
Add notes on increasing performance on AIX, based on an email from William Jojo
(This used to be commit 7dc2b10215c2b015a36e78c3b9b8f13cecfdfeba)

17 years agoTestparm needs the extra arg to set_local_machine_name() too.
Andrew Bartlett [Sat, 8 Mar 2003 10:24:48 +0000 (10:24 +0000)]
Testparm needs the extra arg to set_local_machine_name() too.
(This used to be commit 30ba31e6355b5dfb902e42d2b5edc71630db2923)

17 years agoMake sure that the 'remote' machine name can only be set once. For some weird
Andrew Bartlett [Sat, 8 Mar 2003 10:22:50 +0000 (10:22 +0000)]
Make sure that the 'remote' machine name can only be set once.  For some weird
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.

Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.

(This helps me, by seperating the logs by pid).

Andrew Bartlett
(This used to be commit afe5a3832f79131fb74461577f1db0e5e8bf4b6d)

17 years agoMake it clear that this is a fstrcpy().
Andrew Bartlett [Sat, 8 Mar 2003 05:18:08 +0000 (05:18 +0000)]
Make it clear that this is a fstrcpy().
(This used to be commit c2a266b7b661d319e13982bfdbc3a86e8502b8a4)

17 years agoFix typo in earlier fix, caught by Ranjit @ HP.
Jeremy Allison [Sat, 8 Mar 2003 01:16:30 +0000 (01:16 +0000)]
Fix typo in earlier fix, caught by Ranjit @ HP.
Jeremy.
(This used to be commit 13ab94fa73dbaf54da0169bbcf4d027d5c07d207)

17 years agosome more code
Simo Sorce [Sat, 8 Mar 2003 00:49:18 +0000 (00:49 +0000)]
some more code
(not tested yet)
(This used to be commit 0d6cec90c13731827abcbc61974efc993e794003)

17 years agoinitial work for the new idmpa interface
Simo Sorce [Fri, 7 Mar 2003 23:47:59 +0000 (23:47 +0000)]
initial work for the new idmpa interface
(This used to be commit 8338e74ac4e5f31150c96f459a67e52090dc6013)

17 years agoUse ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy Allison [Fri, 7 Mar 2003 23:34:55 +0000 (23:34 +0000)]
Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy.
(This used to be commit c0930e6d15eb68f06453d9b67142ccd7fb1370a0)

17 years agoAdd early prototype of cifs mount helper for Linux
Steve French [Fri, 7 Mar 2003 22:29:14 +0000 (22:29 +0000)]
Add early prototype of cifs mount helper for Linux
(This used to be commit b20bcf8d336b4b2079eb42342a96d1fe714709de)

17 years agoMissed parentheses around complex logic.
Jeremy Allison [Fri, 7 Mar 2003 19:46:51 +0000 (19:46 +0000)]
Missed parentheses around complex logic.
Jeremy.
(This used to be commit e81427c2d69be166afad94bc083e750e8f48fba7)

17 years agoPatch from Michael Steffens. In his own words :
Jeremy Allison [Fri, 7 Mar 2003 19:37:27 +0000 (19:37 +0000)]
Patch from Michael Steffens. In his own words :
-------------------------------------------------------------------------
I think there are basically two problem:

  1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
     and SMB_ACL_OTHER.
     The function ensure_canon_entry_valid() is prepared for that, but tries
     to "guess" values from group or other permissions, respectively, otherwise
     falling back to minimum r-- for the owner. Even if the owner had full
     permissions before setting ACL. This is the problem with W2k clients.

  2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
     This is ok in a take-ownership situation, but must fail if the file is
     to be given away. This is the problem with XP clients, trying to transfer
     ownership of the original file to the temp file.

The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.

I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:

  1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
     as "preserve current value" instead of attempting to build one ourself.
     The original code is still in, but only as fallback in case current values
     can't be retrieved.

  2. Rearrange set_nt_acl() such that chown is only done before setting
     ACLs if there is either no change of owning user, or change of owning
     user is towards the current user. Otherwise chown is done after setting
     ACLs.

It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 8ec20cbae7ca7e685b1a4186d8482c7405915dc3)

17 years agoSome progress towards gums and tdbsam2
Simo Sorce [Fri, 7 Mar 2003 18:26:24 +0000 (18:26 +0000)]
Some progress towards gums and tdbsam2
genparser works fine, and it is a marvelous tool to store objects in tdb :)
(This used to be commit 4c6d461a8572f03cd33cba95500cc837638b732c)

17 years agoLimit the number of SIDs that may be looked up, in line with existing code
Andrew Bartlett [Fri, 7 Mar 2003 09:29:56 +0000 (09:29 +0000)]
Limit the number of SIDs that may be looked up, in line with existing code
for name->sid.
(This used to be commit 0ebccc0dbeecc10d423529909a2563fbc3bf9857)

17 years agosafe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
Andrew Bartlett [Fri, 7 Mar 2003 09:25:48 +0000 (09:25 +0000)]
safe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
IP address resolving code.
(This used to be commit 1f605fe77c56ee2a7838c9f87eedf4bb91ebf688)

17 years agoFix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy Allison [Fri, 7 Mar 2003 00:34:43 +0000 (00:34 +0000)]
Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy.
(This used to be commit 1cbd53dc3cd2d56f5e62d42fed5d589efcecb8f8)

17 years agoFound at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
Jeremy Allison [Fri, 7 Mar 2003 00:30:29 +0000 (00:30 +0000)]
Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
differently to W2K, cope with this.
Jeremy.
(This used to be commit 172f415c9eaa4d310a52794e3dc1a6bc92206ce4)

17 years agoAdd documentation on line returned by 'add printer command' script
Jelmer Vernooij [Thu, 6 Mar 2003 17:09:07 +0000 (17:09 +0000)]
Add documentation on line returned by 'add printer command' script
(This used to be commit d41dbe568ec77e4860678e5ee4fe2ab2f2da507b)

17 years agoRedirect to printer docs for removed options
Jelmer Vernooij [Thu, 6 Mar 2003 17:05:33 +0000 (17:05 +0000)]
Redirect to printer docs for removed options
(This used to be commit 401a522d88abdb6d6f01707f51b658d4e0497d3d)

17 years agoadd #define for the max device name length in a DEVICEMODE
Gerald Carter [Thu, 6 Mar 2003 16:06:12 +0000 (16:06 +0000)]
add #define for the max device name length in a DEVICEMODE
(This used to be commit 21ec2b6ba3ddba6964f6ddb53f8494e4a8b48a83)

17 years agoMake smbtorture use the same cli_full_connection() framework as the rest of
Andrew Bartlett [Thu, 6 Mar 2003 10:37:51 +0000 (10:37 +0000)]
Make smbtorture use the same cli_full_connection() framework as the rest of
Samba.  This fixes things like not doing *SMBSERVER etc.

Andrew Bartlett
(This used to be commit 8863ff863c1da42aa6b8718f315c608d9d9067c6)

17 years agomore off-by-one safe_strcpy()
Andrew Bartlett [Thu, 6 Mar 2003 08:24:39 +0000 (08:24 +0000)]
more off-by-one safe_strcpy()
(This used to be commit d8d2d5e75503ae2b6532a25e4c9bbcdf20cc60af)

17 years agoMore safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())
Andrew Bartlett [Thu, 6 Mar 2003 07:55:48 +0000 (07:55 +0000)]
More safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())

Andrew Bartlett
(This used to be commit 42b5514404bc7e33306c11344c6c934a1f83d295)

17 years agoFIXME about crash on failure case.
Martin Pool [Thu, 6 Mar 2003 07:36:08 +0000 (07:36 +0000)]
FIXME about crash on failure case.
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)

17 years agoAdd *SMBSERVER fallback code to smbtorture ...
Richard Sharpe [Wed, 5 Mar 2003 23:55:11 +0000 (23:55 +0000)]
Add *SMBSERVER fallback code to smbtorture ...
(This used to be commit 460339db2246b0213252ee34f507eb8e55ecbecb)

17 years agoAdd code to allow us to specify the port to connect on when performing
Richard Sharpe [Wed, 5 Mar 2003 23:29:36 +0000 (23:29 +0000)]
Add code to allow us to specify the port to connect on when performing
a test ...
(This used to be commit 1128a2fb4c16681e669efe605ff7d7161a2f7acd)

17 years agoUse new configure test to turn on this automated test for correct string
Andrew Bartlett [Wed, 5 Mar 2003 09:40:08 +0000 (09:40 +0000)]
Use new configure test to turn on this automated test for correct string
function usage.

Andrew Bartlett
(This used to be commit cdc6139a9646b267a9921fc11fa532640a2e4c7f)

17 years agoA couple more fixes for fstrcpy() into a malloced region. In this case it's
Andrew Bartlett [Wed, 5 Mar 2003 09:36:41 +0000 (09:36 +0000)]
A couple more fixes for fstrcpy() into a malloced region.  In this case it's
all perfectly legit - the region is an fstring in length, but might not
always be, and it is the last peice of code to fail my automated test.

Andrew Bartlett
(This used to be commit 762d61b37d053568b6346e249ba7ef594320153a)

17 years agoAdd a test for a useful property of the compiler - we can get link-time
Andrew Bartlett [Wed, 5 Mar 2003 09:33:43 +0000 (09:33 +0000)]
Add a test for a useful property of the compiler - we can get link-time
failures for some compile-time properties this way.

Andrew Bartlett
(This used to be commit ce618624b7df797e228f8ef0f19820b318c62ae9)

17 years agoalso ignore the autom4te-2.53.cache
Andrew Bartlett [Wed, 5 Mar 2003 08:49:56 +0000 (08:49 +0000)]
also ignore the autom4te-2.53.cache
(This used to be commit 243c9c37a53501b96df6286517e03eb09efcc620)

17 years agoThis file has not been maintained for a while - if we really want this
Andrew Bartlett [Wed, 5 Mar 2003 08:48:08 +0000 (08:48 +0000)]
This file has not been maintained for a while - if we really want this
behaviour we should seperate -g from --enable-developer, and allow developers
to also select --enable-debug if they want.

Andrew Bartlett
(This used to be commit 96d1449c42597ea22c538a004960b26925c641fc)

17 years agolp_string: Add note about dodgy StrnCpy use.
Martin Pool [Wed, 5 Mar 2003 05:19:35 +0000 (05:19 +0000)]
lp_string: Add note about dodgy StrnCpy use.
(This used to be commit b32ae2d83fd0b4dd2c313cd0727bd276564cec0c)

17 years agoUse PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
Tim Potter [Wed, 5 Mar 2003 05:14:19 +0000 (05:14 +0000)]
Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
command.  From Ronan Waide <waider@waider.ie>.
(This used to be commit 992b5eb4e05fbf99d91d7235b9a002957533f95b)

17 years agoMore const fixes.
Jeremy Allison [Wed, 5 Mar 2003 01:34:37 +0000 (01:34 +0000)]
More const fixes.
Jeremy.
(This used to be commit 7b945e10a6c636c0b0aabc841803bf44405cb2ae)

17 years agoWritable string const fixes.
Jeremy Allison [Wed, 5 Mar 2003 01:30:26 +0000 (01:30 +0000)]
Writable string const fixes.
Jeremy.
(This used to be commit 60b0cfc8a5b6275d3460ebc6bf17d0f08e25b67e)

17 years agoConnectathon fix. W2K -> W2K over port 445 doing a tconX does the full
Jeremy Allison [Wed, 5 Mar 2003 00:54:07 +0000 (00:54 +0000)]
Connectathon fix. W2K -> W2K over port 445 doing a tconX does the full
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
(This used to be commit 9d7ea5585c873156ede4b56e43a0d4d75077283a)

17 years agoFix another 'off by one' bug with safe_strcpy(). It is unclear if the intent
Andrew Bartlett [Tue, 4 Mar 2003 09:33:34 +0000 (09:33 +0000)]
Fix another 'off by one' bug with safe_strcpy().  It is unclear if the intent
was to limit the string to 31 or 32 characters (excluding the null term), so
I've assumed for now that 32 is fine, as this matches current behaviour (well, current behaviour would crash, but anyway...)

Jerry:  Can you look at this for me?

Andrew Bartlett
(This used to be commit 6c43327ea2b50820ea4f623c889dc4525d58baa3)

17 years agoAnother pstrcpy() into malloc()ed buffer fix.
Andrew Bartlett [Mon, 3 Mar 2003 23:53:35 +0000 (23:53 +0000)]
Another pstrcpy() into malloc()ed buffer fix.

Andrew Bartlett
(This used to be commit bd0c84d60b703e89081838a7cfa1eb1b4f45ad0a)

17 years agoConst warning fixes.
Jeremy Allison [Mon, 3 Mar 2003 20:12:07 +0000 (20:12 +0000)]
Const warning fixes.
Jeremy.
(This used to be commit 3ad62ebe26d8c6b82f8618eea11d104b3ab0ec18)

17 years agodlsym takes a const char *.
Jeremy Allison [Mon, 3 Mar 2003 19:53:04 +0000 (19:53 +0000)]
dlsym takes a const char *.
Jeremy.
(This used to be commit ff3827a62b37342b13fd8b4eafd256d91428c02b)

17 years agoFix "might be used uninitialised" warnings.
Jeremy Allison [Mon, 3 Mar 2003 19:36:16 +0000 (19:36 +0000)]
Fix "might be used uninitialised" warnings.
Jeremy.
(This used to be commit a670b57c563b220c2ede1dac4ce1e9c71c866498)

17 years agoDo my janitorial duties to encourage others to do so.
Richard Sharpe [Mon, 3 Mar 2003 17:43:33 +0000 (17:43 +0000)]
Do my janitorial duties to encourage others to do so.
Fix lingering large offset problems in smbtar etc.
(This used to be commit c416eec2f2a38eebfcda5868999d474628037f1e)

17 years ago* always report ourselves as a Windows 2000 print server (even
Gerald Carter [Mon, 3 Mar 2003 17:33:57 +0000 (17:33 +0000)]
* always report ourselves as a Windows 2000 print server (even
  without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
(This used to be commit 342734e3de71c7dc8e3d24fd66dae58cf647a569)