16 years agor4497: fixed a typo
Andrew Tridgell [Mon, 3 Jan 2005 02:47:00 +0000 (02:47 +0000)]
r4497: fixed a typo
(This used to be commit 2f6107ea9af125a031479dd863447eeadd8e5cfc)

16 years agor4496: expanded info on testing your filesystem for xattr support
Andrew Tridgell [Mon, 3 Jan 2005 02:26:14 +0000 (02:26 +0000)]
r4496: expanded info on testing your filesystem for xattr support
(This used to be commit bf9dfcc5e2f1b3fb827d4625ebaa2e75b754c76c)

16 years agor4495: Some more regexps for handling stuff in the lsa and samr pipes -
Tim Potter [Mon, 3 Jan 2005 00:26:50 +0000 (00:26 +0000)]
r4495: Some more regexps for handling stuff in the lsa and samr pipes -
various types of arrays and relative structures.
(This used to be commit 9f99d94ff5863b2da05f2283639852306bfbc74d)

16 years agor4494: Allow gensec_gssapi to use the SPNEGO mech provided by Heimdal (off by
Andrew Bartlett [Sun, 2 Jan 2005 23:53:14 +0000 (23:53 +0000)]
r4494: Allow gensec_gssapi to use the SPNEGO mech provided by Heimdal (off by
default at this point), and include the GSSAPI OIDs in our source, per
advice by lha that this is easier than getting the includes right.

Andrew Bartlett
(This used to be commit 9ff8b2b4d12d364084df5c95a752ce2a0546053d)

16 years agor4493: change name of README.gcov so it doesn't get deleted by "make clean" :-)
Andrew Tridgell [Sun, 2 Jan 2005 23:48:07 +0000 (23:48 +0000)]
r4493: change name of README.gcov so it doesn't get deleted by "make clean" :-)
(This used to be commit 209ba7b889823f1badb0337412b2b9b34c5e23de)

16 years agor4492: is a pointer that needs to be allocated before use
Andrew Tridgell [Sun, 2 Jan 2005 23:44:08 +0000 (23:44 +0000)]
r4492: is a pointer that needs to be allocated before use
(This used to be commit f830adc54ada7f38f964a6ccb5270d2791325dd5)

16 years agor4491: don't dereference q1.out.sam unless we know it is not NULL
Andrew Tridgell [Sun, 2 Jan 2005 23:36:02 +0000 (23:36 +0000)]
r4491: don't dereference q1.out.sam unless we know it is not NULL
(This used to be commit 77e14c28584c5917f22672b304cb0f8e37e883fd)

16 years agor4490: when implementing one rpc server call in terms of another call, you
Andrew Tridgell [Sun, 2 Jan 2005 23:31:12 +0000 (23:31 +0000)]
r4490: when implementing one rpc server call in terms of another call, you
must zero r.out before making the 2nd call if the 2nd call has any
non-ref out parameters. This is needed for the case where the 2nd call
fails, and the 1st call would then fill in its out fields based on
uninitialised memory.
(This used to be commit 202470326dcfaa5d36aaaf6be47eec40fed50402)

16 years agor4489: Remove an obsolete file.
Tim Potter [Sun, 2 Jan 2005 23:25:25 +0000 (23:25 +0000)]
r4489: Remove an obsolete file.
(This used to be commit 446b2cf99641956b9bdede4364c93232d914c678)

16 years agor4488: removed an unused variable
Andrew Tridgell [Sun, 2 Jan 2005 23:09:11 +0000 (23:09 +0000)]
r4488: removed an unused variable
(This used to be commit 1dfc41c9a3b6418236a1f04b5cf3f9ef9e8b608e)

16 years agor4487: fixed the use of ldb_msg_add_*() in the samr password backend
Andrew Tridgell [Sun, 2 Jan 2005 23:05:27 +0000 (23:05 +0000)]
r4487: fixed the use of ldb_msg_add_*() in the samr password backend
(This used to be commit d79cc8b901ef273547bab2f66355e075da61ce9b)

16 years agor4486: fixed some memory leaks in the new ldb code, by ensuring that memory is always
Andrew Tridgell [Sun, 2 Jan 2005 23:03:50 +0000 (23:03 +0000)]
r4486: fixed some memory leaks in the new ldb code, by ensuring that memory is always
allocated as a child of the right context
(This used to be commit 1071712cf5951fa2e94f314bd7678cfa51b2dbcd)

16 years agor4485: remove unused TODO comment we already handle the DS_ROLE_STANDALONE_SERVER...
Stefan Metzmacher [Sun, 2 Jan 2005 16:25:30 +0000 (16:25 +0000)]
r4485: remove unused TODO comment we already handle the DS_ROLE_STANDALONE_SERVER case

(This used to be commit 7ab9de14afa8abb44f0f6c16217964618fcaf894)

16 years agor4484: - use the nTMixedDomain attribute to check if our domain is mixed mode or not
Stefan Metzmacher [Sun, 2 Jan 2005 16:24:05 +0000 (16:24 +0000)]
r4484: - use the nTMixedDomain attribute to check if our domain is mixed mode or not

(This used to be commit 7fe9550375a7a922f9fc93944acaf7915ee107c1)

16 years agor4483: - rename same structs, enums and uninons of the dssetup pipe
Stefan Metzmacher [Sun, 2 Jan 2005 16:11:59 +0000 (16:11 +0000)]
r4483: - rename same structs, enums and uninons of the dssetup pipe
  to match the style we are using in other pipes

- first fillin local vars and only set the out parameter on success

- for the server code only to the samdb lookup when it's needed

NOTE: the DsRoleGetPrimaryDomainInformation() code with DS_ROLE_MEMBER_SERVER
      is not tested yet, does someone has a w2k3 member server to test with?

(This used to be commit e6d1136497f501fe0687bfb34a155db6a9d87bde)

16 years agor4482: in ads mixed mode there are also only one PDC and multiple BDC's
Stefan Metzmacher [Sun, 2 Jan 2005 16:06:21 +0000 (16:06 +0000)]
r4482: in ads mixed mode there are also only one PDC and multiple BDC's

(This used to be commit 30980d218495d389d7a5db4b190ed717217c08d4)

16 years agor4481: get rid of the last leak
Andrew Tridgell [Sun, 2 Jan 2005 13:04:32 +0000 (13:04 +0000)]
r4481: get rid of the last leak
(This used to be commit 52de02b2c31eefac75ce0582ed8acae8007e7cc2)

16 years agor4480: autofree the dcom proxy tables
Andrew Tridgell [Sun, 2 Jan 2005 12:56:21 +0000 (12:56 +0000)]
r4480: autofree the dcom proxy tables
(This used to be commit 973acf7bbdb7bd71f052aca15d0189f2e2069fd4)

16 years agor4479: added the function talloc_autofree_context() which returns a talloc context...
Andrew Tridgell [Sun, 2 Jan 2005 12:55:33 +0000 (12:55 +0000)]
r4479: added the function talloc_autofree_context() which returns a talloc context that
will automatically be freed on program exit. This is useful for reducing
clutter in leak reports
(This used to be commit cf73dda652e0a121901f22771104be6751c0fcb9)

16 years agor4477: expanded the test suite to increase code coverage a lot
Andrew Tridgell [Sun, 2 Jan 2005 09:46:59 +0000 (09:46 +0000)]
r4477: expanded the test suite to increase code coverage a lot
(This used to be commit 4edbd1b18ee38e584cf844b64c7fcb2645921837)

16 years agor4476: added a little gcov howto for ldb
Andrew Tridgell [Sun, 2 Jan 2005 08:53:58 +0000 (08:53 +0000)]
r4476: added a little gcov howto for ldb
(This used to be commit 5dc1995118c7d25adf89b6cc6156b1e6fc281e9b)

16 years agor4475: fixed smbd to work with the small changes in the ldb API (the most important
Andrew Tridgell [Sun, 2 Jan 2005 07:51:13 +0000 (07:51 +0000)]
r4475: fixed smbd to work with the small changes in the ldb API (the most important
change was in the ldb_msg_add_*() routines, which now use the msg as a context,
and thus it needs to be a talloc ptr)
(This used to be commit 1a4713bfd0e519f3eb7b3241121ff914a6eeef18)

16 years agor4474: - converted ldb to use talloc internally
Andrew Tridgell [Sun, 2 Jan 2005 07:49:29 +0000 (07:49 +0000)]
r4474: - converted ldb to use talloc internally

- added gcov flags to Makefile.ldb

- expanded ldb test suite to get more coverage
(This used to be commit 0ab98f50a7e0fe15347a99e5c29a6590a87729a0)

16 years agor4473: - moved talloc into its own lib/talloc/ area
Andrew Tridgell [Sun, 2 Jan 2005 07:47:34 +0000 (07:47 +0000)]
r4473: - moved talloc into its own lib/talloc/ area

- added gcov flags to Makefile.talloc

- expanded talloc testsuite to add a test for realloc with a child ptr

- fixed a bug in talloc_realloc() with realloc of a ptr that has child ptrs
(This used to be commit 98b5f73c1ba34d7576c5995069b485c1c5ede324)

16 years agor4472: improve the discard_const() macro for standalone build of talloc
Andrew Tridgell [Sun, 2 Jan 2005 04:21:32 +0000 (04:21 +0000)]
r4472: improve the discard_const() macro for standalone build of talloc
(This used to be commit 310cea15bf01343d9ab8ff7a166f0699c0507816)

16 years agor4471: Running 'make eparser_idl' doesn't need --header anymore.
Tim Potter [Sun, 2 Jan 2005 03:24:57 +0000 (03:24 +0000)]
r4471: Running 'make eparser_idl' doesn't need --header anymore.
(This used to be commit 913630d6e43cda621b36403169544dcbea926153)

16 years agor4470: Try not to have GSSAPI built unless we detected krb5. We should split
Andrew Bartlett [Sun, 2 Jan 2005 03:10:28 +0000 (03:10 +0000)]
r4470: Try not to have GSSAPI built unless we detected krb5.  We should split
these tests out a bit, but for now it's an indicator we can use.

Andrew Bartlett
(This used to be commit 2b0605dbaee18da4ebb676fc292b324d21805ef7)

16 years agor4469: Version n + 1 of the pidl ethereal parser generator. This version is
Tim Potter [Sun, 2 Jan 2005 00:00:43 +0000 (00:00 +0000)]
r4469: Version n + 1 of the pidl ethereal parser generator.  This version is
based on the idea of manipulating the .c and .h files generated by with perl regexps and glueing it all together to make an
ethereal plugin.

I thought this was a pretty crazy idea to start off with but it has
turned out to be not as complicated as I thought and has the huge advantage
of not duplicating any of the difficult code in
(This used to be commit 7007522f83740f41f9a47f5ad5942ea46320d405)

16 years agor4468: Don't be a slacker and leave out parameter names when generating
Tim Potter [Sat, 1 Jan 2005 23:18:59 +0000 (23:18 +0000)]
r4468: Don't be a slacker and leave out parameter names when generating
prototypes for ndr push/pull/print functions.
(This used to be commit 1fe95ad1720f48a353ec77178e303b437bb13fed)

16 years agor4467: - tdb standalone build doesn't need -DSTANDALONE any more
Andrew Tridgell [Sat, 1 Jan 2005 05:08:41 +0000 (05:08 +0000)]
r4467: - tdb standalone build doesn't need -DSTANDALONE any more

- fixed standalone build
(This used to be commit ade0b71e4194f99d807d26276592bc041d46df7b)

16 years agor4466: rather than defining "STANDALONE" for building tdb, ldb and talloc
Andrew Tridgell [Sat, 1 Jan 2005 05:06:22 +0000 (05:06 +0000)]
r4466: rather than defining "STANDALONE" for building tdb, ldb and talloc
outside the tree, instead defined _SAMBA_BUILD_ inside the Samba
build. This makes it easier to pull code out of Samba for external
(This used to be commit 09e98c8745cca7ccb1ad7134c0c09b8e4c0f4f06)

16 years agor4465: remove unused file
Andrew Tridgell [Sat, 1 Jan 2005 04:40:11 +0000 (04:40 +0000)]
r4465: remove unused file
(This used to be commit fee40e110d56c932aeff11178c120f3f4e19ddd2)

16 years agor4464: added pvfs backend support for the special CREATOR_OWNER and CREATOR_GROUP...
Andrew Tridgell [Sat, 1 Jan 2005 04:25:46 +0000 (04:25 +0000)]
r4464: added pvfs backend support for the special CREATOR_OWNER and CREATOR_GROUP inheritance rules
(This used to be commit 0a29fb45c310b4b8c348d187b8ff1833deaac6c3)

16 years agor4463: added testing of the special SID_CREATOR_OWNER inheritance rules
Andrew Tridgell [Sat, 1 Jan 2005 03:46:55 +0000 (03:46 +0000)]
r4463: added testing of the special SID_CREATOR_OWNER inheritance rules
(This used to be commit 5448c72ebe58e264ee772f8e1c4caee2250c328c)

16 years agor4462: - enable DSSETUP on ncalrpc
Andrew Tridgell [Sat, 1 Jan 2005 01:40:45 +0000 (01:40 +0000)]
r4462: - enable DSSETUP on ncalrpc

- add DSSETUP to the list of tests run in
(This used to be commit 73c3cdc8ed8dafd544ce4dcac9141124d2b85670)

16 years agor4461: finished the remaining information levels in the DSSETUP pipe. The pipe is...
Andrew Tridgell [Sat, 1 Jan 2005 01:32:01 +0000 (01:32 +0000)]
r4461: finished the remaining information levels in the DSSETUP pipe. The pipe is now complete!

The only glitch is that I am returning DS_ROLE_MEMBER_SERVER when I
should be returning DS_ROLE_PRIMARY_DC. This is needed for the moment
or ACL editing doesn't work from w2k3. Once we have some more ADS
calls we should be able to fix this.
(This used to be commit 6566dc2805a9f6473ebab70b0dbd381c4dbd42c8)

16 years agor4460: Add a new GENSEC module: gensec_gssapi
Andrew Bartlett [Sat, 1 Jan 2005 00:19:08 +0000 (00:19 +0000)]
r4460: Add a new GENSEC module: gensec_gssapi
(disabled by default, set parametric option: gensec:gssapi=yes to enable).

This module backs directly onto GSSAPI, and allows us to sign and seal
GSSAPI/Krb5 connections in particular.  This avoids me reinventing the
entire GSSAPI wheel.

Currently a lot of things are left as default - we will soon start
specifiying OIDs as well as passwords (it uses the keytab only at the
moment).  Tested with our LDAP-* torture tests against Win2k3.

My hope is to use this module to access the new SPNEGO implementation
in Heimdal, to avoid having to standards-verify our own.

Andrew Bartlett
(This used to be commit 14b650c85db14a9bf97e24682b2643b63c51ff35)

16 years agor4459: GENSEC refinements:
Andrew Bartlett [Fri, 31 Dec 2004 22:45:11 +0000 (22:45 +0000)]
r4459: GENSEC refinements:

In developing a GSSAPI plugin for GENSEC, it became clear that the API
needed to change:
 - GSSAPI exposes only a wrap() and unwrap() interface, and determines
   the location of the signature itself.
 - The 'have feature' API did not correctly function in the recursive
   SPNEGO environment.

As such, NTLMSSP has been updated to support these methods.

The LDAP client and server have been updated to use the new wrap() and
unwrap() methods, and now pass the LDAP-* tests in our smbtorture.
(Unfortunely I still get valgrind warnings, in the code that was
previously unreachable).

Andrew Bartlett
(This used to be commit 9923c3bc1b5a6e93a5996aadb039bd229e888ac6)

16 years agor4458: Create ncalrpc directory with 0755 rather then 0700 so non-root users
Jelmer Vernooij [Fri, 31 Dec 2004 22:38:00 +0000 (22:38 +0000)]
r4458: Create ncalrpc directory with 0755 rather then 0700 so non-root users
can use ncalrpc as well.
(This used to be commit 02340bb6eec394576d23f2c51956f4c47f475452)

16 years agor4457: Fix IDL + add torture test for InqObject
Jelmer Vernooij [Fri, 31 Dec 2004 22:12:44 +0000 (22:12 +0000)]
r4457: Fix IDL + add torture test for InqObject
(This used to be commit dbcaff7c71c9b7ee984a2ed458b6c3ce27772740)

16 years agor4456: NT4 usrmgr.exe asks for 4096 accounts, allow twice that.
Volker Lendecke [Fri, 31 Dec 2004 17:56:05 +0000 (17:56 +0000)]
r4456: NT4 usrmgr.exe asks for 4096 accounts, allow twice that.

(This used to be commit f8588a769c185f871fdcd5db35428ad587bdfad3)

16 years agor4455: LSADS was a duplicate of DSSETUP, and is now gone
Andrew Tridgell [Fri, 31 Dec 2004 13:28:31 +0000 (13:28 +0000)]
r4455: LSADS was a duplicate of DSSETUP, and is now gone
(This used to be commit 05c8fd81ddec969ed5280e2fe9f838ac4399f1c9)

16 years agor4454: This is the patch I use to Samba3 nmbd to allow a WinXP box
Andrew Tridgell [Fri, 31 Dec 2004 13:23:37 +0000 (13:23 +0000)]
r4454: This is the patch I use to Samba3 nmbd to allow a WinXP box
to join a Samba4 domain. It is hard-coded for my GUID, so
you will need to edit it to suit.

I'm committing this so others can experiment. Obviously
what we really need is a new nmbd in Samba4.
(This used to be commit a30be712e5abe81b57f8b1b75ebf152018df0eea)

16 years agor4453: use lp_server_role(), which currently returns 3, for the dssetup
Andrew Tridgell [Fri, 31 Dec 2004 12:10:35 +0000 (12:10 +0000)]
r4453: use lp_server_role(), which currently returns 3, for the dssetup
role. The value '5', which is what my w2k3 DC returns, doesn't
work. I'm not sure why this is.

with this change the GUI ACL editor from w2k3 works properly, with
either server role in the HKLM registry.
(This used to be commit 27a8b270bdd029a850c5ec3d10c1ac42468169cb)

16 years agor4452: the beginnings of a dssetup rpc server.
Andrew Tridgell [Fri, 31 Dec 2004 11:37:26 +0000 (11:37 +0000)]
r4452: the beginnings of a dssetup rpc server.
(This used to be commit 1c2170ae21d60c22ee3053fbf249dba59de576ba)

16 years agor4451: added initial RPC-DSSETUP torture test. It works for level1 of
Andrew Tridgell [Fri, 31 Dec 2004 10:49:35 +0000 (10:49 +0000)]
r4451: added initial RPC-DSSETUP torture test. It works for level1 of
(This used to be commit 7aec3dac6fd5165cfca5c650aaa29234e278d95d)

16 years agor4450: the beginnings of IDL for the dssetup pipe. I need this pipe for ACL editing...
Andrew Tridgell [Fri, 31 Dec 2004 10:47:04 +0000 (10:47 +0000)]
r4450: the beginnings of IDL for the dssetup pipe. I need this pipe for ACL editing from w2k3
when we present ourselves as a DC in the registry
(This used to be commit 9651901791e0553f106ab957c5787c109098248b)

16 years agor4449: fixed the helpstring for LSA IDL
Andrew Tridgell [Fri, 31 Dec 2004 10:45:48 +0000 (10:45 +0000)]
r4449: fixed the helpstring for LSA IDL
(This used to be commit 40a68a160e43b2e5d018e393ddecdfc50bad5360)

16 years agor4448: - fixed access_mask checking on acl set
Andrew Tridgell [Fri, 31 Dec 2004 08:56:32 +0000 (08:56 +0000)]
r4448: - fixed access_mask checking on acl set

- honor the change ownership requests of acl set, changing the underlying
  unix owner/group

- fix the access mask on file create with SEC_FLAG_MAXIMUM_ALLOWED
(This used to be commit 5761fa35ab727b51ef1b52459911bafbdd788755)

16 years agor4447: implement server side of lsa_LookupSids3() and lsa_LookupNames3()
Andrew Tridgell [Fri, 31 Dec 2004 08:54:59 +0000 (08:54 +0000)]
r4447: implement server side of lsa_LookupSids3() and lsa_LookupNames3()
(This used to be commit e535f84504b07a912c2f5dd6eca4c9893c1843db)

16 years agor4446: attempt to fix the build - andrew, can you check I've done this right?
Andrew Tridgell [Fri, 31 Dec 2004 08:54:07 +0000 (08:54 +0000)]
r4446: attempt to fix the build - andrew, can you check I've done this right?
(This used to be commit 9f0bf657aeee86d859742fb4da3a0f806e7060b6)

16 years agor4445: put the unlink test in a subdirectory, and ensure it cleans up
Andrew Tridgell [Fri, 31 Dec 2004 08:44:08 +0000 (08:44 +0000)]
r4445: put the unlink test in a subdirectory, and ensure it cleans up
(This used to be commit 382231ca365eccec8024af9420b1ebe41953bdb5)

16 years agor4444: - initialise registry:HKEY_LOCAL_MACHINE to a reasonable default (where
Andrew Tridgell [Fri, 31 Dec 2004 08:43:34 +0000 (08:43 +0000)]
r4444: - initialise registry:HKEY_LOCAL_MACHINE to a reasonable default (where suggests hklm.ldb be put)

- fix the globals init not to wipe parametic values after initialising
  them (this bug prevented default values for parametric parameters)
(This used to be commit 6a360c52c1723b4c3485a97ebcfeb907f840a051)

16 years agor4443: test lsa_LookupNames3() even when lsa_LookupSids3() fails
Andrew Tridgell [Fri, 31 Dec 2004 07:53:42 +0000 (07:53 +0000)]
r4443: test lsa_LookupNames3() even when lsa_LookupSids3() fails
(This used to be commit d37f556258ba12479e4e9acc5cdb5535ebf41d7f)

16 years agor4442: fix lsa_TranslatedSid3 (its a dom_sid2 not a dom_sid)
Andrew Tridgell [Fri, 31 Dec 2004 07:52:54 +0000 (07:52 +0000)]
r4442: fix lsa_TranslatedSid3 (its a dom_sid2 not a dom_sid)
(This used to be commit 0dd258709554265efaa0d25ad5bc86b559139c2e)

16 years agor4441: gensec_krb5 update:
Andrew Bartlett [Fri, 31 Dec 2004 07:43:08 +0000 (07:43 +0000)]
r4441: gensec_krb5 update:

 - Use more of the clikrb5.c wrapper calls

 - Don't use the session keytab if we kinit for the user.

Andrew Bartlett
(This used to be commit e15dbee00628475d5e1c1f329a7f9b199bc36360)

16 years agor4440: - add a start of srvsvc_NetShareCheck() server code
Stefan Metzmacher [Fri, 31 Dec 2004 07:42:57 +0000 (07:42 +0000)]
r4440: - add a start of srvsvc_NetShareCheck() server code

- filterout hidden shares in NetShareEnum()

- get max_connections right

(This used to be commit c685823c5d75f22177549566866301523a64a1dd)

16 years agor4439: unlimited connections is -1
Stefan Metzmacher [Fri, 31 Dec 2004 07:40:14 +0000 (07:40 +0000)]
r4439: unlimited connections is -1

(This used to be commit e62b36bef193f6a58ee035d581ef0f574f1e2910)

16 years agor4438: the ADMIN$ share is a diskshare but hidden
Stefan Metzmacher [Fri, 31 Dec 2004 07:35:14 +0000 (07:35 +0000)]
r4438: the ADMIN$ share is a diskshare but hidden

(This used to be commit 33a185ec3b211f6137abd6367ccc81d5102e5f4f)

16 years agor4437: added IDL and test code for lsa_LookupSids3() and lsa_LookupNames3().
Andrew Tridgell [Fri, 31 Dec 2004 07:26:26 +0000 (07:26 +0000)]
r4437: added IDL and test code for lsa_LookupSids3() and lsa_LookupNames3().

For some reason I am getting ACCESS_DENIED from w2k3 on
lsa_LookupSids3(). I will investigate.
(This used to be commit c759fa0000e37c3e93a7529a7701998af6727612)

16 years agor4436: add one more flag
Stefan Metzmacher [Fri, 31 Dec 2004 07:22:10 +0000 (07:22 +0000)]
r4436: add one more flag

(This used to be commit 7886000e031622795fecb6ec37990c133b1e66f7)

16 years agor4435: add another error code
Stefan Metzmacher [Fri, 31 Dec 2004 07:21:31 +0000 (07:21 +0000)]
r4435: add another error code

(This used to be commit 02861f63052c48fc85c6694ad8164cc6cc5443d4)

16 years agor4434: - fix some NetShare* idl functions
Stefan Metzmacher [Fri, 31 Dec 2004 06:19:05 +0000 (06:19 +0000)]
r4434: - fix some NetShare* idl functions

- add torture test for NetShareCheck()

(This used to be commit 96000a2261ed56fda613a45e3aa460eb3c87082a)

16 years agor4433: added the boilerplate for the new w2k3 LSA functions in preparation
Andrew Tridgell [Fri, 31 Dec 2004 06:08:43 +0000 (06:08 +0000)]
r4433: added the boilerplate for the new w2k3 LSA functions in preparation
for adding LookupSids3 (needed for ACL editing from w2k3)
(This used to be commit 745bbc0e1717c1e0068be00cff36071dbdc451a6)

16 years agor4432: - add srvsvc_NetShareInfo level 1006 and 1501 idl
Stefan Metzmacher [Fri, 31 Dec 2004 05:34:31 +0000 (05:34 +0000)]
r4432: - add srvsvc_NetShareInfo level 1006 and 1501 idl

- implement srvsvc_NetGetShareInfo()

- add more error checks

- bring the rest of the code in the same layout

(This used to be commit 0dd14d9fc611a33dad4e559321d6c50d82efb5d1)

16 years agor4431: add WERR_NET_NAME_NOT_FOUND
Stefan Metzmacher [Fri, 31 Dec 2004 04:45:13 +0000 (04:45 +0000)]

(This used to be commit 74e65680fa9a6b8f04c6ae62ec1da49659879fb5)

16 years agor4430: - fixed the BASE-LOCK* tests to use a subdirectory, and properly setup the...
Andrew Tridgell [Fri, 31 Dec 2004 04:17:03 +0000 (04:17 +0000)]
r4430: - fixed the BASE-LOCK* tests to use a subdirectory, and properly setup the directory before each test,
  thus avoiding errors due to previous failures
(This used to be commit a44fa5319d87e57f4b904334d9ea65cc6807b789)

16 years agor4429: the owner of a file always gets SEC_STD_DELETE
Andrew Tridgell [Fri, 31 Dec 2004 03:55:37 +0000 (03:55 +0000)]
r4429: the owner of a file always gets SEC_STD_DELETE
(This used to be commit 81630d3014c8cbd970bc917e3e9aef337fa211cd)

16 years agor4428: use minimum open permissions in the 'acl' command in smbclient, so the user is
Andrew Tridgell [Fri, 31 Dec 2004 03:54:49 +0000 (03:54 +0000)]
r4428: use minimum open permissions in the 'acl' command in smbclient, so the user is
not prevented from viewing the acl by other access bits
(This used to be commit 61e71782f573d0fa5b88237299df516c67405e30)

16 years agor4427: - added ldb_msg_*() functions for sorting, comparing and copying messages
Andrew Tridgell [Fri, 31 Dec 2004 03:51:42 +0000 (03:51 +0000)]
r4427: - added ldb_msg_*() functions for sorting, comparing and copying messages

- added a ldb_msg_canonicalize() function that fixes a record to not have any duplicate

- changed ldbedit to use ldb_msg_canonicalize(). This fixes a bug when you rename multiple
  elements in a record in one edit
(This used to be commit f006e724400843419c8b6155cbeae1876983855e)

16 years agor4426: fix same names
Stefan Metzmacher [Fri, 31 Dec 2004 03:32:36 +0000 (03:32 +0000)]
r4426: fix same names

(This used to be commit 18bbe40fe1e400546ff3750213f6c0505895e357)

16 years agor4425: - move srvsvc and wkssvc server code to the new W_ERROR_HAVE_NO_MEMORY() macro
Stefan Metzmacher [Fri, 31 Dec 2004 02:48:11 +0000 (02:48 +0000)]
r4425: - move srvsvc and wkssvc server code to the new W_ERROR_HAVE_NO_MEMORY() macro

- add parameters for
  server_info:platform_id = 500 /* this is PLATFORM_ID_NT */
  server_info:version_major = 5
  server_info:version_minor = 2

- implmented srvsvc_NetSrvGetInfo level 101

- make dcesrv_common_get_server_name() match w2k3

(This used to be commit 16f43207704397c6e3c0132e9f17c8a1a846ddca)

16 years agor4424: fixed a simple bug in the '|' handling in indexed ldb searches. I'm
Andrew Tridgell [Fri, 31 Dec 2004 02:18:14 +0000 (02:18 +0000)]
r4424: fixed a simple bug in the '|' handling in indexed ldb searches. I'm
amazed we got along for so long with this bug!
(This used to be commit 937159cf2c6ae08808bd10946fcdbd8741e1a560)

16 years agor4423: give lp_parm_int() and lp_parm_ulong() default values
Stefan Metzmacher [Fri, 31 Dec 2004 01:03:57 +0000 (01:03 +0000)]
r4423: give lp_parm_int() and lp_parm_ulong() default values

(This used to be commit c44f4d44b51789916e50c9da93046d0a15245edc)

16 years agor4422: make lp_set_cmdline("torture:dangerous", "Yes") a bool parameter
Stefan Metzmacher [Fri, 31 Dec 2004 01:02:22 +0000 (01:02 +0000)]
r4422: make lp_set_cmdline("torture:dangerous", "Yes") a bool parameter

(This used to be commit 19482a2245abbf9154423ca8997957b56333fba2)

16 years agor4421: fix typo
Stefan Metzmacher [Fri, 31 Dec 2004 00:07:37 +0000 (00:07 +0000)]
r4421: fix typo

(This used to be commit 222abd4171ce69c65a13b52675d4d75009056bca)

16 years agor4420: - add usefull helper macros for allocation failures,
Stefan Metzmacher [Thu, 30 Dec 2004 23:51:18 +0000 (23:51 +0000)]
r4420: - add usefull helper macros for allocation failures,
  they should be used in mostly all our code after
  calling a talloc_* function

  should be replaced by this new macros

(This used to be commit b6376590f4b2409b2237809d378d9425fe1ce07e)

16 years agor4419: move security_token stuff to the libcli/security/
Stefan Metzmacher [Thu, 30 Dec 2004 20:34:20 +0000 (20:34 +0000)]
r4419: move security_token stuff to the libcli/security/
and debug privileges

(This used to be commit c981808ed4cfa63c7ba7c4f9190b6b14f74bab40)

16 years agor4418: fix compiler warning and remove unused typedef
Stefan Metzmacher [Thu, 30 Dec 2004 19:55:23 +0000 (19:55 +0000)]
r4418: fix compiler warning and remove unused typedef

(This used to be commit 5861657fd12aae026c06ab8c6ae1f1656d06d0a1)

16 years agor4417: Reply to samr_QueryDomainInfo with the same static value as level2 does.
Volker Lendecke [Thu, 30 Dec 2004 19:11:25 +0000 (19:11 +0000)]
r4417: Reply to samr_QueryDomainInfo with the same static value as level2 does.

(This used to be commit 04cf580ef30ac38f3f312184a7b18551195a17ce)

16 years agor4416: [in,out] variables do have an r->out component...
Volker Lendecke [Thu, 30 Dec 2004 19:08:32 +0000 (19:08 +0000)]
r4416: [in,out] variables do have an r->out component...

(This used to be commit 97247c902962b7c0ac69691ae8d7300321de41d5)

16 years agor4415: Implement samr_RemoveMemberFromForeignDomain. This is needed to delete a user
Volker Lendecke [Thu, 30 Dec 2004 18:50:15 +0000 (18:50 +0000)]
r4415: Implement samr_RemoveMemberFromForeignDomain. This is needed to delete a user
with usrmgr.exe.

To fix: Remove domain group membership attrib values when a user is deleted.

(This used to be commit 83d180c732ba73cf50072ef73ccdd60e72bc9910)

16 years agor4414: Various bits&pieces:
Volker Lendecke [Thu, 30 Dec 2004 17:01:49 +0000 (17:01 +0000)]
r4414: Various bits&pieces:

* Implement samr_search_domain, filter out all elements with no "objectSid"
  attribute and all objects outside a specified domain sid.

* Minor cleanups in dcerpc_samr.c due to that.

* Implement srvsvc_NetSrvGetInfo level 100. A quick hack to get usrmgr.exe
  one step further.

* Same for samr_info_DomInfo1.

(This used to be commit cdec89611355fb75d253ecf5b658d0e23de8e440)

16 years agor4413: login failure doesn't warrant a level 1 debug (its filling my logs during...
Andrew Tridgell [Thu, 30 Dec 2004 11:24:49 +0000 (11:24 +0000)]
r4413: login failure doesn't warrant a level 1 debug (its filling my logs during torture tests)
(This used to be commit b9284c16dc37bf14fceeaa694e82f36a38b0dd93)

16 years agor4412: SEC_FILE_READ_ATTRIBUTE is always granted, even if not requested. This was...
Andrew Tridgell [Thu, 30 Dec 2004 07:10:31 +0000 (07:10 +0000)]
r4412: SEC_FILE_READ_ATTRIBUTE is always granted, even if not requested. This was being done
in the full ACL code, but not in the unix access check code, which meant that qfileinfo
was failing for some parameters
(This used to be commit 96d017e521f5a996a7a274682838855d077834bc)

16 years agor4411: when checking for create permissions, we need to check the parent, not the...
Andrew Tridgell [Thu, 30 Dec 2004 06:51:13 +0000 (06:51 +0000)]
r4411: when checking for create permissions, we need to check the parent, not the child!
(This used to be commit 30b4c20b1c9aea94dd2a0611b58860797d244e5a)

16 years agor4410: pvfs_rename_one() should not check for create permissions, as the rename
Andrew Tridgell [Thu, 30 Dec 2004 06:37:37 +0000 (06:37 +0000)]
r4410: pvfs_rename_one() should not check for create permissions, as the rename
is always in the same directory
(This used to be commit babf3480a4c29ce28d9a4525c4174a3d765dcbab)

16 years agor4409: fixed handling of zero access masks for the POSITION_INFORMATION query/set...
Andrew Tridgell [Thu, 30 Dec 2004 06:02:54 +0000 (06:02 +0000)]
r4409: fixed handling of zero access masks for the POSITION_INFORMATION query/set levels
(This used to be commit 75e7229476e1af6ab78fa5b41a7bb67df8e3d2dd)

16 years agor4408: added the remaining access check hooks into pvfs. All calls should now have...
Andrew Tridgell [Thu, 30 Dec 2004 05:50:23 +0000 (05:50 +0000)]
r4408: added the remaining access check hooks into pvfs. All calls should now have acl checking,
and obey the various inheritance rules.
(This used to be commit 5fe51807d6b97e68b65f152c0f405e5c5a025d21)

16 years agor4407: stricter checking of parameters on hard link creation in the RAW-RENAME test
Andrew Tridgell [Thu, 30 Dec 2004 05:48:32 +0000 (05:48 +0000)]
r4407: stricter checking of parameters on hard link creation in the RAW-RENAME test
(This used to be commit b239589b00e673ae2d6254083cd324bc3b54bcdf)

16 years agor4406: - don't call the xattr unlink hook on unlink unless the link count is 1, otherwise
Andrew Tridgell [Thu, 30 Dec 2004 03:19:27 +0000 (03:19 +0000)]
r4406: - don't call the xattr unlink hook on unlink unless the link count is 1, otherwise
  the xattrs of the remaining link are removed

- fix the handling of attribute set on directories
(This used to be commit fa44e3cce00b75656c85378c7825960540d2f282)

16 years agor4405: added acl inheritance to the mkdir and t2mkdir backends.
Andrew Tridgell [Thu, 30 Dec 2004 02:38:44 +0000 (02:38 +0000)]
r4405: added acl inheritance to the mkdir and t2mkdir backends.
(This used to be commit b44d4d17df8af4941740e5d5e0842ca01d8f403c)

16 years agor4404: check for SEC_ACE_FLAG_INHERIT_ONLY in the "maximum allowed" logic
Andrew Tridgell [Thu, 30 Dec 2004 02:27:16 +0000 (02:27 +0000)]
r4404: check for SEC_ACE_FLAG_INHERIT_ONLY in the "maximum allowed" logic
(This used to be commit e4ee8b776ba164a89afca43de20c166ccbfddb99)

16 years agor4403: - added ACL inheritance in the pvfs backend. ACLs are now inherited on
Andrew Tridgell [Thu, 30 Dec 2004 02:25:20 +0000 (02:25 +0000)]
r4403: - added ACL inheritance in the pvfs backend. ACLs are now inherited on
  file and directory creation via ntcreatex. pvfs now passes the
  inheritance test in RAW-ACLS

- cleaned up the error handling a bit in pvfs_open()
(This used to be commit f4dfb63d5395a365961a21388639809fcd3112d0)

16 years agor4402: use __location__ instead of __LINE__ in the RAW-RENAME test
Andrew Tridgell [Thu, 30 Dec 2004 02:22:29 +0000 (02:22 +0000)]
r4402: use __location__ instead of __LINE__ in the RAW-RENAME test
(This used to be commit 09ac1338209b0d0878173cfef3dca5603271b1a8)

16 years agor4401: stricter test for correct ACL inheritance in RAW-ACLS
Andrew Tridgell [Thu, 30 Dec 2004 02:22:03 +0000 (02:22 +0000)]
r4401: stricter test for correct ACL inheritance in RAW-ACLS
(This used to be commit 1bb769196377772326151210309ff12362eb0f2f)

16 years agor4400: Pass rootdse.ldif past the subst code.
Andrew Bartlett [Wed, 29 Dec 2004 22:59:28 +0000 (22:59 +0000)]
r4400: Pass rootdse.ldif past the subst code.

Andrew Bartlett
(This used to be commit d901c8fb64440fd8f966cc3d8929bb63551019fd)

16 years agor4399: Implement samr_GetAliasMembership and samr_GetGroupsForUser. With these two,
Volker Lendecke [Wed, 29 Dec 2004 22:57:20 +0000 (22:57 +0000)]
r4399: Implement samr_GetAliasMembership and samr_GetGroupsForUser. With these two,
usrmgr.exe seems to become usable. Some quirks, but it's worth a try.

(This used to be commit 9c62a239cd609092654ad653972153a3a71e7279)

16 years agor4398: Make usrmgr.exe believe we're a DC. Otherwise it will not show global groups.
Volker Lendecke [Wed, 29 Dec 2004 22:54:24 +0000 (22:54 +0000)]
r4398: Make usrmgr.exe believe we're a DC. Otherwise it will not show global groups.

Index on "key" attribute.

(This used to be commit 9c23d73ec213c3ef6e0afd671570b431a66f55c0)

16 years agor4397: Fix a bug where '(&(objectclass=domain)(!(objectclass=builtindomain)))' fell
Volker Lendecke [Wed, 29 Dec 2004 22:25:46 +0000 (22:25 +0000)]
r4397: Fix a bug where '(&(objectclass=domain)(!(objectclass=builtindomain)))' fell
back to a full search.

(This used to be commit 55c9fbd4f4afdde30a0d92bfd31f5c9ebb98c59b)