samba.git
13 years agoMake char* parameters const
Derrell Lipman [Tue, 24 Feb 2009 14:49:21 +0000 (09:49 -0500)]
Make char* parameters const

- Use const in function signatures whenever appropriate, to help prevent
  errant scribbling on users' buffers. smbc_set_credentials() always acted as
  if its formal parameters were const char *, and changing the formal
  declaration to specify that should not cause any change to the ABI. It is
  still allowable to pass a writable buffer to a function which specifies that
  it will not write to the buffer.

Derrell

13 years agoprefer gssapi header files from subdirectory
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory

this fixes some compile time noise on FreeBSD 7

13 years agoWHATSNEW: Update changes since 3.3.0.
Karolin Seeger [Tue, 24 Feb 2009 07:37:27 +0000 (08:37 +0100)]
WHATSNEW: Update changes since 3.3.0.

Karolin

13 years agoMore warning fixes for Solaris.
Jeremy Allison [Tue, 24 Feb 2009 00:23:42 +0000 (16:23 -0800)]
More warning fixes for Solaris.
Jeremy.

13 years agoMore warning fixes for Solaris.
Jeremy Allison [Mon, 23 Feb 2009 23:42:52 +0000 (15:42 -0800)]
More warning fixes for Solaris.
Jeremy.

13 years agoQuieten down a boatload of shadowed variable warnings on Solaris.
Jeremy Allison [Mon, 23 Feb 2009 23:02:52 +0000 (15:02 -0800)]
Quieten down a boatload of shadowed variable warnings on Solaris.
Makes real problems easier to spot.
Jeremy.

13 years agoVERSION: Raise version number.
Karolin Seeger [Mon, 23 Feb 2009 08:46:52 +0000 (09:46 +0100)]
VERSION: Raise version number.

Karolin

13 years agoWHATSNEW: Updates changes since 3.3.0.
Karolin Seeger [Mon, 23 Feb 2009 08:44:08 +0000 (09:44 +0100)]
WHATSNEW: Updates changes since 3.3.0.

Karolin

13 years agoall BSDs use this evironment variable
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit cd6ae0de52164dd6f50b3614f2511acb3eb15993)

13 years agos3/docs: Fix typo in man mount.cifs.
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.

Thanks to Tobias Stoeckmann for reporting!

Karolin
(cherry picked from commit 09a7f93f6be66a8f2a124e49b4effe2b5863f01d)

13 years agoFor some unknown reason ldbrename was not being built in samba3.
Simo Sorce [Sun, 22 Feb 2009 06:06:28 +0000 (01:06 -0500)]
For some unknown reason ldbrename was not being built in samba3.

13 years agoChange smbc_set_credentials_with_fallback() (unreleased) to use
Jeremy Allison [Sat, 21 Feb 2009 00:40:00 +0000 (16:40 -0800)]
Change smbc_set_credentials_with_fallback() (unreleased) to use
const approptiately.
Jeremy.

13 years agoFix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
Jeremy Allison [Fri, 20 Feb 2009 16:22:57 +0000 (08:22 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.

13 years agovariable grouping: just my OCD desire to keep similar things together
Derrell Lipman [Fri, 20 Feb 2009 15:03:55 +0000 (10:03 -0500)]
variable grouping: just my OCD desire to keep similar things together

13 years agoMake libsmbclient work with DFS
Bo Yang [Fri, 20 Feb 2009 04:21:52 +0000 (12:21 +0800)]
Make libsmbclient work with DFS

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
13 years agos3/docs: Add hint about getfattr in man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 13:14:54 +0000 (14:14 +0100)]
s3/docs: Add hint about getfattr in man vfs_acl_xattr.

Karolin
(cherry picked from commit 27307be0f726c899c0e8a0edfdf200650037bb61)

13 years agos3/docs: Add man vfs_acl_tdb.
Karolin Seeger [Fri, 20 Feb 2009 12:32:44 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_tdb.

Karolin
(cherry picked from commit 0fd1d4c0906158bab55871d53396bdc7ae533220)

13 years agos3/docs: Add man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 12:32:22 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_xattr.

Karolin
(cherry picked from commit 3b0114c0ba676dec2ece96983aff29257399f378)

13 years agos3/docs: Fix several typos.
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.

This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!

Karolin
(cherry picked from commit 54dbb030e2c6fed0abd0a3a89d08dad9b8a201a1)

13 years agoWHATSNEW: Update changes since 3.3.0.
Karolin Seeger [Fri, 20 Feb 2009 07:58:58 +0000 (08:58 +0100)]
WHATSNEW: Update changes since 3.3.0.

Karolin

13 years agoFix printf warnings found on systems where time_t <> long int.
Jeremy Allison [Thu, 19 Feb 2009 21:36:45 +0000 (13:36 -0800)]
Fix printf warnings found on systems where time_t <> long int.
Jeremy.

13 years agoFix printf type warning.
Jeremy Allison [Thu, 19 Feb 2009 21:09:45 +0000 (13:09 -0800)]
Fix printf type warning.
Jeremy.

13 years agoFix a O(n^2) algorithm in regdb_fetch_keys()
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()

13 years agoBackport the semantics of when to delete alternate data streams on a file truncate.
Jeremy Allison [Thu, 19 Feb 2009 19:19:10 +0000 (11:19 -0800)]
Backport the semantics of when to delete alternate data streams on a file truncate.
Needed to fully support stream semantics.
Jeremy.

13 years agoFix a buffer handling bug when adding lots of registry keys
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys

This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)
(cherry picked from commit 36ae846d15027df5e3a02ffabb08183dad9f6517)

13 years agos3-libnet: fix coverity #848 (UNINIT).
Günther Deschner [Thu, 19 Feb 2009 01:35:20 +0000 (02:35 +0100)]
s3-libnet: fix coverity #848 (UNINIT).

Guenther
(cherry picked from commit e9d5405948e35a8eec0b49cc6c066278cb523397)

13 years agoWHATSNEW: Jeremy fixed CID 602, not Volker.
Karolin Seeger [Thu, 19 Feb 2009 11:27:50 +0000 (12:27 +0100)]
WHATSNEW: Jeremy fixed CID 602, not Volker.

Thanks Volker for reading the release notes! ;-)

Karolin

13 years agoWHATSNEW: Update changes since 3.3.0.
Karolin Seeger [Thu, 19 Feb 2009 09:07:40 +0000 (10:07 +0100)]
WHATSNEW: Update changes since 3.3.0.

Karolin

13 years agoGah, typo :-(. Sorry.
Jeremy Allison [Thu, 19 Feb 2009 00:00:34 +0000 (16:00 -0800)]
Gah, typo :-(. Sorry.

13 years agoFix coverity CID-602. Possible use of uninitialized var.
Jeremy Allison [Wed, 18 Feb 2009 23:43:03 +0000 (15:43 -0800)]
Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.

13 years agoWHATSNEW: Update changes since 3.3.0.
Karolin Seeger [Wed, 18 Feb 2009 08:30:27 +0000 (09:30 +0100)]
WHATSNEW: Update changes since 3.3.0.

Karolin

13 years agoDon't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin...
Jeremy Allison [Tue, 17 Feb 2009 23:55:36 +0000 (15:55 -0800)]
Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.

13 years agoFix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy Allison [Tue, 17 Feb 2009 21:43:28 +0000 (13:43 -0800)]
Fix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy.

13 years agos3: remove duplicate prototypes for generated rpc server functions.
Günther Deschner [Tue, 17 Feb 2009 14:42:06 +0000 (15:42 +0100)]
s3: remove duplicate prototypes for generated rpc server functions.

Guenther

13 years agos3:make: use pidl/pidl for 'make idl'
Stefan Metzmacher [Tue, 17 Feb 2009 09:28:37 +0000 (10:28 +0100)]
s3:make: use pidl/pidl for 'make idl'

metze

13 years agofix proto.h after idl changes
Stefan Metzmacher [Tue, 17 Feb 2009 09:28:04 +0000 (10:28 +0100)]
fix proto.h after idl changes

metze

13 years agolibrpc: rerun 'PIDL=pidl/pidl make idl'
Stefan Metzmacher [Tue, 17 Feb 2009 08:04:58 +0000 (09:04 +0100)]
librpc: rerun 'PIDL=pidl/pidl make idl'

metze

13 years agos3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
Stefan Metzmacher [Mon, 16 Feb 2009 09:20:55 +0000 (10:20 +0100)]
s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED

This hopefully fixes bug #6100.

metze
(cherry picked from commit fe417b29bd23b7b935669993e0f01de4c7de2378)

13 years agonetlogon.idl: add idl for netr_LogonGetCapabilities()
Stefan Metzmacher [Mon, 16 Feb 2009 09:42:43 +0000 (10:42 +0100)]
netlogon.idl: add idl for netr_LogonGetCapabilities()

metze
(cherry picked from commit 8339969ed39e4cf3577971869ef2fd127f1c3ae3)

13 years agos3-accessmask: re-run make samba3-idl and remove duplicate copies.
Günther Deschner [Fri, 31 Oct 2008 21:39:25 +0000 (22:39 +0100)]
s3-accessmask: re-run make samba3-idl and remove duplicate copies.

Guenther

13 years agos3: re-run make idl.
Günther Deschner [Tue, 17 Feb 2009 01:43:12 +0000 (02:43 +0100)]
s3: re-run make idl.

No panic, this just removes the NDR_BUFFER flag from ndr functions when there is
no buffer to process.

Guenther

13 years agopidl: add copy of pidl to 3-3-test in order to regenerate librpc code.
Günther Deschner [Tue, 17 Feb 2009 01:35:00 +0000 (02:35 +0100)]
pidl: add copy of pidl to 3-3-test in order to regenerate librpc code.

pidl's reference is 79190992b3820cd028c961c48bdea9b35baf13c9 here.

Guenther

13 years agos3-WHATSNEW: Update WHATSNEW.
Karolin Seeger [Mon, 16 Feb 2009 14:38:51 +0000 (15:38 +0100)]
s3-WHATSNEW: Update WHATSNEW.

Karolin

13 years agoMake sharesec utility part of the default binary install.
Steven Danneman [Fri, 26 Dec 2008 20:41:29 +0000 (12:41 -0800)]
Make sharesec utility part of the default binary install.

This used to be commit 8f84d42f7.

13 years agoFix bug 5920
Yasuma Takeda [Mon, 16 Feb 2009 13:07:37 +0000 (14:07 +0100)]
Fix bug 5920

The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
(cherry picked from commit cb9dd0f58d06a78b7724c3e0ec8f81512edc2d29)

13 years agos3-WHATSNEW: Start WHATSNEW for 3.3.1.
Karolin Seeger [Mon, 16 Feb 2009 10:30:30 +0000 (11:30 +0100)]
s3-WHATSNEW: Start WHATSNEW for 3.3.1.

Karolin

13 years agoAttempt to fix bug #6099. According to Microsoft
Jeremy Allison [Mon, 16 Feb 2009 02:18:38 +0000 (18:18 -0800)]
Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.

13 years agoRemove compiler warnings about unknown structure pointer
Derrell Lipman [Sun, 15 Feb 2009 20:00:25 +0000 (15:00 -0500)]
Remove compiler warnings about unknown structure pointer

13 years agos3 vfs: Fix SMB_VFS_RECVFILE/SENDFILE macros
Tim Prouty [Sun, 15 Feb 2009 04:34:41 +0000 (20:34 -0800)]
s3 vfs: Fix SMB_VFS_RECVFILE/SENDFILE macros

13 years agoremove accidental white space
Derrell Lipman [Sun, 15 Feb 2009 03:30:21 +0000 (22:30 -0500)]
remove accidental white space

13 years agoenums are traditionally signed. Avoid use of high bit in bit flags.
Derrell Lipman [Sun, 15 Feb 2009 03:30:13 +0000 (22:30 -0500)]
enums are traditionally signed. Avoid use of high bit in bit flags.

13 years agoGet rid of the warnings I had for testing
Derrell Lipman [Sat, 14 Feb 2009 23:56:44 +0000 (18:56 -0500)]
Get rid of the warnings I had for testing

13 years agoIt seems some systems use f_flags instead of f_flag. Use the appropriate one.
Derrell Lipman [Sat, 14 Feb 2009 21:11:50 +0000 (16:11 -0500)]
It seems some systems use f_flags instead of f_flag. Use the appropriate one.

13 years agoEnsure consistency of values on stack (caught by AIX compiler)
Derrell Lipman [Sat, 14 Feb 2009 15:07:51 +0000 (10:07 -0500)]
Ensure consistency of values on stack (caught by AIX compiler)

13 years agoignore new test program executables
Derrell Lipman [Sat, 14 Feb 2009 14:43:46 +0000 (09:43 -0500)]
ignore new test program executables

13 years agoCheck for the right error return value
Derrell Lipman [Sat, 14 Feb 2009 14:42:59 +0000 (09:42 -0500)]
Check for the right error return value

13 years agoEnable total anonymization in vfs_smb_traffic_analyzer, by mapping any user names...
Holger Hetterich [Wed, 4 Feb 2009 14:31:24 +0000 (15:31 +0100)]
Enable total anonymization in vfs_smb_traffic_analyzer, by mapping any user names to the one given by anonymize_prefix, without generating a hash number. This setting is optional and is compatible with the module configuration format of Samba 3.3.

13 years agoParameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
Jeremy Allison [Sat, 14 Feb 2009 00:04:15 +0000 (16:04 -0800)]
Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.

13 years agoNoted by Vericode analysis. Correctly use chroot().
Jeremy Allison [Fri, 13 Feb 2009 23:08:57 +0000 (15:08 -0800)]
Noted by Vericode analysis. Correctly use chroot().
Jeremy.

13 years agoFix Coverity ID 740 (RESOURCE_LEAK)
Volker Lendecke [Fri, 13 Feb 2009 20:52:21 +0000 (21:52 +0100)]
Fix Coverity ID 740 (RESOURCE_LEAK)

13 years agoFix Coverity IDs 879 and 880 (RESOURCE_LEAK, REVERSE_INULL)
Volker Lendecke [Fri, 13 Feb 2009 18:06:39 +0000 (10:06 -0800)]
Fix Coverity IDs 879 and 880 (RESOURCE_LEAK, REVERSE_INULL)

13 years agoFix Coverity ID 742 (RESOURCE_LEAK)
Volker Lendecke [Fri, 13 Feb 2009 17:58:35 +0000 (09:58 -0800)]
Fix Coverity ID 742 (RESOURCE_LEAK)

13 years agoFix Coverity ID 744
Volker Lendecke [Fri, 13 Feb 2009 17:53:56 +0000 (09:53 -0800)]
Fix Coverity ID 744

This was marked as a resource leak. This change makes the code a bit clearer
that we always free error_string.

13 years agos3:auth: only create_local_token() should add S-1-22-X-Y sids
Stefan Metzmacher [Wed, 11 Feb 2009 10:47:41 +0000 (11:47 +0100)]
s3:auth: only create_local_token() should add S-1-22-X-Y sids

metze
(cherry picked from commit e7f7ed8bf6281ef01aca53ea44acdd4af4c51aa7)

13 years agos3:auth: add S-1-22-X-Y sids to the local token
Stefan Metzmacher [Wed, 11 Feb 2009 10:46:18 +0000 (11:46 +0100)]
s3:auth: add S-1-22-X-Y sids to the local token

metze
(cherry picked from commit f14e4d4e54f424c05147cb0e635c9b8930270262)

13 years agoFix Coverity ID 745 (RESOURCE_LEAK)
Volker Lendecke [Fri, 13 Feb 2009 10:18:31 +0000 (11:18 +0100)]
Fix Coverity ID 745 (RESOURCE_LEAK)

13 years agoFix double free caused by incorrect talloc_steal usage.
Dan Sledz [Thu, 12 Feb 2009 20:02:43 +0000 (12:02 -0800)]
Fix double free caused by incorrect talloc_steal usage.

13 years ago[Bug 6069] Add a fstatvfs function for libsmbclient
Derrell Lipman [Thu, 12 Feb 2009 14:16:48 +0000 (09:16 -0500)]
[Bug 6069] Add a fstatvfs function for libsmbclient

- DFS is not a POSIX feature, so the state of that bit should be zero if DFS
  is *not* supported. Bit feature reversed.

- Added smbc_statvfs function

Derrell

13 years agoFix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not work corre...
Yasuma Takeda [Wed, 11 Feb 2009 22:36:51 +0000 (14:36 -0800)]
Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not work correctly with "security = domain"

1. If DNS server is invalid, the get_sorted_dc_list() is called with
realm(FQDN) and it fails.
2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) again.

I think "again" is wrong place.
On the 2nd step, get_sorted_dc_list() should be called with realm(WORKGROUP).

13 years agos3:packaging: fix parsing of include.h in fill-templates
Michael Adam [Wed, 11 Feb 2009 21:27:48 +0000 (22:27 +0100)]
s3:packaging: fix parsing of include.h in fill-templates

The content has changed slightly in master for the merged build,
and we must be more exact when parsing the lines.

Michael

13 years agos3:packaging: fix path to calling update-pkginfo after pushd in fill-templates
Michael Adam [Wed, 11 Feb 2009 21:25:41 +0000 (22:25 +0100)]
s3:packaging: fix path to calling update-pkginfo after pushd in fill-templates

Michael

13 years agos3:packaging: paths cosmetics in fill-templates
Michael Adam [Wed, 11 Feb 2009 21:24:52 +0000 (22:24 +0100)]
s3:packaging: paths cosmetics in fill-templates

Michael

13 years agoenable IPv6 support for NetBSD, FreeBSD
Björn Jacke [Wed, 11 Feb 2009 15:34:02 +0000 (16:34 +0100)]
enable IPv6 support for NetBSD, FreeBSD

most systems include netinet/in.h via netdb.h but *BSD don't.

13 years agos3:build: some implementations of "ln" are picky about the order of arguments
Michael Adam [Wed, 11 Feb 2009 10:02:57 +0000 (11:02 +0100)]
s3:build: some implementations of "ln" are picky about the order of arguments

Michael

13 years agoFix resume handle for _samr_EnumDomainGroups
Volker Lendecke [Wed, 11 Feb 2009 03:08:46 +0000 (19:08 -0800)]
Fix resume handle for _samr_EnumDomainGroups

13 years agopackaging: make update-pkginfo callable from any directory
Michael Adam [Tue, 10 Feb 2009 22:52:40 +0000 (23:52 +0100)]
packaging: make update-pkginfo callable from any directory

Michael
(cherry picked from commit 7ea90835ebf6e2f2c6f325760800d8361d087ede)

13 years agopackaging: use "find" instead of "du" to find files... :-)
Michael Adam [Fri, 12 Sep 2008 13:07:00 +0000 (15:07 +0200)]
packaging: use "find" instead of "du" to find files... :-)

Michael
(This used to be commit 768aa82361a2c4b0aab71433b7593723a2868f0a)
(cherry picked from commit fd7635a1161e25d88a8252a5cf9de70ca2fe4232)

13 years agopackaging: remove commented out stuff from update-pkginfo
Michael Adam [Tue, 10 Feb 2009 22:50:14 +0000 (23:50 +0100)]
packaging: remove commented out stuff from update-pkginfo

Michael
(cherry picked from commit d714e58ec1f74897cd13e7cd9dd9003600052b45)

13 years agopackaging: don't clutter the output of fillup-templates with popd output
Michael Adam [Tue, 10 Feb 2009 22:31:52 +0000 (23:31 +0100)]
packaging: don't clutter the output of fillup-templates  with popd output

Michael
(cherry picked from commit 0c711935d30b500a15ef06fd658d382b2c1e2c84)

13 years agopackaging: fix fill-templates call to update-pkginfo to pushd appropriately first
Michael Adam [Tue, 10 Feb 2009 22:30:48 +0000 (23:30 +0100)]
packaging: fix fill-templates call to update-pkginfo to pushd appropriately first

Michael
(cherry picked from commit c28d4ae537d9fc0b76eae758d32356eaf1113c89)

13 years agopackaging: add script fill-templates
Michael Adam [Tue, 10 Feb 2009 17:54:16 +0000 (18:54 +0100)]
packaging: add script fill-templates

This is a standalone-wrapper for update-pkginfo, which is
usually called from create-tarball. It basically repeats
some functionality of create-tarball.

Michael
(cherry picked from commit ca23469a906bab690162184e8d3949897f7b5a67)

13 years ago[Bug 6069] Add a fstatvfs function for libsmbclient
Derrell Lipman [Tue, 10 Feb 2009 20:03:32 +0000 (15:03 -0500)]
[Bug 6069] Add a fstatvfs function for libsmbclient

- Fill in the remainder of the data (or at least as much as we can get) for
  the fstatvfs return value.

Derrell

13 years ago[Bug 6069] Add a fstatvfs function for libsmbclient
Derrell Lipman [Tue, 10 Feb 2009 15:28:32 +0000 (10:28 -0500)]
[Bug 6069] Add a fstatvfs function for libsmbclient

- Reverse the sense of the flags. Since the fstatvfs() function on POSIX-like
  systems would almost certainly indicate case sensitivity (for example),
  leave the bit turned off if the result is the POSIX-like result just as if
  issued on a typical local file system on a POSIX system.

Derrell

13 years agos3-spoolss: fix memleak in get_remote_printer_publishing_data().
Günther Deschner [Tue, 10 Feb 2009 09:59:34 +0000 (10:59 +0100)]
s3-spoolss: fix memleak in get_remote_printer_publishing_data().

Guenther

13 years ago[Bug 6069] Add a fstatvfs function for libsmbclient
Derrell Lipman [Tue, 10 Feb 2009 03:46:29 +0000 (22:46 -0500)]
[Bug 6069] Add a fstatvfs function for libsmbclient

- Complete the implementation of the f_flag field. We now return a flag
  indicatin UNIX CIFS, CASE SENSITIVE, and/or DFS support.

Derrell

13 years agoRevert "s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary."
Michael Adam [Mon, 9 Feb 2009 22:26:36 +0000 (23:26 +0100)]
Revert "s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary."

This reverts commit 3981603761a1cc6fb74ff135fadf4ab3340be1c5.

I was confused about the real meaning of find_domain_from_name_noinit()
vs. find_domain_from_name(). We don't need the connection established
here, just the domain struct which gets initialized by rescan_trusted_domains().

Sorry for the noise.

Michael

13 years agodocs: Add man sharesec.
Karolin Seeger [Mon, 9 Feb 2009 20:00:47 +0000 (21:00 +0100)]
docs: Add man sharesec.

Karolin
(cherry picked from commit cc51cbc862055975bcef016876662576b00e72ef)

13 years ago[Bug 6069] Add a fstatvfs function for libsmbclient
Derrell Lipman [Mon, 9 Feb 2009 17:41:29 +0000 (12:41 -0500)]
[Bug 6069] Add a fstatvfs function for libsmbclient

- Add initial test implementation. This works on a Linux client to determine
  whether a connection's server supports UNIX CIFS. I'm eager to see what the
  build farm has to say about this, specifically how many, if any, hosts don't
  provide a statvfs.h file with the requisite struct statvfs.

Derrell

13 years agos3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary.
Michael Adam [Mon, 9 Feb 2009 12:50:31 +0000 (13:50 +0100)]
s3:winbindd_user: create domain connection in winbindd_fill_pwent if necessary.

Calling find_domain_from_name_noinit() might not be enough here.
This makes winbindd_getpwent() behave the same as winbindd_getgrent().

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3:winbindd_user: fix a debug message.
Michael Adam [Mon, 9 Feb 2009 10:07:11 +0000 (11:07 +0100)]
s3:winbindd_user: fix a debug message.

find_domain_from_name_noinit() is no longer called only for
name alias support.

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agoFix coverity ID 876 (FORWARD_NULL)
Volker Lendecke [Sat, 7 Feb 2009 10:09:45 +0000 (11:09 +0100)]
Fix coverity ID 876 (FORWARD_NULL)

Michael, please check!

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agoFix count in _srvsvc_NetDiskEnum()
Volker Lendecke [Mon, 9 Feb 2009 11:32:16 +0000 (12:32 +0100)]
Fix count in _srvsvc_NetDiskEnum()

Without this, remotely adding a share via MMC fails
(cherry picked from commit 197b4c42bbf53347f4953e39099192693d709a7d)

13 years agos3-rpcclient: fix getform command asprintf return code.
Günther Deschner [Sun, 8 Feb 2009 23:06:36 +0000 (00:06 +0100)]
s3-rpcclient: fix getform command asprintf return code.

Guenther

13 years agoeliminate compiler warnings
Derrell Lipman [Mon, 9 Feb 2009 03:07:25 +0000 (22:07 -0500)]
eliminate compiler warnings

13 years agomount.cifs: initialize rc to 0 in main
Jeff Layton [Fri, 6 Feb 2009 13:31:45 +0000 (08:31 -0500)]
mount.cifs: initialize rc to 0 in main

The value of rc in main() isn't initialized in the declaration. This
wasn't a problem before, but Shirish's fakemount patch can make it so
that we return the uninitialized variable if the -n flag is used.

Fix this by initializing rc to 0.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
13 years agomount.cifs: add fakemount (-f) and nomtab (-n) flags to mount.cifs
Shirish Pargaonkar [Fri, 6 Feb 2009 13:15:35 +0000 (08:15 -0500)]
mount.cifs: add fakemount (-f) and nomtab (-n) flags to mount.cifs

...so that these options work correctly when passed in by mount(8).

13 years agos3:net conf: remove check for sharename being a usernam in "net conf addshare"
Michael Adam [Fri, 6 Feb 2009 09:42:11 +0000 (10:42 +0100)]
s3:net conf: remove check for sharename being a usernam in "net conf addshare"

This is useless and can be overriden by "net conf setparm" anyways.

Michael

13 years agodocs: fix two typos in the mount.cifs manpage
Michael Adam [Thu, 5 Feb 2009 21:19:58 +0000 (22:19 +0100)]
docs: fix two typos in the mount.cifs manpage

Michael
(cherry picked from commit 145fe37766cf1ecffb16a03b58b44d08f7ed7558)

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agodocs: Clarify "ldap ssl" description in man smb.conf.
Karolin Seeger [Fri, 6 Feb 2009 08:41:21 +0000 (09:41 +0100)]
docs: Clarify "ldap ssl" description in man smb.conf.

Mention "ldap ssl ads".

Karolin
(cherry picked from commit 61f1747441ff43c1d9c99bbf69e218c1984834c7)

13 years agodocs: Add description of "ldap ssl ads" to man smb.conf.
Karolin Seeger [Fri, 6 Feb 2009 08:10:15 +0000 (09:10 +0100)]
docs: Add description of "ldap ssl ads" to man smb.conf.

Karolin
(cherry picked from commit 02f13538f00cc8368e3e5e8e510bac468c21089b)