Andrew Bartlett [Mon, 18 Oct 2010 22:12:57 +0000 (09:12 +1100)]
s4-provision Remove serverdn parameter from Schema()
We don't need to know the server DN here any more, and it
makes no sense for many callers.
Andrew Bartlett
Andrew Tridgell [Tue, 19 Oct 2010 03:53:14 +0000 (14:53 +1100)]
s4-dsdb: register the DCPROMO_OID control with the rootdse
this is needed to allow it over ldap
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 19 04:44:23 UTC 2010 on sn-devel-104
Andrew Tridgell [Tue, 19 Oct 2010 03:49:17 +0000 (14:49 +1100)]
selftest: terminate selftest if we can't setup the environment
Andrew Tridgell [Tue, 19 Oct 2010 00:47:22 +0000 (11:47 +1100)]
s4-ldb: increase minor version for 2 new functions
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 19 01:27:44 UTC 2010 on sn-devel-104
Andrew Tridgell [Tue, 19 Oct 2010 00:22:12 +0000 (11:22 +1100)]
s4-ldap: mark all ldap:// requests as untrusted
this allows the rootdse module to filter unregistered controls
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 19 Oct 2010 00:21:45 +0000 (11:21 +1100)]
s4-dsdb: filter unregistered controls in the rootdse module
if we get an unregistered control in the rootdse module, and the
request comes from an untrusted source (eg. ldap://) then we need to:
1) filter the control out if it is marked non-critical
2) give an error if it is marked critical
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 19 Oct 2010 00:20:14 +0000 (11:20 +1100)]
s4-ldb: cope with NULL oid in controls
the ldap server will mark a control with a NULL oid in order to remove
it. This prevents a O(n^2) cost in control handling.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 19 Oct 2010 00:19:20 +0000 (11:19 +1100)]
s4-ldb: added --relax cmdline option
this adds the relax control
Andrew Tridgell [Tue, 19 Oct 2010 00:17:53 +0000 (11:17 +1100)]
s4-ldb: added ldb_req_mark_untrusted() and ldb_req_is_untrusted()
these will be used to determine if a ldb request comes from an
untrusted source. We want requests over ldap:// to be marked untrusted
so we can reject unregistered controls
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Mon, 18 Oct 2010 04:17:56 +0000 (15:17 +1100)]
waf: put -Wl,-no-undefined only in the linker flags, not when compiling C
Andrew Tridgell [Sun, 17 Oct 2010 11:34:17 +0000 (22:34 +1100)]
waf: don't save deps on install
this prevents an install triggering a new check of the project rules
on the next build
Andrew Tridgell [Sun, 17 Oct 2010 10:58:22 +0000 (21:58 +1100)]
waf: automap shared library names from .so to the right extension
this should help with MacOSX .dylib libraries
Andrew Tridgell [Sat, 16 Oct 2010 08:54:05 +0000 (19:54 +1100)]
readline: fixed the test for history_list()
Andrew Tridgell [Sat, 16 Oct 2010 08:53:17 +0000 (19:53 +1100)]
replace: cope with systems that have fdatasync(), but don't have the prototype
this is needed for MacOSX 10.4.1
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 19:22:37 +0000 (21:22 +0200)]
s4:ldap_server - use error code constant
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Oct 18 20:32:40 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 19:21:45 +0000 (21:21 +0200)]
ldb: always return PROTOCOL_ERROR if an operation is unsupported
That's exactly the behaviour of various LDAP servers.
Matthieu Patou [Mon, 18 Oct 2010 18:23:00 +0000 (22:23 +0400)]
selftest: use full path for selftest.pl instead of relative paths
FindBin on solaris8 with perl 5.04 has problem to get the path of the
called script if the script is called with a relative path.
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Mon Oct 18 19:50:03 UTC 2010 on sn-devel-104
Matthieu Patou [Mon, 18 Oct 2010 16:21:12 +0000 (20:21 +0400)]
selftest: correct the import of Time::HighRes
The "use" is always evaluated first even if enclosed into a if. So
on plateform without Time::Hires (ie. sun8 in the build farm). This
leads to an error.
Instead we use the synthax require Module + Module->import("function")
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:19:00 +0000 (20:19 +0200)]
ldb:"ldb_schema_attribute_by_name_internal" - switch back to 32bit counters
Use the signed counter for the binary search but use an unsigned one for
accessing the entry.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Oct 18 19:01:31 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:10:17 +0000 (20:10 +0200)]
ldb:ldb_tdb.c - fix up counter variables
"find_element" returns an "int" since there is also the possibility that a
certain element doesn't exist - then "-1" is returned. But beside this
exception treat all other return values as unsigned.
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:07:49 +0000 (20:07 +0200)]
ldb:ldb_tdb.c - improve the error outputs
- Fix indentation
- Include always the failing DN
- Reorder the outputs to make them consistent
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 17:24:43 +0000 (19:24 +0200)]
s4:"util_ldb" - remove some really unused dependancies
Stefan Metzmacher [Mon, 11 Oct 2010 20:29:30 +0000 (22:29 +0200)]
libcli/nbt: we don't need LIBCLI_COMPOSITE anymore
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 18 16:18:32 UTC 2010 on sn-devel-104
Stefan Metzmacher [Mon, 11 Oct 2010 19:18:15 +0000 (21:18 +0200)]
libcli/nbt: convert nbt_name_register_bcast_send/recv to tevent_req
metze
Stefan Metzmacher [Mon, 11 Oct 2010 19:01:23 +0000 (21:01 +0200)]
libcli/nbt: s/name_register_bcast_handler/nbt_name_register_bcast_handler
metze
Stefan Metzmacher [Mon, 11 Oct 2010 18:59:35 +0000 (20:59 +0200)]
libcli/nbt: s/register_bcast_state/nbt_name_register_bcast_state/
metze
Stefan Metzmacher [Mon, 11 Oct 2010 18:57:58 +0000 (20:57 +0200)]
libcli/nbt: move nbt_name_register_bcast_send to the top of nbt_name_register_bcast_*
metze
Stefan Metzmacher [Mon, 11 Oct 2010 20:17:02 +0000 (22:17 +0200)]
s4:nbt_server/register: add a nbtd_register_name_state
metze
Stefan Metzmacher [Mon, 11 Oct 2010 19:58:29 +0000 (21:58 +0200)]
libcli/nbt: convert nbt_name_register_wins_send/recv to tevent_req
metze
Stefan Metzmacher [Mon, 11 Oct 2010 19:23:58 +0000 (21:23 +0200)]
libcli/nbt: s/name_register_wins_handler/nbt_name_register_wins_handler
metze
Stefan Metzmacher [Mon, 11 Oct 2010 19:21:26 +0000 (21:21 +0200)]
libcli/nbt: s/register_wins_state/nbt_name_register_wins_state
metze
Stefan Metzmacher [Mon, 11 Oct 2010 19:19:59 +0000 (21:19 +0200)]
libcli/nbt: move nbt_name_register_wins_send() to the top of all nbt_name_register_wins_* related code
metze
Stefan Metzmacher [Mon, 11 Oct 2010 18:49:28 +0000 (20:49 +0200)]
s4:nbt_server/winsclient: add a nbtd_wins_register_state
We now keep the nbtd_wins_register_state around between
nbt_name_register_wins_send() and nbt_name_register_wins_recv()
metze
Stefan Metzmacher [Mon, 11 Oct 2010 06:54:27 +0000 (08:54 +0200)]
libcli/nbt: convert nbt_name_refresh_wins_send/recv to tevent_req
metze
Stefan Metzmacher [Mon, 11 Oct 2010 06:33:06 +0000 (08:33 +0200)]
libcli/nbt: s/name_refresh_wins_handler/nbt_name_refresh_wins_handler
metze
Stefan Metzmacher [Mon, 11 Oct 2010 06:18:16 +0000 (08:18 +0200)]
libcli/nbt: s/refresh_wins_state/nbt_name_refresh_wins_state
metze
Stefan Metzmacher [Mon, 11 Oct 2010 06:15:01 +0000 (08:15 +0200)]
libcli/nbt: move nbt_name_refresh_wins_send() to the top of all nbt_name_refresh_wins_* related code
metze
Stefan Metzmacher [Mon, 11 Oct 2010 07:41:16 +0000 (09:41 +0200)]
s4:nbt_server/winsclient: add a nbtd_wins_refresh_state
We now keep the nbtd_wins_refresh_state around between
nbt_name_refresh_wins_send() and nbt_name_refresh_wins_recv()
metze
Stefan Metzmacher [Mon, 11 Oct 2010 20:26:09 +0000 (22:26 +0200)]
s4:nbt_server/wins: fix compiler warnings
metze
Tim Potter [Mon, 18 Oct 2010 14:54:31 +0000 (07:54 -0700)]
Include misc.idl for policy_handle in srvsvc.idl.
Autobuild-User: Tim Potter <tpot@samba.org>
Autobuild-Date: Mon Oct 18 15:35:40 UTC 2010 on sn-devel-104
Günther Deschner [Mon, 18 Oct 2010 13:55:47 +0000 (15:55 +0200)]
s3: fix the build of idmap_adex, idmap_tdb2, idmap_hash and several vfs modules.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Oct 18 14:39:39 UTC 2010 on sn-devel-104
Günther Deschner [Mon, 18 Oct 2010 13:55:16 +0000 (15:55 +0200)]
s3-waf: fix the build after libcli/security changes.
Guenther
Günther Deschner [Mon, 11 Oct 2010 22:46:53 +0000 (00:46 +0200)]
s3-waf: fix the build of smbtorture.
Guenther
Günther Deschner [Mon, 11 Oct 2010 22:26:03 +0000 (00:26 +0200)]
s3-waf: fix pdb modules build.
Guenther
Stefan Metzmacher [Mon, 11 Oct 2010 21:04:28 +0000 (23:04 +0200)]
s4:libcli/util: add pipe related NT_STATUS_RPC_* codes
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 18 13:50:55 UTC 2010 on sn-devel-104
Stefan Metzmacher [Mon, 11 Oct 2010 21:03:34 +0000 (23:03 +0200)]
s3:libsmb: add pipe related NT_STATUS_RPC_* codes
metze
Stefan Metzmacher [Mon, 11 Oct 2010 21:02:38 +0000 (23:02 +0200)]
libcli/util: add pipe related NT_STATUS_RPC_* codes
metze
Andreas Schneider [Fri, 15 Oct 2010 15:58:39 +0000 (17:58 +0200)]
s3-winbind: Fixed init order.
We need the system server info in the rpc services.
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Oct 18 12:43:16 UTC 2010 on sn-devel-104
Stefan Metzmacher [Mon, 18 Oct 2010 10:20:56 +0000 (12:20 +0200)]
librpc: Fixed memory context of dcerpc_binding_from_tower.
Andreas Schneider [Mon, 18 Oct 2010 09:50:04 +0000 (11:50 +0200)]
s4-gensec: Add dependency on com_err to GENSEC_KRB5.
Andrew Bartlett [Mon, 18 Oct 2010 11:13:20 +0000 (22:13 +1100)]
s4-ldb Add LDB_REQ_SET_LOCATION to help track handler use
This greatly assists in debugging what is going on with the
ldb handle, as it indicates where it was created.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Oct 18 11:54:46 UTC 2010 on sn-devel-104
Andrew Bartlett [Mon, 18 Oct 2010 11:11:40 +0000 (22:11 +1100)]
s4-selftest Make GDB_PROVISION work again
gdb --args won't run the #!/usr/bin/evn python
Andrew Bartlett
Andrew Bartlett [Mon, 18 Oct 2010 03:06:50 +0000 (14:06 +1100)]
ldb Ensure we mark ongoing LDAP requests as PENDING
Andrew Bartlett [Mon, 18 Oct 2010 00:49:55 +0000 (11:49 +1100)]
s4-openldap-backend Don't set 'dbnosync' on cn=config
This isn't valid in current OpenLDAP versions.
Andrew Bartlett
Andrew Bartlett [Mon, 18 Oct 2010 00:48:14 +0000 (11:48 +1100)]
s4-provision Use --ldap-backend-nosync rather than just --nosync
For some reason we had both options, and --ldap-backend-nosync is
the better name.
Andrew Bartlett
Jelmer Vernooij [Mon, 18 Oct 2010 09:35:46 +0000 (11:35 +0200)]
heimdal_build: Add dependency on com_err to HEIMDAL_CONFIG.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Oct 18 10:27:47 UTC 2010 on sn-devel-104
Samba-JP oota [Mon, 18 Oct 2010 05:10:29 +0000 (07:10 +0200)]
This is typo fix patch for smbcacls.1.xml .
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Oct 18 05:53:26 UTC 2010 on sn-devel-104
Andrew Bartlett [Sun, 17 Oct 2010 23:48:21 +0000 (10:48 +1100)]
dsdb simple_ldap_map depends on LDBSAMBA
This shows up at build time on MacOS and runtime on Linux when we
use the LDAP backend.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Oct 18 00:57:51 UTC 2010 on sn-devel-104
Andrew Bartlett [Sun, 17 Oct 2010 23:24:56 +0000 (10:24 +1100)]
Revert "s4:dsdb - make the RELAX control private"
This must be available to the OpenLDAP backend, to set the GUID values
in some situations. We need a proper ACL mechanism to control the use
or abuse of this control.
This reverts commit
10adee89367cee9add993869280542418fb3d370.
Jelmer Vernooij [Sun, 17 Oct 2010 23:28:53 +0000 (01:28 +0200)]
heimdal: Attempt to fix path of hdb_asn1.h
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Oct 18 00:15:11 UTC 2010 on sn-devel-104
Jelmer Vernooij [Sun, 17 Oct 2010 23:17:56 +0000 (01:17 +0200)]
dsdb: Module aliases require to be prefixed with the subsystem name.
Jelmer Vernooij [Sun, 17 Oct 2010 18:35:04 +0000 (20:35 +0200)]
dcerpc_samr: Fix -l arguments for dcerpc_samr and dcerpc_atsvc.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 17 19:15:43 UTC 2010 on sn-devel-104
Jelmer Vernooij [Sun, 17 Oct 2010 17:39:09 +0000 (19:39 +0200)]
tdb: Bump version to 1.2.7 after addition of pytdb.__version__.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 17 18:23:16 UTC 2010 on sn-devel-104
Jelmer Vernooij [Sat, 16 Oct 2010 17:01:18 +0000 (19:01 +0200)]
heimdal: Add local simpler copy of to_list().
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 12:27:18 +0000 (14:27 +0200)]
Revert "s4:remove "util_ldb" submodule and integrate the three gendb_* calls in "dsdb/common/util.c""
This reverts commit
8a2ce5c47cee499f90b125ebde83de5f9f1a9aa0.
Jelmer pointed out that these are also in use by other LDB databases - not only
SAMDB ones.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Oct 17 13:37:16 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:37:23 +0000 (10:37 +0200)]
s4:remove "util_ldb" submodule and integrate the three gendb_* calls in "dsdb/common/util.c"
They're only in use by SAMDB code.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Oct 17 09:40:13 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:29:46 +0000 (10:29 +0200)]
s4:lib/util/util_ldb.c - remove unused "gendb_add_ldif" call
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:23:41 +0000 (10:23 +0200)]
s4:ldb-samba/ldb_wrap.c - fix indentation and trailing whitespaces
Matthias Dieter Wallnöfer [Sun, 17 Oct 2010 08:20:40 +0000 (10:20 +0200)]
s4:"wrap_casefold" - move it to "ldb_wrap.c" since it's only used there
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:58:51 +0000 (20:58 +0200)]
s4:dsdb - make the RELAX control private
This makes our LDAP much more secure and less error-prone.
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 19:43:36 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:46:20 +0000 (20:46 +0200)]
s4:libcli/ldap/ldap_controls.c - fix up the controls list
- add missing private controls and comments
- use control defines rather than hardcoded values -> easier to comprehend
- reorder controls
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 18:45:08 +0000 (20:45 +0200)]
ldb:ldb.h - reorder controls/extended operations
This makes it easier to read
Jelmer Vernooij [Sat, 16 Oct 2010 15:30:51 +0000 (17:30 +0200)]
heimdal: Remove some unused arguments from HEIMDAL_SUBSYSTEM().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Oct 16 16:14:24 UTC 2010 on sn-devel-104
Jelmer Vernooij [Sat, 16 Oct 2010 15:26:24 +0000 (17:26 +0200)]
heimdal: Allow leaving off prefix from asn1 option_file.
Jelmer Vernooij [Sat, 16 Oct 2010 15:25:19 +0000 (17:25 +0200)]
heimdal: Leave off ../heimdal prefix to HEIMDAL_BINARY().
Jelmer Vernooij [Sat, 16 Oct 2010 15:23:06 +0000 (17:23 +0200)]
heimdal: Allow leaving off prefix to HEIMDAL_ERRTABLE().
Jelmer Vernooij [Sat, 16 Oct 2010 15:21:05 +0000 (17:21 +0200)]
heimdal: Allow leaving off prefix for HEIMDAL_ASN1().
Jelmer Vernooij [Sat, 16 Oct 2010 15:16:44 +0000 (17:16 +0200)]
heimdal: Allow leaving off ../heimdal prefix for proto headers.
Jelmer Vernooij [Sat, 16 Oct 2010 15:13:10 +0000 (17:13 +0200)]
heimdal: Allow leaving off ../heimdal prefix for source files.
Jelmer Vernooij [Sat, 16 Oct 2010 15:08:27 +0000 (17:08 +0200)]
heimdal: Add convenience functions for finding heimdal paths.
Jelmer Vernooij [Sat, 16 Oct 2010 15:06:41 +0000 (17:06 +0200)]
heimdal: Call HEIMDAL_AUTOPROTO() manually.
Jelmer Vernooij [Sat, 16 Oct 2010 15:03:06 +0000 (17:03 +0200)]
heimdal: Call HEIMDAL_AUTOPROTO_PRIVATE() manually.
Jelmer Vernooij [Sat, 16 Oct 2010 14:46:22 +0000 (16:46 +0200)]
heimdal: Add variables for source files.
Jelmer Vernooij [Sat, 16 Oct 2010 14:37:11 +0000 (16:37 +0200)]
heimdal: Simplify handling of ../heimdal prefixes in HEIMDAL_SUBSYSTEM.
Jelmer Vernooij [Sat, 16 Oct 2010 02:31:54 +0000 (04:31 +0200)]
heimdal_build: Fix detection of system roken library.
Jelmer Vernooij [Sat, 16 Oct 2010 02:30:49 +0000 (04:30 +0200)]
heimdal_build: Remove ignored argument ldflags from HEIMDAL_BINARY().
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:49:07 +0000 (15:49 +0200)]
ldb:pyldb.c - remove pointless comment
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 14:38:58 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:10:11 +0000 (15:10 +0200)]
ldb:"ldb_dn_compare_base" - use "unsigned int" counters
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 13:54:13 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:08:40 +0000 (15:08 +0200)]
ldb:"ldb_dn_add_child" - use "unsigned int" counters
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 13:04:57 +0000 (15:04 +0200)]
ldb:"ldb_dn_remove_base_components" - use an "unsigned int" counter
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 12:47:42 +0000 (14:47 +0200)]
ldb:"ldb_dn_canonical" - use an "unsigned int" counter
Convert it to use an "unsigned int" counter which represents the exact length
of the DN components.
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 12:19:19 +0000 (14:19 +0200)]
s4:samldb LDB module - use appropriate fixed-length integer types where needed
- The "systemFlags" we interpret always as signed
- Use "samdb_msg_add_int" where possible (much saver for integer storing than
ldb_msg_add_fmt)
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 09:00:12 +0000 (11:00 +0200)]
s4:dsdb/samdb/ldb_modules/util.c - remove now unused functions which set integers
Please do always use the functions which specifiy the appropriate integer
length to not run into platform-specific issues. Therefore I'm removing these
generic calls.
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 08:59:30 +0000 (10:59 +0200)]
s4:samba3sid LDB module - handle the RID as uint32_t
- This is how we always deal with RIDs
- Use an integer-length safe function for the RID update
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 10:28:25 +0000 (12:28 +0200)]
s4:objectclass LDB module - implement the "isCriticalSystemObject" subtree delete protection
MS-ADTS 3.1.1.5.5.7.2
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Oct 16 11:24:09 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 09:32:38 +0000 (11:32 +0200)]
s4:ldif_handlers.c - fix a typo
Matthias Dieter Wallnöfer [Thu, 14 Oct 2010 15:01:39 +0000 (17:01 +0200)]
s4:dsdb - fix unsigned integer save problems using the "%u" specifier
The issue here is that we have not yet first cast to int32_t explicitly,
before we cast to an signed int to printf() into the %d or cast to a
int64_t before we then cast to a long long to printf into a %lld.
There are *no* unsigned integers in Active Directory LDAP, even the RID
allocations and ms-DS-Secondary-KrbTgt-Number are *signed* quantities.
(See the schema, and the syntax definitions in schema_syntax.c).
The failure has been detected by Matthieu Patou on the buildfarm host "tridge"
due to a malformed "groupType" attribute.
The solution is to use the "%d" specifier. Either to use it directly - or better
(when possible) use the call "samdb_msg_add_uint" (which encapsulates it).
This patch changes such problematic situations.
Matthias Dieter Wallnöfer [Sat, 16 Oct 2010 08:36:32 +0000 (10:36 +0200)]
s4:dsdb/common/util.c - describe the behaviour of the functions "samdb_msg_add_uint", "samdb_msg_add_uint64" and "samdb_msg_set_uint" a bit more
Unsigned int data in AD is a bit problematic to handle. Problem described by
abartlet.
Jeremy Allison [Sat, 16 Oct 2010 05:27:10 +0000 (22:27 -0700)]
Don't arbitrarily clean all parametric options in add_a_service(),
that is called from many places, not just smb.conf processing. Only
clean parametric options when doing actual smb.conf reading (or
registry equivalent).
Michael Adams, Volker, Metze, please check.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 16 06:46:19 UTC 2010 on sn-devel-104
Jeremy Allison [Sat, 16 Oct 2010 02:54:51 +0000 (19:54 -0700)]
Ensure we have correct parameters to use Windows ACL modules.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct 16 03:36:04 UTC 2010 on sn-devel-104
git.samba.org / samba.git / log