samba.git
16 years agor23998: Convert reply_close to the new API
Volker Lendecke [Mon, 23 Jul 2007 09:53:06 +0000 (09:53 +0000)]
r23998: Convert reply_close to the new API
(This used to be commit dbf74cb747d34dac571d85d6bae9398558086456)

16 years agor23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer
Volker Lendecke [Mon, 23 Jul 2007 09:36:09 +0000 (09:36 +0000)]
r23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer

The complete history of this patch can be found under
http://www.samba.org/~vlendec/inbuf-checkin/.

Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only
checking into 3_2 at the moment, as it currently will slow down operations for
all non-converted (i.e. all at this moment) operations, as it will copy the
talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort
to convert everything necessary for the normal operations an XP box does.

I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More
to come, but I would appreciate some help here.

Volker
(This used to be commit 5594af2b208c860d3f4b453af6a649d9e4295d1c)

16 years agor23996: One more const
Volker Lendecke [Mon, 23 Jul 2007 08:20:44 +0000 (08:20 +0000)]
r23996: One more const
(This used to be commit a54fa551a4b9ffe3f29b339a54e563cdfe924959)

16 years agor23992: Some const
Volker Lendecke [Sun, 22 Jul 2007 17:13:46 +0000 (17:13 +0000)]
r23992: Some const
(This used to be commit bc106cf50732ed6c169dcf593797501fcb3ae675)

16 years agor23991: Some const
Volker Lendecke [Sun, 22 Jul 2007 13:51:39 +0000 (13:51 +0000)]
r23991: Some const
(This used to be commit 804be77e4695eb923048948dbc6e223967fdef94)

16 years agor23990: Reformatting for 80 cols and trailing whitespace
Volker Lendecke [Sun, 22 Jul 2007 11:38:11 +0000 (11:38 +0000)]
r23990: Reformatting for 80 cols and trailing whitespace
(This used to be commit 0484de27d97306707ae0243443d18e9dec6d80f3)

16 years agor23989: For testing purposes, add "echo" to smbclient
Volker Lendecke [Sun, 22 Jul 2007 11:18:49 +0000 (11:18 +0000)]
r23989: For testing purposes, add "echo" to smbclient
(This used to be commit 4cdfc887545f7367239c73b0fecf173970bbc5d2)

16 years agor23988: Looks a lot more scary than it is: This just unwraps the else-branch of
Volker Lendecke [Sat, 21 Jul 2007 22:29:55 +0000 (22:29 +0000)]
r23988: Looks a lot more scary than it is: This just unwraps the else-branch of
if (smb_messages[type].fn == NULL) { into the function top-level. Makes
this function a bit easier to understand IMO.

Volker
(This used to be commit ada23b7f06acb00c36763a3e7a6f6e0caac86951)

16 years agor23987: Remove static pid in switch_message()
Volker Lendecke [Sat, 21 Jul 2007 22:00:09 +0000 (22:00 +0000)]
r23987: Remove static pid in switch_message()

There's no point in duplicating functionality that exists in
sys_getpid() that also only used in a debug statement
(This used to be commit ebf1b1e97c709f5ffe48c85b4227a0af1f88b0ab)

16 years agor23986: Some const
Volker Lendecke [Sat, 21 Jul 2007 21:56:33 +0000 (21:56 +0000)]
r23986: Some const
(This used to be commit dc6f4bdb7f5fc0fd4cd9f687c47af3719985da8b)

16 years agor23981: Make tdb_validate_and_backup try harder to end up with a valid tdb:
Michael Adam [Fri, 20 Jul 2007 16:39:42 +0000 (16:39 +0000)]
r23981: Make tdb_validate_and_backup try harder to end up with a valid tdb:

If restoring a backup fails due to lack of space, remove the
corrupt tdb previously moved away to "name.corrupt", and retry.
If restoring still fails, move the backup in place instead of
copying it.

Michael
(This used to be commit f81f2bf480a955213be8461636ee6f81643f17b8)

16 years agor23980: Fix one more use of pwrite in expand_file.
Michael Adam [Fri, 20 Jul 2007 16:31:32 +0000 (16:31 +0000)]
r23980: Fix one more use of pwrite in expand_file.

Michael
(This used to be commit de0ef9134650e3e7cc5b5cfec9e8dd8510bd6677)

16 years agor23979: Fix another occurence of (written != requested) as an
Michael Adam [Fri, 20 Jul 2007 15:00:58 +0000 (15:00 +0000)]
r23979: Fix another occurence of (written != requested) as an
error condition to write. This is in tdb_new_database.

Fix one call to tdb_new_database in tdb_open_ex to not
overwrite the newly propagated errno (typically ENOSPC).

Michael
(This used to be commit 24fed55d72a4922bfd3ddba61449fbae01365feb)

16 years agor23977: Im prove the pwrite-patch to tdb_expand_file of r23972:
Michael Adam [Fri, 20 Jul 2007 14:23:12 +0000 (14:23 +0000)]
r23977: Im prove the pwrite-patch to tdb_expand_file of r23972:

* prevent infinite loops due to 0 bytes written:
  try once more. if we still get 0 as return,
  set errno to ENOSPC and return -1 (error)

* replace int by correct types (ssize_t and size_t).

* print a warning log message in case "written < requested to write"
  usually this means, that the next call to pwrite will fail
  with return value -1 and set errno accordingly.

  Note that the former error condition "written != requested to write"
  is not a correct error condition of write/pwrite. If this is due
  to an error, a subsequent call to (p)write will reveal the cause
  (typically "no space left on device" - ENOSPC).

Michael
(This used to be commit 5b8d53dfe1872621bf28c8351d87bfc53ef6e66b)

16 years agor23976: Move authdata.o to LIBADS_SERVER_OBJ.
Günther Deschner [Thu, 19 Jul 2007 14:49:08 +0000 (14:49 +0000)]
r23976: Move authdata.o to LIBADS_SERVER_OBJ.

Guenther
(This used to be commit 3544d19d543fa8e9166017a8c31e981941beafdd)

16 years agor23975: Enhance some debug output.
Michael Adam [Thu, 19 Jul 2007 14:22:24 +0000 (14:22 +0000)]
r23975: Enhance some debug output.
(This used to be commit 909172839a512b60db075fb1a7488345a2e48eb0)

16 years agor23974: Fix Coverity ID 361. num_rids == 0 is caught on function entry
Volker Lendecke [Thu, 19 Jul 2007 14:08:01 +0000 (14:08 +0000)]
r23974: Fix Coverity ID 361.  num_rids == 0 is caught on function entry
(This used to be commit 839d64add4ebf900863f1ed3e7a379db9b6fdf69)

16 years agor23973: For debugging, add (undocumented) net ads kerberos commands (kinit, renew,
Günther Deschner [Thu, 19 Jul 2007 13:47:53 +0000 (13:47 +0000)]
r23973: For debugging, add (undocumented) net ads kerberos commands (kinit, renew,
pac).

Guenther
(This used to be commit 4cada7c1485c9957e553d6e75cb6f30f4338489f)

16 years agor23972: Fix a bug in pwrite error detection in tdb_expand_file():
Michael Adam [Thu, 19 Jul 2007 13:46:26 +0000 (13:46 +0000)]
r23972: Fix a bug in pwrite error detection in tdb_expand_file():
The proper error condition is (ret == -1) instead of
(ret != number_of_byte_told_to_write).

Michael
(This used to be commit e3af95f0983e9f92c10a80ee4f15a0cd718a4728)

16 years agor23971: Prevent build failures.
Günther Deschner [Thu, 19 Jul 2007 13:37:49 +0000 (13:37 +0000)]
r23971: Prevent build failures.

Guenther
(This used to be commit f959a0f152956429d8b525a55f99cbe2963504d6)

16 years agor23970: Allow to set the debuglevel at which to dump the PAC logon info.
Günther Deschner [Thu, 19 Jul 2007 13:36:41 +0000 (13:36 +0000)]
r23970: Allow to set the debuglevel at which to dump the PAC logon info.

Guenther
(This used to be commit 7d321aad83cb7b9cc766bc89a886676337a2bad8)

16 years agor23969: Some helper routines to retrieve a PAC and PAC elements.
Günther Deschner [Thu, 19 Jul 2007 13:34:45 +0000 (13:34 +0000)]
r23969: Some helper routines to retrieve a PAC and PAC elements.

Guenther
(This used to be commit d4c87c792a955be7d5ef59fc683fc48e3d8afe16)

16 years agor23968: Harmonize net's password prompts.
Günther Deschner [Thu, 19 Jul 2007 13:07:22 +0000 (13:07 +0000)]
r23968: Harmonize net's password prompts.

Guenther
(This used to be commit 7e2fb14d6e4f58fe6645b7e7468f925c21cb4c9d)

16 years agor23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Volker Lendecke [Thu, 19 Jul 2007 10:23:36 +0000 (10:23 +0000)]
r23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>

Thanks!

Volker
(This used to be commit 46997a70199296d4ec45780f002898f23029bb26)

16 years agor23962: Linux oplock support is conditional on HAVE_KERNEL_OPLOCKS_LINUX,
James Peach [Thu, 19 Jul 2007 04:37:38 +0000 (04:37 +0000)]
r23962: Linux oplock support is conditional on HAVE_KERNEL_OPLOCKS_LINUX,
not plain old LINUX.
(This used to be commit 234cb7c893172edeb6802ac02304a041b33ee939)

16 years agor23957: Use tdb_open_log instead of tdb_open.
Michael Adam [Wed, 18 Jul 2007 14:38:18 +0000 (14:38 +0000)]
r23957: Use tdb_open_log instead of tdb_open.

Michael
(This used to be commit efabd7fe03733d1fcb02d0d270c18ede7836f3a9)

16 years agor23956: merge from 3_2-ctdb-tridge:
Stefan Metzmacher [Wed, 18 Jul 2007 14:03:46 +0000 (14:03 +0000)]
r23956: merge from 3_2-ctdb-tridge:
fixed a bug with dead share mode entries

jra: please tell me if it's ok to merge this to 3_2_0.

metze
(This used to be commit 044ac6afa7a36b352f4cb203879af082d4726417)

16 years agor23954: merge from 3_0-ctdb-tridge:
Stefan Metzmacher [Wed, 18 Jul 2007 13:52:20 +0000 (13:52 +0000)]
r23954: merge from 3_0-ctdb-tridge:
don't display dead share mode entries in smbstatus

metze
(This used to be commit b52bb1e1556d2f4c2bfbd21e12782420bc26a029)

16 years agor23953: Some C++ warnings
Volker Lendecke [Wed, 18 Jul 2007 12:28:32 +0000 (12:28 +0000)]
r23953: Some C++ warnings
(This used to be commit 8716edf157bf8866328f82eb6cf25e71af7fea15)

16 years agor23952: Streamline and improve the logic of tdb_validate_and backup:
Michael Adam [Wed, 18 Jul 2007 11:43:50 +0000 (11:43 +0000)]
r23952: Streamline and improve the logic of tdb_validate_and backup:

- call tdb_validate on the given tdb.
- if validation is successful, create a backup
  return 0 (success) even if the backup fails.
- if validation fails:
  - move tdb to name.corrupt (don't exit if this fails)
  - look for a valid backup
  - if a valid backup is found, restore it, else return -1 (failure)
    if restoring succeeds, return 0 (success), else -1 (failure)

Summing up:

If 0 is returned, there is a valid tdb at the given location:
either the original one ore one restrored from a backup.

If -1 is returned, there is no valid tdb at the given location:
Either there is no file at all, or the original file is still
in place (if moving it away failed).

Michael
(This used to be commit 1c36ccd86d85b02f27ec66d37bdf7f04ad760901)

16 years agor23951: Fix segfault.
Günther Deschner [Wed, 18 Jul 2007 11:21:21 +0000 (11:21 +0000)]
r23951: Fix segfault.

Guenther
(This used to be commit 1a5c8780ae79e5ae4e6a36bfb66cd92ae7d3aa88)

16 years agor23950: unlink before rename is superfluous.
Michael Adam [Wed, 18 Jul 2007 08:29:00 +0000 (08:29 +0000)]
r23950: unlink before rename is superfluous.

Michael
(This used to be commit 63c4c40cf7055ab7cf413a23e306cf209a1dd0a1)

16 years agor23948: add gsskrb5 sign and seal support for LDAP connections
Stefan Metzmacher [Wed, 18 Jul 2007 08:19:13 +0000 (08:19 +0000)]
r23948: add gsskrb5 sign and seal support for LDAP connections

NOTE: only for the "GSSAPI" SASL mech yet

metze
(This used to be commit a079b66384b15e9d569dded0d9d6bd830e1a6dfa)

16 years agor23946: add support for NTLMSSP sign and seal
Stefan Metzmacher [Wed, 18 Jul 2007 08:15:42 +0000 (08:15 +0000)]
r23946: add support for NTLMSSP sign and seal

NOTE: windows servers are broken with sign only...

metze
(This used to be commit 408bb2e6e2171196a2bd314db181d9b124e931a1)

16 years agor23945: add infrastructure to select plain, sign or seal LDAP connection
Stefan Metzmacher [Wed, 18 Jul 2007 07:45:16 +0000 (07:45 +0000)]
r23945: add infrastructure to select plain, sign or seal LDAP connection

metze
(This used to be commit 2075c05b3d8baa7d6d8510cd962471a5781740a6)

16 years agor23943: - always provide ads_setup_sasl_wrapping() function
Stefan Metzmacher [Wed, 18 Jul 2007 07:30:41 +0000 (07:30 +0000)]
r23943: - always provide ads_setup_sasl_wrapping() function
- read/write returning 0 means EOF and we need to return direct

metze
(This used to be commit 885d557ae746c318df0aabc0a03dce1587918cce)

16 years agor23942: Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
Jeremy Allison [Wed, 18 Jul 2007 01:27:03 +0000 (01:27 +0000)]
r23942: Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
(This used to be commit 78d0c5194fe42ad4f096657e2210a15541303a2a)

16 years agor23941: Don't use "False" when you mean "MARSHALL".
Jeremy Allison [Wed, 18 Jul 2007 00:18:57 +0000 (00:18 +0000)]
r23941: Don't use "False" when you mean "MARSHALL".
Jeremy.
(This used to be commit 57d4d5f2cd1ad7bae28f40478f4c2f9b6a475ce6)

16 years agor23940: Added missing line that was deleted accidently.
Jeremy Allison [Tue, 17 Jul 2007 23:57:13 +0000 (23:57 +0000)]
r23940: Added missing line that was deleted accidently.
Should fix the build.
Jeremy.
(This used to be commit b085366d5b982b635561f1d3211a6f3197258e6f)

16 years agor23939: Fixes for notify returns. Returned param value must fix inside
Jeremy Allison [Tue, 17 Jul 2007 23:01:02 +0000 (23:01 +0000)]
r23939: Fixes for notify returns. Returned param value must fix inside
max_param or return NT_STATUS_OK.
Jeremy.
(This used to be commit ab4af60d1ab4583fd27deb63b3f7baa1ede3473d)

16 years agor23938: Add a debug message.
Michael Adam [Tue, 17 Jul 2007 21:55:31 +0000 (21:55 +0000)]
r23938: Add a debug message.
(This used to be commit 6bd2c48921dd8dbf2885a8135ba01a1324e020c8)

16 years agor23937: Use ads_config_path() when we need to know the configration context.
Günther Deschner [Tue, 17 Jul 2007 20:28:31 +0000 (20:28 +0000)]
r23937: Use ads_config_path() when we need to know the configration context.

Guenther
(This used to be commit 1a62c731c6259bf4285d3735bff8b191002553f7)

16 years agor23935: We were lying to the client in the case of POSIX_UNLINK
Jeremy Allison [Tue, 17 Jul 2007 18:48:39 +0000 (18:48 +0000)]
r23935: We were lying to the client in the case of POSIX_UNLINK
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
(This used to be commit 24e625a615447c025b73fed2d3db03c1f11ae596)

16 years agor23933: - implement ctrl SASL wrapping hook
Stefan Metzmacher [Tue, 17 Jul 2007 14:08:53 +0000 (14:08 +0000)]
r23933: - implement ctrl SASL wrapping hook
- pass down sign or seal hooks
- some sasl wrapping fixes

metze
(This used to be commit 8c64ca3394489b28034310fe64d6998e49827196)

16 years agor23932: Fill extended status with information in case the validation traverse
Michael Adam [Tue, 17 Jul 2007 13:06:29 +0000 (13:06 +0000)]
r23932: Fill extended status with information in case the validation traverse
functions did not do so but returned an error. (This is the case when
error occurred deeper than at the level of the content checking done by
the per entry validate_fn.)

Michael
(This used to be commit e56be59947a29d0a5692f3f3bc6c089dd8b4b5d9)

16 years agor23931: Use the new tdb_validate_and_backup function instead of pure tdb_validate
Michael Adam [Tue, 17 Jul 2007 12:51:43 +0000 (12:51 +0000)]
r23931: Use the new tdb_validate_and_backup function instead of pure tdb_validate
in winbindd cache validation.

Michael
(This used to be commit 2c2a1ff2c27861ca87afbd8bab39d257a69e9565)

16 years agor23930: Introduce tdb_validate_and_backup:
Michael Adam [Tue, 17 Jul 2007 12:49:22 +0000 (12:49 +0000)]
r23930: Introduce tdb_validate_and_backup:
This is a wrapper around tdb_validate, that does backup handling:

* if the given tdb is valid, a backup is created (name.bak)
* if the tdb is invalid, if a valid bakup is found (validated
  with the same validation function) under the name "name.bak"
  the orignal tdb is moved to name.corrupt and the backup
  is restored.

For the backup handling, a variant of the backup_tdb function
from lib/tdb/tools/tdbbackup.c is included in lib/util_tdb.c.
The copy function for the traverse action eliminates the need
to maintain a global success state by using a struct wrapping
the target tdb and a success flag as the private data.

Michael
(This used to be commit ca63a99b6188c0976603dc2852e478cc7a6b2f8b)

16 years agor23929: Deleting gpo_sd_check_trustee_in_sid_token() as nt_token_check_sid() is what we
Günther Deschner [Tue, 17 Jul 2007 11:52:23 +0000 (11:52 +0000)]
r23929: Deleting gpo_sd_check_trustee_in_sid_token() as nt_token_check_sid() is what we
need here.

Guenther
(This used to be commit 465c89ee4a0c287203121037052c875b1c6ca41e)

16 years agor23928: Merge all "copy-info3-groups-to-sid-array" blocks to a sid_array_from_info3()
Günther Deschner [Tue, 17 Jul 2007 11:47:17 +0000 (11:47 +0000)]
r23928: Merge all "copy-info3-groups-to-sid-array" blocks to a sid_array_from_info3()
function.

Guenther
(This used to be commit 1e1e480115e37b3f4c85f979ddd800b8de0b9c57)

16 years agor23926: implement output buffer handling for the SASL write wrapper
Stefan Metzmacher [Tue, 17 Jul 2007 11:14:42 +0000 (11:14 +0000)]
r23926: implement output buffer handling for the SASL write wrapper

metze
(This used to be commit 65ce6fa21adec704b3cde30c57001e5620f048e4)

16 years agor23925: Use NULL instead of 0 for a void * argument.
Michael Adam [Tue, 17 Jul 2007 10:30:13 +0000 (10:30 +0000)]
r23925: Use NULL instead of 0 for a void * argument.
(This used to be commit 864b3d260f3b099b1f24edf4ed0a7ed52b05f6cc)

16 years agor23922: implement input buffer handling for the SASL read wrapper
Stefan Metzmacher [Tue, 17 Jul 2007 10:13:53 +0000 (10:13 +0000)]
r23922: implement input buffer handling for the SASL read wrapper

metze
(This used to be commit 7d8518ebd9470062b499b7074a940e14520e99f2)

16 years agor23921: Remove GPO_SID_TOKEN struct and use nt_user_token instead, that already has
Günther Deschner [Tue, 17 Jul 2007 09:39:39 +0000 (09:39 +0000)]
r23921: Remove GPO_SID_TOKEN struct and use nt_user_token instead, that already has
S-1-5-11 in the token.

Guenther
(This used to be commit 83c734690ab09a0fe103ee9fdb855fbdd31db39c)

16 years agor23920: Fix debug statement.
Günther Deschner [Tue, 17 Jul 2007 08:14:45 +0000 (08:14 +0000)]
r23920: Fix debug statement.

Guenther
(This used to be commit 7317eb408de8798ce6160907b59aad96acf983b6)

16 years agor23918: not all ldap libraries support debugging
Stefan Metzmacher [Tue, 17 Jul 2007 07:29:43 +0000 (07:29 +0000)]
r23918: not all ldap libraries support debugging

metze
(This used to be commit 3f68189c9a319ac9cae76f6d2b586cbde6d31e3c)

16 years agor23916: use the correct io operations for debugging
Stefan Metzmacher [Tue, 17 Jul 2007 07:28:00 +0000 (07:28 +0000)]
r23916: use the correct io operations for debugging

metze
(This used to be commit d745a1a71991f306c29b3c62f43d619177f79725)

16 years agor23914: try to fix the build on Tru64
Stefan Metzmacher [Tue, 17 Jul 2007 06:03:03 +0000 (06:03 +0000)]
r23914: try to fix the build on Tru64

/usr/include/sys/acl.h:#define acl_type acl_common.entry_type
was the problem...

metze
(This used to be commit 8557b8b570ac8f8d3d14aaeb894c8b3532558736)

16 years agor23913: Revert back to Volker's original logic to fix the
Jeremy Allison [Tue, 17 Jul 2007 05:55:10 +0000 (05:55 +0000)]
r23913: Revert back to Volker's original logic to fix the
RAW-SFILEINFO-RENAME until I can figure out what
is different from the way CIFSFS drives this in
the cthon tests and the way smbtorture drives it.
Jeremy.
(This used to be commit 99f72dd9af82921de4827b9b9d90d75127332295)

16 years agor23911: Revert r23910 to try and fix the build farm. I
Jeremy Allison [Tue, 17 Jul 2007 04:47:36 +0000 (04:47 +0000)]
r23911: Revert r23910 to try and fix the build farm. I
need to look at this more closely tomorrow.
Stevef's cthon tests definately show we're not
matching Windows behaviour (as his tests pass
against Windows but not SAMBA_3_2) but this isn't
the fix.
Jeremy.
(This used to be commit 90bbc077e15de0493dccda50be9bcdf6e2649137)

16 years agor23910: We used to deny renames on the
Jeremy Allison [Tue, 17 Jul 2007 02:17:23 +0000 (02:17 +0000)]
r23910: We used to deny renames on the
source open for non-delete open.
Turns out this is not the case.
VL please test but this matches
Windows behaviour. (I'll add a
torture test tomorrow).
Jeremy.
(This used to be commit 03e3d587468ce66044814a8a58308b2fe9ab5499)

16 years agor23909: Get closer to passing the cthon tests for delete open file.
Jeremy Allison [Tue, 17 Jul 2007 02:06:38 +0000 (02:06 +0000)]
r23909: Get closer to passing the cthon tests for delete open file.
It matters how the target is open.
Jeremy.
(This used to be commit 0989877fd191f7c9e195dc6e45dda5fd026f09dd)

16 years agor23908: Fix bug with interaction of optimization with
Jeremy Allison [Tue, 17 Jul 2007 00:50:48 +0000 (00:50 +0000)]
r23908: Fix bug with interaction of optimization with
POSIX locking. We can't do lock counts with POSIX,
so stop counting if we get a POSIX lock request.
Jeremy.
(This used to be commit a48e4a29e6774e5e72b9b361a17207b053474521)

16 years agor23906: Fix POSIX unlink bug found by Steve. If we
Jeremy Allison [Tue, 17 Jul 2007 00:09:56 +0000 (00:09 +0000)]
r23906: Fix POSIX unlink bug found by Steve. If we
used lstat during the open (which we always
do for POSIX) then use lstat for the unlink.
Jeremy.
(This used to be commit 4aad77c27cc277e3d937f674ee620729411e3eaf)

16 years agor23904: Remove an unused variable reference
Volker Lendecke [Mon, 16 Jul 2007 21:17:26 +0000 (21:17 +0000)]
r23904: Remove an unused variable reference
(This used to be commit 7f4ceb1bf0c7aad50d93bb963c49dbc405e9524a)

16 years agor23903: Fix a potential reason for the segfault Steve found
Volker Lendecke [Mon, 16 Jul 2007 19:36:46 +0000 (19:36 +0000)]
r23903: Fix a potential reason for the segfault Steve found
(This used to be commit c06bc91085c24bf6cc4491448ba12c5c2f1c7937)

16 years agor23902: Fix uninitialized read in devicetype noticed by Volker.
Jeremy Allison [Mon, 16 Jul 2007 18:17:19 +0000 (18:17 +0000)]
r23902: Fix uninitialized read in devicetype noticed by Volker.
Jeremy
(This used to be commit 98c23939731654440d2f008e44e11371eaddf014)

16 years agor23900: LDAP_OPT_SOCKBUF doesn't exists on all platforms
Stefan Metzmacher [Mon, 16 Jul 2007 16:22:05 +0000 (16:22 +0000)]
r23900: LDAP_OPT_SOCKBUF doesn't exists on all platforms

metze
(This used to be commit 8455c65be34186e73283bb60b1ef3441d0338d55)

16 years agor23898: rename HAVE_ADS_SASL_WRAPPING -> HAVE_LDAP_SASL_WRAPPING
Stefan Metzmacher [Mon, 16 Jul 2007 16:08:24 +0000 (16:08 +0000)]
r23898: rename HAVE_ADS_SASL_WRAPPING -> HAVE_LDAP_SASL_WRAPPING

metze
(This used to be commit 873eaff8febb50f00f9dac64c57b2a22c16f4f9b)

16 years agor23896: hopefully fix the build on most systems
Stefan Metzmacher [Mon, 16 Jul 2007 15:31:01 +0000 (15:31 +0000)]
r23896: hopefully fix the build on most systems

metze
(This used to be commit d5512da62a6ae38321709611b04f419cc6c3b190)

16 years agor23893: add dummy callbacks for LDAP SASL wrapping,
Stefan Metzmacher [Mon, 16 Jul 2007 14:35:33 +0000 (14:35 +0000)]
r23893: add dummy callbacks for LDAP SASL wrapping,
they're not used yet...

metze
(This used to be commit a3b97cdce719d9d5e82f26096c0e8c3a86ff3965)

16 years agor23891: fix compiler warning
Stefan Metzmacher [Mon, 16 Jul 2007 14:19:59 +0000 (14:19 +0000)]
r23891: fix compiler warning

metze
(This used to be commit 6dcbc0b6055998d77bd7bb6acfb622bc1423964b)

16 years agor23888: move elements belonging to the current ldap connection to a
Stefan Metzmacher [Mon, 16 Jul 2007 11:08:00 +0000 (11:08 +0000)]
r23888: move elements belonging to the current ldap connection to a
substructure.

metze
(This used to be commit 00909194a6c1ed193dfdb296f50f58a53450583c)

16 years agor23886: add ads_disconnect() function
Stefan Metzmacher [Mon, 16 Jul 2007 09:48:15 +0000 (09:48 +0000)]
r23886: add ads_disconnect() function

metze
(This used to be commit ba70737b7043cae89dd90f8668a24881212ac6fb)

16 years agor23885: Fix make test on opi.
Volker Lendecke [Mon, 16 Jul 2007 08:23:20 +0000 (08:23 +0000)]
r23885: Fix make test on opi.
(This used to be commit b2adb28808fe25d420bc12834ca8bc70779bb653)

16 years agor23884: Fix Coverity ID 379
Volker Lendecke [Mon, 16 Jul 2007 07:46:29 +0000 (07:46 +0000)]
r23884: Fix Coverity ID 379
(This used to be commit 86476efc7a6adfe70c0437c2ff1bbd4b2b4ade5e)

16 years agor23883: Fix Coverity ID 380
Volker Lendecke [Mon, 16 Jul 2007 07:44:23 +0000 (07:44 +0000)]
r23883: Fix Coverity ID 380
(This used to be commit 5eda562f2b7a08f57fb2a7082d18e2983bfdc864)

16 years agor23882: Fix Coverity id 389 -- finally (I hope)
Volker Lendecke [Mon, 16 Jul 2007 07:40:30 +0000 (07:40 +0000)]
r23882: Fix Coverity id 389 -- finally (I hope)
(This used to be commit 9b8f2d8bd144700306819480bcb260d2c20969ae)

16 years agor23879: Fix two memleaks, found by the IBM checker
Volker Lendecke [Sun, 15 Jul 2007 09:42:43 +0000 (09:42 +0000)]
r23879: Fix two memleaks, found by the IBM checker
(This used to be commit 4d1b33f51308c95293fa2494b47ba1255af8d216)

16 years agor23878: Fix an error return, found by the IBM checker
Volker Lendecke [Sun, 15 Jul 2007 09:40:00 +0000 (09:40 +0000)]
r23878: Fix an error return, found by the IBM checker
(This used to be commit a369c67f6678bdcc0689929238bc96f45cdeeb25)

16 years agor23877: Fix two segfaults in (very unlikely) error paths, found by the IBM
Volker Lendecke [Sun, 15 Jul 2007 09:37:36 +0000 (09:37 +0000)]
r23877: Fix two segfaults in (very unlikely) error paths, found by the IBM
checker.
(This used to be commit 33068885e62f3681644c128e381822d48298ea05)

16 years agor23874: Some more minor edits for net ads gpo.
Günther Deschner [Fri, 13 Jul 2007 23:38:19 +0000 (23:38 +0000)]
r23874: Some more minor edits for net ads gpo.

Guenther
(This used to be commit cc41b3b60f5e0c604a764bc5bb1f8ecfe13a36f6)

16 years agor23873: Make use of ads_find_samaccount().
Günther Deschner [Fri, 13 Jul 2007 23:36:12 +0000 (23:36 +0000)]
r23873: Make use of ads_find_samaccount().

Guenther
(This used to be commit 94d11806fd5384cbdd6c12b230985991b9e6473d)

16 years agor23872: Dump all GPFLAGS in dump_gpo().
Günther Deschner [Fri, 13 Jul 2007 23:34:42 +0000 (23:34 +0000)]
r23872: Dump all GPFLAGS in dump_gpo().

Guenther
(This used to be commit 4b5c4b4fffbd62917894432c9bb6946f181668c4)

16 years agor23871: The snapin handler needs to have the full struct GROUP_POLICY_OBJECT.
Günther Deschner [Fri, 13 Jul 2007 23:32:43 +0000 (23:32 +0000)]
r23871: The snapin handler needs to have the full struct GROUP_POLICY_OBJECT.

Guenther
(This used to be commit 9dc8ec0e193ad4aa85293c334ebbca5d0618f0d2)

16 years agor23870: Use GPO_LINK_TYPE in GROUP_POLICY_OBJECT struct.
Günther Deschner [Fri, 13 Jul 2007 23:28:12 +0000 (23:28 +0000)]
r23870: Use GPO_LINK_TYPE in GROUP_POLICY_OBJECT struct.

Guenther
(This used to be commit f60ad2ccff1afea99e49e51832a1fcdface4bf58)

16 years agor23869: Protect against partial security descriptors.
Günther Deschner [Fri, 13 Jul 2007 23:26:55 +0000 (23:26 +0000)]
r23869: Protect against partial security descriptors.

Guenther
(This used to be commit 0a96a11f01dd8c0d29fff1d97c3d666c32b33b59)

16 years agor23866: Fix a 1-byte buffer overrun
Volker Lendecke [Fri, 13 Jul 2007 13:29:12 +0000 (13:29 +0000)]
r23866: Fix a 1-byte buffer overrun
(This used to be commit 2ed83d36fec918e6ad9605f43e1a49fa5b61f17b)

16 years agor23865: Fix a type-punned error
Volker Lendecke [Fri, 13 Jul 2007 11:36:55 +0000 (11:36 +0000)]
r23865: Fix a type-punned error
(This used to be commit a40d3a566af88464fc6afd2c6e6e8b6e3a98aac2)

16 years agor23863: handle NT_STATUS_RETRY and always print out the NTSTATUS string
Stefan Metzmacher [Fri, 13 Jul 2007 10:40:53 +0000 (10:40 +0000)]
r23863: handle NT_STATUS_RETRY and always print out the NTSTATUS string
before calling ctdb_fatal()

metze
(This used to be commit 48ece3c21e3a5e9aa434c847eefaab59274a4e6f)

16 years agor23861: Fix return code in ads_find_samaccount().
Günther Deschner [Fri, 13 Jul 2007 09:53:55 +0000 (09:53 +0000)]
r23861: Fix return code in ads_find_samaccount().

Guenther
(This used to be commit 684fcf39dcc08bcf571272549222fdeb11d2725f)

16 years agor23858: Added srvstr_pull_buf_talloc() and srvstr_pull_talloc()
Jeremy Allison [Fri, 13 Jul 2007 01:22:09 +0000 (01:22 +0000)]
r23858: Added srvstr_pull_buf_talloc() and srvstr_pull_talloc()
calls and converted reply_tcon and reply_tconX to use
them - to show the boilerplate usage (valgrind tested).
In conjunction with Volker's srvstr_get_path_talloc()
work this should allow us to start eliminating all
pstrings/fstrings out of the main path processing
code.
I'll watch the build farm tonight...
Jeremy.
(This used to be commit b4eff3f68089f082781afcf90d43faa317949566)

16 years agor23856: Add Jiri.Sasek@Sun.COM;s fix from Axel Apitz for ZFS ACLs.
Jeremy Allison [Thu, 12 Jul 2007 18:49:44 +0000 (18:49 +0000)]
r23856: Add Jiri.Sasek@Sun.COM;s fix from Axel Apitz for ZFS ACLs.
Jeremy.
(This used to be commit 6ba12b6cb9f69297731c73071b627e8d7fbc6d73)

16 years agor23855: Setting the allocation size updates the modified time
Jeremy Allison [Thu, 12 Jul 2007 18:11:41 +0000 (18:11 +0000)]
r23855: Setting the allocation size updates the modified time
as a write does. Fix bug #4779.
Jeremy.
(This used to be commit ed0e2174a895b25ce2b4e8ffd912ad57b31dd2e9)

16 years agor23853: Fix a very misleading error message in tdbbackup.
Michael Adam [Thu, 12 Jul 2007 13:41:34 +0000 (13:41 +0000)]
r23853: Fix a very misleading error message in tdbbackup.

Michael
(This used to be commit 3a2a032a44502eebdb61faf9cfdb3e54f5072514)

16 years agor23850: Fix whitespacing in DEBUG output.
Michael Adam [Thu, 12 Jul 2007 09:36:52 +0000 (09:36 +0000)]
r23850: Fix whitespacing in DEBUG output.
(This used to be commit 918aad0d8b4b0c2caa8830726a17d3ad4d19f72a)

16 years agor23847: As Dr. Volker says, "A pstring a day....".
Jeremy Allison [Thu, 12 Jul 2007 00:42:09 +0000 (00:42 +0000)]
r23847: As Dr. Volker says, "A pstring a day....".
Jeremy.
(This used to be commit 8adf81696aee99c5090e1b827ceb14929ec4aeda)

16 years agor23846: Belt-and-braces on the msdfs bug. Ensure ELOOP maps
Jeremy Allison [Wed, 11 Jul 2007 23:54:01 +0000 (23:54 +0000)]
r23846: Belt-and-braces on the msdfs bug. Ensure ELOOP maps
correctly.
Jeremy.
(This used to be commit f2cf4b6b9d1ce561fdf9f6815564d5b4f033dd10)

16 years agor23845: Second part of the fix for #4777. Looks like on AIX opendir
Jeremy Allison [Wed, 11 Jul 2007 23:40:14 +0000 (23:40 +0000)]
r23845: Second part of the fix for #4777. Looks like on AIX opendir
returns an errno of ELOOP for a symlink of msdfs:server\path\to\link.
Cope with this by mapping to a known error NT_STATUS_OBJECT_PATH_NOT_FOUND
that we know dfs_path_lookup should ignore.
Jeremy.
(This used to be commit d4a7411c4886c601a917b0f0e53facc7e10dd18e)

16 years agor23844: Add patch series from Volker (after review and consultation).
Jeremy Allison [Wed, 11 Jul 2007 22:39:11 +0000 (22:39 +0000)]
r23844: Add patch series from Volker (after review and consultation).

0001-Save-a-strdup-in-stat_cache_add.patch
0002-Use-ISDOT-and-ISDOTDOT.patch
0003-Move-fname_equal-around.patch
0004-unix_convert-pstring-dirpath-char.patch
0005-Ignore-.o-files.patch
0006-Get-rid-of-pstrings-inside-unix_convert.patch
0007-revert-pstring-unix_convert.patch
0008-Make-name-an-allocated-pstring-inside-unix_convert.patch
0009-Pass-explicit-pstring-to-mangle_check_cache.patch
0010-Don-t-overwrite-orig_path-unnecessarily.patch
0011-Defer-allocating-name.patch
0012-Make-sure-dirpath-is-always-correctly-allocated.patch
0013-Remove-one-pstring-dependency-in-unix_convert.patch
0014-Remove-more-name-pstring-dependencies.patch
0015-Hide-the-nasty-API-of-mangle_check_cache-in-mangle_c.patch
0016-name-does-not-need-to-be-pstring-size-anymore.patch
0017-Make-use-of-ISDOT-and-ISDOTDOT.patch
0018-Remove-pstring-from-stat_cache_lookup.patch
0019-Add-my-copyright.patch

To remove pstrings from statcache and unix_convert.

Jeremy.
(This used to be commit ea6ef368891af24164d2e76700c405a82b3dfc19)

16 years agor23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Jeremy Allison [Wed, 11 Jul 2007 21:01:06 +0000 (21:01 +0000)]
r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
(This used to be commit cd93f0cb00207098014e41e0ba16210cb150b895)