samba.git
3 years agoEfficient xattr handling for VxFS Signed-off-by: Abhidnya Joshi <Abhidnya.Joshi@verit...
Abhidnya Joshi [Thu, 2 Jun 2016 06:38:31 +0000 (23:38 -0700)]
Efficient xattr handling for VxFS Signed-off-by: Abhidnya Joshi <Abhidnya.Joshi@veritas.com>

Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun  3 07:26:34 CEST 2016 on sn-devel-144

3 years agolib: replace: snprintf - Fix length calculation for hex/octal 64-bit values.
Lorinczy Zsigmond [Thu, 2 Jun 2016 21:54:05 +0000 (14:54 -0700)]
lib: replace: snprintf - Fix length calculation for hex/octal 64-bit values.

Prevents truncation due to buffer size being too small.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11947

Signed-off-by: Lorinczy Zsigmond <lzsiga@freemail.c3.hu>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jun  3 03:48:58 CEST 2016 on sn-devel-144

3 years agoImprove help wording for samba-tool domain provision as per https://lists.samba.org...
Peter C. Kelly [Wed, 4 May 2016 08:13:37 +0000 (20:13 +1200)]
Improve help wording for samba-tool domain provision as per https://lists.samba.org/archive/samba-technical/2016-April/113740.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11894
Signed-off-by: Peter C. Kelly <peter+sambabugzilla@pck.co.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun  2 20:07:22 CEST 2016 on sn-devel-144

3 years agobuild: Build less of Samba when building --without-ntvfs-fileserver
Andrew Bartlett [Tue, 10 May 2016 17:33:17 +0000 (05:33 +1200)]
build: Build less of Samba when building --without-ntvfs-fileserver

We would build, but not use, many components of the NTVFS file server
even when we asked not to.  They would then consume disk, but not be
of any use

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agorepl: Do not consider userPassword differences to matter in rpc.dssync
Andrew Bartlett [Mon, 30 May 2016 01:57:26 +0000 (13:57 +1200)]
repl: Do not consider userPassword differences to matter in rpc.dssync

userPassword is also not shown over LDAP

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agotorture: Only walk over objects actually converted in drs.dssync
Andrew Bartlett [Fri, 13 May 2016 04:06:29 +0000 (16:06 +1200)]
torture: Only walk over objects actually converted in drs.dssync

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agosamba-tool domain demote: Fix error handling and error messages
Andrew Bartlett [Wed, 20 Apr 2016 20:16:19 +0000 (08:16 +1200)]
samba-tool domain demote: Fix error handling and error messages

Due to an error in a previous patch, e was undefined

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoselftest: Mark LDAPNotificationTest.test_max_search flapping
Andrew Bartlett [Wed, 23 Mar 2016 03:56:17 +0000 (16:56 +1300)]
selftest: Mark LDAPNotificationTest.test_max_search flapping

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agodsdb: Improve syntax clarity
Andrew Bartlett [Tue, 15 Mar 2016 02:09:14 +0000 (15:09 +1300)]
dsdb: Improve syntax clarity

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agodsdb: Use DRSUAPI_ATTID_isDeleted constant in repl_meta_data
Andrew Bartlett [Thu, 12 May 2016 23:39:19 +0000 (11:39 +1200)]
dsdb: Use DRSUAPI_ATTID_isDeleted constant in repl_meta_data

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agomit_samba: Allow to use SPNs for AS-REQ
Andreas Schneider [Tue, 26 Apr 2016 14:37:29 +0000 (16:37 +0200)]
mit_samba: Allow to use SPNs for AS-REQ

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Thu Jun  2 16:35:35 CEST 2016 on sn-devel-144

3 years agomit_samba: Fix flags that we get a referral tickets
Andreas Schneider [Wed, 17 Feb 2016 08:32:11 +0000 (09:32 +0100)]
mit_samba: Fix flags that we get a referral tickets

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agomit_samba: Return 0 in case of a wrong realm
Andreas Schneider [Mon, 15 Feb 2016 07:31:16 +0000 (08:31 +0100)]
mit_samba: Return 0 in case of a wrong realm

The MIT KDC will deal with this correctly for us.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agosdb: Do not create kmod information if we return early
Andreas Schneider [Mon, 15 Feb 2016 07:29:27 +0000 (08:29 +0100)]
sdb: Do not create kmod information if we return early

In case of a wrong realm in a cross forest trust we return early with
just the realm corrected. We need to parse a kdb entry but do not have
all information available. So skip creating the kmod.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agosdb: Fix NULL pointer deference if we return early
Andreas Schneider [Mon, 15 Feb 2016 07:27:54 +0000 (08:27 +0100)]
sdb: Fix NULL pointer deference if we return early

If we return because of a wrong realm in a cross forest trust case, we
do not have a skdc_entry allocated.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agokdb: Do not allocate memory with size 0
Andreas Schneider [Mon, 15 Feb 2016 07:24:45 +0000 (08:24 +0100)]
kdb: Do not allocate memory with size 0

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agosdb: Do not set disallow if we do not have ticket info in the DB
Andreas Schneider [Fri, 12 Feb 2016 09:01:54 +0000 (10:01 +0100)]
sdb: Do not set disallow if we do not have ticket info in the DB

These things are applied by the incoming ticket by the KDC.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agotorture: Add a dummy test for MIT Kerberos case
Andreas Schneider [Fri, 13 May 2016 07:42:44 +0000 (09:42 +0200)]
torture: Add a dummy test for MIT Kerberos case

This is a preperatory test to add tests for the MIT KDC.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agotorture: Fix trailing whitespaces in krb5 tests
Andreas Schneider [Thu, 2 Jun 2016 08:14:25 +0000 (10:14 +0200)]
torture: Fix trailing whitespaces in krb5 tests

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
3 years agos3/client/clitar.c: always close fd
Aurelien Aptel [Tue, 31 May 2016 13:46:47 +0000 (15:46 +0200)]
s3/client/clitar.c: always close fd

Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jun  2 12:47:26 CEST 2016 on sn-devel-144

3 years agowinbindd: prevent log spam when enumerating users
Ralph Boehme [Tue, 31 May 2016 16:52:12 +0000 (18:52 +0200)]
winbindd: prevent log spam when enumerating users

When enumerating users we try to fetch sAMAccountType attribute which
might not be present for whatever reason.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Thu Jun  2 09:04:13 CEST 2016 on sn-devel-144

3 years agowinbindd: log domain name of failures to get trustdoms
Ralph Boehme [Wed, 3 Feb 2016 07:07:02 +0000 (08:07 +0100)]
winbindd: log domain name of failures to get trustdoms

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
3 years agotalloc: rename local timeval function copies
Ralph Boehme [Wed, 1 Jun 2016 13:42:13 +0000 (15:42 +0200)]
talloc: rename local timeval function copies

timeval_current() and timeval_elapsed() are public functions from
libsamba-util. Redeclaring them as static functions here triggers linker
error when building with gcc link-time-optimisation (LTO).

This shows the error after reverting this patch:
[slow@kazak lto]$ make -j
WAF_MAKE=1 python ./buildtools/bin/waf build
Waf: Entering directory `/home/slow/git/samba/lto/bin'
        Selected embedded Heimdal build
[ 174/4259] Generating ctdb-samba-version-header
[ 174/4259] Generating ctdb-samba-version-header
[ 521/4259] Generating source4/torture/local/proto.h
[2565/4259] Compiling lib/talloc/testsuite.c
[4125/4259] Linking default/source4/torture/smbtorture
/tmp/ccvL9UCe.ltrans3.ltrans.o:<artificial>:function smbsrv_accept.lto_priv.11: error: undefined reference to 'timeval_current.lto_priv.630'
/tmp/ccvL9UCe.ltrans4.ltrans.o:<artificial>:function smbsrv_recv_smb2_request: error: undefined reference to 'timeval_current.lto_priv.630'
/tmp/ccvL9UCe.ltrans4.ltrans.o:<artificial>:function smb2srv_negprot_backend: error: undefined reference to 'timeval_current.lto_priv.630'
/tmp/ccvL9UCe.ltrans4.ltrans.o:<artificial>:function smb2srv_negprot_backend: error: undefined reference to 'timeval_current.lto_priv.630'
/tmp/ccvL9UCe.ltrans9.ltrans.o:<artificial>:function test_smb2_oplock_batch22: error: undefined reference to 'timeval_elapsed.lto_priv.628'
/tmp/ccvL9UCe.ltrans9.ltrans.o:<artificial>:function test_smb2_bench_oplock: error: undefined reference to 'timeval_elapsed.lto_priv.628'
/tmp/ccvL9UCe.ltrans9.ltrans.o:<artificial>:function test_smb2_bench_oplock: error: undefined reference to 'timeval_elapsed.lto_priv.628'
/tmp/ccvL9UCe.ltrans9.ltrans.o:<artificial>:function test_smb2_bench_oplock: error: undefined reference to 'timeval_elapsed.lto_priv.628'
collect2: error: ld returned 1 exit status
...

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jun  1 21:09:16 CEST 2016 on sn-devel-144

3 years agoctdb-recoverd: Freeze databases whenever the node is INACTIVE
Amitay Isaacs [Wed, 1 Jun 2016 02:10:46 +0000 (12:10 +1000)]
ctdb-recoverd: Freeze databases whenever the node is INACTIVE

If the node becomes stopped or banned after recovery is marked
active, then it will never freeze the databases, and hence the
node will keep banning itself indefinitely, until ctdbd is restarted.

This is a regression from 4.3, introduced with

b4357a79d916b1f8ade8fa78563fbef0ce670aa9

and

d8f3b490bbb691c9916eed0df5b980c1aef23c85

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11945

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Jun  1 17:36:12 CEST 2016 on sn-devel-144

3 years agoctdb:banning: Improve debug message in ctdb_ban_node_event()
Michael Adam [Tue, 31 May 2016 23:16:23 +0000 (01:16 +0200)]
ctdb:banning: Improve debug message in ctdb_ban_node_event()

Make it more clear what happens when reading the logs.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb:banning: Improve a debug message
Michael Adam [Tue, 31 May 2016 22:53:54 +0000 (00:53 +0200)]
ctdb:banning: Improve a debug message

This adapts the debug message in local_node_got_banned
to reflect what the function is currently doing.
This message was not adapted when the function was changed.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agorepl_meta_data: Do rename before deleted object cleanup
Andrew Bartlett [Mon, 21 Mar 2016 23:07:27 +0000 (12:07 +1300)]
repl_meta_data: Do rename before deleted object cleanup

Following from the lesson of subtree_rename, do the rename first,
as this is more likely to fail for some reason

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun  1 14:01:36 CEST 2016 on sn-devel-144

3 years agodsdb/subtree_rename: Rename the base before we rename children
Andrew Bartlett [Tue, 15 Mar 2016 02:35:21 +0000 (15:35 +1300)]
dsdb/subtree_rename: Rename the base before we rename children

Otherwise, we might rename children to be under a different, conflicting, DN.

This would normally be picked up in the transaction rollback, but in replication
the transaction is not aborted for this situation

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agogetncchanges: Fill in ctr6.linked_attributes with a pointer to a zero-length array
Andrew Bartlett [Sun, 13 Mar 2016 22:10:04 +0000 (11:10 +1300)]
getncchanges: Fill in ctr6.linked_attributes with a pointer to a zero-length array

Our newly run repl_exop tests expect this, matching Windows 2012R2

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agogetncchanges: Use the talloc_stackframe() for tempory memory
Andrew Bartlett [Sun, 13 Mar 2016 22:09:02 +0000 (11:09 +1300)]
getncchanges: Use the talloc_stackframe() for tempory memory

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agogetncchanges: Give the correct error when RID_ALLOC fails on an invalid destination_d...
Andrew Bartlett [Sun, 13 Mar 2016 22:06:39 +0000 (11:06 +1300)]
getncchanges: Give the correct error when RID_ALLOC fails on an invalid destination_dsa_guid

This is found by our new tests.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agorpc_server/drsuapi: Return the correct 3 objects for DRSUAPI_EXOP_FSMO_RID_ALLOC
Andrew Bartlett [Fri, 4 Mar 2016 00:12:12 +0000 (13:12 +1300)]
rpc_server/drsuapi: Return the correct 3 objects for DRSUAPI_EXOP_FSMO_RID_ALLOC

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agoctdb:tests: timedout->timed out in 60.nfs.multi.004 test
Michael Adam [Tue, 31 May 2016 22:45:00 +0000 (00:45 +0200)]
ctdb:tests: timedout->timed out in 60.nfs.multi.004 test

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jun  1 04:30:36 CEST 2016 on sn-devel-144

3 years agoctdb:eventscript: timedout->timed out in ctdb_event_script_args()
Michael Adam [Tue, 31 May 2016 22:44:21 +0000 (00:44 +0200)]
ctdb:eventscript: timedout->timed out in ctdb_event_script_args()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agoctdb:banning: timedout->timed out in dbg messages in ctdb_ban_node_event()
Michael Adam [Tue, 31 May 2016 22:43:38 +0000 (00:43 +0200)]
ctdb:banning: timedout->timed out in dbg messages in ctdb_ban_node_event()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agoctdb:tcp: add missing spaces in debug message in ctdb_tcp_node_connect()
Michael Adam [Thu, 26 May 2016 11:40:38 +0000 (13:40 +0200)]
ctdb:tcp: add missing spaces in debug message in ctdb_tcp_node_connect()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agodsdb: Simplify acl_validate_spn_value
Volker Lendecke [Fri, 27 May 2016 08:40:55 +0000 (10:40 +0200)]
dsdb: Simplify acl_validate_spn_value

Avoid pointless "else" and fix indentation

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3-dfree-quota: remove special handling of EDQUOT
Uri Simchoni [Fri, 27 May 2016 19:15:46 +0000 (22:15 +0300)]
s3-dfree-quota: remove special handling of EDQUOT

It is no longer part of the quota VFS interface to return
an EDQUOT error as an indication that getting quota succeeded
but the user/group is over-quota. A VFS module implementing
quota interface always returns 0 on success.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3-sysquotas: remove special handling of EDQUOT
Uri Simchoni [Fri, 27 May 2016 18:51:38 +0000 (21:51 +0300)]
s3-sysquotas: remove special handling of EDQUOT

The sysquotas module has several supported backends for
getting/setting user/group quota. This patch removes a check
by the common code, to see if the backend has returned EDQUOT.

Before this patch, it was OK for a backend to return with error
and errno set to EDQUOT, and that meant success, but with a warning
that the user/group is over quota. This is the system behavior on
some Unices. This patch removes this from the protocol between the
sysquota module and its backend drivers - it's the responsibility
of the backend to return 0 iff it has fulfilled the request to get or
set quota.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agovfs_fake_dfq - remove support for generating EDQUOT
Uri Simchoni [Fri, 27 May 2016 18:42:49 +0000 (21:42 +0300)]
vfs_fake_dfq - remove support for generating EDQUOT

Remove the option to retrieve valid user/group quota while
returning -1 and EDQUOT errno - this is no longer part of the
protocol between the quota backend and smbd.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agoselftest: remove test for EDQUOT returned from quota backend
Uri Simchoni [Fri, 27 May 2016 18:40:06 +0000 (21:40 +0300)]
selftest: remove test for EDQUOT returned from quota backend

Remove a test for special handling of EDQUOT errno when determining
user/group quota - If the backend has obtained the quota settings it
has to return 0 and not error.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3-sysquotas-linux: do not check for EDQUOT
Uri Simchoni [Thu, 26 May 2016 07:24:58 +0000 (10:24 +0300)]
s3-sysquotas-linux: do not check for EDQUOT

When obtaining user/group quota, remove check for EDQUOT
errno return. Apparently on some Unices, EDQUOT means that
the get-quota function has succeeded, but the user/group is
over-quota. Not so in Linux.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agosamba-too: Allow 'samba-tool fsmo' to cope with empty or missing fsmo roles
Rowland Penny [Thu, 31 Mar 2016 11:07:00 +0000 (12:07 +0100)]
samba-too: Allow 'samba-tool fsmo' to cope with empty or missing fsmo roles

samba-too: Allow 'samba-tool fsmo' to cope with empty or missing fsmo roles

Signed-off-by: Rowland Penny <rpenny@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
3 years agos3/client/clitar.c: NULL-check correct variable
Aurelien Aptel [Tue, 31 May 2016 13:44:27 +0000 (15:44 +0200)]
s3/client/clitar.c: NULL-check correct variable

`f` was checked again instead of `s`.

Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Reviewed-by: ndreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agorwrap: Update resolve_wrapper to version 1.1.4
Andreas Schneider [Tue, 31 May 2016 06:36:01 +0000 (08:36 +0200)]
rwrap: Update resolve_wrapper to version 1.1.4

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue May 31 20:13:43 CEST 2016 on sn-devel-144

3 years agolib: tevent: Use struct sockaddr_storage to cope with IPv6.
Jeremy Allison [Fri, 27 May 2016 18:43:31 +0000 (11:43 -0700)]
lib: tevent: Use struct sockaddr_storage to cope with IPv6.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun May 29 09:13:30 CEST 2016 on sn-devel-144

3 years agos3: lib: ldap: Use struct sockaddr_storage to cope with IPv6.
Jeremy Allison [Fri, 27 May 2016 18:42:58 +0000 (11:42 -0700)]
s3: lib: ldap: Use struct sockaddr_storage to cope with IPv6.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
3 years agos3: net: Return an error when no name servers were returned by the lookup so that...
Richard Sharpe [Sun, 15 May 2016 17:28:04 +0000 (10:28 -0700)]
s3: net: Return an error when no name servers were returned by the lookup so that we see an error in self test.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 28 04:34:20 CEST 2016 on sn-devel-144

3 years agosmbd: dfree - ignore quota if not enforced
Uri Simchoni [Wed, 27 Apr 2016 20:22:25 +0000 (23:22 +0300)]
smbd: dfree - ignore quota if not enforced

When calculating free disk space, do not take user quota
into account if quota is globally not enforced on the file
system.

This is meant to fix a specific problem with XFS. One might
say "why don't you fix the XFS-specific code instead?". The
reason for that is that getting and setting quota must not
be affected by whether quota is actually enforced. NTFS has
the same notion of separating quota accounting (and being
able to configure / retrieve configured quota), from quota
enforcement.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11937

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 28 00:09:05 CEST 2016 on sn-devel-144

3 years agoselftest: add disk-free quota tests
Uri Simchoni [Thu, 26 May 2016 19:52:09 +0000 (22:52 +0300)]
selftest: add disk-free quota tests

Add a test for situation where quota accounting is enabled
but quota enforcement is disabled (disk-free should not take
quota into account)

Add a test for situation where overall quota status reporting
(whether or not it's enforcing) is not supported - as with NFS.
In that case it must be assumed that if quota is configured, then
it is also enforced (as with NFS).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11937

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agovfs_fake_dfq: add more mocking options
Uri Simchoni [Thu, 26 May 2016 18:59:38 +0000 (21:59 +0300)]
vfs_fake_dfq: add more mocking options

Add support for mocking FS user/group quotas (default quota and
quota flags).

Make the default block size 4096 instead of 0. This
turns the default into "no quota" instead of "punt to
lower VFS module" (that is, if the mock module is asked
to retrieve quota of a user/group/default for which there
is no config).

Add support for ENOSYS error

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11937

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agoFix memory leak in share mode locking.
Hemanth Thummala [Wed, 25 May 2016 06:15:04 +0000 (23:15 -0700)]
Fix memory leak in share mode locking.

Not freeing up(and reparenting to NULL context) ndr buffer
used for TDB updates resulting in huge memory leak when there
in high volume of opens and closes happening on same object.

Free the buffer before reparenting its parent to NULL context.

https://bugzilla.samba.org/show_bug.cgi?id=11934

Signed-off-by: Hemanth Thummala <hemanth.thummala@nutanix.com>
Signed-off-by: Saji VR <saji.vr@nutanix.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 27 18:43:31 CEST 2016 on sn-devel-144

3 years agos3: auth: Move the declaration of struct dom_sid tmp_sid to function level scope.
Jeremy Allison [Thu, 26 May 2016 23:31:55 +0000 (16:31 -0700)]
s3: auth: Move the declaration of struct dom_sid tmp_sid to function level scope.

It's referred to outside of the {} brace scope it was defined in by
the following code:

                uid_to_unix_users_sid(*uid, &tmp_sid);
                user_sid = &tmp_sid;

As tmp_sid was going out of scope, user_sid was
being incorrectly set in the token sid list.

I think this *may* be the root cause of:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10618

But even if not this is an obvious error that must
be fixed.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 27 11:28:18 CEST 2016 on sn-devel-144

3 years agos3-sysquotas-linux - cleanup
Uri Simchoni [Mon, 23 May 2016 20:14:12 +0000 (23:14 +0300)]
s3-sysquotas-linux - cleanup

Now that the module supports only the current Linux quota
interface, it does not need a two-level hierarchy.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Thu May 26 18:54:12 CEST 2016 on sn-devel-144

3 years agos3-sysquotas-linux: remove check for EDQUOT on getting user quota
Uri Simchoni [Mon, 23 May 2016 19:27:28 +0000 (22:27 +0300)]
s3-sysquotas-linux: remove check for EDQUOT on getting user quota

The same check is done by sys_get_quota() which is the only caller.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3-sysquotas-linux: remove support for old interfaces
Uri Simchoni [Mon, 23 May 2016 19:07:39 +0000 (22:07 +0300)]
s3-sysquotas-linux: remove support for old interfaces

Remove support for Linux quota interfaces that predate the
2.6.x kernel series. Glibc has been supporting the "current"
quota interface for over 10 years now...

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agoctdb-common: Use correct macro for checking Ethernet hardware family
Martin Schwenke [Thu, 19 May 2016 06:22:36 +0000 (16:22 +1000)]
ctdb-common: Use correct macro for checking Ethernet hardware family

Both of these expand to 1.  However, AF_LOCAL is a Unix domain socket,
which makes no sense when reading the code.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu May 26 11:42:46 CEST 2016 on sn-devel-144

3 years agoctdb-tests: Make sure empty override values are properly quoted
Martin Schwenke [Fri, 13 May 2016 21:13:41 +0000 (07:13 +1000)]
ctdb-tests: Make sure empty override values are properly quoted

With an empty value the first expression adds a trailing opening
quote, so the second expression doesn't add the closing quote.  Handle
this with a special case.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb-tests: Allow local daemons to be run under valgrind
Martin Schwenke [Wed, 4 May 2016 04:47:54 +0000 (14:47 +1000)]
ctdb-tests: Allow local daemons to be run under valgrind

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb-scripts: Simplify ip_maskbits_iface()
Martin Schwenke [Fri, 13 May 2016 15:06:38 +0000 (01:06 +1000)]
ctdb-scripts: Simplify ip_maskbits_iface()

This doesn't need to print the family.  Nothing uses it.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb-tests: Drop no-op functions and add an ip6tables stub
Martin Schwenke [Fri, 13 May 2016 15:01:48 +0000 (01:01 +1000)]
ctdb-tests: Drop no-op functions and add an ip6tables stub

Stub scripts are more obvious.  rc.local should only be used when
strictly necessary.

iptables_wrapper doesn't need to be no-op-ed, provided flock is
installed.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb-scripts: Rename get_iface_ip_maskbits_family() to get_iface_ip_maskbits()
Martin Schwenke [Fri, 13 May 2016 10:24:52 +0000 (20:24 +1000)]
ctdb-scripts: Rename get_iface_ip_maskbits_family() to get_iface_ip_maskbits()

The family is not needed.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoctdb-scripts: New functions ip_block() and ip_unblock()
Martin Schwenke [Fri, 13 May 2016 09:43:05 +0000 (19:43 +1000)]
ctdb-scripts: New functions ip_block() and ip_unblock()

Block and unblock IP addresses using these new functions.  This makes
the code more readable.

The case statement in each function is very cheap, so there is no need
to prematurely optimise and pass the family.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
3 years agoExtend DsBind and DsGetDomainControllerInfo to work with w2k8.
Dirk Godau [Tue, 24 May 2016 23:49:24 +0000 (11:49 +1200)]
Extend DsBind and DsGetDomainControllerInfo to work with w2k8.

W2K8 Clients ask for DRSUAPI_SUPPORTED_EXTENSION_LH_BETA2 on DsBind. W2K8
expect this to be set (with server fl 2k8) or else they do not call
DsGetDomainControllerInfo.

If DRSUAPI_SUPPORTED_EXTENSION_LH_BETA2 is set, DsGetDomainControllerInfo
must be able to return DCInfo Level 3.

If Samba4 AD ist set to work as 2k8, with >2k8 clients the following
will not work as expected:

  * Group Policy Editor Infrastructure Discovery
  * nltest /dclist:<domain>
  * w32tm /monitor

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9971
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9976

Signed-off-by: Dirk Godau <voidswitch@gmail.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Thu May 26 06:21:10 CEST 2016 on sn-devel-144

3 years agodrsuapi tests for DsBind with w2k8
Dirk Godau [Tue, 24 May 2016 23:50:09 +0000 (11:50 +1200)]
drsuapi tests for DsBind with w2k8

These are marked as known_fail pending the next patch ("Extend DsBind
and DsGetDomainControllerInfo to work with w2k8").

Signed-off-by: Dirk Godau <voidswitch@gmail.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
3 years agos3: docs: Add documentation for posix_whoami command in smbclient.
Jeremy Allison [Wed, 25 May 2016 16:17:40 +0000 (09:17 -0700)]
s3: docs: Add documentation for posix_whoami command in smbclient.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 26 02:43:55 CEST 2016 on sn-devel-144

3 years agos3: smbclient: Add posix_whoami command.
Jeremy Allison [Wed, 25 May 2016 16:15:13 +0000 (09:15 -0700)]
s3: smbclient: Add posix_whoami command.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
3 years agos3: libsmb: Add sync and async cli_posix_whoami().
Jeremy Allison [Tue, 24 May 2016 23:58:11 +0000 (16:58 -0700)]
s3: libsmb: Add sync and async cli_posix_whoami().

Will add as a command to smbclient, plus will be useful for testing.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>
3 years agos3-smbd: Support systemd 230
Alexander Bokovoy [Wed, 25 May 2016 12:41:52 +0000 (15:41 +0300)]
s3-smbd: Support systemd 230

systemd 230 version finally deprecated libsystemd-daemon/libsystemd-journal split
and put everything in libsystemd library.

Make sure HAVE_LIBSYSTEMD define is supported in the code (we already
have it defined by the waf).

Patch is based on the code proposed by Zbigniew JÄ™drzejewski-Szmek
from systemd project.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11936

Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed May 25 20:25:44 CEST 2016 on sn-devel-144

3 years agos3-smbspool: Log to stderr
Andreas Schneider [Wed, 25 May 2016 11:39:29 +0000 (13:39 +0200)]
s3-smbspool: Log to stderr

This way we will be able to see the log in the cups logs and are able to
debug issues.

https://bugzilla.samba.org/show_bug.cgi?id=11935

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
3 years agodrsuapi: Improve debug in DsWriteAccountSpn
Volker Lendecke [Tue, 24 May 2016 13:10:14 +0000 (15:10 +0200)]
drsuapi: Improve debug in DsWriteAccountSpn

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed May 25 11:34:13 CEST 2016 on sn-devel-144

3 years agosamdb: Improve debugging in acl_validate_spn_value()
Volker Lendecke [Tue, 24 May 2016 13:07:00 +0000 (15:07 +0200)]
samdb: Improve debugging in acl_validate_spn_value()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoselftest: use the default values for "server signing"
Stefan Metzmacher [Wed, 15 Jul 2015 09:10:24 +0000 (11:10 +0200)]
selftest: use the default values for "server signing"

That will hopefully catch possible regressions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11910

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue May 24 18:35:19 CEST 2016 on sn-devel-144

3 years agos3:selftest: run test_smbclient_ntlm also against ad_dc
Stefan Metzmacher [Wed, 18 May 2016 08:24:36 +0000 (10:24 +0200)]
s3:selftest: run test_smbclient_ntlm also against ad_dc

This makes sure anonymous connections work if the server
requires signing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11910

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoselftest: systematize formatting of if/elseif/else indentation in cleanup_child
Michael Adam [Fri, 13 May 2016 22:51:19 +0000 (00:51 +0200)]
selftest: systematize formatting of if/elseif/else indentation in cleanup_child

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue May 24 13:43:35 CEST 2016 on sn-devel-144

3 years agoselftest: improve logic in cleanup_child() with early return
Michael Adam [Fri, 13 May 2016 22:49:40 +0000 (00:49 +0200)]
selftest: improve logic in cleanup_child() with early return

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoselftest: improve misleading indentation in cleanup_child()
Michael Adam [Fri, 13 May 2016 22:44:18 +0000 (00:44 +0200)]
selftest: improve misleading indentation in cleanup_child()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoselftest: fix printf in cleanup_child()
Michael Adam [Fri, 13 May 2016 22:38:48 +0000 (00:38 +0200)]
selftest: fix printf in cleanup_child()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
3 years agoheimdal make kvno unisgned internally
Uri Simchoni [Tue, 17 May 2016 10:45:11 +0000 (13:45 +0300)]
heimdal make kvno unisgned internally

The folks at heimdal didn't like the patch in
commit 6379737b7ddc6ccb752238c5820cc62e76a8da17 and insisted
that kvno should remain unsigned internally, even though it is
encoded as signed in packets. This patch reverts some of the
unsigned->signed changes in that commit, and resolves conversion
issues - in order to be aligned with upstream Heimdal.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue May 24 03:00:39 CEST 2016 on sn-devel-144

3 years agos3-quotas: fix sysquotas_4B quota fetching for BSD
Uri Simchoni [Sat, 21 May 2016 19:25:32 +0000 (22:25 +0300)]
s3-quotas: fix sysquotas_4B quota fetching for BSD

Correctly copy block hard/soft limits from the OS-specific structure
to samba structure.

BUG:https://bugzilla.samba.org/show_bug.cgi?id=11931

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3:rpcclient: make use of SMB_SIGNING_IPC_DEFAULT
Stefan Metzmacher [Thu, 19 May 2016 09:47:18 +0000 (11:47 +0200)]
s3:rpcclient: make use of SMB_SIGNING_IPC_DEFAULT

This means we'll use the "client ipc min protocol", "client ipc max protocol"
and "client ipc signing" options. But "--signing=no" or "--signing=required"
still overwrite "client ipc signing".

The following can be used to alter the max protocol

rpcclient --option="client ipc max protocol=SMB2_10" 172.31.9.163 -Uadministrator%A1b2C3d4 -c "getusername"
Account Name: Administrator, Authority Name: W4EDOM-L4

rpcclient --option="client ipc max protocol=NT1" 172.31.9.163 -Uadministrator%A1b2C3d4 -c "getusername"
Account Name: Administrator, Authority Name: W4EDOM-L4

rpcclient 172.31.9.163 -Uadministrator%A1b2C3d4 -c "getusername"
Account Name: Administrator, Authority Name: W4EDOM-L4

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11927

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat May 21 05:01:15 CEST 2016 on sn-devel-144

3 years agoRevert "s3:rpcclient add -m option"
Stefan Metzmacher [Thu, 19 May 2016 09:47:29 +0000 (11:47 +0200)]
Revert "s3:rpcclient add -m option"

This reverts commit a55ac51f5f67c61bda1fee7067ad7d09a0c1efdf.

This will be implemented in a more common way using the
"client ipc max protocol" option.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11927

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agos3: wscript: Add checks for open file description locks.
Jeremy Allison [Thu, 12 May 2016 19:46:50 +0000 (21:46 +0200)]
s3: wscript: Add checks for open file description locks.

Compiles and runs code that checks for working
F_OFD_GETLK, F_OFD_SETLK, F_OFD_SETLKW.

We now use these if available.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: VFS: Map process-associated lock operation to open file description lock operation.
Jeremy Allison [Thu, 12 May 2016 19:17:21 +0000 (21:17 +0200)]
s3: VFS: Map process-associated lock operation to open file description lock operation.

Only in the default VFS. Gpfs, Ceph, Gluster and other modern
backend VFS filesystems might want to do the same.

Allow tuneable "smbd:force process locks = true" to turn
off OFD locks if in use and the kernel doesn't support them.

Display debug message showing admins what to do in this case.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: lib: util: Add map_process_lock_to_ofd_lock() utility function.
Jeremy Allison [Thu, 12 May 2016 19:14:28 +0000 (21:14 +0200)]
s3: lib: util: Add map_process_lock_to_ofd_lock() utility function.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: VFS: Add bool use_ofd_locks member to struct files_struct.
Jeremy Allison [Thu, 12 May 2016 19:03:57 +0000 (21:03 +0200)]
s3: VFS: Add bool use_ofd_locks member to struct files_struct.

Not yet used. We will set this if we translate a process-associated
lock operation to a open file description lock operation.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: lib: Add 'int op' parameter to fcntl_getlock().
Jeremy Allison [Thu, 12 May 2016 18:57:36 +0000 (20:57 +0200)]
s3: lib: Add 'int op' parameter to fcntl_getlock().

Will allow us to move to open file description locks
from process-associated locks.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: torture: Add POSIX-OFD-LOCK test.
Jeremy Allison [Fri, 13 May 2016 14:09:54 +0000 (15:09 +0100)]
s3: torture: Add POSIX-OFD-LOCK test.

Ensures that we *always* expose ofd-lock behavior to clients.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: locking: Convert on the wire behavior of POSIX (UNIX extensions) locks from proce...
Jeremy Allison [Mon, 16 May 2016 23:59:30 +0000 (16:59 -0700)]
s3: locking: Convert on the wire behavior of POSIX (UNIX extensions) locks from process-associated locks to open file description locks.

This means locks are associated with the SMB handle
they were created on, not the inode. In all other ways
they behave like UNIX extensions fcntl (process-associated)
locks. Torture test to follow.

When a handle is closed all locks attached to that handle
are closed, not all locks on the underlying inode. In
this respect they now behave like Windows locks.

The key to this in the UNIX extensions locking codepath is modifying
the reference count only when a new locking context is seen
on any lock request, and decrementing the reference count
when the last instance of a locking context is seen on any
unlock request. For SMB2+ the persistent part of a file handle
is used as the locking context so this behavior becomes
natural.

This is a behavior change but after consultation with
Jeff Layton and Steve French the only client that implements
UNIX extensions POSIX locks - the cifsfs client - already
expects these locks to behave like open file description
(ofd) locks. With our previous behavior Linux ofd-locks
fail against smbd.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: locking: Add a const struct lock_context * paramter to set_posix_lock_posix_flavour()
Jeremy Allison [Tue, 17 May 2016 19:49:36 +0000 (12:49 -0700)]
s3: locking: Add a const struct lock_context * paramter to set_posix_lock_posix_flavour()

We will need this to implement open file description record locks.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: locking: Add some const.
Jeremy Allison [Mon, 16 May 2016 23:37:47 +0000 (16:37 -0700)]
s3: locking: Add some const.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agos3: locking: Rename xxx_windows_lock_ref_count to xxx_lock_ref_count.
Jeremy Allison [Mon, 16 May 2016 23:17:12 +0000 (16:17 -0700)]
s3: locking: Rename xxx_windows_lock_ref_count to xxx_lock_ref_count.

We will be using this to also ref count a posix lock applied
to a file handle when changing to open file description lock
semantics.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Jeff Layton <jlayton@samba.org>
3 years agoctdb-scripts: Drop unnecessary detect_init_style() call
Martin Schwenke [Tue, 10 May 2016 16:44:26 +0000 (02:44 +1000)]
ctdb-scripts: Drop unnecessary detect_init_style() call

CTDB_INIT_STYLE isn't used in this script.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri May 20 21:06:18 CEST 2016 on sn-devel-144

3 years agoctdb-scripts: Support systemctl directly
Martin Schwenke [Tue, 10 May 2016 16:42:40 +0000 (02:42 +1000)]
ctdb-scripts: Support systemctl directly

Some Linux distributions don't have a "service" compatibility command.

To avoid breaking working systems, prefer the "service" compatibility
command just in case it does some extra, unexpected magic.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Kai Blin <kai@samba.org>
3 years agonotifyd: prevent NULL deref segfault in notifyd_peer_destructor
Michael Adam [Fri, 20 May 2016 10:57:48 +0000 (12:57 +0200)]
notifyd: prevent NULL deref segfault in notifyd_peer_destructor

It seems it could happen that p->db == NULL in the list
from notifyd_clean_peers_next(). This has been seen in
a ctdb cluster when an node-internal ctdb interface is
brought down.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11930

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 20 17:32:55 CEST 2016 on sn-devel-144

3 years agoswrap: Update to version 1.1.7
Andreas Schneider [Fri, 20 May 2016 08:20:28 +0000 (10:20 +0200)]
swrap: Update to version 1.1.7

* Added support for accept4()
* Added support for OpenBSD
* Fixed sendto() with UDP and a connected socket
* Fixed AF_RAWLINK sockets

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri May 20 13:58:37 CEST 2016 on sn-devel-144

3 years agovfs_fruit: Fix a few signed/unsigned mixups
Volker Lendecke [Thu, 19 May 2016 16:42:04 +0000 (18:42 +0200)]
vfs_fruit: Fix a few signed/unsigned mixups

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May 19 23:53:47 CEST 2016 on sn-devel-144

3 years agovfs_fileid: Fix a signed/unsigned mixup
Volker Lendecke [Thu, 19 May 2016 12:55:10 +0000 (14:55 +0200)]
vfs_fileid: Fix a signed/unsigned mixup

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
3 years agopython:samba: move netcmd/time.py to python/samba/netcmd/nettime.py
Stefan Metzmacher [Thu, 11 Feb 2016 16:51:29 +0000 (17:51 +0100)]
python:samba: move netcmd/time.py to python/samba/netcmd/nettime.py

This allows 'import time' to work.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu May 19 15:21:58 CEST 2016 on sn-devel-144

3 years agoWHATSNEW: add 'Support for LDAP_SERVER_NOTIFICATION_OID'
Stefan Metzmacher [Wed, 17 Feb 2016 10:29:16 +0000 (11:29 +0100)]
WHATSNEW: add 'Support for LDAP_SERVER_NOTIFICATION_OID'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>