24 years agoFuss fuss fuss.
Christopher R. Hertel [Wed, 27 Jan 1999 18:22:48 +0000 (18:22 +0000)]
Fuss fuss fuss.

Added missing default: statements to two switch blocks.

Chris -)-----
(This used to be commit 0681f6946be2f7b528a1efb6adcc2366a2951644)

24 years ago- got client code cleartext passwords working again in cli_session_setup.
Luke Leighton [Wed, 27 Jan 1999 00:08:33 +0000 (00:08 +0000)]
- got client code cleartext passwords working again in cli_session_setup.
  needed this for some tests.

- removed code that said "if lm password is not encrypted then encrypt both
  lm and nt passwords".  actually it said "if lm password length is not 24
  bytes and we're in security=user mode..."

  it didn't bother to check whether the nt password was NULL or not, and
  doing the encryption inside cli_session_setup is the wrong place.

- checked all instances where cli_session_setup is called with cleartext
  passwords that are expected to then be encrypted (see above) with the
  test "if pwlen != 24...".  there was only one: all the others either
  provide encrypted passwords, do null sessions or use

* recommendation: use cli_establish_connection() in smbwrapper/smbw.c
(This used to be commit 2a509e9606f8aefbefa6e7b49878726464dbed44)

24 years agocompilation errors due to addition of smb file handle parameter.
Luke Leighton [Wed, 27 Jan 1999 00:03:31 +0000 (00:03 +0000)]
compilation errors due to addition of smb file handle parameter.
(This used to be commit 03967986ec6a92785b92fefce9e27b8bb088ea85)

24 years agoPutting back the -p flag in smbclient.
Richard Sharpe [Mon, 25 Jan 1999 01:46:14 +0000 (01:46 +0000)]
Putting back the -p flag in smbclient.

However, it seems that the -s flag
in smbclient is also ignored :-(
(This used to be commit f6c78192664d611d4663ed7459a2789315861eec)

24 years agoMore changes to get SSL working with 2.x.x
Richard Sharpe [Mon, 25 Jan 1999 00:36:45 +0000 (00:36 +0000)]
More changes to get SSL working with 2.x.x

Now, we have most of the configure support done, next
have to fix and other things ...
(This used to be commit 3598d90a325eaf90341832c1aa35ad17f6d34af7)

24 years agoFixing up configure to properly support ssl
Richard Sharpe [Sun, 24 Jan 1999 14:20:19 +0000 (14:20 +0000)]
Fixing up configure to properly support ssl
(This used to be commit 524c4d2978f8b951708ad30316e3d69ed1c39b75)

24 years agoAdding first of the fixes for SSL.
Richard Sharpe [Sun, 24 Jan 1999 14:08:55 +0000 (14:08 +0000)]
Adding first of the fixes for SSL.

A whole bunch of string variables in loadparm.c were
not being initialized properly.  Programs crashed as a result.

This set of code not tested, but same code tested elsewhere,
and all this guarded by #ifdef HAVE_SSL
(This used to be commit fb6048bb8655e8bd87cc69b48c99219d6701a907)

24 years agoIn security=user mode we must allow cli_connect_serverlist to connect to our
Matthew Chapman [Mon, 18 Jan 1999 01:35:43 +0000 (01:35 +0000)]
In security=user mode we must allow cli_connect_serverlist to connect to our
own smbd process, rather than complaining about a password server loop.
(This used to be commit 63d7822b9d87d085194de6895d3e271cedcd3c9a)

24 years agoAdded load_interfaces in smbpasswd to allow name resolution by broadcast and
Matthew Chapman [Mon, 18 Jan 1999 01:32:45 +0000 (01:32 +0000)]
Added load_interfaces in smbpasswd to allow name resolution by broadcast and
multiple interfaces. (Jeremy already committed this in SAMBA_2_0).
(This used to be commit f530e289c6f69961c51511e0220fdd886fbd2c78)

24 years agoA small change to clitar.c (really, I promise :-)
Richard Sharpe [Sun, 17 Jan 1999 01:03:52 +0000 (01:03 +0000)]
A small change to clitar.c (really, I promise :-)

If we are writing the tar file to stdout, set dbf to stderr
so that we do not screw up tar output with log info etc.

Compiles clean and tested with 38MB backup. Honest :-)
(This used to be commit 57301a3eb4723d0790822d3409da788fec4d8378)

24 years agoeclass != ERRDOS && num != ERRmoredata
Matthew Chapman [Fri, 15 Jan 1999 05:09:36 +0000 (05:09 +0000)]
eclass != ERRDOS && num != ERRmoredata
is not the same as
!(eclass == ERRDOS && num == ERRmoredata)

This was causing smbclient to segfault on receiving certain errors.
(This used to be commit 15bd172530af360cf16ad626330dfe2ea92100df)

24 years agoFixed typo in srv_samr.c where samr_add_groupmem and samr_del_groupmem were
Matthew Chapman [Fri, 15 Jan 1999 05:02:41 +0000 (05:02 +0000)]
Fixed typo in srv_samr.c where samr_add_groupmem and samr_del_groupmem were
the wrong way around.
(This used to be commit 2b6f4818858d422399321064245a36be1dba9738)

24 years agoFinally committing my LDAP changes.
Matthew Chapman [Fri, 15 Jan 1999 05:00:26 +0000 (05:00 +0000)]
Finally committing my LDAP changes.

* Added new APIs for modifying groups.
* RIDs are allocated similarly to NT, starting from 1000 and incrementing by 1
  for each new user/group.
* RIDs are now consistently in hex

* Fixed bugs reported by Allan Bjorklund <>:
   - ldap_close_connection is exported by OpenLDAP - changed to ldap_disconnect
   - Missing ldap_connect() in getusergroups functions
   - ldap_next_entry was being called too early while retrieving a sam_struct
   - LDAP globals should be extern in sampassldap.c

* Fixed bugs reported by Martin Hofbauer <>
   - Newly added workstation trust accounts had attributes DU rather than W.
   - User dn's were forced to start with "uid=XX" rather than using the existing
(This used to be commit 91c77f5432169553572bb4d85ad5f09d17524f20)

24 years agoFixed the "You password will expire in 0 days. Would you like to
Gerald Carter [Wed, 13 Jan 1999 00:48:25 +0000 (00:48 +0000)]
Fixed the "You password will expire in 0 days.  Would you like to
change it now?" message when you login to a Samba Controlled domain.

The fix is a hard coded 42 days from right now until you need to
change you pasword again time (see passdb/sampassdb.c:pwdb_smb_to_sam())

Also fixed getsmbfilepwent() so that it will read in the last password
change time correctly.

* Related to this lib/util_pwdb.c:StrnCaseCmp() returns 0 if the
strings match.  Chouldn't this be the pther way?  Oh well.  I
didn't change the return code as it was used in several
other cases (see lib/util_pwdb.c:pwdb_get_last_set_time())
(This used to be commit 175e598dccd042c0f8b045db45fbe3ae928a7387)

24 years agofixed an uninitialized variable in lookupsmbgrpgid() and
Gerald Carter [Wed, 13 Jan 1999 00:40:04 +0000 (00:40 +0000)]
fixed an uninitialized variable in lookupsmbgrpgid() and
lookupsmbpwuid that was causing a SEGFAULT in smbd.
(This used to be commit cabc7e739cb6a6c8dfc4b6988a8ef5837e3312d2)

24 years agoUpdated the docs to match the changes I made to debug2html.
Christopher R. Hertel [Tue, 29 Dec 1998 21:16:08 +0000 (21:16 +0000)]
Updated the docs to match the changes I made to debug2html.
Chris -)-----
(This used to be commit fcbdf5fe9790298d519b678ff3a6121641c1e6d9)

24 years agoWhile writing the man page, I realized that it was a bit silly not to accept
Christopher R. Hertel [Tue, 29 Dec 1998 20:43:01 +0000 (20:43 +0000)]
While writing the man page, I realized that it was a bit silly not to accept
command-line parameters.  I've added that capability.  Of course, the man
page is now wrong.  Sigh.

Chris -)-----
(This used to be commit 300a8c9e5077206b706c522c0b4288b00b7afda7)

24 years agoFirst go at documentation for debug2html.
Christopher R. Hertel [Tue, 29 Dec 1998 18:57:38 +0000 (18:57 +0000)]
First go at documentation for debug2html.

Chris -)-----
(This used to be commit a045186d4d5d8121f46ffc380aeca1904e0686fe)

24 years agoSorry that this is going so slowly.
Christopher R. Hertel [Mon, 28 Dec 1998 22:34:08 +0000 (22:34 +0000)]
Sorry that this is going so slowly.

I've added debug2html to so that it compiles as part of the
normal build.  Fixed a typo in debug2html.c as well.

One problem:  I found it necessary to link with both $(PARAM_OBJ) and
              $(LIB_OBJ).  The result is an executable that is much larger
              than it really needs to be.
(This used to be commit d2d6f0bf362d376f39d0ec7e4b6651ca2b8c8819)

24 years agoModified packaging-prep script to remove use of "rm -f *".
John Terpstra [Sun, 27 Dec 1998 22:31:50 +0000 (22:31 +0000)]
Modified packaging-prep script to remove use of "rm -f *".
(This used to be commit 1d9540bfc00381cd86f47e5673d902352e9f4b55)

24 years agoChanging to PHT standard SPEC settings.
John Terpstra [Mon, 21 Dec 1998 10:12:27 +0000 (10:12 +0000)]
Changing to PHT standard SPEC settings.
(This used to be commit bf2b97f5905419cdfe43b0f0f1f3b7b85881711a)

24 years agofix for potential lsass.exe crashing due to negative response from
Luke Leighton [Sun, 20 Dec 1998 00:37:24 +0000 (00:37 +0000)]
fix for potential lsass.exe crashing due to negative response from
LsaLookupNames being incorrect.  this is a bit wierd: why would the
lsass.exe on the nt _client_ crash due to an LsaLookupNames response
from a samba _server_?
(This used to be commit a15a3f95f2a14ab164ca758e2145444a803190b2)

24 years agoadding start of remote lookup for domain member role.
Luke Leighton [Sun, 20 Dec 1998 00:35:43 +0000 (00:35 +0000)]
adding start of remote lookup for domain member role.
(This used to be commit 090512e18770bab9222a30e68dee83d1612eca10)

24 years agolib_sec_ctxt.o not .c
Luke Leighton [Sun, 20 Dec 1998 00:31:18 +0000 (00:31 +0000)]
lib_sec_ctxt.o not .c
(This used to be commit 2485b8e706a2d0358f075dcb8b03bc75fa122ee1)

24 years agoUpdated makefile-path info contributed on the samba-technical mailing list.
John Terpstra [Sat, 19 Dec 1998 03:29:03 +0000 (03:29 +0000)]
Updated makefile-path info contributed on the samba-technical mailing list.
(This used to be commit bd3770235dd417d06e47d1ba16bcedc8a94e9ff9)

24 years agoFixed problems in debug code because I did not compile
Richard Sharpe [Sat, 19 Dec 1998 02:08:35 +0000 (02:08 +0000)]
Fixed problems in debug code because I did not compile
first :-(
(This used to be commit 47e36bed8fc3cec3a63087f30d680f2431bcfe55)

24 years agoAdded some debugging to clitar ...
Richard Sharpe [Sat, 19 Dec 1998 01:43:24 +0000 (01:43 +0000)]
Added some debugging to clitar ...
(This used to be commit b75af70990c3a9eaed9e3537b79e8e66a0ae8286)

24 years agoFixed tar recurse bug.
Jeremy Allison [Thu, 17 Dec 1998 22:44:56 +0000 (22:44 +0000)]
Fixed tar recurse bug.
(This used to be commit 7be5c8e8f734a2bd8f4e3c38b7f94c501ad35a19)

24 years agoFix bug with nmbd running wild due to recursion in retransmit_or_expire_response_reco...
Jeremy Allison [Thu, 17 Dec 1998 21:41:28 +0000 (21:41 +0000)]
Fix bug with nmbd running wild due to recursion in retransmit_or_expire_response_records().
(This used to be commit d5f05b4faef50e7cfc0ed05a87d92e14102106c6)

24 years agoand in head branch:
Andrew Tridgell [Thu, 17 Dec 1998 01:04:38 +0000 (01:04 +0000)]
and in head branch:

make sure we include sys/mman.h if available
(This used to be commit ccf644388732287da01a943ea826187b5394ebc6)

24 years agoA while back, Andrew and I talked about making the debug parsing code a
Christopher R. Hertel [Wed, 16 Dec 1998 18:50:54 +0000 (18:50 +0000)]
A while back, Andrew and I talked about making the debug parsing code a
better "fit" with other Samba code.  This is a small first step toward
doing what (I think) we agreed to do.

I've moved the key function from ubiqx/debugparse.c into lib/debug.c.  I
have also moved the enum from ubiqx/debugparse.h into the debug section in

The next thing to do is to get debug2html added into the so
that it is always produced when compiling the suite.

Chris -)-----
(This used to be commit 782474f41e0c2bc0b1f098758a3e5cb44e87d8b1)

24 years agoon Linux force fcntl/mmap based shared memory and on other systems
Andrew Tridgell [Tue, 15 Dec 1998 03:16:24 +0000 (03:16 +0000)]
on Linux force fcntl/mmap based shared memory and on other systems
force IPC/shmem based shared memory.
(This used to be commit ef5f752a4ae818d9c739a064410a02fa48a477e3)

24 years agoserver_cryptkey() now calling cli_connectserverlist(). stupid microsoft
Luke Leighton [Mon, 14 Dec 1998 21:22:59 +0000 (21:22 +0000)]
server_cryptkey() now calling cli_connectserverlist().  stupid microsoft
idiotic *SMBSERVER connectionism added to cli_connect_serverlist().
also added check for protocol < LANMAN2.
(This used to be commit c2bcb3a286f22ed4f0f55da2a3eb2bff17906fb1)

24 years agoadded sid_name_use array argument to lsa_lookup_names and lsa_lookup_sids.
Luke Leighton [Mon, 14 Dec 1998 20:23:20 +0000 (20:23 +0000)]
added sid_name_use array argument to lsa_lookup_names and lsa_lookup_sids.
(This used to be commit 0b2095e092d747f741e78a3349f0b81a72811629)

24 years agotrying to track down issues in get_home_dir().
Luke Leighton [Mon, 14 Dec 1998 20:21:39 +0000 (20:21 +0000)]
trying to track down issues in get_home_dir().
(This used to be commit 2cce78aa00f31b79d51aaf46da72019b926e8226)

24 years ago%U substitution should be unix user not nt user
Luke Leighton [Fri, 11 Dec 1998 19:27:19 +0000 (19:27 +0000)]
%U substitution should be unix user not nt user
(This used to be commit f4b8a283065a7c1ae233a0ae01ac76f32fea6b31)

24 years agoadding svcctl parsing code
Luke Leighton [Wed, 9 Dec 1998 23:16:37 +0000 (23:16 +0000)]
adding svcctl parsing code
(This used to be commit c6f2f58c74cd79d84ec4a7802882da07a9af80d4)

24 years agobugfix in smb_err_msg
Luke Leighton [Wed, 9 Dec 1998 18:59:12 +0000 (18:59 +0000)]
bugfix in smb_err_msg
(This used to be commit 870bccb174337dec5cc14a5e7740662de56e629c)

24 years agooops, util_pwdb.c appears to be included in PASSDB_OBJ not LIB_OBJ.
Luke Leighton [Wed, 9 Dec 1998 16:30:37 +0000 (16:30 +0000)]
oops, util_pwdb.c appears to be included in PASSDB_OBJ not LIB_OBJ.
(This used to be commit ca10eb44909e66a07dc7f88b0a740390f9ec3922)

24 years agoadding some enumerate services code, client and server.
Luke Leighton [Wed, 9 Dec 1998 16:28:04 +0000 (16:28 +0000)]
adding some enumerate services code, client and server.
(This used to be commit dacf5b152bf74cc3ee9a816911384a5eb0e77afa)

24 years agoneed to initialise global_myworkgroup
Luke Leighton [Wed, 9 Dec 1998 16:23:57 +0000 (16:23 +0000)]
need to initialise global_myworkgroup
(This used to be commit 501617307f3b9bbad76406d00b1bc82f5cb479a6)

24 years agoremoved the SID stuff from the head branch as well.
Andrew Tridgell [Wed, 9 Dec 1998 06:35:37 +0000 (06:35 +0000)]
removed the SID stuff from the head branch as well.

This allows the removal of PASSDB_OBJ, RPC_CLIENT_OBJ and
RPC_PARSE_OBJ from nmbd in the head branch.

so nmbd just went on a diet :)
(This used to be commit be697c9ef00f1b6366228dcdd3983d68158dd94f)

24 years agoadding "Service Control Manager" commands to rpcclient.
Luke Leighton [Tue, 8 Dec 1998 23:29:37 +0000 (23:29 +0000)]
adding "Service Control Manager" commands to rpcclient.
(This used to be commit e5ee965f8d8452ab694bc5d88e474c4b91dce5b0)

24 years agoAdding George's Mac extension code.
Jeremy Allison [Tue, 8 Dec 1998 02:25:41 +0000 (02:25 +0000)]
Adding George's Mac extension code.
(This used to be commit b993081db1d371b8f0d16db23a46a2d5fedcc9ef)

24 years agoAdding George's Mac extension include files.
Jeremy Allison [Tue, 8 Dec 1998 02:22:56 +0000 (02:22 +0000)]
Adding George's Mac extension include files.
(This used to be commit 60c3e2f14d5c31fd1fd7aebf7196ac186e31d8f1)

24 years agoldap_getpw() also needs to be (void)
Luke Leighton [Tue, 8 Dec 1998 00:33:05 +0000 (00:33 +0000)]
ldap_getpw() also needs to be (void)
(This used to be commit f36cf3b6a70d0a91bce923ab51780d20d69e3bd6)

24 years agocompilation warnings due to missing (void) in ldap_close_connection.
Luke Leighton [Tue, 8 Dec 1998 00:30:23 +0000 (00:30 +0000)]
compilation warnings due to missing (void) in ldap_close_connection.
(This used to be commit f11eb4165836ce8d15a453d37c4e07913562d778)

24 years agoadding srvsvc pipe.
Luke Leighton [Tue, 8 Dec 1998 00:25:04 +0000 (00:25 +0000)]
adding srvsvc pipe.
(This used to be commit d06d6369942828ec89e90f99bd0d0d3f91d61d13)

24 years agoadded ldap files by Matthew Chapman.
Luke Leighton [Mon, 7 Dec 1998 22:52:49 +0000 (22:52 +0000)]
added ldap files by Matthew Chapman.
(This used to be commit 2bc031e8fafeafdc58c6a8056597b647d00657ae)

24 years agoMatthew Chapman spotted that smbpasschange was assuming the existence
Luke Leighton [Mon, 7 Dec 1998 22:52:13 +0000 (22:52 +0000)]
Matthew Chapman spotted that smbpasschange was assuming the existence
of a private/smbpasswd file, this will not be the case for other
database APIs.  removed startsmbdb and endsmbpwdb calls because
add_smbpwd_entry() and mod_smbpwd_entry() don't need them.
(This used to be commit 8b36c7c08ffa408506c35219e6453a595cbc3a4f)

24 years agofixed warnings (and potential errors) due to integer overflow when
Andrew Tridgell [Mon, 7 Dec 1998 22:43:43 +0000 (22:43 +0000)]
fixed warnings (and potential errors) due to integer overflow when
creating locking masks
(This used to be commit 5e2844d5edb15de29b976d2ff077ffbe012b860c)

24 years agoadded text and html versions of LDAP.yo. smb.conf.5 not generated yet
Luke Leighton [Mon, 7 Dec 1998 21:48:58 +0000 (21:48 +0000)]
added text and html versions of LDAP.yo.  smb.conf.5 not generated yet
because there were parts rejected from the ldap patch file.
(This used to be commit 4f85105578fdf74d883f185f983e608112fe823b)

24 years agoupdated for Matt Chapman's ldap code
Luke Leighton [Mon, 7 Dec 1998 21:44:37 +0000 (21:44 +0000)]
updated for Matt Chapman's ldap code
(This used to be commit d11859041d4ec828b2262282cda98a021129d008)

24 years agoissues spotted by herb.
Luke Leighton [Mon, 7 Dec 1998 21:40:53 +0000 (21:40 +0000)]
issues spotted by herb.
(This used to be commit 57e025494692b1e54d4d83192e6c15d4d1454353)

24 years agomatthew chapman's ldap code, to date. plus docs!
Luke Leighton [Mon, 7 Dec 1998 21:37:17 +0000 (21:37 +0000)]
matthew chapman's ldap code, to date.  plus docs!
(This used to be commit 2c438c86cbb38833b3abd4fbead6324687633b25)

24 years agobugs in rpcclient. add_aliasmem uses a DOM_SID2 not a DOM_SID.
Luke Leighton [Mon, 7 Dec 1998 21:32:02 +0000 (21:32 +0000)]
bugs in rpcclient.  add_aliasmem uses a DOM_SID2 not a DOM_SID.
(This used to be commit 8a85d7abed317fd06e3e0026d4b9e088311eede4)

24 years agofirst attempt at making unix setuid/setgid code that is independent of
Luke Leighton [Mon, 7 Dec 1998 20:28:51 +0000 (20:28 +0000)]
first attempt at making unix setuid/setgid code that is independent of
cnums and snums.
(This used to be commit 657f46edfbea852309505f5e3065506127eda6a2)

24 years agosync with 2.0 tree
Herb Lewis [Mon, 7 Dec 1998 20:27:01 +0000 (20:27 +0000)]
sync with 2.0 tree
(This used to be commit 44d962b73634c3e43973b35c1f02aaff6edc5981)

24 years agoremoved nt_pipe_fnum from struct cli_state. need to be able to call
Luke Leighton [Mon, 7 Dec 1998 20:23:41 +0000 (20:23 +0000)]
removed nt_pipe_fnum from struct cli_state.  need to be able to call
LsaLookupSids etc from within SamrQueryAliasMembers, for example.
fnum is now a parameter to client functions.  thanks to mike black
for starting the ball rolling.
(This used to be commit bee8f7fa6b0f7f995f71303f4e14a4aaed0c2437)

24 years ago- lib/unix_sec_ctxt.c
Luke Leighton [Mon, 7 Dec 1998 17:23:48 +0000 (17:23 +0000)]
- lib/unix_sec_ctxt.c

attempt at taking lib/uid.c and getting a unix security context
change module that is independent of "cnums" and "snums".
a security context is needed for pipes, not just IPC$ or other

- group database API

added add_group/alias_member, del_group/alias_member,
del_group/alias_entry functions.  del_builtin_entry() is
deliberately set to NULL to cause an exception, you cannot
delete builtin aliases.

- parse_lsa.c srv_lsa.c

fixed lookup_names code, it was a load of trash and didn't do

- cmd_samr.c rpcclient.c srv_samr.c

added "deletegroup", "deletealias", "delaliasmem", "delgroupmem",
"addgroupmem", "addaliasmem", "createalias", "creategroup", to
both client and server code.

server code calls into unix stubs right now, which don't actually
do anything.  the only instance where they are expected to do
anything is in appliance mode NOT even in the ldap code or anything.

client code modified to call samr_lookup_names() for group code
(because we can) and lsa_lookup_names() for alias code (because
we have to).

- srv_lookup.c

oops, lookup on unsplit name, we got lookup on DOMAIN, DOMAIN\name
instead of DOMAIN, name.
(This used to be commit b8175702ef61b8b37b078f38e81452c00a5e2986)

24 years agofixed a link to testparm.1.html
Andrew Tridgell [Mon, 7 Dec 1998 10:37:13 +0000 (10:37 +0000)]
fixed a link to testparm.1.html
(This used to be commit 7e9b687de7fbb34a2736030dab31a9df73a75073)

24 years agooops - lock test was the wrong way around
Andrew Tridgell [Sat, 5 Dec 1998 08:19:42 +0000 (08:19 +0000)]
oops - lock test was the wrong way around
(This used to be commit 783d4b3477fa9e363aa1f7524bd060019648ab0d)

24 years agofixed pidfile handling to check for a lock on the file, so we can be
Andrew Tridgell [Sat, 5 Dec 1998 08:09:59 +0000 (08:09 +0000)]
fixed pidfile handling to check for a lock on the file, so we can be
sure it is a samba process that is running.
(This used to be commit f7ad78e369ebf2f4d31e8259e3e1fdd4c087b037)

24 years agoreplaced the icons in SWAT with real icons
Andrew Tridgell [Sat, 5 Dec 1998 06:54:10 +0000 (06:54 +0000)]
replaced the icons in SWAT with real icons
(This used to be commit 26fd660e30d632624c3c804d9e73178d75c7855d)

24 years agoSync up critical kernel oplock bugfix. I don't want to lose
Jeremy Allison [Sat, 5 Dec 1998 01:03:42 +0000 (01:03 +0000)]
Sync up critical kernel oplock bugfix. I don't want to lose
(This used to be commit 5287f3d19b7d8e76970f1ce1abfd95b7341434e5)

24 years agoadded delete domain group and local group and delete domain group member.
Luke Leighton [Fri, 4 Dec 1998 23:06:27 +0000 (23:06 +0000)]
added delete domain group and local group and delete domain group member.
(This used to be commit bf15343def5b95ce4387ac4357674aff31431194)

24 years agofixing "addgroupmem" and "enumgroups -m" commands, samr_open_group()
Luke Leighton [Fri, 4 Dec 1998 22:00:39 +0000 (22:00 +0000)]
fixing "addgroupmem" and "enumgroups -m" commands, samr_open_group()
needed a flags fields as you get 0x0000 0010 and 0x0000 001f unknown
values for different purposes, no-one's going to tell us what they
are and i don't CARE!
(This used to be commit aabb4b3bc5119ef317b5697ae6fcf5d36c2d474e)

24 years ago- oops, i got "add alias member" and "delete alias member" swapped.
Luke Leighton [Fri, 4 Dec 1998 21:48:06 +0000 (21:48 +0000)]
- oops, i got "add alias member" and "delete alias member" swapped.

- samr_enum_dom_users, the first 4 bytes is some sort of garbage,
  nt5-beta2 clears them out to zeros whereas nt4 does not.
  fixed bug where we were assuming that the first 4 bytes of a
  response _had_ to be non-zero.

- cli_lsarpc.c: forgot to append the rid on the lsa_lookup_names()
  client call.

- added in "addaliasmem" and "addgroupmem" commands.  the addaliasmem
  command actually turned out to be a "delaliasmem" :-) :-)

- parse_lsa.c: moved assert array check to after the size of useable
  array space is set...
(This used to be commit 165b15a8cacc4bc7cf8cc0b9aaabb6b92cef7fdb)

24 years ago- renamed do_samr_xxx to samr_xxx
Luke Leighton [Fri, 4 Dec 1998 16:30:00 +0000 (16:30 +0000)]
- renamed do_samr_xxx to samr_xxx
- renamed do_lsa_xxx to lsa_xxx

- added "enumgroups [-m]" command, enumerates groups, shows members.
- added cmd_sam_add_groupmem(), need to call these in rpcclient.c
- added cmd_sam_add_aliasmem(), need to call these in rpcclient.c

- modified "enumaliases [-m]" command

- improved "enumgroups" and "enumaliases" to display names not just RIDS/SIDs.

- renamed "samr_unknown_12" to "samr_lookup_rids".

- added the following client-side functions:


- improved display output (display.c)
(This used to be commit eacc5e581af2b4de24186b9be3238b352c54effe)

24 years agoUpdated packaging files from 2.0.0 branch - NOTE: Not yet operative.
John Terpstra [Fri, 4 Dec 1998 00:13:12 +0000 (00:13 +0000)]
Updated packaging files from 2.0.0 branch - NOTE: Not yet operative.
I will update these when 2.0.0beta3 has shipped. <John H Terpstra>
(This used to be commit a6d3601cc687b59afb346502488a2e74f2f737a9)

24 years agoUpdated version info and date in document headers.
John Terpstra [Thu, 3 Dec 1998 23:14:52 +0000 (23:14 +0000)]
Updated version info and date in document headers.
(This used to be commit f8b811bcda0976c05e0490fb3198a6079e544c55)

24 years agoadded createalias command to rpcclient
Luke Leighton [Thu, 3 Dec 1998 22:20:30 +0000 (22:20 +0000)]
added createalias command to rpcclient
(This used to be commit 4771d5451b49375cc2fd4246d7d746b0d03cd5ba)

24 years agocreate domain group command (creategroup) added to rpcclient.
Luke Leighton [Thu, 3 Dec 1998 20:50:33 +0000 (20:50 +0000)]
create domain group command (creategroup) added to rpcclient.

renamed do_samr_xxxx to samr_xxxx.
(This used to be commit 1e5d81c154740349a2cda4c1892b33a21c0683a8)

24 years agomoved get_unixgroups it will be needed by the unix instance of the group
Luke Leighton [Thu, 3 Dec 1998 17:41:14 +0000 (17:41 +0000)]
moved get_unixgroups it will be needed by the unix instance of the group
(This used to be commit ef58e48bc9af338ed6c734205d4faf82371284ac)

24 years agojean-f spotted race condition on generation of sam sid, from starting
Luke Leighton [Thu, 3 Dec 1998 17:38:20 +0000 (17:38 +0000)]
jean-f spotted race condition on generation of sam sid, from starting
nmbd and smbd.  nmbd is now client: smbd is solely responsible for
creating sam_name.SID
(This used to be commit 50fa4822df679b4d54b5a868179594ec087e811f)

24 years agojean-f spotted bug in test for existence of MACHINE.SID and SAM_NAME.SID.
Luke Leighton [Thu, 3 Dec 1998 17:34:05 +0000 (17:34 +0000)]
jean-f spotted bug in test for existence of MACHINE.SID and SAM_NAME.SID.
(This used to be commit 81be1e60764d380adf47737552659854d94ca626)

24 years agoadding group parsing: add/modify/delete/add members.
Luke Leighton [Thu, 3 Dec 1998 17:29:03 +0000 (17:29 +0000)]
adding group parsing: add/modify/delete/add members.
(This used to be commit 13a656b0e5c73e157b222765fb57a1bdafc67b80)

24 years agojeremy's going to do me in, again.
Luke Leighton [Wed, 2 Dec 1998 22:48:00 +0000 (22:48 +0000)]
jeremy's going to do me in, again.
jean-francois' going to get annoyed, again.
andrew's going to threaten to take cvs access away, again.

missed compilation of this file when updating sam_unknown_12 call.
(This used to be commit 74f826af36a7af4e91f9325d11ef8432d343c3bd)

24 years agoupdating smb.conf from yodl
Luke Leighton [Wed, 2 Dec 1998 22:37:29 +0000 (22:37 +0000)]
updating smb.conf from yodl
(This used to be commit da442218c5990aab75525bc519b5ed37ef54cc4a)

24 years agospotted the mistake in group_info1 parsing.
Luke Leighton [Wed, 2 Dec 1998 22:13:48 +0000 (22:13 +0000)]
spotted the mistake in group_info1 parsing.
(This used to be commit e39c0c76ae52bbd4539f8f254e78566a5511efc1)

24 years agoadded rid and sid_name_use to DOMAIN_GRP_MEMBER, for use in group member
Luke Leighton [Wed, 2 Dec 1998 22:05:56 +0000 (22:05 +0000)]
added rid and sid_name_use to DOMAIN_GRP_MEMBER, for use in group member

domain groups now work, hurrah!  only thing is that the description is
one character long, don't know why (which is wierd in itself).
(This used to be commit 78a86c64960a7823b0db8b7bebfffabb4a5ba864)

24 years agoERRmoredata is an acceptable error code, it is not an error.
Luke Leighton [Wed, 2 Dec 1998 20:03:08 +0000 (20:03 +0000)]
ERRmoredata is an acceptable error code, it is not an error.
(This used to be commit 9bce7340d60a49594f67cc3c6cc6119b33a5358a)

24 years agoremoved check on name of domain having to be right, etc etc.
Luke Leighton [Wed, 2 Dec 1998 16:27:38 +0000 (16:27 +0000)]
removed check on name of domain having to be right, etc etc.
(This used to be commit a74b6dcc76794c1fe350d6906f156fdf5189e18b)

24 years agotrailing backslashes spotted by andrej.
Luke Leighton [Wed, 2 Dec 1998 16:21:25 +0000 (16:21 +0000)]
trailing backslashes spotted by andrej.
(This used to be commit 9266137fcb87b6e4b2cc45a55341ebaa69c594b7)

24 years agoissues spotted by andrej: %s\\%s not %s\%s
Luke Leighton [Wed, 2 Dec 1998 16:20:36 +0000 (16:20 +0000)]
issues spotted by andrej: %s\\%s not %s\%s
(This used to be commit 779a7aa30d4b8a3c8ca1d817a3fd9886c0437def)

24 years agostring_to_sid was using next_token() this is bad as it stops you from
Luke Leighton [Wed, 2 Dec 1998 16:01:40 +0000 (16:01 +0000)]
string_to_sid was using next_token() this is bad as it stops you from
being able to use next_token() outside of string_to_sid calls.
use strchr instead
(This used to be commit 1c478ca1723558cc5dde693b4abacb56bd98cd43)

24 years agoUpdated HEAD branch version to 2.1.0-prealpha in response to a user
John Terpstra [Wed, 2 Dec 1998 13:20:18 +0000 (13:20 +0000)]
Updated HEAD branch version to 2.1.0-prealpha in response to a user
complaint about confusion because both the HEAD and SAMBA_2_0 reported
the same version info.
(This used to be commit 195b860b46b78a6a2dd83909477dbc2e9af8f845)

24 years agoadding group member code, made a start. found that the group members'
Luke Leighton [Wed, 2 Dec 1998 01:13:02 +0000 (01:13 +0000)]
adding group member code, made a start.  found that the group members'
rid is needed not the name (see DOMAIN_GRP_MEMBER) decided to go home.
(This used to be commit 9337049dfc98becfa74522d418dae64a97c7a304)

24 years agook. unix-nt mapping code issues
Luke Leighton [Tue, 1 Dec 1998 23:51:17 +0000 (23:51 +0000)]
ok.  unix-nt mapping code issues

need to check, when looking up group members, that a group member is
a unix user [being mapped to an nt user] FIRST then if that fails
check that a group member is a unix group [being mapped to an nt group].

why?  because you can have group names in a unix /etc/group file with
the same name as users.

this _might_ be a problem...
(This used to be commit 585d47644d3d709ccdfd5135c5f77166b609eb3b)

24 years agocheck server role before doing nt user to unix user mapping
Luke Leighton [Tue, 1 Dec 1998 22:39:33 +0000 (22:39 +0000)]
check server role before doing nt user to unix user mapping
(This used to be commit 9d4e810e7dd8d6d80b47204636f9a37774f95455)

24 years agoquery_aliasmem code. it works (hurrah).
Luke Leighton [Tue, 1 Dec 1998 22:18:48 +0000 (22:18 +0000)]
query_aliasmem code.  it works (hurrah).
(This used to be commit f7f2516df46dde1671235f788f7689c93d9395ae)

24 years agofixing smbpasswd to link to smbd to obtain domain sid
Luke Leighton [Tue, 1 Dec 1998 19:34:58 +0000 (19:34 +0000)]
fixing smbpasswd to link to smbd to obtain domain sid
(This used to be commit bfb75e58ced1082d3bb7d6b3f3367d50a0ca26ea)

24 years agorpc_samr.h parse_samr.c srv_samr.c :
Luke Leighton [Tue, 1 Dec 1998 19:10:44 +0000 (19:10 +0000)]
rpc_samr.h parse_samr.c srv_samr.c :

samr_query_aliasmembers (cool!)

util_pwdb.c sids.c nmbd.c server.c smbpasswd.c swat.c :

pwdb_initialise(BOOL is_server) now creates / reads DOMAIN_NAME.SID
if is_server is True, and does LsaQueryInfoPolicy(levels 3 and 5)
to obtain member and pdc sids.
(This used to be commit 3e1eb4f26b67e484b05e1dde94fd4e4dae982631)

24 years agoandrej spotted that entries _not_ in domain map user were being refused.
Luke Leighton [Tue, 1 Dec 1998 18:24:23 +0000 (18:24 +0000)]
andrej spotted that entries _not_ in domain map user were being refused.
modified map_nt_and_unix_names() to never refuse a mapping (returns void
now not BOOL).
(This used to be commit faffcb3c8955dcea3987e2978dc34b4dba580167)

24 years agohm. removed the "if failed to map nt name to unix name, fail tcon call"
Luke Leighton [Tue, 1 Dec 1998 16:41:34 +0000 (16:41 +0000)]
hm.  removed the "if failed to map nt name to unix name, fail tcon call"
restriction and "domain user map" seems to work.

(This used to be commit 2c0d91e64a6b330b209ca62c3306ec1a53fda873)

24 years agofix to domain_namemap (domain, ntname wrong way round oops)
Luke Leighton [Tue, 1 Dec 1998 16:22:09 +0000 (16:22 +0000)]
fix to domain_namemap (domain, ntname wrong way round oops)

stupid compile errors with file_rename() call just created.
(This used to be commit f5cedb8c9618b83b63b5e2db867d238eebc7e13c)

24 years agoadding some samr parsing calls (group / alias adding / deleting)
Luke Leighton [Tue, 1 Dec 1998 16:04:24 +0000 (16:04 +0000)]
adding some samr parsing calls (group / alias adding / deleting)

added code that moves MACHINE.SID to DOMAIN_NAME.SID if it exists.
(This used to be commit 51c1c31768a92d9c57ee6c09b78419bcbc544f03)

24 years agoattempting to fix "domain user map" up, but it's a bit complicated.
Luke Leighton [Mon, 30 Nov 1998 22:42:13 +0000 (22:42 +0000)]
attempting to fix "domain user map" up, but it's a bit complicated.
i may simply go for a response in the NetSamLogon returning the
unix username, forcing the NT user to appear to be a unix user,
however even that is fraught with implications.

might just have to go the whole hog and do this tuple thing,
"unix_name + nt_name" always associated together...

issue with api_net_sam_logon, getsam21pwent() being called twice,
the second time overwriting static buffer data (argh) so had to
make a copy.

noticed a nested "become_root()"/"unbecome_root()" which will have
to be tracked down...
(This used to be commit 474f94f419a531e33b475249da7efb99ac22f454)

24 years agopassdb.c now calls getpwnam() which returns results in a static buffer.
Luke Leighton [Mon, 30 Nov 1998 20:42:49 +0000 (20:42 +0000)]
passdb.c now calls getpwnam() which returns results in a static buffer.
a call _outside_ of this was _also_ calling getpwnam.   the calls to
getsmbpwnam() were therefore overwriting the static buffer.
(This used to be commit c5ba5fa6feab2884a23b8bcb5dcb349ee1a7c139)

24 years agopwdb_initialise() in the wrong place: must load smb.conf first. thanks phil.
Luke Leighton [Mon, 30 Nov 1998 19:29:32 +0000 (19:29 +0000)]
pwdb_initialise() in the wrong place: must load smb.conf first.  thanks phil.
(This used to be commit 4b5bd4e18cee72aeb76909cf85b1f932393fcfc8)