samba.git
10 years agos4-waf: sanitize library names like the old build system did, only add
Jelmer Vernooij [Mon, 31 May 2010 00:43:17 +0000 (02:43 +0200)]
s4-waf: sanitize library names like the old build system did, only add
-samba4 suffix for libraries that are bundled.

10 years agos3: use PICFLAG instead of PIE_FLAGS
Björn Jacke [Mon, 31 May 2010 00:17:04 +0000 (02:17 +0200)]
s3: use PICFLAG instead of PIE_FLAGS

10 years agowafsamba: Actually install manual pages.
Jelmer Vernooij [Sun, 30 May 2010 23:35:43 +0000 (01:35 +0200)]
wafsamba: Actually install manual pages.

10 years agoldb: Remove manual pages for binaries that have already been moved to utils/.
Jelmer Vernooij [Sun, 30 May 2010 23:35:07 +0000 (01:35 +0200)]
ldb: Remove manual pages for binaries that have already been moved to utils/.

10 years agoldb-waf: Fix installation path of manpages, simplify manpage handling.
Jelmer Vernooij [Sun, 30 May 2010 23:28:15 +0000 (01:28 +0200)]
ldb-waf: Fix installation path of manpages, simplify manpage handling.

10 years agos4-waf: Look for xsltproc executable, required to build manpages.
Jelmer Vernooij [Sun, 30 May 2010 23:25:56 +0000 (01:25 +0200)]
s4-waf: Look for xsltproc executable, required to build manpages.

10 years agos3: final test for working shlib support requires PIE_LDFLAGS
Björn Jacke [Sun, 30 May 2010 22:26:01 +0000 (00:26 +0200)]
s3: final test for working shlib support requires PIE_LDFLAGS

10 years agos4-python: Remove cruft to deal with static python modules, which are no
Jelmer Vernooij [Sun, 30 May 2010 22:13:10 +0000 (00:13 +0200)]
s4-python: Remove cruft to deal with static python modules, which are no
longer supported.

10 years agos3: use autoconf macro to get some debug output in config.log
Björn Jacke [Sun, 30 May 2010 21:50:48 +0000 (23:50 +0200)]
s3: use autoconf macro to get some debug output in config.log

10 years agos3-waf: Fix the build after rebase
Kai Blin [Sun, 30 May 2010 21:27:08 +0000 (23:27 +0200)]
s3-waf: Fix the build after rebase

10 years agos3-waf: support avahi builds
Kai Blin [Fri, 28 May 2010 13:56:32 +0000 (15:56 +0200)]
s3-waf: support avahi builds

10 years agobuild: Also replace '-' by '_' when creating header defines
Kai Blin [Fri, 28 May 2010 13:50:26 +0000 (15:50 +0200)]
build: Also replace '-' by '_' when creating header defines

Tridge, please check

10 years agos3-waf: Add more darwin-specific options
Kai Blin [Wed, 26 May 2010 11:44:43 +0000 (13:44 +0200)]
s3-waf: Add more darwin-specific options

10 years agos4:tests/python/passwords.py - fix filter
Matthias Dieter Wallnöfer [Sun, 30 May 2010 20:46:50 +0000 (22:46 +0200)]
s4:tests/python/passwords.py - fix filter

10 years agoldb:ldb_tdb/ldb_tdb.c - quiet a warning regarding TDB -> LDB error code conversions
Matthias Dieter Wallnöfer [Sun, 30 May 2010 19:58:11 +0000 (21:58 +0200)]
ldb:ldb_tdb/ldb_tdb.c - quiet a warning regarding TDB -> LDB error code conversions

10 years agos4:samldb LDB module - deny delete operations on some important attributes
Matthias Dieter Wallnöfer [Tue, 11 May 2010 19:43:36 +0000 (21:43 +0200)]
s4:samldb LDB module - deny delete operations on some important attributes

Add operations are denied since these are single-valued - only replace is
allowed.

This is only provisorily at the moment - we need to implement the triggers
specified in MS-ADTS.

10 years agos4:ldap.py - add a test which shows the modification behaviour of important attributes
Matthias Dieter Wallnöfer [Tue, 11 May 2010 19:35:46 +0000 (21:35 +0200)]
s4:ldap.py - add a test which shows the modification behaviour of important attributes

This shows how important attributes of SAM objects do behave when you launch
add and delete modify requests on them.

10 years agos4:samldb LDB module - rework the group change code to be again synchronous
Matthias Dieter Wallnöfer [Sun, 30 May 2010 19:08:05 +0000 (21:08 +0200)]
s4:samldb LDB module - rework the group change code to be again synchronous

10 years agos4:ldap.py - add more test cases to show invalid primary group change behaviour
Matthias Dieter Wallnöfer [Tue, 11 May 2010 15:00:54 +0000 (17:00 +0200)]
s4:ldap.py - add more test cases to show invalid primary group change behaviour

10 years agos3-waf: Set HAVE_GSSAPI if gssapi libs were found
Kai Blin [Thu, 27 May 2010 21:38:02 +0000 (23:38 +0200)]
s3-waf: Set HAVE_GSSAPI if gssapi libs were found

10 years agolibreplace: include sys/file.h only when available
Björn Jacke [Sun, 30 May 2010 19:44:14 +0000 (21:44 +0200)]
libreplace: include sys/file.h only when available

thanks to Joachim Schmitz <schmitz@hp.com>. This fixes #7460.

10 years agos3: define timespec before we use it
Joachim Schmitz [Sun, 30 May 2010 19:25:30 +0000 (21:25 +0200)]
s3: define timespec before we use it

this fixes #7464

Signed-off-by: Björn Jacke <bj@sernet.de>
10 years agos4:dsdb/samdb/ldb_modules/util.c - make sure to always free temporary data
Matthias Dieter Wallnöfer [Sun, 30 May 2010 18:46:57 +0000 (20:46 +0200)]
s4:dsdb/samdb/ldb_modules/util.c - make sure to always free temporary data

10 years agos4:dsdb_module_search_dn - add code to handle NULL format string
Matthias Dieter Wallnöfer [Sun, 30 May 2010 18:46:31 +0000 (20:46 +0200)]
s4:dsdb_module_search_dn - add code to handle NULL format string

10 years agos4:dsdb/common/util.c - fix a counter variable
Matthias Dieter Wallnöfer [Sun, 30 May 2010 18:45:56 +0000 (20:45 +0200)]
s4:dsdb/common/util.c - fix a counter variable

10 years agoselftest: list.remove raises ValueError rather than KeyError.
Jelmer Vernooij [Sun, 30 May 2010 15:05:07 +0000 (17:05 +0200)]
selftest: list.remove raises ValueError rather than KeyError.

10 years agos3: set pthread cflags in a more portable fashion
Björn Jacke [Sat, 29 May 2010 00:06:56 +0000 (02:06 +0200)]
s3: set pthread cflags in a more portable fashion

this avoids one place of a GNU make dependency.

Portable make sucks a bit as it has no way of defining variables for a limited
set of targets only. Manual duplication of target rules is the only way to
achieve what we need.

If someone actually knows a trick how to do this without target duplication,
let me know.

10 years agoRevert "s3: Attempt to fix the non-gnumake build"
Björn Jacke [Sat, 29 May 2010 00:02:20 +0000 (02:02 +0200)]
Revert "s3: Attempt to fix the non-gnumake build"

This reverts commit 086c6c0e9a56f7e6dca6c1398e210b8c6225e4ed, it broke some
builds. The following commit should also remove the gmake dependency.

10 years agos3: fix check for pie compiler flags
Björn Jacke [Fri, 28 May 2010 23:40:21 +0000 (01:40 +0200)]
s3: fix check for pie compiler flags

some compilers (HP and Sun e.g.) output warning messages on stderr for unknown
options and we ended up partly using some unwanted random compile flags we
did't intend to use.

10 years agos3: add m4 macro to check if stderr is empty or not
Björn Jacke [Fri, 28 May 2010 23:39:16 +0000 (01:39 +0200)]
s3: add m4 macro to check if stderr is empty or not

10 years agoRevert "s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows...
Matthias Dieter Wallnöfer [Sun, 30 May 2010 12:53:36 +0000 (14:53 +0200)]
Revert "s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000"

This reverts commit 1cf5be39e30f9478606a5525eb7beeb21ee83c24.

My fix approach isn't such appreciated therefore revert this.

10 years agos4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000
Matthias Dieter Wallnöfer [Sun, 30 May 2010 10:02:24 +0000 (12:02 +0200)]
s4:rpc_server/dcesrv_auth.c - Fix a RPC issue in conjunction with Windows 2000

Windows 2000 does strictly request header signing on some requests also if the
server doesn't provide it. But there is a small trick (don't reset the actual
session info) to make these special RPC operations work without a full header
signing implementation.

This fixes for example the list of domain groups in local groups when displayed
sing the local user/group management tool.

And this should finally fix bug #7113.

The patch was inspired by another one by tridge and abartlet: http://gitweb.samba.org/samba.git/?p=tridge/samba.git;a=commitdiff;h=2dc19e2878371264606575d3fc09176776be7729

10 years agos4:web_server/wsgi.c - free the "env" and "inputstream" objects on an "asprintf"...
Matthias Dieter Wallnöfer [Sun, 30 May 2010 09:01:25 +0000 (11:01 +0200)]
s4:web_server/wsgi.c - free the "env" and "inputstream" objects on an "asprintf" failure

10 years agos4:auth/credentials/credentials.c - initialise "password_last_changed_time"
Matthias Dieter Wallnöfer [Fri, 28 May 2010 20:30:50 +0000 (22:30 +0200)]
s4:auth/credentials/credentials.c - initialise "password_last_changed_time"

Otherwise it could remain uninitialised.

10 years agonss_wrapper/testsuite.c - make sure to test always the "NSS wrapper" calls
Matthias Dieter Wallnöfer [Sat, 29 May 2010 20:54:07 +0000 (22:54 +0200)]
nss_wrapper/testsuite.c - make sure to test always the "NSS wrapper" calls

This should fix bug #7319 and #7320.

10 years agos3:auth make it easier to trace auth modules
Simo Sorce [Sat, 29 May 2010 20:49:37 +0000 (16:49 -0400)]
s3:auth make it easier to trace auth modules

10 years agos3:auth fix info3 duplication function
Simo Sorce [Fri, 28 May 2010 17:35:56 +0000 (13:35 -0400)]
s3:auth fix info3 duplication function

10 years agos3:smbd Use the right num_sids
Simo Sorce [Fri, 28 May 2010 12:33:18 +0000 (08:33 -0400)]
s3:smbd Use the right num_sids

We use s_i->ptok->num_sids everywhere else in this call and
then suddenly we reference s_i->num_sids

10 years agos3:passdb Fix memory leak
Simo Sorce [Sat, 29 May 2010 13:48:20 +0000 (09:48 -0400)]
s3:passdb Fix memory leak

We were allocating this passwd structure on sampass, but never freeing
it nor assigning it to unix_pw where it could be reused.

10 years agos3:auth Fix segfault when the user cannot be found by getpwnam()
Andrew Bartlett [Fri, 28 May 2010 18:14:27 +0000 (04:14 +1000)]
s3:auth Fix segfault when the user cannot be found by getpwnam()

Add comment to notify when getpwnam() fails.

Reviewed-by: Simo Sorce <idra@samba.org>
10 years agos3-selftest: fix chmod commands in provisioning.
Günther Deschner [Fri, 28 May 2010 22:38:21 +0000 (00:38 +0200)]
s3-selftest: fix chmod commands in provisioning.

Guenther

10 years agos3-selftest: make sure provisioned s3 looks the same in make selftest as in make...
Günther Deschner [Fri, 28 May 2010 22:09:14 +0000 (00:09 +0200)]
s3-selftest: make sure provisioned s3 looks the same in make selftest as in make test.

This fixes some tests that were previously failing.

Guenther

10 years agos4/test-libnet: Remove multiple test_samr_close() impelementations
Kamen Mazdrashki [Fri, 28 May 2010 19:14:39 +0000 (22:14 +0300)]
s4/test-libnet: Remove multiple test_samr_close() impelementations

We now have a nice common test_samr_close_handle() function to use

10 years agos4/test-libnet-user: Remove test_createuser()
Kamen Mazdrashki [Fri, 28 May 2010 18:20:03 +0000 (21:20 +0300)]
s4/test-libnet-user: Remove test_createuser()

We have same functionality already implemented by
test_user_create() in libnet/utils.c

10 years agos4/test-libnet-utils: refactor test_user_create()
Kamen Mazdrashki [Fri, 28 May 2010 14:59:25 +0000 (17:59 +0300)]
s4/test-libnet-utils: refactor test_user_create()

- param names made more clear what they stand for
- user RID out param is now optional, so that this function may
  be used in cases where we don't need user RID
- SAMR connection handle is closed as it is not used further
  (we should play nice with servers)

10 years agos4/test: remove local impl for open_domain and use common one
Kamen Mazdrashki [Fri, 28 May 2010 02:20:18 +0000 (05:20 +0300)]
s4/test: remove local impl for open_domain and use common one

10 years agos4/test: remove torture/libnet/utils.h as we are using proto.h now
Kamen Mazdrashki [Fri, 28 May 2010 02:14:47 +0000 (05:14 +0300)]
s4/test: remove torture/libnet/utils.h as we are using proto.h now

10 years agos4/test: change prototype for test_opendomain()
Kamen Mazdrashki [Fri, 28 May 2010 02:06:55 +0000 (05:06 +0300)]
s4/test: change prototype for test_opendomain()

- name changed to test_domain_open to be more alike athore functions
  in utils.c file
- output parameters moved to the end param list definition just
  after mem_ctx so it is somehow more clear those params are OUT

10 years agos4/test: Refactor test_opendomain to address following
Kamen Mazdrashki [Fri, 28 May 2010 02:04:56 +0000 (05:04 +0300)]
s4/test: Refactor test_opendomain to address following

- param names made more clear what they stand for
- dom_sid out param is now optional, so that this function may
  be used in cases where we don't need dom_sid
- SAMR connection handle is closed as it is not used further

10 years agos4/test: make samr_close handle functio public
Kamen Mazdrashki [Fri, 28 May 2010 01:45:40 +0000 (04:45 +0300)]
s4/test: make samr_close handle functio public

It is to be used further for closing opened handles when testing
using SAMR interface

10 years agos4/test: refactor NET-USERINFO test to be more 'torture' friendly
Kamen Mazdrashki [Thu, 27 May 2010 14:24:10 +0000 (17:24 +0300)]
s4/test: refactor NET-USERINFO test to be more 'torture' friendly

Test may be further refactored to be converted as a test case
(what it is actually)

10 years agos4/test: test_userinfo/_async tests should use passed user_name param value
Kamen Mazdrashki [Thu, 27 May 2010 14:10:31 +0000 (17:10 +0300)]
s4/test: test_userinfo/_async tests should use passed user_name param value

10 years agos4:web_server/wsgi.c - provide a better out-of-memory handling for an "asprintf"...
Matthias Dieter Wallnöfer [Fri, 28 May 2010 16:58:45 +0000 (18:58 +0200)]
s4:web_server/wsgi.c - provide a better out-of-memory handling for an "asprintf" call

10 years agos3:winbind Kill amusing but un-used winbindd_kill_all_clients
Andrew Bartlett [Thu, 13 May 2010 07:41:33 +0000 (17:41 +1000)]
s3:winbind Kill amusing but un-used winbindd_kill_all_clients

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:lib s3:lib move get_global_sam_name to util_names.c
Andrew Bartlett [Wed, 26 May 2010 01:11:08 +0000 (11:11 +1000)]
s3:lib s3:lib move get_global_sam_name to util_names.c

This doesn't really belong in util_sid.c, and has much more in common
with the other functions in util_names.c

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:lib split out global workgroup and netbios name functions.
Andrew Bartlett [Mon, 17 May 2010 06:25:26 +0000 (16:25 +1000)]
s3:lib split out global workgroup and netbios name functions.

Having these in their own file allows easier selective inclusion.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smbd move messaging_context and memcache into globals.c
Andrew Bartlett [Wed, 26 May 2010 00:48:15 +0000 (10:48 +1000)]
s3:smbd move messaging_context and memcache into globals.c

This helps vfstest, which previously had duplicate copies of these functions.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smbd split reload services/printers functions from server.c
Andrew Bartlett [Thu, 27 May 2010 05:18:58 +0000 (07:18 +0200)]
s3:smbd split reload services/printers functions from server.c

This helps vfstest, as it previously had duplicate copies of these
functions.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:smbd split smbd/server.c into smbd/server.c and smbd/server_exit.c
Andrew Bartlett [Wed, 12 May 2010 21:48:04 +0000 (07:48 +1000)]
s3:smbd split smbd/server.c into smbd/server.c and smbd/server_exit.c

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3-waf: Support builds with utmp accounting
Kai Blin [Fri, 28 May 2010 13:17:35 +0000 (15:17 +0200)]
s3-waf: Support builds with utmp accounting

10 years agos3-waf: Match the defines from the autotools build on PACKAGE_*
Kai Blin [Fri, 28 May 2010 12:35:01 +0000 (14:35 +0200)]
s3-waf: Match the defines from the autotools build on PACKAGE_*

10 years agos3-auth: Added a function to get the server_info from the system user.
Andreas Schneider [Wed, 14 Apr 2010 13:15:32 +0000 (15:15 +0200)]
s3-auth: Added a function to get the server_info from the system user.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3-samr: Fix crash bug in _samr_QueryUserInfo{2} level 18.
Günther Deschner [Fri, 28 May 2010 12:11:53 +0000 (14:11 +0200)]
s3-samr: Fix crash bug in _samr_QueryUserInfo{2} level 18.

Guenther

10 years agos4:build Don't automatically mark as 'not a git snapshot'.
Andrew Bartlett [Fri, 28 May 2010 10:34:08 +0000 (20:34 +1000)]
s4:build Don't automatically mark as 'not a git snapshot'.

If we generate a tarball, it may well be a git snapshot - we will
change the VERSION file if it really is a release.

Andrew Bartlett

10 years agos4:build use autotools for mkrelease.sh
Andrew Bartlett [Fri, 28 May 2010 10:33:28 +0000 (20:33 +1000)]
s4:build use autotools for mkrelease.sh

The mkrelease.sh script only works with the autotools build.  However,
it isn't recommended.

Andrew Bartlett

10 years agowaf Provide release signing capability in 'waf dist'
Andrew Bartlett [Fri, 28 May 2010 10:24:47 +0000 (20:24 +1000)]
waf Provide release signing capability in 'waf dist'

This helps ensure the release is signed correctly - the .tar file, not
the .tar.gz must be signed, and it's easy to forget this.

Andrew Bartlett

10 years agos4:waf Exclude the autotools based build environment from a Samba4 release
Andrew Bartlett [Fri, 28 May 2010 08:54:57 +0000 (18:54 +1000)]
s4:waf Exclude the autotools based build environment from a Samba4 release

10 years agowaf Add DIST_BLACKLIST to list files that we cannot include in a release
Andrew Bartlett [Fri, 28 May 2010 08:50:25 +0000 (18:50 +1000)]
waf Add DIST_BLACKLIST to list files that we cannot include in a release

This currently includes the source3 directory for Samba4 releases (per
past practice in mkrelease.sh), but also could include things like
DFSG-unfree RFC files in the future.

Andrew Barltett

10 years agos4:kdc Remove special talloc_free of the ldb context
Andrew Bartlett [Tue, 25 May 2010 09:54:24 +0000 (19:54 +1000)]
s4:kdc Remove special talloc_free of the ldb context

I can see no reason not to just let this go with the talloc tree that
created it, and avoid a talloc_free with references.

Andrew Bartlett

10 years agos3-waf: Fix the smbclient build with libcap
Kai Blin [Fri, 28 May 2010 11:20:10 +0000 (13:20 +0200)]
s3-waf: Fix the smbclient build with libcap

10 years agos3-waf: Detect which version of krb5_enctype_to_string is used
Kai Blin [Fri, 28 May 2010 10:59:04 +0000 (12:59 +0200)]
s3-waf: Detect which version of krb5_enctype_to_string is used

Pair-Programmed-With: Günther Deschner <gd@samba.org>

10 years agos3-waf: Fix the build of swat with --enable-cups
Kai Blin [Fri, 28 May 2010 10:58:23 +0000 (12:58 +0200)]
s3-waf: Fix the build of swat with --enable-cups

10 years agos4:client/client.c - we don't need "&ctx" for talloc calls
Matthias Dieter Wallnöfer [Fri, 28 May 2010 08:39:54 +0000 (10:39 +0200)]
s4:client/client.c - we don't need "&ctx" for talloc calls

Simply use "ctx".

10 years agos4:web_server/wsgi.c - fix "asprintf" call
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:45:19 +0000 (17:45 +0200)]
s4:web_server/wsgi.c - fix "asprintf" call

10 years agos4:utils/ntlm_auth.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:41:39 +0000 (17:41 +0200)]
s4:utils/ntlm_auth.c - fix "asprintf" calls

10 years agos4:smbd/pidfile.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:37:15 +0000 (17:37 +0200)]
s4:smbd/pidfile.c - fix "asprintf" calls

10 years agos4:scripting/python/modules.c - fix "asprintf" calls
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:36:33 +0000 (17:36 +0200)]
s4:scripting/python/modules.c - fix "asprintf" calls

10 years agos4:param/loadparm.c - fix "asprintf" call
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:28:52 +0000 (17:28 +0200)]
s4:param/loadparm.c - fix "asprintf" call

10 years agos4:ntvfs/simple/svfs_util.c - change an "asprintf" into a "talloc_asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:18:03 +0000 (17:18 +0200)]
s4:ntvfs/simple/svfs_util.c - change an "asprintf" into a "talloc_asprintf"

10 years agos4:ntvfs/nbench/vfs_bench.c - change a "asprintf" into a "talloc_asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:11:00 +0000 (17:11 +0200)]
s4:ntvfs/nbench/vfs_bench.c - change a "asprintf" into a "talloc_asprintf"

10 years agos4:libcli/clideltree.c - fix "asprintf"s
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:06:12 +0000 (17:06 +0200)]
s4:libcli/clideltree.c - fix "asprintf"s

10 years agos4:regshell - fix an "asprintf"
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:02:02 +0000 (17:02 +0200)]
s4:regshell - fix an "asprintf"

10 years agos4:regshell - don't use negative exit codes
Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:00:50 +0000 (17:00 +0200)]
s4:regshell - don't use negative exit codes

10 years agos4:client/client.c - fix "asprintf"s
Matthias Dieter Wallnöfer [Thu, 27 May 2010 14:59:14 +0000 (16:59 +0200)]
s4:client/client.c - fix "asprintf"s

Fix the result values or change them into "talloc_asprintf"s where possible

see bug #6404

10 years agowaf Read VERSION file inside WAF to set package version
Andrew Bartlett [Fri, 28 May 2010 05:20:03 +0000 (15:20 +1000)]
waf Read VERSION file inside WAF to set package version

This replaces the call to mkversion.sh in both the Samba3 and Samba4
WAF builds.

Andrew Bartlett

10 years agos3-lanman: Fix api_RNetUserGetInfo level 2 marshalling offset calculation.
Günther Deschner [Thu, 27 May 2010 22:02:15 +0000 (00:02 +0200)]
s3-lanman: Fix api_RNetUserGetInfo level 2 marshalling offset calculation.

54 + 4 = 58 (and not 60).

Found by torture test.

Guenther

10 years agos3-auth: fix c++ buildwarnings.
Günther Deschner [Fri, 28 May 2010 00:47:12 +0000 (02:47 +0200)]
s3-auth: fix c++ buildwarnings.

Guenther

10 years agos3-build: remove duplicate ndr_krb5pac.h inclusion.
Günther Deschner [Fri, 28 May 2010 00:20:21 +0000 (02:20 +0200)]
s3-build: remove duplicate ndr_krb5pac.h inclusion.

Guenther

10 years agos3-build: use ndr_misc.h where needed.
Günther Deschner [Fri, 28 May 2010 00:20:02 +0000 (02:20 +0200)]
s3-build: use ndr_misc.h where needed.

Guenther

10 years agos3-build: only use ndr_samr.h where needed.
Günther Deschner [Fri, 28 May 2010 00:18:21 +0000 (02:18 +0200)]
s3-build: only use ndr_samr.h where needed.

Guenther

10 years agos3-idl: fix some missing dependencies to other IDL files.
Günther Deschner [Fri, 28 May 2010 00:16:38 +0000 (02:16 +0200)]
s3-idl: fix some missing dependencies to other IDL files.

Guenther

10 years agos3-rpc_client: move protos to init_netlogon.h
Günther Deschner [Thu, 27 May 2010 23:19:25 +0000 (01:19 +0200)]
s3-rpc_client: move protos to init_netlogon.h

Guenther

10 years agos3:auth Add comment to clarify usage of session keys.
Simo Sorce [Fri, 28 May 2010 00:40:22 +0000 (20:40 -0400)]
s3:auth Add comment to clarify usage of session keys.

Explain why we have what looks like a duplicate of session keys.
It is in fact not a duplicate.

10 years agos3:auth remove login_server from server info
Simo Sorce [Thu, 27 May 2010 23:41:07 +0000 (19:41 -0400)]
s3:auth remove login_server from server info

It is not used anymore, we have that information in
info3->base.logon_server already

10 years agoFix Out of memory checks
Simo Sorce [Thu, 27 May 2010 23:22:02 +0000 (19:22 -0400)]
Fix Out of memory checks

Günther pushed an older version of the patch "s3:auth add function to copy a
netr_SamInfo3 structure" that was missing these fixes.

10 years agos3:auth add function to convert wbcAuthUserInfo to netr_SamInfo3
Simo Sorce [Thu, 27 May 2010 07:21:35 +0000 (03:21 -0400)]
s3:auth add function to convert wbcAuthUserInfo to netr_SamInfo3

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3:auth Free sampass as soon as we have server_info
Simo Sorce [Thu, 27 May 2010 09:31:45 +0000 (05:31 -0400)]
s3:auth Free sampass as soon as we have server_info

We don't keep sampass in server_info anymore
So it makes no sense to keep it around.

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3:auth use info3 in auth_serversupplied_info
Simo Sorce [Thu, 27 May 2010 07:41:56 +0000 (03:41 -0400)]
s3:auth use info3 in auth_serversupplied_info

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3:auth add function to copy a netr_SamInfo3 structure
Simo Sorce [Thu, 27 May 2010 06:40:59 +0000 (02:40 -0400)]
s3:auth add function to copy a netr_SamInfo3 structure

Signed-off-by: Günther Deschner <gd@samba.org>
10 years agos3:auth: add function to convert samu to netr_SamInfo3
Simo Sorce [Thu, 27 May 2010 06:07:33 +0000 (02:07 -0400)]
s3:auth: add function to convert samu to netr_SamInfo3

Signed-off-by: Günther Deschner <gd@samba.org>