17 years agoIgnore .pyc files.
Tim Potter [Mon, 17 Mar 2003 05:46:54 +0000 (05:46 +0000)]
Ignore .pyc files.
(This used to be commit b20a357ac534b513383ad20046a99bb7f39bba25)

17 years agoFix a memory leak - 'smbcontrol smbd pool-usage' is your freind!
Andrew Bartlett [Mon, 17 Mar 2003 04:42:57 +0000 (04:42 +0000)]
Fix a memory leak - 'smbcontrol smbd pool-usage' is your freind!

Andrew Bartlett
(This used to be commit a12e8524997e329a4f4cd766d6371e384698795a)

17 years agoSome cosmetic changes to make the popt --usage output look nicer.
Tim Potter [Mon, 17 Mar 2003 03:56:58 +0000 (03:56 +0000)]
Some cosmetic changes to make the popt --usage output look nicer.
(This used to be commit 39124b9a62e1ba0f8089c36b27d6c79352a27973)

17 years agoFix memory leaks and add parinoioa code to our stat() cache.
Andrew Bartlett [Mon, 17 Mar 2003 03:47:15 +0000 (03:47 +0000)]
Fix memory leaks and add parinoioa code to our stat() cache.

Andrew Bartlett
(This used to be commit 3fd07bd25eefdb2a7a6891fa1169ab2425607249)

17 years agoMissed one when I move 'share_sanity_checks' to use an fstring for 'dev'.
Andrew Bartlett [Sun, 16 Mar 2003 22:07:36 +0000 (22:07 +0000)]
Missed one when I move 'share_sanity_checks' to use an fstring for 'dev'.

Andrew Bartlett
(This used to be commit a0208a4f74f9c61eb1e346d9cb62dbe00ef4c24a)

17 years agoMake sure we mark the assumption of a fstring parameter for 'devicetype'
Andrew Bartlett [Sun, 16 Mar 2003 13:24:36 +0000 (13:24 +0000)]
Make sure we mark the assumption of a fstring parameter for 'devicetype'
in the function prototype, and change callers to respect this.

Andrew Bartlett
(This used to be commit 9f3d3c380120f16d76d68f346799282d61eec892)

17 years agoAdd const.
Andrew Bartlett [Sun, 16 Mar 2003 13:23:12 +0000 (13:23 +0000)]
Add const.
(This used to be commit 5371720971bc60a4cfba0460614306f322aa10b8)

17 years ago - Make ReadDirName return a const char*.
Andrew Bartlett [Sun, 16 Mar 2003 13:21:12 +0000 (13:21 +0000)]
 - Make ReadDirName return a const char*.

 - Consequential changes from that

 - mark our fstring/pstring assumptions in function prototypes

Andrew Bartlett
(This used to be commit fe2bc64bc439b27387b8f326b0f4f3bfcc3d04a1)

17 years agoTry to avoid dereferencing a null pointer.
Andrew Bartlett [Sun, 16 Mar 2003 13:16:42 +0000 (13:16 +0000)]
Try to avoid dereferencing a null pointer.

Andrew Bartlett
(This used to be commit 4e96585b60512905776c2c6692c76d45241f089d)

17 years agoNew statcache internals - this time it's actually possible to follow what's
Andrew Bartlett [Sun, 16 Mar 2003 13:15:29 +0000 (13:15 +0000)]
New statcache internals - this time it's actually possible to follow what's
going on.

In particular, add doxygen documentation.

Andrew Bartlett
(This used to be commit 7ff77ab46c63eca3b6edf18f39024eadb83a1a90)

17 years agoFix nmbd under -DDEVELOPER (pstrcpy on not-pstring).
Andrew Bartlett [Sun, 16 Mar 2003 03:21:58 +0000 (03:21 +0000)]
Fix nmbd under -DDEVELOPER (pstrcpy on not-pstring).

Make a new macro to help in this situation, and add memcpy() parinoia

Andrew Bartlett
(This used to be commit 4d00626b6e003952df6715fa80615ec028facdf4)

17 years agoChanges to help the kerberos change password code work on systems that
Andrew Bartlett [Sun, 16 Mar 2003 02:14:05 +0000 (02:14 +0000)]
Changes to help the kerberos change password code work on systems that
have some of the labels 'duplicated' (ie, the defines double-up).

Also, to an ads_connect() to try and find our KDC. (So we don't segfualt
*every* time)

Andrew Bartlett
(This used to be commit 56dce7ddad118051c93c62507234efca3920bc9b)

17 years agoMore work on my macro mess - we need function prototypes of different types,
Andrew Bartlett [Sun, 16 Mar 2003 00:39:40 +0000 (00:39 +0000)]
More work on my macro mess - we need function prototypes of different types,
and we were missing the 'char' type.

Andrew Bartlett
(This used to be commit 193e80fafbda9e3af58fec1e629ec607f29b4099)

17 years agoA hack to get us building on a slightly older heimdal kerberos. It appears
Andrew Bartlett [Sat, 15 Mar 2003 23:16:40 +0000 (23:16 +0000)]
A hack to get us building on a slightly older heimdal kerberos.  It appears
that we don't need this flag - heimdal's internal password change routines
don't set it.

Andrew Bartlett
(This used to be commit 069825bd78f2bf125e8a4e72933da924d393f5a5)

17 years agoFix non-gmake syntax error.
Andrew Bartlett [Sat, 15 Mar 2003 22:57:00 +0000 (22:57 +0000)]
Fix non-gmake syntax error.
(This used to be commit 97daece056516e52e56bf5a749676e7c53e087e3)

17 years agoCheckin cifs vfs for Linux mount helper
Steve French [Sat, 15 Mar 2003 22:35:47 +0000 (22:35 +0000)]
Checkin cifs vfs for Linux mount helper
(This used to be commit a55acfd7a296c5ae9b043dc03393a29d87e43a40)

17 years agoFix the 'non-optomizing compiler' case...
Andrew Bartlett [Sat, 15 Mar 2003 11:28:45 +0000 (11:28 +0000)]
Fix the 'non-optomizing compiler' case...

Andrew Bartlett
(This used to be commit 94424c5d72246b2e58f3a21aa0de6949d7eb2da1)

17 years agoFix the non-DEVELOPER case of my macro madness...
Andrew Bartlett [Sat, 15 Mar 2003 10:59:14 +0000 (10:59 +0000)]
Fix the non-DEVELOPER case of my macro madness...

Andrew Bartlett
(This used to be commit 618bda3a28f65417e3c31a70229f6da70cf223fc)

17 years agoMinor fixes.
Andrew Bartlett [Sat, 15 Mar 2003 08:18:29 +0000 (08:18 +0000)]
Minor fixes.
 - signed/unsigned
 - quieten warning about assignment as truth value
 - whitespace

Andrew Bartlett
(This used to be commit a13ce0df4b4a776fa635a1fb804dd00d195f58d0)

17 years agoRemove an unused function and fix the build.
Andrew Bartlett [Sat, 15 Mar 2003 08:03:11 +0000 (08:03 +0000)]
Remove an unused function and fix the build.

Andrew Bartlett
(This used to be commit 67a0319d268dfc0e2154d3ab0f8bf866e3cbb6db)

17 years agoFix signed/unsigned issues - mostly 'i' counters.
Andrew Bartlett [Sat, 15 Mar 2003 07:45:51 +0000 (07:45 +0000)]
Fix signed/unsigned issues - mostly 'i' counters.

Fix an inconpatible poitner type that caused the IA64 not to build

Andrew Bartlett
(This used to be commit 37436b0aae108fceace3049d3868510e1ba592ac)

17 years agosigned/unsigned fix
Andrew Bartlett [Sat, 15 Mar 2003 07:16:32 +0000 (07:16 +0000)]
signed/unsigned fix
(This used to be commit f6bcfa59447700e0ccfc069d0228019a9bdca9d2)

17 years agoString handling parinoia fixes.
Andrew Bartlett [Sat, 15 Mar 2003 07:14:55 +0000 (07:14 +0000)]
String handling parinoia fixes.

This patch enables the compile-time checking of strings assable by means of
sizeof().  (Original code had the configure check reversed).

This is extended to all safe_strcpy() users, push_string and pull_string,
as well as the cli and srv derivitives.  There is an attempt to cap strings
at the end of the cli buffer, and clobber_region() of the speified length
(when not -1 :-).

Becouse of the way they are declared, the 'overmalloc a string' users of
safe_strcpy() have been changed to use overmalloc_safe_strcpy() (which skips
some of the checks).

This whole ball of mud worked fine, until I pulled out my 'fix' for our
statcache.  When jeremy fixes that, we should be able to get back to testing
this stuff.

This patch also includes a 'marker' of the last caller to clobber_region (ie,
the function that called pstrcpy() that called clobber_region) to assist in
debugging problems that may have smashed the stack.  This is printed at
smb_panic() time.  (Original idea and patch by metze).

It also removes some unsused functions, and #if 0's some others that are
unused but probably should be used in the near future.

For now, this patch gives us some confidence on one class of trivial parsing
error in our code.

Andrew Bartlett
(This used to be commit 31f4827acc2a2f00399a5528fc83a0dae5cebaf4)

17 years agoFix off-by-one bug in safe_strcpy size paramater.
Andrew Bartlett [Sat, 15 Mar 2003 06:54:09 +0000 (06:54 +0000)]
Fix off-by-one bug in safe_strcpy size paramater.
(This used to be commit 9af30c9aae3623c4db1edca39a91973f0279acb4)

17 years agoTruncate the machinename manually, so as not to generate level 0 debugs for
Andrew Bartlett [Sat, 15 Mar 2003 06:53:37 +0000 (06:53 +0000)]
Truncate the machinename manually, so as not to generate level 0 debugs for
an expected situation.

Andrew Bartlett
(This used to be commit a07fccb7ae169c0b5089e3f7d2c5d6465b2e4686)

17 years agospecify the size of these buffers
Andrew Bartlett [Sat, 15 Mar 2003 06:51:57 +0000 (06:51 +0000)]
specify the size of these buffers
(This used to be commit f6ea572cd57d4e655d387fe225a5d7122d587a9b)

17 years agoIf the server went away, don't segfault by attempting to FD_SET -1.
Andrew Bartlett [Sat, 15 Mar 2003 06:50:45 +0000 (06:50 +0000)]
If the server went away, don't segfault by attempting to FD_SET -1.

Andrew Bartlett
(This used to be commit 4b1337ee94a19e39a2f4012c4dbc32a2e58cacf5)

17 years agoSpecify buffer sizes
Andrew Bartlett [Sat, 15 Mar 2003 06:46:43 +0000 (06:46 +0000)]
Specify buffer sizes
(This used to be commit aa12379b3fd9646199a8ff3f217ec7dfef1942a5)

17 years agoBe parinoid, malloc an extra SAFETY_MARGIN on the client's inbuf and outbuf.
Andrew Bartlett [Sat, 15 Mar 2003 06:46:05 +0000 (06:46 +0000)]
Be parinoid, malloc an extra SAFETY_MARGIN on the client's inbuf and outbuf.

Andrew Bartlett
(This used to be commit 2effcae13f9dfbff40b34d32c7fd82118c3fd096)

17 years agoclient-side smbpasswd fixes - use pstrcpy_base to avoid clobber_region bugs
Andrew Bartlett [Sat, 15 Mar 2003 06:45:19 +0000 (06:45 +0000)]
client-side smbpasswd fixes - use pstrcpy_base to avoid clobber_region bugs

Andrew Bartlett
(This used to be commit 7ab6559369b4e6ee3c5269d8cff04e5a39f6b493)

17 years agoAdd const, and a signed/unsigned fix.
Andrew Bartlett [Sat, 15 Mar 2003 06:43:37 +0000 (06:43 +0000)]
Add const, and a signed/unsigned fix.
(This used to be commit f07a93eaeba20f5704f43c7f02141adc564db136)

17 years agoIf it's an fstring, use fstrcpy().
Andrew Bartlett [Sat, 15 Mar 2003 06:42:44 +0000 (06:42 +0000)]
If it's an fstring, use fstrcpy().

Andrew Bartlett
(This used to be commit bf5e0698eed72d7fc005be08feb36ef82ada716c)

17 years agoClean up the VFS module loading logic by making the parameter an P_LIST,
Andrew Bartlett [Sat, 15 Mar 2003 06:41:31 +0000 (06:41 +0000)]
Clean up the VFS module loading logic by making the parameter an P_LIST,
rather than a runtime-parsed string.

Andrew Bartlett
(This used to be commit 3465cd6cd92c39c018979b5a82acbddca0927623)

17 years agoFound by my new checking code (yet to be commited):
Andrew Bartlett [Sat, 15 Mar 2003 06:34:32 +0000 (06:34 +0000)]
Found by my new checking code (yet to be commited):

Allow a service longer than 4 characters in CORE tcon.

Andrew Bartlett
(This used to be commit b56613c1cc13ebd5c9ba11a35d2f96c4c3eb0628)

17 years agostrictly, you can't #if on somthing that may or may not be defined.
Andrew Bartlett [Sat, 15 Mar 2003 06:31:23 +0000 (06:31 +0000)]
strictly, you can't #if on somthing that may or may not be defined.

Andrew Bartlett
(This used to be commit 49bae0227323e811cb71ada24928d24f7dc56d1f)

17 years agoNow that mimir has done the grunt work, I'll fix up the comment
Andrew Bartlett [Sat, 15 Mar 2003 06:10:48 +0000 (06:10 +0000)]
Now that mimir has done the grunt work, I'll fix up the comment
(This used to be commit 7154fe10969a34b97ddc8321bfb5271b8e6d4795)

17 years agofix WinXP & Win2K3 remote_arch and check pointer in ntlmssp code before dereferencing
Gerald Carter [Fri, 14 Mar 2003 23:11:19 +0000 (23:11 +0000)]
fix WinXP & Win2K3 remote_arch and check pointer in ntlmssp code before dereferencing
(This used to be commit 2487480228b99183cab9e34ab497997e0c144ed6)

17 years agoWe haven't implemented The Singing Contexts so far.
Rafal Szczesniak [Fri, 14 Mar 2003 17:20:13 +0000 (17:20 +0000)]
We haven't implemented The Singing Contexts so far.
Who knows what .NET server brings, though ...?  ;-)

(This used to be commit d81b0d26903004be6a99ac029dd531fd18947268)

17 years agoExtending code to work both in case of domain membership
Rafal Szczesniak [Fri, 14 Mar 2003 17:16:33 +0000 (17:16 +0000)]
Extending code to work both in case of domain membership
and domain controller respecting interdomain trust relationships.
In the latter case we need to find DC of remote domain instead
of ours. In the former 'domain' is our domain name.

(This used to be commit 0cd45d5d3b3e3ec5a589c3ee9f0e369901eefe8f)

17 years agoFresh meat in trusted domains code:
Rafal Szczesniak [Fri, 14 Mar 2003 17:12:40 +0000 (17:12 +0000)]
Fresh meat in trusted domains code:
 - packing/unpacking utility functions for trusted domain
   password struct; can be used to prepare buffer to store
   in secrets.tdb or (soon) passdb backend
 - similiar functions for DOM_SID
 - respectively modified secrets_(fetch|store) routines
 - new auth mapping code utilising introduced is_trusted_domain
 - added tdb (un)packing of single bytes

(This used to be commit 5281ee7e84421b9be746aed2f1718ceaf2a2fe3d)

17 years ago/tmp/newfun.msg
Rafal Szczesniak [Fri, 14 Mar 2003 17:05:13 +0000 (17:05 +0000)]
(This used to be commit 3f4cb7b2c4d9b54b41bcc184ccfd00032e2b021b)

17 years agoFound by metze with the clobber-region check - if it's a pstring, use pstrcpy().
Andrew Bartlett [Fri, 14 Mar 2003 10:02:12 +0000 (10:02 +0000)]
Found by metze with the clobber-region check - if it's a pstring, use pstrcpy().

Andrew Bartlett
(This used to be commit f9c3c93f55cac774e576fd5975c0582e0b334d6a)

17 years agoAdd examples of ComfyChair
Martin Pool [Fri, 14 Mar 2003 04:54:10 +0000 (04:54 +0000)]
Add examples of ComfyChair
(This used to be commit dfee0a6ad5d203df04df8a54da87ff5e493a33ca)

17 years agoMerge from Subversion
Martin Pool [Fri, 14 Mar 2003 04:50:17 +0000 (04:50 +0000)]
Merge from Subversion

* Better report formatting
(This used to be commit e7eafa10da828b4dc46a05a99164eb8ac37563df)

17 years agoMerge cifsntdomain.sgml fixes from 3.0 branch
Alexander Bokovoy [Thu, 13 Mar 2003 14:55:44 +0000 (14:55 +0000)]
Merge cifsntdomain.sgml fixes from 3.0 branch
(This used to be commit fb85311941967fa1080b84103a01d16b4fd33926)

17 years agoAdd bin/libbigballofmud.a non-shared library. A bit easier to link to
Martin Pool [Thu, 13 Mar 2003 07:05:10 +0000 (07:05 +0000)]
Add bin/libbigballofmud.a non-shared library.  A bit easier to link to
for testing than the .so.  (
(This used to be commit 386087d77f836b8133afc977c9c3e8e7845125dc)

17 years agoIn Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
Martin Pool [Thu, 13 Mar 2003 06:18:18 +0000 (06:18 +0000)]
In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
etc.  So check for that as well as the old names when including macros
and conditionally defining -DVALGRIND.
(This used to be commit c9151c7b1113e2f01bd33d4dd301a2e7e2040b35)

17 years agoIn Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
Martin Pool [Thu, 13 Mar 2003 06:16:51 +0000 (06:16 +0000)]
In Valgrind 1.9.4, the headers have moved to <valgrind/valgrind.h>,
etc.  So check for that as well as the old names.
(This used to be commit 1ffa4d75b75979b8abb409634212ce43a0826467)

17 years agoAdded chainlock, chainunlock, lock_bystring and unlock_bystring methods.
Tim Potter [Thu, 13 Mar 2003 06:09:18 +0000 (06:09 +0000)]
Added chainlock, chainunlock, lock_bystring and unlock_bystring methods.
(This used to be commit cd5c47f47379a8c4021771ec28a9da0085f80d98)

17 years agoFixed crash bug when calling tdb_unlockkeys() with no locked keys.
Tim Potter [Thu, 13 Mar 2003 05:52:49 +0000 (05:52 +0000)]
Fixed crash bug when calling tdb_unlockkeys() with no locked keys.

(This used to be commit eb432700c0010e536be3a0703f152c533357b851)

17 years agoshow which files we fail to create in the casetable test
Andrew Tridgell [Thu, 13 Mar 2003 04:36:32 +0000 (04:36 +0000)]
show which files we fail to create in the casetable test
(This used to be commit d40e3747cfa2994349aa84568f7b79457341a058)

17 years agofixed the unmarshalling of the queryaliasmem SAMR call
Andrew Tridgell [Thu, 13 Mar 2003 04:35:15 +0000 (04:35 +0000)]
fixed the unmarshalling of the queryaliasmem SAMR call
(This used to be commit 80c45434092a881fe2c9ae7f90856deea4722cb0)

17 years agowin2000 can take much longer than the specified time to respond to a
Andrew Tridgell [Thu, 13 Mar 2003 04:34:31 +0000 (04:34 +0000)]
win2000 can take much longer than the specified time to respond to a
lock - so to make the torture tests valid I give it a grace time of 10
seconds instead of 2
(This used to be commit c9c9e9eb26ec3042395637d14a6661d04a629ccc)

17 years agoChange size parameters from signed to unsigned to fix up warnings.
Jeremy Allison [Wed, 12 Mar 2003 22:24:12 +0000 (22:24 +0000)]
Change size parameters from signed to unsigned to fix up warnings.
(This used to be commit 2e9880ef7c259b67eb75edc8098b734c3b7b22c1)

17 years agofixed a strcat noticed by metze
Andrew Tridgell [Wed, 12 Mar 2003 21:01:25 +0000 (21:01 +0000)]
fixed a strcat noticed by metze
(This used to be commit db3ad0dbe0bca729f98ca5d5a698388fe086daf2)

17 years agoEnsure we count the length correctly in mangle_map.
Jeremy Allison [Wed, 12 Mar 2003 19:08:01 +0000 (19:08 +0000)]
Ensure we count the length correctly in mangle_map.
(This used to be commit 596705198c555568da208f59008ab87c5164bfb4)

17 years agoadding some initiaial code to sert %a to Win2K3 (using Native LanMan string from...
Gerald Carter [Wed, 12 Mar 2003 15:40:43 +0000 (15:40 +0000)]
adding some initiaial code to sert %a to Win2K3 (using Native LanMan string from .NET RC2)
(This used to be commit 4c823e61d14a33344deb887043b60b2e3c83416f)

17 years agoAdd const
Andrew Bartlett [Wed, 12 Mar 2003 11:00:02 +0000 (11:00 +0000)]
Add const
(This used to be commit 147a0c8b13d20e06c557fb817a36fddf9a920d65)

17 years ago - Fix a double-free (I can't say I understand the code, but it matches the other
Andrew Bartlett [Wed, 12 Mar 2003 10:56:55 +0000 (10:56 +0000)]
 - Fix a double-free (I can't say I understand the code, but it matches the other
cases and keeps valgrind quiet).

 - Add static

Andrew Bartlett
(This used to be commit e9da9c500b96a828d744e7a1c64427fc01153310)

17 years agoPatch from Ken Cross <> to take a username in the form
Andrew Bartlett [Wed, 12 Mar 2003 10:36:14 +0000 (10:36 +0000)]
Patch from Ken Cross <> to take a username in the form
of user@realm for kerberos logins.

Andrew Bartlett
(This used to be commit ce013dc13e9e77b5cb9b2d5a4b76d54f91614e6c)

17 years agoUpdate for new version of ComfyChair: some methods are renamed to be
Martin Pool [Wed, 12 Mar 2003 07:17:39 +0000 (07:17 +0000)]
Update for new version of ComfyChair: some methods are renamed to be
more consistent, and it now looks at command-line arguments to work
out what to do.

Run this program to get a quick demonstration of what ComfyChair does.
(This used to be commit 9b0c59a10707b2bbe3837d718e5030a6cdf19bfa)

17 years agoNew import of ComfyChair, many changes
Martin Pool [Wed, 12 Mar 2003 07:14:03 +0000 (07:14 +0000)]
New import of ComfyChair, many changes
(This used to be commit e84046e769a518fa1970827f4dcb8284ba9b9952)

17 years agoImport Samba Testing Framework code from private CVS module.
Martin Pool [Wed, 12 Mar 2003 03:08:28 +0000 (03:08 +0000)]
Import Samba Testing Framework code from private CVS module.
(This used to be commit 0effe832a48f0c51d50675558cc2744e815d68c7)

17 years agoImport design notes by martin and tpot from ComfyChair and stf modules.
Martin Pool [Wed, 12 Mar 2003 03:07:46 +0000 (03:07 +0000)]
Import design notes by martin and tpot from ComfyChair and stf modules.
(This used to be commit f923729ca37c18fd58943015a530607c05e96659)

17 years agoImport ComfyChair framework from trunk.
Martin Pool [Wed, 12 Mar 2003 03:06:42 +0000 (03:06 +0000)]
Import ComfyChair framework from trunk.
(This used to be commit a7fb1fcc72ffe3cc2aa9c5abfcbd8197e7610167)

17 years agoStart importing the Python testing framework that Tim and I have been
Martin Pool [Wed, 12 Mar 2003 03:04:37 +0000 (03:04 +0000)]
Start importing the Python testing framework that Tim and I have been
working on into the main Samba tree.
(This used to be commit f3b77aae13df2559a81db6453d04e0fe8004cd52)

17 years agoUpdate usage message.
Martin Pool [Wed, 12 Mar 2003 02:58:45 +0000 (02:58 +0000)]
Update usage message.
(This used to be commit 17f01f6959fb79ba11a56d6869ec9789e3ee2f74)

17 years agoAdd example of string overflow which is now caught in developer mode.
Martin Pool [Wed, 12 Mar 2003 02:57:48 +0000 (02:57 +0000)]
Add example of string overflow which is now caught in developer mode.
(This used to be commit dcf1705782f5d589120624c90b695b81a0332e6b)

17 years agoWe use unsigned now, so use %u.
Jeremy Allison [Tue, 11 Mar 2003 20:57:41 +0000 (20:57 +0000)]
We use unsigned now, so use %u.
(This used to be commit 01727b0296ee407e49444b9d9c4e7993892cb537)

17 years agoFix up zero termination. Spotted by Sebastian Krahmer <>.
Jeremy Allison [Tue, 11 Mar 2003 18:10:36 +0000 (18:10 +0000)]
Fix up zero termination. Spotted by Sebastian Krahmer <>.
(This used to be commit 69becdb563b2620513931811a6695481bebcceed)

17 years agoThis patch attemptes to clean up winbindd's mutex locking.
Andrew Bartlett [Tue, 11 Mar 2003 11:28:59 +0000 (11:28 +0000)]
This patch attemptes to clean up winbindd's mutex locking.

The current locking scheme in winbind is a complete mess - indeed, the
next step should be to push the locking into cli_full_connection(), but
I'll leave it for now.

This patch works on the noted behaviour that 2 parts of the connection
process need protection - and independent protection.  Tim Potter did
some work on this a little while back, verifying the second case.

The two cases are:
 - between connect() and first session setup
 - during the auth2 phase of the netlogon pipe setup.

I've removed the counter on the lock, as I fail to see what it gains us.

This patch also adds 'anonymous fallback' to our winbindd -> DC connection.

If the authenticated connection fails (wbinfo -A specifed) - say that
account isn't trusted by a trusted DC - then we try an anonymous.

Both tpot and mbp like the patch.

Andrew Bartlett
(This used to be commit 0620320002082298a15cbba72bd79aecfc607947)

17 years agosecurity=domain and domain logons = yes should be a BDC (of sorts).
Andrew Bartlett [Tue, 11 Mar 2003 10:53:46 +0000 (10:53 +0000)]
security=domain and domain logons = yes should be a BDC (of sorts).

Matches 2.2

Andrew Bartlett
(This used to be commit f6497fd639c5bb7d61eda0286c4c3c38609933b0)

17 years agoSome further tought on the server role issue - try not to break it compeatly.
Andrew Bartlett [Tue, 11 Mar 2003 10:13:57 +0000 (10:13 +0000)]
Some further tought on the server role issue - try not to break it compeatly.

Andrew Bartlett
(This used to be commit 4c6a2d8d28d1752d7fee52d253ce2829bd0a0671)

17 years agoAfter 'consultation' with idra, this is how I think the server roles should work...
Andrew Bartlett [Tue, 11 Mar 2003 10:06:34 +0000 (10:06 +0000)]
After 'consultation' with idra, this is how I think the server roles should work...

Andrew Bartlett
(This used to be commit 5c1f1005907bf50b809dfae1f8251c7122103098)

17 years agoThis is how combination of domain logons and security parameter best combine.
Simo Sorce [Tue, 11 Mar 2003 09:16:37 +0000 (09:16 +0000)]
This is how combination of domain logons and security parameter best combine.
Comments wellcome.

(This used to be commit e1431424e7603d946f63cfe7fe669b0b32ac8095)

17 years agoRemove valgrind_strlen function, hopefully no longer needed with
Martin Pool [Tue, 11 Mar 2003 07:25:48 +0000 (07:25 +0000)]
Remove valgrind_strlen function, hopefully no longer needed with
recent Valgrind relases and clashing with -DVALGRIND.
(This used to be commit 98479f1315cf8968152e1566966ac57e171008c3)

17 years agoNote about using Valgrind with tdbs.
Martin Pool [Tue, 11 Mar 2003 07:23:43 +0000 (07:23 +0000)]
Note about using Valgrind with tdbs.
(This used to be commit 36c6f67d4af50d8fc4c8bd54486df315861d55c2)

17 years agohaving sticky create times is not a bug
Andrew Tridgell [Tue, 11 Mar 2003 06:53:44 +0000 (06:53 +0000)]
having sticky create times is not a bug
(This used to be commit f283f71104319fa9f1e7d22fc91b8d7224ae157a)

17 years agofixed the MANGLE smbtorture test with the new paranoid string code
Andrew Tridgell [Tue, 11 Mar 2003 06:53:10 +0000 (06:53 +0000)]
fixed the MANGLE smbtorture test with the new paranoid string code
(This used to be commit 7be44dbe009a8d831c0720a2649fc871b067beef)

17 years agomake sure we have an empty directory when we start the utable test
Andrew Tridgell [Tue, 11 Mar 2003 06:31:23 +0000 (06:31 +0000)]
make sure we have an empty directory when we start the utable test
(This used to be commit af415842b80f024ca26b4e3bc52fd73fce0a28f3)

17 years agoIf using --enable-developer and valgrind.h is present, define VALGRIND.
Martin Pool [Tue, 11 Mar 2003 05:57:53 +0000 (05:57 +0000)]
If using --enable-developer and valgrind.h is present, define VALGRIND.
(This used to be commit 71c8e90117f00f168416f2f35a1c25755e2d0ed4)

17 years agoWhen opening an existing DB, don't require the hash_size specified to
Martin Pool [Tue, 11 Mar 2003 04:21:14 +0000 (04:21 +0000)]
When opening an existing DB, don't require the hash_size specified to
the open call to be the same as that of the existing tdb.  The
specified hash_size is only used if the tdb needs to be (re)created.

With this patch in place, tdbtool can open the printing tdbs, which
are created with a hash_size of 5000.  Before it would fail with EIO.
(This used to be commit e412dd6d7e5a41de94c07c64b186390ccce104cc)

17 years agoRemove obsolete file.
Tim Potter [Tue, 11 Mar 2003 02:30:17 +0000 (02:30 +0000)]
Remove obsolete file.
(This used to be commit c5c1a7979385778c08d6dd7796cfe8be1815992f)

17 years agoPatch from Ronan Waide:
Martin Pool [Tue, 11 Mar 2003 00:14:55 +0000 (00:14 +0000)]
Patch from Ronan Waide:

> when doing "enumdomusers", rpcclient prints each one preceded by the
> word "group" instead of "user"
(This used to be commit 17567dd1d510d4cf1dffa67be78510ae51571ec6)

17 years agoSome conversion to pstrcpy_base.
Volker Lendecke [Mon, 10 Mar 2003 16:59:29 +0000 (16:59 +0000)]
Some conversion to pstrcpy_base.

(This used to be commit 329911e43681b724cb0579aad77b4a658759d7ba)

17 years agocheck a pointer before dereferencing it; not sure why userdata == NULL though
Gerald Carter [Mon, 10 Mar 2003 15:05:06 +0000 (15:05 +0000)]
check a pointer before dereferencing it; not sure why userdata == NULL though
(This used to be commit 6fca29ddcdb111af24ee051b555ab4eec8cadd1d)

17 years agoDon't segfault on make_server_info_guest() failure - instead return the
Andrew Bartlett [Mon, 10 Mar 2003 12:08:32 +0000 (12:08 +0000)]
Don't segfault on make_server_info_guest() failure - instead return the
error code.

make_server_info_guest() requires an entry in the SAM at the moment, but
this will change before release.

Andrew Bartlett
(This used to be commit 6a956390fa253e87e38b3f1909f13595fbf2767a)

17 years agoUse "$@" to preserve shell quoting in case somebody passes an escaped
Martin Pool [Mon, 10 Mar 2003 03:04:47 +0000 (03:04 +0000)]
Use "$@" to preserve shell quoting in case somebody passes an escaped
string as a configure parameter.
(This used to be commit 3285c80cb0e41d6736b4f74b01a65d55753a7920)

17 years agofixed use_oplocks and the timeout in smbtorture startup
Andrew Tridgell [Mon, 10 Mar 2003 02:51:30 +0000 (02:51 +0000)]
fixed use_oplocks and the timeout in smbtorture startup
(This used to be commit cec1ef09e5009cdac22e6c9ca101a49c5ef36b1a)

17 years agoadded -i option for ignoring dot errors in masktest
Andrew Tridgell [Mon, 10 Mar 2003 02:49:52 +0000 (02:49 +0000)]
added -i option for ignoring dot errors in masktest
(This used to be commit 0f4d1172a6add3f490fca22a45975d2588485146)

17 years for NTLMSSP singing update
Andrew Bartlett [Mon, 10 Mar 2003 02:48:32 +0000 (02:48 +0000)] for NTLMSSP singing update
(This used to be commit 7717555438e4d74bb63d12abde3573933c15342a)

17 years agoFurther work on NTLMSSP-based SMB signing. Current status is that I cannnot
Andrew Bartlett [Mon, 10 Mar 2003 02:14:35 +0000 (02:14 +0000)]
Further work on NTLMSSP-based SMB signing.  Current status is that I cannnot
get Win2k to send a valid signiture in it's session setup reply - which it will
give to win2k clients.

So, I need to look at becoming 'more like MS', but for now I'll get this code
into the tree.  It's actually based on the TNG cli_pipe_ntlmssp.c, as it was
slightly easier to understand than our own (but only the utility functions
remain in any way intact...).

This includes the mysical 'NTLM2' code - I have no idea if it actually works.

(I couldn't get TNG to use it for its pipes either).

Andrew Bartlett
(This used to be commit a034a5e381ba5612be21e2ba640d11f82cd945da)

17 years agoClobber strings with 0xf1f1f1f1 before writing to them to check buffer
Martin Pool [Mon, 10 Mar 2003 01:10:45 +0000 (01:10 +0000)]
Clobber strings with 0xf1f1f1f1 before writing to them to check buffer
lengths are correct.  Attempts to pstrcpy into an fstring or allocated
string should fail in developer builds.

This builds on abartlet's earlier overflow probe for safe_strcpy, but
by clobbering the whole string with a nonzero value is more likely to
find overflows on the stack.

This is only used in -DDEVELOPER mode.

Reviewed by abartlet, tpot.
(This used to be commit 8d915e266cd8ccc8b27e9c7ea8e9d003d05f8182)

17 years agoInclude valgrind.h if present on the system.
Martin Pool [Mon, 10 Mar 2003 00:45:28 +0000 (00:45 +0000)]
Include valgrind.h if present on the system.
(This used to be commit 65ba78c6bd4c5ab7ec9bf4d15e4410482e82588d)

17 years agoCheck for valgrind.h
Martin Pool [Mon, 10 Mar 2003 00:37:25 +0000 (00:37 +0000)]
Check for valgrind.h
(This used to be commit 0ece70d631bf095bf9c8819180b6c59990159cd0)

17 years agoTry not to clobber the session request.
Andrew Bartlett [Sun, 9 Mar 2003 21:09:28 +0000 (21:09 +0000)]
Try not to clobber the session request.
(This used to be commit 05cffbee56f0556f550b4d14f3111bd7db972621)

17 years agoAdd Ronan Waide's info about the setdriver call.
Jelmer Vernooij [Sun, 9 Mar 2003 16:39:34 +0000 (16:39 +0000)]
Add Ronan Waide's info about the setdriver call.
(This used to be commit ef6cb3ec1aa943d4e52ea08e7b43a47d781d3273)

17 years agoAdd some printing question & answers
Jelmer Vernooij [Sun, 9 Mar 2003 12:08:36 +0000 (12:08 +0000)]
Add some printing question & answers
(This used to be commit 998537ca398100974075d11e28d5199997424f15)

17 years agoChange the way we sign SMB packets, to a function pointer interface.
Andrew Bartlett [Sun, 9 Mar 2003 09:23:09 +0000 (09:23 +0000)]
Change the way we sign SMB packets, to a function pointer interface.

The intention is to allow for NTLMSSP and kerberos signing of packets, but
for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA

Andrew Bartlett
(This used to be commit b9cf95c3dc04a45de71fb16e85c1bfbae50e6d8f)

17 years agoDon't fault on error returns (ptr == 0) for this LSA query.
Andrew Bartlett [Sun, 9 Mar 2003 01:13:41 +0000 (01:13 +0000)]
Don't fault on error returns (ptr == 0) for this LSA query.

(for example, query to non-dc)

Andrew Bartlett
(This used to be commit d1dde5f684652f86e63ac6cfa34ff42a680693de)