samba.git
17 years agoadd_initial_entry should fail if string_to_sid fails.
Martin Pool [Tue, 18 Feb 2003 01:05:56 +0000 (01:05 +0000)]
add_initial_entry should fail if string_to_sid fails.
(This used to be commit bb095dc28d8369457286225ac63e03070889f394)

17 years agoPatch from vorlon@debian.org to split out our -lacl dependency to only smbd
Andrew Bartlett [Tue, 18 Feb 2003 00:54:22 +0000 (00:54 +0000)]
Patch from vorlon@debian.org to split out our -lacl dependency to only smbd
and vfstest.
(This used to be commit bcbc2213230e95d732a774b5aee67295fba4380b)

17 years agoDoxygen janitor and some doc typo fixes.
Martin Pool [Tue, 18 Feb 2003 00:52:42 +0000 (00:52 +0000)]
Doxygen janitor and some doc typo fixes.
(This used to be commit 82414706e6659c1638936d9b9afdb9329109f58f)

17 years agoDoxygen janitor. No other changes.
Martin Pool [Tue, 18 Feb 2003 00:41:13 +0000 (00:41 +0000)]
Doxygen janitor.  No other changes.
(This used to be commit fa38e7956c21b828ba208282ef0ac85c2b66ff22)

17 years agoThe cli_send_tconX code already determines to send \\server\share to port 139
Andrew Bartlett [Tue, 18 Feb 2003 00:36:37 +0000 (00:36 +0000)]
The cli_send_tconX code already determines to send \\server\share to port 139
and share to 445, so doing this only confuses the issue (sending
\\server\\server\share to 139) and makes debugging specific error codes more
difficult.

Andrew Bartlett
(This used to be commit 1a723bcda72901dac00b36955e860e3af23c0dc6)

17 years agoUpdate config.guess, config.sub to the versions from the GNU autotools
Martin Pool [Mon, 17 Feb 2003 23:49:01 +0000 (23:49 +0000)]
Update config.guess, config.sub to the versions from the GNU autotools
2003-01-10 release.  This adds or improves detection for many host
platforms.
(This used to be commit 24fe55ea6d55a78d662942e78e192a84809fcba6)

17 years agoAdd comment explaining the -DDEVELOPER safe_strcpy overflow hack.
Martin Pool [Mon, 17 Feb 2003 23:33:55 +0000 (23:33 +0000)]
Add comment explaining the -DDEVELOPER safe_strcpy overflow hack.
(This used to be commit 90e1d8bdfa9ec0a4f3795d9a89db1d2324447b68)

17 years agoCorrectly check for inet_addr fail. Patch from gregor.7@osu.edu.
Jeremy Allison [Mon, 17 Feb 2003 21:19:09 +0000 (21:19 +0000)]
Correctly check for inet_addr fail. Patch from gregor.7@osu.edu.
Jeremy.
(This used to be commit fb3548e5080812c037c2c134504cc9af4ecbfedd)

17 years agoDummy commit, I can't get through to samba-cvs@samba.org. It can't really
Volker Lendecke [Mon, 17 Feb 2003 21:12:21 +0000 (21:12 +0000)]
Dummy commit, I can't get through to samba-cvs@samba.org. It can't really
remember under what mail address I have to post.

My last commit to this file made it compile again, my fingers were a bit
too fast to really type this message.

Sorry for this confusion,

Volker
(This used to be commit 3b905f5a16dff8ce6742a92fd403cb720707f513)

17 years agocmd_srvsvc.c
Volker Lendecke [Mon, 17 Feb 2003 21:04:09 +0000 (21:04 +0000)]
cmd_srvsvc.c
(This used to be commit fcfbb3c430b2e48819c0c1852bc154661c4b7adf)

17 years agoThis is a very nice way to detect pstrcpy() into a malloc()ed string, but
Andrew Bartlett [Mon, 17 Feb 2003 12:33:24 +0000 (12:33 +0000)]
This is a very nice way to detect pstrcpy() into a malloc()ed string, but
it really is a developer hack...

Andrew Bartlett
(This used to be commit 3588ebb35b14422141d4070413185195b525038e)

17 years agoThis patch fixes one of my longest-standing pet hates with Samba :-).
Andrew Bartlett [Mon, 17 Feb 2003 12:27:34 +0000 (12:27 +0000)]
This patch fixes one of my longest-standing pet hates with Samba :-).

When we look see if a user is in a list, and we try to 'expand' an @group, we
should lookup the user's own list of groups, rather than looking for all the
members of a group.

I'm sure this will fix some nasty performance issues, particularly on large
domains etc.  In particular, this avoids contacting winbind at all, if the
group is not a winbind group.

(This caused a deadlock on my winbind-on-PDC setup).

The groups list always includes the user's primary group, as per the
getgrouplist manpage, and my recent changes to our implementation.

Andrew Bartlett
(This used to be commit 9be21976f7662ebe6eb92fff7cecbdb352eca334)

17 years agoDon't leak a session_key worth of memory at the end of the NTLMSSP auth.
Andrew Bartlett [Mon, 17 Feb 2003 12:20:20 +0000 (12:20 +0000)]
Don't leak a session_key worth of memory at the end of the NTLMSSP auth.
(This used to be commit ae9765b84de0fd6eff790b3bff26dd3d43ec2bd6)

17 years agoSet the length back to zero when we free the data_blob.
Andrew Bartlett [Mon, 17 Feb 2003 12:19:12 +0000 (12:19 +0000)]
Set the length back to zero when we free the data_blob.
(This used to be commit 4560594a67056ee1a5e51a122d1b254944e7c266)

17 years agoTry to make our getgrouplist replacement better match the 'real' implemenations.
Andrew Bartlett [Mon, 17 Feb 2003 12:04:09 +0000 (12:04 +0000)]
Try to make our getgrouplist replacement better match the 'real' implemenations.

In particular, make sure we include the primary gid in the list.

Andrew Bartlett
(This used to be commit 0cd4b339b7eff55019caaeaa998d5e70b2eed200)

17 years agoTypo: /mized/mixed/
Martin Pool [Mon, 17 Feb 2003 06:54:43 +0000 (06:54 +0000)]
Typo: /mized/mixed/
(This used to be commit ada36d2fe38dbb07886a671a6d85b6317ab230a8)

17 years agoDon't pstrcpy into an fstring. (Harmless in this case since it comes
Martin Pool [Mon, 17 Feb 2003 06:28:58 +0000 (06:28 +0000)]
Don't pstrcpy into an fstring.  (Harmless in this case since it comes
from an environment variable.)
(This used to be commit 9f9077346bf9f7c96376169c60aa893f15fb9d2c)

17 years agoStart reworking rpcclient to use popt rather than next_token to parse
Martin Pool [Mon, 17 Feb 2003 05:42:36 +0000 (05:42 +0000)]
Start reworking rpcclient to use popt rather than next_token to parse
command lines.  This makes the code much simpler and also stops
trivial syntax errors from causing a crash.

Also fix support for semicolon-separated commands in -c, which is
promised by the manual but apparently never working due to an
off-by-one error.
(This used to be commit d85a25e733fe970ae96a02a5cbc892f2b8dca1b7)

17 years agoAdded SRVSVC pipe support. I've started implementing NetServerGetInfo()
Tim Potter [Mon, 17 Feb 2003 04:43:09 +0000 (04:43 +0000)]
Added SRVSVC pipe support.  I've started implementing NetServerGetInfo()
(This used to be commit 8e0d781995b56dd1cd348baadd494bb8e64c10bc)

17 years agoAdd KRBCLIENT_OBJ to PYTHON_OBJ list.
Tim Potter [Mon, 17 Feb 2003 04:41:08 +0000 (04:41 +0000)]
Add KRBCLIENT_OBJ to PYTHON_OBJ list.
(This used to be commit 651be759b3db98133feb6fe8c578964ec7b5cf71)

17 years agoReturn a WERROR instead of a NTSTATUS like the rest of the srvsvc
Tim Potter [Mon, 17 Feb 2003 04:35:32 +0000 (04:35 +0000)]
Return a WERROR instead of a NTSTATUS like the rest of the srvsvc
rpc calls.
(This used to be commit 619af61644ecc221c45e5cf69d562451b5b9f951)

17 years agoIf we didn't make the server_info correctly, then don't segfault trying to
Andrew Bartlett [Mon, 17 Feb 2003 00:58:47 +0000 (00:58 +0000)]
If we didn't make the server_info correctly, then don't segfault trying to
set the 'guest' bit.

Andrew Bartlett
(This used to be commit 960c53bf952de4431da4e90da035fcfbe98f1bd7)

17 years agoPeople were being tripped up by the fact that we havn't updated acconfig.h
Andrew Bartlett [Mon, 17 Feb 2003 00:07:38 +0000 (00:07 +0000)]
People were being tripped up by the fact that we havn't updated acconfig.h
as we don't need it for autoconf 2.53.  Remove it from CVS, and assert the
newer autotools in configure.in

Andrew Bartlett
(This used to be commit 14b38c004f4bd5b695d04941b03e3bfa31372da3)

17 years agoAdd the 'session key' output of the NTLMSSP exchange to the cli struct, so
Andrew Bartlett [Sun, 16 Feb 2003 22:10:48 +0000 (22:10 +0000)]
Add the 'session key' output of the NTLMSSP exchange to the cli struct, so
it can be used for 'net rpc join'.

Also fix a bug in our server-side NTLMSSP code - a client without any domain
trust links to us may calculate the NTLMv2 response with "" as the domain.

Andrew Bartlett
(This used to be commit ddaa42423bc952e59b95362f5f5aa7cca10d1ad4)

17 years agoRecover much of my changes to editreg.c. Add some const and start coding
Richard Sharpe [Sun, 16 Feb 2003 17:16:06 +0000 (17:16 +0000)]
Recover much of my changes to editreg.c. Add some const and start coding
the regedit file parser etc.
(This used to be commit 5040b498675b91cd18bc7fe4456c94df0a8fa41d)

17 years ago* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736
Gerald Carter [Sat, 15 Feb 2003 23:36:18 +0000 (23:36 +0000)]
* set PRINTER_ATTRIBUTE_RAW_ONLY; CR 1736
* never save a pointer to an automatic variable (they go away)
  implement a deep copy for SPOOLSS_NOTIFY_MSG to correct
  messages being sent that have junk for strings;
  fix in response to changes for CR 1504
(This used to be commit 043b9dff22e909fc290c34d879cad8b4c980fc13)

17 years agoThird-party configuration scripts may produce undesirable additions to CFLAGS/CPPFLAGS
Alexander Bokovoy [Sat, 15 Feb 2003 22:51:15 +0000 (22:51 +0000)]
Third-party configuration scripts may produce undesirable additions to CFLAGS/CPPFLAGS
and LIBS/LDFALGS. In particular, they often don't check where the appropriate libraries
were installed and pass -I/usr/include and -L/usr/lib as part of CFLAGS/LDFLAGS.

While the latter isn't dangerous, passing system include directory through -I lead
to change of its status in CPP from system to user-defined in many cases.

This patch cleans up CFLAGS/CPPFLAGS from errorenous -I/usr/include and LIBS/LDFLAGS
from -L/usr/lib. This is done as two m4 macros which are called before AC_OUTPUT.
(This used to be commit 643172ac1a9b53823d704690eb03120074bbef78)

17 years agoDon't return NULL pointers for now.
Andrew Bartlett [Sat, 15 Feb 2003 21:41:01 +0000 (21:41 +0000)]
Don't return NULL pointers for now.

We should look into how to deal with NULL v "" strings, and the NTLMSSP code
underneath properly at some stage.

Andrew Bartlett
(This used to be commit dc934412b0190ea75073cccddac45e74ebcd4a6b)

17 years agofix dumb perror used without errno beeing set.
Simo Sorce [Sat, 15 Feb 2003 21:36:28 +0000 (21:36 +0000)]
fix dumb perror used without errno beeing set.
thanks to RedHat developers for the report
(This used to be commit 4a3c6c62d979707900b95e6c38b0132f522269ca)

17 years agoSome small updates
Jelmer Vernooij [Sat, 15 Feb 2003 16:35:20 +0000 (16:35 +0000)]
Some small updates
(This used to be commit 10a97c22637ce5320b4d30d7724d200d25fbfd25)

17 years agoWhen checking for tgetent, include libtinfo from recent Ncurses as well
Alexander Bokovoy [Sat, 15 Feb 2003 15:50:24 +0000 (15:50 +0000)]
When checking for tgetent, include libtinfo from recent Ncurses as well
(This used to be commit c88a5b1abaaee9aea3ece5677fce8b79bcd00552)

17 years agoAdd support for krb5-config from recent MIT and Heimdal. And fallback to traditional...
Alexander Bokovoy [Sat, 15 Feb 2003 15:47:32 +0000 (15:47 +0000)]
Add support for krb5-config from recent MIT and Heimdal. And fallback to traditional guessing only if krb5-config was not found.
(This used to be commit ca27334ba0f2ffbe0fd2a18ef5edf644d4e52190)

17 years agoAdd draft of universal passdb document that combines ENCRYPTION.sgml,
Jelmer Vernooij [Sat, 15 Feb 2003 14:44:25 +0000 (14:44 +0000)]
Add draft of universal passdb document that combines ENCRYPTION.sgml,
Samba-LDAP-HOWTO.sgml, pdb_mysql.sgml and pdb_xml.sgml
(This used to be commit fc26d1bfd15e8762628f115dd18e9d716bbea0e8)

17 years agoRemove obsolete textdocs - they have been migrated to SGML
Jelmer Vernooij [Sat, 15 Feb 2003 14:17:03 +0000 (14:17 +0000)]
Remove obsolete textdocs - they have been migrated to SGML
(This used to be commit 327075d14f266170de140d728b4a4a4283e65026)

17 years agoFix *a lot* of syntax errors
Jelmer Vernooij [Sat, 15 Feb 2003 14:13:55 +0000 (14:13 +0000)]
Fix *a lot* of syntax errors
(This used to be commit 41753997ae427bdca86c98d35f0aff7eb3293995)

17 years agoMove our NTLMSSP client code into ntlmssp.c. The intention is to provide a
Andrew Bartlett [Sat, 15 Feb 2003 12:20:22 +0000 (12:20 +0000)]
Move our NTLMSSP client code into ntlmssp.c.  The intention is to provide a
relitivly useful external lib from this code, and to remove the dupicate
NTLMSSP code elsewhere in samba (RPC pipes, LDAP client).

The code I've replaced this with in cliconnect.c is relitivly ugly, and
I hope to replace it with a more general SPENGO layer at some later date.

Andrew Bartlett
(This used to be commit b2b66909ac2e251f8189e0696b6075dbf748521a)

17 years agoUse more portable @SHLIBEXT@ instead of .so
Jelmer Vernooij [Sat, 15 Feb 2003 02:04:41 +0000 (02:04 +0000)]
Use more portable @SHLIBEXT@ instead of .so
(This used to be commit ba25db83f241a28200132f3dc52f7f5f93a3b00e)

17 years agoRemove obsolete file lib/netatalk.c - We have a VFS module now
Jelmer Vernooij [Sat, 15 Feb 2003 02:02:51 +0000 (02:02 +0000)]
Remove obsolete file lib/netatalk.c - We have a VFS module now
(This used to be commit 28653989cfe5d705b99a4888c0c3fb79d1f89162)

17 years agoPatch based on work by Michael Steffens <michael_steffens@hp.com> to wrap
Jeremy Allison [Sat, 15 Feb 2003 01:34:34 +0000 (01:34 +0000)]
Patch based on work by Michael Steffens <michael_steffens@hp.com> to wrap
all cm_get_XX calls and their subsequent requests in a retry loop in case
we've temporarily lost connection to the DC. Makes winbindd more reliable.
Jeremy.
(This used to be commit 81f358b632dbf7043d2a716359b0fcf7c647af0a)

17 years agoAdd reference to example mysql.dump file
Jelmer Vernooij [Sat, 15 Feb 2003 01:08:08 +0000 (01:08 +0000)]
Add reference to example mysql.dump file
(This used to be commit ed46cb9e64e5c58cef6e2469438bacaae9dcdce8)

17 years agoAntti Andreimann <Antti.Andreimann@mail.ee> has done some changes to enable
Andrew Bartlett [Sat, 15 Feb 2003 00:29:21 +0000 (00:29 +0000)]
Antti Andreimann <Antti.Andreimann@mail.ee> has done some changes to enable
users w/o full administrative access on computer accounts to join a
computer into AD domain.

The patch and detailed changelog is available at:
http://www.itcollege.ee/~aandreim/samba

This is a list of changes in general:

1. When creating machine account do not fail if SD cannot be changed.
   setting SD is not mandatory and join will work perfectly without it.
2. Implement KPASSWD CHANGEPW protocol for changing trust password so
   machine account does not need to have reset password right for itself.
3. Command line utilities no longer interfere with user's existing
   kerberos ticket cache.
4. Command line utilities can do kerberos authentication even if
   username is specified (-U). Initial TGT will be requested in this case.

I've modified the patch to share the kinit code, rather than copying it,
and updated it to current CVS.  The other change included in the original patch
(local realms) has been left out for now.

Andrew Bartlett
(This used to be commit ce52f1c2ed4d3ddafe8ae6258c90b90fa434fe43)

17 years agoMove our NTLMSSP code into easily seperated peices, not relying on the whole
Andrew Bartlett [Sat, 15 Feb 2003 00:10:09 +0000 (00:10 +0000)]
Move our NTLMSSP code into easily seperated peices, not relying on the whole
of libsmb.

Andrew Bartlett
(This used to be commit b5ec7efa80478187124c1cfa8c7fcc4036506a37)

17 years agoOops, forgot the header file changes.
Andrew Bartlett [Fri, 14 Feb 2003 23:34:32 +0000 (23:34 +0000)]
Oops, forgot the header file changes.
(This used to be commit 5492fc1144abac74959b7e0938ce1bb387fa7429)

17 years agoNTLMSSP parinoia - we really don't want to run over the end of our blob,
Andrew Bartlett [Fri, 14 Feb 2003 23:13:05 +0000 (23:13 +0000)]
NTLMSSP parinoia - we really don't want to run over the end of our blob,
and make sure we can never get an 'authenticate' packet without a challenge.

Andrew Bartlett
(This used to be commit 4d94f8e6912c1339515cd1f68d1b698e7c699626)

17 years agoEnsure that only parse_prs.c access internal members of the prs_struct.
Jeremy Allison [Fri, 14 Feb 2003 23:04:03 +0000 (23:04 +0000)]
Ensure that only parse_prs.c access internal members of the prs_struct.
Needed to move to disk based i/o later.
Jeremy.
(This used to be commit 4c3ee228fcdb089eaeead95e79532a9cf6cb0de6)

17 years agooff by one bug in string length; CR 1159
Gerald Carter [Fri, 14 Feb 2003 22:24:49 +0000 (22:24 +0000)]
off by one bug in string length; CR 1159
(This used to be commit 4b5b0bcd9092a6003e3494dda949e03e803ec0aa)

17 years agoPut dynrpc modules as part of make all, when specified in configure.
Jim McDonough [Fri, 14 Feb 2003 20:10:43 +0000 (20:10 +0000)]
Put dynrpc modules as part of make all, when specified in configure.
(This used to be commit b44be1c7c4b8c7a8c1d35fe8b24aeff0ff0af32b)

17 years agoFurther extract our NTLMv2 code into smbencrypt.c, prior to merge into our
Andrew Bartlett [Fri, 14 Feb 2003 10:47:07 +0000 (10:47 +0000)]
Further extract our NTLMv2 code into smbencrypt.c, prior to merge into our
NTLMSSP client code.

Andrew Bartlett
(This used to be commit eaa8e7d1f82b30e7af14a0a58d7ca3eb66a06053)

17 years agoDoc
Martin Pool [Fri, 14 Feb 2003 06:34:59 +0000 (06:34 +0000)]
Doc
(This used to be commit 11c1e712d48438bd80c4f347a2f31e308bd54d7a)

17 years agoSimplify some return values in gencache functions:
Tim Potter [Fri, 14 Feb 2003 05:07:05 +0000 (05:07 +0000)]
Simplify some return values in gencache functions:

- return ret == 0 ? True : False;
+ return ret == 0;

and

- return tdb_close(cache) ? False : True;
+ return tdb_close(cache) != -1;
(This used to be commit 026b988b132ec76fdd3821639960658e1d36cd43)

17 years agoFix for trusted domains scan not working inspired by Ken Cross.
Tim Potter [Fri, 14 Feb 2003 00:23:31 +0000 (00:23 +0000)]
Fix for trusted domains scan not working inspired by Ken Cross.

(Sorry - I should have checked this in yesterday but forgot)
(This used to be commit 7420ddcda8e7189cedacb2c60f5ea265b8c35bda)

17 years agoA few typo fixes Andrew eventually let off to me.
Rafal Szczesniak [Thu, 13 Feb 2003 21:40:35 +0000 (21:40 +0000)]
A few typo fixes Andrew eventually let off to me.

Rafal
(This used to be commit 16a66cf17a544a214b7c5b483c81c7568a18a779)

17 years agoRemoved unused variable.
Jeremy Allison [Thu, 13 Feb 2003 19:42:50 +0000 (19:42 +0000)]
Removed unused variable.
Jeremy.
(This used to be commit c9654c8ec71903c59ff5f66c3fd6ea1baa599133)

17 years agoFix typo in WIFSIGNALED (as per Waider's report)
Alexander Bokovoy [Thu, 13 Feb 2003 16:29:12 +0000 (16:29 +0000)]
Fix typo in WIFSIGNALED (as per Waider's report)
(This used to be commit 4463ffeed91163314d2d903a271b29e87edaadcf)

17 years agoMerge JohnR's patch.
Jeremy Allison [Thu, 13 Feb 2003 06:52:45 +0000 (06:52 +0000)]
Merge JohnR's patch.
Removed extra copy of server name in the printername field (it was
mangling the the name to be \\server\\\server\printer ... yes, there
were 3 backslashes) reported by get & enum jobs level 2.
Jeremy.
(This used to be commit d079edf7327acba7f00b5868e7e6ce91ddc1eb14)

17 years agoAdd FIXME about checking exit code for popen'd commands.
Martin Pool [Thu, 13 Feb 2003 04:46:55 +0000 (04:46 +0000)]
Add FIXME about checking exit code for popen'd commands.

Fix typo.
(This used to be commit 2b5664823e05e328c86051fb607182ad20d786d4)

17 years agowaitstatus audit: Correctly handle case where smbmnt is killed by a
Martin Pool [Thu, 13 Feb 2003 04:45:40 +0000 (04:45 +0000)]
waitstatus audit: Correctly handle case where smbmnt is killed by a
signal.  Previously this was incorrectly treated as success.
(This used to be commit fe5582c1b2e1c6a6ed5e048dd169a1fcf908069c)

17 years agoDoc
Martin Pool [Thu, 13 Feb 2003 01:05:56 +0000 (01:05 +0000)]
Doc

Set HTML output directory
(This used to be commit 38b5a219eeec128db4630a9fb8d0615324cc74e7)

17 years agoUpdate towards automatic building on dp.samba.org:
Martin Pool [Thu, 13 Feb 2003 00:37:35 +0000 (00:37 +0000)]
Update towards automatic building on dp.samba.org:

Remove features not supported by Doxygen 1.2.14 on RH7.3.

Remove dependence on dot tool, which is apparently not in Redhat, and
doesn't produce very interesting results for C code anyhow.

Make Doxygen --quiet to support running from cron.

Remove references to files which are gone from Samba
(CodingSuggestions).

Put HTML output in the right directory.
(This used to be commit 5904260f4842adb36e30b36b37cf7e6ed1bc03f2)

17 years agoAdded code based on Michael Steffens <michael.steffens@hp.com> uid/gid
Jeremy Allison [Wed, 12 Feb 2003 23:51:05 +0000 (23:51 +0000)]
Added code based on Michael Steffens <michael.steffens@hp.com> uid/gid
caching code. Reduces load on winbindd. Probably should be moved to
use gencache at some future date.
Jeremy.
(This used to be commit 19f577e23ba3dd9101fb3e77a729906fdb8f5df7)

17 years agoFixes for HPUX only having limited POSIX lock range from Michael Steffens <michael...
Jeremy Allison [Wed, 12 Feb 2003 20:38:02 +0000 (20:38 +0000)]
Fixes for HPUX only having limited POSIX lock range from Michael Steffens <michael.steffens@hp.com>
Jeremy.
(This used to be commit ba0f47f78db488bd8dcd59023f48aa77a1cb2c27)

17 years agoadding more descriptions for nt status codes
Gerald Carter [Wed, 12 Feb 2003 16:43:47 +0000 (16:43 +0000)]
adding more descriptions for nt status codes
(This used to be commit dfceb0aab5d97df5b6b744143db254656398f0e9)

17 years agoMatch Samba 2.2 by chosing the correct desired access, and getting cupsaddsmb
Andrew Bartlett [Wed, 12 Feb 2003 11:17:35 +0000 (11:17 +0000)]
Match Samba 2.2 by chosing the correct desired access, and getting cupsaddsmb
back working again.

Andrew Bartlett
(This used to be commit 512e65a6a6ac5ee97edf1868007db20bb144857f)

17 years agoinitial server side privileges implementation, using a tdb. This needs to be hooked...
Andrew Tridgell [Wed, 12 Feb 2003 09:14:35 +0000 (09:14 +0000)]
initial server side privileges implementation, using a tdb. This needs to be hooked into pdb, and we need some access control on changing privileges. That's next
(This used to be commit f4f1f84a6bf1d356ccc83f0ecb135bef4a39619e)

17 years agoPrevent NULL-pointer induced segfaults.
Andrew Bartlett [Wed, 12 Feb 2003 06:38:18 +0000 (06:38 +0000)]
Prevent NULL-pointer induced segfaults.

Is tdb_pack in appliance_head different for some reason?

Andrew Bartlett
(This used to be commit 9deb14a2e63fa71a05915b5ab865b8d0c11df098)

17 years agoCorrectly return access denied on share mode deny when we can't open the
Jeremy Allison [Wed, 12 Feb 2003 01:12:33 +0000 (01:12 +0000)]
Correctly return access denied on share mode deny when we can't open the
file. This is a regression that was damaged by other code.
Jeremy.
(This used to be commit 5cdc957ea6335d8bb4248065a3b60a0a26e766a8)

17 years agosetup the %U substitution in winbindd for the homedir template
Andrew Tridgell [Wed, 12 Feb 2003 00:56:14 +0000 (00:56 +0000)]
setup the %U substitution in winbindd for the homedir template
(This used to be commit 6186c10ceb2e61cd684968b56d3f32d9916538f8)

17 years agoadd a note about relative opens with blank paths - its a re-open!
Andrew Tridgell [Wed, 12 Feb 2003 00:41:35 +0000 (00:41 +0000)]
add a note about relative opens with blank paths - its a re-open!
(not implemented yet)
(This used to be commit bceac9cdde04a57d661b6a7ece329fa6d5a169bd)

17 years agoadd a note about a better method for finding netbios name of workgroup
Andrew Tridgell [Wed, 12 Feb 2003 00:40:41 +0000 (00:40 +0000)]
add a note about a better method for finding netbios name of workgroup
(not implemented yet)
(This used to be commit 8a8cca78adebba640c6ce971d8888515bf0ea4be)

17 years agopull_ucs2_talloc() should pull to a char**, not a void**
Andrew Tridgell [Wed, 12 Feb 2003 00:39:36 +0000 (00:39 +0000)]
pull_ucs2_talloc() should pull to a char**, not a void**
(This used to be commit 3cf539421fa2a5c276baeedbdbf42ced29d9f1e4)

17 years agoremoved a duplicate copy of smb_io_sid_array()
Andrew Tridgell [Tue, 11 Feb 2003 22:53:57 +0000 (22:53 +0000)]
removed a duplicate copy of smb_io_sid_array()
(This used to be commit 2ef72f95003cebf2ff56e47f16fb8be0e8032042)

17 years agoadded server stubs for lsa_enum_acct_with_right
Andrew Tridgell [Tue, 11 Feb 2003 21:55:48 +0000 (21:55 +0000)]
added server stubs for lsa_enum_acct_with_right
(This used to be commit aa2abacaf48924797b6803786c14c9f303185e4a)

17 years agoPatch from Anthony Liguori <aliguor@us.ibm.com> to remove scandir() portability
Andrew Bartlett [Tue, 11 Feb 2003 21:54:36 +0000 (21:54 +0000)]
Patch from Anthony Liguori <aliguor@us.ibm.com> to remove scandir() portability
madness.

Andrew Bartlett
(This used to be commit 7836b9a58d158a54a7326b3de5d2fa757a9bb5b6)

17 years agoremove trailing 'a' from VFS_MODULES targets...fix build
Jim McDonough [Tue, 11 Feb 2003 19:57:17 +0000 (19:57 +0000)]
remove trailing 'a' from VFS_MODULES targets...fix build
(This used to be commit fa4961b1fc9f0ab2a1c32c56c6200d86a61093c9)

17 years agoFixup delete on close torture.
Jeremy Allison [Tue, 11 Feb 2003 02:29:04 +0000 (02:29 +0000)]
Fixup delete on close torture.
Jeremy.
(This used to be commit b031e81f4f4d5dc10e792c216d269b49569f5af9)

17 years agoFix delete on close semantics to match W2K. I (think:-) I understand it now :-).
Jeremy Allison [Tue, 11 Feb 2003 02:24:45 +0000 (02:24 +0000)]
Fix delete on close semantics to match W2K. I (think:-) I understand it now :-).
Thanks to Nir Livni <nirl@cyber-ark.com> for giving me the test case to
track it down.
Jeremy.
(This used to be commit c98ebb3031649203e607264ecb15722adf55af58)

17 years agoFix the msdfs proxy handling code in dfsenum to return the cumulative number of
Shirish Kalele [Tue, 11 Feb 2003 01:45:15 +0000 (01:45 +0000)]
Fix the msdfs proxy handling code in dfsenum to return the cumulative number of
dfs links encountered. Previously the number was being mistakenly reset to 1.
Thanks to Guenther Deschner <gd@suse.de> for pointing this out and a fix.
[Check into HEAD]
(This used to be commit 9307942a89600004ae3467b1bbf0dc536698ecdf)

17 years agoautogen - cope with autoconf-2.53/2.13 systems (like RH 7.3)
Gerald Carter [Mon, 10 Feb 2003 17:30:20 +0000 (17:30 +0000)]
autogen - cope with autoconf-2.53/2.13 systems (like RH 7.3)
findsmb - use @PERL@
(This used to be commit 15853857299c0de37b9cb736bb99928526924608)

17 years agoFix a mistake spotted by Metze
Richard Sharpe [Mon, 10 Feb 2003 16:42:24 +0000 (16:42 +0000)]
Fix a mistake spotted by Metze
(This used to be commit cf167e9249fee0ea871c0dac28e9a21aeeebd614)

17 years agoClean up our NTLMv2 code by moving the grunt work into a helper function.
Andrew Bartlett [Mon, 10 Feb 2003 12:22:57 +0000 (12:22 +0000)]
Clean up our NTLMv2 code by moving the grunt work into a helper function.

Andrew Bartlett
(This used to be commit 6789e237d7b070624ba09e7ed43680b838337b74)

17 years agoadded the 'lsaenumacctwithright' command to rpcclient. This allows you
Andrew Tridgell [Mon, 10 Feb 2003 11:31:23 +0000 (11:31 +0000)]
added the 'lsaenumacctwithright' command to rpcclient. This allows you
to lookup what SIDs have a particular privilege (that is how
privileges are stored).
(This used to be commit 3ddb5fb0dd33992b7db54a661752551a3fefc0b4)

17 years agoAs metze mentioned, this is the proper way to find perl...
Andrew Bartlett [Mon, 10 Feb 2003 10:36:09 +0000 (10:36 +0000)]
As metze mentioned, this is the proper way to find perl...

Andrew Bartlett
(This used to be commit f364921864bf4c33580c432f0d328c7ffc48a7df)

17 years agoperl might not be in /usr/bin/perl, so try and find it in the path.
Andrew Bartlett [Mon, 10 Feb 2003 09:23:30 +0000 (09:23 +0000)]
perl might not be in /usr/bin/perl, so try and find it in the path.

Perhaps this generated file should be autobuilt on samba.org for the
build farm and the tarballs.

Andrew Bartlett
(This used to be commit b8a07da68053b3eebb4f8c9ca9e620a67c878d15)

17 years agoUse safe_strcpy() instead of pstrcpy() for malloced strings.
Andrew Bartlett [Mon, 10 Feb 2003 09:20:09 +0000 (09:20 +0000)]
Use safe_strcpy() instead of pstrcpy() for malloced strings.

Andrew Bartlett
(This used to be commit 333d313c9d047697d7a8a519fdbc2b7da06745c2)

17 years agoFailure to find a CUPS printer, when auto-adding printers is not a level 0 error.
Andrew Bartlett [Mon, 10 Feb 2003 09:18:04 +0000 (09:18 +0000)]
Failure to find a CUPS printer, when auto-adding printers is not a level 0 error.

Andrew Bartlett
(This used to be commit 79650e08c9f1cbf66979adf2575d8b04e06fe4e7)

17 years agoSome cleanups:
Andrew Bartlett [Mon, 10 Feb 2003 09:16:05 +0000 (09:16 +0000)]
Some cleanups:

- Don't use pstrcpy into an allocated string - use safe_strcpy() directly
instead.

- Keep a copy of the 'server_info' attached to the vuid.  In future use this
for things like the session key, homedir and full name instead of current
copies.

- Try to avoid memory leak/segfault on Realloc failure

- clear up #endif comments

Andrew Bartlett
(This used to be commit 162477bb086827950b6cb71afa9bef62c2753c2e)

17 years ago(only for HEAD at the moment).
Andrew Bartlett [Sun, 9 Feb 2003 12:26:58 +0000 (12:26 +0000)]
(only for HEAD at the moment).

Add NTLMv2 support to our client, used when so configured ('client use NTLMv2 =
yes') and only when 'client use spengo = no'.  (A new option to allow the
client and server ends to chose spnego seperatly).

NTLMv2 signing doesn't yet work, and NTLMv2 is not done for NTLMSSP yet.

Also some parinoia checks in our input parsing.

Andrew Bartlett
(This used to be commit 85e9c060eab59c7692198f14a447ad59f05af437)

17 years agoEnsure we return NOSPACE if we can't fast allocate a print job.
Jeremy Allison [Sat, 8 Feb 2003 01:04:26 +0000 (01:04 +0000)]
Ensure we return NOSPACE if we can't fast allocate a print job.
Jeremy.
(This used to be commit 9cd29f2bacd7c61f82f799e97f93d88f98f9ece6)

17 years agoOne more fix for the difference between FILE and X_FILE.
Andrew Bartlett [Sat, 8 Feb 2003 01:00:55 +0000 (01:00 +0000)]
One more fix for the difference between FILE and X_FILE.
(This used to be commit 7e56014b2877cde489913310edbfd16c267d9859)

17 years agoEnsure we don't get problems between FILE and X_FILE buffers - always use the
Andrew Bartlett [Fri, 7 Feb 2003 23:39:47 +0000 (23:39 +0000)]
Ensure we don't get problems between FILE and X_FILE buffers - always use the
x_ varient of the command.

Andrew Bartlett
(This used to be commit 6a028507f0d5eadd2ec0a5b45c35e3a019a56f0b)

17 years agoSamba janitors: applying mbp's redundant umask fix.
Jeremy Allison [Fri, 7 Feb 2003 22:52:35 +0000 (22:52 +0000)]
Samba janitors: applying mbp's redundant umask fix.
Jeremy.
(This used to be commit 45d4e58ca5da1c01f135470257bb17a5257e6fb2)

17 years agoSamba janitor: adding mbp's umask patch :-).
Jeremy Allison [Fri, 7 Feb 2003 21:59:42 +0000 (21:59 +0000)]
Samba janitor: adding mbp's umask patch :-).
Jeremy.
(This used to be commit babbbd9c651e044832a78aa0fbcee5afd73770e2)

17 years agocheck pointer before dereferencing it
Gerald Carter [Fri, 7 Feb 2003 16:20:58 +0000 (16:20 +0000)]
check pointer before dereferencing it
(This used to be commit 786d91d75c909f6d407b8466c89181f26e62e68f)

17 years agoRevert Flag testing upon abartlet's request ;-)
Volker Lendecke [Fri, 7 Feb 2003 08:02:18 +0000 (08:02 +0000)]
Revert Flag testing upon abartlet's request ;-)

Volker
(This used to be commit e8f751fe84cbd20934116d5213f9bb1850aa9dfa)

17 years agoAdded extended audit module that logs to smbd log as well as syslog.
John Terpstra [Fri, 7 Feb 2003 05:00:34 +0000 (05:00 +0000)]
Added extended audit module that logs to smbd log as well as syslog.
(This used to be commit d2fe7e38b287b87d6c76a9b73724118928941e93)

17 years agomake sure we don't run over the end of 'name' in unix_convert()
Andrew Tridgell [Fri, 7 Feb 2003 04:01:36 +0000 (04:01 +0000)]
make sure we don't run over the end of 'name' in unix_convert()

Thanks to Andrew Bartlett for spotting this.
(This used to be commit b4c210ccb05e71a8ddf1c25d028452dd5cd93c72)

17 years agoMake account flags editable with pdbedit.
Volker Lendecke [Thu, 6 Feb 2003 16:53:58 +0000 (16:53 +0000)]
Make account flags editable with pdbedit.

Volker
(This used to be commit 597c50550955c5bdc0c646d5b751d377b40f3485)

17 years agoignore config.h.in in cvs as generated by autoheader
Andrew Tridgell [Thu, 6 Feb 2003 09:55:21 +0000 (09:55 +0000)]
ignore config.h.in in cvs as generated by autoheader
(This used to be commit 830423abd843dd20535755f910bc1e9563a0774f)

17 years agoignore configure in cvs
Andrew Tridgell [Thu, 6 Feb 2003 09:54:51 +0000 (09:54 +0000)]
ignore configure in cvs
(This used to be commit 0a5ed634d8d8999cc957d4917563ec3c174c311d)

17 years agoRemove configure and config.h.in from CVS.
Andrew Bartlett [Thu, 6 Feb 2003 09:20:32 +0000 (09:20 +0000)]
Remove configure and config.h.in from CVS.

configure and config.h.in is now regenerated by the 'autogen.sh' script.

However, samba.org will run autoconf and autoheader to keep the anonyomous
rsync 'unpacked' areas intact (helping the build farm), and released will ship
with the genereated files.

Andrew Bartlett
(This used to be commit 15bba73dea51a6394294fc627933d026d6002091)