Andrew Tridgell [Tue, 14 Dec 2004 22:18:33 +0000 (22:18 +0000)]
r4206: fixed a status code check in lsa_LookupNames2 that could cause a segv
Andrew Tridgell [Tue, 14 Dec 2004 22:17:41 +0000 (22:17 +0000)]
r4205: fixed the default acl mapping from posix permissions to use the mapped
uid->sid and gid->sid
Jelmer Vernooij [Tue, 14 Dec 2004 20:49:18 +0000 (20:49 +0000)]
r4204: Arguments to reg_del_key more like the RPC for more efficient usage
Fix small bug in regpatch
Fix segfault in regshell cmdline completion
Implement set_value and del_value in ldb backend
Stefan Metzmacher [Tue, 14 Dec 2004 07:18:58 +0000 (07:18 +0000)]
r4203: the bind_info blob isn't a const.
here's the idl to parse it, because we don't want the
callers to manually de/encode this
metze
Andrew Tridgell [Tue, 14 Dec 2004 06:31:20 +0000 (06:31 +0000)]
r4202: added smbclient commands "addprivileges" and "delprivileges" for
easily adding/removing privileges from users
Tim Potter [Tue, 14 Dec 2004 06:25:19 +0000 (06:25 +0000)]
r4201: Remove duplicate const.
Tim Potter [Tue, 14 Dec 2004 06:23:01 +0000 (06:23 +0000)]
r4200: Fix some more warnings.
Andrew Tridgell [Tue, 14 Dec 2004 06:17:33 +0000 (06:17 +0000)]
r4199: - added server side code for lsa_RemoveAccountRights (sharing code
with lsa_AddAccountRights)
Andrew Tridgell [Tue, 14 Dec 2004 06:10:45 +0000 (06:10 +0000)]
r4198: - added server side code for lsa_AddAccountRights
Tim Potter [Tue, 14 Dec 2004 06:09:04 +0000 (06:09 +0000)]
r4197: Remove silly extra const.
Andrew Tridgell [Tue, 14 Dec 2004 05:51:01 +0000 (05:51 +0000)]
r4196: - added server side code for lsa_LookupPrivDisplayName
- added english descriptions of privileges. We should add other
languages in the future.
Andrew Tridgell [Tue, 14 Dec 2004 05:32:51 +0000 (05:32 +0000)]
r4195: added IDL, test suite and server side code for lsa_LookupPrivValue
Andrew Tridgell [Tue, 14 Dec 2004 05:20:38 +0000 (05:20 +0000)]
r4194: added server side implementation of lsa_EnumPrivs
Andrew Tridgell [Tue, 14 Dec 2004 05:07:29 +0000 (05:07 +0000)]
r4193: added server side implementation of lsa_EnumAccountsWithUserRight
Andrew Tridgell [Tue, 14 Dec 2004 04:45:00 +0000 (04:45 +0000)]
r4192: added server side implementation of lsa_EnumAccountRights
the "privilege" command in smbclient now works against Samba4
Andrew Tridgell [Mon, 13 Dec 2004 23:58:39 +0000 (23:58 +0000)]
r4183: expanded the RAW-MKDIR torture test to test creation of EA lists
Andrew Tridgell [Mon, 13 Dec 2004 23:57:59 +0000 (23:57 +0000)]
r4182: fixed trans2 mkdir, allowing mkdir with an initial EA list
Stefan Metzmacher [Mon, 13 Dec 2004 12:34:43 +0000 (12:34 +0000)]
r4181: use int32 for level
metze
Stefan Metzmacher [Mon, 13 Dec 2004 12:28:47 +0000 (12:28 +0000)]
r4180: use the same syntax as the other torture tests
metze
Stefan Metzmacher [Mon, 13 Dec 2004 12:24:57 +0000 (12:24 +0000)]
r4179: - nicer code layout
- and disable DsReplicaSync by default it kill lsass.exe
on my w2k box
metze
Stefan Metzmacher [Mon, 13 Dec 2004 12:01:43 +0000 (12:01 +0000)]
r4178: the level is mostly singed not unsigned
metze
Stefan Metzmacher [Mon, 13 Dec 2004 11:37:47 +0000 (11:37 +0000)]
r4177: add some more error codes
metze
Stefan Metzmacher [Mon, 13 Dec 2004 11:34:57 +0000 (11:34 +0000)]
r4176: I just remeber that I have already implement STR_CONFORMANT
so use it in DsReplicaSync()
metze
Jelmer Vernooij [Mon, 13 Dec 2004 11:00:24 +0000 (11:00 +0000)]
r4175: InitiateSystemShutdownEx IDL and torture test
Stefan Metzmacher [Mon, 13 Dec 2004 10:48:35 +0000 (10:48 +0000)]
r4174: nicer debug output
metze
Andrew Tridgell [Mon, 13 Dec 2004 10:48:21 +0000 (10:48 +0000)]
r4173: - new t2open code, that can cope with "create with EAs". Many thanks
to kukks on #samba-technical for the sniffs that allowed me to work
this out
- much simpler ntvfs open generic mapping code
- added t2open create with EA torture test to RAW-OPEN test
Stefan Metzmacher [Mon, 13 Dec 2004 10:29:44 +0000 (10:29 +0000)]
r4172: commit a DsReplicaSync() torture test
this not make much sense as we don't send the correct nc_name
but it shows that doesn't get a NDR_FAULT anymore,
we just need handle the conformant strings in pidl
metze
Andrew Tridgell [Mon, 13 Dec 2004 09:32:57 +0000 (09:32 +0000)]
r4171: an attempt at better IDL for DsReplicaSync
Andrew Tridgell [Mon, 13 Dec 2004 09:32:02 +0000 (09:32 +0000)]
r4170: don't check array size for conformant arrays (they are checked separately)
Stefan Metzmacher [Mon, 13 Dec 2004 09:26:13 +0000 (09:26 +0000)]
r4169: add descriptions about binding and unc strings to the
smbtorture --usage --help output
metze
Jelmer Vernooij [Mon, 13 Dec 2004 02:04:34 +0000 (02:04 +0000)]
r4168: Implement QueryValue in the server
IDL for NotifyChangeKeyValue
Jelmer Vernooij [Mon, 13 Dec 2004 01:37:18 +0000 (01:37 +0000)]
r4167: Fix CreateKey
Support CreateKey in the RPC registry backend
Jelmer Vernooij [Mon, 13 Dec 2004 00:45:29 +0000 (00:45 +0000)]
r4166: More small API fixes, keep registry structs as small as possible.
Implement DelValue in the RPC server
Andrew Tridgell [Sun, 12 Dec 2004 11:30:30 +0000 (11:30 +0000)]
r4165: added a 100 element name cache to cope with some amount of seeking
back to filenames that have been deleted. This fixes the new os/2
delete test.
Andrew Tridgell [Sun, 12 Dec 2004 11:29:35 +0000 (11:29 +0000)]
r4164: added a test that simulates a OS/2 file delete. This includes seek by
name back into a directory for files that no longer exist.
Andrew Tridgell [Sun, 12 Dec 2004 09:11:39 +0000 (09:11 +0000)]
r4163: 2nd attempt at fixing the OS/2 "del *" problem
Andrew Tridgell [Sun, 12 Dec 2004 09:02:18 +0000 (09:02 +0000)]
r4162: this should fix the delete/findnext problem from OS/2 clients. Thanks
again to kukks for the excellent and detailed bug report
Andrew Tridgell [Sun, 12 Dec 2004 08:35:11 +0000 (08:35 +0000)]
r4161: two more fixes for NT4 clients. Bugs found by kukks.
- nt4 doesn't setup the pfc flags correctly for rpc packet types
other than normal requests, so don't check for fragmented packets
unless they are of type request
- ensure we give STATUS_BUFFER_OVERFLOW when we return a partial
fragment in SMBtrans requests on ncacn_np
Andrew Tridgell [Sun, 12 Dec 2004 08:33:08 +0000 (08:33 +0000)]
r4160: fixed the file_type in ntcreatex reply on a named pipe. NT4 requires this to be right.
Andrew Tridgell [Sun, 12 Dec 2004 07:22:59 +0000 (07:22 +0000)]
r4159: fixed error return for writebraw
Jelmer Vernooij [Sun, 12 Dec 2004 00:35:50 +0000 (00:35 +0000)]
r4158: Fix IDL for InitiateShutdown and AbortShutdown and run both only
when dangerous tests are enabled.
Jelmer Vernooij [Sun, 12 Dec 2004 00:22:30 +0000 (00:22 +0000)]
r4157: QueryMultipleValues IDL and torture test
Initialisation data pointer in QueryValue torture test
Jelmer Vernooij [Sat, 11 Dec 2004 23:28:48 +0000 (23:28 +0000)]
r4156: GetKeySecurity() IDL and torture test
Jelmer Vernooij [Sat, 11 Dec 2004 20:06:40 +0000 (20:06 +0000)]
r4155: More destinction between hives and predefined keys
Jelmer Vernooij [Sat, 11 Dec 2004 17:12:16 +0000 (17:12 +0000)]
r4154: Add definitions for HKEY_PERFORMANCE_TEXT and HKEY_PERFORMANCE_NLSTEXT
Hives and predefined keys (HKEY_*) are not necessarily the same thing.
Andrew Tridgell [Sat, 11 Dec 2004 13:19:41 +0000 (13:19 +0000)]
r4151: added privilege attribute handling on samdb.
pvfs will now honor some privileges on ACLs, and it will be quite easy
to add the checks for more privileges in the necessary places, by
making calls to sec_privilege_check().
Andrew Tridgell [Sat, 11 Dec 2004 12:01:20 +0000 (12:01 +0000)]
r4150: - add fns for manipulating the privilege_mask in a security_token
- add the hooks in access_check that check the privilege bitmasks for
SEC_STD_DELETE and SEC_FLAG_SYSTEM_SECURITY
Andrew Tridgell [Sat, 11 Dec 2004 05:43:03 +0000 (05:43 +0000)]
r4148: add a default set of privileges to the core builtin accounts in the
sam. I decided to do it the simple way of making the privileges user
attributes. w2k doesn't expose the privileges via LDAP, so we are free
to store them in any way we like without breaking compatibility.
Andrew Tridgell [Sat, 11 Dec 2004 05:41:19 +0000 (05:41 +0000)]
r4147: converted from NT_USER_TOKEN to struct security_token
this is mostly just a tidyup, but also adds the privilege_mask, which
I will be using shortly in ACL checking.
note that I had to move the definition of struct security_token out of
security.idl as pidl doesn't yet handle arrays of pointers, and the
usual workaround (to use a intermediate structure) would make things
too cumbersome for this structure, especially given we never encode it
to NDR.
Andrew Tridgell [Sat, 11 Dec 2004 04:11:26 +0000 (04:11 +0000)]
r4146: an attempted fix for a OS/2 rename problem found by kukks - seems OS/2
is v senstive to SMB flags2 bits
Andrew Tridgell [Sat, 11 Dec 2004 03:39:09 +0000 (03:39 +0000)]
r4145: make sure we don't set the 32-bit error codes flag unless the client
can handle it, even for success packets (this bug was harmless, but
can be confusing in ethereal with old clients)
Jelmer Vernooij [Fri, 10 Dec 2004 23:20:24 +0000 (23:20 +0000)]
r4142: Check result value of OpenHKU and OpenHKCR
Jelmer Vernooij [Fri, 10 Dec 2004 23:13:17 +0000 (23:13 +0000)]
r4141: Fix crash bug in ldb backend
Jelmer Vernooij [Fri, 10 Dec 2004 22:57:43 +0000 (22:57 +0000)]
r4140: Get rid of close_hive (replace it with talloc destructors).
Andrew Tridgell [Fri, 10 Dec 2004 22:36:46 +0000 (22:36 +0000)]
r4139: 2nd attempt at fixing the null ptr in size_is() problem.
Andrew Tridgell [Fri, 10 Dec 2004 22:35:35 +0000 (22:35 +0000)]
r4138: initialise 'type' in RPC-WINREG EnumValue test
Jelmer Vernooij [Fri, 10 Dec 2004 22:28:49 +0000 (22:28 +0000)]
r4137: Make *_open_key take a registry_key instead of a hive (more efficient
in some cases)
Andrew Tridgell [Fri, 10 Dec 2004 22:16:35 +0000 (22:16 +0000)]
r4136: when we have a size or switch variable that is a pointer we need to check that the server
hasn't given us a null pointer, otherwise we can segv when we dereference it. For example:
[size_is(*size)] *x;
uint32 *size;
if a broken server gave us x != NULL and size == NULL then we would crash. I've added
a check_null_pointer() call in pidl to catch this.
Andrew Tridgell [Fri, 10 Dec 2004 21:31:32 +0000 (21:31 +0000)]
r4135: improve a debug message
Jelmer Vernooij [Fri, 10 Dec 2004 20:50:49 +0000 (20:50 +0000)]
r4133: Cache results of subkey and value queries
Jelmer Vernooij [Fri, 10 Dec 2004 20:07:04 +0000 (20:07 +0000)]
r4132: - Bunch of rather large fixes in the registry
- Added some README files
Not everything works yet, e.g. the EnumValue test appears to be broken.
Andrew Tridgell [Fri, 10 Dec 2004 04:41:56 +0000 (04:41 +0000)]
r4124: include locale.h to get LC_ALL in include/system/iconv.h
Andrew Tridgell [Fri, 10 Dec 2004 03:41:54 +0000 (03:41 +0000)]
r4123: set locale to C to ensure ascii string functions work
thanks to Bjoern JACKE <samba@j3e.de> for pointing this out
Andrew Tridgell [Thu, 9 Dec 2004 12:54:01 +0000 (12:54 +0000)]
r4118: don't assume that "unsigned int" is the same type as uint32_t
Andrew Tridgell [Thu, 9 Dec 2004 12:50:50 +0000 (12:50 +0000)]
r4117: fixed EnumValue in winreg server
Andrew Tridgell [Thu, 9 Dec 2004 12:42:29 +0000 (12:42 +0000)]
r4116: fixed compilation of EnumValue code in winreg rpc backend
thanks to volker for pointing this out
Andrew Tridgell [Thu, 9 Dec 2004 10:33:21 +0000 (10:33 +0000)]
r4115: check for gensec errors before calling memcpy on a set of credentials,
otherwise the creds structure might be invalid
Andrew Tridgell [Thu, 9 Dec 2004 10:32:43 +0000 (10:32 +0000)]
r4114: added have_features bits to gensec schannel code. This fixes our
schannel code.
I would also like to give a gentle reminder to everyone to please run
the appropriate test scripts when you change a subsystem. It's a shame
to have this test code and not use it, and it takes much longer for
another developer to track down a bug in your new code than it would
take for you fix to it at the time you first add it.
- for rpc changes run test_rpc.sh
- for CIFS changes run test_posix.sh
- for ldb changes run test-tdb in lib/ldb/
Andrew Tridgell [Thu, 9 Dec 2004 07:52:00 +0000 (07:52 +0000)]
r4113: modified EnumValue in winreg to take advantage of the new pidl handling
of arrays.
Andrew Tridgell [Thu, 9 Dec 2004 07:51:20 +0000 (07:51 +0000)]
r4112: when a pointer is NULL on the wire ensure it is null in the structure
Andrew Tridgell [Thu, 9 Dec 2004 07:05:47 +0000 (07:05 +0000)]
r4111: fixed winreg to use much simpler (and I believe correct) IDL for QueryValue
Andrew Tridgell [Thu, 9 Dec 2004 07:05:00 +0000 (07:05 +0000)]
r4110: fixed pidl to allow arrays to have size_is() and length_is() elements
that depend on variables that come after the array in the structure or function.
This has been something that has been problematic for a while, but the
winreg QueryValue problem finally prompted me to fix it properly. We
should now go back and fix up all the ugly workarounds we have used to
avoid this problem in other calls.
Unfortunately the solution is fairly complex, and involves the use of
the internal ndr token lists (similar to the solution for relative
pointers). I wonder if anyone else will be able to follow the logic if
I get run over by a bus :-)
Andrew Tridgell [Thu, 9 Dec 2004 04:40:57 +0000 (04:40 +0000)]
r4109: fixed an uninitialised socket write found by kukks
Jelmer Vernooij [Wed, 8 Dec 2004 22:13:28 +0000 (22:13 +0000)]
r4106: Add full name of two more hives
Jelmer Vernooij [Wed, 8 Dec 2004 22:02:49 +0000 (22:02 +0000)]
r4105: Fix IDL for QueryValue() and add a torture test for it.
Thanks to Michael Allen for some hints on what was wrong with the previous IDL.
Stefan Metzmacher [Wed, 8 Dec 2004 11:30:26 +0000 (11:30 +0000)]
r4102: more uint64 vs HYPER_T fixes
NOTE:
[u]int64 uses 4 Byte alignment
and HYPER_T uses 8 Byte alignment
metze
Andrew Tridgell [Wed, 8 Dec 2004 11:02:47 +0000 (11:02 +0000)]
r4101: ignore secondary session requests to cope with a OS/2 bug reported by
Guenter Kukkukk
Stefan Metzmacher [Wed, 8 Dec 2004 10:54:09 +0000 (10:54 +0000)]
r4100: fix drsuapi_DsReplicaObjMetaData2() idl
(many thanks to tridge for telling me that HYPER_T isn't the same as uint64!)
metze
Tim Potter [Wed, 8 Dec 2004 10:36:14 +0000 (10:36 +0000)]
r4099: Spelling fixes.
Andrew Tridgell [Wed, 8 Dec 2004 10:24:10 +0000 (10:24 +0000)]
r4098: catch null guid string so RPC-DRSUAPI works against my server
Stefan Metzmacher [Wed, 8 Dec 2004 10:13:45 +0000 (10:13 +0000)]
r4097: add missing file from last commit
sorry!:-)
metze
Stefan Metzmacher [Wed, 8 Dec 2004 08:21:35 +0000 (08:21 +0000)]
r4096: move the samdb code to source/dsdb/
the idea is to have a directory service db layer
which will be used by the ldap server, samr server, drsuapi server
authentification...
I plan to make different implementations of this interface possible
- current default will be the current samdb code with sam.ldb
- a compat implementation for samba3 (if someone wants to write one)
- a new dsdb implementation which:
- understands naming contexts (directory parrtitions)
- do schema and acl checking checking
- maintain objectGUID, timestamps and USN number,
maybe linked attributes ('member' and 'memberOf' attributes)
- store metadata on a attribute=value combination...
metze
Andrew Tridgell [Wed, 8 Dec 2004 08:09:42 +0000 (08:09 +0000)]
r4095: smbsrv_terminate_connection() doesn't exit() in single processor mode, so after we
call it we need to return, and not continue processing packets
Stefan Metzmacher [Tue, 7 Dec 2004 12:20:28 +0000 (12:20 +0000)]
r4087: - add idl and torture tests for drsuapi_DsReplicaGetInfo()
(NOTE: that the drsuapi_DsReplicaObjMetaData2 struct is not corrently parsed yet
and there're some unknown fields left in someother infotypes)
metze
Stefan Metzmacher [Tue, 7 Dec 2004 09:26:00 +0000 (09:26 +0000)]
r4086: - make dcerpc_ndr_request_table_send() the default and rename it to just
dcerpc_ndr_request_send()
- this allows us to call dcerpc_log_packet() when we receive a packet we
can't parse correctly
metze
Stefan Metzmacher [Tue, 7 Dec 2004 09:21:13 +0000 (09:21 +0000)]
r4085: print out dcerpc_fault's as names
metze
Stefan Metzmacher [Tue, 7 Dec 2004 09:18:56 +0000 (09:18 +0000)]
r4084: add some more error codes
metze
Stefan Metzmacher [Mon, 6 Dec 2004 17:48:51 +0000 (17:48 +0000)]
r4082: support alter_context requests
metze
Stefan Metzmacher [Mon, 6 Dec 2004 17:44:33 +0000 (17:44 +0000)]
r4081: use clearer names
metze
Stefan Metzmacher [Mon, 6 Dec 2004 15:45:48 +0000 (15:45 +0000)]
r4080: missing file from the last commit
metze
Stefan Metzmacher [Mon, 6 Dec 2004 15:44:17 +0000 (15:44 +0000)]
r4079: implement the gensec_have_feature() correctly by asking
the backend what is actually in use
metze
Stefan Metzmacher [Mon, 6 Dec 2004 15:17:43 +0000 (15:17 +0000)]
r4078: use clearer names
metze
Stefan Metzmacher [Mon, 6 Dec 2004 15:14:42 +0000 (15:14 +0000)]
r4077: don't add wrapping to empty blobs
metze
Stefan Metzmacher [Mon, 6 Dec 2004 15:10:31 +0000 (15:10 +0000)]
r4076: fix compiler warning
metze
Stefan Metzmacher [Mon, 6 Dec 2004 11:10:15 +0000 (11:10 +0000)]
r4075: implement RemoteTOD server function
metze
Andrew Tridgell [Mon, 6 Dec 2004 07:13:50 +0000 (07:13 +0000)]
r4074: make the RAW-ACLS test use the new lsa helper functions to determine
the privileges of the user running the test. This allows the test to
work out what the expected access masks are.
Andrew Tridgell [Mon, 6 Dec 2004 07:12:38 +0000 (07:12 +0000)]
r4073: - added a set of lsa helper routines to make lsa lookups that are
related to filesharing. For example, in order to manipulate ACLs
properly its important to be able to call LookupSids, and to be able
to lookup what privileges a SID has.
- added 3 new commands to smbclient "lookupname", "lookupsid" and
"privileges"
Andrew Tridgell [Mon, 6 Dec 2004 07:10:25 +0000 (07:10 +0000)]
r4072: - changed the names of some of the well known sids to be more consistent
- added string constants for the important privileges.
Andrew Tridgell [Mon, 6 Dec 2004 06:45:51 +0000 (06:45 +0000)]
r4071: - ldap does allow adding additional attribute values with a modify
operation, but not if the value already exists
- fixed syntax of test.ldif for ldap backend
Stefan Metzmacher [Sun, 5 Dec 2004 16:29:27 +0000 (16:29 +0000)]
r4070: move some defines from asn_1.h to the places they belong to
metze