samba.git
10 years agodocs: Always declare rule to build parameters.all.xml and do it first
Andrew Bartlett [Wed, 15 Jan 2014 05:11:41 +0000 (18:11 +1300)]
docs: Always declare rule to build parameters.all.xml and do it first

This ensures this file and the rule to generate it can always be found.

Andrew Bartlett

Change-Id: I76d9f4470e2678fc2df4e3a13642737128938f3a
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of usershare path to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:32:32 +0000 (13:32 +1300)]
docs: change default of usershare path to use an entity

Change-Id: Idf9b8b95387f9b31b1cf8d3d548adb8361de0534
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of cache directory to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:18:14 +0000 (13:18 +1300)]
docs: change default of cache directory to use an entity

Change-Id: I555524324d671a30c8bfb130ba95e745492a50b2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of winbindd privileged socket directory to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:08:35 +0000 (13:08 +1300)]
docs: change default of winbindd privileged socket directory to use an entity

Change-Id: Ia520090dbad50a6d3fc5b7bdc1982cfc15174b16
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of samba kcc command to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:08:05 +0000 (13:08 +1300)]
docs: change default of samba kcc command to use an entity

Change-Id: I63c10ca0efc83496ffcd720edc00bd711ce53eac
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of ntp signd socket directory to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:07:48 +0000 (13:07 +1300)]
docs: change default of ntp signd socket directory to use an entity

Change-Id: Id66dcd5b587c4c355961d8e9d10cdf0d1e17a6ad
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default of spn update command to use an entity
Andrew Bartlett [Thu, 9 Jan 2014 00:07:33 +0000 (13:07 +1300)]
docs: change default of spn update command to use an entity

Change-Id: I05720c79767311593d93277e2ba82f6bde212518
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in private directory to use an entity
Garming Sam [Wed, 8 Jan 2014 23:35:03 +0000 (12:35 +1300)]
docs: change default in private directory to use an entity

Change-Id: I4d015f2a75d8f404e0db64382b6d71bb9b59b8e3
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in lock directory to use an entity
Garming Sam [Wed, 8 Jan 2014 23:33:27 +0000 (12:33 +1300)]
docs: change default in lock directory to use an entity

Change-Id: Ie36185c0c9f439747a855885138093197f60786a
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in state directory to use an entity
Garming Sam [Wed, 8 Jan 2014 23:31:17 +0000 (12:31 +1300)]
docs: change default in state directory to use an entity

Change-Id: I955779e117183ea42c86c092df9f6e3fda936f3c
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in winbindd socket directory to use an entity
Garming Sam [Wed, 8 Jan 2014 23:27:18 +0000 (12:27 +1300)]
docs: change default in winbindd socket directory to use an entity

Change-Id: I8b3305f789cf081c5289c9d2653aecd8aa828577
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in ncalrpc dir to use an entity
Garming Sam [Wed, 8 Jan 2014 23:23:31 +0000 (12:23 +1300)]
docs: change default in ncalrpc dir to use an entity

Change-Id: I53e66f778731f44aba9fa2e1e18f157bea9c2974
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in smb passwd file to use an entity
Garming Sam [Wed, 8 Jan 2014 23:19:48 +0000 (12:19 +1300)]
docs: change default in smb passwd file to use an entity

Change-Id: Ia81d677657ec0013c9cc7bfaecc2d88faf50f07c
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in dns update command to use an entity
Garming Sam [Wed, 8 Jan 2014 23:15:28 +0000 (12:15 +1300)]
docs: change default in dns update command to use an entity

Change-Id: I911eabd0271d0b3cdd15b5232a837ca3289997ae
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change default in pid directory to use an entity
Garming Sam [Wed, 8 Jan 2014 23:07:32 +0000 (12:07 +1300)]
docs: change default in pid directory to use an entity

Change-Id: I4e4d5c7e1a82aa0788423efe2cba2e828f127346
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: Allow smb.conf.5 to still be generated outside the waf build
Andrew Bartlett [Tue, 14 Jan 2014 00:07:52 +0000 (13:07 +1300)]
docs: Allow smb.conf.5 to still be generated outside the waf build

This will be needed once we start to use the XML entities for the
configure-dependent paths.

Change-Id: I2b64f02bb365cc099178b63b2b24bdb239dbb7c1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: define and include entities for the docs
Garming Sam [Wed, 8 Jan 2014 23:01:18 +0000 (12:01 +1300)]
docs: define and include entities for the docs

This allows for dynamic default settings to be generated.

Change-Id: If8b93d233fb941bc7e3073ccf4b5ec0b0a231bd9
Pair-programmed-with: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: adjust the defaults for list parameters to include commas to match testparm...
Garming Sam [Mon, 13 Jan 2014 21:54:05 +0000 (10:54 +1300)]
docs: adjust the defaults for list parameters to include commas to match testparm output

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jan 31 12:57:34 CET 2014 on sn-devel-104

10 years agos3-param: Remove compilation conditional for setting directory name cache size.
Garming Sam [Mon, 13 Jan 2014 22:34:24 +0000 (11:34 +1300)]
s3-param: Remove compilation conditional for setting directory name cache size.

BROKEN_DIRECTORY_HANDLING was originally added in f1041f98ced8ef50373ca37d541d7ca8b1d46638
however, it was never set.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: change server max protocol to be consistent with s3 and docs
Garming Sam [Wed, 8 Jan 2014 00:34:49 +0000 (13:34 +1300)]
lib/param: change server max protocol to be consistent with s3 and docs

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: change min wins ttl default to be consistent with docs
Garming Sam [Tue, 31 Dec 2013 03:38:24 +0000 (16:38 +1300)]
lib/param: change min wins ttl default to be consistent with docs

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of printjob username to match s3
Andrew Bartlett [Thu, 9 Jan 2014 00:38:07 +0000 (13:38 +1300)]
lib/param: Fix default of printjob username to match s3

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of logon path to match s3
Andrew Bartlett [Thu, 9 Jan 2014 00:37:05 +0000 (13:37 +1300)]
lib/param: Fix default of logon path to match s3

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of logon home to match s3
Andrew Bartlett [Thu, 9 Jan 2014 00:36:24 +0000 (13:36 +1300)]
lib/param: Fix default of logon home to match s3

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of smb passwd file to match s3
Andrew Bartlett [Thu, 9 Jan 2014 00:34:58 +0000 (13:34 +1300)]
lib/param: Fix default of smb passwd file to match s3

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of panic action to match s3
Andrew Bartlett [Thu, 9 Jan 2014 00:33:51 +0000 (13:33 +1300)]
lib/param: Fix default of panic action to match s3

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix default of usershare path to match docs
Andrew Bartlett [Thu, 9 Jan 2014 00:33:15 +0000 (13:33 +1300)]
lib/param: Fix default of usershare path to match docs

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: change hard-coded default of nsupdate command to match lib/param
Andrew Bartlett [Thu, 9 Jan 2014 00:07:11 +0000 (13:07 +1300)]
docs: change hard-coded default of nsupdate command to match lib/param

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: change name resolve order to include lmhosts as per the docs
Garming Sam [Tue, 31 Dec 2013 04:25:14 +0000 (17:25 +1300)]
lib/param: change name resolve order to include lmhosts as per the docs

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agos4-resolve: Add lmhosts support into the source4 name resolve code
Andrew Bartlett [Tue, 14 Jan 2014 00:48:32 +0000 (13:48 +1300)]
s4-resolve: Add lmhosts support into the source4 name resolve code

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: set default for -valid parameter
Garming Sam [Wed, 8 Jan 2014 01:38:09 +0000 (14:38 +1300)]
lib/param: set default for -valid parameter

This parameter isn't used in any of the lib/param code and is being added for consistency

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Rename variable used for lp__server_role server_role
Garming Sam [Thu, 9 Jan 2014 22:28:45 +0000 (11:28 +1300)]
param: Rename variable used for lp__server_role server_role

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Rename variable used for lp__security security
Garming Sam [Thu, 9 Jan 2014 22:26:15 +0000 (11:26 +1300)]
param: Rename variable used for lp__security security

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: fixup security default to AUTO to permit server role = domain member
Garming Sam [Tue, 7 Jan 2014 04:55:35 +0000 (17:55 +1300)]
param: fixup security default to AUTO to permit server role = domain member

When this is set to AUTO, it behaves as security = user unless server role = domain member has been set.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: fix a comment for lpcfg_printername
Garming Sam [Thu, 9 Jan 2014 22:19:56 +0000 (11:19 +1300)]
lib/param: fix a comment for lpcfg_printername

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Rename variable used for lp__printername szPrintername
Garming Sam [Thu, 30 Jan 2014 03:54:39 +0000 (16:54 +1300)]
param: Rename variable used for lp__printername szPrintername

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: remove static functions in param_functions.c
Garming Sam [Thu, 9 Jan 2014 22:06:17 +0000 (11:06 +1300)]
param: remove static functions in param_functions.c

Only two functions are static and their presence doesn't really gain much, besides impeding auto-generation

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Complete the removal of the "open files database hash size" parameter
Garming Sam [Fri, 10 Jan 2014 02:41:08 +0000 (15:41 +1300)]
param: Complete the removal of the "open files database hash size" parameter

This parameter was originally set for removal in 2007 in 28210588edc39eb2b6cd237f11b488fa4d6b6985

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoctdb-doc: Fix usage string for ctdb readkey/writekey
Amitay Isaacs [Fri, 31 Jan 2014 01:46:21 +0000 (12:46 +1100)]
ctdb-doc: Fix usage string for ctdb readkey/writekey

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Jan 31 07:52:46 CET 2014 on sn-devel-104

10 years agoctdb-daemon: Return negative status only if there are known errors
Amitay Isaacs [Thu, 23 Jan 2014 03:57:53 +0000 (14:57 +1100)]
ctdb-daemon: Return negative status only if there are known errors

If event script does not exist or does not have execute permissions, then
return negative errno to distinguish from the exit errors of event script.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
10 years agoctdb/tests/eventscripts: Avoid errors on broken pipe
Martin Schwenke [Tue, 28 Jan 2014 03:34:15 +0000 (14:34 +1100)]
ctdb/tests/eventscripts: Avoid errors on broken pipe

ctdb_get_my_public_addresses() attempts to echo things and this causes
an error if head has taken the first line and the pipe is closed.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Fri Jan 31 05:30:38 CET 2014 on sn-devel-104

10 years agoctdb/tests/eventscripts: Improve ip command stub secondary handling
Martin Schwenke [Tue, 28 Jan 2014 05:07:53 +0000 (16:07 +1100)]
ctdb/tests/eventscripts: Improve ip command stub secondary handling

It should support primary and secondaries per network instead of per
interface.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
10 years agoctdb/daemon: reloadips must register state of asynchronous controls
Martin Schwenke [Wed, 22 Jan 2014 05:02:46 +0000 (16:02 +1100)]
ctdb/daemon: reloadips must register state of asynchronous controls

Otherwise ctdb_client_async_wait() is a no-op.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
10 years agos4:tls_tstream: allow mode of SSL keyfile to be 0400, not only 0600
Michael Brown [Wed, 22 Jan 2014 03:23:12 +0000 (03:23 +0000)]
s4:tls_tstream: allow mode of SSL keyfile to be 0400, not only 0600

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10392

Signed-off-by: Michael Brown <michael@netdirect.ca>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jan 31 01:27:03 CET 2014 on sn-devel-104

10 years agobuild: Build idmap_ad by default
Volker Lendecke [Thu, 30 Jan 2014 11:30:05 +0000 (11:30 +0000)]
build: Build idmap_ad by default

Most other idmap modules are built by default. I don't see a reason why
idmap_ad should be special here.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agoselftets: durable-open.reopen4 succeeds now.
Michael Adam [Tue, 28 Jan 2014 22:56:06 +0000 (23:56 +0100)]
selftets: durable-open.reopen4 succeeds now.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 30 23:32:13 CET 2014 on sn-devel-104

10 years agos4:torture:smb2: fix durable-open.reopen4
Michael Adam [Tue, 28 Jan 2014 22:43:58 +0000 (23:43 +0100)]
s4:torture:smb2: fix durable-open.reopen4

We currently don't support durable handles with delete-on-close:
with delete-on-close, we close a durable handle with delete-on-close
set upon disconnect.

This patch adapts the test to behave accordingly,
i.e. don't use delete-on-close...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
10 years agos3:smbd: skip empty records in smbXsrv_open_cleanup()
Stefan Metzmacher [Tue, 24 Dec 2013 08:00:01 +0000 (09:00 +0100)]
s3:smbd: skip empty records in smbXsrv_open_cleanup()

This should avoid scary ndr_pull errors, if there's
a cleanup race.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jan 30 18:49:37 CET 2014 on sn-devel-104

10 years agosmbd:smb2: fix durable reconnect: set fsp->fnum from the smbXsrv_open->local_id
Michael Adam [Thu, 23 Jan 2014 23:09:50 +0000 (00:09 +0100)]
smbd:smb2: fix durable reconnect: set fsp->fnum from the smbXsrv_open->local_id

Originally, fsp->fnum was left at the INVALID fnum value.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodocs: remove extra spaces in synopsis of dbwrap_tool
Michael Adam [Thu, 30 Jan 2014 09:47:15 +0000 (10:47 +0100)]
docs: remove extra spaces in synopsis of dbwrap_tool

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodocs: document new --non-persistent option to dbwrap_tool
Michael Adam [Thu, 30 Jan 2014 09:36:46 +0000 (10:36 +0100)]
docs: document new --non-persistent option to dbwrap_tool

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodbwrap_tool: add option "--non-persistent" and force excatly one of "--[non-]persistent"
Michael Adam [Thu, 30 Jan 2014 09:29:49 +0000 (10:29 +0100)]
dbwrap_tool: add option "--non-persistent" and force excatly one of "--[non-]persistent"

We want to force users of dbwrap_tool to explicitly specify
persistent or non-persistent. Otherwise, one could easily
by accident wipe a whole database that is actually persistent
but not currently opened by a samba process, just by openeing
the DB with the default non-persistent mode...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodocs: remove short form "-p" of --persistent from dbwrap_tool manpage
Michael Adam [Thu, 30 Jan 2014 09:33:00 +0000 (10:33 +0100)]
docs: remove short form "-p" of --persistent from dbwrap_tool manpage

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agodbwrap_tool: remove the short form "-p" of "--persistent"
Michael Adam [Wed, 29 Jan 2014 15:58:37 +0000 (16:58 +0100)]
dbwrap_tool: remove the short form "-p" of "--persistent"

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
10 years agos3:brlock: fix a comment typo
Michael Adam [Tue, 28 Jan 2014 23:55:19 +0000 (00:55 +0100)]
s3:brlock: fix a comment typo

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 30 13:25:22 CET 2014 on sn-devel-104

10 years agoctdb-eventscripts: Do not mark node unhealthy if no fs is available
Srikrishan Malik [Fri, 13 Dec 2013 07:35:53 +0000 (13:05 +0530)]
ctdb-eventscripts: Do not mark node unhealthy if no fs is available

Signed-off-by: Srikrishan Malik <srimalik@in.ibm.com>
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Jan 30 11:18:19 CET 2014 on sn-devel-104

10 years agoparam: Do not check defaults_saved in is_default
Andrew Bartlett [Mon, 27 Jan 2014 02:14:38 +0000 (15:14 +1300)]
param: Do not check defaults_saved in is_default

We only call is_default if defaults_saved == true, so this static variable
reference is not required.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Jan 30 03:31:29 CET 2014 on sn-devel-104

10 years agolib/param: Do not check defaults_saved in is_default
Andrew Bartlett [Mon, 27 Jan 2014 02:13:49 +0000 (15:13 +1300)]
lib/param: Do not check defaults_saved in is_default

We only call is_default if defaults_saved == true, so this static variable
reference is not required.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Remove unused lp_is_default (once used by SWAT)
Andrew Bartlett [Mon, 27 Jan 2014 02:00:02 +0000 (15:00 +1300)]
param: Remove unused lp_is_default (once used by SWAT)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: Remove unused lp_next_parameter (once used by SWAT)
Andrew Bartlett [Mon, 27 Jan 2014 01:58:21 +0000 (14:58 +1300)]
param: Remove unused lp_next_parameter (once used by SWAT)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Remove unused lpcfg_next_parameter (once used by SWAT)
Andrew Bartlett [Mon, 27 Jan 2014 01:58:14 +0000 (14:58 +1300)]
lib/param: Remove unused lpcfg_next_parameter (once used by SWAT)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: remove unused bPreferredMaster from s3 loadparm in LOADPARM_EXTRA_GLOBALS
Garming Sam [Fri, 10 Jan 2014 01:47:25 +0000 (14:47 +1300)]
param: remove unused bPreferredMaster from s3 loadparm in LOADPARM_EXTRA_GLOBALS

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Make and use lpcfg_equal_parameter in common
Andrew Bartlett [Wed, 15 Jan 2014 02:56:34 +0000 (15:56 +1300)]
lib/param: Make and use lpcfg_equal_parameter in common

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Make and use common lpcfg_map_parameter
Andrew Bartlett [Wed, 15 Jan 2014 01:19:21 +0000 (14:19 +1300)]
lib/param: Make and use common lpcfg_map_parameter

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agos3-param: Use lpcfg_dump_a_parameter in dump_a_parameter
Andrew Bartlett [Wed, 15 Jan 2014 00:48:22 +0000 (13:48 +1300)]
s3-param: Use lpcfg_dump_a_parameter in dump_a_parameter

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agos3-param: Make dump_a_parameter use lp_paramater() rather than an open-coded loop
Andrew Bartlett [Wed, 15 Jan 2014 00:42:55 +0000 (13:42 +1300)]
s3-param: Make dump_a_parameter use lp_paramater() rather than an open-coded loop

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Make lpcfg_print_parameter() common
Andrew Bartlett [Wed, 15 Jan 2014 00:39:14 +0000 (13:39 +1300)]
lib/param: Make lpcfg_print_parameter() common

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: pad permissions to 3 digits and update docs to be consistent
Garming Sam [Thu, 2 Jan 2014 23:22:19 +0000 (12:22 +1300)]
param: pad permissions to 3 digits and update docs to be consistent

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: Fix copy_service to handle BOOLREV
Andrew Bartlett [Wed, 15 Jan 2014 01:13:13 +0000 (14:13 +1300)]
lib/param: Fix copy_service to handle BOOLREV

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Jan 29 11:11:11 CET 2014 on sn-devel-104

10 years agodocs: Remove unused parameters.global.xml and parameters.service.xml
Andrew Bartlett [Mon, 13 Jan 2014 23:35:25 +0000 (12:35 +1300)]
docs: Remove unused parameters.global.xml and parameters.service.xml

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: Remove find_missing_manpages replaced by docs.py and dependent on a Makefile...
Andrew Bartlett [Mon, 13 Jan 2014 22:22:16 +0000 (11:22 +1300)]
docs: Remove find_missing_manpages replaced by docs.py and dependent on a Makefile.in file

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: don't ignore some parameters when performing map_parameter
Garming Sam [Wed, 8 Jan 2014 01:29:36 +0000 (14:29 +1300)]
param: don't ignore some parameters when performing map_parameter

Only the -valid parameter is currently affected by this. There doesn't seem to be any reason why you shouldn't
be able to simply map the parameter and there are already existing checks, in dump_a_service for instance, where it
checks for the prefix anyways.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agolib/param: fix copy service to include the case for P_CHAR
Garming Sam [Tue, 7 Jan 2014 23:51:26 +0000 (12:51 +1300)]
lib/param: fix copy service to include the case for P_CHAR

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: remove the file prefix from included path names
Garming Sam [Tue, 7 Jan 2014 04:09:39 +0000 (17:09 +1300)]
docs: remove the file prefix from included path names

This allows the inbuilt python xml modules to perform the include.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agodocs: update XInclude year to conform with current standard
Garming Sam [Tue, 7 Jan 2014 03:08:50 +0000 (16:08 +1300)]
docs: update XInclude year to conform with current standard

This allows the inbuilt python XML parser to handle these includes.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: remove unnecessary checks in dump a parameter
Garming Sam [Tue, 28 Jan 2014 23:12:00 +0000 (12:12 +1300)]
param: remove unnecessary checks in dump a parameter

In dump_a_parameter we now allow dumping of a parameter by alias name,
and so this check is not required.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agoparam: fix an offset bug in lpcfg_set_cmdline
Garming Sam [Tue, 28 Jan 2014 22:59:29 +0000 (11:59 +1300)]
param: fix an offset bug in lpcfg_set_cmdline

Previously, it was possible to compare offsets between
loadparm_service and loadparm_global.  This meant in some cases
incorrectly skipping certain parameters.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
10 years agopthreadpool: Fix a comment, "quit"->"shutdown"
Volker Lendecke [Mon, 27 Jan 2014 10:08:03 +0000 (11:08 +0100)]
pthreadpool: Fix a comment, "quit"->"shutdown"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Jan 28 19:06:40 CET 2014 on sn-devel-104

10 years agoparam: assign default ports in s3 loadparm to match docs and s4
Garming Sam [Thu, 9 Jan 2014 02:45:45 +0000 (15:45 +1300)]
param: assign default ports in s3 loadparm to match docs and s4

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jan 28 10:29:57 CET 2014 on sn-devel-104

10 years agoparam: Add default for rndc command to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 01:05:58 +0000 (14:05 +1300)]
param: Add default for rndc command to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for nsupdate command to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 01:04:24 +0000 (14:04 +1300)]
param: Add default for nsupdate command to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for spn update command to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 01:03:34 +0000 (14:03 +1300)]
param: Add default for spn update command to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for dns update command to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 01:02:07 +0000 (14:02 +1300)]
param: Add default for dns update command to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for samba kcc command to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 01:01:03 +0000 (14:01 +1300)]
param: Add default for samba kcc command to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add defaults for tls parameters to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 00:52:44 +0000 (13:52 +1300)]
param: Add defaults for tls parameters to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for winbindd privileged socket directory to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 00:45:33 +0000 (13:45 +1300)]
param: Add default for winbindd privileged socket directory to s3 loadparm

(note that this parameter is only used in the source4 winbindd code at this time)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agoparam: Add default for ntp signd socket directory to s3 loadparm
Andrew Bartlett [Thu, 9 Jan 2014 00:43:56 +0000 (13:43 +1300)]
param: Add default for ntp signd socket directory to s3 loadparm

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: change server min protocol to be consistent with s3 and docs
Garming Sam [Wed, 8 Jan 2014 00:33:15 +0000 (13:33 +1300)]
lib/param: change server min protocol to be consistent with s3 and docs

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: fix nbt client socket address default setting to be consistent with s3...
Garming Sam [Wed, 8 Jan 2014 00:27:23 +0000 (13:27 +1300)]
lib/param: fix nbt client socket address default setting to be consistent with s3 and docs

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: set defaults for a number of previously unset parameters
Garming Sam [Wed, 8 Jan 2014 00:21:39 +0000 (13:21 +1300)]
lib/param: set defaults for a number of previously unset parameters

These defaults are based on the docs which have been checked against source3.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for guest account
Garming Sam [Tue, 7 Jan 2014 21:51:03 +0000 (10:51 +1300)]
lib/param: add default for guest account

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: Move GUEST_ACCOUNT define to a common header
Andrew Bartlett [Fri, 10 Jan 2014 02:04:02 +0000 (15:04 +1300)]
lib/param: Move GUEST_ACCOUNT define to a common header

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for password chat timeout
Garming Sam [Tue, 7 Jan 2014 21:50:02 +0000 (10:50 +1300)]
lib/param: add default for password chat timeout

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for browse list parameter
Garming Sam [Tue, 7 Jan 2014 21:45:55 +0000 (10:45 +1300)]
lib/param: add default for browse list parameter

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for hide dot files parameter
Garming Sam [Tue, 7 Jan 2014 21:44:35 +0000 (10:44 +1300)]
lib/param: add default for hide dot files parameter

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for mangling method
Garming Sam [Tue, 7 Jan 2014 21:43:02 +0000 (10:43 +1300)]
lib/param: add default for mangling method

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for lm interval
Garming Sam [Tue, 7 Jan 2014 21:41:21 +0000 (10:41 +1300)]
lib/param: add default for lm interval

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for ldap deref parameter
Garming Sam [Tue, 7 Jan 2014 21:39:33 +0000 (10:39 +1300)]
lib/param: add default for ldap deref parameter

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for ldap ssl parameter
Garming Sam [Tue, 7 Jan 2014 21:34:08 +0000 (10:34 +1300)]
lib/param: add default for ldap ssl parameter

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
10 years agolib/param: add default for smb2 max credits
Garming Sam [Tue, 7 Jan 2014 21:25:05 +0000 (10:25 +1300)]
lib/param: add default for smb2 max credits

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>