Derrell Lipman [Thu, 31 Mar 2005 20:28:47 +0000 (20:28 +0000)]
r6155: Fixes bug #1133
Added provision for overloading some global configuration options via the new,
per-user file ~/.smb/smb.conf.append which is read after the global config
file is read (and only if the global config file was read). This leave the
original, BC behavior of ~/.smb/smb.conf which, if found, is read but causes
the global config file to not be read.
Also fixed a potential seg fault in to lp_dump_one().
Gerald Carter [Thu, 31 Mar 2005 20:11:20 +0000 (20:11 +0000)]
r6154: fix winbindd <-> Windows 2003 sp1 issue.
Can't do LsaOpenPolicy() over schannel anymore.
This is an interesting find as it could imply that there are
other changes we haven't seen yet in sp1.
Volker, You might want to look at this for trunk.
Jeremy Allison [Thu, 31 Mar 2005 19:10:59 +0000 (19:10 +0000)]
r6152: Correctly check OpenX open modes.
Jeremy.
Derrell Lipman [Thu, 31 Mar 2005 16:26:15 +0000 (16:26 +0000)]
r6151: additional examples/tests for libsmbclient
Derrell Lipman [Thu, 31 Mar 2005 05:06:04 +0000 (05:06 +0000)]
r6149: Fixes bugs #2498 and 2484.
1. using smbc_getxattr() et al, one may now request all access control
entities in the ACL without getting all other NT attributes.
2. added the ability to exclude specified attributes from the result set
provided by smbc_getxattr() et al, when requesting all attributes,
all NT attributes, or all DOS attributes.
3. eliminated all compiler warnings, including when --enable-developer
compiler flags are in use. removed -Wcast-qual flag from list, as that
is specifically to force warnings in the case of casting away qualifiers.
Note: In the process of eliminating compiler warnings, a few nasties were
discovered. In the file libads/sasl.c, PRIVATE kerberos interfaces
are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED
kerberos interfaces are being used. Someone who knows kerberos
should look at these and determine if there is an alternate method
of accomplishing the task.
Jeremy Allison [Thu, 31 Mar 2005 02:12:09 +0000 (02:12 +0000)]
r6146: Added OS/2 EA support in trans2_open and trans2_mkdir. Fixed in nttrans_create.
Jeremy.
Jeremy Allison [Thu, 31 Mar 2005 00:36:22 +0000 (00:36 +0000)]
r6141: Fix OS/2 EA's for NTcreate. OpenX and mkdir to follow.
Jeremy.
Jeremy Allison [Wed, 30 Mar 2005 20:53:02 +0000 (20:53 +0000)]
r6138: Refactor length reading out of EA code so we can read length
external to buffer. Needed to add EA code to create calls.
Jeremy.
Derrell Lipman [Wed, 30 Mar 2005 04:40:24 +0000 (04:40 +0000)]
r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
whole of samba comiles warning-free with the default compiler flags.
Temporarily defined -Wall to locate other potential problems. Found an
unused static function (#ifdefed out rather than deleted, in case it's
needed for something in progress).
There are also a number of uses of undeclared functions, mostly krb5_*.
Files with these problems need to have appropriate header files included,
but they are not fixed in this update.
oplock_linux.c.c has undefined functions capget() and capset(), which need
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>,
but that could potentially have other side effects, so that remains uncorrected
as well.
The flag -Wall should be added permanently to CFLAGS, and all warnings then
generated should be eliminated.
Derrell Lipman [Wed, 30 Mar 2005 02:39:22 +0000 (02:39 +0000)]
r6126: added utility for testing smbc_stat()
Derrell Lipman [Wed, 30 Mar 2005 02:35:31 +0000 (02:35 +0000)]
r6125: smbc_stat() returned incorrect timestamps IFF it used cli_qpathinfo2() to
retrieve the timestamps (Win2k) and not if it used cli-getatr() to retrieve
the timestamps (Win98). Timestamps are supposed to be in GMT, and should
not have serverzone deducted from them in cli_qpathinfo2().
Jeremy Allison [Wed, 30 Mar 2005 02:24:47 +0000 (02:24 +0000)]
r6124: Fix for bug #2242 from Tom Lackemann <cessnatomny@yahoo.com> - don't
set SD on an NTtransact create unless we created the file.
Jeremy.
Jeremy Allison [Wed, 30 Mar 2005 02:05:22 +0000 (02:05 +0000)]
r6122: Added "hack" fix for broken SMB_INFO_VOLUME level - used by OS/2
I believe. Reported as fixed by Marcel Müller <mueller@maazl.de>.
Jeremy.
Jeremy Allison [Wed, 30 Mar 2005 00:47:57 +0000 (00:47 +0000)]
r6120: Added "volume" command to smbclient that prints out the volume name and
serial number.
Jeremy.
Günther Deschner [Tue, 29 Mar 2005 15:17:26 +0000 (15:17 +0000)]
r6117: Close handles after group-creation as well.
Guenther
Simo Sorce [Tue, 29 Mar 2005 14:08:49 +0000 (14:08 +0000)]
r6116: update debian changelog
Volker Lendecke [Tue, 29 Mar 2005 06:45:10 +0000 (06:45 +0000)]
r6110: Close handles on user creation. This allows easy mass creation of users with
rpcclient.
Volker
Derrell Lipman [Tue, 29 Mar 2005 00:42:51 +0000 (00:42 +0000)]
r6108: Added smbsh/smbwrapper for Linux to example/libsmbclient tree; provided more complete libsmbclient testbrowse utility
Jeremy Allison [Tue, 29 Mar 2005 00:36:30 +0000 (00:36 +0000)]
r6106: Fix bug #2551. It turns out that the incoming flags2 flag FLAGS2_LONG_PATH_COMPONENTS
determines if a reply is uppercased on a SMBsearch request, not the protocol level.
This could clear up quite a few hacks going forward I think.
Jeremy.
Jeremy Allison [Mon, 28 Mar 2005 21:31:01 +0000 (21:31 +0000)]
r6104: Update dos filetimes to default yes for Office 2000.
Jeremy.
Steve French [Mon, 28 Mar 2005 20:32:04 +0000 (20:32 +0000)]
r6103: Update list of mount options for mount.cifs
Derrell Lipman [Mon, 28 Mar 2005 19:52:23 +0000 (19:52 +0000)]
r6102: add support for opening a file for write with O_APPEND in libsmbclient
Jeremy Allison [Mon, 28 Mar 2005 03:27:44 +0000 (03:27 +0000)]
r6092: This much const causes the compiler on Fedora Core 2
to throw up.
Jeremy.
Jeremy Allison [Mon, 28 Mar 2005 03:18:57 +0000 (03:18 +0000)]
r6090: Patch to fix sys_select so it can't drop signals if another fd
is ready to read. Patch from Mark Weaver <mark-clist@npsl.co.uk>.
The only question is, how did we miss this for so long..... :-).
Jeremy.
Jeremy Allison [Sun, 27 Mar 2005 20:44:06 +0000 (20:44 +0000)]
r6082: Fix for bugid #2541. Fixes from Guenter Kukkukk <guenter.kukkukk@kukkukk.com>
Jeremy.
Volker Lendecke [Sun, 27 Mar 2005 16:33:04 +0000 (16:33 +0000)]
r6080: Port some of the non-critical changes from HEAD to 3_0. The main one is the
change in pdb_enum_alias_memberships to match samr.idl a bit closer.
Volker
Gerald Carter [Sat, 26 Mar 2005 06:52:56 +0000 (06:52 +0000)]
r6071: * clean up UNISTR2_ARRAY ( really just an array of UNISTR4 + count )
* add some backwards compatibility to 'net rpc rights list'
* verify privilege name in 'net rpc rights privileges <name>' in order
to give back better error messages.
Jeremy Allison [Sat, 26 Mar 2005 00:44:46 +0000 (00:44 +0000)]
r6069: Fix for bug #2541. Ensure we recognise LANMAN2.1 as OS/2 and select LANMAN2
protocol, ensure the EA size is always correctly set on a query for a file with no EA's.
Jeremy.
Jeremy Allison [Fri, 25 Mar 2005 23:45:11 +0000 (23:45 +0000)]
r6067: Patch from Marcel Müller <mueller@maazl.de> - fix OS/2 EA_FROM_LIST
info level.
Jeremy.
Jeremy Allison [Fri, 25 Mar 2005 19:52:01 +0000 (19:52 +0000)]
r6063: Fix for bug #2533 - ensure SMBsearch unsets UNICODE flags2 bit as this SMB is
DOS codepage only.
Jeremy.
Gerald Carter [Fri, 25 Mar 2005 14:37:10 +0000 (14:37 +0000)]
r6062: work around autoconf setting the CFLAGS="-g -O2" by default in AC_CACHE_CHECK
Jeremy Allison [Fri, 25 Mar 2005 03:41:02 +0000 (03:41 +0000)]
r6060: It's not quite accurate to say not having write access causes a group
entry never to match - it matches but if doesn't grant access is recorded
so the "other" entry isn't subsequently checked.
Fix the algorithm.
Jeremy.
Jeremy Allison [Fri, 25 Mar 2005 01:36:39 +0000 (01:36 +0000)]
r6057: Don't put the assert in the wrong place :-).
Jeremy.
Jeremy Allison [Fri, 25 Mar 2005 01:30:21 +0000 (01:30 +0000)]
r6055: Fix algorithm. If any of the primary or supplementary group ids match
a "allow" entry of GROUP or GROUP_OBJ, then access is allowed. It doesn't
terminate on the first match. Added debug to show where the match occured
(or didn't).
Jeremy.
Jeremy Allison [Fri, 25 Mar 2005 00:58:15 +0000 (00:58 +0000)]
r6053: Fixup dfs path with the new wildcard parser code split out.
Jeremy.
Gerald Carter [Fri, 25 Mar 2005 00:38:30 +0000 (00:38 +0000)]
r6051: finish off
net rpc service stop
net rpc service start
net rpc service pause
net rpc service resume
Jeremy Allison [Thu, 24 Mar 2005 22:34:28 +0000 (22:34 +0000)]
r6049: Ensure "dos filetime" checks file ACLs correctly. May fix Excel "read-only"
issue.
Jeremy.
Jeremy Allison [Thu, 24 Mar 2005 22:32:52 +0000 (22:32 +0000)]
r6048: Split out the check_path_syntax into a findfirst/next/wildcard version.
The semantics are different with wildcards.
Jeremy.
Gerald Carter [Thu, 24 Mar 2005 22:32:31 +0000 (22:32 +0000)]
r6046: $ net -S block -U % -W VALE rpc service status spooler
spooler service is SVCCTL_RUNNING.
Configuration details:
Service Type = 0x110
Start Type = 0x2
Error Control = 0x1
Tag ID = 0x0
Executable Path = C:\WINNT\system32\spoolsv.exe
Load Order Group = SpoolerGroup
Dependencies = RPCSS/
Start Name = LocalSystem
Display Name = Print Spooler
Jeremy Allison [Thu, 24 Mar 2005 19:33:02 +0000 (19:33 +0000)]
r6044: Ensure the old search calls always ask mask_match to translate
patterns like ????????.??? - even if using an NT1 protocol.
Matches W2K3 behavior.
Jeremy.
Gerald Carter [Thu, 24 Mar 2005 18:13:51 +0000 (18:13 +0000)]
r6041: cleaning up output from 'rpc service list'
Gerald Carter [Thu, 24 Mar 2005 18:05:31 +0000 (18:05 +0000)]
r6040: finish out 'net rpc service list'
Gerald Carter [Thu, 24 Mar 2005 17:11:51 +0000 (17:11 +0000)]
r6039: add CLI_DO_RPC macro for cookie cutter code; no new functionality to 'net rpc service'
Gerald Carter [Thu, 24 Mar 2005 16:11:23 +0000 (16:11 +0000)]
r6038: adding more flesh to 'net rpc service'
open and close the service control manager.
Also experimenting with ideas for cli_xxx() interface.
Gerald Carter [Thu, 24 Mar 2005 14:40:35 +0000 (14:40 +0000)]
r6037: little cleanup of unused vars and unnecessary codepaths
Gerald Carter [Thu, 24 Mar 2005 14:39:55 +0000 (14:39 +0000)]
r6036: patch from Lin Li <linl@xandros.com> to ensure trusted domains are initialized whenenumerating users and groups
Simo Sorce [Thu, 24 Mar 2005 08:36:00 +0000 (08:36 +0000)]
r6034: Check only once
Gerald Carter [Thu, 24 Mar 2005 04:25:49 +0000 (04:25 +0000)]
r6029: adding files necessary to support 'net rpc service' functions; will fill in tomorrow
Jeremy Allison [Thu, 24 Mar 2005 02:23:32 +0000 (02:23 +0000)]
r6022: Fix for bug #2533. Incorrect dir listings from OS/2 clients.
Jeremy.
Jeremy Allison [Thu, 24 Mar 2005 01:02:52 +0000 (01:02 +0000)]
r6020: Never do NT status codes with protocols before NT1 as we don't get client caps.
Jeremy.
Simo Sorce [Thu, 24 Mar 2005 00:01:56 +0000 (00:01 +0000)]
r6016: Give access only to root and Domain Users
Gerald Carter [Wed, 23 Mar 2005 23:26:33 +0000 (23:26 +0000)]
r6014: rather large change set....
pulling back all recent rpc changes from trunk into
3.0. I've tested a compile and so don't think I've missed
any files. But if so, just mail me and I'll clean backup
in a couple of hours.
Changes include \winreg, \eventlog, \svcctl, and
general parse_misc.c updates.
I am planning on bracketing the event code with an
#ifdef ENABLE_EVENTLOG until I finish merging Marcin's
changes (very soon).
Jeremy Allison [Wed, 23 Mar 2005 21:46:09 +0000 (21:46 +0000)]
r6009: Add privillage check for SE_DISK_OP (is this the right privilage?)
before allowing users to shut down any sessions.
Simo - please check security before allowing state changes. Please
review this change.
Jeremy.
Simo Sorce [Wed, 23 Mar 2005 20:57:03 +0000 (20:57 +0000)]
r6004: Let's make server manager able to kill a user session.
This will send a shutdown command to the right process by pid read from the sessions list.
Jeremy Allison [Wed, 23 Mar 2005 19:35:56 +0000 (19:35 +0000)]
r6001: Oops. Checing the wrong tagtype - should have been SMB_ACL_GROUP, not SMB_ACL_MASK.
Fix bug #2521.
Jeremy.
Gerald Carter [Wed, 23 Mar 2005 15:36:48 +0000 (15:36 +0000)]
r5994: proper fix for smbclient and win98 file servers; check the WCT value in the tcon&X reply before setting the cli_state->dfsroot flag
Gerald Carter [Wed, 23 Mar 2005 14:28:27 +0000 (14:28 +0000)]
r5993: compiler warning fix
Jeremy Allison [Wed, 23 Mar 2005 03:55:02 +0000 (03:55 +0000)]
r5991: Fixup last entry offset correctly for level 260.
Should fix bug found by Derrell.Lipman@UnwiredUniverse.com.
Jeremy.
Jeremy Allison [Tue, 22 Mar 2005 23:45:57 +0000 (23:45 +0000)]
r5981: Hack to fix DFS code to work with Win98 server. JERRY PLEASE REVIEW THIS !
I don't think this is correct - it just happens to work and fix bug #2530
to return all the files.
Jeremy.
Jeremy Allison [Tue, 22 Mar 2005 23:18:41 +0000 (23:18 +0000)]
r5979: Don't crash when talking to a Win98 server (bugid #2530 - not a fix
buy just prevent the crash).
Jeremy.
Jeremy Allison [Tue, 22 Mar 2005 22:04:01 +0000 (22:04 +0000)]
r5975: Re-arrange code and comments to make more sense.
Jeremy.
Jeremy Allison [Tue, 22 Mar 2005 21:43:51 +0000 (21:43 +0000)]
r5973: Fix up overwrite of last 2 bytes on clilist (could cause coredump).
Jeremy.
Günther Deschner [Tue, 22 Mar 2005 21:24:16 +0000 (21:24 +0000)]
r5971: Check for the correct cli-struct when copying files.
Good catch from Lars Mueller <lmuelle@suse.de>.
Guenther
Jeremy Allison [Tue, 22 Mar 2005 21:22:59 +0000 (21:22 +0000)]
r5970: Fix old bug where ff_searchcount was being compared -1 ! This caused a
filename to be processed twice.
Jeremy.
Gerald Carter [Tue, 22 Mar 2005 21:17:01 +0000 (21:17 +0000)]
r5968: derrell's large file fix for libsmbclient (BUG 2505)
Jeremy Allison [Tue, 22 Mar 2005 20:54:19 +0000 (20:54 +0000)]
r5967: Fix typo bug where flags overwrote info level.
Jeremy.
Jim McDonough [Tue, 22 Mar 2005 20:50:29 +0000 (20:50 +0000)]
r5965: Apply Volker's patch for "ldapsam trusted = yes" for samr_lookup_rids. Gives us
again up to ~6x improvement on group membership lookups.
Gerald Carter [Tue, 22 Mar 2005 18:07:58 +0000 (18:07 +0000)]
r5961: final round of compiler warning fixes based on feedback from Jason Mader
Jeremy Allison [Tue, 22 Mar 2005 17:48:41 +0000 (17:48 +0000)]
r5960: Integer wrap paranoia when reading EA buffers.
Jeremy.
Gerald Carter [Tue, 22 Mar 2005 17:31:23 +0000 (17:31 +0000)]
r5958: BUG 1843: patch from james peach to fix quotas (with no soft limits) on IRIX
Gerald Carter [Tue, 22 Mar 2005 17:08:09 +0000 (17:08 +0000)]
r5957: BUGS 2478, 2093: compiler warning patches from Jason Mader
Gerald Carter [Tue, 22 Mar 2005 16:39:09 +0000 (16:39 +0000)]
r5956: more compile warngin fixes from the Mr. Mader
Gerald Carter [Tue, 22 Mar 2005 16:35:15 +0000 (16:35 +0000)]
r5955: BUG 2517: use the realm from smb.conf for 'net ads info' when 'disable netbios = yes'
Günther Deschner [Tue, 22 Mar 2005 15:45:38 +0000 (15:45 +0000)]
r5954: Fix some compiler warnings and add missing exclude-block in "net rpc
share migrate" (found by Lars Mueller <lmuelle@suse.de>).
Guenther
Gerald Carter [Tue, 22 Mar 2005 15:39:24 +0000 (15:39 +0000)]
r5953: more compiler cleanups; moved SID_LIST from smb.h to privileges.c to cleanup the name space
Gerald Carter [Tue, 22 Mar 2005 15:12:50 +0000 (15:12 +0000)]
r5952: BUG 2469: patch from Jason Mader to cleanup compiler warning when not using krb5
Gerald Carter [Tue, 22 Mar 2005 15:03:17 +0000 (15:03 +0000)]
r5951: gotta love that SGI compiler :-) (thanks Jason)
Gerald Carter [Tue, 22 Mar 2005 14:54:12 +0000 (14:54 +0000)]
r5950: more compiler warning's from Jason Mader
Gerald Carter [Tue, 22 Mar 2005 14:48:18 +0000 (14:48 +0000)]
r5948: more compile cleanups from Jason Mader
Gerald Carter [Tue, 22 Mar 2005 14:44:16 +0000 (14:44 +0000)]
r5946: BUG 2497: fix bug in rpcclient's deletedriverex when asking to delete all versions of a driver
Gerald Carter [Tue, 22 Mar 2005 14:39:32 +0000 (14:39 +0000)]
r5945: BUG 2516: fix compile issue on True64
Gerald Carter [Tue, 22 Mar 2005 14:33:30 +0000 (14:33 +0000)]
r5944: cleaning up compiler warnings reported by Jason Mader
Gerald Carter [Tue, 22 Mar 2005 14:20:25 +0000 (14:20 +0000)]
r5943: remove unneccessary se_priv_copy()
Jeremy Allison [Tue, 22 Mar 2005 02:23:52 +0000 (02:23 +0000)]
r5936: Fix bugs in earlier work in progress commit. Closer to properly supporting EA's now.
Jeremy.
Jeremy Allison [Tue, 22 Mar 2005 02:14:38 +0000 (02:14 +0000)]
r5933: We were handling setting of EA's incorrectly - we should be able to set
a list. Also not converting names from DOS CP to UNIX CP correctly. This
code doesn't quite work yet but it's a work in progress to be fixed
tomorrow (don't want to lose it).
Jeremy.
Jim McDonough [Mon, 21 Mar 2005 21:09:21 +0000 (21:09 +0000)]
r5927: Fix ldapsam trusted enum_group_members. We were searching in the user
suffix instead of the group suffix.
Thanks to John Janosik (jpjanosi@us.ibm.com).
Gerald Carter [Mon, 21 Mar 2005 19:07:40 +0000 (19:07 +0000)]
r5926: setting version to 3.0.14pre1-svn
Jeremy Allison [Mon, 21 Mar 2005 18:10:21 +0000 (18:10 +0000)]
r5922: Fix for NASTY NASTY bug #2501. All my fault :-(. Brown paper bag time.
Stops Win98 from looping doing findnext on a singleton directory. More
testing very welcome.
Jeremy.
John Terpstra [Mon, 21 Mar 2005 16:11:44 +0000 (16:11 +0000)]
r5918: Fix typo.
Tim Potter [Sun, 20 Mar 2005 21:54:19 +0000 (21:54 +0000)]
r5916: Only one C++ guard is necessary, not one around each smbc function.
Jelmer Vernooij [Sun, 20 Mar 2005 21:08:50 +0000 (21:08 +0000)]
r5915: Remove --with-manpages-languages= from configure (we only have them in one
lanuage, English, at the moment). Fixes #2261. If other languages
might are added in the future, this parameter will still not be needed.
Simo Sorce [Sun, 20 Mar 2005 18:01:46 +0000 (18:01 +0000)]
r5912: - Enhance net rpc rights utility
- Make it possible to list users that are given a specific privilege
- Make the lisitng interface a bit more usable by distinguishing
between "keys" and "names", using user names directly still
supported for backward compatibility
Volker Lendecke [Sun, 20 Mar 2005 11:51:01 +0000 (11:51 +0000)]
r5910: Partial fix for bug 2438. I'll leave the debug message in place, that fix is a
bit more effort.
The real fix for this would be to open an schannel netlogon connection to the
remote DC and change the trust account password...
Volker
Tim Potter [Sun, 20 Mar 2005 09:23:37 +0000 (09:23 +0000)]
r5909: Remove some unecessary casts. Patch from Jason Mader for bugzill #2468.
Jeremy Allison [Sat, 19 Mar 2005 20:49:09 +0000 (20:49 +0000)]
r5907: Fix compile warning noticed by Jason Mader <jason@ncac.gwu.edu>.
Bug #2483.
Jeremy.
Volker Lendecke [Sat, 19 Mar 2005 18:21:39 +0000 (18:21 +0000)]
r5905: Fix two warnings found by AIX. They might actually be bugs on 64-bit
platforms.
Volker
Steve French [Sat, 19 Mar 2005 05:45:53 +0000 (05:45 +0000)]
r5897: Fix domain name parsing for cifs mount util
Steve French [Sat, 19 Mar 2005 05:00:57 +0000 (05:00 +0000)]
r5896: Fix cifs mounts to handle commas embedded in prompted password, and password and credential files.
Fix cifs mounts to handle domain name and user name in username field (in form domain\user)
Jeremy Allison [Sat, 19 Mar 2005 00:31:45 +0000 (00:31 +0000)]
r5893: Get us to pass some of the Samba4 EA tests. EA_LIST seems to be
working - need to valgrind it to be sure.
Jeremy.
Günther Deschner [Fri, 18 Mar 2005 23:48:46 +0000 (23:48 +0000)]
r5891: Make enum- and getform use the same form_display-function.
Guenther