Martin Pool [Wed, 12 Mar 2003 07:17:39 +0000 (07:17 +0000)]
Update for new version of ComfyChair: some methods are renamed to be
more consistent, and it now looks at command-line arguments to work
out what to do.
Run this program to get a quick demonstration of what ComfyChair does.
Martin Pool [Wed, 12 Mar 2003 07:14:03 +0000 (07:14 +0000)]
New import of ComfyChair, many changes
Martin Pool [Wed, 12 Mar 2003 03:08:28 +0000 (03:08 +0000)]
Import Samba Testing Framework code from private CVS module.
Martin Pool [Wed, 12 Mar 2003 03:07:46 +0000 (03:07 +0000)]
Import design notes by martin and tpot from ComfyChair and stf modules.
Martin Pool [Wed, 12 Mar 2003 03:06:42 +0000 (03:06 +0000)]
Import ComfyChair framework from trunk.
Martin Pool [Wed, 12 Mar 2003 03:04:37 +0000 (03:04 +0000)]
Start importing the Python testing framework that Tim and I have been
working on into the main Samba tree.
Martin Pool [Wed, 12 Mar 2003 02:58:45 +0000 (02:58 +0000)]
Update usage message.
Martin Pool [Wed, 12 Mar 2003 02:57:48 +0000 (02:57 +0000)]
Add example of string overflow which is now caught in developer mode.
Jeremy Allison [Tue, 11 Mar 2003 20:57:41 +0000 (20:57 +0000)]
We use unsigned now, so use %u.
Jeremy.
Jeremy Allison [Tue, 11 Mar 2003 18:10:36 +0000 (18:10 +0000)]
Fix up zero termination. Spotted by Sebastian Krahmer <krahmer@suse.de>.
Jeremy.
Andrew Bartlett [Tue, 11 Mar 2003 11:28:59 +0000 (11:28 +0000)]
This patch attemptes to clean up winbindd's mutex locking.
The current locking scheme in winbind is a complete mess - indeed, the
next step should be to push the locking into cli_full_connection(), but
I'll leave it for now.
This patch works on the noted behaviour that 2 parts of the connection
process need protection - and independent protection. Tim Potter did
some work on this a little while back, verifying the second case.
The two cases are:
- between connect() and first session setup
- during the auth2 phase of the netlogon pipe setup.
I've removed the counter on the lock, as I fail to see what it gains us.
This patch also adds 'anonymous fallback' to our winbindd -> DC connection.
If the authenticated connection fails (wbinfo -A specifed) - say that
account isn't trusted by a trusted DC - then we try an anonymous.
Both tpot and mbp like the patch.
Andrew Bartlett
Andrew Bartlett [Tue, 11 Mar 2003 10:53:46 +0000 (10:53 +0000)]
security=domain and domain logons = yes should be a BDC (of sorts).
Matches 2.2
Andrew Bartlett
Andrew Bartlett [Tue, 11 Mar 2003 10:13:57 +0000 (10:13 +0000)]
Some further tought on the server role issue - try not to break it compeatly.
Andrew Bartlett
Andrew Bartlett [Tue, 11 Mar 2003 10:06:34 +0000 (10:06 +0000)]
After 'consultation' with idra, this is how I think the server roles should work...
Andrew Bartlett
Simo Sorce [Tue, 11 Mar 2003 09:16:37 +0000 (09:16 +0000)]
This is how combination of domain logons and security parameter best combine.
Comments wellcome.
Simo.
Martin Pool [Tue, 11 Mar 2003 07:25:48 +0000 (07:25 +0000)]
Remove valgrind_strlen function, hopefully no longer needed with
recent Valgrind relases and clashing with -DVALGRIND.
Martin Pool [Tue, 11 Mar 2003 07:23:43 +0000 (07:23 +0000)]
Note about using Valgrind with tdbs.
Andrew Tridgell [Tue, 11 Mar 2003 06:53:44 +0000 (06:53 +0000)]
having sticky create times is not a bug
Andrew Tridgell [Tue, 11 Mar 2003 06:53:10 +0000 (06:53 +0000)]
fixed the MANGLE smbtorture test with the new paranoid string code
Andrew Tridgell [Tue, 11 Mar 2003 06:31:23 +0000 (06:31 +0000)]
make sure we have an empty directory when we start the utable test
Martin Pool [Tue, 11 Mar 2003 05:57:53 +0000 (05:57 +0000)]
If using --enable-developer and valgrind.h is present, define VALGRIND.
Martin Pool [Tue, 11 Mar 2003 04:21:14 +0000 (04:21 +0000)]
When opening an existing DB, don't require the hash_size specified to
the open call to be the same as that of the existing tdb. The
specified hash_size is only used if the tdb needs to be (re)created.
With this patch in place, tdbtool can open the printing tdbs, which
are created with a hash_size of 5000. Before it would fail with EIO.
Tim Potter [Tue, 11 Mar 2003 02:30:17 +0000 (02:30 +0000)]
Remove obsolete file.
Martin Pool [Tue, 11 Mar 2003 00:14:55 +0000 (00:14 +0000)]
Patch from Ronan Waide:
> when doing "enumdomusers", rpcclient prints each one preceded by the
> word "group" instead of "user"
Volker Lendecke [Mon, 10 Mar 2003 16:59:29 +0000 (16:59 +0000)]
Some conversion to pstrcpy_base.
Volker
Gerald Carter [Mon, 10 Mar 2003 15:05:06 +0000 (15:05 +0000)]
check a pointer before dereferencing it; not sure why userdata == NULL though
Andrew Bartlett [Mon, 10 Mar 2003 12:08:32 +0000 (12:08 +0000)]
Don't segfault on make_server_info_guest() failure - instead return the
error code.
make_server_info_guest() requires an entry in the SAM at the moment, but
this will change before release.
Andrew Bartlett
Martin Pool [Mon, 10 Mar 2003 03:04:47 +0000 (03:04 +0000)]
Use "$@" to preserve shell quoting in case somebody passes an escaped
string as a configure parameter.
Andrew Tridgell [Mon, 10 Mar 2003 02:51:30 +0000 (02:51 +0000)]
fixed use_oplocks and the timeout in smbtorture startup
Andrew Tridgell [Mon, 10 Mar 2003 02:49:52 +0000 (02:49 +0000)]
added -i option for ignoring dot errors in masktest
Andrew Bartlett [Mon, 10 Mar 2003 02:48:32 +0000 (02:48 +0000)]
Makefile.in for NTLMSSP singing update
Andrew Bartlett [Mon, 10 Mar 2003 02:14:35 +0000 (02:14 +0000)]
Further work on NTLMSSP-based SMB signing. Current status is that I cannnot
get Win2k to send a valid signiture in it's session setup reply - which it will
give to win2k clients.
So, I need to look at becoming 'more like MS', but for now I'll get this code
into the tree. It's actually based on the TNG cli_pipe_ntlmssp.c, as it was
slightly easier to understand than our own (but only the utility functions
remain in any way intact...).
This includes the mysical 'NTLM2' code - I have no idea if it actually works.
(I couldn't get TNG to use it for its pipes either).
Andrew Bartlett
Martin Pool [Mon, 10 Mar 2003 01:10:45 +0000 (01:10 +0000)]
Clobber strings with 0xf1f1f1f1 before writing to them to check buffer
lengths are correct. Attempts to pstrcpy into an fstring or allocated
string should fail in developer builds.
This builds on abartlet's earlier overflow probe for safe_strcpy, but
by clobbering the whole string with a nonzero value is more likely to
find overflows on the stack.
This is only used in -DDEVELOPER mode.
Reviewed by abartlet, tpot.
Martin Pool [Mon, 10 Mar 2003 00:45:28 +0000 (00:45 +0000)]
Include valgrind.h if present on the system.
Martin Pool [Mon, 10 Mar 2003 00:37:25 +0000 (00:37 +0000)]
Check for valgrind.h
Andrew Bartlett [Sun, 9 Mar 2003 21:09:28 +0000 (21:09 +0000)]
Try not to clobber the session request.
Jelmer Vernooij [Sun, 9 Mar 2003 16:39:34 +0000 (16:39 +0000)]
Add Ronan Waide's info about the setdriver call.
Jelmer Vernooij [Sun, 9 Mar 2003 12:08:36 +0000 (12:08 +0000)]
Add some printing question & answers
Andrew Bartlett [Sun, 9 Mar 2003 09:23:09 +0000 (09:23 +0000)]
Change the way we sign SMB packets, to a function pointer interface.
The intention is to allow for NTLMSSP and kerberos signing of packets, but
for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA
spec)
Andrew Bartlett
Andrew Bartlett [Sun, 9 Mar 2003 01:13:41 +0000 (01:13 +0000)]
Don't fault on error returns (ptr == 0) for this LSA query.
(for example, query to non-dc)
Andrew Bartlett
Andrew Bartlett [Sat, 8 Mar 2003 23:39:44 +0000 (23:39 +0000)]
This is C, not C++
Simo Sorce [Sat, 8 Mar 2003 17:29:40 +0000 (17:29 +0000)]
more on idmap
two layers structure with
- local tdb cache
- remote idmap repository
compiles
Jelmer Vernooij [Sat, 8 Mar 2003 17:29:00 +0000 (17:29 +0000)]
Add Q&A for people having trouble trying to log in without a proper
samba user database.
Jelmer Vernooij [Sat, 8 Mar 2003 15:27:54 +0000 (15:27 +0000)]
Add notes on increasing performance on AIX, based on an email from William Jojo
Andrew Bartlett [Sat, 8 Mar 2003 10:24:48 +0000 (10:24 +0000)]
Testparm needs the extra arg to set_local_machine_name() too.
Andrew Bartlett [Sat, 8 Mar 2003 10:22:50 +0000 (10:22 +0000)]
Make sure that the 'remote' machine name can only be set once. For some weird
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.
Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.
(This helps me, by seperating the logs by pid).
Andrew Bartlett
Andrew Bartlett [Sat, 8 Mar 2003 05:18:08 +0000 (05:18 +0000)]
Make it clear that this is a fstrcpy().
Jeremy Allison [Sat, 8 Mar 2003 01:16:30 +0000 (01:16 +0000)]
Fix typo in earlier fix, caught by Ranjit @ HP.
Jeremy.
Simo Sorce [Sat, 8 Mar 2003 00:49:18 +0000 (00:49 +0000)]
some more code
(not tested yet)
Simo Sorce [Fri, 7 Mar 2003 23:47:59 +0000 (23:47 +0000)]
initial work for the new idmpa interface
Jeremy Allison [Fri, 7 Mar 2003 23:34:55 +0000 (23:34 +0000)]
Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy.
Steve French [Fri, 7 Mar 2003 22:29:14 +0000 (22:29 +0000)]
Add early prototype of cifs mount helper for Linux
Jeremy Allison [Fri, 7 Mar 2003 19:46:51 +0000 (19:46 +0000)]
Missed parentheses around complex logic.
Jeremy.
Jeremy Allison [Fri, 7 Mar 2003 19:37:27 +0000 (19:37 +0000)]
Patch from Michael Steffens. In his own words :
-------------------------------------------------------------------------
I think there are basically two problem:
1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
and SMB_ACL_OTHER.
The function ensure_canon_entry_valid() is prepared for that, but tries
to "guess" values from group or other permissions, respectively, otherwise
falling back to minimum r-- for the owner. Even if the owner had full
permissions before setting ACL. This is the problem with W2k clients.
2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
This is ok in a take-ownership situation, but must fail if the file is
to be given away. This is the problem with XP clients, trying to transfer
ownership of the original file to the temp file.
The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.
I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:
1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
as "preserve current value" instead of attempting to build one ourself.
The original code is still in, but only as fallback in case current values
can't be retrieved.
2. Rearrange set_nt_acl() such that chown is only done before setting
ACLs if there is either no change of owning user, or change of owning
user is towards the current user. Otherwise chown is done after setting
ACLs.
It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
Simo Sorce [Fri, 7 Mar 2003 18:26:24 +0000 (18:26 +0000)]
Some progress towards gums and tdbsam2
genparser works fine, and it is a marvelous tool to store objects in tdb :)
Andrew Bartlett [Fri, 7 Mar 2003 09:29:56 +0000 (09:29 +0000)]
Limit the number of SIDs that may be looked up, in line with existing code
for name->sid.
Andrew Bartlett [Fri, 7 Mar 2003 09:25:48 +0000 (09:25 +0000)]
safe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
IP address resolving code.
Jeremy Allison [Fri, 7 Mar 2003 00:34:43 +0000 (00:34 +0000)]
Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy.
Jeremy Allison [Fri, 7 Mar 2003 00:30:29 +0000 (00:30 +0000)]
Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
differently to W2K, cope with this.
Jeremy.
Jelmer Vernooij [Thu, 6 Mar 2003 17:09:07 +0000 (17:09 +0000)]
Add documentation on line returned by 'add printer command' script
Jelmer Vernooij [Thu, 6 Mar 2003 17:05:33 +0000 (17:05 +0000)]
Redirect to printer docs for removed options
Gerald Carter [Thu, 6 Mar 2003 16:06:12 +0000 (16:06 +0000)]
add #define for the max device name length in a DEVICEMODE
Andrew Bartlett [Thu, 6 Mar 2003 10:37:51 +0000 (10:37 +0000)]
Make smbtorture use the same cli_full_connection() framework as the rest of
Samba. This fixes things like not doing *SMBSERVER etc.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Mar 2003 08:24:39 +0000 (08:24 +0000)]
more off-by-one safe_strcpy()
Andrew Bartlett [Thu, 6 Mar 2003 07:55:48 +0000 (07:55 +0000)]
More safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())
Andrew Bartlett
Martin Pool [Thu, 6 Mar 2003 07:36:08 +0000 (07:36 +0000)]
FIXME about crash on failure case.
Richard Sharpe [Wed, 5 Mar 2003 23:55:11 +0000 (23:55 +0000)]
Add *SMBSERVER fallback code to smbtorture ...
Richard Sharpe [Wed, 5 Mar 2003 23:29:36 +0000 (23:29 +0000)]
Add code to allow us to specify the port to connect on when performing
a test ...
Andrew Bartlett [Wed, 5 Mar 2003 09:40:08 +0000 (09:40 +0000)]
Use new configure test to turn on this automated test for correct string
function usage.
Andrew Bartlett
Andrew Bartlett [Wed, 5 Mar 2003 09:36:41 +0000 (09:36 +0000)]
A couple more fixes for fstrcpy() into a malloced region. In this case it's
all perfectly legit - the region is an fstring in length, but might not
always be, and it is the last peice of code to fail my automated test.
Andrew Bartlett
Andrew Bartlett [Wed, 5 Mar 2003 09:33:43 +0000 (09:33 +0000)]
Add a test for a useful property of the compiler - we can get link-time
failures for some compile-time properties this way.
Andrew Bartlett
Andrew Bartlett [Wed, 5 Mar 2003 08:49:56 +0000 (08:49 +0000)]
also ignore the autom4te-2.53.cache
Andrew Bartlett [Wed, 5 Mar 2003 08:48:08 +0000 (08:48 +0000)]
This file has not been maintained for a while - if we really want this
behaviour we should seperate -g from --enable-developer, and allow developers
to also select --enable-debug if they want.
Andrew Bartlett
Martin Pool [Wed, 5 Mar 2003 05:19:35 +0000 (05:19 +0000)]
lp_string: Add note about dodgy StrnCpy use.
Tim Potter [Wed, 5 Mar 2003 05:14:19 +0000 (05:14 +0000)]
Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
command. From Ronan Waide <waider@waider.ie>.
Jeremy Allison [Wed, 5 Mar 2003 01:34:37 +0000 (01:34 +0000)]
More const fixes.
Jeremy.
Jeremy Allison [Wed, 5 Mar 2003 01:30:26 +0000 (01:30 +0000)]
Writable string const fixes.
Jeremy.
Jeremy Allison [Wed, 5 Mar 2003 00:54:07 +0000 (00:54 +0000)]
Connectathon fix. W2K -> W2K over port 445 doing a tconX does the full
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
Andrew Bartlett [Tue, 4 Mar 2003 09:33:34 +0000 (09:33 +0000)]
Fix another 'off by one' bug with safe_strcpy(). It is unclear if the intent
was to limit the string to 31 or 32 characters (excluding the null term), so
I've assumed for now that 32 is fine, as this matches current behaviour (well, current behaviour would crash, but anyway...)
Jerry: Can you look at this for me?
Andrew Bartlett
Andrew Bartlett [Mon, 3 Mar 2003 23:53:35 +0000 (23:53 +0000)]
Another pstrcpy() into malloc()ed buffer fix.
Andrew Bartlett
Jeremy Allison [Mon, 3 Mar 2003 20:12:07 +0000 (20:12 +0000)]
Const warning fixes.
Jeremy.
Jeremy Allison [Mon, 3 Mar 2003 19:53:04 +0000 (19:53 +0000)]
dlsym takes a const char *.
Jeremy.
Jeremy Allison [Mon, 3 Mar 2003 19:36:16 +0000 (19:36 +0000)]
Fix "might be used uninitialised" warnings.
Jeremy.
Richard Sharpe [Mon, 3 Mar 2003 17:43:33 +0000 (17:43 +0000)]
Do my janitorial duties to encourage others to do so.
Fix lingering large offset problems in smbtar etc.
Gerald Carter [Mon, 3 Mar 2003 17:33:57 +0000 (17:33 +0000)]
* always report ourselves as a Windows 2000 print server (even
without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
Gerald Carter [Mon, 3 Mar 2003 16:34:19 +0000 (16:34 +0000)]
* CR1868: only send a change notify message if we have something
that changed that the client is monitoring.
* couple of comments abnout how we need to validate driver names
on SetPrinter() and AddPrinter()
* up the debug level on some overly verbose dev mode parsing messages
Andrew Bartlett [Mon, 3 Mar 2003 09:16:21 +0000 (09:16 +0000)]
Try the PASSWD environment variable if we don't have one from the command line.
Andrew Bartlett [Mon, 3 Mar 2003 09:12:40 +0000 (09:12 +0000)]
Fixes to the vfs_fake_perms modules - we only need to specify the VFS
functions that we actually modify.
Also a better implementation of the stat() and fstat() functions.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Mar 2003 08:35:49 +0000 (08:35 +0000)]
Add const
Andrew Tridgell [Sat, 1 Mar 2003 10:47:38 +0000 (10:47 +0000)]
i forgot to commit the privilege db init call
Jeremy Allison [Sat, 1 Mar 2003 02:39:14 +0000 (02:39 +0000)]
Added limit to number of jobs enumerated. Set to 0 (means no limit).
Yes I will add the docs....
Jeremy.
Andrew Tridgell [Sat, 1 Mar 2003 01:07:18 +0000 (01:07 +0000)]
the new DEVELOPER checks for string overflows have (as expected)
broken a lot of stuff. These two macros are meant to make life easier
when fixing these bugs. I'm guessing we will see more macros like
this (eg. fstrcpy_base)
Jeremy Allison [Sat, 1 Mar 2003 00:48:09 +0000 (00:48 +0000)]
Ensure added jobs increment total_jobs.
Jeremy.
Jelmer Vernooij [Fri, 28 Feb 2003 08:47:22 +0000 (08:47 +0000)]
Fix HTTP error codes (patch by Vance Lankhaar)
Andrew Tridgell [Fri, 28 Feb 2003 06:03:35 +0000 (06:03 +0000)]
fixed a crash bug in the new winbindd 'sids rule!' code
Martin Pool [Fri, 28 Feb 2003 05:34:19 +0000 (05:34 +0000)]
Doxygen janitor: add note that strequal is in fact case-insensitive.
Andrew Tridgell [Fri, 28 Feb 2003 04:36:08 +0000 (04:36 +0000)]
- added help on -P option
- added general options to 'net -h' help
Martin Pool [Fri, 28 Feb 2003 04:21:55 +0000 (04:21 +0000)]
Doxygen janitor
Martin Pool [Fri, 28 Feb 2003 04:17:30 +0000 (04:17 +0000)]
Doxygen janitor: fix parameter names, grammar, tag names.
Martin Pool [Fri, 28 Feb 2003 04:11:28 +0000 (04:11 +0000)]
Doxygen janitor: rpc_resolve_dc parameter is spelled "trust_passwd"