samba.git
11 years agoComplete the fix for bug 6100
Volker Lendecke [Thu, 5 Mar 2009 21:20:55 +0000 (22:20 +0100)]
Complete the fix for bug 6100

According to [MS-RPCE].pdf, section 2.2.2.11:

----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----

RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.

Thanks to Nick Meier <nmeier@microsoft.com>

Volker

11 years agoFix bug #6160 - Office 2007 fails saving files to a Samba mapped drive.
Jeremy Allison [Thu, 5 Mar 2009 17:04:16 +0000 (09:04 -0800)]
Fix bug #6160 - Office 2007 fails saving files to a Samba mapped drive.
Confirmed by reporters.
Jeremy.

11 years agolibrpc: Re-run make idl_full from source3
Tim Prouty [Thu, 5 Mar 2009 02:29:18 +0000 (18:29 -0800)]
librpc: Re-run make idl_full from source3

11 years agopidl: Don't generate variables declarations for pointless array counters.
Tim Prouty [Tue, 3 Mar 2009 21:04:14 +0000 (13:04 -0800)]
pidl: Don't generate variables declarations for pointless array counters.

Code isn't generated to iterate over arrays of length 0, but the
variable declarations still are.  The result is 'unused variable'
warnings. This only seems to be happening in one place right now, so I
targeted the fix to this case, but refactoring could be done to make
all variable declarations do this zero length check.  Making it the
default would be a much more invasive fix.

Jelmer, please check!

11 years agos3 OneFS: Use the public open_streams_for_delete
Tim Prouty [Wed, 4 Mar 2009 03:27:50 +0000 (19:27 -0800)]
s3 OneFS: Use the public open_streams_for_delete

11 years agos3: Change open_streams_for_delete to call through the vfs layer
Tim Prouty [Wed, 4 Mar 2009 03:23:33 +0000 (19:23 -0800)]
s3: Change open_streams_for_delete to call through the vfs layer

This eliminates the last direct caller of create_file_unixpath

11 years agoFix careless mistake in winbindd_setup_sig_usr2_handler
Bo Yang [Thu, 5 Mar 2009 01:26:57 +0000 (17:26 -0800)]
Fix careless mistake in winbindd_setup_sig_usr2_handler

11 years agoSecond part of fix for #6154, ensure we return max access
Jeremy Allison [Thu, 5 Mar 2009 01:17:43 +0000 (17:17 -0800)]
Second part of fix for #6154, ensure we return max access
if admin user.
Jeremy.

11 years agoFix bug #6154 - zfs does not honor admin users.
Jeremy Allison [Thu, 5 Mar 2009 00:57:37 +0000 (16:57 -0800)]
Fix bug #6154 - zfs does not honor admin users.
Jeremy

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel
Andrew Bartlett [Thu, 5 Mar 2009 00:11:19 +0000 (11:11 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel

11 years agoRemove parse_control from header, long after the function was removed
Andrew Bartlett [Thu, 5 Mar 2009 00:07:35 +0000 (11:07 +1100)]
Remove parse_control from header, long after the function was removed

Simo reminded me that when (long ago) I moved parse_controls away from
this place, I forgot to update the manually maintained header file.

Andrew Bartlett

11 years agoUpdate talloc version so we don't fail on system talloc 1.2.0
Andrew Bartlett [Wed, 4 Mar 2009 23:46:46 +0000 (10:46 +1100)]
Update talloc version so we don't fail on system talloc 1.2.0

The problem is that talloc in the Samba tree now includes
talloc_get_type_abort(), which is not present on Fedora 10 or ubuntu's
talloc 1.2.0.

Andrew Bartlett

11 years agoFix crashes when running RAW-ACLs against system with tdb ACL modules
Jeremy Allison [Wed, 4 Mar 2009 22:48:33 +0000 (14:48 -0800)]
Fix crashes when running RAW-ACLs against system with tdb ACL modules
(caused by the POSIX pathname fixes).
Jeremy.

11 years agos3:dbwrap_ctdb_marshall_add: don't leak the ctdb_rec_data to the outside
Michael Adam [Wed, 4 Mar 2009 21:05:17 +0000 (22:05 +0100)]
s3:dbwrap_ctdb_marshall_add: don't leak the ctdb_rec_data to the outside

Michael

11 years agos3:smbconf: move smbconf_share_exists checks into backend
Michael Adam [Wed, 4 Mar 2009 21:02:07 +0000 (22:02 +0100)]
s3:smbconf: move smbconf_share_exists checks into backend

Michael

11 years agos3:net conf: reduce memory usage of "net conf import".
Michael Adam [Wed, 4 Mar 2009 20:46:32 +0000 (21:46 +0100)]
s3:net conf: reduce memory usage of "net conf import".

"net conf import" was wrapped in one big transaction.
This lead to MAX_TALLOC_SIZE being exceeded at roughly
1500 shares. This patch resolves that problem by
limiting the top level transactions in "net conf import"
to 100 shares.

Michael

11 years agosocket wrapper: Fix 'might be used uninitialized' warning
Tim Prouty [Wed, 4 Mar 2009 20:59:16 +0000 (12:59 -0800)]
socket wrapper: Fix 'might be used uninitialized' warning

11 years agos3: Remove madvise support
Steven Danneman [Wed, 4 Mar 2009 19:04:31 +0000 (11:04 -0800)]
s3: Remove madvise support

This reverts 193be432.  The MADVISE_PROTECT is inherited by all child
processes and cannot be unset.  The intention of the original patch was
to protect the parent process, but allow children to be killed in low
memory.  Since this isn't possible with the current API, reverting the
whole feature.

11 years agoAttempt to fix the build on IRIX
Volker Lendecke [Wed, 4 Mar 2009 11:21:26 +0000 (12:21 +0100)]
Attempt to fix the build on IRIX

11 years agoMake use of gpfs_get_real_filename optional
Volker Lendecke [Mon, 2 Mar 2009 13:56:01 +0000 (14:56 +0100)]
Make use of gpfs_get_real_filename optional

11 years agos3: Fix a memleak in dbwrap_rbt.
Michael Adam [Fri, 27 Feb 2009 14:28:52 +0000 (15:28 +0100)]
s3: Fix a memleak in dbwrap_rbt.

The SMB_MALLOC'ed rbt node data was not free'd on talloc free of
the db context. This is a quick fix using talloc instead of malloc
for allocation of the node data.

Since malloc was originally used for performance reasons, one
might want to reverse to malloc and create a talloc destructor
that walks the tree and frees all the node data if this talloc
approach proves to be too slow..

Michael

11 years agosocket_wrapper: add multiple interface support for ipv6
Stefan Metzmacher [Tue, 3 Mar 2009 15:45:41 +0000 (16:45 +0100)]
socket_wrapper: add multiple interface support for ipv6

We use FD00::5357:5FXX in the same way we use 127.0.0.XX

metze

11 years agosocket_wrapper: add ipv6 pcap support
Stefan Metzmacher [Tue, 3 Mar 2009 14:43:22 +0000 (15:43 +0100)]
socket_wrapper: add ipv6 pcap support

metze

11 years agosocket_wrapper: pass down sockaddr instead of sockaddr_in to prepare pcap support...
Stefan Metzmacher [Tue, 3 Mar 2009 14:17:26 +0000 (15:17 +0100)]
socket_wrapper: pass down sockaddr instead of sockaddr_in to prepare pcap support for ipv6

metze

11 years agosocket_wrapper: prepare pcap support for ipv6 traffic
Stefan Metzmacher [Tue, 3 Mar 2009 13:58:53 +0000 (14:58 +0100)]
socket_wrapper: prepare pcap support for ipv6 traffic

metze

11 years agos4:blackbox/test_ldb: make use of the $VALGRIND envvar
Stefan Metzmacher [Tue, 3 Mar 2009 18:23:25 +0000 (19:23 +0100)]
s4:blackbox/test_ldb: make use of the $VALGRIND envvar

metze

11 years agosocket_wrapper: don't crash if we get EAGAIN from real_recv()
Stefan Metzmacher [Tue, 3 Mar 2009 18:20:43 +0000 (19:20 +0100)]
socket_wrapper: don't crash if we get EAGAIN from real_recv()

This fixes a crash in the ldaps tests with socket wrapper pcap support.

metze

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Wed, 4 Mar 2009 03:10:41 +0000 (14:10 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel

11 years agoPull in all the schema information during DRS schema fetch
Andrew Bartlett [Wed, 4 Mar 2009 03:06:11 +0000 (14:06 +1100)]
Pull in all the schema information during DRS schema fetch

This includes things such as allowed attributes, which were not
populated into the schema structure before.

Andrew Bartlett

11 years agoDon't print the admin password if we don't set one.
Andrew Bartlett [Wed, 4 Mar 2009 03:02:35 +0000 (14:02 +1100)]
Don't print the admin password if we don't set one.

For example, if we don't create the admin user (perhaps expecting
users to be in LDAP already, or we are due an incoming replication) we
should not confuse the administrator by printing a unused password.

Andrew Bartlett

11 years agoAllow 'net vampire' to work without an existing smb.conf
Andrew Bartlett [Wed, 4 Mar 2009 02:58:07 +0000 (13:58 +1100)]
Allow 'net vampire' to work without an existing smb.conf

Now the provision can generate one based on the detected settings from
the target domain.

Andrew Bartlett

11 years agos3 passdb: Add back some useful debug statements
Tim Prouty [Wed, 4 Mar 2009 00:47:48 +0000 (16:47 -0800)]
s3 passdb: Add back some useful debug statements

Originally removed in be1dfff02d562e42a7847bd02fed8538630d3f41

11 years agoFix bug #6155 - "force group" is no longer working as expected.
Jeremy Allison [Wed, 4 Mar 2009 00:08:56 +0000 (16:08 -0800)]
Fix bug #6155 - "force group" is no longer working as expected.
We need to store the "force group" uid separately from the
conn->server_info token as we need to apply it separately also.
Volker PLEASE CHECK !
Jeremy.

11 years agos3 OneFS: Add parameter to ignore streams
Tim Prouty [Sat, 28 Feb 2009 00:25:31 +0000 (16:25 -0800)]
s3 OneFS: Add parameter to ignore streams

11 years agolib/util: remove samba specific talloc_get_type_abort()
Stefan Metzmacher [Tue, 3 Mar 2009 17:03:57 +0000 (18:03 +0100)]
lib/util: remove samba specific talloc_get_type_abort()

metze

11 years agotalloc: add talloc_get_type_abort()
Stefan Metzmacher [Tue, 3 Mar 2009 17:01:01 +0000 (18:01 +0100)]
talloc: add talloc_get_type_abort()

metze

11 years agoFix "ignore return" warning.
Jeremy Allison [Tue, 3 Mar 2009 16:50:35 +0000 (08:50 -0800)]
Fix "ignore return" warning.
Jeremy.

11 years agoIt appears that the first time we see a uid/gid that winbind can't map,
Dan Sledz [Tue, 3 Mar 2009 00:50:19 +0000 (16:50 -0800)]
It appears that the first time we see a uid/gid that winbind can't map,
we end up returning the null sid instead of falling back to the legacy
code.  Next time through the code we'll hit the negative cache and do
the right thing, but we still fail the first time.

If we fail the winbind id to sid mapping, call the legacy version.  This
catches the case where we don't have a negative cache entry for the mapping.
This is better than returning the NULL sid to the caller.

11 years agoMore fix to initialize idmap statuses
Bo Yang [Mon, 2 Mar 2009 06:19:50 +0000 (14:19 +0800)]
More fix to initialize idmap statuses

11 years agouse test -f, Solaris /bin/sh doesn't know test -e
Björn Jacke [Mon, 2 Mar 2009 16:01:37 +0000 (17:01 +0100)]
use test -f, Solaris /bin/sh doesn't know test -e

11 years agoFix wbclient.c wrt tevent_req changes too.
Simo Sorce [Mon, 2 Mar 2009 20:38:45 +0000 (15:38 -0500)]
Fix wbclient.c wrt tevent_req changes too.

11 years agoAttempt to fix the build
Volker Lendecke [Mon, 2 Mar 2009 19:10:13 +0000 (20:10 +0100)]
Attempt to fix the build

Simo, with which compiler did you build this? I'd be curious to learn about the
compiler settings that make this build.

Thanks,

Volker

11 years agoMake struct tevent_req opaque
Simo Sorce [Sat, 28 Feb 2009 20:44:30 +0000 (15:44 -0500)]
Make struct tevent_req opaque

Move struct tevent_req in tevent_internal, and ad getters and setters
for private data and the callback function.
This patch also renames 'private_state' into 'data'. What is held in this
pointer is in fact data and not a state like enum tevent_req_state.
Calling it 'state' is confusing.

The functions addedd are:
tevent_req_set_callback() - sets req->async.fn and req->async.private_data
tevent_req_set_print_fn() - sets req->private_print
tevent_req_callback_data() - gets req->async.private_data
tevent_req_data() - gets rea->data

This way it is much simpler to keep API/ABI compatibility in the future.

11 years agos3-spoolss: PRINTER_STATUS_OK has been moved to IDL.
Günther Deschner [Mon, 2 Mar 2009 12:09:19 +0000 (13:09 +0100)]
s3-spoolss: PRINTER_STATUS_OK has been moved to IDL.

Guenther

11 years agos3-rpcclient: zero out devmode and secdesc in setdriver and setprinter command.
Günther Deschner [Mon, 2 Mar 2009 10:21:26 +0000 (11:21 +0100)]
s3-rpcclient: zero out devmode and secdesc in setdriver and setprinter command.

Guenther

11 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 2 Mar 2009 13:23:42 +0000 (14:23 +0100)]
s3: re-run make samba3-idl.

Guenther

11 years agospoolss: move up printer and job status codes.
Günther Deschner [Mon, 2 Mar 2009 12:08:55 +0000 (13:08 +0100)]
spoolss: move up printer and job status codes.

Guenther

11 years agospoolss: use dummy pointers for truncated devmode and secdesc in SetJobInfo2/4.
Günther Deschner [Mon, 2 Mar 2009 10:19:57 +0000 (11:19 +0100)]
spoolss: use dummy pointers for truncated devmode and secdesc in SetJobInfo2/4.

Guenther

11 years agoerror-codes: add WERR_DEVICE_NOT_CONNECTED.
Günther Deschner [Mon, 2 Mar 2009 12:07:46 +0000 (13:07 +0100)]
error-codes: add WERR_DEVICE_NOT_CONNECTED.

Guenther

11 years agomake man page (un)install more portable
Björn Jacke [Sun, 1 Mar 2009 20:08:33 +0000 (21:08 +0100)]
make man page (un)install more portable

11 years agosome shells are picky about ^ without quotes
Björn Jacke [Sun, 1 Mar 2009 20:38:31 +0000 (21:38 +0100)]
some shells are picky about ^ without quotes

11 years agos3/docs: Add missing full stop.
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.

Karolin

11 years agolibcli/security: fix the source4 build
Stefan Metzmacher [Mon, 2 Mar 2009 11:05:43 +0000 (12:05 +0100)]
libcli/security: fix the source4 build

metze

11 years agolibcli/security: fix the source3 build
Stefan Metzmacher [Mon, 2 Mar 2009 07:55:00 +0000 (08:55 +0100)]
libcli/security: fix the source3 build

metze

11 years agoFix test_surrounding in samba4.rpcecho.python.
Jelmer Vernooij [Mon, 2 Mar 2009 04:07:30 +0000 (05:07 +0100)]
Fix test_surrounding in samba4.rpcecho.python.

11 years agoUse samba3's own iconv implementation for now, until all changes are
Jelmer Vernooij [Mon, 2 Mar 2009 04:04:07 +0000 (05:04 +0100)]
Use samba3's own iconv implementation for now, until all changes are
merged.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Mon, 2 Mar 2009 03:15:11 +0000 (04:15 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoImport ISO-8859-1, 646 from Samba 3 iconv.
Jelmer Vernooij [Mon, 2 Mar 2009 03:12:57 +0000 (04:12 +0100)]
Import ISO-8859-1, 646 from Samba 3 iconv.

11 years agos3: Fix incompatible type warnings
Tim Prouty [Sun, 1 Mar 2009 21:58:46 +0000 (13:58 -0800)]
s3: Fix incompatible type warnings

11 years agos3 OneFS: Refactor config code and cleanup includes
Tim Prouty [Fri, 27 Feb 2009 22:47:47 +0000 (14:47 -0800)]
s3 OneFS: Refactor config code and cleanup includes

11 years agoUse shared header file for character sets, remove old definitions from samba3 smb.h.
Jelmer Vernooij [Sun, 1 Mar 2009 21:31:10 +0000 (22:31 +0100)]
Use shared header file for character sets, remove old definitions from samba3 smb.h.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 21:25:57 +0000 (22:25 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoUse common header file for character set handling in Samba 3 and Samba 4.
Jelmer Vernooij [Sun, 1 Mar 2009 21:24:34 +0000 (22:24 +0100)]
Use common header file for character set handling in Samba 3 and Samba 4.

11 years agoAdd header files for secace and secacl.
Jelmer Vernooij [Sun, 1 Mar 2009 19:06:55 +0000 (20:06 +0100)]
Add header files for secace and secacl.

11 years agos4: Use same function signature for convert_* as s3.
Jelmer Vernooij [Sun, 1 Mar 2009 18:55:46 +0000 (19:55 +0100)]
s4: Use same function signature for convert_* as s3.

11 years agoMove secacl to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:36 +0000 (18:15 +0100)]
Move secacl to top-level.

11 years agodom_sid.h: Include dependency security.h that provides the dom_sid struct.
Jelmer Vernooij [Sun, 1 Mar 2009 17:15:15 +0000 (18:15 +0100)]
dom_sid.h: Include dependency security.h that provides the dom_sid struct.

11 years agoAlso re-add removed codepoint_t; I'm clearly not having my day today.
Jelmer Vernooij [Sun, 1 Mar 2009 17:05:22 +0000 (18:05 +0100)]
Also re-add removed codepoint_t; I'm clearly not having my day today.

11 years agoKeep using Samba3's charset.h for now.
Jelmer Vernooij [Sun, 1 Mar 2009 17:02:24 +0000 (18:02 +0100)]
Keep using Samba3's charset.h for now.

11 years agoMove secace.c to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 16:59:30 +0000 (17:59 +0100)]
Move secace.c to top-level.

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 16:29:04 +0000 (17:29 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
Jelmer Vernooij [Sun, 1 Mar 2009 16:13:10 +0000 (17:13 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next

11 years agoRerun pidl.
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:45 +0000 (17:09 +0100)]
Rerun pidl.

11 years agoDon't generate array iterators when the length of the array is always 0.
Jelmer Vernooij [Sun, 1 Mar 2009 16:09:07 +0000 (17:09 +0100)]
Don't generate array iterators when the length of the array is always 0.
(bug #6140)

11 years agoMerge branch 'master' of git://git.samba.org/samba into convenience
Jelmer Vernooij [Sun, 1 Mar 2009 15:41:57 +0000 (16:41 +0100)]
Merge branch 'master' of git://git.samba.org/samba into convenience

11 years agoMerge branch 'master' of git://git.samba.org/samba into teventfix
Jelmer Vernooij [Sun, 1 Mar 2009 15:39:35 +0000 (16:39 +0100)]
Merge branch 'master' of git://git.samba.org/samba into teventfix

Conflicts:
lib/tevent/pytevent.c

11 years agoAvoid using tevent_util.h, which won't be available if we use the system
Jelmer Vernooij [Sun, 1 Mar 2009 15:38:07 +0000 (16:38 +0100)]
Avoid using tevent_util.h, which won't be available if we use the system
tevent.

11 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
Jelmer Vernooij [Sun, 1 Mar 2009 15:23:53 +0000 (16:23 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next

11 years agoMove next_token_talloc to util.c, as util_str.c is only compiled inside samba 4.
Jelmer Vernooij [Sun, 1 Mar 2009 15:19:38 +0000 (16:19 +0100)]
Move next_token_talloc to util.c, as util_str.c is only compiled inside samba 4.

11 years agoMove next_token_talloc() to top-level.
Jelmer Vernooij [Sun, 1 Mar 2009 15:16:16 +0000 (16:16 +0100)]
Move next_token_talloc() to top-level.

11 years agoSync smb_iconv_t type, convert_string return type with Samba 3 equivalents.
Jelmer Vernooij [Sun, 1 Mar 2009 11:59:58 +0000 (12:59 +0100)]
Sync smb_iconv_t type, convert_string return type with Samba 3 equivalents.

11 years agoOnly copy sharename up from rap_to_pjobid
Volker Lendecke [Sun, 1 Mar 2009 10:39:44 +0000 (11:39 +0100)]
Only copy sharename up from rap_to_pjobid

Why?? :-)

Another one of the little micro-optimizations that I just came across: If you
allocate a variable in a sub-block like the "fstring sharename" in
write_file(), gcc even with -O3 will allocate this variable unconditionally on
the stack at the beginning of the routine. So with eliminating this fstring we
cut 256 bytes of stack in a very hot code path writing to a file. It might make
us a bit more cache-friendly.

This would probably not be worth a second look if it involved larger code
changes, but this one was just too simple to let it pass :-)

11 years agoAdd allow_badcharcnv argument to all conversion function, for
Jelmer Vernooij [Sun, 1 Mar 2009 05:33:40 +0000 (06:33 +0100)]
Add allow_badcharcnv argument to all conversion function, for
consistency with Samba 3.

11 years agoMerge branch 'master' of git://git.samba.org/samba into HEAD
Jelmer Vernooij [Sun, 1 Mar 2009 04:46:15 +0000 (05:46 +0100)]
Merge branch 'master' of git://git.samba.org/samba into HEAD

11 years agoEliminate two duplicate SEC_ACE_TYPE constants already provided by
Jelmer Vernooij [Sun, 1 Mar 2009 03:59:07 +0000 (04:59 +0100)]
Eliminate two duplicate SEC_ACE_TYPE constants already provided by
security.idl.

11 years agoFix bug #6082 - smbd_gpfs_getacl failed: Windows client can´t rename or
Jeremy Allison [Sat, 28 Feb 2009 21:14:23 +0000 (13:14 -0800)]
Fix bug #6082 - smbd_gpfs_getacl failed: Windows client can´t rename or
delete file (directory fix).
Jeremy.

11 years agoFix async reading winbindd_response
Volker Lendecke [Sat, 28 Feb 2009 11:20:56 +0000 (12:20 +0100)]
Fix async reading winbindd_response

11 years agoSimplify async_connect_send slightly
Volker Lendecke [Sat, 28 Feb 2009 11:19:24 +0000 (12:19 +0100)]
Simplify async_connect_send slightly

11 years agoAnd the prize for the most pain caused in the build farm for a simple
Jeremy Allison [Sat, 28 Feb 2009 04:57:49 +0000 (20:57 -0800)]
And the prize for the most pain caused in the build farm for a simple
typo goes to.....
Tim Prouty !!!!
Sorry Tim, nice test but you made a typo in passing in
the size of an array so we were reading uninitialized
memory :-).
That took far longer than it should have to track down...
(%$&#ing build system....).
The build farm should now slowly go back to normal.
Jeremy.

11 years agoInitialize the id_map status in idmap_ldap to avoid surprise
Bo Yang [Thu, 26 Feb 2009 09:44:33 +0000 (17:44 +0800)]
Initialize the id_map status in idmap_ldap to avoid surprise

11 years agos3: re-run make samba3-idl.
Günther Deschner [Fri, 27 Feb 2009 12:33:51 +0000 (13:33 +0100)]
s3: re-run make samba3-idl.

Guenther

11 years agospoolss: fill in spoolss_SetJobInfo1,2,3,4.
Günther Deschner [Fri, 27 Feb 2009 12:31:02 +0000 (13:31 +0100)]
spoolss: fill in spoolss_SetJobInfo1,2,3,4.

Guenther

11 years agospoolss: add spoolss_PortInfo3 and spoolss_PortInfoFF.
Günther Deschner [Fri, 27 Feb 2009 10:27:44 +0000 (11:27 +0100)]
spoolss: add spoolss_PortInfo3 and spoolss_PortInfoFF.

Guenther

11 years agos3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.
Günther Deschner [Thu, 26 Feb 2009 22:40:58 +0000 (23:40 +0100)]
s3-spoolss: use DSPRINT flags instead of SPOOLS_DS flags.

Guenther

11 years agoUse talloc_tos() in regkey_access_check()
Volker Lendecke [Fri, 27 Feb 2009 10:18:35 +0000 (11:18 +0100)]
Use talloc_tos() in regkey_access_check()

11 years agos3: fix guest auth when winbindd is running
Steven Danneman [Fri, 27 Feb 2009 01:47:32 +0000 (17:47 -0800)]
s3: fix guest auth when winbindd is running

This fix is very subtle.  If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.

This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid().  Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.

This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.

11 years agos3-rpcclient: add getjob spoolss command.
Günther Deschner [Thu, 26 Feb 2009 14:35:12 +0000 (15:35 +0100)]
s3-rpcclient: add getjob spoolss command.

Guenther

11 years agos3-rpcclient: use is_valid_policy_hnd before closing handles.
Günther Deschner [Thu, 26 Feb 2009 14:33:16 +0000 (15:33 +0100)]
s3-rpcclient: use is_valid_policy_hnd before closing handles.

Guenther

11 years agos3-spoolss: remove old rpccli_spoolss_getjob.
Günther Deschner [Thu, 26 Feb 2009 14:34:46 +0000 (15:34 +0100)]
s3-spoolss: remove old rpccli_spoolss_getjob.

Guenther

11 years agos3-spoolss: add rpccli_spoolss_getjob convenience wrapper.
Günther Deschner [Thu, 26 Feb 2009 14:33:57 +0000 (15:33 +0100)]
s3-spoolss: add rpccli_spoolss_getjob convenience wrapper.

Guenther