samba.git
7 years agoselftest: Do not start up an already-running test environment
Andrew Bartlett [Tue, 14 Feb 2012 21:55:05 +0000 (08:55 +1100)]
selftest: Do not start up an already-running test environment

Otherwise we may re-provision the dc just because we started it via s3member or s4member
first.

Andrew Bartlett

7 years agoselftest: Make plugin_s4_dc set the cached environment correctly
Andrew Bartlett [Wed, 15 Feb 2012 05:08:05 +0000 (16:08 +1100)]
selftest: Make plugin_s4_dc set the cached environment correctly

7 years agowintest: update WinXP-1 snapshot
Andrew Bartlett [Thu, 16 Feb 2012 02:51:10 +0000 (13:51 +1100)]
wintest: update WinXP-1 snapshot

7 years agowintest: Change Windows 7 VM
Andrew Bartlett [Thu, 16 Feb 2012 00:34:49 +0000 (11:34 +1100)]
wintest: Change Windows 7 VM

7 years agowintest: Give the Windows VM a little more time to start back up
Andrew Bartlett [Wed, 15 Feb 2012 03:44:24 +0000 (14:44 +1100)]
wintest: Give the Windows VM a little more time to start back up

7 years agowintest: Samba is now all version 4.0
Andrew Bartlett [Tue, 14 Feb 2012 23:08:07 +0000 (10:08 +1100)]
wintest: Samba is now all version 4.0

7 years agowintest: Cope with nc not timing out even when -w 1 is specified
Andrew Bartlett [Tue, 14 Feb 2012 22:29:27 +0000 (09:29 +1100)]
wintest: Cope with nc not timing out even when -w 1 is specified

7 years agowintest: s3 moved smb.conf to /etc
Andrew Bartlett [Tue, 14 Feb 2012 11:43:50 +0000 (22:43 +1100)]
wintest: s3 moved smb.conf to /etc

7 years agowintest: Update VM used for W2K8R2A
Andrew Bartlett [Tue, 14 Feb 2012 10:42:44 +0000 (21:42 +1100)]
wintest: Update VM used for W2K8R2A

7 years agowintest: Allow access denied when turning off the firewall
Andrew Bartlett [Thu, 16 Feb 2012 03:01:44 +0000 (14:01 +1100)]
wintest: Allow access denied when turning off the firewall

7 years agowintest: Retry joining the domain a few times
Andrew Bartlett [Thu, 16 Feb 2012 02:51:55 +0000 (13:51 +1100)]
wintest: Retry joining the domain a few times

7 years agowintest: connect to correct hostname in test_net_use
Andrew Bartlett [Thu, 16 Feb 2012 02:51:32 +0000 (13:51 +1100)]
wintest: connect to correct hostname in test_net_use

7 years agos3-nmbd: Initialise newly non-static variables
Andrew Bartlett [Tue, 14 Feb 2012 22:56:43 +0000 (09:56 +1100)]
s3-nmbd: Initialise newly non-static variables

Found by testing with wintest.  When the variables were made non-static in
c21f6a1c6869a5086634bb830d6c3689dea539a3 the implicit initialisation to 0
was lost.

Andrew Bartlett

7 years agos3: Add SERVERID_UNIQUE_ID_NOT_TO_VERIFY, bug 8760
Volker Lendecke [Wed, 15 Feb 2012 10:22:45 +0000 (11:22 +0100)]
s3: Add SERVERID_UNIQUE_ID_NOT_TO_VERIFY, bug 8760

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 15 21:10:22 CET 2012 on sn-devel-104

7 years agos3-printing: fix crash in printer_list_set_printer()
David Disseldorp [Wed, 15 Feb 2012 15:30:27 +0000 (16:30 +0100)]
s3-printing: fix crash in printer_list_set_printer()

The printer list database format was recently changed to accommodate for
the printcap location field.
One of the tdb_pack calls is not provided with a location string
argument, this causes a crash on some platforms.

https://bugzilla.samba.org/show_bug.cgi?id=8762

Signed-off-by: Günther Deschner <gd@samba.org>
Signed-off-by: Jim McDonough <jmcd@samba.org>
Signed-off-by: Lars Müller <lars@samba.org>
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Wed Feb 15 19:34:38 CET 2012 on sn-devel-104

7 years agotevent_signal: Fix a valgrind error
Volker Lendecke [Wed, 15 Feb 2012 15:17:34 +0000 (16:17 +0100)]
tevent_signal: Fix a valgrind error

This fixes an uninitialized read introduced by my fix for the tevent_signal
destructors. From looking at the code you might believe that this kicks in only
when talloc failed. But with -O3 I do see it in normal operations.

Sorry for that.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 15 17:58:37 CET 2012 on sn-devel-104

7 years agos3: files_struct->mode is only written, remove it
Volker Lendecke [Tue, 14 Feb 2012 16:37:09 +0000 (17:37 +0100)]
s3: files_struct->mode is only written, remove it

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue Feb 14 19:14:29 CET 2012 on sn-devel-104

7 years agotdb: build and run unit tests in tdb/test/
Rusty Russell [Tue, 14 Feb 2012 04:15:29 +0000 (14:45 +1030)]
tdb: build and run unit tests in tdb/test/

Now we can build the test binaries: the CCAN style is to compile
everything called "compile_ok*.c", compile and run everything called
"run*.c", compile, link with the module, and run everything called
"api*.c", and link any other C files (presumably test helpers) into
all the tests.

Unfortunately, actually passing that between the various parts of
wscript is painful, so I open-coded the names.

Also, the tests expect to be run in a (temporary) directory they can
pollute, with the test directory found in test/ (to find the canned
TDB files, for example).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Feb 14 06:53:46 CET 2012 on sn-devel-104

7 years agotdb/test: fix up tests for use in SAMBA tdb code.
Rusty Russell [Tue, 14 Feb 2012 04:15:21 +0000 (14:45 +1030)]
tdb/test: fix up tests for use in SAMBA tdb code.

1) Make sure we include "tdb_private.h" first, to get the right headers
   (esp. the correct setting of _FILE_OFFSET_BITS before unistd.h).
2) Fix 3G file test since expand logic has changed.
3) Fix nested transaction test, since default is to allow nesting.
4) Capture fdatasync, which was slowing down transaction expand.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotdb: wean CCAN-style unit tests off of tap.
Rusty Russell [Tue, 14 Feb 2012 04:15:19 +0000 (14:45 +1030)]
tdb: wean CCAN-style unit tests off of tap.

We could use subunit, but that's overkill.  Just print messages when
we fail, and use exit status.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotdb: import unit tests from CCAN into tdb/test/
Rusty Russell [Mon, 13 Feb 2012 17:35:43 +0000 (04:05 +1030)]
tdb: import unit tests from CCAN into tdb/test/

I pulled tdb into CCAN as an experiment a while ago; it doesn't belong
there, but it has accumulated some important unit tests.

These are copied from CCAN version init-1486-gc438ec1 with #include "../"
changed to #include "../common/".

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotdb: make tdb_private.h idempotent.
Rusty Russell [Mon, 13 Feb 2012 17:34:43 +0000 (04:04 +1030)]
tdb: make tdb_private.h idempotent.

The most convenient way to write unit tests in C is to directly
#include the C files (CCAN uses this, for example).  That works quite
well, but it means that tdb_private.h now needs to be protected
against multiple inclusions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agos4:torture: add another SMB2 rename test
Christian Ambach [Mon, 13 Feb 2012 15:47:41 +0000 (16:47 +0100)]
s4:torture: add another SMB2 rename test

this mimics Word 2010 saving a file

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon Feb 13 18:33:43 CET 2012 on sn-devel-104

7 years agolibndr: Add ndr_map_error2errno
Volker Lendecke [Mon, 13 Feb 2012 12:27:22 +0000 (13:27 +0100)]
libndr: Add ndr_map_error2errno

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb 13 15:06:29 CET 2012 on sn-devel-104

7 years agos3-auth: On successful user mapping set mapped_to_guest to false.
Sumit Bose [Sat, 11 Feb 2012 16:52:07 +0000 (17:52 +0100)]
s3-auth: On successful user mapping set mapped_to_guest to false.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon Feb 13 13:09:10 CET 2012 on sn-devel-104

7 years agos3-selftest: Do not assume $USERNAME is the same as $DC_USERNAME
Andrew Bartlett [Mon, 13 Feb 2012 01:36:21 +0000 (12:36 +1100)]
s3-selftest: Do not assume $USERNAME is the same as $DC_USERNAME

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 13 06:13:38 CET 2012 on sn-devel-104

7 years agoselftest: Allow setup_env() to signal that an environment name is unknown
Andrew Bartlett [Mon, 13 Feb 2012 01:14:57 +0000 (12:14 +1100)]
selftest: Allow setup_env() to signal that an environment name is unknown

This will allow us to skip samba4 environments that may be mentioned in
the source3/selftest/tests.py file.

Andrew Bartlett

7 years agos3-build: expliticly require gssapi for HAVE_KRB5 and remove HAVE_GSSAPI
Andrew Bartlett [Mon, 13 Feb 2012 00:26:24 +0000 (11:26 +1100)]
s3-build: expliticly require gssapi for HAVE_KRB5 and remove HAVE_GSSAPI

The requirement for gss functions already make this happen, but
this is clearer.  No code depends on HAVE_GSSAPI any more.

Andrew Bartlett

7 years agos3-libads: Move to using only the HAVE_KRB5 define
Andrew Bartlett [Mon, 13 Feb 2012 00:23:15 +0000 (11:23 +1100)]
s3-libads: Move to using only the HAVE_KRB5 define

HAVE_KRB5 already implies that GSSAPI is present as well.

Andrew Bartlett

7 years agos3-lib/addns: Move to system/kerberos.h and HAVE_KRB5
Andrew Bartlett [Mon, 13 Feb 2012 00:21:11 +0000 (11:21 +1100)]
s3-lib/addns: Move to system/kerberos.h and HAVE_KRB5

7 years agos4-dsdb: Check if metadata.tdb exists, before trying to open it
Amitay Isaacs [Mon, 13 Feb 2012 00:07:06 +0000 (11:07 +1100)]
s4-dsdb: Check if metadata.tdb exists, before trying to open it

This fixes the error output from tdb2 when metadata module tries
to create metadata.tdb first time. This error is reported since
metadata module tries to check if tdb exists by trying to open
tdb file.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Mon Feb 13 03:02:09 CET 2012 on sn-devel-104

7 years agoauth: Pass in the SMB username (for %U) into generate_session_info
Andrew Bartlett [Mon, 30 Jan 2012 10:49:33 +0000 (21:49 +1100)]
auth: Pass in the SMB username (for %U) into generate_session_info

This matches what Samba3 does.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 13 01:25:59 CET 2012 on sn-devel-104

7 years agos4:join python code - "msDS-KeyVersionNumber" does not exist on Win2k
Matthias Dieter Wallnöfer [Mon, 30 Jan 2012 16:20:28 +0000 (17:20 +0100)]
s4:join python code - "msDS-KeyVersionNumber" does not exist on Win2k

No problem since "secretsdb_self_join()" then chooses 1 as a default
value.
Fix case sensitivity for "msDS-KeyVersionNumber".

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agoLDB:pyldb.c - use always the case insensitive comparison for attribute names
Matthias Dieter Wallnöfer [Sat, 11 Feb 2012 11:48:20 +0000 (12:48 +0100)]
LDB:pyldb.c - use always the case insensitive comparison for attribute names

We can make no assumptions about our users

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
7 years agowafsamba: Add tests for dict_concat.
Jelmer Vernooij [Sun, 12 Feb 2012 17:42:17 +0000 (18:42 +0100)]
wafsamba: Add tests for dict_concat.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 12 20:17:54 CET 2012 on sn-devel-104

7 years agowafsamba: Add tests for unique_list, subst_vars_error.
Jelmer Vernooij [Sun, 12 Feb 2012 16:48:01 +0000 (17:48 +0100)]
wafsamba: Add tests for unique_list, subst_vars_error.

7 years agowaf: Add initial unit test for samba_utils.
Jelmer Vernooij [Sun, 12 Feb 2012 16:35:20 +0000 (17:35 +0100)]
waf: Add initial unit test for samba_utils.

7 years agogitignore: Ignore waf cache files.
Jelmer Vernooij [Sun, 12 Feb 2012 13:38:37 +0000 (14:38 +0100)]
gitignore: Ignore waf cache files.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 12 16:14:49 CET 2012 on sn-devel-104

7 years agomkversion: Add quotes around various version strings
Amitay Isaacs [Thu, 9 Feb 2012 23:58:30 +0000 (10:58 +1100)]
mkversion: Add quotes around various version strings

This fixes compilation errors when VENDOR strings are specified.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Sat Feb 11 09:07:54 CET 2012 on sn-devel-104

7 years agos3-waf: add dependency on talloc or it won't build if talloc.h is not in the default...
Matthieu Patou [Tue, 7 Feb 2012 18:46:43 +0000 (10:46 -0800)]
s3-waf: add dependency on talloc or it won't build if talloc.h is not in the default include path

The problem occurs only if talloc, tdb and ldb are used as system
libraries and talloc is not installed in a default.

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Feb 10 23:27:29 CET 2012 on sn-devel-104

7 years agos3-winbindd: set the can_do_validation6 also for trusted domain
Matthieu Patou [Fri, 10 Feb 2012 19:45:21 +0000 (11:45 -0800)]
s3-winbindd: set the can_do_validation6 also for trusted domain

The flag can_do_validation6 was only set for the domain to which
winbindd is the member. Setting this flag in other domains (trusted
domain) if it's active directory domain is a good idea as it allow to do
level 6 validation also when winbindd is querying them directly.

7 years agos3:smbd/oplock_linux: don't overwrite private_data
Stefan Metzmacher [Fri, 10 Feb 2012 18:49:05 +0000 (19:49 +0100)]
s3:smbd/oplock_linux: don't overwrite private_data

We set ctx->private_data = sconn a few lines above
and expect 'sconn' in the signal event handler.

Thanks to Christian Ambach <ambi@samba.org> for the
bug report.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb 10 21:48:18 CET 2012 on sn-devel-104

7 years agos3:vfs_gpfs:quieten an expectable warning message
Christian Ambach [Fri, 10 Feb 2012 17:15:56 +0000 (18:15 +0100)]
s3:vfs_gpfs:quieten an expectable warning message

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Feb 10 20:14:12 CET 2012 on sn-devel-104

7 years agos3:vfs_gpfs: fix a compiler warning
Christian Ambach [Fri, 10 Feb 2012 17:11:30 +0000 (18:11 +0100)]
s3:vfs_gpfs: fix a compiler warning

7 years agos3:vfs_gpfs:Fix query of creation time from GPFS
Christof Schmitt [Tue, 29 Nov 2011 20:23:29 +0000 (13:23 -0700)]
s3:vfs_gpfs:Fix query of creation time from GPFS

Setting the creation time through SetFileTime on a GPFS file system and
querying it with GetFileTime shows a mismatch.

The vfs_gpfs module first retrieves the information from the operating
system and the flag st_ex_calculated_birthtime is set to false. When
vfs_gpfs retrieves the birthtime from GPFS the flag
st_ex_calculated_birthtime has to be set to true. Otherwise the birth
time will get overwritten by a call to update_stat_ex_mtime, reporting
the wrong time to a client system.

Signed-off-by: Christian Ambach <ambi@samba.org>
7 years agos3:vfs_gpfs: make "gpfs:getrealfilename" a per share option
Stefan Metzmacher [Thu, 22 Dec 2011 14:54:41 +0000 (15:54 +0100)]
s3:vfs_gpfs: make "gpfs:getrealfilename" a per share option

metze

Signed-off-by: Christian Ambach <ambi@samba.org>
7 years agos3:vfs_gpfs: make "gpfs:ftruncate" a per share option
Stefan Metzmacher [Thu, 22 Dec 2011 14:54:41 +0000 (15:54 +0100)]
s3:vfs_gpfs: make "gpfs:ftruncate" a per share option

metze

Signed-off-by: Christian Ambach <ambi@samba.org>
7 years agos3:vfs_gpfs: make "gpfs:winattr" a per share option
Stefan Metzmacher [Thu, 22 Dec 2011 13:36:55 +0000 (14:36 +0100)]
s3:vfs_gpfs: make "gpfs:winattr" a per share option

metze

Signed-off-by: Christian Ambach <ambi@samba.org>
7 years agos3:vfs_gpfs: be less verbose in get/set_xattr functions
Stefan Metzmacher [Thu, 22 Dec 2011 13:20:32 +0000 (14:20 +0100)]
s3:vfs_gpfs: be less verbose in get/set_xattr functions

metze

Signed-off-by: Christian Ambach <ambi@samba.org>
7 years agos3-smb2: Use the correct indicator if a request was deferred
Volker Lendecke [Fri, 10 Feb 2012 11:49:28 +0000 (12:49 +0100)]
s3-smb2: Use the correct indicator if a request was deferred

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Feb 10 16:44:23 CET 2012 on sn-devel-104

7 years agos3-smb2: Make sure we have a subreq set
Volker Lendecke [Fri, 10 Feb 2012 11:48:30 +0000 (12:48 +0100)]
s3-smb2: Make sure we have a subreq set

7 years agoselftest: add smb2.rename to testsuite
Christian Ambach [Wed, 8 Feb 2012 15:05:34 +0000 (16:05 +0100)]
selftest: add smb2.rename to testsuite

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Feb 10 15:02:51 CET 2012 on sn-devel-104

7 years agos4:torture: add some SMB2 renaming tests
Christian Ambach [Tue, 7 Feb 2012 17:02:56 +0000 (18:02 +0100)]
s4:torture: add some SMB2 renaming tests

7 years agogensec: explain gensec_use_kerberos_mechs() logic
Andrew Bartlett [Fri, 10 Feb 2012 09:54:18 +0000 (20:54 +1100)]
gensec: explain gensec_use_kerberos_mechs() logic

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 10 12:36:23 CET 2012 on sn-devel-104

7 years agogensec: set flag to continue in outer for loop in gensec_use_kerberos_mechs
Andrew Bartlett [Thu, 9 Feb 2012 21:13:40 +0000 (08:13 +1100)]
gensec: set flag to continue in outer for loop in gensec_use_kerberos_mechs

This should be the correct fix for the valgrind erorr Volker found in
744ed53a62037a659133ccd4de2065491208ae7d.  This fix avoids putting
SPNEGO into the list twice when we are in the CRED_DONT_USE_KERBEROS
case.

Andrew Bartlett

7 years agoRevert "gensec: Fix a memory corruption in gensec_use_kerberos_mechs"
Andrew Bartlett [Thu, 9 Feb 2012 21:07:21 +0000 (08:07 +1100)]
Revert "gensec: Fix a memory corruption in gensec_use_kerberos_mechs"

This reverts commit 744ed53a62037a659133ccd4de2065491208ae7d.

The real bug here is that the second half of the outer loop should not
have been run once we found spnego.

Andrew Bartlett

7 years agoselftest: mark posix_s3.rpc.spoolss.printer as flakey test
Stefan Metzmacher [Fri, 10 Feb 2012 07:26:40 +0000 (08:26 +0100)]
selftest: mark posix_s3.rpc.spoolss.printer as flakey test

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb 10 10:04:15 CET 2012 on sn-devel-104

7 years agos4-nbt_server: remove unused winsdb_get_seqnumber()
Andrew Bartlett [Thu, 9 Feb 2012 00:25:58 +0000 (11:25 +1100)]
s4-nbt_server: remove unused winsdb_get_seqnumber()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 10 08:21:41 CET 2012 on sn-devel-104

7 years agos3-libsmb: Remove unused kerberos_set_creds_enctype()
Andrew Bartlett [Thu, 9 Feb 2012 04:37:50 +0000 (15:37 +1100)]
s3-libsmb: Remove unused kerberos_set_creds_enctype()

Also remove the unused configure tests for krb5_c_enctype_compare.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-libsmb: Remove unused kerberos_compatible_enctypes
Andrew Bartlett [Thu, 9 Feb 2012 04:34:45 +0000 (15:34 +1100)]
s3-libsmb: Remove unused kerberos_compatible_enctypes

Also remove the unused configure tests for krb5_c_enctype_compare.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-lib: Remove unused is_myworkgroup()
Andrew Bartlett [Thu, 9 Feb 2012 04:20:24 +0000 (15:20 +1100)]
s3-lib: Remove unused is_myworkgroup()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-charcnv: Remove unused rpcstr_push()
Andrew Bartlett [Thu, 9 Feb 2012 02:40:52 +0000 (13:40 +1100)]
s3-charcnv: Remove unused rpcstr_push()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-libsmb: Remove unused smb_krb5_mk_error()
Andrew Bartlett [Thu, 9 Feb 2012 02:29:06 +0000 (13:29 +1100)]
s3-libsmb: Remove unused smb_krb5_mk_error()

Also remove now-unused configure checks for krb5_mk_error().

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-param: Remove unused share_defined()
Andrew Bartlett [Thu, 9 Feb 2012 02:24:46 +0000 (13:24 +1100)]
s3-param: Remove unused share_defined()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos4-lib/samba3: Remove unused smbpasswd_decode_acb_info()
Andrew Bartlett [Thu, 9 Feb 2012 02:22:37 +0000 (13:22 +1100)]
s4-lib/samba3: Remove unused smbpasswd_decode_acb_info()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agolib/util: Remove unused str_format_nbt_domain()
Andrew Bartlett [Thu, 9 Feb 2012 01:49:45 +0000 (12:49 +1100)]
lib/util: Remove unused str_format_nbt_domain()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agocharset: Remove unused strcmp_w()
Andrew Bartlett [Thu, 9 Feb 2012 01:46:38 +0000 (12:46 +1100)]
charset: Remove unused strcmp_w()

Found by callcatcher.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos4-lib/tls: remove unused tls_support()
Andrew Bartlett [Thu, 9 Feb 2012 00:28:19 +0000 (11:28 +1100)]
s4-lib/tls: remove unused tls_support()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos4-cmdline: Remove unused popt_common_dont_ask()
Andrew Bartlett [Thu, 9 Feb 2012 00:18:43 +0000 (11:18 +1100)]
s4-cmdline: Remove unused popt_common_dont_ask()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-lib: Remove unused pid_path()
Andrew Bartlett [Thu, 9 Feb 2012 00:17:02 +0000 (11:17 +1100)]
s3-lib: Remove unused pid_path()

piddir.c calls lp_piddir() directly.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-registry: Remove unused prs_uint8()
Andrew Bartlett [Thu, 9 Feb 2012 00:13:29 +0000 (11:13 +1100)]
s3-registry: Remove unused prs_uint8()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agos3-charcnv: Remove unused pull_string_fn
Andrew Bartlett [Thu, 9 Feb 2012 00:11:10 +0000 (11:11 +1100)]
s3-charcnv: Remove unused pull_string_fn

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agocharset: Remove unused iconv_talloc()
Andrew Bartlett [Wed, 8 Feb 2012 23:49:49 +0000 (10:49 +1100)]
charset: Remove unused iconv_talloc()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

7 years agobuild: Add --enable-coverage option to build with gcov support
Andrew Bartlett [Fri, 10 Feb 2012 04:19:05 +0000 (15:19 +1100)]
build: Add --enable-coverage option to build with gcov support

This allows running lcov over the output.

Andrew Bartlett

7 years agoheimdal: Re-run lexyacc.sh to remove #line statements
Andrew Bartlett [Thu, 9 Feb 2012 21:53:15 +0000 (08:53 +1100)]
heimdal: Re-run lexyacc.sh to remove #line statements

7 years agoheimdal_build: omit #line statments
Andrew Bartlett [Thu, 9 Feb 2012 21:49:05 +0000 (08:49 +1100)]
heimdal_build: omit #line statments

This restores and finishes my original commit
80e23c68d83a7c9989f87d5a88a78bb76d222afc, reverted in
68c61a829b8487104483b23052b54c532fecb6ce

    heimdal_build omit #line statments to allow valgrind to work again

This time however, the reason to omit line statements is that it
causes more trouble with the lcov code coverage system than the (nil)
value that these statements bring.  Otherwise, we have to have a
special case to remove the .gcno and .gcda files for these generated
files.

Andrew Bartlett

7 years agoheimdal: Re-run lexyacc.sh
Andrew Bartlett [Thu, 9 Feb 2012 21:43:59 +0000 (08:43 +1100)]
heimdal: Re-run lexyacc.sh

7 years agocredentials: Show returned error_string in debug message
Andrew Bartlett [Thu, 9 Feb 2012 21:14:59 +0000 (08:14 +1100)]
credentials: Show returned error_string in debug message

7 years agotests/source: Add wafsamba/ files to list of Python files to check.
Jelmer Vernooij [Thu, 9 Feb 2012 12:12:06 +0000 (13:12 +0100)]
tests/source: Add wafsamba/ files to list of Python files to check.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Feb 10 01:45:16 CET 2012 on sn-devel-104

7 years agowafsamba: Expand tabs.
Jelmer Vernooij [Thu, 9 Feb 2012 12:08:31 +0000 (13:08 +0100)]
wafsamba: Expand tabs.

7 years agogensec: Fix a memory corruption in gensec_use_kerberos_mechs
Volker Lendecke [Thu, 9 Feb 2012 15:07:12 +0000 (16:07 +0100)]
gensec: Fix a memory corruption in gensec_use_kerberos_mechs

Without this I get the following valgrind error:

==27740== Invalid write of size 8
==27740==    at 0x62C53E: gensec_use_kerberos_mechs (gensec_start.c:112)
==27740==    by 0x62C623: gensec_security_mechs (gensec_start.c:141)
==27740==    by 0x62C777: gensec_security_by_oid (gensec_start.c:181)
==27740==    by 0x62DD6E: gensec_start_mech_by_oid (gensec_start.c:735)
==27740==    by 0x50D6FD: negprot_spnego (negprot.c:210)
==27740==    by 0x5B0DEA: smbd_smb2_request_process_negprot (smb2_negprot.c:209)
==27740==    by 0x5AD036: smbd_smb2_request_dispatch (smb2_server.c:1417)
==27740==    by 0x5AFB77: smbd_smb2_first_negprot (smb2_server.c:2643)
==27740==    by 0x585C00: process_smb (process.c:1641)
==27740==    by 0x587F78: smbd_server_connection_read_handler (process.c:2314)
==27740==    by 0x587FD6: smbd_server_connection_handler (process.c:2331)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x584AFF: smbd_server_connection_loop_once (process.c:984)
==27740==    by 0x58B2D9: smbd_process (process.c:3389)
==27740==    by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==    by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==    by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==    by 0xDE6DD8: main (server.c:1413)
==27740==  Address 0x9ff3538 is 4,232 bytes inside a block of size 8,288 alloc'd
==27740==    at 0x4C261D7: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27740==    by 0x6926965: __talloc (talloc.c:560)
==27740==    by 0x6926771: talloc_pool (talloc.c:598)
==27740==    by 0x93B927: talloc_stackframe_internal (talloc_stack.c:145)
==27740==    by 0x93B9D6: talloc_stackframe_pool (talloc_stack.c:171)
==27740==    by 0x58B2B7: smbd_process (process.c:3385)
==27740==    by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==    by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==    by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==    by 0xDE6DD8: main (server.c:1413)

In the for-loop we can increment j twice, so we need twice as many output array
elements as input array elements.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Feb  9 19:44:47 CET 2012 on sn-devel-104

7 years agos3-printing: Add new printers to registry.
Björn Baumbach [Tue, 7 Feb 2012 10:41:54 +0000 (11:41 +0100)]
s3-printing: Add new printers to registry.

This fixes bug #8554, #8612 and #8748.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb  9 16:39:04 CET 2012 on sn-devel-104

7 years agos3-libsmb: Remove obsolete smb_krb5_locate_kdc.
Andreas Schneider [Wed, 30 Nov 2011 16:58:30 +0000 (17:58 +0100)]
s3-libsmb: Remove obsolete smb_krb5_locate_kdc.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb  9 14:58:57 CET 2012 on sn-devel-104

7 years agos3-net: Don't use an internal krb5 for kdc lookup.
Andreas Schneider [Wed, 30 Nov 2011 16:39:22 +0000 (17:39 +0100)]
s3-net: Don't use an internal krb5 for kdc lookup.

This replaces the use of the internal krb5_locate_kdc() function with
our own get_kdc_list() function.

Signed-off-by: Günther Deschner <gd@samba.org>
7 years agotevent: change the version to 0.9.15 tevent-0.9.15
Stefan Metzmacher [Thu, 9 Feb 2012 09:11:19 +0000 (10:11 +0100)]
tevent: change the version to 0.9.15

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb  9 12:24:19 CET 2012 on sn-devel-104

7 years agotevent: Fix deleting signal events from within themselves
Volker Lendecke [Sat, 28 Jan 2012 21:18:00 +0000 (22:18 +0100)]
tevent: Fix deleting signal events from within themselves

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agosmbwrapper: Remove smbwrapper
Andrew Bartlett [Fri, 3 Feb 2012 04:06:48 +0000 (15:06 +1100)]
smbwrapper: Remove smbwrapper

There are now many better ways to access a remote SMB filesystem,
which do not rely on LD_PRELOAD and the associated dangers.  FUSE,
gvfs and the CIFS VFS are all much better options which do not require
knowing every possible libc entry point that can deal with a file
descriptor.

As an example of the maintainence that would be required to keep this
going, recent changes to deal with thread races and close-on-exec have
resulted in dup3(), but this isn't currently mapped.  While this would
not be hard to add, it illistrates why it is better to move to an
interface designed for this task.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb  9 01:58:24 CET 2012 on sn-devel-104

7 years agos3-build: remove EXEEXT from Makefiles
Andrew Bartlett [Wed, 25 Jan 2012 22:23:23 +0000 (09:23 +1100)]
s3-build: remove EXEEXT from Makefiles

As far as I am aware, we do not actually build on any platforms that
require this.  The last Stratos VOS release on
ftp://ftp.stratus.com/vos/samba/samba.html was 3.0.5

Andrew Bartlett

7 years agos4:join python code - perform a fallback password set operation over libnet
Matthias Dieter Wallnöfer [Mon, 14 Nov 2011 16:53:39 +0000 (17:53 +0100)]
s4:join python code - perform a fallback password set operation over libnet

Windows 2000 DCs allow LDAP password set operations only with the help of SSL.
Given the fact that this technique is hard to setup it is easier to use SAMR
over "libnet".

Reviewed-By: Andrew Bartlett <abartlet@samba.org>
7 years agos4:join python code - write the SAM account name correctly
Matthias Dieter Wallnöfer [Sun, 8 Jan 2012 15:41:54 +0000 (16:41 +0100)]
s4:join python code - write the SAM account name correctly

It is easier for the comprehension

Reviewed-By: Andrew Bartlett <abartlet@samba.org>
7 years agoFix shadow variable name warning.
Jeremy Allison [Wed, 8 Feb 2012 20:15:04 +0000 (12:15 -0800)]
Fix shadow variable name warning.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb  8 22:55:08 CET 2012 on sn-devel-104

7 years agoregshell: Fix a counter that can actually be non-zero.
Jelmer Vernooij [Wed, 8 Feb 2012 13:17:17 +0000 (14:17 +0100)]
regshell: Fix a counter that can actually be non-zero.

This was a regression caused by one of the unsigned patches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb  8 16:00:22 CET 2012 on sn-devel-104

7 years agos3-passdb: Remove #if _SAMBA_BUILD_ == 4 from pdb_samba4
Andrew Bartlett [Wed, 8 Feb 2012 06:41:54 +0000 (17:41 +1100)]
s3-passdb: Remove #if _SAMBA_BUILD_ == 4 from pdb_samba4

pdb_samba4 is only built with waf anyway.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb  8 09:17:40 CET 2012 on sn-devel-104

7 years agos3-docs: Remove references to long-gone smbmount utilities
Andrew Bartlett [Fri, 3 Feb 2012 03:51:59 +0000 (14:51 +1100)]
s3-docs: Remove references to long-gone smbmount utilities

7 years agoauth: rename ntlmssp.c to ntlmssp_util.c
Andrew Bartlett [Mon, 30 Jan 2012 21:54:22 +0000 (08:54 +1100)]
auth: rename ntlmssp.c to ntlmssp_util.c

7 years agos3-auth Add const to make_user_info_map
Andrew Bartlett [Mon, 30 Jan 2012 11:44:28 +0000 (22:44 +1100)]
s3-auth Add const to make_user_info_map

7 years agos4-messaging: fix pymessaging docstring
Andrew Bartlett [Mon, 6 Feb 2012 06:44:34 +0000 (17:44 +1100)]
s4-messaging: fix pymessaging docstring

7 years agos3-build use common VERSION file for all builds
Andrew Bartlett [Mon, 4 Jul 2011 00:14:27 +0000 (10:14 +1000)]
s3-build use common VERSION file for all builds

There is no need to have both version files at this point.

Andrew Bartlett

7 years agopidl: add more mapped types
Andrew Tridgell [Wed, 8 Feb 2012 02:01:32 +0000 (13:01 +1100)]
pidl: add more mapped types

when we #define one type to another, we need special handling in the
python generator

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb  8 04:50:06 CET 2012 on sn-devel-104

7 years agoidl: wmi and dcom don't need python bindings
Andrew Tridgell [Wed, 8 Feb 2012 02:00:29 +0000 (13:00 +1100)]
idl: wmi and dcom don't need python bindings

the python generation for these IDL files is currently broken