samba.git
8 years agos3-lib use True and False in bitmap.c
Andrew Bartlett [Thu, 7 Jul 2011 08:18:38 +0000 (18:18 +1000)]
s3-lib use True and False in bitmap.c

8 years agos3-param: calculate default_server_announce at runtime
Andrew Bartlett [Thu, 7 Jul 2011 04:10:54 +0000 (14:10 +1000)]
s3-param: calculate default_server_announce at runtime

8 years agos3-param Remove lp_set_passdb_backend()
Andrew Bartlett [Thu, 7 Jul 2011 03:45:13 +0000 (13:45 +1000)]
s3-param Remove lp_set_passdb_backend()

8 years agos3-zfsacl: Fix a debug message
Volker Lendecke [Fri, 8 Jul 2011 08:06:58 +0000 (10:06 +0200)]
s3-zfsacl: Fix a debug message

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jul  8 11:22:55 CEST 2011 on sn-devel-104

8 years agos3:wscript_build: remove unused variable
Stefan Metzmacher [Thu, 7 Jul 2011 17:48:43 +0000 (19:48 +0200)]
s3:wscript_build: remove unused variable

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul  8 02:43:22 CEST 2011 on sn-devel-104

8 years agos3:selftest: run SMB2-BASIC
Stefan Metzmacher [Thu, 7 Jul 2011 23:03:49 +0000 (01:03 +0200)]
s3:selftest: run SMB2-BASIC

metze

8 years agos3:torture: add SMB2-BASIC
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:torture: add SMB2-BASIC

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_query_directory*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_query_directory*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_write*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_write*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_read*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_read*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_flush*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_flush*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_close*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_close*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_create*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_create*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_tcon*() and smb2cli_tdis*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_tcon*() and smb2cli_tdis*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_sesssetup*() and smb2cli_logoff*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_sesssetup*() and smb2cli_logoff*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add smb2cli_negprot*()
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add smb2cli_negprot*()

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agos3:libsmb: add basic smb2 client infrastructure
Stefan Metzmacher [Thu, 5 May 2011 16:12:07 +0000 (18:12 +0200)]
s3:libsmb: add basic smb2 client infrastructure

Based on the initial patch from Volker Lendecke <vl@samba.org>.

metze

8 years agoFix bug #8293 - SMB2 doesn't rotate the log files often enough.
Jeremy Allison [Thu, 7 Jul 2011 21:59:41 +0000 (14:59 -0700)]
Fix bug #8293 - SMB2 doesn't rotate the log files often enough.

Move the num_requests field out of the smb1 struct into the generic
struct smbd_server_connection struct. Use it to count SMB2 requests
as well as SMB1 and ensure that check_log_size() is called every 50
SMB2 requests.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jul  8 01:14:53 CEST 2011 on sn-devel-104

8 years agos3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()
Stefan Metzmacher [Thu, 7 Jul 2011 14:38:33 +0000 (16:38 +0200)]
s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()

For all requests which don't operate on a tcon, we should call
change_to_root_user(), to match the SMB1 behavior.

For SMB1 we do the following operations without AS_USER:

/* 0x70 */ { "SMBtcon",reply_tcon,0},
/* 0x71 */ { "SMBtdis",reply_tdis,DO_CHDIR},
/* 0x72 */ { "SMBnegprot",reply_negprot,0},
/* 0x73 */ { "SMBsesssetupX",reply_sesssetup_and_X,0},
/* 0x74 */ { "SMBulogoffX",reply_ulogoffX, 0}, /* ulogoff doesn't give a valid TID */
/* 0x75 */ { "SMBtconX",reply_tcon_and_X,0},
...
/* 0x2b */ { "SMBecho",reply_echo,0},
...
/* 0xa4 */ { "SMBntcancel",reply_ntcancel, 0 },

For SMB2tdis we still call smbd_smb2_request_check_tcon()
as close_cnum() calls change_to_root_user() when needed.

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
8 years agolibcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB
Björn Baumbach [Thu, 7 Jul 2011 15:43:46 +0000 (17:43 +0200)]
libcli: remove duplicate of #define NT_STATUS_NO_SUCH_JOB

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jul  7 20:29:13 CEST 2011 on sn-devel-104

8 years agos3-client: Remove use of cli_errstr()
Björn Baumbach [Thu, 7 Jul 2011 15:36:22 +0000 (17:36 +0200)]
s3-client: Remove use of cli_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-libsmb: Remove use of cli_errstr()
Björn Baumbach [Thu, 7 Jul 2011 15:18:40 +0000 (17:18 +0200)]
s3-libsmb: Remove use of cli_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-torture: run_shortname_test: Remove uses of cli_errstr()
Björn Baumbach [Thu, 7 Jul 2011 14:56:05 +0000 (16:56 +0200)]
s3-torture: run_shortname_test: Remove uses of cli_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-torture: run_simple_posix_open_test: Remove uses of cli_errstr()
Björn Baumbach [Thu, 7 Jul 2011 14:49:12 +0000 (16:49 +0200)]
s3-torture: run_simple_posix_open_test: Remove uses of cli_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-torture: use nt_errstr() for cli_unlink() error handling
Stefan Metzmacher [Thu, 7 Jul 2011 15:56:19 +0000 (17:56 +0200)]
s3-torture: use nt_errstr() for cli_unlink() error handling

Use nt_errstr() instead of cli_errstr() for error handling on
cli_unlink() calls.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-torture: introduce check_both_error()
Björn Baumbach [Thu, 7 Jul 2011 14:27:39 +0000 (16:27 +0200)]
s3-torture: introduce check_both_error()

Check if the server produced the expected dos or nt error code like
check_error(), but without a cli_state struct.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3:libsmb: finally remove unused cli_state->outbuf
Stefan Metzmacher [Thu, 7 Jul 2011 16:16:56 +0000 (18:16 +0200)]
s3:libsmb: finally remove unused cli_state->outbuf

metze

8 years agos3:libsmb: remove unused clistr_push_fn()
Stefan Metzmacher [Thu, 7 Jul 2011 15:24:32 +0000 (17:24 +0200)]
s3:libsmb: remove unused clistr_push_fn()

metze

8 years agos3:libsmb: remove unused clistr_pull_fn()
Stefan Metzmacher [Wed, 6 Jul 2011 15:57:45 +0000 (17:57 +0200)]
s3:libsmb: remove unused clistr_pull_fn()

metze

8 years agos3:torture/scanner: use trans2_bytes_push_str() in scan_nttrans()
Stefan Metzmacher [Thu, 7 Jul 2011 13:38:02 +0000 (15:38 +0200)]
s3:torture/scanner: use trans2_bytes_push_str() in scan_nttrans()

metze

8 years agos3:torture/scanner: use trans2_bytes_push_str() in scan_trans2()
Stefan Metzmacher [Thu, 7 Jul 2011 13:38:02 +0000 (15:38 +0200)]
s3:torture/scanner: use trans2_bytes_push_str() in scan_trans2()

metze

8 years agos3:libsmb: use trans2_bytes_push_str() in cli_tcon_andx_create() for the plaintext...
Stefan Metzmacher [Thu, 7 Jul 2011 08:55:00 +0000 (10:55 +0200)]
s3:libsmb: use trans2_bytes_push_str() in cli_tcon_andx_create() for the plaintext password

This makes sure we push the string always in DOS charset.

metze

8 years agos3:libsmb: use trans2_bytes_push_str() in cli_set_ea_path()
Stefan Metzmacher [Thu, 7 Jul 2011 08:16:38 +0000 (10:16 +0200)]
s3:libsmb: use trans2_bytes_push_str() in cli_set_ea_path()

metze

8 years agos3:libsmb: use trans2_bytes_push_str() in cli_dfs_get_referral()
Stefan Metzmacher [Wed, 6 Jul 2011 16:36:29 +0000 (18:36 +0200)]
s3:libsmb: use trans2_bytes_push_str() in cli_dfs_get_referral()

metze

8 years agos3:libsmb: use a talloc_stackframe in cli_dfs_get_referral()
Stefan Metzmacher [Thu, 7 Jul 2011 06:58:25 +0000 (08:58 +0200)]
s3:libsmb: use a talloc_stackframe in cli_dfs_get_referral()

metze

8 years agos3:libsmb: use trans2_bytes_push_str/bytes() in cli_list_trans_*()
Stefan Metzmacher [Wed, 6 Jul 2011 16:24:50 +0000 (18:24 +0200)]
s3:libsmb: use trans2_bytes_push_str/bytes() in cli_list_trans_*()

metze

8 years agos3:libsmb: use clistr_pull_talloc() for short_name in interpret_long_filename()
Stefan Metzmacher [Wed, 6 Jul 2011 16:57:27 +0000 (18:57 +0200)]
s3:libsmb: use clistr_pull_talloc() for short_name in interpret_long_filename()

metze

8 years agos3:libsmb: interpret_long_filename() short_name is always UNICODE
Stefan Metzmacher [Thu, 7 Jul 2011 12:46:40 +0000 (14:46 +0200)]
s3:libsmb: interpret_long_filename() short_name is always UNICODE

metze

8 years agos3:libsmb: add trans2_bytes_push_bytes()
Stefan Metzmacher [Thu, 7 Jul 2011 08:02:36 +0000 (10:02 +0200)]
s3:libsmb: add trans2_bytes_push_bytes()

metze

8 years agos3:libsmb: make trans2_bytes_push_str() non-static
Stefan Metzmacher [Wed, 6 Jul 2011 16:23:52 +0000 (18:23 +0200)]
s3:libsmb: make trans2_bytes_push_str() non-static

We should use this and get rid of clistr_push().

metze

8 years agos3:utils: avoid cli_nt_error()/cli_errstr() if we already have the status
Stefan Metzmacher [Thu, 7 Jul 2011 13:33:43 +0000 (15:33 +0200)]
s3:utils: avoid cli_nt_error()/cli_errstr() if we already have the status

metze

8 years agos3-printing: remove tdb migration invalid printer name checks
David Disseldorp [Tue, 5 Jul 2011 13:04:02 +0000 (15:04 +0200)]
s3-printing: remove tdb migration invalid printer name checks

WERR_INVALID_PRINTER_NAME only needed to be handled when printing tdb
migration used spoolss, with winreg such errors are no longer possible.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jul  7 19:15:34 CEST 2011 on sn-devel-104

8 years agos3-printing: make sure to first migrate the printers then the security descriptor.
Günther Deschner [Tue, 5 Jul 2011 12:01:40 +0000 (14:01 +0200)]
s3-printing: make sure to first migrate the printers then the security descriptor.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: fill info2_mask in printer migration
David Disseldorp [Tue, 5 Jul 2011 09:34:47 +0000 (11:34 +0200)]
s3-printing: fill info2_mask in printer migration

Also fix possibly uninitialised status return from
printing_tdb_migrate_printer().

8 years agos3-printing: remove spoolss pipe from migration library, only using winreg finally.
Günther Deschner [Tue, 5 Jul 2011 00:33:23 +0000 (02:33 +0200)]
s3-printing: remove spoolss pipe from migration library, only using winreg finally.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: use winreg interface for migration, instead of spoolss.
Günther Deschner [Mon, 4 Jul 2011 17:47:07 +0000 (19:47 +0200)]
s3-printing: use winreg interface for migration, instead of spoolss.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles.
Günther Deschner [Mon, 4 Jul 2011 22:55:35 +0000 (00:55 +0200)]
s3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: use winreg_internal functions.
Günther Deschner [Mon, 4 Jul 2011 22:16:03 +0000 (00:16 +0200)]
s3-printing: use winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: add winreg_internal functions.
Günther Deschner [Mon, 4 Jul 2011 22:16:47 +0000 (00:16 +0200)]
s3-printing: add winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c.
Günther Deschner [Mon, 4 Jul 2011 18:09:54 +0000 (20:09 +0200)]
s3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: add rpc_client/cli_winreg_spoolss.c
Günther Deschner [Mon, 4 Jul 2011 17:47:29 +0000 (19:47 +0200)]
s3-printing: add rpc_client/cli_winreg_spoolss.c

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-waf: make LIBCLI_SPOOLSS a shared library
Günther Deschner [Tue, 5 Jul 2011 09:29:37 +0000 (11:29 +0200)]
s3-waf: make LIBCLI_SPOOLSS a shared library

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h
Günther Deschner [Tue, 5 Jul 2011 00:15:35 +0000 (02:15 +0200)]
s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
Günther Deschner [Tue, 5 Jul 2011 00:12:24 +0000 (02:12 +0200)]
s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3-printing: move os2 related functions to printing/nt_printing_os2.c.
Günther Deschner [Mon, 4 Jul 2011 23:24:48 +0000 (01:24 +0200)]
s3-printing: move os2 related functions to printing/nt_printing_os2.c.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

8 years agos3: Remove a use of cli_errstr
Volker Lendecke [Thu, 7 Jul 2011 13:42:33 +0000 (15:42 +0200)]
s3: Remove a use of cli_errstr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 18:04:26 CEST 2011 on sn-devel-104

8 years agos3-waf: Fix linking bugs causing segfaults.
Andreas Schneider [Thu, 7 Jul 2011 12:59:51 +0000 (14:59 +0200)]
s3-waf: Fix linking bugs causing segfaults.

As auth_util.c is linked several times the static variables have
different address on different calls. This leads to segfaults.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul  7 16:50:05 CEST 2011 on sn-devel-104

8 years agos3:testparm: avoid spurious warnings about dos mode mapping and create mask if store...
Gregor Beck [Wed, 6 Jul 2011 13:10:27 +0000 (15:10 +0200)]
s3:testparm: avoid spurious warnings about dos mode mapping and create mask if store dos attributes is set

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 12:49:01 CEST 2011 on sn-devel-104

8 years agos4 provision: Add some of the AD-specific DNS records to the directory
Kai Blin [Mon, 27 Jun 2011 09:25:39 +0000 (11:25 +0200)]
s4 provision: Add some of the AD-specific DNS records to the directory

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Jul  7 02:29:53 CEST 2011 on sn-devel-104

8 years agos4 provision: split up DNS provisioning into generic and samba-specific ldifs
Kai Blin [Sat, 25 Jun 2011 22:36:25 +0000 (00:36 +0200)]
s4 provision: split up DNS provisioning into generic and samba-specific ldifs

Signed-off-by: Kai Blin <kai@samba.org>
8 years agos4:torture/smb2: s/smb2cli_unlock/test_smb2_unlock
Stefan Metzmacher [Wed, 6 Jul 2011 15:52:33 +0000 (17:52 +0200)]
s4:torture/smb2: s/smb2cli_unlock/test_smb2_unlock

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 19:07:42 CEST 2011 on sn-devel-104

8 years agos4:torture/smb2: s/smb2cli_lock/test_smb2_lock
Stefan Metzmacher [Wed, 6 Jul 2011 15:52:33 +0000 (17:52 +0200)]
s4:torture/smb2: s/smb2cli_lock/test_smb2_lock

metze

8 years agos3:libsmb: use clistr_pull_talloc() in cli_qfilename()
Stefan Metzmacher [Wed, 6 Jul 2011 12:35:13 +0000 (14:35 +0200)]
s3:libsmb: use clistr_pull_talloc() in cli_qfilename()

metze

8 years agos3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2
Stefan Metzmacher [Wed, 6 Jul 2011 12:04:15 +0000 (14:04 +0200)]
s3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2

metze

8 years agos3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info()
Stefan Metzmacher [Wed, 6 Jul 2011 11:57:20 +0000 (13:57 +0200)]
s3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info()

metze

8 years agos3:libsmb: the SMB_QUERY_FS_VOLUME_INFO response needs at least 18 data bytes
Stefan Metzmacher [Wed, 6 Jul 2011 11:21:41 +0000 (13:21 +0200)]
s3:libsmb: the SMB_QUERY_FS_VOLUME_INFO response needs at least 18 data bytes

metze

8 years agos3:libsmb: don't use cli->inbuf in cli_dfs_get_referral()
Stefan Metzmacher [Wed, 6 Jul 2011 11:04:26 +0000 (13:04 +0200)]
s3:libsmb: don't use cli->inbuf in cli_dfs_get_referral()

The rdata buffer returned by cli_trans() doesn't belong to
cli->inbuf, so don't use it.

metze

8 years agos3:libsmb: fix error handling in cli_dfs_get_referral()
Stefan Metzmacher [Wed, 6 Jul 2011 13:57:22 +0000 (15:57 +0200)]
s3:libsmb: fix error handling in cli_dfs_get_referral()

We should not return NT_STATUS_OK on error.

metze

8 years agos3:sharesec: return an error if get_share_security() returns NULL
Stefan Metzmacher [Wed, 6 Jul 2011 10:31:41 +0000 (12:31 +0200)]
s3:sharesec: return an error if get_share_security() returns NULL

This indicates an error, as it uses get_share_security_default()
if no security descriptor is configured.

Jeremy, please check.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 15:40:23 CEST 2011 on sn-devel-104

8 years agos3:test: catch more errors in test_access_check() in the smbclient_s3 test
Michael Adam [Wed, 6 Jul 2011 10:24:13 +0000 (12:24 +0200)]
s3:test: catch more errors in test_access_check() in the smbclient_s3 test

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jul  6 14:07:13 CEST 2011 on sn-devel-104

8 years agos3:registry: update copyright for the registry db implementation
Michael Adam [Wed, 6 Jul 2011 10:09:52 +0000 (12:09 +0200)]
s3:registry: update copyright for the registry db implementation

8 years agoexamples/VFS: try to fix the build on openbsd, adding alternative spellings of autoco...
Michael Adam [Wed, 6 Jul 2011 08:37:40 +0000 (10:37 +0200)]
examples/VFS: try to fix the build on openbsd, adding alternative spellings of autoconf/header

The host "samba-amd64" on the build farm running openbsd 4.8 broke.
Taking over the additional spellings of autoconf and autoheader from
the source3/autogen.sh script should fix it.

8 years agos3:sharesec: also initialize pgranted if get_share_security() returns NULL
Stefan Metzmacher [Tue, 5 Jul 2011 14:59:41 +0000 (16:59 +0200)]
s3:sharesec: also initialize pgranted if get_share_security() returns NULL

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 12:54:30 CEST 2011 on sn-devel-104

8 years agos3: Follow the TALLOC_FREE convention in source3
Volker Lendecke [Wed, 6 Jul 2011 07:39:08 +0000 (09:39 +0200)]
s3: Follow the TALLOC_FREE convention in source3

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 11:01:05 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2586 -- NO_EFFECT
Volker Lendecke [Wed, 6 Jul 2011 07:37:04 +0000 (09:37 +0200)]
s3: Fix Coverity ID 2586 -- NO_EFFECT

tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is
unsigned. So (len < 0) could never have turned true.

Volker

8 years agos3: Remove cli_errstr from cmd_posix_open
Volker Lendecke [Tue, 5 Jul 2011 17:55:25 +0000 (19:55 +0200)]
s3: Remove cli_errstr from cmd_posix_open

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 09:45:11 CEST 2011 on sn-devel-104

8 years agos3: Fix error logic in posix_open
Volker Lendecke [Tue, 5 Jul 2011 17:51:09 +0000 (19:51 +0200)]
s3: Fix error logic in posix_open

8 years agos3: Remove a few uses of cli_errstr
Volker Lendecke [Tue, 5 Jul 2011 17:42:46 +0000 (19:42 +0200)]
s3: Remove a few uses of cli_errstr

8 years agos3: make cli_resolve_path return NTSTATUS
Volker Lendecke [Sun, 3 Jul 2011 18:53:55 +0000 (20:53 +0200)]
s3: make cli_resolve_path return NTSTATUS

This looks larger than it is. No parameters needed changing.

8 years agoccan/tally: don't use SIZE_MAX.
Rusty Russell [Wed, 6 Jul 2011 05:17:44 +0000 (14:47 +0930)]
ccan/tally: don't use SIZE_MAX.

Michael Adam points out this broke the build farm (ie. OSF1 axp V5.1 2650 alpha)
so fixed in CCAN and imported from af7a902d74a7926693f55da9e21a67dde46931d4:

    Turns out it's not standard (thanks Samba build farm!)
    And the previous test had a hole in it anyway.  This one is more conservative.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Jul  6 08:34:05 CEST 2011 on sn-devel-104

8 years agobuild: we no longer put #if _SAMBA_BUILD_ == 4 in public headers
Andrew Bartlett [Wed, 6 Jul 2011 03:09:17 +0000 (13:09 +1000)]
build: we no longer put #if _SAMBA_BUILD_ == 4 in public headers

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jul  6 06:46:50 CEST 2011 on sn-devel-104

8 years agos3-build We no longer require to redefine _SAMBA_BUILD_
Andrew Bartlett [Wed, 6 Jul 2011 02:49:11 +0000 (12:49 +1000)]
s3-build We no longer require to redefine _SAMBA_BUILD_

8 years agolibcli/smb move FILE_TYPE constants in common
Andrew Bartlett [Wed, 6 Jul 2011 03:06:14 +0000 (13:06 +1000)]
libcli/smb move FILE_TYPE constants in common

This allows us to remove another _SAMBA_BUILD_ conditional

Andrew Bartlett

8 years agolibcli/smb move enum protocol_types to a common header
Andrew Bartlett [Wed, 6 Jul 2011 03:05:45 +0000 (13:05 +1000)]
libcli/smb move enum protocol_types to a common header

8 years agobuild: Remove _SAMBA_BUILD == 4 from libgpo
Andrew Bartlett [Wed, 6 Jul 2011 02:39:34 +0000 (12:39 +1000)]
build: Remove _SAMBA_BUILD == 4 from libgpo

This code has no hope of building against the samba4 libs (it has been
disabled for a very long time, and files referenced don't exist etc),
and with the common build there simply is no need.

Andrew Bartlett

8 years agolibrpc/ndr remove _SAMBA_BUILD_ conditionals
Andrew Bartlett [Wed, 6 Jul 2011 02:08:52 +0000 (12:08 +1000)]
librpc/ndr remove _SAMBA_BUILD_ conditionals

8 years agobuild: Re-enable the -Wl,--as-needed flag
Andrew Bartlett [Wed, 6 Jul 2011 01:58:10 +0000 (11:58 +1000)]
build: Re-enable the -Wl,--as-needed flag

8 years agos3:smbd fix a compile warning on AIX 5.3
Christian Ambach [Tue, 5 Jul 2011 22:06:27 +0000 (17:06 -0500)]
s3:smbd fix a compile warning on AIX 5.3

use the correct alias instead of FD directly

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jul  5 19:51:42 CEST 2011 on sn-devel-104

8 years agos3:build fix autoconf build on AIX 5.3
Christian Ambach [Tue, 5 Jul 2011 22:04:15 +0000 (17:04 -0500)]
s3:build fix autoconf build on AIX 5.3

using ZLIB_LIBS as dependency made AIX make fail trying to
find -lz as build target

8 years ago.gitignore: add AIX WINBIND nss module
Christian Ambach [Tue, 5 Jul 2011 22:02:23 +0000 (17:02 -0500)]
.gitignore: add AIX WINBIND nss module

this cleans up git status on AIX after building source3

8 years agos3:lib fix non-empty blank lines
Christian Ambach [Tue, 28 Jun 2011 16:01:22 +0000 (18:01 +0200)]
s3:lib fix non-empty blank lines

8 years agos3:modules fix non-empty blank lines
Christian Ambach [Tue, 28 Jun 2011 12:59:18 +0000 (14:59 +0200)]
s3:modules fix non-empty blank lines

8 years agos3: Remove some unused variables
Volker Lendecke [Tue, 5 Jul 2011 15:26:04 +0000 (17:26 +0200)]
s3: Remove some unused variables

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jul  5 18:40:11 CEST 2011 on sn-devel-104

8 years agos3: Fix bug 8102
Volker Lendecke [Tue, 5 Jul 2011 09:13:07 +0000 (11:13 +0200)]
s3: Fix bug 8102

We can't allow open with access that has been denied via the share
security descriptor

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul  5 16:21:54 CEST 2011 on sn-devel-104

8 years agos3: Calculate&store the maximum share access mask
Volker Lendecke [Mon, 4 Jul 2011 16:35:21 +0000 (18:35 +0200)]
s3: Calculate&store the maximum share access mask

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3: Return "granted" from share_access_check
Volker Lendecke [Mon, 4 Jul 2011 15:02:34 +0000 (17:02 +0200)]
s3: Return "granted" from share_access_check

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agoldb: set -Wl,-no-undefined only on standalone build
Andrew Bartlett [Tue, 5 Jul 2011 05:55:25 +0000 (15:55 +1000)]
ldb: set -Wl,-no-undefined only on standalone build

This ensures that the flag is not propogated to other projects, such
as Samba's source3 waf build.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jul  5 10:37:30 CEST 2011 on sn-devel-104

8 years agoldb: make ldb a top level library for Samba 4.0
Andrew Bartlett [Tue, 5 Jul 2011 00:01:32 +0000 (10:01 +1000)]
ldb: make ldb a top level library for Samba 4.0

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-dbcheck: support the 'none' option for prompts
Andrew Tridgell [Tue, 5 Jul 2011 03:03:18 +0000 (13:03 +1000)]
s4-dbcheck: support the 'none' option for prompts

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Jul  5 08:22:40 CEST 2011 on sn-devel-104

8 years agos4-pycommon: support 'none' as an option in confirm
Andrew Tridgell [Tue, 5 Jul 2011 03:02:48 +0000 (13:02 +1000)]
s4-pycommon: support 'none' as an option in confirm

this allows the user to ask for none of the changes of this type

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>