samba.git
12 years agos3: Add a dummy test to prove the maxfd calculation
Volker Lendecke [Thu, 10 Jun 2010 07:50:32 +0000 (09:50 +0200)]
s3: Add a dummy test to prove the maxfd calculation

To be run in a debugger, there's no way to inspect the internal tevent_select.c
maxfd calculation

12 years agotevent: Fix maxfd calculation in tevent_select
Volker Lendecke [Thu, 10 Jun 2010 07:41:11 +0000 (09:41 +0200)]
tevent: Fix maxfd calculation in tevent_select

When doing

        fd1 = tevent_add_fd(ev, ev, 2, 0, NULL, NULL);
        fd2 = tevent_add_fd(ev, ev, 3, 0, NULL, NULL);
        TALLOC_FREE(fd2);
        fd2 = tevent_add_fd(ev, ev, 1, 0, NULL, NULL);

we end up with select_ev->maxfd==1. This is wrong.

An alternative fix might be to make select_ev->maxfd an unsigned int and make
EVENT_INVALID_MAXFD==UINT_MAX. But in theory we might end up with an fd of
UINT_MAX.

std_event_add_fd() contains exactly the same piece of code, so I'm directly
pushing it.

Volker

12 years agos3-smbd: Fix typo in comment.
Karolin Seeger [Thu, 10 Jun 2010 08:35:56 +0000 (10:35 +0200)]
s3-smbd: Fix typo in comment.

Karolin

12 years agos3-passdb: Fix typo in comment.
Karolin Seeger [Thu, 10 Jun 2010 08:34:58 +0000 (10:34 +0200)]
s3-passdb: Fix typo in comment.

Karolin

12 years agoRename "allow_smb2" -> "using_smb2" and make the usage clearer.
Jeremy Allison [Thu, 10 Jun 2010 02:12:02 +0000 (19:12 -0700)]
Rename "allow_smb2" -> "using_smb2" and make the usage clearer.

12 years agoSplit out the "finished write processing" code into a function so it can be called
Jeremy Allison [Thu, 10 Jun 2010 00:09:11 +0000 (17:09 -0700)]
Split out the "finished write processing" code into a function so it can be called
by both sync and async code.

Jeremy.

12 years agoEnsure we don't send SMB1 keepalives on an SMB2 connection.
Jeremy Allison [Thu, 10 Jun 2010 00:08:41 +0000 (17:08 -0700)]
Ensure we don't send SMB1 keepalives on an SMB2 connection.

Jeremy.

12 years agoSplit out the "finished read processing" code into a function so it can be called
Jeremy Allison [Wed, 9 Jun 2010 17:48:12 +0000 (10:48 -0700)]
Split out the "finished read processing" code into a function so it can be called
by both sync and async code.

Jeremy.

12 years agos3-winbind: Fixed setting default sequence number.
Andreas Schneider [Wed, 9 Jun 2010 14:15:28 +0000 (16:15 +0200)]
s3-winbind: Fixed setting default sequence number.

12 years agos3: fix calculation of st_blocks in streams_xattr
Björn Jacke [Wed, 9 Jun 2010 13:24:26 +0000 (15:24 +0200)]
s3: fix calculation of st_blocks in streams_xattr

Thanks to Joachim Schmitz for finding that miscalculation.

12 years agos3: fix calculation of st_blocks in init_stat_ex_from_stat
Björn Jacke [Wed, 9 Jun 2010 13:21:24 +0000 (15:21 +0200)]
s3: fix calculation of st_blocks in init_stat_ex_from_stat

this is just relevant for the very rare systems that don't have the st_blocks
struct member. This is a fixup of the fix for bug 7474.

Thanks to Joachim Schmitz for spotting this!

12 years agoAdded guids for the validated writes.
Nadezhda Ivanova [Wed, 9 Jun 2010 09:03:32 +0000 (12:03 +0300)]
Added guids for the validated writes.

12 years agos3: Fix bug 7253
Volker Lendecke [Tue, 16 Mar 2010 20:03:34 +0000 (21:03 +0100)]
s3: Fix bug 7253

acct_ctrl is 32 bit in LOGIN_CACHE, but "w" as a format specifier for
tdb_unpack only writes 16 bits. Okay on x86, not okay on Solaris.

Thanks to Vladimir.Marek@Sun.COM!

Volker

12 years agoFix a valgrind error found by SMB2-COMPOUND test.
Jeremy Allison [Wed, 9 Jun 2010 04:20:07 +0000 (21:20 -0700)]
Fix a valgrind error found by SMB2-COMPOUND test.

If a file is closed we must also NULL out all chained_fsp
pointers when the fsp is freed to prevent invalid pointer
access.

Jeremy.

12 years agoSecond part of fix for 7501 - SMB2: CREATE request replies getting mangled.
Jeremy Allison [Wed, 9 Jun 2010 00:44:05 +0000 (17:44 -0700)]
Second part of fix for 7501 - SMB2: CREATE request replies getting mangled.

Based on code from Ira Cooper <samba@ira.wakeful.net>, and also
advice on refactoring the patch into a function call. outbuf vectors
can be reallocated by smb2 processing code, so when returning interim
responses we must not make assumptions about vector size.

Jeremy

12 years agoFix for bug 7501 - SMB2: CREATE request replies getting mangled.
Ira Cooper [Tue, 8 Jun 2010 18:20:23 +0000 (11:20 -0700)]
Fix for bug 7501 -  SMB2: CREATE request replies getting mangled.

Code for dup_smb2_req() was duplicating the wrong vector (i, instead
of i+2) when returning a non-minimal SMB2 response.

12 years agos3-selftest: disable domain creds smbclient_s3 tests for now.
Günther Deschner [Tue, 8 Jun 2010 12:34:20 +0000 (14:34 +0200)]
s3-selftest: disable domain creds smbclient_s3 tests for now.

Not sure they were ever working before.

With this patch, make selftest is down to 4 failures from 259 tests.

(two times LOCK9 from s3 smbtorture, one spoolss notify test and
samba3.posix_s3.unix.info2).

Guenther

12 years agos3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in netdomjoin...
Günther Deschner [Tue, 8 Jun 2010 09:25:00 +0000 (11:25 +0200)]
s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in netdomjoin-gui.

Patch from Buchan Milne <bgmilne@mandriva.org>.

Thanks!

Guenther

12 years agoRevert "s3:smbd Fix segfault if register_existing_vuid() fails"
Volker Lendecke [Tue, 8 Jun 2010 08:26:43 +0000 (10:26 +0200)]
Revert "s3:smbd Fix segfault if register_existing_vuid() fails"

This reverts commit 8f1cec5faf4e26de8b9797777059e99f2a66558b.

12 years agoRevert "s3:smbd Give the kerberos session key a parent"
Volker Lendecke [Tue, 8 Jun 2010 08:26:35 +0000 (10:26 +0200)]
Revert "s3:smbd Give the kerberos session key a parent"

This reverts commit 4a7f45b7e1cef13bc28d7ee50dd4b5519bdec397.

12 years agoRevert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"
Volker Lendecke [Tue, 8 Jun 2010 08:26:08 +0000 (10:26 +0200)]
Revert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"

This reverts commit edba46ce94c335411ab337eeb4ef6f88fb3aae80.

Conflicts:

source3/auth/auth_ntlmssp.c

12 years agos3-waf: fix the the waf build.
Günther Deschner [Tue, 8 Jun 2010 08:56:41 +0000 (10:56 +0200)]
s3-waf: fix the the waf build.

Guenther

12 years agoMake aio_ex owned by a talloc context, not neccessarily on the null context.
Jeremy Allison [Mon, 7 Jun 2010 23:26:30 +0000 (16:26 -0700)]
Make aio_ex owned by a talloc context, not neccessarily on the null context.

12 years agoMove "write_though" into aio_ex struct.
Jeremy Allison [Mon, 7 Jun 2010 23:25:18 +0000 (16:25 -0700)]
Move "write_though" into aio_ex struct.

12 years agos3:smbd add utility function to check if there are open pipes
Simo Sorce [Mon, 7 Jun 2010 18:08:05 +0000 (14:08 -0400)]
s3:smbd add utility function to check if there are open pipes

12 years agos3:rpc make num_pipe_handles get an actual pipe as argument
Simo Sorce [Mon, 7 Jun 2010 20:02:14 +0000 (16:02 -0400)]
s3:rpc make num_pipe_handles get an actual pipe as argument

Let the function abstract out how handles are counted

12 years agos3:rpc handles are used by all pipes, use better name
Simo Sorce [Sun, 6 Jun 2010 20:33:28 +0000 (16:33 -0400)]
s3:rpc handles are used by all pipes, use better name

12 years agos3:rpc fix potential out of bound memory access
Simo Sorce [Mon, 7 Jun 2010 19:07:38 +0000 (15:07 -0400)]
s3:rpc fix potential out of bound memory access

memcpy copies memory unconditionally, we are passing "" in some cases here.
Use strncpy which will stop reading from src if the null byte is found and
will fill with nulls the destination.

12 years agos3: fix build on platforms without st_blocks and st_blksize stat struct members
Björn Jacke [Mon, 7 Jun 2010 21:06:28 +0000 (23:06 +0200)]
s3: fix build on platforms without st_blocks and st_blksize stat struct members

This fixes bug 7474.

12 years agoldb:pyldb.c - we cannot use "ldb_dn_compare" if both message DNs are NULL in "py_ldb_...
Matthias Dieter Wallnöfer [Mon, 7 Jun 2010 19:26:33 +0000 (21:26 +0200)]
ldb:pyldb.c - we cannot use "ldb_dn_compare" if both message DNs are NULL in "py_ldb_msg_compare"

Discovered by the testcase.

12 years agos4 python: add more unit tests to verify the compare tests
Matthieu Patou [Fri, 7 May 2010 00:16:11 +0000 (04:16 +0400)]
s4 python: add more unit tests to verify the compare tests

12 years agos4:objectclass_attrs LDB module - move the single-valued attribute check into this...
Matthias Dieter Wallnöfer [Mon, 7 Jun 2010 18:46:59 +0000 (20:46 +0200)]
s4:objectclass_attrs LDB module - move the single-valued attribute check into this module

It seems to me more consistent (and also to keep the same behaviour on all
backends).

Also the DRS hack should therefore not be needed anymore since the
"repl_meta_data" module launches requests behind "objectclass_attrs".

12 years agos4:rdn_name LDB module - move the "distinguishedName" write prevent check here
Matthias Dieter Wallnöfer [Mon, 7 Jun 2010 18:31:22 +0000 (20:31 +0200)]
s4:rdn_name LDB module - move the "distinguishedName" write prevent check here

In my eyes it fits better here than in the TDB backend code.

12 years agos3:auth add hooks to indicate if signing or sealing is desired with NTLMSSP
Andrew Bartlett [Wed, 2 Jun 2010 12:52:56 +0000 (22:52 +1000)]
s3:auth add hooks to indicate if signing or sealing is desired with NTLMSSP

This allows the right hooks to be called in GENSEC when s3compat
implements the auth_ntlmssp interface.  Otherwise, we can't do the
signing or sealing as we have not negoitated it's use.

Andrew Bartlett

12 years agos3:auth Change auth_ntlmssp_server_info API to return NTSTATUS
Andrew Bartlett [Wed, 2 Jun 2010 12:35:53 +0000 (22:35 +1000)]
s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS

It's nicer to have an NTSTATUS return, and in s3compat there may be a
reason other than 'no memory' why this can fail.

Andrew Bartlett

12 years agos3:named pipe proxy Improve error messages when named pipes fail to forward
Andrew Bartlett [Thu, 3 Jun 2010 11:05:57 +0000 (21:05 +1000)]
s3:named pipe proxy Improve error messages when named pipes fail to forward

I hope this helps the next person who needs to debug this.

Andrew Bartlett

12 years agos3:smbd Give the kerberos session key a parent
Andrew Bartlett [Thu, 3 Jun 2010 11:15:33 +0000 (21:15 +1000)]
s3:smbd Give the kerberos session key a parent

I can't see what would free this, so this should prevent a memory leak.

Andrew Bartlett

12 years agonamed_pipe_auth Always lower case the incoming pipe name
Andrew Bartlett [Thu, 3 Jun 2010 10:59:25 +0000 (20:59 +1000)]
named_pipe_auth Always lower case the incoming pipe name

Windows connects to an upper case NETLOGON pipe, and we can't find the
socket to connect to until we lower case the name.

Andrew Bartlett

12 years agos3:smbd Fix segfault if register_existing_vuid() fails
Andrew Bartlett [Tue, 1 Jun 2010 09:19:01 +0000 (19:19 +1000)]
s3:smbd Fix segfault if register_existing_vuid() fails

The register_existing_vuid() call will handle both the ntlmssp_end and
vuid invalidation internally, so we don't want to do it again.

Andrew Bartlett

12 years agos3:auth Rename user_info->domain -> user_info->mapped.domain_name
Andrew Bartlett [Tue, 1 Jun 2010 11:11:14 +0000 (21:11 +1000)]
s3:auth Rename user_info->domain -> user_info->mapped.domain_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

12 years agos3:auth Rename user_info->client_domain -> user_info->client.domain_name
Andrew Bartlett [Tue, 1 Jun 2010 11:08:38 +0000 (21:08 +1000)]
s3:auth Rename user_info->client_domain -> user_info->client.domain_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

12 years agos3:auth fix header comment for internal_username -> mapped.account_name
Andrew Bartlett [Tue, 1 Jun 2010 11:01:23 +0000 (21:01 +1000)]
s3:auth fix header comment for internal_username -> mapped.account_name

12 years agos3:auth Rename user_info->internal_username -> user_info->mapped.account_name
Andrew Bartlett [Tue, 1 Jun 2010 10:30:56 +0000 (20:30 +1000)]
s3:auth Rename user_info->internal_username -> user_info->mapped.account_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

12 years agos3:auth Rename user_info->smb_name -> user_info->client.account_name
Andrew Bartlett [Tue, 1 Jun 2010 10:27:03 +0000 (20:27 +1000)]
s3:auth Rename user_info->smb_name -> user_info->client.account_name

This is closer to the structure I want for a common struct
auth_usersupplied_info.

Andrew Bartlett

12 years agos4:samba_dsdb LDB module - fix typos
Matthias Dieter Wallnöfer [Mon, 7 Jun 2010 13:02:38 +0000 (15:02 +0200)]
s4:samba_dsdb LDB module - fix typos

12 years agos4:samba_dsdb LDB module - enhance/fix module rule comments
Matthias Dieter Wallnöfer [Mon, 7 Jun 2010 12:58:30 +0000 (14:58 +0200)]
s4:samba_dsdb LDB module - enhance/fix module rule comments

12 years agos3:auth make sure the primary group sid is usable
Simo Sorce [Sat, 29 May 2010 15:29:29 +0000 (11:29 -0400)]
s3:auth make sure the primary group sid is usable

This function was previously performed under the cover by converting
back and forth from info3 to samu and then later from samu to info3.

Since we now shortcircuit that in some cases, check explicitly using
get_primary_group_sid()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth return the full passwd struct from check_account
Simo Sorce [Sat, 29 May 2010 15:02:47 +0000 (11:02 -0400)]
s3:auth return the full passwd struct from check_account

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:passdb Export function to calculate the proper primary group sid
Simo Sorce [Sat, 29 May 2010 14:51:40 +0000 (10:51 -0400)]
s3:passdb Export function to calculate the proper primary group sid

Don't keep it buried in passdb, this function need to be available
for use in places where we do not want to construct an artificial
samu struct just to play tricks.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth remove unused structure member
Simo Sorce [Fri, 28 May 2010 21:03:18 +0000 (17:03 -0400)]
s3:auth remove unused structure member

sids are now completely handled using info3, remove dead code that fills
server info sids and the structure members themselves

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth create nt token from info3 directly
Simo Sorce [Fri, 28 May 2010 20:16:53 +0000 (16:16 -0400)]
s3:auth create nt token from info3 directly

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth handle unix domain sids in samu
Simo Sorce [Fri, 28 May 2010 17:18:13 +0000 (13:18 -0400)]
s3:auth handle unix domain sids in samu

When we generate a user out of thin air we may end up adding sids
that are not part of the sam domain (unix domain sids).
Handle the case and preserve these sids as extra sids.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth set the resolved user sid in the fake sam account
Simo Sorce [Fri, 28 May 2010 17:22:41 +0000 (13:22 -0400)]
s3:auth set the resolved user sid in the fake sam account

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth check the user is valid first
Simo Sorce [Fri, 28 May 2010 15:14:01 +0000 (11:14 -0400)]
s3:auth check the user is valid first

It makes no sense to go through all the hoops to build samu and
convert it to info3, just to discard them later if the user was
not valid.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3:auth make sure we set the right username
Simo Sorce [Fri, 28 May 2010 15:07:49 +0000 (11:07 -0400)]
s3:auth make sure we set the right username

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos4:ldap.py - add some "objectclass" behaviour tests
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 18:58:43 +0000 (20:58 +0200)]
s4:ldap.py - add some "objectclass" behaviour tests

12 years agos4:objectclass LDB module - rework the code which handles the objectclasses modification
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 21:02:25 +0000 (23:02 +0200)]
s4:objectclass LDB module - rework the code which handles the objectclasses modification

Before it has been very incomplete. We try now to match the Windows Server
behaviour as close as possible.

12 years agos4:ldap.py - enhance the attributes testcase to demonstrate how the attributes are...
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 21:09:28 +0000 (23:09 +0200)]
s4:ldap.py - enhance the attributes testcase to demonstrate how the attributes are checked against the schema and the specified objectclasses

This demonstrates the bew "objectclass_attrs" LDB module behaviour.

12 years agos4:acl LDB module - LDB attribute names should be compared using "ldb_attr_cmp" or...
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 17:06:58 +0000 (19:06 +0200)]
s4:acl LDB module - LDB attribute names should be compared using "ldb_attr_cmp" or "strcasecmp"

12 years agos4:acl LDB module - adaption for "objectclass_attrs" module
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 18:19:31 +0000 (20:19 +0200)]
s4:acl LDB module - adaption for "objectclass_attrs" module

Since the attribute schema checking code moved back we need to give here the
"LDB_ERR_NO_SUCH_ATTRIBUTE" error.

12 years agos4:objectclass LDB module - remove "fix_check_attributes"
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 17:11:25 +0000 (19:11 +0200)]
s4:objectclass LDB module - remove "fix_check_attributes"

Also this task is now performed by the "objectclass_attrs" LDB module.

12 years agos4:samldb LDB module - adjust the module to set always a "defaultObjectCategory"...
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 17:53:33 +0000 (19:53 +0200)]
s4:samldb LDB module - adjust the module to set always a "defaultObjectCategory" on objectclass add operations

This is needed to make the "objectclass_attrs" LDB module happy. The search
check and case adjustment are done as it was using a second modify operation.

12 years agos4:remove the "validate_update" LDB module - the task is now handled by the far more...
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 17:09:51 +0000 (19:09 +0200)]
s4:remove the "validate_update" LDB module - the task is now handled by the far more complete "objectclass_attrs" LDB module

12 years agos4:dsdb - introduce a new "objectclass_attrs" LDB module which performs the objectcla...
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 15:34:35 +0000 (17:34 +0200)]
s4:dsdb - introduce a new "objectclass_attrs" LDB module which performs the objectclass attributes checking

Until now we had no real consistent mechanism which allowed us to check if
attributes belong to the specified objectclasses.

12 years agos4:objectclass LDB module - instanciate the schema variable centrally on the "ac...
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 17:17:16 +0000 (19:17 +0200)]
s4:objectclass LDB module - instanciate the schema variable centrally on the "ac" context creation

This unifies the position when the schema is read and prevents multiple
instanciations (eg on a modification operation).

12 years agos4:samldb LDB module - finally we can remove the RDN check
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 20:13:03 +0000 (22:13 +0200)]
s4:samldb LDB module - finally we can remove the RDN check

This is now dynamically always done by the objectclass LDB module

12 years agos4:ldap.py - enhance the rename tests to demonstrate the functionality
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 20:06:39 +0000 (22:06 +0200)]
s4:ldap.py - enhance the rename tests to demonstrate the functionality

12 years agos4:objectclass LDB module - finally implement the correct entry rename protections
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 19:55:08 +0000 (21:55 +0200)]
s4:objectclass LDB module - finally implement the correct entry rename protections

Only the "systemFlags" check is still missing.

12 years agos4:objectclass LDB module - cosmetic change
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 19:43:55 +0000 (21:43 +0200)]
s4:objectclass LDB module - cosmetic change

12 years agos4:objectclass LDB module - remove duplicated code
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 19:42:06 +0000 (21:42 +0200)]
s4:objectclass LDB module - remove duplicated code

12 years agos4:objectclass LDB module - fix counter variable types
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 19:24:49 +0000 (21:24 +0200)]
s4:objectclass LDB module - fix counter variable types

12 years agos4:objectclass LDB module - explain why the search can return with an empty return
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 19:23:34 +0000 (21:23 +0200)]
s4:objectclass LDB module - explain why the search can return with an empty return

12 years agos4:objectclass LDB module - this "talloc_steal" is not necessary
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 17:44:22 +0000 (19:44 +0200)]
s4:objectclass LDB module - this "talloc_steal" is not necessary

The "parent_dn" was created on the "ac" context which lives anyway longer
than this child request.

12 years agos4:objectclass LDB module - fix error result if an entry doesn't contain a structural...
Matthias Dieter Wallnöfer [Fri, 4 Jun 2010 18:48:52 +0000 (20:48 +0200)]
s4:objectclass LDB module - fix error result if an entry doesn't contain a structural objectclass

We need to return LDB_ERR_UNWILLING_TO_PERFORM (not LDB_ERR_NAMING_VIOLATION).

12 years agos4:objectclass LDB module - use "ldb_oom" for expressing out of memory
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 11:06:54 +0000 (13:06 +0200)]
s4:objectclass LDB module - use "ldb_oom" for expressing out of memory

12 years agos4:objectclass LDB module - fix header and add my copyright
Matthias Dieter Wallnöfer [Wed, 2 Jun 2010 20:42:59 +0000 (22:42 +0200)]
s4:objectclass LDB module - fix header and add my copyright

12 years agos3-waf: Build rpc_server/srv_spoolss_util.c too.
Andreas Schneider [Thu, 27 May 2010 07:07:03 +0000 (09:07 +0200)]
s3-waf: Build rpc_server/srv_spoolss_util.c too.

Signed-off-by: Günther Deschner <gd@samba.org>
12 years agos3-lsa: Fix static list of luids in our privileges implementation.
Günther Deschner [Mon, 7 Jun 2010 10:55:43 +0000 (12:55 +0200)]
s3-lsa: Fix static list of luids in our privileges implementation.

The high/low order changed while moving to LSA defines. Found by torture test.

Guenther

12 years agos4-smbtorture: test workstation auth as well in RPC-SPOOLSS-ACCESS.
Günther Deschner [Mon, 7 Jun 2010 10:41:39 +0000 (12:41 +0200)]
s4-smbtorture: test workstation auth as well in RPC-SPOOLSS-ACCESS.

Guenther

12 years agos4:ldb python bindings - implement comparison on Python LDB Message objects
Matthieu Patou [Fri, 7 May 2010 00:15:28 +0000 (04:15 +0400)]
s4:ldb python bindings - implement comparison on Python LDB Message objects

Coauthors: Jelmer Vernooij, Matthias Dieter Wallnöfer

12 years agos4: Remove an uselessly exposed control
Matthieu Patou [Sat, 5 Jun 2010 15:25:18 +0000 (19:25 +0400)]
s4: Remove an uselessly exposed control

12 years agos4-smbtorture: handle printservers w/o printers in RPC-SPOOLSS-ACCESS.
Günther Deschner [Mon, 7 Jun 2010 09:21:26 +0000 (11:21 +0200)]
s4-smbtorture: handle printservers w/o printers in RPC-SPOOLSS-ACCESS.

Guenther

12 years agos3-privileges: use LUID defines from lsa IDL.
Günther Deschner [Sat, 5 Jun 2010 00:39:11 +0000 (02:39 +0200)]
s3-privileges: use LUID defines from lsa IDL.

Guenther

12 years agoFix bug with incorrect flag values for inherited ace in some cases.
Matthew McGillis [Sat, 5 Jun 2010 00:48:40 +0000 (17:48 -0700)]
Fix bug with incorrect flag values for inherited ace in some cases.

12 years agos4:password_hash LDB module - adapt the module to the new "ldb_msg_remove_attr" behaviour
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:35:00 +0000 (18:35 +0200)]
s4:password_hash LDB module - adapt the module to the new "ldb_msg_remove_attr" behaviour

12 years agoldb:ldb_msg_remove_attr - provide a better implementation
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:22:10 +0000 (18:22 +0200)]
ldb:ldb_msg_remove_attr - provide a better implementation

We can have some special (bad) messages which contain multiple message elements
for the same attribute. The AD password change ones are such an example.

12 years agos4:samldb LDB module - this codepart isn't needed due to the objectclass LDB module
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 17:12:48 +0000 (19:12 +0200)]
s4:samldb LDB module - this codepart isn't needed due to the objectclass LDB module

When a "computer" entry will be added, also the inherited "user" objectclass is
going to be specified.

12 years agos4:get_last_structural_class - only real structural classes can be candidates for...
Matthias Dieter Wallnöfer [Fri, 4 Jun 2010 19:10:41 +0000 (21:10 +0200)]
s4:get_last_structural_class - only real structural classes can be candidates for fetching the last one

Classes with objectCategory = 1 are always structural, these with
objectCategory = 0 also (as we can see in our Windows 2008 R2 schema file where
class "Person" has 0 but is structural).

Abstract classes and auxiliary ones cannot be considered (objectCategory = 2, 3)

http://msdn.microsoft.com/en-us/library/ms677964(VS.85).aspx

12 years agos4:ldap.py - enhance the RDN name test to show that invalid "name" attributes are...
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:05:52 +0000 (18:05 +0200)]
s4:ldap.py - enhance the RDN name test to show that invalid "name" attributes are allowed on add operations

12 years agos4:rdn_name LDB module - use "ldb_msg_remove_attr" for deleting attributes
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:25:43 +0000 (18:25 +0200)]
s4:rdn_name LDB module - use "ldb_msg_remove_attr" for deleting attributes

12 years agos4:rdn_name LDB module - remove "rdn_name_find_attribute"
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 15:56:09 +0000 (17:56 +0200)]
s4:rdn_name LDB module - remove "rdn_name_find_attribute"

It does exactly the same as "ldb_msg_find_element".

12 years agos4:dsdb/common/util.c - provide a better implementation of the "samdb_msg_add_(add...
Matthias Dieter Wallnöfer [Mon, 31 May 2010 12:52:46 +0000 (14:52 +0200)]
s4:dsdb/common/util.c - provide a better implementation of the "samdb_msg_add_(add/del)val" calls

This supports now also coexisting add and delete message elements with the
same attribute name.

12 years agoldb:ltdb_filter_attrs - fix a counter variable type
Matthias Dieter Wallnöfer [Thu, 3 Jun 2010 16:37:15 +0000 (18:37 +0200)]
ldb:ltdb_filter_attrs - fix a counter variable type

12 years agos4:ldap_server/ldap_backend.c - send back also the extended error message if it exists
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 12:33:52 +0000 (14:33 +0200)]
s4:ldap_server/ldap_backend.c - send back also the extended error message if it exists

This message often contains suggestions how to fix issues.

12 years agos4:ridalloc LDB module - add more "talloc_free"s where useful
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 15:45:51 +0000 (17:45 +0200)]
s4:ridalloc LDB module - add more "talloc_free"s where useful

Some were missing on failure return branches.

12 years agos4:acl LDB module - fix counter types where appropriate
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 18:08:45 +0000 (20:08 +0200)]
s4:acl LDB module - fix counter types where appropriate

12 years agos4:descriptor LDB module - cosmetic fixup
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 17:58:28 +0000 (19:58 +0200)]
s4:descriptor LDB module - cosmetic fixup

12 years agos4:urgent_replication.py - specify the "dnsRoot" attribute which is requested on...
Matthias Dieter Wallnöfer [Sun, 6 Jun 2010 18:23:42 +0000 (20:23 +0200)]
s4:urgent_replication.py - specify the "dnsRoot" attribute which is requested on "crossRef" entries

12 years agos4:ldap.py - make sure that also the "posixuser" will be deleted on test breakages
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 20:19:58 +0000 (22:19 +0200)]
s4:ldap.py - make sure that also the "posixuser" will be deleted on test breakages

12 years agos4:provision - fix typo in substitution variable
Matthias Dieter Wallnöfer [Sat, 5 Jun 2010 22:11:16 +0000 (00:11 +0200)]
s4:provision - fix typo in substitution variable