samba.git
13 years agoasn1_tests: Implement negative unit-tests for ber_write_OID_String()
Kamen Mazdrashki [Wed, 20 Oct 2010 10:46:34 +0000 (13:46 +0300)]
asn1_tests: Implement negative unit-tests for ber_write_OID_String()

13 years agoasn1: ber_write_OID_String() to be more picky about supplied OID
Kamen Mazdrashki [Wed, 20 Oct 2010 10:45:59 +0000 (13:45 +0300)]
asn1: ber_write_OID_String() to be more picky about supplied OID

Now function will check for invalid OID handling cases where:
 - sub-identifier has invalid characters (non-digit)
 - 'dot' separator found on unexpected place. For instance
    '.' at start or end of the OID. Two '.' in a row.

13 years agowaf: Mark the replacement zlib private so that it can build on machine without a...
Matthieu Patou [Thu, 21 Oct 2010 21:01:53 +0000 (01:01 +0400)]
waf: Mark the replacement zlib private so that it can build on machine without a system zlib

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu Oct 21 21:47:46 UTC 2010 on sn-devel-104

13 years agoreplace: use replace for non 'samba' compliant strptime
Matthieu Patou [Wed, 20 Oct 2010 22:14:39 +0000 (02:14 +0400)]
replace: use replace for non 'samba' compliant strptime

13 years agoreplace: use a wrapper around strtoll if it didn't behave as expected
Matthieu Patou [Wed, 20 Oct 2010 20:13:54 +0000 (00:13 +0400)]
replace: use a wrapper around strtoll if it didn't behave as expected

13 years agoLowercase socket_wrapper name.
Jelmer Vernooij [Thu, 21 Oct 2010 19:43:13 +0000 (21:43 +0200)]
Lowercase socket_wrapper name.

Avoid linking against socket_wrapper outside of developer mode.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 21 20:26:11 UTC 2010 on sn-devel-104

13 years agos4-dsdb extended_dn_out: Move lazy dereference control creation to lazy-init
Andrew Bartlett [Thu, 21 Oct 2010 10:08:45 +0000 (21:08 +1100)]
s4-dsdb extended_dn_out: Move lazy dereference control creation to lazy-init

We didn't seem to get the control created by the time we do searches here.

Andrew Bartlett

Autobuild-User: Anatoliy Atanasov <anatoliy@samba.org>
Autobuild-Date: Thu Oct 21 12:29:54 UTC 2010 on sn-devel-104

13 years agotdb: Set _PUBLIC_ in C file rather than header files (Debian bug 600898)
Jelmer Vernooij [Thu, 21 Oct 2010 09:51:37 +0000 (11:51 +0200)]
tdb: Set _PUBLIC_ in C file rather than header files (Debian bug 600898)

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 21 11:47:22 UTC 2010 on sn-devel-104

13 years agos4-waf: we don't need the smbtorture.static for s3 any more
Andrew Tridgell [Thu, 21 Oct 2010 10:17:57 +0000 (21:17 +1100)]
s4-waf: we don't need the smbtorture.static for s3 any more

this breaks the build farm

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 21 11:04:21 UTC 2010 on sn-devel-104

13 years agoautobuild: don't cleanup the pid file within the retry loop
Andrew Tridgell [Thu, 21 Oct 2010 09:41:06 +0000 (20:41 +1100)]
autobuild: don't cleanup the pid file within the retry loop

if we rebase and retry we need to keep the pid file

13 years agowaf: RPC_NDR_WINBIND is samba4 specific
Andrew Tridgell [Thu, 21 Oct 2010 09:21:10 +0000 (20:21 +1100)]
waf: RPC_NDR_WINBIND is samba4 specific

this caused problems with the s3 waf build

13 years agoldb:ldb_modules.c - "dlclose" could cause inference on "dlerror"
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 08:28:32 +0000 (10:28 +0200)]
ldb:ldb_modules.c - "dlclose" could cause inference on "dlerror"

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 21 09:28:19 UTC 2010 on sn-devel-104

13 years agowaf: check the linker accepts a set of ldflags before using them
Andrew Tridgell [Thu, 21 Oct 2010 07:36:41 +0000 (18:36 +1100)]
waf: check the linker accepts a set of ldflags before using them

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 21 08:45:49 UTC 2010 on sn-devel-104

13 years agos4-dsdb: force LDB_ERR_NO_SUCH_ATTRIBUTE on missing schemaInfo
Andrew Tridgell [Thu, 21 Oct 2010 07:17:59 +0000 (18:17 +1100)]
s4-dsdb: force LDB_ERR_NO_SUCH_ATTRIBUTE on missing schemaInfo

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-ldb: make ldb_options_find() public
Andrew Tridgell [Thu, 21 Oct 2010 06:55:24 +0000 (17:55 +1100)]
s4-ldb: make ldb_options_find() public

we need to make this symbol public to allow for -Wl,-no-undefined, as
otherwise the pyldb module can't find the symbol when it creates the
module

13 years agowaf: loosen the restriction on depending on python libs
Andrew Tridgell [Thu, 21 Oct 2010 06:45:23 +0000 (17:45 +1100)]
waf: loosen the restriction on depending on python libs

the pidl generated python code can generate dependencies between two
python modules, so we have to allow this for now

13 years agowaf-python: make the pyext flag add the pyembed features for libraries
Andrew Tridgell [Thu, 21 Oct 2010 06:44:32 +0000 (17:44 +1100)]
waf-python: make the pyext flag add the pyembed features for libraries

this is rather strange, but we get build errors without it. There may
be a bug in the waf python tool, or I may misunderstand how to use it

13 years agowaf: fixed the handling of -Wl,-no-undefined
Andrew Tridgell [Thu, 21 Oct 2010 06:41:42 +0000 (17:41 +1100)]
waf: fixed the handling of -Wl,-no-undefined

this flag was not being propogated to our link rules, so we were not
in fact enforcing no undefined symbols in libraries.

13 years agos4-librpc: fixed depenencies for libcli/security
Andrew Tridgell [Thu, 21 Oct 2010 06:36:15 +0000 (17:36 +1100)]
s4-librpc: fixed depenencies for libcli/security

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibcli: LIBSECURITY depends on NDR_SECURITY
Andrew Tridgell [Thu, 21 Oct 2010 06:34:55 +0000 (17:34 +1100)]
libcli: LIBSECURITY depends on NDR_SECURITY

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: fixed depenencies for -no-undefined
Andrew Tridgell [Thu, 21 Oct 2010 06:14:10 +0000 (17:14 +1100)]
s4-dsdb: fixed depenencies for -no-undefined

added some depenencies needed for -Wl,-no-undefined

13 years agos4-events: LIBEVENTS depends on LIBSAMBA-UTIL
Andrew Tridgell [Thu, 21 Oct 2010 06:13:26 +0000 (17:13 +1100)]
s4-events: LIBEVENTS depends on LIBSAMBA-UTIL

it needs it for the debug code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-rpc_server: split out DCERPC_SHARE as a separate subsystem
Andrew Tridgell [Thu, 21 Oct 2010 06:12:31 +0000 (17:12 +1100)]
s4-rpc_server: split out DCERPC_SHARE as a separate subsystem

this avoids a problem with -Wl,-no-undefined in the ntvfs layer

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-python: python_samba needs pyext
Andrew Tridgell [Thu, 21 Oct 2010 06:11:20 +0000 (17:11 +1100)]
s4-python: python_samba needs pyext

13 years agowaf: show duplicate objects in python modules as well as libraries
Andrew Tridgell [Thu, 21 Oct 2010 04:30:27 +0000 (15:30 +1100)]
waf: show duplicate objects in python modules as well as libraries

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-waf: removed the dependency loop between ntvfs and dcerpc_server
Andrew Tridgell [Thu, 21 Oct 2010 04:27:50 +0000 (15:27 +1100)]
s4-waf: removed the dependency loop between ntvfs and dcerpc_server

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibrpc: added a few more NDR_* targets to NDR_SAMBA
Andrew Tridgell [Thu, 21 Oct 2010 04:27:25 +0000 (15:27 +1100)]
librpc: added a few more NDR_* targets to NDR_SAMBA

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-ldb: make pyldb_util a private library
Andrew Tridgell [Thu, 21 Oct 2010 04:26:38 +0000 (15:26 +1100)]
s4-ldb: make pyldb_util a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibrpc: added RPC_NDR_SAMBA grouping library
Andrew Tridgell [Thu, 21 Oct 2010 04:26:20 +0000 (15:26 +1100)]
librpc: added RPC_NDR_SAMBA grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolib: make WRAP_XATTR a private library
Andrew Tridgell [Thu, 21 Oct 2010 04:26:00 +0000 (15:26 +1100)]
lib: make WRAP_XATTR a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: added pyext option to SAMBA_LIBRARY()
Andrew Tridgell [Thu, 21 Oct 2010 04:25:44 +0000 (15:25 +1100)]
waf: added pyext option to SAMBA_LIBRARY()

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibrpc: added NDR_XATTR and NDR_UNIXINFO to the NDR_SAMBA grouping library
Andrew Tridgell [Thu, 21 Oct 2010 03:58:14 +0000 (14:58 +1100)]
librpc: added NDR_XATTR and NDR_UNIXINFO to the NDR_SAMBA grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-python: added a samba_python grouping library
Andrew Tridgell [Thu, 21 Oct 2010 03:57:34 +0000 (14:57 +1100)]
s4-python: added a samba_python grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-param: added a libshares grouping library
Andrew Tridgell [Thu, 21 Oct 2010 03:56:59 +0000 (14:56 +1100)]
s4-param: added a libshares grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos3-waf: mark some libraries as private
Andrew Tridgell [Thu, 21 Oct 2010 03:56:36 +0000 (14:56 +1100)]
s3-waf: mark some libraries as private

public libraries must have a vnum specified

13 years agowaf: raise an error on a dependency on a python module
Andrew Tridgell [Thu, 21 Oct 2010 03:55:19 +0000 (14:55 +1100)]
waf: raise an error on a dependency on a python module

it is never correct to list a dependency on a python module

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-waf: don't depend directly on python modules
Andrew Tridgell [Thu, 21 Oct 2010 03:54:11 +0000 (14:54 +1100)]
s4-waf: don't depend directly on python modules

build rules should not list dependencies on python modules. Instead,
if code needs the module it should use the python API import calls to
access the module.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-waf: removed the XATTR and SASL aliases
Andrew Tridgell [Thu, 21 Oct 2010 03:52:25 +0000 (14:52 +1100)]
s4-waf: removed the XATTR and SASL aliases

these were hangovers from the old build system names

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: prevent the global deps list creating depenency loops
Andrew Tridgell [Thu, 21 Oct 2010 02:52:47 +0000 (13:52 +1100)]
waf: prevent the global deps list creating depenency loops

this prevents a loop between SOCKET_WRAPPER and replace in the s3 waf
build

13 years agos4-libcli: make LIBSECURITY_SESSION a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:52:15 +0000 (13:52 +1100)]
s4-libcli: make LIBSECURITY_SESSION a private library

13 years agos4-socket: make LIBNETIF a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:55 +0000 (13:51 +1100)]
s4-socket: make LIBNETIF a private library

13 years agos4-events: make LIBEVENTS a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:40 +0000 (13:51 +1100)]
s4-events: make LIBEVENTS a private library

13 years agos4-kdc: make DB_GLUE a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:21 +0000 (13:51 +1100)]
s4-kdc: make DB_GLUE a private library

13 years agos4-dsdb: make ldb_password_hash depend on hdb not HEIMDAL_HDB_KEYS
Andrew Tridgell [Thu, 21 Oct 2010 02:51:02 +0000 (13:51 +1100)]
s4-dsdb: make ldb_password_hash depend on hdb not HEIMDAL_HDB_KEYS

this prevents a duplicate object file

13 years agonsswitch: make LIBWINBIND-CLIENT a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:50:13 +0000 (13:50 +1100)]
nsswitch: make LIBWINBIND-CLIENT a private library

13 years agonsswitch: make LIBWBCLIENT a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:49:55 +0000 (13:49 +1100)]
nsswitch: make LIBWBCLIENT a private library

13 years agolib: add UTIL_TEVENT to samba_sockets grouping library
Andrew Tridgell [Thu, 21 Oct 2010 01:58:31 +0000 (12:58 +1100)]
lib: add UTIL_TEVENT to samba_sockets grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-libcli: make LIBSAMBA-ERRORS a private library
Andrew Tridgell [Thu, 21 Oct 2010 01:57:56 +0000 (12:57 +1100)]
s4-libcli: make LIBSAMBA-ERRORS a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-lib: make SMBPASSWD a private library
Andrew Tridgell [Thu, 21 Oct 2010 01:57:36 +0000 (12:57 +1100)]
s4-lib: make SMBPASSWD a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: moved a bunch of fuctions from schema/schema_info_attr.c to samdb/ldb_module...
Andrew Tridgell [Thu, 21 Oct 2010 01:47:57 +0000 (12:47 +1100)]
s4-dsdb: moved a bunch of fuctions from schema/schema_info_attr.c to samdb/ldb_modules/schema_util.c

these functions operate on ldb_modules, so they should be in the
ldb_modules directory. They also should return ldb errors codes, not
WERROR codes, as otherwise the error can be hidden from the ldap
caller

This re-arrangement fixes a dependency loop in the schema/samdb code.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Kamen Mazdrashki <kamenim@samba.org>

13 years agos4-waf: make NDR_STANDARD a grouping library and add NDR_SAMBA4
Andrew Tridgell [Thu, 21 Oct 2010 00:29:46 +0000 (11:29 +1100)]
s4-waf: make NDR_STANDARD a grouping library and add NDR_SAMBA4

this collects a number of subsystems into logical groups

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-build: make LIBSAMBA-NET a private library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:58 +0000 (11:28 +1100)]
s4-build: make LIBSAMBA-NET a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf-build: create a NDR_SAMBA grouping library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:27 +0000 (11:28 +1100)]
waf-build: create a NDR_SAMBA grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf-build: create a samba_sockets grouping library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:05 +0000 (11:28 +1100)]
waf-build: create a samba_sockets grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-waf: removed dependencies on missing subsystems
Andrew Tridgell [Thu, 21 Oct 2010 00:25:59 +0000 (11:25 +1100)]
s4-waf: removed dependencies on missing subsystems

these were left over from the old config.mk system

13 years agowaf: replace the is_bundled option with private_library
Andrew Tridgell [Thu, 21 Oct 2010 00:22:36 +0000 (11:22 +1100)]
waf: replace the is_bundled option with private_library

'private_library' better captures what we are trying to get at when we
bundle a library

13 years agowaf: added the concept of a grouping_library
Andrew Tridgell [Thu, 21 Oct 2010 00:19:09 +0000 (11:19 +1100)]
waf: added the concept of a grouping_library

a grouping library is one which 'groups' a set of subsystems. This
means that if a target depends on a subsystem that is within a
grouping library then that dependency is replaced with a dependency on
the grouping library.

This gives us a powerful method to avoid duplicated object files
between libraries.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-build: fixed some formatting
Andrew Tridgell [Wed, 20 Oct 2010 21:59:06 +0000 (08:59 +1100)]
s4-build: fixed some formatting

indentation was far too deep

13 years agobuild: subunit and popt need to be marked as private libraries
Andrew Tridgell [Wed, 20 Oct 2010 21:58:35 +0000 (08:58 +1100)]
build: subunit and popt need to be marked as private libraries

they have no vnum

13 years agowaf: cope with libraries with a specified version number
Andrew Tridgell [Wed, 20 Oct 2010 21:54:36 +0000 (08:54 +1100)]
waf: cope with libraries with a specified version number

this fixes a problem with libnss_winbind.so.2. Thanks to Jelmer for
spotting this.

13 years agos4-libcli: make LIBCLI_LDAP a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:55 +0000 (08:30 +1100)]
s4-libcli: make LIBCLI_LDAP a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-auth: make auth a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:39 +0000 (08:30 +1100)]
s4-auth: make auth a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoreplace: make libreplace a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:15 +0000 (08:30 +1100)]
replace: make libreplace a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-ndr: make NDR_TABLE a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:29:24 +0000 (08:29 +1100)]
s4-ndr: make NDR_TABLE a private library

this greatly reduces the size of ndrdump, and saves us a fair bit of
duplication

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibcli: make LIBCLI_NBT a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:28:35 +0000 (08:28 +1100)]
libcli: make LIBCLI_NBT a private library

13 years agowrapper: make socket_wrapper, uid_wrapper and nss_wrapper private libs
Andrew Tridgell [Wed, 20 Oct 2010 21:28:12 +0000 (08:28 +1100)]
wrapper: make socket_wrapper, uid_wrapper and nss_wrapper private libs

this prevents double instantiation

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: re-work the module alias code
Andrew Tridgell [Wed, 20 Oct 2010 21:27:07 +0000 (08:27 +1100)]
waf: re-work the module alias code

we now create a base library, and then create the alias modules as
wrappers around that base. That prevents double instantiation of any
object files in the modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: make SAMDB_COMMON into a private library
Andrew Tridgell [Wed, 20 Oct 2010 07:19:55 +0000 (18:19 +1100)]
s4-dsdb: make SAMDB_COMMON into a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agolibcli: make the LIBSECURITY subsystem into a private library
Andrew Tridgell [Wed, 20 Oct 2010 07:19:31 +0000 (18:19 +1100)]
libcli: make the LIBSECURITY subsystem into a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: fixed expansion of direct_objects and direct_libs
Andrew Tridgell [Wed, 20 Oct 2010 07:17:52 +0000 (18:17 +1100)]
waf: fixed expansion of direct_objects and direct_libs

these do not need to be expanded in break_dependency_loops()

13 years agowaf: allows libraries to be marked as private_library=True
Andrew Tridgell [Wed, 20 Oct 2010 07:17:13 +0000 (18:17 +1100)]
waf: allows libraries to be marked as private_library=True

this is for libraries where we make no promises about the API, but
where we wish it to be a library to allow our binaries to use common
code.

These libraries always get the project suffix added to the library
name, to ensure we are in a separate namespace

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: rework expand_subsystem_deps()
Andrew Tridgell [Wed, 20 Oct 2010 07:11:31 +0000 (18:11 +1100)]
waf: rework expand_subsystem_deps()

make the variable names a lot clearer, and restrict the expansion of
subsystem deps to object style subsystems and modules. If a subsystem
or a module is built as a library then we don't need to expand the
dependencies across that boundary

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agowaf: added --show-deps and --show-duplicates
Andrew Tridgell [Wed, 20 Oct 2010 07:09:45 +0000 (18:09 +1100)]
waf: added --show-deps and --show-duplicates

these options make it easier to examine our depenency tree, by showing
any objects linked into more than one library, and by showing the
dependency tree for a chosen target

13 years agoldb:ldb_modules.c - if we don't find the associated dynamic object then please close...
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:51:46 +0000 (08:51 +0200)]
ldb:ldb_modules.c - if we don't find the associated dynamic object then please close the handle

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 21 07:52:44 UTC 2010 on sn-devel-104

13 years agoldb:ldb_tdb/ldb_cache.c - remove a superflous "talloc_free"
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 07:03:31 +0000 (09:03 +0200)]
ldb:ldb_tdb/ldb_cache.c - remove a superflous "talloc_free"

Didn't realise that this is already called by "ltdb_attributes_unload".

13 years agoldb:ldb_tdb/ldb_cache.c - in this function we don't use LDB return codes
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:45:06 +0000 (08:45 +0200)]
ldb:ldb_tdb/ldb_cache.c - in this function we don't use LDB return codes

13 years agos4:lib/util/charset/iconv.c - remove a distinction which can never happen
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 17:55:28 +0000 (19:55 +0200)]
s4:lib/util/charset/iconv.c - remove a distinction which can never happen

"ret->cd_direct" is never set before. It is set in the "if" upperwards but
then the function is terminated with "return".

13 years agoNow we have SeSystemSecurity, remove the source3-only #ifdef.
Jeremy Allison [Thu, 21 Oct 2010 00:51:13 +0000 (17:51 -0700)]
Now we have SeSystemSecurity, remove the source3-only #ifdef.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 01:35:00 UTC 2010 on sn-devel-104

13 years agoAdd code to implement SeSecurityPrivilege in net rpc rights, and in the
Jeremy Allison [Wed, 20 Oct 2010 23:31:18 +0000 (16:31 -0700)]
Add code to implement SeSecurityPrivilege in net rpc rights, and in the
open and get/set NT security descriptor code.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 00:15:57 UTC 2010 on sn-devel-104

13 years agopytalloc: use talloc_unlink() to free py_talloc objects
Kamen Mazdrashki [Fri, 8 Oct 2010 01:21:07 +0000 (04:21 +0300)]
pytalloc: use talloc_unlink() to free py_talloc objects

Those type of objects are referenced every time we assign
them to other py_talloc objects, which leads to runtime
warnings that we are trying to free an object with references

Wrap talloc_unlink() in SMB_ASSERT() to ensure we catch possible failure

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct 20 21:37:06 UTC 2010 on sn-devel-104

13 years agotalloc: make header C++ safe
Simo Sorce [Wed, 20 Oct 2010 17:09:57 +0000 (13:09 -0400)]
talloc: make header C++ safe

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Oct 20 18:15:09 UTC 2010 on sn-devel-104

13 years agosmbtorture: Fix typo in status message.
James Peach [Wed, 20 Oct 2010 17:07:33 +0000 (10:07 -0700)]
smbtorture: Fix typo in status message.

13 years agos3: Make "unpack_pjob" static
Volker Lendecke [Mon, 18 Oct 2010 07:48:30 +0000 (09:48 +0200)]
s3: Make "unpack_pjob" static

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct 20 16:51:04 UTC 2010 on sn-devel-104

13 years agos3: Use any_nt_status_not_ok in winbind
Volker Lendecke [Mon, 18 Oct 2010 08:10:43 +0000 (10:10 +0200)]
s3: Use any_nt_status_not_ok in winbind

13 years agos3: Add any_nt_status_not_ok
Volker Lendecke [Mon, 18 Oct 2010 08:09:57 +0000 (10:09 +0200)]
s3: Add any_nt_status_not_ok

This helps avoid quite a bit of repetitive code when looking at dcerpc_xx_recv
results.

13 years agos3: Don't use talloc_autofree_context in map_file
Volker Lendecke [Sat, 9 Oct 2010 08:12:06 +0000 (10:12 +0200)]
s3: Don't use talloc_autofree_context in map_file

13 years agouid_wrapper: The gid wrapper does not require a destructor
Volker Lendecke [Sat, 9 Oct 2010 07:44:43 +0000 (09:44 +0200)]
uid_wrapper: The gid wrapper does not require a destructor

Don't use talloc_autofree_context

13 years agoMake getpwnam_alloc() static to lib/username.c, and ensure all username lookups go
Jeremy Allison [Wed, 20 Oct 2010 15:16:23 +0000 (08:16 -0700)]
Make getpwnam_alloc() static to lib/username.c, and ensure all username lookups go
through Get_Pwnam_alloc(), which is the correct wrapper function. We were using
it *some* of the time anyway, so this just makes us properly consistent.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 20 16:02:12 UTC 2010 on sn-devel-104

13 years agonsstest: no need for two copies of the same tool.
Günther Deschner [Wed, 20 Oct 2010 12:52:30 +0000 (14:52 +0200)]
nsstest: no need for two copies of the same tool.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 20 15:05:34 UTC 2010 on sn-devel-104

13 years agos3-waf: more registry cleanup.
Günther Deschner [Wed, 20 Oct 2010 00:17:41 +0000 (02:17 +0200)]
s3-waf: more registry cleanup.

Guenher

13 years agos3-waf: convert LIBSMBCONF into a subsystem.
Günther Deschner [Tue, 19 Oct 2010 23:54:12 +0000 (01:54 +0200)]
s3-waf: convert LIBSMBCONF into a subsystem.

Guenther

13 years agos3-waf: move RPC_CLIENT_SCHANNEL into a subsystem.
Günther Deschner [Fri, 8 Oct 2010 11:17:21 +0000 (13:17 +0200)]
s3-waf: move RPC_CLIENT_SCHANNEL into a subsystem.

Guenther

13 years agos4-schema_init: Print more info about syntax we fail to recognize
Kamen Mazdrashki [Wed, 20 Oct 2010 10:43:00 +0000 (13:43 +0300)]
s4-schema_init: Print more info about syntax we fail to recognize

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct 20 13:54:01 UTC 2010 on sn-devel-104

13 years agoasn1_tests.c: Make test data static const
Kamen Mazdrashki [Mon, 18 Oct 2010 00:50:20 +0000 (03:50 +0300)]
asn1_tests.c: Make test data static const

13 years agolib/util/asn1.c: comment spelling
Kamen Mazdrashki [Mon, 18 Oct 2010 00:49:21 +0000 (03:49 +0300)]
lib/util/asn1.c: comment spelling

13 years agoldb:ldb_index.c - fix some memory leaks
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:27:04 +0000 (14:27 +0200)]
ldb:ldb_index.c - fix some memory leaks

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Oct 20 13:11:49 UTC 2010 on sn-devel-104

13 years agoldb:ldb_index.c - let "ldb_module_oom" generate the return code
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:26:37 +0000 (14:26 +0200)]
ldb:ldb_index.c - let "ldb_module_oom" generate the return code

13 years agoldb:ldb_cache.c - fix memory contexts and memory leaks
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:08:53 +0000 (14:08 +0200)]
ldb:ldb_cache.c - fix memory contexts and memory leaks

13 years agoldb:ldb_tdb submodule - use "ldb_msg_new" where appropriate
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 11:53:14 +0000 (13:53 +0200)]
ldb:ldb_tdb submodule - use "ldb_msg_new" where appropriate

It is saver than a manual "talloc".

13 years agoldb:ldb_pack.c - remove superflous "message->elements = NULL"
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 11:47:48 +0000 (13:47 +0200)]
ldb:ldb_pack.c - remove superflous "message->elements = NULL"

It's already marked at this at the beginning of the call.