samba.git
23 years agoProto update. Also fix from John Reilly @ HP for not showing APW with W2K.
Jeremy Allison [Fri, 6 Oct 2000 20:03:17 +0000 (20:03 +0000)]
Proto update. Also fix from John Reilly @ HP for not showing APW with W2K.
Jeremy.
(This used to be commit 698288cb9de316527c0c2a271e18c920578f9930)

23 years agoHerb's warning fixes. Also the POSIX locking fix.
Jeremy Allison [Fri, 6 Oct 2000 18:13:52 +0000 (18:13 +0000)]
Herb's warning fixes. Also the POSIX locking fix.
We now use our own vfs layer to do get/set acl calls (hurrah!).
Jeremy.
(This used to be commit dfe77c7046cbd65ee52aea7439f21503c1eac41d)

23 years agoglobal_myname is actually a pstring.
Tim Potter [Fri, 6 Oct 2000 04:36:05 +0000 (04:36 +0000)]
global_myname is actually a pstring.
(This used to be commit e451fd346105d5d34354ff9141d445b5f1a82e0a)

23 years agoInlined many of the vfs_XXX calls as macros for speed.
Jeremy Allison [Fri, 6 Oct 2000 03:41:48 +0000 (03:41 +0000)]
Inlined many of the vfs_XXX calls as macros for speed.
Jeremy.
(This used to be commit 0811d080abd374f47c7c3c8a1ef007e443e5b79c)

23 years agoRestructuring of vfs layer to include a "this" pointer - can be an fsp or
Jeremy Allison [Fri, 6 Oct 2000 03:21:49 +0000 (03:21 +0000)]
Restructuring of vfs layer to include a "this" pointer - can be an fsp or
a conn struct depending on the call.
We need this to have a clean NT ACL call interface.
This will break any existing VFS libraries (that's why this is pre-release
code).
Andrew gets credit for this one :-) :-).

In addition - added Herb's WITH_PROFILE changes - Herb - please examine
the changes I've made to the smbd/reply.c code you added. The original
code was very ugly and I have replaced it with a
START_PROFILE(x)/END_PROFILE(x) pair using the preprocessor.
Please check this compiles ok with the --with-profile switch.
Jeremy.
(This used to be commit b07611f8159b0b3f42e7e02611be9f4d56de96f5)

23 years agoFix for null passwords being allowed bug.
Jeremy Allison [Thu, 5 Oct 2000 22:51:57 +0000 (22:51 +0000)]
Fix for null passwords being allowed bug.
Jeremy.
(This used to be commit d4d55488397832df35b558564c263a307b0bb629)

23 years agoFixes from Damian at Cisco to tidy up some tdbtool issues.
Jeremy Allison [Thu, 5 Oct 2000 22:19:34 +0000 (22:19 +0000)]
Fixes from Damian at Cisco to tidy up some tdbtool issues.
Jeremy.
(This used to be commit 623bfa6c935e2e3acb3145bfbd490758b34d2c70)

23 years agoVector get_nt_acl/set_nt_acl via vfs. POSIX ACL support should be added
Jeremy Allison [Thu, 5 Oct 2000 19:04:41 +0000 (19:04 +0000)]
Vector get_nt_acl/set_nt_acl via vfs. POSIX ACL support should be added
above this layer.
Jeremy.
(This used to be commit b90af886a951b7b049ed7a42e6d99c332e43897b)

23 years agoHerb's fixes for profiling & compiler warnings.
Jeremy Allison [Thu, 5 Oct 2000 18:50:18 +0000 (18:50 +0000)]
Herb's fixes for profiling & compiler warnings.
Jeremy.
(This used to be commit 7914e9351abb5271ebb4990c3b1fe495d15a4eda)

23 years agosomeone forgot to update proto.h :-)
Jean-François Micouleau [Thu, 5 Oct 2000 12:43:37 +0000 (12:43 +0000)]
someone forgot to update proto.h :-)

J.F.
(This used to be commit 3664e80fcd292ee8ba20861b01945d7db59858a9)

23 years agofixing prs_unistr2(). For the special case of an empty (but existing)
Jean-François Micouleau [Thu, 5 Oct 2000 12:41:31 +0000 (12:41 +0000)]
fixing prs_unistr2(). For the special case of an empty (but existing)
string.

J.F.
(This used to be commit 83bfe94771e0afbffbb4a1a741cd9983ef612362)

23 years agoSpelling flames. (-:
Tim Potter [Thu, 5 Oct 2000 03:35:37 +0000 (03:35 +0000)]
Spelling flames.  (-:
(This used to be commit 178e6971005505d2debd74b761ecfaa982336a53)

23 years agoAdded uid and gid to push_sec_ctx() debug.
Tim Potter [Thu, 5 Oct 2000 03:28:58 +0000 (03:28 +0000)]
Added uid and gid to push_sec_ctx() debug.
(This used to be commit 2817b6cc8af3edbaa63b5db67689ab94cb240d4f)

23 years agoFixed compiler warnings.
Tim Potter [Thu, 5 Oct 2000 03:14:28 +0000 (03:14 +0000)]
Fixed compiler warnings.
(This used to be commit ec7f7e350dc1dfa757436cb0efe777c3e0719877)

23 years agoMade re-init of stat cache explicit rather than being hidden.
Jeremy Allison [Wed, 4 Oct 2000 22:37:33 +0000 (22:37 +0000)]
Made re-init of stat cache explicit rather than being hidden.
Jeremy.
(This used to be commit b0c40236bb4381fec0e812c20e5f8c09ebf005f9)

23 years agoAdding Herb's compile warning fixes to HEAD.
Jeremy Allison [Wed, 4 Oct 2000 01:03:23 +0000 (01:03 +0000)]
Adding Herb's compile warning fixes to HEAD.
Jeremy.
(This used to be commit d131ad1ce3f6e72e295f865a463f8dcbfa6f8d42)

23 years agoFixes for the fact that UNICODE sizes are no always 2*no of chars when
Jeremy Allison [Tue, 3 Oct 2000 19:15:05 +0000 (19:15 +0000)]
Fixes for the fact that UNICODE sizes are no always 2*no of chars when
in multibyte codepages. Fix from Hiroshi MIURA, Samba User Group Japan staff.
Jeremy.
(This used to be commit f2f373df67a3c6b0bd431c19e3494d45ef0a263c)

23 years agoFixes from Herb - compiler warnings.
Jeremy Allison [Tue, 3 Oct 2000 18:29:12 +0000 (18:29 +0000)]
Fixes from Herb - compiler warnings.
Jeremy.
(This used to be commit d9d3668fa322cbed36ca3393d8268bf0e5255e8d)

23 years agoutf-8 and EUC3 patch from Hiroshi Miura Samba User Group Japan staff.
Jeremy Allison [Tue, 3 Oct 2000 02:12:14 +0000 (02:12 +0000)]
utf-8 and EUC3 patch from Hiroshi Miura Samba User Group Japan staff.
mkdir high bits patch from Robert Dahlem" <Robert.Dahlem@gmx.net>.
jeremy.
(This used to be commit b40191d27180ab1e59935086073c4d312552f717)

23 years agoMemleak fix for cache code.
Jeremy Allison [Mon, 2 Oct 2000 21:03:46 +0000 (21:03 +0000)]
Memleak fix for cache code.
Jeremy.
(This used to be commit 1ebe54666b0fc6f224f17036063dfe0ef7ec9147)

23 years agoAdded debug so if zero length messages get sent we successfully remove
Jeremy Allison [Mon, 2 Oct 2000 19:28:26 +0000 (19:28 +0000)]
Added debug so if zero length messages get sent we successfully remove
them (this can happen if smbd processes are shut down at the wrong time).
Jeremy.
(This used to be commit c1de97f96b8c5ad8e5f01a0d17c6387733769442)

23 years agoMissing null termination on printer changenotify message caused insure
Jeremy Allison [Fri, 29 Sep 2000 21:15:45 +0000 (21:15 +0000)]
Missing null termination on printer changenotify message caused insure
error.
Jeremy.
(This used to be commit 3733d29ce678c71ef2ee8b600e547765d8d8ea9e)

23 years agoutils/smbcontrol.c: Fixes from Herb for interactive use.
Jeremy Allison [Fri, 29 Sep 2000 20:08:00 +0000 (20:08 +0000)]
utils/smbcontrol.c: Fixes from Herb for interactive use.
printing/nt_printing.c: No C++ comments please :-).
Jeremy.
(This used to be commit dd9f668108215f18240458fc33bf872a6fc9e6be)

23 years agonew man pages
Herb Lewis [Fri, 29 Sep 2000 19:50:57 +0000 (19:50 +0000)]
new man pages
(This used to be commit 8a7d6c8e91ecd57f2693be7d697d8231c8d339a4)

23 years agonew prototypes
Andrew Tridgell [Fri, 29 Sep 2000 04:47:18 +0000 (04:47 +0000)]
new prototypes
(This used to be commit 3e77bf2117c43d3202774df24debc91f61d88733)

23 years agoadded a hack to get 64 bit locking working with the broken fcntl()
Andrew Tridgell [Fri, 29 Sep 2000 04:45:00 +0000 (04:45 +0000)]
added a hack to get 64 bit locking working with the broken fcntl()
call in glibc 2.1.95. This hack only gets enabled if you define
GLIBC_HACK_FCNTL64
(This used to be commit d8b9ec741cc57b5f3dd1b3ef782a7baed402beaa)

23 years agouse the 64 bit locking interface in locktest
Andrew Tridgell [Fri, 29 Sep 2000 04:43:07 +0000 (04:43 +0000)]
use the 64 bit locking interface in locktest
(This used to be commit 1ece7f1ffd7d0b61d6acea03819fb857ea556b4b)

23 years agofixed a harmess mixup of bitops and a boolean
Andrew Tridgell [Fri, 29 Sep 2000 04:42:29 +0000 (04:42 +0000)]
fixed a harmess mixup of bitops and a boolean
(This used to be commit 0e0f3dc577ceab540be6505a86697b14a2136b9f)

23 years agoadded cli_lock64() and cli_unlock64()
Andrew Tridgell [Fri, 29 Sep 2000 04:41:52 +0000 (04:41 +0000)]
added cli_lock64() and cli_unlock64()
(This used to be commit 91f0a3cc2f59a49f6ce8550e7d07b9b01e0b285f)

23 years agoMissing from HEAD and 2.2 - terminal server reg config.
Jeremy Allison [Thu, 28 Sep 2000 22:17:41 +0000 (22:17 +0000)]
Missing from HEAD and 2.2 - terminal server reg config.
Jeremy.
(This used to be commit f5b5b9f287de343d9eb61817ef99499408f1a019)

23 years agoFix from John Reilly for forms ordering problems.
Jeremy Allison [Thu, 28 Sep 2000 21:33:08 +0000 (21:33 +0000)]
Fix from John Reilly for forms ordering problems.
Jeremy.
(This used to be commit 837839eb3d0fae7fef5d61593862a2c1b00d6a07)

23 years agoRemoved a line by mistake...
Jeremy Allison [Thu, 28 Sep 2000 20:58:15 +0000 (20:58 +0000)]
Removed a line by mistake...
Jeremy.
(This used to be commit dcbdff7a4d6442ca8f9e1aa6fcf65c196c2f22bf)

23 years agoAdded comment on JF's new code. Removed ifdef in passdb/smbpass.c as this
Jeremy Allison [Thu, 28 Sep 2000 20:36:28 +0000 (20:36 +0000)]
Added comment on JF's new code. Removed ifdef in passdb/smbpass.c as this
was not correct.
Jeremy.
(This used to be commit 1a3f7ecde2ca031b2f93a079f75822354fe241a0)

23 years agofixed samr_create_user(). we now correctly parse the query and the reply.
Jean-François Micouleau [Thu, 28 Sep 2000 17:35:03 +0000 (17:35 +0000)]
fixed samr_create_user(). we now correctly parse the query and the reply.
And we create the disabled account. That means we can create user and
trust accounts remotely !

ifdef out a return in passdb/smbpass.c. I think I didn't break any
security. Jeremy could you check if I didn't make any mistakes ???

J.F.
(This used to be commit 416be1b64f366c8b859f25856fce2467ec0446d9)

23 years agoRemoved annoying unecessary debug message.
Tim Potter [Thu, 28 Sep 2000 00:07:19 +0000 (00:07 +0000)]
Removed annoying unecessary debug message.
(This used to be commit b1a893b74114ee4ab6a295ac0cb0e8fdccda3f53)

23 years agoFixed stupid introduced bug found by "Jim McDonough/Boulder/IBM" <jmcd@us.ibm.com>.
Jeremy Allison [Wed, 27 Sep 2000 21:57:38 +0000 (21:57 +0000)]
Fixed stupid introduced bug found by "Jim McDonough/Boulder/IBM" <jmcd@us.ibm.com>.
Jeremy.
(This used to be commit 563f8b09a810446c658bf58303b5fe998d27bec9)

23 years agoRestructuring of the code to remove dos_ChDir/dos_GetWd and re-vector them
Jeremy Allison [Wed, 27 Sep 2000 19:09:59 +0000 (19:09 +0000)]
Restructuring of the code to remove dos_ChDir/dos_GetWd and re-vector them
through the VFS. All file access/directory access code in smbd should now
go via the vfs. Added vfs_chown/vfs_chmod calls. Still looking at vfs_get_nt_acl()
vfs_set_nt_acl() call API design.
Jeremy.
(This used to be commit f96625ec124adb6e110dc54632e006b3620a962b)

23 years agosamr unknown 0x32 is in fact samr create user.
Jean-François Micouleau [Wed, 27 Sep 2000 13:02:57 +0000 (13:02 +0000)]
samr unknown 0x32 is in fact samr create user.
so renamed and tidy up of the server function.

J.F.
(This used to be commit 0f707ac1fb5685b800d6599b9074ec1d4e65b1c1)

23 years agoignore smbcontrol in bin directory
Jean-François Micouleau [Wed, 27 Sep 2000 11:25:16 +0000 (11:25 +0000)]
ignore smbcontrol in bin directory

J.F.
(This used to be commit d56cc6ebe7fe546c1fe28f6f75d1cc0702694972)

23 years agofix for IRIX 6.2 compiler error
Herb Lewis [Tue, 26 Sep 2000 23:28:04 +0000 (23:28 +0000)]
fix for IRIX 6.2 compiler error
(This used to be commit eecee22bf1ab6e22e5e989b51d522fcf587aa48c)

23 years agofix for IRIX compiler error messages
Herb Lewis [Tue, 26 Sep 2000 18:48:13 +0000 (18:48 +0000)]
fix for IRIX compiler error messages
(This used to be commit f2549db1ce6527c3e378e9f9210c70be5de93762)

23 years agofixed IRIX compiller error message
Herb Lewis [Tue, 26 Sep 2000 14:48:52 +0000 (14:48 +0000)]
fixed IRIX compiller error message
(This used to be commit 908da12d5f24ea076db6627ef0d4407e1cdcd014)

23 years agobroadcast printer notify message to all clients. We now have printer
Jean-François Micouleau [Tue, 26 Sep 2000 10:15:12 +0000 (10:15 +0000)]
broadcast printer notify message to all clients. We now have printer
notification as on NT.

Andrew, your message passing code is cool :-)

J.F.
(This used to be commit 0374bc4b5f56d0fab3f7310e13cb71b5a71f9112)

23 years agoadded NEGNOWAIT. sent to secure@microsoft.com
Luke Leighton [Tue, 26 Sep 2000 05:44:42 +0000 (05:44 +0000)]
added NEGNOWAIT.  sent to secure@microsoft.com
(This used to be commit b21179331802aace566671dcff6db22cdf4b3e81)

23 years agoChanges from John Reilly to add a parameter "show add printer wizard" that
Jeremy Allison [Tue, 26 Sep 2000 00:54:18 +0000 (00:54 +0000)]
Changes from John Reilly to add a parameter "show add printer wizard" that
allows Samba to turn off the display of APW (hmmm. This should probably
be a share specific parameter, I'll fix that in another commit).
Also a few small changes to JF's code to fix compiler warnings about
missing return statements and also change '//' comments (C++) to /* .. */
comments (C).
Jeremy.
(This used to be commit 0a9ccc99b335650d235eb747d803d059f7828fd7)

23 years agoprinter notify code.
Jean-François Micouleau [Mon, 25 Sep 2000 21:05:18 +0000 (21:05 +0000)]
printer notify code.

It only sends notifies to one client. The broadcasting notify code will
code soon.

J.F.
(This used to be commit 4c63c9185887c64e57d901e82a4a16a83522c898)

23 years agoOptimization (noticed by bloody Andrew :-) to stop directory scan ever
Jeremy Allison [Thu, 21 Sep 2000 23:39:19 +0000 (23:39 +0000)]
Optimization (noticed by bloody Andrew :-) to stop directory scan ever
being done if any of the directory timestamps were changed.
Jeremy.
(This used to be commit 915152ed981e8e537d15fd4b80b3c3d10ee86bff)

23 years agoAdding fix from Jim Vopni <jimv@metrics.com> to ensure jobs are
Jeremy Allison [Thu, 21 Sep 2000 21:44:15 +0000 (21:44 +0000)]
Adding fix from Jim Vopni <jimv@metrics.com> to ensure jobs are
closed before a printer is closed/deleted.
Jeremy.
(This used to be commit f0c16f7228d6923b11ac521aef986960a1d0c0b4)

23 years agoSome code moved back from TNG - updates to LSA stuff. Not yet used but
Jeremy Allison [Wed, 20 Sep 2000 22:07:56 +0000 (22:07 +0000)]
Some code moved back from TNG - updates to LSA stuff. Not yet used but
will be needed soon.
Jeremy.
(This used to be commit f0aa8f9314c837fe39b6d1b0c41d5cfae2e4098f)

23 years agoFix to allow a timestamp of zero to cause an instantaneous changenotify
Jeremy Allison [Wed, 20 Sep 2000 19:00:21 +0000 (19:00 +0000)]
Fix to allow a timestamp of zero to cause an instantaneous changenotify
scan - then call this from renames. This allows instantaneous update for
W2k renames.
Jeremy.
(This used to be commit 07dffc4ee931cbc61197e2da277df9c404a77469)

23 years agoparam/loadparm.c: Fix based on Damian's code to stop printer scripts getting overwritten.
Jeremy Allison [Tue, 19 Sep 2000 22:32:56 +0000 (22:32 +0000)]
param/loadparm.c: Fix based on Damian's code to stop printer scripts getting overwritten.
rpc_parse/parse_spoolss.c: Tidyup to call function for relstring arrays.
Win2000 now does "Add Printer" successfully !!!!!

Jeremy.
(This used to be commit d666b958bc335c7fceebeb7a6333d78bc421c30f)

23 years agoModified test.h generator to return error if structure passed to vluke
Tim Potter [Mon, 18 Sep 2000 01:14:21 +0000 (01:14 +0000)]
Modified test.h generator to return error if structure passed to vluke
doesn't match any known structure names.
(This used to be commit ce70fb5800a875ea755c96bc214033c5e9d81081)

23 years agoRemoved emacs backup file from repository.
Tim Potter [Mon, 18 Sep 2000 01:09:25 +0000 (01:09 +0000)]
Removed emacs backup file from repository.
(This used to be commit 807f22412e2738bb6323e43a2da6c942017621ac)

23 years agoin a printer_info_6, driver version is 64 bits long and there is a 32 bit
Jean-François Micouleau [Sat, 16 Sep 2000 10:07:46 +0000 (10:07 +0000)]
in a printer_info_6, driver version is 64 bits long and there is a 32 bit
padding before.

J.F.
(This used to be commit cd41d7a35477accec1a82b86f9fa3477e5a49d6e)

23 years agoFixes from JF as I didn't understand the string array sizing code correctly.
Jeremy Allison [Fri, 15 Sep 2000 21:20:49 +0000 (21:20 +0000)]
Fixes from JF as I didn't understand the string array sizing code correctly.
Jeremy.
(This used to be commit 63a7d0fc359ab7cb2ece74dff0ee25f6bb9fbe36)

23 years agoMove towards getting W2k p&p to upload NT4.x drivers. Still doesn't work -
Jeremy Allison [Fri, 15 Sep 2000 00:15:10 +0000 (00:15 +0000)]
Move towards getting W2k p&p to upload NT4.x drivers. Still doesn't work -
not sure why (JF - a glance at this would be appreciated). Removed code
that JF objected to with enumprinterdata. Added translations to/from
level 6 - but Win2k still not happy... hmmm...
Jeremy.
(This used to be commit e5d98ba9e97eb16337ff6c49f799e130844ae72e)

23 years agoPlaceholder for some forthcoming documentation
Gerald Carter [Thu, 14 Sep 2000 16:49:50 +0000 (16:49 +0000)]
Placeholder for some forthcoming documentation

jerry
(This used to be commit d4a60f22331b3ead4dd428f3dbe699f56a3a30b3)

23 years agofixed typo
Gerald Carter [Thu, 14 Sep 2000 16:47:49 +0000 (16:47 +0000)]
fixed typo

jerry
(This used to be commit d2949468dccd79eb281769cd0da74e4b37d936b8)

23 years agoAdded a gew more mods by Patrick Powell (lprng guy)
Gerald Carter [Thu, 14 Sep 2000 16:44:44 +0000 (16:44 +0000)]
Added a gew more mods by Patrick Powell (lprng guy)

jerry
(This used to be commit d675a6bd147e974c7970310ba8af9032f8bba1c7)

23 years agoFirst draft of new printing doc describing the SPOOLSS support in the
Gerald Carter [Thu, 14 Sep 2000 16:40:51 +0000 (16:40 +0000)]
First draft of new printing doc describing the SPOOLSS support in the
upcoming 2.2.0 release.

Needs some other eyes to review it.  :-)

jerry
(This used to be commit c9a76a2e10fd14fc1c63184afcda986163912b06)

23 years agoEnsure old DACL and SACL are preserved if the new SD is a 'set' only.
Jeremy Allison [Wed, 13 Sep 2000 22:01:15 +0000 (22:01 +0000)]
Ensure old DACL and SACL are preserved if the new SD is a 'set' only.
Jeremy.
(This used to be commit 29f41d0d95661fbc31ae1d9669fd7fb439169f90)

23 years agoAdded SIGHUP when printer deleted as well as added.
Jeremy Allison [Wed, 13 Sep 2000 18:50:38 +0000 (18:50 +0000)]
Added SIGHUP when printer deleted as well as added.
Jeremy.
(This used to be commit 79c94f37d0434150d84858e67c8677650106d76c)

23 years agodon't show equivalent enum options in swat
Andrew Tridgell [Wed, 13 Sep 2000 07:08:09 +0000 (07:08 +0000)]
don't show equivalent enum options in swat
(This used to be commit 52074960971995580a03647ac5c638043eb8f5e1)

23 years agofirst cut at smbcontrol program. It currently allows syntax like:
Andrew Tridgell [Wed, 13 Sep 2000 07:07:17 +0000 (07:07 +0000)]
first cut at smbcontrol program. It currently allows syntax like:

  smbcontrol nmbd debug 7
  smbcontrol smbd debug 9
  smbcontrol 3278 debug 1
  smbcontrol nmbd force-election
(This used to be commit 5f91c24636f5d82486f22c10bc55e060f9c518bf)

23 years agoWhen creating a print job entry for the printing backend, use the Windows
Tim Potter [Wed, 13 Sep 2000 04:42:06 +0000 (04:42 +0000)]
When creating a print job entry for the printing backend, use the Windows
username rather than the Unix username.  The Windows username will then be
shown in the port monitor regardless of the Unix username used to spool the
job.
(This used to be commit a15e610bb34636448cb30e590277c53e7f9efe1a)

23 years agoAdded time check test before allowing print job.
Jeremy Allison [Wed, 13 Sep 2000 02:24:35 +0000 (02:24 +0000)]
Added time check test before allowing print job.
Jeremy.
(This used to be commit 0249de4cd91d72efb344e9fb05e2be2cb3f03945)

23 years agoAdded missing break statement for manage documents check in
Tim Potter [Wed, 13 Sep 2000 01:18:01 +0000 (01:18 +0000)]
Added missing break statement for manage documents check in
print_access_check() function.
(This used to be commit 318ead783c842f2a557207690afd522b3d28e077)

23 years agoUpdated manual pages to point at http://lists.samba.org instead of old
Tim Potter [Tue, 12 Sep 2000 23:00:01 +0000 (23:00 +0000)]
Updated manual pages to point at lists.samba.org instead of old
listproc address.
(This used to be commit 0d7f81633157d6028a47488020862fe24a648546)

23 years agoFix for enumjobs infor level 2 which caused smbd to coredump.
Jeremy Allison [Tue, 12 Sep 2000 22:33:41 +0000 (22:33 +0000)]
Fix for enumjobs infor level 2 which caused smbd to coredump.
Uninitialized element in struct.
Jeremy.
(This used to be commit 9e1fbb0c2f1d2ad0c907f1e902e44ea7af214b57)

23 years agoFixed error return when printer is PAUSED - should be returning "Pause".
Jeremy Allison [Tue, 12 Sep 2000 21:45:42 +0000 (21:45 +0000)]
Fixed error return when printer is PAUSED - should be returning "Pause".
Jeremy.
(This used to be commit 41d03a118c9981fc2159f37cd5ed4684e1d36037)

23 years agoWith John Reilly help tracking it down - fixed a *nasty* bug when
Jeremy Allison [Tue, 12 Sep 2000 19:51:38 +0000 (19:51 +0000)]
With John Reilly help tracking it down - fixed a *nasty* bug when
authorising logins. If a user connected to a share as guest, then
the snum was getting flagged as "force guest", meaning that all
subsequent connections to it, even under a different vuid, would
be bounced to guest.
This explains several very hard to reproduce access denied bugs,
and as the NT client also has bugs in that it will sometimes
erroneously use guest instead of the correct vuid on an IPC$
connection lead to a *very* hard problem to find.
This fix should be propagated into all branches (TNG/Applience
take note) and I'll also make a separate patch availalble on the
samba-technical list.
Jeremy.
(This used to be commit 0264fdafe909cf9e995df3ae7b64bedbe0b4e8a1)

23 years agospoolgetprinterdriver now returns "Windows NT x86" and "Windows 4.0"
Gerald Carter [Tue, 12 Sep 2000 16:03:16 +0000 (16:03 +0000)]
spoolgetprinterdriver now returns "Windows NT x86" and "Windows 4.0"
driver information.

Will merge into TNG.

jerry
(This used to be commit ae7dd77c2495d5e17f6e8da94afbe8cab3e773bb)

23 years agofixed a race in the pipe() setup in sys_select()
Andrew Tridgell [Tue, 12 Sep 2000 07:24:06 +0000 (07:24 +0000)]
fixed a race in the pipe() setup in sys_select()
(This used to be commit bb0f769272d8a8bd527053746b468bca797e1663)

23 years ago- fixed some memory leaks in the messages code
Andrew Tridgell [Tue, 12 Sep 2000 06:57:25 +0000 (06:57 +0000)]
- fixed some memory leaks in the messages code

- added a MSG_PING message for performance testing.
(This used to be commit e779f834dbb875669c3aa0a35b324aa13f0c8c36)

23 years ago- changed the msg_type to be an int instead of an enum so that it is
Andrew Tridgell [Tue, 12 Sep 2000 06:13:25 +0000 (06:13 +0000)]
- changed the msg_type to be an int instead of an enum so that it is
easier to add new message types to messages.h without breaking old
binaries

- added a MSG_FORCE_ELECTION message to force nmbd to hold an election
(This used to be commit f1c49ca7ce56bc39259041a71479e84ebf53eeca)

23 years agowe should not lowercase the username we receive in
Andrew Tridgell [Tue, 12 Sep 2000 04:50:36 +0000 (04:50 +0000)]
we should not lowercase the username we receive in
reply_sesssetup_and_X(). The getpwnam() wrapper handles the case
munging operations later.

this fixes a problem with mixed case usernames.
(This used to be commit 2ebfdd21b3123d7daefeeed4dae6e8bc3a7a7653)

23 years agomuch nicer message interface. We now register dispatch functions,
Andrew Tridgell [Tue, 12 Sep 2000 00:47:11 +0000 (00:47 +0000)]
much nicer message interface. We now register dispatch functions,
allowing new bits of code or vfs modules to register functions without
impacting on the messaging code itself.

Also note that multiple registrations for the same message type are
possible allowing the same message to be delivered to multiple parts
of the code (possibly useful for reload messages).
(This used to be commit c3350c77f52cade48d2945574e09cb630af85b92)

23 years agoFixed memory leaks found in enumprinterdrivers code.
Jeremy Allison [Mon, 11 Sep 2000 23:43:44 +0000 (23:43 +0000)]
Fixed memory leaks found in enumprinterdrivers code.
Jeremy.
(This used to be commit e08b521559a824da09b0b73a04e462c573c42b06)

23 years agoFix for malloc of zero bytes found by insure.
Jeremy Allison [Mon, 11 Sep 2000 23:21:16 +0000 (23:21 +0000)]
Fix for malloc of zero bytes found by insure.
Jeremy.
(This used to be commit 2916790859acc56e582056774b02d4a33cedeaa4)

23 years agodebug messages now work for nmbd
Andrew Tridgell [Mon, 11 Sep 2000 07:33:44 +0000 (07:33 +0000)]
debug messages now work for nmbd
(This used to be commit 6a503f95b10f6661b089f30f2b5ffebead32685c)

23 years agoa simple test program I use to test the debug message system
Andrew Tridgell [Mon, 11 Sep 2000 07:03:10 +0000 (07:03 +0000)]
a simple test program I use to test the debug message system
(This used to be commit db1ec05f89071cd1ae4b190dda843b38e2d97cef)

23 years agothe first cut of the internal messaging system.
Andrew Tridgell [Mon, 11 Sep 2000 07:02:43 +0000 (07:02 +0000)]
the first cut of the internal messaging system.

The motivation for this system is to replace the UDP message for
oplocks, but this commit only does the "set debug level" message.
(This used to be commit 2a34ee95f3929cff131db6c5a2b4820194c05b2d)

23 years agoImplemented DELETEPRINTERDATA (tested with Gerald's Win32 progs).
Jeremy Allison [Sat, 9 Sep 2000 00:19:35 +0000 (00:19 +0000)]
Implemented DELETEPRINTERDATA (tested with Gerald's Win32 progs).
Jeremy.
(This used to be commit fb48efaf830626f6ef05b88f5f8a74b932ceb257)

23 years agoFixed up get_a_printer_driver_3 so it looks in the tdb using the correct
Jeremy Allison [Fri, 8 Sep 2000 21:24:45 +0000 (21:24 +0000)]
Fixed up get_a_printer_driver_3 so it looks in the tdb using the correct
key name for a driver info. Version needs to be adjusted in the same
way that it is adjusted when the driver info is stored in the tdb.
AddPrinterConnection() Win32 call caught this one.
Jeremy.
(This used to be commit 54cab7dd3b7c1ad3a01692447f80134518772486)

23 years agoFixed typo where docname was being checked for datatype - was causing
Jeremy Allison [Fri, 8 Sep 2000 02:20:48 +0000 (02:20 +0000)]
Fixed typo where docname was being checked for datatype - was causing
STARTDOCPRINTER call to fail. I *love* Gerald's test code :-).
Jeremy.
(This used to be commit 43192370f31c7cc71d1f72449a067573adad3ebc)

23 years agoWin32 API is explicit that EnumPrinterData returns ERROR_MORE_DATA not
Jeremy Allison [Fri, 8 Sep 2000 00:28:07 +0000 (00:28 +0000)]
Win32 API is explicit that EnumPrinterData returns ERROR_MORE_DATA not
ERROR_INSUFICIENT_BUFFER when working out what space is needed. This fix
gives us the same return that WinNT does.
Jeremy.
(This used to be commit a87f6277b1faa1ea492f31add4ce33556bdf3695)

23 years agoFixed the printerdata code to return NO_MORE_ITEMS if a size is requested
Jeremy Allison [Thu, 7 Sep 2000 20:56:24 +0000 (20:56 +0000)]
Fixed the printerdata code to return NO_MORE_ITEMS if a size is requested
and the parameter index doesn't exist. I think this code can be simplified
considerably, but JF needs to check to be sure.
Jeremy.
(This used to be commit 4d792e6bcb7bef640c2c4e3054ed8839d8fc86f4)

23 years agoAdded code to return NO_MORE_ENTRIES when trying to determine
Jeremy Allison [Thu, 7 Sep 2000 19:12:59 +0000 (19:12 +0000)]
Added code to return NO_MORE_ENTRIES when trying to determine
size using "NT mega hack". I think this is the correct thing to
do but JF should also examine the.
Jeremy.
(This used to be commit 29ba3a2cdf7f6fbcf0be41b75d76c04007cd4651)

23 years agoHopefully this should fix the primary group permission problem.
Tim Potter [Thu, 7 Sep 2000 08:43:05 +0000 (08:43 +0000)]
Hopefully this should fix the primary group permission problem.
(This used to be commit 2f33ec41ac1d3243340455b6c3a6cea22d267f14)

23 years agoTemporary fix to convert from level6 (Win2k) to level 3 (NT4)
Jeremy Allison [Wed, 6 Sep 2000 23:20:35 +0000 (23:20 +0000)]
Temporary fix to convert from level6 (Win2k) to level 3 (NT4)
for driver download files.
Jeremy.
(This used to be commit 1c9ac94c941aac5f6d309a094e4f741d523dbfb0)

23 years agoFix from John Reilly for double free of printer struct.
Jeremy Allison [Wed, 6 Sep 2000 01:55:36 +0000 (01:55 +0000)]
Fix from John Reilly for double free of printer struct.
Jeremy.
(This used to be commit c15b7e41e170ced4e4de2e08f6fba860f51e66ac)

23 years agoFix for the SID history problem when using a Win2k domain controller
Jeremy Allison [Wed, 6 Sep 2000 01:06:39 +0000 (01:06 +0000)]
Fix for the SID history problem when using a Win2k domain controller
with security=domain. Also fixed to dynamically allocate the SIDs and GIDs.
Jeremy.
(This used to be commit 2b1f66eb82f05fe0b85ac5b4916e32847b8de675)

23 years agoImplemented GETFORM tested and working using Gerald's Win32 test progs....
Jeremy Allison [Tue, 5 Sep 2000 20:56:09 +0000 (20:56 +0000)]
Implemented GETFORM tested and working using Gerald's Win32 test progs....
Jeremy.
(This used to be commit 55ed0a9b0c91159c0fc4282c2171d9ced74a302a)

23 years agoChanges from APPLIANCE_HEAD (per Tim Potter):
David O'Neill [Fri, 1 Sep 2000 18:49:26 +0000 (18:49 +0000)]
Changes from APPLIANCE_HEAD (per Tim Potter):
- make proto
- addition of function to convert from errno values to NT status codes
  (source/lib/error.c)
- purge queue done without full access permission will purge only the
  jobs owned by that user, rather than failing.
- unlock job database tdb before sending job to printer
- in print_job_start(), ensure that we don't pick a jobid with an existing
  temporary file that may be owned by another user, as it causes silent
  failures.
- fixes for printer permission checking for NT5 clients
  (source/include/rpc_spoolss.h, source/printing/nt_printing.c,
   source/printing/printing.c, source/rpc_server/srv_spoolss_nt.c)
- change from uint8 to 'enum SID_NAME_USE' (source/rpc_server/srv_lsa.c)
- fixed memory leaks for win95 driver download process
  (source/smbd/lanman.c)
- properly free prs_structs and dacl in testsuite/printing/psec.c
(This used to be commit 74af3e2caec7197e5d1ca389e2f78054a4197502)

23 years agoFix from John Reilly @ HP for my typo with the parameters being reversed. Ooops.
Jeremy Allison [Fri, 1 Sep 2000 17:13:44 +0000 (17:13 +0000)]
Fix from John Reilly @ HP for my typo with the parameters being reversed. Ooops.
Jeremy.
(This used to be commit 8317d70a35086c5539e67d60cbcf937b6ce0932c)

23 years ago-U% should be an anonymous connection. Fixed bug where
Gerald Carter [Fri, 1 Sep 2000 06:25:15 +0000 (06:25 +0000)]
-U% should be an anonymous connection.  Fixed bug where
the password was being set to "" instead of NULL.

..and yes Elrond, I'll merge this into TNG.

P
jerry
(This used to be commit cc611ecc674832f7e7390b5e7ad6648c9d622e9e)

23 years agoFix for swat to return correct MIME type for text files. From "Ron
Tim Potter [Fri, 1 Sep 2000 02:06:20 +0000 (02:06 +0000)]
Fix for swat to return correct MIME type for text files.  From "Ron
Alexander" <rcalex@home.com>
(This used to be commit 061e5e50523913a26bc86bd816c4e26a37a832c7)

23 years agoImplemented DELETEFORM tested using Gerald's Win32 test code :-).
Jeremy Allison [Thu, 31 Aug 2000 19:04:51 +0000 (19:04 +0000)]
Implemented DELETEFORM tested using Gerald's Win32 test code :-).
Jeremy.
(This used to be commit 596c21a2af0309ce43a5e52a343a671036d05ebf)

23 years agomake sure a couple of variables are initialised
Andrew Tridgell [Thu, 31 Aug 2000 07:11:59 +0000 (07:11 +0000)]
make sure a couple of variables are initialised
(This used to be commit 155c7c37398f5f9457ea249ded74f425b90ac9a0)

23 years agofixed "admin users" option with new security code
Andrew Tridgell [Thu, 31 Aug 2000 07:11:45 +0000 (07:11 +0000)]
fixed "admin users" option with new security code
(This used to be commit b69c5de6bad9fad3aed1280e7d12fbfed276a16f)