samba.git
10 years agosubunit: Update to newer upstream version.
Jelmer Vernooij [Mon, 29 Mar 2010 14:25:03 +0000 (16:25 +0200)]
subunit: Update to newer upstream version.

10 years agos4-python: Simplify mechanism for finding included Python modules.
Jelmer Vernooij [Mon, 29 Mar 2010 14:21:26 +0000 (16:21 +0200)]
s4-python: Simplify mechanism for finding included Python modules.

10 years agos4-python: Move dnspython to lib/, like the other Python modules
Jelmer Vernooij [Mon, 29 Mar 2010 14:08:11 +0000 (16:08 +0200)]
s4-python: Move dnspython to lib/, like the other Python modules

This also avoids it from being installed if it's already present on the
system.

10 years agos4-python: Format to PEP8, simplify tests.
Jelmer Vernooij [Mon, 29 Mar 2010 13:43:43 +0000 (15:43 +0200)]
s4-python: Format to PEP8, simplify tests.

10 years agoMake the smbta-util manpage xml create smbta-util.8 instead of smbta-tool.8
Holger Hetterich [Mon, 29 Mar 2010 15:05:34 +0000 (17:05 +0200)]
Make the smbta-util manpage xml create smbta-util.8 instead of smbta-tool.8

Additionally change any references to smbta-tool in the text of the manpage.

Signed-off-by: Andreas Schneider <asn@samba.org>
10 years agopidl:Samba4/Client: don't mix rpc and application NTSTATUS errors anymore for the...
Stefan Metzmacher [Sat, 27 Mar 2010 11:48:21 +0000 (12:48 +0100)]
pidl:Samba4/Client: don't mix rpc and application NTSTATUS errors anymore for the new bindings

The new dcerpc_binding_handle based client stubs don't mix error codes anymore,
while the old dcerpc_pipe based ones still do to keep OpenChange happy for now.

metze

10 years agos4:torture/rpc/samba3rpc.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Wed, 24 Mar 2010 12:14:09 +0000 (13:14 +0100)]
s4:torture/rpc/samba3rpc.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:libnet/libnet_passwd.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Wed, 17 Mar 2010 19:14:53 +0000 (20:14 +0100)]
s4:libnet/libnet_passwd.c: add explicit check for NTSTATUS r.out.result

metze

10 years agos4:libnet/libnet_samsync.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Wed, 17 Mar 2010 19:31:15 +0000 (20:31 +0100)]
s4:libnet/libnet_samsync.c: add explicit check for NTSTATUS r.out.result

metze

10 years agos4:libnet/libnet_join.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Wed, 17 Mar 2010 19:30:57 +0000 (20:30 +0100)]
s4:libnet/libnet_join.c: add explicit check for NTSTATUS r.out.result

metze

10 years agos4:libcli/util/clilsa.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Tue, 23 Mar 2010 14:04:25 +0000 (15:04 +0100)]
s4:libcli/util/clilsa.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/lsa.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Wed, 24 Mar 2010 08:06:54 +0000 (09:06 +0100)]
s4:torture/rpc/lsa.c: add explicit check for NTSTATUS r.out.result

metze

10 years agos4:torture/rpc/samr.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Thu, 18 Mar 2010 23:38:04 +0000 (00:38 +0100)]
s4:torture/rpc/samr.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/handles.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 14:35:36 +0000 (15:35 +0100)]
s4:torture/rpc/handles.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/samr_accessmask.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 11:23:37 +0000 (12:23 +0100)]
s4:torture/rpc/samr_accessmask.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/samsync.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Sat, 27 Mar 2010 09:45:17 +0000 (10:45 +0100)]
s4:torture/rpc/samsync.c: add explicit check for NTSTATUS r.out.result

10 years agos4:torture/rpc/samlogon.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 13:56:52 +0000 (14:56 +0100)]
s4:torture/rpc/samlogon.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/netlogon.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 13:45:38 +0000 (14:45 +0100)]
s4:torture/rpc/netlogon.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/lsa_lookup.c:add explicit check for NTSTATUS r.out.result
Günther Deschner [Thu, 18 Mar 2010 23:09:46 +0000 (00:09 +0100)]
s4:torture/rpc/lsa_lookup.c:add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/libnet:add explicit check for NTSTATUS r.out.result
Günther Deschner [Tue, 23 Mar 2010 14:20:16 +0000 (15:20 +0100)]
s4:torture/libnet:add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/schannel.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 13:17:18 +0000 (14:17 +0100)]
s4:torture/rpc/schannel.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/remote_pac.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 13:48:36 +0000 (14:48 +0100)]
s4:torture/rpc/remote_pac.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/testjoin.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 12:55:35 +0000 (13:55 +0100)]
s4:torture/rpc/testjoin.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/session_key.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Thu, 18 Mar 2010 23:16:29 +0000 (00:16 +0100)]
s4:torture/rpc/session_key.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/eventlog.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 11:57:54 +0000 (12:57 +0100)]
s4:torture/rpc/eventlog.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/unixinfo.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Thu, 18 Mar 2010 23:21:01 +0000 (00:21 +0100)]
s4:torture/rpc/unixinfo.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/ntp: add explicit check for NTSTATUS r.out.result
Günther Deschner [Tue, 23 Mar 2010 14:19:25 +0000 (15:19 +0100)]
s4:torture/ntp: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/atsvc.c: add explicit check for NTSTATUS r.out.result
Günther Deschner [Fri, 19 Mar 2010 11:26:27 +0000 (12:26 +0100)]
s4:torture/rpc/atsvc.c: add explicit check for NTSTATUS r.out.result

Guenther
Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos4:torture/rpc/echo.c: remove NTSTATUS status variables
Stefan Metzmacher [Wed, 24 Mar 2010 08:45:21 +0000 (09:45 +0100)]
s4:torture/rpc/echo.c: remove NTSTATUS status variables

metze

10 years agos4:torture/rpc/echo.c: add explicit check for NTSTATUS r.out.result
Stefan Metzmacher [Wed, 24 Mar 2010 08:31:17 +0000 (09:31 +0100)]
s4:torture/rpc/echo.c: add explicit check for NTSTATUS r.out.result

metze

10 years agos3: Fix bug 7212, "getent group does not return group members"
Volker Lendecke [Mon, 29 Mar 2010 14:59:48 +0000 (16:59 +0200)]
s3: Fix bug 7212, "getent group does not return group members"

10 years agos4-waf: use the libreplace strerror_r if needed
Andrew Tridgell [Mon, 29 Mar 2010 09:53:16 +0000 (20:53 +1100)]
s4-waf: use the libreplace strerror_r if needed

10 years agopytalloc: allow for using a system libtalloc-dev with pytalloc
Andrew Tridgell [Sun, 28 Mar 2010 21:35:30 +0000 (08:35 +1100)]
pytalloc: allow for using a system libtalloc-dev with pytalloc

When we have a system talloc library, we still need to grab pytalloc.h
from lib/talloc. We don't want to just use -Ilib/talloc, as otherwise
we'll get the in-tree talloc.h which may not be compatible with the
system talloc.h

So we need to give the path to pytalloc.h

10 years agotalloc: testsuite should use <talloc.h> not "talloc.h"
Andrew Tridgell [Mon, 29 Mar 2010 07:48:29 +0000 (18:48 +1100)]
talloc: testsuite should use <talloc.h> not "talloc.h"

if we are using the system talloc, the testsuite needs to use the
system talloc.h

10 years agos4: added a simple implementation of bin/samba -b
Andrew Tridgell [Mon, 29 Mar 2010 09:20:25 +0000 (20:20 +1100)]
s4: added a simple implementation of bin/samba -b

this shows the config paths. Useful for debugging --enable-fhs

10 years agos3-selftest: Don't log to stdout, use logfiles instead.
Andreas Schneider [Fri, 26 Mar 2010 12:23:31 +0000 (13:23 +0100)]
s3-selftest: Don't log to stdout, use logfiles instead.

The logging to the logfiles is more verbose and they can be found in
./st/dc/logs. If you still want to log to stdout start selftest with:

SMBD_OPTIONS="-S -d10" make selftest

10 years agos3: Attempt to fix the build on AIX, shm_ptr seems to be a macro there
Volker Lendecke [Mon, 29 Mar 2010 05:24:00 +0000 (07:24 +0200)]
s3: Attempt to fix the build on AIX, shm_ptr seems to be a macro there

10 years agoupgradeprovision: Fix formatting, syntax error.
Jelmer Vernooij [Sun, 28 Mar 2010 20:58:36 +0000 (22:58 +0200)]
upgradeprovision: Fix formatting, syntax error.

10 years agos4 upgradeprovision: add information about upgrade in oEMInformation to keep a better...
Matthieu Patou [Sun, 28 Mar 2010 20:37:26 +0000 (00:37 +0400)]
s4 upgradeprovision: add information about upgrade in oEMInformation to keep a better trace of different updates

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
10 years agos4: allow upgrade provision to fix acl and missing dir on GPO dirs
Matthieu Patou [Sun, 28 Mar 2010 18:48:55 +0000 (22:48 +0400)]
s4: allow upgrade provision to fix acl and missing dir on GPO dirs

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
10 years agoprovision: make gpo related function more reusable for upgradeprovision
Matthieu Patou [Tue, 23 Feb 2010 16:11:58 +0000 (19:11 +0300)]
provision: make gpo related function more reusable for upgradeprovision

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
10 years agoprovision: Remove unnecessary whitespace.
Jelmer Vernooij [Sun, 28 Mar 2010 20:42:31 +0000 (22:42 +0200)]
provision: Remove unnecessary whitespace.

10 years agoselftest: Update locations in README.
Jelmer Vernooij [Sun, 28 Mar 2010 20:42:11 +0000 (22:42 +0200)]
selftest: Update locations in README.

10 years agoselftest: Remove unused BuildFarm output file (now using subunit)
Jelmer Vernooij [Sun, 28 Mar 2010 19:56:09 +0000 (21:56 +0200)]
selftest: Remove unused BuildFarm output file (now using subunit)

10 years agoselftest: Remove html subunit formatter; it's too simple and really belongs in subuni...
Jelmer Vernooij [Sun, 28 Mar 2010 19:45:42 +0000 (21:45 +0200)]
selftest: Remove html subunit formatter; it's too simple and really belongs in subunit or testrepository upstream.

10 years agoRemove extension from format-subunit.
Jelmer Vernooij [Sun, 28 Mar 2010 19:42:34 +0000 (21:42 +0200)]
Remove extension from format-subunit.

10 years agos3: Slightly simplify unmap_unix_group
Volker Lendecke [Sun, 14 Mar 2010 18:45:26 +0000 (19:45 +0100)]
s3: Slightly simplify unmap_unix_group

10 years agoAttempt to fix the build on AIX, that system seems to have a #define for s_type
Volker Lendecke [Sun, 28 Mar 2010 14:22:26 +0000 (16:22 +0200)]
Attempt to fix the build on AIX, that system seems to have a #define for s_type

10 years agos3: Remove unused bitmap_[allocate|free]
Volker Lendecke [Sun, 28 Mar 2010 12:32:47 +0000 (14:32 +0200)]
s3: Remove unused bitmap_[allocate|free]

10 years agos3: Use bitmap_talloc in vfs_full_audit.c
Volker Lendecke [Sun, 28 Mar 2010 12:26:53 +0000 (14:26 +0200)]
s3: Use bitmap_talloc in vfs_full_audit.c

This also simplifies the calling convention for init_bitmap() slightly

10 years agos3: Use bitmap_talloc for smb1 server tcons
Volker Lendecke [Sun, 28 Mar 2010 12:19:17 +0000 (14:19 +0200)]
s3: Use bitmap_talloc for smb1 server tcons

10 years agos3: Use bitmap_talloc in init_dptrs
Volker Lendecke [Sun, 28 Mar 2010 12:16:55 +0000 (14:16 +0200)]
s3: Use bitmap_talloc in init_dptrs

10 years agos3: Use bitmap_talloc in files.c
Volker Lendecke [Sun, 28 Mar 2010 12:14:48 +0000 (14:14 +0200)]
s3: Use bitmap_talloc in files.c

10 years agos3: Use bitmap_talloc in loadparm
Volker Lendecke [Sun, 28 Mar 2010 12:13:48 +0000 (14:13 +0200)]
s3: Use bitmap_talloc in loadparm

10 years agos3: A NULL context might be perfectly valid for bitmap_talloc
Volker Lendecke [Sun, 28 Mar 2010 12:05:55 +0000 (14:05 +0200)]
s3: A NULL context might be perfectly valid for bitmap_talloc

10 years agos3: Fix a memleak in bitmap_talloc
Volker Lendecke [Sun, 28 Mar 2010 12:03:57 +0000 (14:03 +0200)]
s3: Fix a memleak in bitmap_talloc

10 years agos3: Use TALLOC_ZERO_ARRAY in bitmap_talloc
Volker Lendecke [Sun, 28 Mar 2010 12:03:31 +0000 (14:03 +0200)]
s3: Use TALLOC_ZERO_ARRAY in bitmap_talloc

10 years agos3: Fix the memory hierarchy in bitmap_talloc
Volker Lendecke [Sun, 28 Mar 2010 12:02:47 +0000 (14:02 +0200)]
s3: Fix the memory hierarchy in bitmap_talloc

10 years agos3: Slightly simplify logic in conv_str_size
Volker Lendecke [Sun, 28 Mar 2010 11:16:58 +0000 (13:16 +0200)]
s3: Slightly simplify logic in conv_str_size

10 years agos3: Fix indentation in conv_str_size
Volker Lendecke [Sun, 28 Mar 2010 11:16:18 +0000 (13:16 +0200)]
s3: Fix indentation in conv_str_size

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 28 Mar 2010 11:13:03 +0000 (13:13 +0200)]
s3: Fix some nonempty blank lines

10 years agos3: Use tdb_transaction_start_nonblock in gencache_stabilize
Volker Lendecke [Fri, 26 Mar 2010 12:18:52 +0000 (13:18 +0100)]
s3: Use tdb_transaction_start_nonblock in gencache_stabilize

This avoids the thundering herd problem when 5000 smbds exit simultaneously
because the network went down.

10 years agoRevert "s3: Optimize gencache for smbd exit"
Volker Lendecke [Fri, 26 Mar 2010 12:15:53 +0000 (13:15 +0100)]
Revert "s3: Optimize gencache for smbd exit"

This reverts commit 5ca63676dc59e83ffd9560fdcfa26063f267f283.

That does not fully fix the problem, adding a tdb_transaction_start_nonblock to fix it.

10 years agos3: Fix typos in a debug message in vfs_init_custom
Volker Lendecke [Sun, 28 Mar 2010 12:21:49 +0000 (14:21 +0200)]
s3: Fix typos in a debug message in vfs_init_custom

10 years agos4-selftest: use CONFIG_H environment variable to find config.h
Andrew Tridgell [Sat, 27 Mar 2010 01:44:20 +0000 (12:44 +1100)]
s4-selftest: use CONFIG_H environment variable to find config.h

10 years agos4:heimdal Use correct variable to advance past -- options in kpasswd
Andrew Bartlett [Sat, 27 Mar 2010 08:13:28 +0000 (19:13 +1100)]
s4:heimdal Use correct variable to advance past -- options in kpasswd

This bug was introduced when kpasswd was migrated to a local getarg()
call, in Heimdal commit 7dd146072cd9b56d660a01f4aa20f8d81be356e8

Andrew Bartlett

10 years agos4:heimdal_build Remove forced HAVE_STRERROR_R
Andrew Bartlett [Sat, 27 Mar 2010 08:12:33 +0000 (19:12 +1100)]
s4:heimdal_build Remove forced HAVE_STRERROR_R

This just causes warnings, now upstream has a more complete fix.

10 years agos4:heimal Update generated files (cp from Heimdal)
Andrew Bartlett [Sat, 27 Mar 2010 01:24:00 +0000 (12:24 +1100)]
s4:heimal Update generated files (cp from Heimdal)

10 years agos4:testprogs Update test to match current Heimdal
Andrew Bartlett [Sat, 27 Mar 2010 01:23:21 +0000 (12:23 +1100)]
s4:testprogs Update test to match current Heimdal

10 years agos4:heimdal: import lorikeet-heimdal-201003262338 (commit f4e0dc17709829235f057e0e100d...
Andrew Bartlett [Sat, 27 Mar 2010 00:55:22 +0000 (11:55 +1100)]
s4:heimdal: import lorikeet-heimdal-201003262338 (commit f4e0dc17709829235f057e0e100d34802d3929ff)

10 years agos4:testprogs Fix kinit test for updated Heimdal
Andrew Bartlett [Sat, 27 Mar 2010 00:48:05 +0000 (11:48 +1100)]
s4:testprogs Fix kinit test for updated Heimdal

10 years agos4:heimdal New files and supporting logic for heimdal update
Andrew Bartlett [Tue, 12 Jan 2010 02:24:33 +0000 (13:24 +1100)]
s4:heimdal New files and supporting logic for heimdal update

10 years agos4:heimdal: import lorikeet-heimdal-201001120029 (commit a5e675fed7c5db8a7370b77ed0bf...
Andrew Bartlett [Tue, 12 Jan 2010 07:16:45 +0000 (18:16 +1100)]
s4:heimdal: import lorikeet-heimdal-201001120029 (commit a5e675fed7c5db8a7370b77ed0bfa724196aa84d)

10 years agoFix bug #7240 - Net usershare is not case sensitive.
Jeremy Allison [Sat, 27 Mar 2010 00:09:58 +0000 (17:09 -0700)]
Fix bug #7240 - Net usershare is not case sensitive.

Updates usershare files in a backwards compatible way.
I don't intend to back port this fix to 3.5.x as it
depends on a version upgrade in the share_info.tdb share security database.

Jeremy.

10 years agos3-selftest: set "lpq cache time = 0" in server configuration.
Günther Deschner [Fri, 26 Mar 2010 21:59:29 +0000 (22:59 +0100)]
s3-selftest: set "lpq cache time = 0" in server configuration.

This fixes currently broken spoolss tests.
(make test variant).

Guenther

10 years agos3-selftest: set "lpq cache time = 0" in server configuration.
Günther Deschner [Fri, 26 Mar 2010 21:58:42 +0000 (22:58 +0100)]
s3-selftest: set "lpq cache time = 0" in server configuration.

This fixes currently broken spoolss tests.

Guenther

10 years agos4-smbtorture: more JobInfo testing.
Günther Deschner [Fri, 26 Mar 2010 14:23:34 +0000 (15:23 +0100)]
s4-smbtorture: more JobInfo testing.

Guenther

10 years agos3 ntlm_auth: Don't malloc data that will be talloc_free()d
Kai Blin [Thu, 25 Mar 2010 21:22:56 +0000 (22:22 +0100)]
s3 ntlm_auth: Don't malloc data that will be talloc_free()d

This fixes bug #7290
Thanks to Mohan <mohann@silver-peak.com> for the bug report.

10 years agotdb: update exports and signatures files
Simo Sorce [Fri, 26 Mar 2010 19:21:15 +0000 (15:21 -0400)]
tdb: update exports and signatures files

10 years agotdb: Add a non-blocking version of tdb_transaction_start
Volker Lendecke [Fri, 26 Mar 2010 12:18:33 +0000 (13:18 +0100)]
tdb: Add a non-blocking version of tdb_transaction_start

10 years agos4:auth/credentials/credentials.c - initialise more content
Matthias Dieter Wallnöfer [Fri, 26 Mar 2010 09:08:47 +0000 (10:08 +0100)]
s4:auth/credentials/credentials.c - initialise more content

Now all data should be initialised

10 years agoRevert the part of bug fix #7233 - print fails with jobs >4GB from Win7 clients.
Jeremy Allison [Fri, 26 Mar 2010 16:32:40 +0000 (09:32 -0700)]
Revert the part of bug fix #7233 - print fails with jobs >4GB from Win7 clients.

Submitter reports print file corruption after 2GB when SMBwrite etc.
always write at EOF. Still working on the fix.

Jeremy.

10 years agos3-util_sock: Rise debug level for getpeername failed messages.
Karolin Seeger [Fri, 26 Mar 2010 14:14:35 +0000 (15:14 +0100)]
s3-util_sock: Rise debug level for getpeername failed messages.

Don't show all getpeername failed messages in debug level 0 and 1.

Karolin

Signed-off-by: Volker Lendecke <vl@samba.org>
10 years agos3-smbd: Don't close stdout if we want to log to stdout.
Andreas Schneider [Fri, 26 Mar 2010 10:17:37 +0000 (11:17 +0100)]
s3-smbd: Don't close stdout if we want to log to stdout.

10 years agos4-smbtorture: fail spoolss test on SetJob failure.
Günther Deschner [Fri, 26 Mar 2010 12:37:42 +0000 (13:37 +0100)]
s4-smbtorture: fail spoolss test on SetJob failure.

Guenther

10 years agos3-spoolss: return info for the correct printjob in _spoolss_GetJob().
Günther Deschner [Fri, 26 Mar 2010 12:36:00 +0000 (13:36 +0100)]
s3-spoolss: return info for the correct printjob in _spoolss_GetJob().

Guenther

10 years agos3-printing: avoid mixing cups backend code with nt_printing code in cups_pull_commen...
Günther Deschner [Fri, 26 Mar 2010 12:17:49 +0000 (13:17 +0100)]
s3-printing: avoid mixing cups backend code with nt_printing code in cups_pull_comment_location.

Guenther

10 years agos3-event: switch s3 to using tevent_re_initialise()
Andrew Tridgell [Fri, 26 Mar 2010 11:07:50 +0000 (22:07 +1100)]
s3-event: switch s3 to using tevent_re_initialise()

This correctly initialises the event backend, and checks for errors

(thanks to Metze for suggesting this)

10 years agos4-smbd: use tevent_re_initialise()
Andrew Tridgell [Fri, 26 Mar 2010 10:13:55 +0000 (21:13 +1100)]
s4-smbd: use tevent_re_initialise()

This fixes a crash bug on startup

10 years agotevent: added tevent_re_initialise()
Andrew Tridgell [Fri, 26 Mar 2010 10:13:27 +0000 (21:13 +1100)]
tevent: added tevent_re_initialise()

This allows us to re-initialise a tevent context without destroying
the pointer. That means that if someone keeps a long term ptr to the
event context across a fork it will still work.

This also brings the memory handling in single and standard process
models much closer together, which means less bugs that we don't find
with make test.

10 years agoutil: on FreeBSD true is in /usr/bin. Use execvp to find it
Andrew Tridgell [Fri, 26 Mar 2010 08:03:22 +0000 (19:03 +1100)]
util: on FreeBSD true is in /usr/bin. Use execvp to find it

10 years agolibutil: moved the networking defines to util_net.h
Andrew Tridgell [Fri, 26 Mar 2010 06:36:02 +0000 (17:36 +1100)]
libutil: moved the networking defines to util_net.h

These were causing thousands of warnings on solaris8

10 years agolibreplace: strerror_r() is needed by heimdal on solaris8
Andrew Tridgell [Fri, 26 Mar 2010 05:50:24 +0000 (16:50 +1100)]
libreplace: strerror_r() is needed by heimdal on solaris8

10 years agos4-drs: replmd_delete with the 3 stage deletion recycle bin
Eduardo Lima [Wed, 24 Mar 2010 19:21:15 +0000 (16:21 -0300)]
s4-drs: replmd_delete with the 3 stage deletion recycle bin

10 years agotsocket: not all systems have IPV6_V6ONLY
Andrew Tridgell [Thu, 25 Mar 2010 05:42:19 +0000 (16:42 +1100)]
tsocket: not all systems have IPV6_V6ONLY

10 years agoSecond part of bug #7288 - SMB job IDs in CUPS job names wrong.
Jeremy Allison [Fri, 26 Mar 2010 01:20:33 +0000 (18:20 -0700)]
Second part of bug #7288 - SMB job IDs in CUPS job names wrong.

Forgot to delete the overload of the smbjob bool.

Jeremy.

10 years agoFix bug #7288 - SMB job IDs in CUPS job names wrong.
Jeremy Allison [Fri, 26 Mar 2010 00:36:47 +0000 (17:36 -0700)]
Fix bug #7288 - SMB job IDs in CUPS job names wrong.

Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>.

I think this is the correct fix. It causes cups_job_submit to use
print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the
link to work).

It turns out the old print_parse_jobid() was *broken*, in that the pjob
filename was set as an absolute path - not relative to the sharename (due to it
not going through the VFS calls).

This meant that the original code doing a strncmp on the first part of the
filename would always fail - it starts with a "/", not the relative pathname of
PRINT_SPOOL_PREFIX ("smbprn.").

This fix could fix some other mysterious printing bugs - probably the ones
Guenther noticed where job control fails on non-cups backends.

Guenther PLEASE CHECK !

Jeremy.

10 years agoFix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
Jeremy Allison [Fri, 26 Mar 2010 00:09:23 +0000 (17:09 -0700)]
Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.

Ensure we don't dereference an array with an index of -1.

Jeremy.

10 years agos3: vfs_smb_traffic_analyzer.c: remove warnings from developer build
Holger Hetterich [Mon, 22 Mar 2010 14:05:33 +0000 (15:05 +0100)]
s3: vfs_smb_traffic_analyzer.c: remove warnings from developer build

This patch should remove all warnings coming up when compiling
traffic analyzer with configure.developer.

Re-activate the smb_traffic_analyzer_rmdir function by adding it's
vfs_fn_pointer to vfs_smb_traffic_analyzer_fns.

Copy the mode_t used in smb_traffic_analyzer_open to the corresponding
data structure.

10 years agos3:passdb: avoid sid_to_gid() if the sid is "domain users"
Stefan Metzmacher [Thu, 25 Mar 2010 19:59:49 +0000 (20:59 +0100)]
s3:passdb: avoid sid_to_gid() if the sid is "domain users"

If the call fails we would use the "domain users" sid anyway.

metze