samba.git
7 years agolib/crypto: add aes_cmac_128* (rfc 4493)
Stefan Metzmacher [Sat, 18 Feb 2012 10:47:31 +0000 (11:47 +0100)]
lib/crypto: add aes_cmac_128* (rfc 4493)

Thanks to Jeremy, Michael and Volker for the debugging!

metze

7 years agos3: Introduce "req" helper var in reply_lockingX_success
Volker Lendecke [Tue, 28 Feb 2012 01:47:46 +0000 (02:47 +0100)]
s3: Introduce "req" helper var in reply_lockingX_success

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 29 03:08:53 CET 2012 on sn-devel-104

7 years agos3: Fix a const warning
Volker Lendecke [Tue, 28 Feb 2012 02:14:37 +0000 (03:14 +0100)]
s3: Fix a const warning

7 years agos3: Add a test that makes a chained open break an oplock
Volker Lendecke [Tue, 28 Feb 2012 19:28:55 +0000 (20:28 +0100)]
s3: Add a test that makes a chained open break an oplock

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed Feb 29 01:13:03 CET 2012 on sn-devel-104

7 years agos3: More fix for smbd -i
Volker Lendecke [Tue, 28 Feb 2012 21:36:06 +0000 (22:36 +0100)]
s3: More fix for smbd -i

We need a full re-initialize, otherwise we don't re-init the USR1
signal handler

7 years agoFix problem reported by Tom Lee <tlee2951@gmail.com> - when calculating
Jeremy Allison [Tue, 28 Feb 2012 17:47:50 +0000 (09:47 -0800)]
Fix problem reported by Tom Lee <tlee2951@gmail.com> - when calculating
the share security mask, take priviliges into account for the connecting
user.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 28 20:21:26 CET 2012 on sn-devel-104

7 years agotorture: added samba4-ntvfs target
Andrew Tridgell [Thu, 9 Feb 2012 03:33:09 +0000 (14:33 +1100)]
torture: added samba4-ntvfs target

this will be used for the samba4 server with the ntvfs backend

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Feb 28 13:34:44 CET 2012 on sn-devel-104

7 years agos3fs: when samba is logging to stdout, ask smbd to also do so
Andrew Tridgell [Thu, 9 Feb 2012 03:07:00 +0000 (14:07 +1100)]
s3fs: when samba is logging to stdout, ask smbd to also do so

this prevents make test getting spurious errors about opening log
files in the install prefix

7 years agosmbd: detect EOF on stdin in --foreground mode
Andrew Tridgell [Wed, 30 Nov 2011 03:08:28 +0000 (14:08 +1100)]
smbd: detect EOF on stdin in --foreground mode

if EOF is detected on stdin then exit

7 years agoselftest: added a pipe on stdin in s3 child processes
Andrew Tridgell [Tue, 3 Jan 2012 05:48:29 +0000 (16:48 +1100)]
selftest: added a pipe on stdin in s3 child processes

this adds a pipe for STDIN in smbd, nmbd and winbindd when run in
selftest. This allows those processes to detect when they should exit
by looking for EOF on stdin.

7 years agos3fs: added file_server directory
Andrew Tridgell [Mon, 2 May 2011 23:35:07 +0000 (09:35 +1000)]
s3fs: added file_server directory

this contains a file server backend that forks and starts smbd

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agos4-smb_server Remove inetd-mode samba3 hook
Andrew Bartlett [Tue, 6 Sep 2011 01:34:35 +0000 (11:34 +1000)]
s4-smb_server Remove inetd-mode samba3 hook

7 years agoupgradedns: Missing rename from upgradedns to samba_upgradedns
Amitay Isaacs [Tue, 28 Feb 2012 07:26:28 +0000 (18:26 +1100)]
upgradedns: Missing rename from upgradedns to samba_upgradedns

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Feb 28 10:06:03 CET 2012 on sn-devel-104

7 years agos4:torture:smb2:durable-open: fix a silly access-after-free panic
Michael Adam [Tue, 28 Feb 2012 04:33:23 +0000 (05:33 +0100)]
s4:torture:smb2:durable-open: fix a silly access-after-free panic

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 28 08:33:44 CET 2012 on sn-devel-104

7 years agos3:torture/test_smb2: test a tree_connect during reauth
Stefan Metzmacher [Tue, 28 Feb 2012 04:11:23 +0000 (05:11 +0100)]
s3:torture/test_smb2: test a tree_connect during reauth

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Feb 28 06:58:44 CET 2012 on sn-devel-104

7 years agos3:torture/test_smb2: check directory listing during reauth
Stefan Metzmacher [Tue, 28 Feb 2012 03:24:12 +0000 (04:24 +0100)]
s3:torture/test_smb2: check directory listing during reauth

metze

7 years agos4:selftest: skip smb2.session testsuite
Michael Adam [Tue, 28 Feb 2012 00:44:10 +0000 (01:44 +0100)]
s4:selftest: skip smb2.session testsuite

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Feb 28 03:19:52 CET 2012 on sn-devel-104

7 years agos4:selftest: remove old "samba4.smb2.persistent.handle1" from knownfail - test does...
Michael Adam [Tue, 28 Feb 2012 00:27:59 +0000 (01:27 +0100)]
s4:selftest: remove old "samba4.smb2.persistent.handle1" from knownfail - test does not exist

7 years agos4:torture:smb2: add new "session" testsuite starting with a session.reconnect test
Michael Adam [Sun, 26 Feb 2012 16:53:13 +0000 (17:53 +0100)]
s4:torture:smb2: add new "session" testsuite starting with a session.reconnect test

7 years agos4:torture:smb2: add durable_open.reopen2a - variant of reopen2 with session reconnect
Michael Adam [Sun, 26 Feb 2012 01:36:13 +0000 (02:36 +0100)]
s4:torture:smb2: add durable_open.reopen2a - variant of reopen2 with session reconnect

7 years agos4:torture:smb2: add torture_smb2_connection_ext() that takes previous_session
Michael Adam [Sun, 26 Feb 2012 00:45:53 +0000 (01:45 +0100)]
s4:torture:smb2: add torture_smb2_connection_ext() that takes previous_session

7 years agos4:libcli:smb2: add a smb2_connect_ext variant of smb2_connect that takes a previous_...
Michael Adam [Sun, 26 Feb 2012 00:45:00 +0000 (01:45 +0100)]
s4:libcli:smb2: add a smb2_connect_ext variant of smb2_connect that takes a previous_session argument

7 years agos4:libcli:smb2: add a previous session argument to smb2_connect_send()
Michael Adam [Sun, 26 Feb 2012 00:43:50 +0000 (01:43 +0100)]
s4:libcli:smb2: add a previous session argument to smb2_connect_send()

7 years agos4:torture:smb2: add previous_session argument to torture_smb2_session_setup()
Michael Adam [Sun, 26 Feb 2012 00:36:51 +0000 (01:36 +0100)]
s4:torture:smb2: add previous_session argument to torture_smb2_session_setup()

To allow for doing a session reconnect

7 years agos4:libcli:smb2: add a previous session argument to smb2_session_setup_spnego()
Michael Adam [Sat, 25 Feb 2012 21:32:03 +0000 (22:32 +0100)]
s4:libcli:smb2: add a previous session argument to smb2_session_setup_spnego()

So that we can do a session reconnect.

7 years agos3:libsmb:smb2: pass previous session ID to session setup, not previous session
Michael Adam [Sun, 26 Feb 2012 16:35:28 +0000 (17:35 +0100)]
s3:libsmb:smb2: pass previous session ID to session setup, not previous session

We only need the session, and under some circumstances, it might complicate
things for the caller to have to cope with the whole structure (talloc...).

7 years agos3-winbindd: Close netlogon connection if the status returned by the NetrSamLogonEx...
Matthieu Patou [Sat, 25 Feb 2012 00:13:10 +0000 (16:13 -0800)]
s3-winbindd: Close netlogon connection if the status returned by the NetrSamLogonEx call is timeout in the pam_auth_crap path

If not the child process would hang for quite a long time up to the
moment when the connection is cleaned by the kernel (took ~ 20 minutes)
in my tests.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb 27 23:10:03 CET 2012 on sn-devel-104

7 years agos3:torture/test_smb2: show that a session is not valid for path based calls during...
Stefan Metzmacher [Mon, 27 Feb 2012 12:23:53 +0000 (13:23 +0100)]
s3:torture/test_smb2: show that a session is not valid for path based calls during reauth

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 16:29:02 CET 2012 on sn-devel-104

7 years agos3:torture/test_smb2: show that a session is valid during a multi-leg reauth
Stefan Metzmacher [Mon, 27 Feb 2012 12:18:42 +0000 (13:18 +0100)]
s3:torture/test_smb2: show that a session is valid during a multi-leg reauth

metze

7 years agos3:torture/test_smb2: fix missleading file name in reauth test
Stefan Metzmacher [Mon, 27 Feb 2012 12:26:00 +0000 (13:26 +0100)]
s3:torture/test_smb2: fix missleading file name in reauth test

metze

7 years agolibcli/smb/smb2_signing: pass down 'protocol' to smb2_signing_[sign|check]_pdu()
Stefan Metzmacher [Mon, 27 Feb 2012 08:29:53 +0000 (09:29 +0100)]
libcli/smb/smb2_signing: pass down 'protocol' to smb2_signing_[sign|check]_pdu()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Feb 27 14:26:32 CET 2012 on sn-devel-104

7 years agolibcli/smb/smb2_signing: rename session_key to signing_key
Stefan Metzmacher [Mon, 27 Feb 2012 08:27:51 +0000 (09:27 +0100)]
libcli/smb/smb2_signing: rename session_key to signing_key

metze

7 years agolibcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()
Stefan Metzmacher [Mon, 27 Feb 2012 08:24:38 +0000 (09:24 +0100)]
libcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()

metze

7 years agos4:libcli/smb2: remove unused 'session_key' from struct smb2_session
Stefan Metzmacher [Mon, 27 Feb 2012 08:20:20 +0000 (09:20 +0100)]
s4:libcli/smb2: remove unused 'session_key' from struct smb2_session

metze

7 years agos4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()
Stefan Metzmacher [Mon, 27 Feb 2012 08:16:28 +0000 (09:16 +0100)]
s4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()

metze

7 years agolibcli/smb/smbXcli: add smb2cli_session_application_key()
Stefan Metzmacher [Mon, 27 Feb 2012 08:03:54 +0000 (09:03 +0100)]
libcli/smb/smbXcli: add smb2cli_session_application_key()

metze

7 years agolibcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key
Stefan Metzmacher [Mon, 27 Feb 2012 07:48:55 +0000 (08:48 +0100)]
libcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key

The signing_key is fix across all channels and is used for session setups
on a channel binding.

Note:
 - the last session setup response is signed with the new channel signing key.
 - the reauth session setups are signed with the channel signing key.

It's also not needed to remember the main session key.

metze

7 years agolibcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()
Stefan Metzmacher [Mon, 27 Feb 2012 08:58:53 +0000 (09:58 +0100)]
libcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()

metze

7 years agos3:torture/test_smb2: remove explicit smb2_signing_check_pdu()
Stefan Metzmacher [Mon, 27 Feb 2012 08:18:33 +0000 (09:18 +0100)]
s3:torture/test_smb2: remove explicit smb2_signing_check_pdu()

smb2cli_session_set_session_key() already checks the signature
and that function really knows the signing key.

metze

7 years agos3:torture/test_smb2: a reauth doesn't update the session/signing key
Stefan Metzmacher [Mon, 27 Feb 2012 10:52:50 +0000 (11:52 +0100)]
s3:torture/test_smb2: a reauth doesn't update the session/signing key

metze

7 years agolib/crypto: fix hmac_sha256_final() prototype
Stefan Metzmacher [Wed, 22 Feb 2012 08:01:10 +0000 (09:01 +0100)]
lib/crypto: fix hmac_sha256_final() prototype

metze

7 years agodbwrap: changed log level for information about lock order
Andrew Tridgell [Thu, 9 Feb 2012 03:10:41 +0000 (14:10 +1100)]
dbwrap: changed log level for information about lock order

we were filling our logs with lock ordering debug lines

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 12:50:29 CET 2012 on sn-devel-104

7 years agoselftest: up the default log level in s3
Andrew Bartlett [Mon, 13 Feb 2012 06:47:11 +0000 (17:47 +1100)]
selftest: up the default log level in s3

This may help show more detail when our tests fail.

Andrew Bartlett

7 years agos3-selftest: avoid running LOCAL- tests twice
Andrew Bartlett [Mon, 27 Feb 2012 05:29:14 +0000 (16:29 +1100)]
s3-selftest: avoid running LOCAL- tests twice

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 09:07:59 CET 2012 on sn-devel-104

7 years agos3-param: Align lp_{max,min}protocol with lib/param names
Andrew Bartlett [Mon, 27 Feb 2012 03:24:30 +0000 (14:24 +1100)]
s3-param: Align lp_{max,min}protocol with lib/param names

This adds an alisas to ensure that both our loadparm systems know all
the names.

I would like to move to the 'server ..' name as canonical, and this
will be raised on the list.

Andrew Bartlett

7 years agotorture: don't check the NOINDEXED bit in attribute comparison
Andrew Tridgell [Thu, 9 Feb 2012 04:14:10 +0000 (15:14 +1100)]
torture: don't check the NOINDEXED bit in attribute comparison

this bit is dependent on user settings on the filesystem

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agoselftest: plugin_s4_dc can now handle kerberos properly
Andrew Bartlett [Mon, 27 Feb 2012 04:36:45 +0000 (15:36 +1100)]
selftest: plugin_s4_dc can now handle kerberos properly

7 years agos4-netlogond: Fix use of uninitialised value dns_name
Andrew Bartlett [Mon, 27 Feb 2012 05:46:22 +0000 (16:46 +1100)]
s4-netlogond: Fix use of uninitialised value dns_name

The GET_CHECK_STR macro (now unrolled) did not initialise the trusts->array[n].dns_name
when the value was not set.  New tests for our trusted domains code create
domain trusts without a DNS domain name.  Found by the autobuild flakey build detector.

Andrew Bartlett

7 years agolib/tdb2: rename tdb2.pc to tdb.pc
Rusty Russell [Mon, 27 Feb 2012 03:45:47 +0000 (14:15 +1030)]
lib/tdb2: rename tdb2.pc to tdb.pc

The library is called tdb, so the pc file must have the same name.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Mon Feb 27 06:59:58 CET 2012 on sn-devel-104

7 years agoupgradehelpers: Simplify transaction handling.
Jelmer Vernooij [Mon, 27 Feb 2012 02:50:37 +0000 (03:50 +0100)]
upgradehelpers: Simplify transaction handling.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 05:25:04 CET 2012 on sn-devel-104

7 years agosamba.xattr: Massively simplify copytree_with_xattrs.
Jelmer Vernooij [Mon, 27 Feb 2012 01:46:31 +0000 (02:46 +0100)]
samba.xattr: Massively simplify copytree_with_xattrs.

7 years agoupgradeprovision: Only backup sysvol directory if it exists.
Jelmer Vernooij [Sun, 26 Feb 2012 23:53:19 +0000 (00:53 +0100)]
upgradeprovision: Only backup sysvol directory if it exists.

This is not the case for standalone installations.

Bug: https://bugs.launchpad.net/samba/+bug/930370
Bug: https://bugzilla.samba.org/show_bug.cgi?id=8781

7 years agosamba.xattr: Split copying of tree with extended attributes out into separate module.
Jelmer Vernooij [Sun, 26 Feb 2012 23:50:00 +0000 (00:50 +0100)]
samba.xattr: Split copying of tree with extended attributes out into separate module.

7 years agos4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4
Michael Adam [Thu, 23 Feb 2012 14:49:51 +0000 (15:49 +0100)]
s4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 27 03:44:16 CET 2012 on sn-devel-104

7 years agos4:torture:smb2:durable-open: introduce new variable for the new session
Michael Adam [Thu, 23 Feb 2012 22:43:18 +0000 (23:43 +0100)]
s4:torture:smb2:durable-open: introduce new variable for the new session

This is to clarify the code.

7 years agos4:torture:smb2:durable-open: make a comment more precise in the reopen4 test
Michael Adam [Thu, 23 Feb 2012 22:25:18 +0000 (23:25 +0100)]
s4:torture:smb2:durable-open: make a comment more precise in the reopen4 test

7 years agos4:torture:smb2:durable_open: use the correct tree in the final close call
Michael Adam [Thu, 23 Feb 2012 14:35:15 +0000 (15:35 +0100)]
s4:torture:smb2:durable_open: use the correct tree in the final close call

7 years agoprovision: Write configuration without help of templates.
Jelmer Vernooij [Sun, 26 Feb 2012 22:15:48 +0000 (23:15 +0100)]
provision: Write configuration without help of templates.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 00:52:46 CET 2012 on sn-devel-104

7 years agopyparam: fix formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:43:15 +0000 (22:43 +0100)]
pyparam: fix formatting.

7 years agoprovision: Simplify make_smbconf a bit.
Jelmer Vernooij [Sun, 26 Feb 2012 21:23:27 +0000 (22:23 +0100)]
provision: Simplify make_smbconf a bit.

7 years agoprovision: Fix order for error formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:09:44 +0000 (22:09 +0100)]
provision: Fix order for error formatting.

7 years agoprovision: Raise proper error when shares are missing rather than AssertionError.
Jelmer Vernooij [Sun, 26 Feb 2012 20:47:50 +0000 (21:47 +0100)]
provision: Raise proper error when shares are missing rather than AssertionError.

7 years agoprovision: Share more code for determine_netbios_name() with samba.valid_netbios_name().
Jelmer Vernooij [Sun, 26 Feb 2012 19:51:04 +0000 (20:51 +0100)]
provision: Share more code for determine_netbios_name() with samba.valid_netbios_name().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 22:24:42 CET 2012 on sn-devel-104

7 years agoprovision/backend: Properly close all opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:45:43 +0000 (20:45 +0100)]
provision/backend: Properly close all opened files.

7 years agoprovision: Properly close opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:42:41 +0000 (20:42 +0100)]
provision: Properly close opened files.

7 years agoprovision: Reuse determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:40:26 +0000 (20:40 +0100)]
provision: Reuse determine_netbios_name.

7 years agoprovision: Add tests for determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:39:13 +0000 (20:39 +0100)]
provision: Add tests for determine_netbios_name.

7 years agoprovision: Factor out determination of new netbios name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:38:50 +0000 (20:38 +0100)]
provision: Factor out determination of new netbios name.

7 years agojoin: Don't print provision results when they're just noise.
Jelmer Vernooij [Sun, 26 Feb 2012 15:25:56 +0000 (16:25 +0100)]
join: Don't print provision results when they're just noise.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 17:56:57 CET 2012 on sn-devel-104

7 years agoprovision: Split out result reporting for backends.
Jelmer Vernooij [Sun, 26 Feb 2012 15:23:18 +0000 (16:23 +0100)]
provision: Split out result reporting for backends.

7 years agoprovision: Put adminpass details in ProvisionResult.
Jelmer Vernooij [Sun, 26 Feb 2012 15:07:21 +0000 (16:07 +0100)]
provision: Put adminpass details in ProvisionResult.

7 years agoprovision/tests: Test for phpldapadminconfig path.
Jelmer Vernooij [Sun, 26 Feb 2012 14:56:52 +0000 (15:56 +0100)]
provision/tests: Test for phpldapadminconfig path.

7 years agoprovision: Leave result reporting up to caller.
Jelmer Vernooij [Sun, 26 Feb 2012 14:44:40 +0000 (15:44 +0100)]
provision: Leave result reporting up to caller.

7 years agos3: Remove pointless parentheses
Volker Lendecke [Sun, 26 Feb 2012 08:20:38 +0000 (09:20 +0100)]
s3: Remove pointless parentheses

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 11:10:15 CET 2012 on sn-devel-104

7 years agos3-configure: Add CFLAGS_APPEND variable
Volker Lendecke [Sat, 25 Feb 2012 22:42:52 +0000 (23:42 +0100)]
s3-configure: Add CFLAGS_APPEND variable

This makes it possible to add some CFLAGS to the end of the CFLAGS list. I use
it for adding -Wno-unused-value when compiling with clang.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 01:21:49 CET 2012 on sn-devel-104

7 years agos3: Use the correct enum values
Volker Lendecke [Sat, 25 Feb 2012 20:27:28 +0000 (21:27 +0100)]
s3: Use the correct enum values

wbcIdType and id_type have the same values, but different names

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 23:46:36 CET 2012 on sn-devel-104

7 years agonsswitch: Remove a pointless if-clause
Volker Lendecke [Sat, 25 Feb 2012 20:20:21 +0000 (21:20 +0100)]
nsswitch: Remove a pointless if-clause

gr->num_gr_mem is a uint32, so it can never be < 0

7 years agolibcli: Remove a pointless check
Volker Lendecke [Sat, 25 Feb 2012 20:17:40 +0000 (21:17 +0100)]
libcli: Remove a pointless check

"n" is size_t, so it is always >=0.

7 years agoprovision: Start splitting out provision result reporting from actual provisioning.
Jelmer Vernooij [Sat, 25 Feb 2012 19:04:57 +0000 (20:04 +0100)]
provision: Start splitting out provision result reporting from actual provisioning.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 22:13:10 CET 2012 on sn-devel-104

7 years agoprovision: Properly close ldb transactions.
Jelmer Vernooij [Sat, 25 Feb 2012 16:55:52 +0000 (17:55 +0100)]
provision: Properly close ldb transactions.

7 years ago'samba-tool gpo': Properly close transaction.
Jelmer Vernooij [Sat, 25 Feb 2012 16:50:14 +0000 (17:50 +0100)]
'samba-tool gpo': Properly close transaction.

7 years agontacl: There is no 'secrets database' configuration option.
Jelmer Vernooij [Sat, 25 Feb 2012 16:36:54 +0000 (17:36 +0100)]
ntacl: There is no 'secrets database' configuration option.

7 years agoFactor out sanitize_server_role.
Jelmer Vernooij [Sat, 25 Feb 2012 16:35:41 +0000 (17:35 +0100)]
Factor out sanitize_server_role.

7 years agoPartially revert 1f0298dd1b1a939cb215e7b474178b217f8347f4
Jelmer Vernooij [Sat, 25 Feb 2012 14:56:25 +0000 (15:56 +0100)]
Partially revert 1f0298dd1b1a939cb215e7b474178b217f8347f4

It's fine to catch keyboard interrupts and other kinds of errors when it's done just for resource management, where the error is reraised later.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 17:29:34 CET 2012 on sn-devel-104

7 years agoprovision: Remove unused imports.
Jelmer Vernooij [Sat, 25 Feb 2012 14:15:51 +0000 (15:15 +0100)]
provision: Remove unused imports.

7 years agos3: Fix a typo
Volker Lendecke [Sat, 25 Feb 2012 08:40:16 +0000 (09:40 +0100)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 11:16:41 CET 2012 on sn-devel-104

7 years agos3: Fix bug 8777, sys_statvfs() wrapper support for OpenBSD/FreeBSD/DragonFly
Brad Smith [Sat, 25 Feb 2012 08:28:43 +0000 (09:28 +0100)]
s3: Fix bug 8777, sys_statvfs() wrapper support for OpenBSD/FreeBSD/DragonFly

7 years agos3-auth rename vuid_serverinfo to session_info
Andrew Bartlett [Sat, 14 Jan 2012 23:49:07 +0000 (10:49 +1100)]
s3-auth rename vuid_serverinfo to session_info

This matches the name used elsewhere in the code.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Feb 25 05:24:19 CET 2012 on sn-devel-104

7 years agos4-lib: Remove unused samdb_msg_set_value()
Ricky Nance [Fri, 10 Feb 2012 06:43:40 +0000 (00:43 -0600)]
s4-lib: Remove unused samdb_msg_set_value()

Found by callcatcher.

Ricky Nance

7 years agos4-lib: Remove unused samdb_msg_set_string()
Ricky Nance [Fri, 10 Feb 2012 06:41:44 +0000 (00:41 -0600)]
s4-lib: Remove unused samdb_msg_set_string()

Found by callcatcher.

Ricky Nance

7 years agos4-lib: Remove unused samdb_msg_set_int()
Ricky Nance [Fri, 10 Feb 2012 06:36:55 +0000 (00:36 -0600)]
s4-lib: Remove unused samdb_msg_set_int()

Found by callcatcher

Ricky Nance

7 years agoMove dptr code over to TALLOC.
Jeremy Allison [Sat, 25 Feb 2012 01:16:08 +0000 (17:16 -0800)]
Move dptr code over to TALLOC.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 25 03:50:24 CET 2012 on sn-devel-104

7 years agoMake dptr_path() and dptr_wcard() const.
Jeremy Allison [Sat, 25 Feb 2012 01:12:52 +0000 (17:12 -0800)]
Make dptr_path() and dptr_wcard() const.

7 years agoFix const warnings.
Jeremy Allison [Thu, 23 Feb 2012 22:49:02 +0000 (14:49 -0800)]
Fix const warnings.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 24 23:10:56 CET 2012 on sn-devel-104

7 years agoRemove unused function.
Jeremy Allison [Thu, 23 Feb 2012 22:46:45 +0000 (14:46 -0800)]
Remove unused function.

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

No code change, just remove a {} block left over as the else branch
from the previous commit

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Feb 24 18:07:48 CET 2012 on sn-devel-104

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

first_request won't be true anymore, we always splice fully existing
records in smbd

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

With the last commit, bytes_padding is not set anymore

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

bytes_alignment used to be used in libsmb, which uses different code
now

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

We use it in smbd/process.c only now. This only splices in finished
buffers, both callers used the same arguments. Pull that into the
routine itself.