samba.git
11 years agoReturn existsing cache_tree if it has already been initialized.
Michael Adam [Thu, 3 Jan 2008 11:07:02 +0000 (12:07 +0100)]
Return existsing cache_tree if it has already been initialized.

So reghook_cache_init() does not leak memory when called more
than once.
Also, fix the return value while we are at it.

Michael
(This used to be commit 25f571f40a630bff5a47bba6b01e42d4e0ffed66)

11 years agoRename libnet_smbconf_reg_setvalue_internal() to libnet_smbconf_reg_set_value().
Michael Adam [Thu, 3 Jan 2008 10:35:21 +0000 (11:35 +0100)]
Rename libnet_smbconf_reg_setvalue_internal() to libnet_smbconf_reg_set_value().

Michael
(This used to be commit 3fc3fee88afd9e8b6232afc140a07090b4215c23)

11 years agoFix a comment.
Michael Adam [Thu, 3 Jan 2008 10:33:17 +0000 (11:33 +0100)]
Fix a comment.

Michael
(This used to be commit 2d0c7fe44f075205db1713ef2d69006f7192c490)

11 years agoRename libnet_smbconf_reg_createkey_internal to libnet_smbconf_reg_create_service_key.
Michael Adam [Thu, 3 Jan 2008 10:32:00 +0000 (11:32 +0100)]
Rename libnet_smbconf_reg_createkey_internal to libnet_smbconf_reg_create_service_key.

Michael
(This used to be commit 08056a2c8160a44d27744467da467faea9ba0686)

11 years agoAdd libnet_conf API function libnet_smbconf_create_share().
Michael Adam [Thu, 3 Jan 2008 10:30:14 +0000 (11:30 +0100)]
Add libnet_conf API function libnet_smbconf_create_share().

And make libnet_smbconf_setparm() return error if the share
does not already exist. Adapt net_conf_addshare to this new
situation.

Michael
(This used to be commit de349bd26db3341815f6d8f6c18a5ca1fd664dca)

11 years agoRemove unused vars.
Günther Deschner [Thu, 3 Jan 2008 09:39:19 +0000 (10:39 +0100)]
Remove unused vars.

Guenther
(This used to be commit ff3f0006d167a9bca85919bf6115d73413554909)

11 years agoTrivial simplification
Volker Lendecke [Thu, 3 Jan 2008 09:24:45 +0000 (10:24 +0100)]
Trivial simplification

... things you come across when you review code
(This used to be commit 1e006bcfb15d44ecb81b6994c588d30d87b48033)

11 years agoAdd comments
Volker Lendecke [Thu, 3 Jan 2008 09:24:11 +0000 (10:24 +0100)]
Add comments

Jeremy was able to use this correctly without comments, so the code can't be
*that* bad :-)
(This used to be commit 6f22f7c13fd08ee772ac3aa593d2f4b37eb2cbee)

11 years agoFix for bug #5163 from Laurent Pinchart <pinchart@skynet.be>
Jeremy Allison [Thu, 3 Jan 2008 02:20:23 +0000 (18:20 -0800)]
Fix for bug #5163 from Laurent Pinchart <pinchart@skynet.be>
Failure to change password in ldap is mapped to NT_STATUS_UNSUCCESSFUL unconditionally.
Jeremy.
(This used to be commit 9369d6e907a49da1fbf2a5690118412b8d1a0383)

11 years agoConvert the little caches in util_sock.c to use
Jeremy Allison [Thu, 3 Jan 2008 01:37:39 +0000 (17:37 -0800)]
Convert the little caches in util_sock.c to use
the singleton memcache. Vl please check (passes
make valgrindtest).
Jeremy.
(This used to be commit a4d613cde86caf5782c4bfc47122d6ba807990ac)

11 years agoDon't leak: Use a temporary context for the admin token and free it.
Michael Adam [Thu, 3 Jan 2008 00:26:31 +0000 (01:26 +0100)]
Don't leak: Use a temporary context for the admin token and free it.

Michael
(This used to be commit 9d7502115e0f6cdfd27943d52f0de04447582b92)

11 years agoUse libnet_smbconf_reg_open_path() in libnet_smbconf_drop().
Michael Adam [Thu, 3 Jan 2008 00:12:23 +0000 (01:12 +0100)]
Use libnet_smbconf_reg_open_path() in libnet_smbconf_drop().

Replaces creation of token and direct use of reg_open_path.

Michael
(This used to be commit 7e407e18be0761e7004acfbd2376c3a435922c25)

11 years agoAbstract opening of registry path out of libnet_smbconf_reg_open_service_key().
Michael Adam [Thu, 3 Jan 2008 00:07:30 +0000 (01:07 +0100)]
Abstract opening of registry path out of libnet_smbconf_reg_open_service_key().

Creates new function libnet_smbconf_reg_open_path().
Use libnet_smbconf_reg_open_path() directly in libnet_smbconf_reg_open_basekey().
Return error in libnet_smbconf_reg_open_service_key() when NULL
servicename is given.

Michael
(This used to be commit 1e46b479638c54e8bd7ba939bc7aba18a27b5155)

11 years agoAdd debug output in error path.
Michael Adam [Wed, 2 Jan 2008 23:53:34 +0000 (00:53 +0100)]
Add debug output in error path.

Michael
(This used to be commit a58ccbc6d70613f7572bc80621935d81f9e290e3)

11 years agoFix setting of error code in error path.
Michael Adam [Wed, 2 Jan 2008 23:52:55 +0000 (00:52 +0100)]
Fix setting of error code in error path.

Michael
(This used to be commit 8a7954a9ae13df527ccedb1004ee4f87d506ce5b)

11 years agoUse a better parameter name.
Michael Adam [Wed, 2 Jan 2008 23:51:36 +0000 (00:51 +0100)]
Use a better parameter name.

Michael
(This used to be commit 3972deb90c4b645fb4d207a7e132cd7e180e78bb)

11 years agoRename libnet_smbconf_reg_open_path() to libnet_smbconf_reg_open_service_key().
Michael Adam [Wed, 2 Jan 2008 23:49:53 +0000 (00:49 +0100)]
Rename libnet_smbconf_reg_open_path() to libnet_smbconf_reg_open_service_key().

Michael
(This used to be commit d95b4935d3a97ca9c4b7990bbcf4e85c81c79516)

11 years agoHey, it is 2008 now.
Michael Adam [Wed, 2 Jan 2008 23:44:47 +0000 (00:44 +0100)]
Hey, it is 2008 now.

:-)

Michael
(This used to be commit a1d3f60ea753a158447bb0208441453b76a0f3b9)

11 years agoChoose a more apropriate parameter name.
Michael Adam [Wed, 2 Jan 2008 23:43:29 +0000 (00:43 +0100)]
Choose a more apropriate parameter name.

Michael
(This used to be commit 39a73b6291fd028d44fc2712afa76abf1fcff9cb)

11 years agoRename libnet_smbconf_reg_open_basepath() to libnet_smbconf_reg_open_basekey().
Michael Adam [Wed, 2 Jan 2008 23:35:09 +0000 (00:35 +0100)]
Rename libnet_smbconf_reg_open_basepath() to libnet_smbconf_reg_open_basekey().

Michael
(This used to be commit 9e953a94e9b3a060769938ef6af25623e446c180)

11 years agoFix some C++ warnings (patch was Volker's) - implicit case from void* to char*
Gerald (Jerry) Carter [Wed, 2 Jan 2008 23:34:41 +0000 (17:34 -0600)]
Fix some C++ warnings (patch was Volker's) - implicit case from void* to char*
(This used to be commit 518168410c49ac25085714c73e76dcf358fc4b68)

11 years agoMerge branch 'work/v3-2-test' into v3-2-test
Gerald (Jerry) Carter [Wed, 2 Jan 2008 23:15:10 +0000 (17:15 -0600)]
Merge branch 'work/v3-2-test' into v3-2-test
(This used to be commit 761858312b3470ff2acc2980882bad534275c552)

11 years agouse C99 bool return types (true & false).
Gerald (Jerry) Carter [Wed, 2 Jan 2008 20:54:25 +0000 (14:54 -0600)]
use C99 bool return types (true & false).
(This used to be commit f22c9d6296c754d472e8eab51caa058f55ef370e)

11 years agoMake sure that wbcLookupSid() and wbcLookupRids() use talloc()'d memory.
Gerald (Jerry) Carter [Wed, 2 Jan 2008 20:50:59 +0000 (14:50 -0600)]
Make sure that wbcLookupSid() and wbcLookupRids() use talloc()'d memory.

Follows existing convention that all returned memory should be freed with
wbcFreeMemory() and not directly with free().  Noticed by Volker.  Txs.
(This used to be commit 39c2059f66ee9eb471a503b9c776807b91c2a8f8)

11 years agoAttempt to fix bug #3617. Mix of patches from Volker and
Jeremy Allison [Wed, 2 Jan 2008 19:56:07 +0000 (11:56 -0800)]
Attempt to fix bug #3617. Mix of patches from Volker and
myself. Use standard dlinklist macros.
Jeremy.
(This used to be commit 1b06ee69f6b737c1d6e7b29f8ae9621e6eb07d27)

11 years agoUse the proper boolean constants.
Michael Adam [Wed, 2 Jan 2008 16:08:28 +0000 (17:08 +0100)]
Use the proper boolean constants.

Michael
(This used to be commit f731fee408a809b6dc266d45e41f37e63bf4e48d)

11 years agoFix libnetapi (resolve dependency on libwbclient).
Günther Deschner [Wed, 2 Jan 2008 12:50:31 +0000 (13:50 +0100)]
Fix libnetapi (resolve dependency on libwbclient).

Guenther
(This used to be commit fa669b307c5191f1f8921e863e88c1e9ff692557)

11 years agoFix libsmbclient (resolve dependency on libwbclient).
Günther Deschner [Wed, 2 Jan 2008 12:50:13 +0000 (13:50 +0100)]
Fix libsmbclient (resolve dependency on libwbclient).

Guenther
(This used to be commit ef17dc7bda98a8e4149e98fcfb99fe729edbec1f)

11 years agoMake libsmbsharemodes.so work again (fix unresolved tdb symbols).
Günther Deschner [Wed, 2 Jan 2008 12:48:54 +0000 (13:48 +0100)]
Make libsmbsharemodes.so work again (fix unresolved tdb symbols).

Guenther
(This used to be commit 3c6ed0321606f0bcfc3b5edc492d69b0e2f602cb)

11 years agoConvert call_trans2open to create_file()
Volker Lendecke [Sat, 8 Dec 2007 11:29:09 +0000 (12:29 +0100)]
Convert call_trans2open to create_file()
(This used to be commit 22138572bd2b9ae379b01098566e38e132653968)

11 years agoConvert reply_mknew to create_file
Volker Lendecke [Sat, 8 Dec 2007 11:05:41 +0000 (12:05 +0100)]
Convert reply_mknew to create_file
(This used to be commit 1b1cea9ef04a85a2fdd3c8574f7c4db559b7d9b6)

11 years agoConvert reply_open_and_X to create_file
Volker Lendecke [Fri, 7 Dec 2007 13:23:10 +0000 (14:23 +0100)]
Convert reply_open_and_X to create_file
(This used to be commit fa09b9ab26657af9bd6dcf3fcc7311d5983a591d)

11 years agoConvert reply_open to create_file
Volker Lendecke [Fri, 7 Dec 2007 13:19:07 +0000 (14:19 +0100)]
Convert reply_open to create_file
(This used to be commit 209c696ab8490564ec9e30f6f07b9c72af3ed2e1)

11 years agoAdd test_shlibs to Makefile.
Günther Deschner [Wed, 2 Jan 2008 12:22:19 +0000 (13:22 +0100)]
Add test_shlibs to Makefile.

Guenther
(This used to be commit 5f5051911c25772c7fb4ff41fca0aafae371ae4f)

11 years agoHappy new year !
Günther Deschner [Wed, 2 Jan 2008 11:55:53 +0000 (12:55 +0100)]
Happy new year !

Guenther
(This used to be commit 9a58cd57953d6aead14789daa47a3badef19496d)

11 years agoUse NULL instead of 0
Volker Lendecke [Tue, 1 Jan 2008 11:55:29 +0000 (12:55 +0100)]
Use NULL instead of 0

"struct security_descriptor" has pointers, not integers inside
(This used to be commit 13158014e3b05e44eea897fbcf470957301c5c97)

11 years agoMake the last two helper functions in libnet_conf.c static.
Michael Adam [Mon, 31 Dec 2007 02:57:45 +0000 (03:57 +0100)]
Make the last two helper functions in libnet_conf.c static.

Now the registry backend is completely hidden from the API.

Michael
(This used to be commit 5608c398ad9a0d05d651905a81dd92b7a0e120ff)

11 years agoMake grouping in if statement more explicit.
Michael Adam [Mon, 31 Dec 2007 02:55:22 +0000 (03:55 +0100)]
Make grouping in if statement more explicit.

Michael
(This used to be commit a1bb47695a7fb21af239aa9d02537d3de2fea325)

11 years agoFix a permissions error in reg_deletekey_recursive().
Michael Adam [Mon, 31 Dec 2007 02:25:54 +0000 (03:25 +0100)]
Fix a permissions error in reg_deletekey_recursive().

Michael
(This used to be commit 4a56d3d7075bd8bbd5e139c9433789ab29f6a70e)

11 years agoChange net_conf_import() to only use libnet_conf API functions.
Michael Adam [Mon, 31 Dec 2007 02:02:39 +0000 (03:02 +0100)]
Change net_conf_import() to only use libnet_conf API functions.

More precisely, only import_process_service() is changed.
This removes all references to registry code from net_conf.c.

net_conf_import() is currently -- like net_conf_addshare() -- also
considered a high-level add-on, not an API function.

Michael
(This used to be commit b4dca117c09ddb9c8e7eea25c6cde3fbef8c692b)

11 years agoRewrite net_conf_addshare() to only use libnet_conf API functions.
Michael Adam [Mon, 31 Dec 2007 00:56:18 +0000 (01:56 +0100)]
Rewrite net_conf_addshare() to only use libnet_conf API functions.

Also exit on error if the share already exists.

net_conf_addshare() is considered a high level utility function.
It should not be an libnet_conf API function in itself since it is
kind of arbitrary.

Michael
(This used to be commit af5218f1505321236be52df10ebfe8f42b99573d)

11 years agoRename libnet_smbconf_key_exists() to libnet_smbconf_share_exists()
Michael Adam [Mon, 31 Dec 2007 00:14:44 +0000 (01:14 +0100)]
Rename libnet_smbconf_key_exists() to libnet_smbconf_share_exists()

and move it to the api section of libnet_conf.c

Michael
(This used to be commit 9b5d8f4d95ebfd47831906019e11227aecc83aa1)

11 years agoRemove an unused variable.
Michael Adam [Sun, 30 Dec 2007 21:30:21 +0000 (22:30 +0100)]
Remove an unused variable.

Michael
(This used to be commit 332be113a775adce8108a8003682019ae7f5bc21)

11 years agoRemove an unused variable.
Michael Adam [Sun, 30 Dec 2007 21:29:54 +0000 (22:29 +0100)]
Remove an unused variable.

Michael
(This used to be commit 7bac935b65565099c0dfb34cab0dec73dd5fb479)

11 years agoRemove all d_fprintf-s from libnet_conf.c
Michael Adam [Sun, 30 Dec 2007 21:27:45 +0000 (22:27 +0100)]
Remove all d_fprintf-s from libnet_conf.c

Replacing them buy DEBUG statements and filling in
d_fprintfs in callers in net_conf.c.

Michael
(This used to be commit 1f0122d8d4ec0f67eaedd5df7383c1b45f37290f)

11 years agoAs the encryption is stream based there's no reason
Jeremy Allison [Sun, 30 Dec 2007 21:10:29 +0000 (13:10 -0800)]
As the encryption is stream based there's no reason
oplock breaks can't be encrypted. If we have multiple
contexts I should probably attach them to the connection
struct, but for now use the global context number.
Jeremy.
(This used to be commit 5b4b335ed0d1dc738f1f099e5c638361f3aede07)

11 years agoFix error message.
Jeremy Allison [Sun, 30 Dec 2007 06:42:20 +0000 (22:42 -0800)]
Fix error message.
Jeremy.
(This used to be commit a0494b115b644c1c4afa50442c46a54779687571)

11 years agoAdded -e, --encrypt option to smbclient that immediately
Jeremy Allison [Sun, 30 Dec 2007 06:39:52 +0000 (22:39 -0800)]
Added -e, --encrypt option to smbclient that immediately
forces encrypted smb after initial connect. Will document
for 3.2 official release.
Jeremy.
(This used to be commit f02bf419282419950471deae74c4a6fe1543ed26)

11 years agoAllow encryption context setup on IPC$.
Jeremy Allison [Sun, 30 Dec 2007 06:36:49 +0000 (22:36 -0800)]
Allow encryption context setup on IPC$.
Jeremy.
(This used to be commit 5d424cb3060af89bde50bc7fe2989e3c1b8e91b2)

11 years agoMake pdb_tdb honour a private dir overridden in smb.conf.
Michael Adam [Sun, 30 Dec 2007 02:12:11 +0000 (03:12 +0100)]
Make pdb_tdb honour a private dir overridden in smb.conf.

One lp_private_dir() has to be used instead of get_dyn_PRIVATE_DIR()
to determine the location of the passdb.tdb.

I noticed this when running make test as a "normal user" from a
build, where I had done "make install" as root before, and so
the passdb.tdb could not be accessed during the startup phase
"CREATE TEST ENVIRONMENT IN ./st ..." in selftest.sh.

Michael
(This used to be commit 1f96389afa7250af7393489fb538b8aed93d815c)

11 years agoMake libnet_smbconf_reg_open_path() static.
Michael Adam [Sat, 29 Dec 2007 21:29:33 +0000 (22:29 +0100)]
Make libnet_smbconf_reg_open_path() static.

Michael
(This used to be commit 6447bae71c99407485307dd508603c73d5bb9823)

11 years agoMake libnet_smbconf_reg_open_basepath() static.
Michael Adam [Sat, 29 Dec 2007 21:29:00 +0000 (22:29 +0100)]
Make libnet_smbconf_reg_open_basepath() static.

Michael
(This used to be commit 8e87dd79ba4e3aeceb26c7b4e131053172f077cd)

11 years agoRemove list_values() from net_conf.c - it is not needed any more.
Michael Adam [Sat, 29 Dec 2007 21:11:09 +0000 (22:11 +0100)]
Remove list_values() from net_conf.c - it is not needed any more.

Also make libnet.c:libnet_smbconf_format_registry_value() static.
(There are nor more external callers.)

Michael
(This used to be commit ac7baa17e89d2363b5b3db85de9c842b596dea25)

11 years agoUse libnet_smbconf_get_config() in net_conf_list().
Michael Adam [Sat, 29 Dec 2007 21:09:51 +0000 (22:09 +0100)]
Use libnet_smbconf_get_config() in net_conf_list().

This leaves only output logic in net_conf_list().

Michael
(This used to be commit 95d9981d59fe69ee1ed98f21475bd1ba72930c1b)

11 years agoAdd a function libnet_smbconf_get_config() to libnet_conf.c
Michael Adam [Sat, 29 Dec 2007 21:08:11 +0000 (22:08 +0100)]
Add a function libnet_smbconf_get_config() to libnet_conf.c

This gets the whole config as a set of lists (of share names
and corresponding lists of parameter names and values). The function
is an aggregate of libnet_smbconf_get_share_names() and
libnet_smbconf_getshare().

Michael
(This used to be commit 94e97a72548a7f76a5273346d472e3ba5b24795a)

11 years agoInclude libnet/libnet.h in libnet_conf.c to have prototypes available.
Michael Adam [Sat, 29 Dec 2007 20:59:28 +0000 (21:59 +0100)]
Include libnet/libnet.h in libnet_conf.c to have prototypes available.

Michael
(This used to be commit 4842438c396b93007fc4f4dded437567e562a2dc)

11 years agoUse correct size value for linearize call.
Jeremy Allison [Sat, 29 Dec 2007 22:43:32 +0000 (14:43 -0800)]
Use correct size value for linearize call.
Jeremy.
(This used to be commit a5df44f5b7887d10c1e1a0b7a3dd05bcf31015e1)

11 years agoRemove tiny code duplication
Volker Lendecke [Sat, 29 Dec 2007 22:00:49 +0000 (23:00 +0100)]
Remove tiny code duplication

ndr_size_security_descriptor does the same as sec_desc_size
(This used to be commit bc3bd7a8e7c6e9e27acb195c86abb92c0f53112f)

11 years agoMake [un]marshall_sec_desc use librpc/ndr
Volker Lendecke [Sat, 29 Dec 2007 21:54:51 +0000 (22:54 +0100)]
Make [un]marshall_sec_desc use librpc/ndr
(This used to be commit 387936ec3952f88d46df2d4943bbc4e408ad2bb5)

11 years agoMake use of [un]marshall_sec_desc
Volker Lendecke [Sat, 29 Dec 2007 21:47:03 +0000 (22:47 +0100)]
Make use of [un]marshall_sec_desc
(This used to be commit 54576733d6c0511dc7379f964b1cb035913b7c8d)

11 years agoRemove tiny code duplication
Volker Lendecke [Sat, 29 Dec 2007 21:16:31 +0000 (22:16 +0100)]
Remove tiny code duplication

sid_size did the same as ndr_size_dom_sid
(This used to be commit 8aec5d09ba023413bd8ecbdfbc7d23904df94389)

11 years agoFix a panic
Volker Lendecke [Sat, 29 Dec 2007 20:41:23 +0000 (21:41 +0100)]
Fix a panic

get_root_nt_token asks for "struct nt_user_token". talloc_get_type is not smart
enough to see that this is the same as NT_USER_TOKEN... :-)
(This used to be commit 22a98bf7b81fb89dce1f32ef65cfe6caaba985b3)

11 years agoApply some const
Volker Lendecke [Thu, 27 Dec 2007 19:00:13 +0000 (20:00 +0100)]
Apply some const
(This used to be commit 241b72141e3d9e31e30977517f871a97d74bbf7d)

11 years agoReturn NULL (instead of unchanged) for no shares/parameters defined.
Michael Adam [Sat, 29 Dec 2007 16:06:49 +0000 (17:06 +0100)]
Return NULL (instead of unchanged) for no shares/parameters defined.

Michael
(This used to be commit bfe3d1462f52d2849611fc58ad70fa08b4917077)

11 years agoDont return count - 1 but count from libnet_smbconf_reg_get_values().
Michael Adam [Sat, 29 Dec 2007 16:02:27 +0000 (17:02 +0100)]
Dont return count - 1 but count from libnet_smbconf_reg_get_values().

Michael
(This used to be commit ded60dec7d75db7df485a159fb6bf628d8e24805)

11 years agoMake sure libnet_smbconf_get_share_names() always lists "global" first.
Michael Adam [Sat, 29 Dec 2007 13:38:42 +0000 (14:38 +0100)]
Make sure libnet_smbconf_get_share_names() always lists "global" first.

And don't return count-1 but count.

Michael
(This used to be commit b7cb9b78231512dc4a88c307048d7fb5334fa319)

11 years agoMove talloc-appending a string to an array to its own helper function
Michael Adam [Sat, 29 Dec 2007 13:32:13 +0000 (14:32 +0100)]
Move talloc-appending a string to an array to its own helper function

libnet_smbconf_add_string_to_array().

Michael
(This used to be commit f4a4c1b26a03cd0f334e00912d32f15c73474ff1)

11 years agoFix uninitalized variables
Volker Lendecke [Sat, 29 Dec 2007 15:35:51 +0000 (16:35 +0100)]
Fix uninitalized variables
(This used to be commit 2322fe718728178990fdc3696b84f5de7ae7701b)

11 years agoAttempt to fix the AIX make test failures
Volker Lendecke [Sat, 29 Dec 2007 12:10:25 +0000 (13:10 +0100)]
Attempt to fix the AIX make test failures

For some reason AIX does not return the sender address in the AF_UNIX recvfrom.
So the faked netbios name lookup does not work with socket wrapper, nmbd can't
know where to send the reply. This patch works around this by telling smbclient
explicitly where to connect.

If there's any AIX experts listening -- how do I get the sender address from
AF_UNIX recvfrom?

Volker
(This used to be commit 8ba3b8cf7aca657ad8426981d810c36ee6a34a2f)

11 years agoFix a const warning.
Michael Adam [Sat, 29 Dec 2007 12:02:22 +0000 (13:02 +0100)]
Fix a const warning.

Michael
(This used to be commit e276e48177f890531ee8b4024c90352f284d4608)

11 years agoRename libnet_smbconf_getshares() to libnet_smbconf_get_share_names().
Michael Adam [Sat, 29 Dec 2007 11:55:42 +0000 (12:55 +0100)]
Rename libnet_smbconf_getshares() to libnet_smbconf_get_share_names().

Michael
(This used to be commit 9b3b9aa7e1044719a5112b9e5446e6fbdd7cecf9)

11 years agoAdd a comment header for libnet_smbconf_getshares().
Michael Adam [Sat, 29 Dec 2007 11:53:19 +0000 (12:53 +0100)]
Add a comment header for libnet_smbconf_getshares().

Michael
(This used to be commit 7b51535f2f76b5c3c18620ffd9ac64505357e6db)

11 years agoMove functionality of net_conf_listshares() to libnet_conf.c
Michael Adam [Sat, 29 Dec 2007 11:52:09 +0000 (12:52 +0100)]
Move functionality of net_conf_listshares() to libnet_conf.c

into new function libnet_smbconf_getshares().

Michael
(This used to be commit 306c7e4d9cecac4c2c0ea1172bd585c3c17d4541)

11 years agoMove functionality of net_conf_showshare() to libnet_conf.c
Michael Adam [Sat, 29 Dec 2007 02:38:13 +0000 (03:38 +0100)]
Move functionality of net_conf_showshare() to libnet_conf.c

The functionality is moved to a new function libnet_smbconf_getshare().
This returns the parameters of the given share as two lists: the list
of parameter names and the list of matching (formatted) parameter values.

The retrieval and formatting is done in a new internal helper function
libnet_smbconf_reg_get_values() that is to become the replacement for
list_values() from net_conf.c once functionality of net_conf_list() has
been moved to libnet_conf, too.

Michael
(This used to be commit 198232bd525cfac933b4885e6b330ebf4ac2c8ae)

11 years agopassdb.tdb is located in the private directory
Volker Lendecke [Mon, 24 Dec 2007 13:12:54 +0000 (14:12 +0100)]
passdb.tdb is located in the private directory

Jerry, as part of d6cdbfd87 the default location of passdb.tdb has changed from
the private directory to the state directory. I think because passdb.tdb holds
the password hashes, it is reasonable to keep this next to the smbpasswd file.

Please review and potentially push.

Thanks,

Volker
(This used to be commit c9c7607c402c0a9df9796c767b689d207d67d8e4)

11 years agoMake the main net_conf functions static in net_conf.c
Michael Adam [Sat, 29 Dec 2007 01:27:20 +0000 (02:27 +0100)]
Make the main net_conf functions static in net_conf.c

Michael
(This used to be commit dd6e09a65e67a9a16b35b078ebfb41da09926029)

11 years agoAdd a couple of comment headers to the main libnet_conf functions.
Michael Adam [Sat, 29 Dec 2007 01:26:33 +0000 (02:26 +0100)]
Add a couple of comment headers to the main libnet_conf functions.

Michael
(This used to be commit e9694ae20e1da1d8c1cbb252e630815b561647dd)

11 years agoAdd a comment header for libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 01:18:44 +0000 (02:18 +0100)]
Add a comment header for libnet_smbconf_format_registry_value().

Michael
(This used to be commit 80e73407ea326cc68cd8728845c7a1c0907e2201)

11 years agoHandle NULL talloc context in libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 01:16:38 +0000 (02:16 +0100)]
Handle NULL talloc context in libnet_smbconf_format_registry_value().

Maybe we should generate a new context instead of returning NULL?

Michael
(This used to be commit d7aaec713e17f93eed5177f0c3468deb625402a8)

11 years agoHide the registry backend from libnet_smbconf_getparm().
Michael Adam [Sat, 29 Dec 2007 01:12:33 +0000 (02:12 +0100)]
Hide the registry backend from libnet_smbconf_getparm().

Return a formatted string of the value instead.

Michael
(This used to be commit 7d0ec5bae155cda6620db04dcb7bd43db59241aa)

11 years agoRename format_value() to libnet_smbconf_format_registry_value().
Michael Adam [Sat, 29 Dec 2007 00:17:39 +0000 (01:17 +0100)]
Rename format_value() to libnet_smbconf_format_registry_value().

Michael
(This used to be commit 95d5dd9bb0546181cd499e6deabff562166412e3)

11 years agoMove format_value() to libnet_conf.c.
Michael Adam [Fri, 28 Dec 2007 23:05:23 +0000 (00:05 +0100)]
Move format_value() to libnet_conf.c.

Michael
(This used to be commit 3422a5048ad4b7f789ec233356885d78dbdacf9a)

11 years agoConvert get_root_nt_token to memcache
Volker Lendecke [Fri, 28 Dec 2007 16:24:39 +0000 (17:24 +0100)]
Convert get_root_nt_token to memcache
(This used to be commit fada689893314bed2fc78588b3fd9b144f4c808a)

11 years agoRemove a global
Volker Lendecke [Fri, 28 Dec 2007 16:16:35 +0000 (17:16 +0100)]
Remove a global
(This used to be commit 515f6a8cff7e28b0e98136f3214ef52512cfaf37)

11 years agodon't store cache_readonly in gencache
Volker Lendecke [Fri, 28 Dec 2007 16:09:57 +0000 (17:09 +0100)]
don't store cache_readonly in gencache

tdb won't allow us to write anyway
(This used to be commit 069cd6d63a61065be7926230235e198c456d38ae)

11 years agoRemove static zeros
Volker Lendecke [Fri, 28 Dec 2007 16:02:34 +0000 (17:02 +0100)]
Remove static zeros
(This used to be commit dbcc213710a9af31b6094d4741a6f68f573dcdad)

11 years agoRemove a static array
Volker Lendecke [Fri, 28 Dec 2007 16:02:07 +0000 (17:02 +0100)]
Remove a static array

This might be worth it, mangle_hash is hardly used these days
(This used to be commit 44775ea38bc320ac8e2208769a8cde2c6f44f640)

11 years agoConvert csamuser to memcache
Volker Lendecke [Fri, 28 Dec 2007 12:13:29 +0000 (13:13 +0100)]
Convert csamuser to memcache
(This used to be commit 476d3abf9c6142d99822212141fc3d843aca4798)

11 years agobin/vlp needs a dependency on @LIBWBCLIENT_SHARED@
Volker Lendecke [Sat, 22 Dec 2007 11:02:33 +0000 (12:02 +0100)]
bin/vlp needs a dependency on @LIBWBCLIENT_SHARED@

This failed to link if you compile with -j.
(This used to be commit fed8f2abd704d1993146ad462d81f69367537cfb)

11 years agoImprove error messages of 'net rpc user [add|delete]' commands.
Karolin Seeger [Thu, 27 Dec 2007 13:08:40 +0000 (14:08 +0100)]
Improve error messages of 'net rpc user [add|delete]' commands.

Karolin
(This used to be commit 4260c79bf7687bd2ebcc4ca5e0a5f020a759c1fb)

11 years agoEnsure we turn off POSIX large read/write if encryption
Jeremy Allison [Fri, 28 Dec 2007 08:02:13 +0000 (00:02 -0800)]
Ensure we turn off POSIX large read/write if encryption
is mandatory or signing is on.
Jeremy.
(This used to be commit 5088b704791be2f36641fa0ec59dff7f289ae868)

11 years agoAdd the capability to set "smb encrypt = required"
Jeremy Allison [Fri, 28 Dec 2007 07:51:03 +0000 (23:51 -0800)]
Add the capability to set "smb encrypt = required"
on a share (or global) and have the server reply with
ACCESS_DENIED for all non-encrypted traffic (except
that used to query encryption requirements and set
encryption state).
Jeremy.
(This used to be commit d241bfa57729bb934ada6beabf842a2ca7b4f8a2)

11 years agoFix setting the initial permission bits
Volker Lendecke [Thu, 27 Dec 2007 20:31:08 +0000 (21:31 +0100)]
Fix setting the initial permission bits

This fixes a make test failure on Solaris. When creating a new file,
file_set_dosmode() called from open_file_ntcreate calculates a new permission
mask, very likely different from what had been calculated in
open_file_ntcreate. Further down we overwrote the newly calculated value with
SMB_FCHMOD_ACL, ignoring what file_set_dosmode had calculated.

Why did Linux not see this? fchmod_acl on a newly created file without acls
would not retrieve an acl at all, whereas under Solaris acl(2) returns
something even for files with just posix permissions returns something.

Jeremy, given that we have very similar code in 3.0.28 this might also explain
some of the bug reports that people have concerning ACLs on new files.

Volker

P.S: This one took a while to find...
(This used to be commit 2135dfe91bf1ae114a18c15286b535662200677d)

11 years agoAdd "smb encrypt" parameter. Can be set to "no, yes, required".
Jeremy Allison [Fri, 28 Dec 2007 00:54:07 +0000 (16:54 -0800)]
Add "smb encrypt" parameter. Can be set to "no, yes, required".
Currently if set required this is not enforced. I'll be adding
that soon.
Jeremy.
(This used to be commit df7e447623ac03d81bec384f5cfe83c3976cf7b2)

11 years agoFix the non-gcc branch of "likely"
Volker Lendecke [Thu, 27 Dec 2007 23:12:14 +0000 (00:12 +0100)]
Fix the non-gcc branch of "likely"
(This used to be commit 1e07368b5f96e4ada622682e38d260eb0c6185f2)

11 years agoRemove a silly static
Volker Lendecke [Thu, 27 Dec 2007 20:30:15 +0000 (21:30 +0100)]
Remove a silly static
(This used to be commit ef75dcc9ffda85d77c8f22d0db702efbf8e642ed)

11 years agoFix the build
Volker Lendecke [Thu, 27 Dec 2007 18:56:44 +0000 (19:56 +0100)]
Fix the build
(This used to be commit 7fb858b350856d626fed6f062029fcf09b8251e2)

11 years agoWrap the DEBUG checks in a "unlikely"
Volker Lendecke [Thu, 27 Dec 2007 16:41:19 +0000 (17:41 +0100)]
Wrap the DEBUG checks in a "unlikely"

On my Laptop with some limited netbench runs this gains about 1.5% of
performance. When looking at the assembler output I would suspect the biggest
gain is by the fact that with this in place the calls to the debug functions is
moved to the function end, out of the way of the normal code paths. valgrind
tests pending I would suspect this to be much more cache friendly.

Comments?

Volker
(This used to be commit 51448a9dca95de9d35dd8eea68fde2554cb69921)

11 years agoAdd CIFS_UNIX_TRANSPORT_ENCRYPTION_CAP capability to
Jeremy Allison [Thu, 27 Dec 2007 18:18:22 +0000 (10:18 -0800)]
Add CIFS_UNIX_TRANSPORT_ENCRYPTION_CAP capability to
our reported caps.
Jeremy.
(This used to be commit e86d027823c85173c64e7b85406e98f6f7345b10)

11 years agoEncryption works better when you add the client decrypt code :-).
Jeremy Allison [Thu, 27 Dec 2007 01:17:36 +0000 (17:17 -0800)]
Encryption works better when you add the client decrypt code :-).
Jeremy.
(This used to be commit d67b2634068be9c69082a2b8c22c831aba371cd9)