From: Volker Lendecke <vl@samba.org>
Date: Wed, 6 Jun 2018 16:00:22 +0000 (+0200)
Subject: dns: Do NULL checks in dns_sign_tsig
X-Git-Tag: tdb-1.3.17~3
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=f1ff40752486a5207e3dfb322282243343c25ab7

dns: Do NULL checks in dns_sign_tsig

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c
index 740e1e4dd53..8c7502628d5 100644
--- a/source4/dns_server/dns_crypto.c
+++ b/source4/dns_server/dns_crypto.c
@@ -393,6 +393,9 @@ WERROR dns_sign_tsig(struct dns_server *dns,
 	tsig->ttl = 0;
 	tsig->length = UINT16_MAX;
 	tsig->rdata.tsig_record.algorithm_name = talloc_strdup(tsig, "gss-tsig");
+	if (tsig->rdata.tsig_record.algorithm_name == NULL) {
+		return WERR_NOT_ENOUGH_MEMORY;
+	}
 	tsig->rdata.tsig_record.time_prefix = 0;
 	tsig->rdata.tsig_record.time = current_time;
 	tsig->rdata.tsig_record.fudge = 300;
@@ -403,6 +406,9 @@ WERROR dns_sign_tsig(struct dns_server *dns,
 	if (sig.length > 0) {
 		tsig->rdata.tsig_record.mac_size = sig.length;
 		tsig->rdata.tsig_record.mac = talloc_memdup(tsig, sig.data, sig.length);
+		if (tsig->rdata.tsig_record.mac == NULL) {
+			return WERR_NOT_ENOUGH_MEMORY;
+		}
 	}
 
 	if (packet->arcount == 0) {