From: Samba Release Account <samba-bugs@samba.org> 
Date: Fri, 11 Oct 1996 17:55:16 +0000 (+0000)
Subject: netbios registration and release response packets were being junked. a
X-Git-Tag: samba-misc-tags/samba~450
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=b790455aca91a5443df1010deafa9080b6348ca3

netbios registration and release response packets were being junked. a
BAD idea.

lkcl
---

diff --git a/source/namepacket.c b/source/namepacket.c
index cd133d0a53b..e6677ee10da 100644
--- a/source/namepacket.c
+++ b/source/namepacket.c
@@ -394,12 +394,17 @@ static void process_nmb(struct packet_struct *p)
     case NMB_REG:
     case NMB_REG_REFRESH:
     {
-	if (nmb->header.qdcount==0 || nmb->header.arcount==0) break;
 	if (nmb->header.response)
+        {
+          if (nmb->header.ancount ==0) break;
 	  response_netbios_packet(p); /* response to registration dealt 
 					 with here */
+        }
 	else
+        {
+          if (nmb->header.qdcount==0 || nmb->header.arcount==0) break;
 	  reply_name_reg(p);
+        }
 	break;
     }
       
@@ -439,17 +444,17 @@ static void process_nmb(struct packet_struct *p)
       
     case NMB_REL:
     {
-      if (nmb->header.qdcount==0 || nmb->header.arcount==0)
-	  {
-	    DEBUG(2,("netbios release packet rejected\n"));
-	    break;
-	  }
-	
 	if (nmb->header.response)
-	  response_netbios_packet(p); /* response to reply dealt with 
-					 in here */
+        {
+          if (nmb->header.ancount ==0) break;
+	  response_netbios_packet(p); /* response to release dealt 
+					 with here */
+        }
 	else
+        {
+          if (nmb->header.qdcount==0 || nmb->header.arcount==0) break;
 	  reply_name_release(p);
+        }
       break;
     }
   }