From: Andrew Tridgell <tridge@samba.org>
Date: Mon, 3 Jan 2005 07:57:05 +0000 (+0000)
Subject: r4501: when copying files it is common for clients to copy the ACL. When the
X-Git-Tag: samba-4.0.0alpha6~801^3~12091
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=586949362684864a18f9a56b5a96f7c4b8331281

r4501: when copying files it is common for clients to copy the ACL. When the
ACL is the default ACL this menas the copied file would have an xattr
but the original would not. Avoid this by checking if the ACL being
set is the original ACL, and avoid the copy.
(This used to be commit 1df985a49b200a41eed39023aa668afb233f2e53)
---

diff --git a/source4/ntvfs/posix/pvfs_acl.c b/source4/ntvfs/posix/pvfs_acl.c
index ba5fa96b076..86a9a56ee91 100644
--- a/source4/ntvfs/posix/pvfs_acl.c
+++ b/source4/ntvfs/posix/pvfs_acl.c
@@ -190,7 +190,7 @@ NTSTATUS pvfs_acl_set(struct pvfs_state *pvfs,
 {
 	struct xattr_NTACL *acl;
 	uint32_t secinfo_flags = info->set_secdesc.in.secinfo_flags;
-	struct security_descriptor *new_sd, *sd;
+	struct security_descriptor *new_sd, *sd, orig_sd;
 	NTSTATUS status;
 	uid_t uid = -1;
 	gid_t gid = -1;
@@ -217,6 +217,7 @@ NTSTATUS pvfs_acl_set(struct pvfs_state *pvfs,
 	}
 
 	new_sd = info->set_secdesc.in.sd;
+	orig_sd = *sd;
 
 	uid = name->st.st_uid;
 	gid = name->st.st_gid;
@@ -265,7 +266,12 @@ NTSTATUS pvfs_acl_set(struct pvfs_state *pvfs,
 		}
 	}
 
-	status = pvfs_acl_save(pvfs, name, fd, acl);
+	/* we avoid saving if the sd is the same. This means when clients
+	   copy files and end up copying the default sd that we don't
+	   needlessly use xattrs */
+	if (!security_descriptor_equal(sd, &orig_sd)) {
+		status = pvfs_acl_save(pvfs, name, fd, acl);
+	}
 
 	return status;
 }