From: Andrew Tridgell <tridge@samba.org>
Date: Tue, 14 Dec 2004 22:18:33 +0000 (+0000)
Subject: r4206: fixed a status code check in lsa_LookupNames2 that could cause a segv
X-Git-Tag: samba-misc-tags/initial-v4-0-unstable~10582
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=31ab04f790ff4349dbc8a24c07fa35e10b831baf;hp=590e1a91bfc719c2d84a9a066fb4e0308b6d9803

r4206: fixed a status code check in lsa_LookupNames2 that could cause a segv
---

diff --git a/source/rpc_server/lsa/dcesrv_lsa.c b/source/rpc_server/lsa/dcesrv_lsa.c
index 22e108d5380..5b1323dcff8 100644
--- a/source/rpc_server/lsa/dcesrv_lsa.c
+++ b/source/rpc_server/lsa/dcesrv_lsa.c
@@ -691,8 +691,9 @@ static NTSTATUS lsa_OpenAccount(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 /* 
   lsa_EnumPrivsAccount 
 */
-static NTSTATUS lsa_EnumPrivsAccount(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-		       struct lsa_EnumPrivsAccount *r)
+static NTSTATUS lsa_EnumPrivsAccount(struct dcesrv_call_state *dce_call, 
+				     TALLOC_CTX *mem_ctx,
+				     struct lsa_EnumPrivsAccount *r)
 {
 	DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
 }
@@ -1375,7 +1376,7 @@ static NTSTATUS lsa_LookupNames2(struct dcesrv_call_state *dce_call,
 		r->out.sids->sids[i].unknown     = 0;
 
 		status2 = lsa_lookup_name(state, mem_ctx, name, &sid, &atype);
-		if (!NT_STATUS_IS_OK(status) || sid->num_auths == 0) {
+		if (!NT_STATUS_IS_OK(status2) || sid->num_auths == 0) {
 			status = STATUS_SOME_UNMAPPED;
 			continue;
 		}