From: Günther Deschner <gd@samba.org>
Date: Tue, 10 May 2011 13:49:05 +0000 (+0200)
Subject: s3-printing: Fix double free of cups request.
X-Git-Tag: samba-4.0.0alpha16^2~954
X-Git-Url: http://git.samba.org/?p=samba.git;a=commitdiff_plain;h=019f11dd5b3240d05c1abe30dec3d793d6919313

s3-printing: Fix double free of cups request.

We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
---

diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 5ef44647fd3..ea2fc1d7c49 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -1731,10 +1731,6 @@ bool cups_pull_comment_location(TALLOC_CTX *mem_ctx,
 	if (response)
 		ippDelete(response);
 
-	if (request) {
-		ippDelete(request);
-	}
-
 	if (language)
 		cupsLangFree(language);