Revert "s3:rpcclient add -m option"
authorStefan Metzmacher <metze@samba.org>
Thu, 19 May 2016 09:47:29 +0000 (11:47 +0200)
committerJeremy Allison <jra@samba.org>
Fri, 20 May 2016 23:28:28 +0000 (01:28 +0200)
This reverts commit a55ac51f5f67c61bda1fee7067ad7d09a0c1efdf.

This will be implemented in a more common way using the
"client ipc max protocol" option.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11927

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
docs-xml/manpages/rpcclient.1.xml
source3/rpcclient/rpcclient.c

index 2ce1443c7bf667be523b929f30a94dd9112ff220..fcdd0c668d5a4979e3836af2fd29939a5cec5d91 100644 (file)
@@ -24,7 +24,6 @@
                <arg choice="opt">-c &lt;command string&gt;</arg>
                <arg choice="opt">-d debuglevel</arg>
                <arg choice="opt">-l logdir</arg>
                <arg choice="opt">-c &lt;command string&gt;</arg>
                <arg choice="opt">-d debuglevel</arg>
                <arg choice="opt">-l logdir</arg>
-               <arg choice="opt">-m maxprotocol</arg>
                <arg choice="opt">-N</arg>
                <arg choice="opt">-s &lt;smb config file&gt;</arg>
                <arg choice="opt">-U username[%password]</arg>
                <arg choice="opt">-N</arg>
                <arg choice="opt">-s &lt;smb config file&gt;</arg>
                <arg choice="opt">-U username[%password]</arg>
                above. </para></listitem>
                </varlistentry>
 
                above. </para></listitem>
                </varlistentry>
 
-               <varlistentry>
-               <term>-m|--max-protocol protocol</term>
-               <listitem><para>This allows the user to select the
-               highest SMB protocol level that rpcclient will use to
-               connect to the server. By default this is set to
-               NT1, which is the highest available SMB1 protocol.
-               To connect using SMB2 or SMB3 protocol, use the
-               strings SMB2 or SMB3 respectively. Note that to connect
-               to a Windows 2012 server with encrypted transport selecting
-               a max-protocol of SMB3 is required.
-               </para></listitem>
-               </varlistentry>
-
                <varlistentry>
                <term>-p|--port port</term>
                <listitem><para>This number is the TCP port number that will be used
                <varlistentry>
                <term>-p|--port port</term>
                <listitem><para>This number is the TCP port number that will be used
index 44d691bd61433d61ae92167b7313e497030f94fb..efca9530cf249fc8be0eeef1e700294916893255 100644 (file)
@@ -913,7 +913,6 @@ out_free:
                {"command",     'c', POPT_ARG_STRING,   &cmdstr, 'c', "Execute semicolon separated cmds", "COMMANDS"},
                {"dest-ip", 'I', POPT_ARG_STRING,   &opt_ipaddr, 'I', "Specify destination IP address", "IP"},
                {"port", 'p', POPT_ARG_INT,   &opt_port, 'p', "Specify port number", "PORT"},
                {"command",     'c', POPT_ARG_STRING,   &cmdstr, 'c', "Execute semicolon separated cmds", "COMMANDS"},
                {"dest-ip", 'I', POPT_ARG_STRING,   &opt_ipaddr, 'I', "Specify destination IP address", "IP"},
                {"port", 'p', POPT_ARG_INT,   &opt_port, 'p', "Specify port number", "PORT"},
-               {"max-protocol", 'm', POPT_ARG_STRING, NULL, 'm', "Set the max protocol level", "LEVEL" },
                POPT_COMMON_SAMBA
                POPT_COMMON_CONNECTION
                POPT_COMMON_CREDENTIALS
                POPT_COMMON_SAMBA
                POPT_COMMON_CONNECTION
                POPT_COMMON_CREDENTIALS
@@ -950,10 +949,6 @@ out_free:
        while((opt = poptGetNextOpt(pc)) != -1) {
                switch (opt) {
 
        while((opt = poptGetNextOpt(pc)) != -1) {
                switch (opt) {
 
-               case 'm':
-                       lp_set_cmdline("client max protocol", poptGetOptArg(pc));
-                       break;
-
                case 'I':
                        if (!interpret_string_addr(&server_ss,
                                                opt_ipaddr,
                case 'I':
                        if (!interpret_string_addr(&server_ss,
                                                opt_ipaddr,