credentials: Only do shallow copies of valid ccaches
authorVolker Lendecke <vl@samba.org>
Wed, 21 Nov 2018 16:36:35 +0000 (17:36 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 28 Nov 2018 16:44:14 +0000 (17:44 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
auth/credentials/credentials_krb5.c

index d36797b..3f142f7 100644 (file)
@@ -896,12 +896,26 @@ static int cli_credentials_shallow_ccache(struct cli_credentials *cred)
        const struct ccache_container *old_ccc = NULL;
        struct ccache_container *ccc = NULL;
        char *ccache_name = NULL;
+       krb5_principal princ;
 
        old_ccc = cred->ccache;
        if (old_ccc == NULL) {
                return 0;
        }
 
+       ret = krb5_cc_get_principal(
+               old_ccc->smb_krb5_context->krb5_context,
+               old_ccc->ccache,
+               &princ);
+       if (ret != 0) {
+               /*
+                * This is an empty ccache. No point in copying anything.
+                */
+               cred->ccache = NULL;
+               return 0;
+       }
+       krb5_free_principal(old_ccc->smb_krb5_context->krb5_context, princ);
+
        ccc = talloc(cred, struct ccache_container);
        if (ccc == NULL) {
                return ENOMEM;