libsmbconf: untangle assignment and test in for-loop condition.

Michael
(This used to be commit 4339caff09e1277ae33d3810043bcb3f4e7c4e45)

diff --git a/source3/lib/smbconf/smbconf_reg.c b/source3/lib/smbconf/smbconf_reg.c
index b40c37e60e7b94c530abc22e9256757a4f45392a..f25382769dce31bbcf93f29d114f6bc4feb33b63 100644 (file)
--- a/source3/lib/smbconf/smbconf_reg.c
+++ b/source3/lib/smbconf/smbconf_reg.c
@@ -342,8 +342,8 @@ static WERROR smbconf_reg_get_values(TALLOC_CTX *mem_ctx,
        }
 
        for (count = 0;
-            W_ERROR_IS_OK(werr = reg_enumvalue(tmp_ctx, key, count, &valname,
-                                               &valvalue));
+            werr = reg_enumvalue(tmp_ctx, key, count, &valname, &valvalue),
+            W_ERROR_IS_OK(werr);
             count++)
        {
                char *valstring;
@@ -562,8 +562,8 @@ static WERROR smbconf_reg_get_share_names(struct smbconf_ctx *ctx,
        }
 
        for (count = 0;
-            W_ERROR_IS_OK(werr = reg_enumkey(tmp_ctx, key, count,
-                                             &subkey_name, NULL));
+            werr = reg_enumkey(tmp_ctx, key, count, &subkey_name, NULL),
+            W_ERROR_IS_OK(werr);
             count++)
        {
                if (strequal(subkey_name, GLOBAL_NAME)) {