dsdb: Add assert in drepl_take_FSMO_role
authorAndrew Bartlett <abartlet@samba.org>
Thu, 27 Jun 2013 23:15:16 +0000 (09:15 +1000)
committerStefan Metzmacher <metze@samba.org>
Wed, 24 Jul 2013 14:35:32 +0000 (16:35 +0200)
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
source4/dsdb/repl/drepl_fsmo.c

index 37fb684f473a1cf6970017b33d97d19b73d2c8a1..7a107da6a3de496fbfbf5a5b943462c677abfdaf 100644 (file)
@@ -91,11 +91,10 @@ NTSTATUS drepl_take_FSMO_role(struct irpc_message *msg,
                extended_op = DRSUAPI_EXOP_FSMO_REQ_PDC;
                break;
        default:
-               DEBUG(2,("Unknown role %u in role transfer\n",
+               DEBUG(0,("Unknown role %u in role transfer\n",
                         (unsigned)role));
-               r->out.result = WERR_DS_DRA_INTERNAL_ERROR;
-               talloc_free(tmp_ctx);
-               return NT_STATUS_OK;
+               /* IRPC messages are trusted, so this really should not happen */
+               smb_panic("Unknown role despite dsdb_get_fsmo_role_info success");
        }
 
        ret = samdb_dn_is_our_ntdsa(service->samdb, role_owner_dn, &is_us);