tdb: cleanup: rename global_lock to allrecord_lock.

The word global is overloaded in tdb.  The global_lock inside struct
tdb_context is used to indicate we hold a lock across all the chains.

Rename it to allrecord_lock.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/lib/tdb/common/lock.c b/lib/tdb/common/lock.c
index 515bffee598f01df50f73524d214b21b72f79510..6b320f45fedf7a410bbed3ba5a14eff9f1fc3599 100644 (file)
--- a/lib/tdb/common/lock.c
+++ b/lib/tdb/common/lock.c
@@ -226,13 +226,13 @@ static int _tdb_lock(struct tdb_context *tdb, int list, int ltype,
        struct tdb_lock_type *new_lck;
        int i;
 
        struct tdb_lock_type *new_lck;
        int i;
 

-       /* a global lock allows us to avoid per chain locks */
-       if (tdb->global_lock.count && 
-           (ltype == tdb->global_lock.ltype || ltype == F_RDLCK)) {
+       /* a allrecord lock allows us to avoid per chain locks */
+       if (tdb->allrecord_lock.count &&
+           (ltype == tdb->allrecord_lock.ltype || ltype == F_RDLCK)) {

                return 0;
        }
 
                return 0;
        }
 

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }
                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }


@@ -318,12 +318,12 @@ static int _tdb_unlock(struct tdb_context *tdb, int list, int ltype,
        struct tdb_lock_type *lck = NULL;
 
        /* a global lock allows us to avoid per chain locks */
        struct tdb_lock_type *lck = NULL;
 
        /* a global lock allows us to avoid per chain locks */

-       if (tdb->global_lock.count && 
-           (ltype == tdb->global_lock.ltype || ltype == F_RDLCK)) {
+       if (tdb->allrecord_lock.count &&
+           (ltype == tdb->allrecord_lock.ltype || ltype == F_RDLCK)) {

                return 0;
        }
 
                return 0;
        }
 

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }
                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }


@@ -403,7 +403,7 @@ int tdb_unlock(struct tdb_context *tdb, int list, int ltype)
  */
 int tdb_transaction_lock(struct tdb_context *tdb, int ltype)
 {
  */
 int tdb_transaction_lock(struct tdb_context *tdb, int ltype)
 {

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                return 0;
        }
        if (tdb->transaction_lock_count > 0) {
                return 0;
        }
        if (tdb->transaction_lock_count > 0) {


@@ -426,7 +426,7 @@ int tdb_transaction_lock(struct tdb_context *tdb, int ltype)
 int tdb_transaction_unlock(struct tdb_context *tdb, int ltype)
 {
        int ret;
 int tdb_transaction_unlock(struct tdb_context *tdb, int ltype)
 {
        int ret;

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                return 0;
        }
        if (tdb->transaction_lock_count > 1) {
                return 0;
        }
        if (tdb->transaction_lock_count > 1) {


@@ -453,12 +453,12 @@ static int _tdb_lockall(struct tdb_context *tdb, int ltype,
                return -1;
        }
 
                return -1;
        }
 

-       if (tdb->global_lock.count && tdb->global_lock.ltype == ltype) {
-               tdb->global_lock.count++;
+       if (tdb->allrecord_lock.count && tdb->allrecord_lock.ltype == ltype) {
+               tdb->allrecord_lock.count++;

                return 0;
        }
 
                return 0;
        }
 

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                /* a global lock of a different type exists */
                tdb->ecode = TDB_ERR_LOCK;
                return -1;
                /* a global lock of a different type exists */
                tdb->ecode = TDB_ERR_LOCK;
                return -1;


@@ -479,8 +479,8 @@ static int _tdb_lockall(struct tdb_context *tdb, int ltype,
                return -1;
        }
 
                return -1;
        }
 

-       tdb->global_lock.count = 1;
-       tdb->global_lock.ltype = ltype;
+       tdb->allrecord_lock.count = 1;
+       tdb->allrecord_lock.ltype = ltype;

 
        return 0;
 }
 
        return 0;
 }


@@ -496,13 +496,13 @@ static int _tdb_unlockall(struct tdb_context *tdb, int ltype, bool mark_lock)
                return -1;
        }
 
                return -1;
        }
 

-       if (tdb->global_lock.ltype != ltype || tdb->global_lock.count == 0) {
+       if (tdb->allrecord_lock.ltype != ltype || tdb->allrecord_lock.count == 0) {

                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }
 
                tdb->ecode = TDB_ERR_LOCK;
                return -1;
        }
 

-       if (tdb->global_lock.count > 1) {
-               tdb->global_lock.count--;
+       if (tdb->allrecord_lock.count > 1) {
+               tdb->allrecord_lock.count--;

                return 0;
        }
 
                return 0;
        }
 


@@ -513,8 +513,8 @@ static int _tdb_unlockall(struct tdb_context *tdb, int ltype, bool mark_lock)
                return -1;
        }
 
                return -1;
        }
 

-       tdb->global_lock.count = 0;
-       tdb->global_lock.ltype = 0;
+       tdb->allrecord_lock.count = 0;
+       tdb->allrecord_lock.ltype = 0;

 
        return 0;
 }
 
        return 0;
 }


@@ -637,7 +637,7 @@ int tdb_chainunlock_read(struct tdb_context *tdb, TDB_DATA key)
 /* record lock stops delete underneath */
 int tdb_lock_record(struct tdb_context *tdb, tdb_off_t off)
 {
 /* record lock stops delete underneath */
 int tdb_lock_record(struct tdb_context *tdb, tdb_off_t off)
 {

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                return 0;
        }
        return off ? tdb->methods->brlock(tdb, F_RDLCK, off, 1, TDB_LOCK_WAIT) : 0;
                return 0;
        }
        return off ? tdb->methods->brlock(tdb, F_RDLCK, off, 1, TDB_LOCK_WAIT) : 0;


@@ -668,7 +668,7 @@ int tdb_unlock_record(struct tdb_context *tdb, tdb_off_t off)
        struct tdb_traverse_lock *i;
        uint32_t count = 0;
 
        struct tdb_traverse_lock *i;
        uint32_t count = 0;
 

-       if (tdb->global_lock.count) {
+       if (tdb->allrecord_lock.count) {

                return 0;
        }
 
                return 0;
        }
 

diff --git a/lib/tdb/common/open.c b/lib/tdb/common/open.c
index 35968c9eaf67df9d6d962e5279535330859e389d..9fbd5fdea92a9c4e15e165ca623c3447e0ab1e29 100644 (file)
--- a/lib/tdb/common/open.c
+++ b/lib/tdb/common/open.c
@@ -465,7 +465,7 @@ static int tdb_reopen_internal(struct tdb_context *tdb, bool active_lock)
                return 0; /* Nothing to do. */
        }
 
                return 0; /* Nothing to do. */
        }
 

-       if (tdb->num_locks != 0 || tdb->global_lock.count) {
+       if (tdb->num_locks != 0 || tdb->allrecord_lock.count) {

                TDB_LOG((tdb, TDB_DEBUG_ERROR, "tdb_reopen: reopen not allowed with locks held\n"));
                goto fail;
        }
                TDB_LOG((tdb, TDB_DEBUG_ERROR, "tdb_reopen: reopen not allowed with locks held\n"));
                goto fail;
        }

diff --git a/lib/tdb/common/tdb.c b/lib/tdb/common/tdb.c
index 9fa7287113d1efe6fb40f59dc57a230c06a07be3..ad81a56877f55d9cf711a4ad4e502fbfdb090093 100644 (file)
--- a/lib/tdb/common/tdb.c
+++ b/lib/tdb/common/tdb.c
@@ -805,7 +805,7 @@ static int tdb_free_region(struct tdb_context *tdb, tdb_off_t offset, ssize_t le
 
 /*
   wipe the entire database, deleting all records. This can be done
 
 /*
   wipe the entire database, deleting all records. This can be done

-  very fast by using a global lock. The entire data portion of the
+  very fast by using a allrecord lock. The entire data portion of the

   file becomes a single entry in the freelist.
 
   This code carefully steps around the recovery area, leaving it alone
   file becomes a single entry in the freelist.
 
   This code carefully steps around the recovery area, leaving it alone

diff --git a/lib/tdb/common/tdb_private.h b/lib/tdb/common/tdb_private.h
index be630e8bfa57fcc82f785e6719869f67560be5ae..2e5679690f32146fbefe87e1299920944bb381ea 100644 (file)
--- a/lib/tdb/common/tdb_private.h
+++ b/lib/tdb/common/tdb_private.h
@@ -191,7 +191,7 @@ struct tdb_context {
        int read_only; /* opened read-only */
        int traverse_read; /* read-only traversal */
        int traverse_write; /* read-write traversal */
        int read_only; /* opened read-only */
        int traverse_read; /* read-only traversal */
        int traverse_write; /* read-write traversal */

-       struct tdb_lock_type global_lock;
+       struct tdb_lock_type allrecord_lock;

        int num_lockrecs;
        struct tdb_lock_type *lockrecs; /* only real locks, all with count>0 */
        enum TDB_ERROR ecode; /* error code for last tdb error */
        int num_lockrecs;
        struct tdb_lock_type *lockrecs; /* only real locks, all with count>0 */
        enum TDB_ERROR ecode; /* error code for last tdb error */

diff --git a/lib/tdb/common/transaction.c b/lib/tdb/common/transaction.c
index 08910a74a9601eae6a71f1dd6a140cc460d2978a..e72eff5b1f94d7da96d4ee20bc21e31b93038737 100644 (file)
--- a/lib/tdb/common/transaction.c
+++ b/lib/tdb/common/transaction.c
@@ -463,7 +463,7 @@ int tdb_transaction_start(struct tdb_context *tdb)
                return 0;
        }
 
                return 0;
        }
 

-       if (tdb->num_locks != 0 || tdb->global_lock.count) {
+       if (tdb->num_locks != 0 || tdb->allrecord_lock.count) {

                /* the caller must not have any locks when starting a
                   transaction as otherwise we'll be screwed by lack
                   of nested locks in posix */
                /* the caller must not have any locks when starting a
                   transaction as otherwise we'll be screwed by lack
                   of nested locks in posix */


@@ -621,10 +621,10 @@ static int _tdb_transaction_cancel(struct tdb_context *tdb, int ltype)
        }
 
        /* remove any global lock created during the transaction */
        }
 
        /* remove any global lock created during the transaction */

-       if (tdb->global_lock.count != 0) {
-               tdb_brunlock(tdb, tdb->global_lock.ltype,
+       if (tdb->allrecord_lock.count != 0) {
+               tdb_brunlock(tdb, tdb->allrecord_lock.ltype,

                             FREELIST_TOP, 4*tdb->header.hash_size);
                             FREELIST_TOP, 4*tdb->header.hash_size);

-               tdb->global_lock.count = 0;
+               tdb->allrecord_lock.count = 0;

        }
 
        /* remove any locks created during the transaction */
        }
 
        /* remove any locks created during the transaction */


@@ -950,7 +950,7 @@ static int _tdb_transaction_prepare_commit(struct tdb_context *tdb)
        
        /* if there are any locks pending then the caller has not
           nested their locks properly, so fail the transaction */
        
        /* if there are any locks pending then the caller has not
           nested their locks properly, so fail the transaction */

-       if (tdb->num_locks || tdb->global_lock.count) {
+       if (tdb->num_locks || tdb->allrecord_lock.count) {

                tdb->ecode = TDB_ERR_LOCK;
                TDB_LOG((tdb, TDB_DEBUG_ERROR, "tdb_transaction_prepare_commit: locks pending on commit\n"));
                _tdb_transaction_cancel(tdb, F_RDLCK);
                tdb->ecode = TDB_ERR_LOCK;
                TDB_LOG((tdb, TDB_DEBUG_ERROR, "tdb_transaction_prepare_commit: locks pending on commit\n"));
                _tdb_transaction_cancel(tdb, F_RDLCK);