smbcontrol: Use messaging_dgm_forall
authorVolker Lendecke <vl@samba.org>
Thu, 26 Oct 2017 15:18:36 +0000 (17:18 +0200)
committerJeremy Allison <jra@samba.org>
Mon, 4 Dec 2017 23:56:12 +0000 (00:56 +0100)
Doing stacktraces can be done locally only anyway

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/utils/smbcontrol.c

index 08c1530cdff4d12371319f0994193d61294c0766..417358b7d5b747053ecd2045a2d43fb3ee198682 100644 (file)
@@ -319,13 +319,9 @@ cleanup:
        ptrace(PTRACE_DETACH, pid, NULL, NULL);
 }
 
-static int stack_trace_server(const struct server_id *id,
-                             uint32_t msg_flags,
-                             void *priv)
+static int stack_trace_server(pid_t pid, void *priv)
 {
-       if (procid_is_local(id)) {
-               print_stack_trace(procid_to_pid(id), (int *)priv);
-       }
+       print_stack_trace(pid, (int *)priv);
        return 0;
 }
 
@@ -352,7 +348,7 @@ static bool do_daemon_stack_trace(struct tevent_context *ev_ctx,
                 */
                print_stack_trace(dest, &count);
        } else {
-               serverid_traverse_read(stack_trace_server, &count);
+               messaging_dgm_forall(stack_trace_server, &count);
        }
 
        return True;