Revert "smbd: add smbd_server_connection->raw_ev_ctx pointer"
authorRalph Boehme <slow@samba.org>
Thu, 27 Dec 2018 14:26:15 +0000 (15:26 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 11 Jan 2019 22:11:19 +0000 (23:11 +0100)
This reverts commit 6114f9545fa856717220658e87f2a60f6767b7f4.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/smbd/globals.h
source3/smbd/msdfs.c
source3/smbd/process.c

index 689aa0b..02f1e58 100644 (file)
@@ -877,7 +877,6 @@ struct smbd_server_connection {
        const struct tsocket_address *remote_address;
        const char *remote_hostname;
        struct tevent_context *ev_ctx;
-       struct tevent_context *raw_ev_ctx;
        struct messaging_context *msg_ctx;
        struct notify_context *notify_ctx;
        bool using_smb2;
index af5888c..19cb301 100644 (file)
@@ -258,13 +258,12 @@ static NTSTATUS create_conn_struct_as_root(TALLOC_CTX *ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       sconn->raw_ev_ctx = samba_tevent_context_init(sconn);
-       if (sconn->raw_ev_ctx == NULL) {
+       sconn->ev_ctx = samba_tevent_context_init(sconn);
+       if (sconn->ev_ctx == NULL) {
                TALLOC_FREE(sconn);
                return NT_STATUS_NO_MEMORY;
        }
 
-       sconn->ev_ctx = sconn->raw_ev_ctx;
        sconn->msg_ctx = msg;
 
        conn = conn_new(sconn);
index 03aa225..99693ed 100644 (file)
@@ -3924,7 +3924,6 @@ void smbd_process(struct tevent_context *ev_ctx,
        sconn->client = client;
 
        sconn->ev_ctx = ev_ctx;
-       sconn->raw_ev_ctx = ev_ctx;
        sconn->msg_ctx = msg_ctx;
 
        ret = pthreadpool_tevent_init(sconn, lp_aio_max_threads(),