r24784: Initialize uninitalized data to prevent segfaults.
authorMichael Adam <obnox@samba.org>
Wed, 29 Aug 2007 14:34:15 +0000 (14:34 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:30:21 +0000 (12:30 -0500)
Thanks to Volker for the hint!

Michael
(This used to be commit 3b7ed3ea881dc59b77a067d5d3738e9e03b6c538)

source3/rpc_client/cli_lsarpc.c

index cf2e5624a9eb53113d371bd6fb612c2b9bf6528e..281fe855762caa6b8e28cd6f1db7c40977f8c5d8 100644 (file)
@@ -182,6 +182,11 @@ static NTSTATUS rpccli_lsa_lookup_sids_noalloc(struct rpc_pipe_client *cli,
        /* Return output parameters */
 
        if (r.mapped_count == 0) {
        /* Return output parameters */
 
        if (r.mapped_count == 0) {
+               for (i = 0; i < num_sids; i++) {
+                       (names)[i] = NULL;
+                       (domains)[i] = NULL;
+                       (types)[i] = SID_NAME_UNKNOWN;
+               }
                result = NT_STATUS_NONE_MAPPED;
                goto done;
        }
                result = NT_STATUS_NONE_MAPPED;
                goto done;
        }