s3: Fix Coverity ID 242184 Dereference after null check

rpc_query_user unconditionally dereferences user_info if successfull

diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index c03f59381e5963f14aa9d5598f7f9a898c8adbb1..5994a354b51c748c564a4d423127565b52b6184c 100644 (file)
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -317,11 +317,9 @@ static NTSTATUS sam_query_user(struct winbindd_domain *domain,
                return NT_STATUS_NO_SUCH_USER;
        }
 
-       if (user_info) {
-               user_info->homedir = NULL;
-               user_info->shell = NULL;
-               user_info->primary_gid = (gid_t) -1;
-       }
+       user_info->homedir = NULL;
+       user_info->shell = NULL;
+       user_info->primary_gid = (gid_t) -1;
 
        tmp_ctx = talloc_stackframe();
        if (tmp_ctx == NULL) {