s3: smbd: Inside rename_internals() wildcard case, re-purpose dst_original_lcomp.
authorJeremy Allison <jra@samba.org>
Thu, 26 Mar 2020 22:32:36 +0000 (15:32 -0700)
committerRalph Boehme <slow@samba.org>
Mon, 30 Mar 2020 14:45:30 +0000 (14:45 +0000)
Pass to rename_internals_fsp() instead of using smb_fname_dst->original_lcomp.

Removes one more use of the struct member original_lcomp.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index 369398116a4f5cc7c7ebd3996570f56abd7b7af2..826387b99149b37971d35eaf9d384e0f22b8e5d5 100644 (file)
@@ -8228,9 +8228,8 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
                        break;
                }
 
-               smb_fname_dst->original_lcomp = talloc_strdup(smb_fname_dst,
-                                                             dname);
-               if (!smb_fname_dst->original_lcomp) {
+               dst_original_lcomp = talloc_strdup(smb_fname_dst, dname);
+               if (dst_original_lcomp == NULL) {
                        status = NT_STATUS_NO_MEMORY;
                        goto out;
                }
@@ -8238,7 +8237,7 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
                status = rename_internals_fsp(conn,
                                        fsp,
                                        smb_fname_dst,
-                                       smb_fname_dst->original_lcomp,
+                                       dst_original_lcomp,
                                        attrs,
                                        replace_if_exists);