s4:torture The test logic for the target was wrong. This should correct it.

diff --git a/source4/torture/ldap/basic.c b/source4/torture/ldap/basic.c
index ff95ba74ac9b8eb525df856075efcc5c1e46f8cf..c2a26f81b8cdce3cbb7b2ce3993a16c171a96bff 100644 (file)
--- a/source4/torture/ldap/basic.c
+++ b/source4/torture/ldap/basic.c
@@ -217,7 +217,7 @@ static bool test_error_codes(struct torture_context *tctx,
        WERROR err;
        NTSTATUS status;
 
-       printf("Testing error codes\n");
+       printf("Testing error codes - to make this test pass against SAMBA 4 you have to specify the target!\n");
 
        if (!basedn) {
                return false;
@@ -257,7 +257,7 @@ static bool test_error_codes(struct torture_context *tctx,
        err = ad_error(rep->r.AddResponse.errormessage, &endptr);
        err_code_str = win_errstr(err);
        printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr);
-       if (torture_setting_bool(tctx, "samba4", false)) {
+       if (!torture_setting_bool(tctx, "samba4", false)) {
                if ((!W_ERROR_EQUAL(err, WERR_DS_REFERRAL))
                        || (rep->r.AddResponse.resultcode != 10)) {
                        return false;
@@ -298,7 +298,7 @@ static bool test_error_codes(struct torture_context *tctx,
        err = ad_error(rep->r.ModifyResponse.errormessage, &endptr);
        err_code_str = win_errstr(err);
        printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr);
-       if (torture_setting_bool(tctx, "samba4", false)) {
+       if (!torture_setting_bool(tctx, "samba4", false)) {
                if ((!W_ERROR_EQUAL(err, WERR_INVALID_PARAM))
                        || (rep->r.ModifyResponse.resultcode != 53)) {
                        return false;
@@ -337,7 +337,7 @@ static bool test_error_codes(struct torture_context *tctx,
        err = ad_error(rep->r.DelResponse.errormessage, &endptr);
        err_code_str = win_errstr(err);
        printf(" - Errorcode: %s; Reason: %s\n", err_code_str, endptr);
-       if (torture_setting_bool(tctx, "samba4", false)) {
+       if (!torture_setting_bool(tctx, "samba4", false)) {
                if ((!W_ERROR_EQUAL(err, WERR_DS_OBJ_NOT_FOUND))
                        || (rep->r.DelResponse.resultcode != 32)) {
                        return false;