Fixed unitilized secdesc pointer which was causing spoolgetprinter

rpcclient command to fail on shared printers.

jerry

diff --git a/source/rpc_client/msrpc_spoolss.c b/source/rpc_client/msrpc_spoolss.c
index d8379048cf417a461ddbc779364794456093253f..10582c01be7e754b8e4b56cb5d510d7b1ce67323 100644 (file)
--- a/source/rpc_client/msrpc_spoolss.c
+++ b/source/rpc_client/msrpc_spoolss.c
@@ -92,6 +92,8 @@ static void decode_printer_info_2(NEW_BUFFER *buffer, uint32 returned,
         buffer->prs.data_offset=0;
 
         for (i=0; i<returned; i++) {
+               /* a little initialization as we go */
+               inf[i].secdesc = NULL;
                 new_smb_io_printer_info_2("", buffer, &(inf[i]), 0);
         }
 
@@ -356,6 +358,9 @@ BOOL msrpc_spoolss_enum_printerdata( const char* printer_name,
        if(!spoolss_open_printer_ex( printer_name, 0, 0, station, user_name, &hnd))
                return False;
 
+       /* FIXME!!!!  --jerry
+          something is severly buggy about the use of 
+          data, datalen, value, & valuelen */
        status = spoolss_enum_printerdata(&hnd, 0, &valuelen, value, 
                                          &rvaluelen, &type, &datalen, 
                                          data, &rdatalen);

diff --git a/source/rpcclient/cmd_spoolss.c b/source/rpcclient/cmd_spoolss.c
index 2dd70bfd67f9d238f71eee2557835f2b740e986c..9b4da4f1af1a37e2d49038771c8b385c66d0e2c7 100644 (file)
--- a/source/rpcclient/cmd_spoolss.c
+++ b/source/rpcclient/cmd_spoolss.c
@@ -337,8 +337,8 @@ uint32 cmd_spoolss_getprinterdata(struct client_info *info, int argc, char *argv
                                 printer_name, station, value_name));
 
         status = msrpc_spoolss_getprinterdata( printer_name, station,
-                                "Administrateur",
-                                /*usr_creds->ntc.user_name,*/
+                                /* "Administrateur", */
+                                usr_creds->ntc.user_name,
                                 value_name, &type,
                                 &ctr, NULL);