ctdb-common: Fix CID 1435600

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed May 16 09:51:07 CEST 2018 on sn-devel-144

diff --git a/ctdb/common/logging.c b/ctdb/common/logging.c
index 3cc19331bab8d9d3122ca5c46d05a3b8c53f41f5..dc8c4f7505896007bfee30833fb6c53d6ca65604 100644 (file)
--- a/ctdb/common/logging.c
+++ b/ctdb/common/logging.c
@@ -173,13 +173,12 @@ static bool file_log_validate(const char *option)
        dir = dirname(t);
 
        ret = stat(dir, &st);
+       free(t);
        if (ret != 0) {
-               free(t);
                return false;
        }
 
        if (! S_ISDIR(st.st_mode)) {
-               free(t);
                return false;
        }