s3:auth: make_user_info_map() should not set mapped_state
authorStefan Metzmacher <metze@samba.org>
Thu, 3 Mar 2022 22:24:25 +0000 (23:24 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 10 Mar 2022 03:16:35 +0000 (03:16 +0000)
mapped_state is only evaluated in authsam_check_password_internals()
of auth_sam.c in source4, so setting it in the auth3 code
doesn't make any difference. I've proved that with
an SMB_ASSERT() and a full pipeline not triggering it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13879

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/auth/auth_util.c

index d7b3b032572eb75ece3bd0ca52f16b9c04a8627e..b60dd2647c86ba29cd2b9c9b4d66797b435a4bcf 100644 (file)
@@ -137,8 +137,6 @@ NTSTATUS make_user_info_map(TALLOC_CTX *mem_ctx,
                                lm_interactive_pwd, nt_interactive_pwd,
                                plaintext, password_state);
        if (NT_STATUS_IS_OK(result)) {
-               /* We have tried mapping */
-               (*user_info)->mapped_state = true;
                /* did we actually map the user to a different name? */
                (*user_info)->was_mapped = was_mapped;
        }