s4:rpc_server: don't replace '\\pipe\\' with '\\PIPE\\'
authorStefan Metzmacher <metze@samba.org>
Wed, 12 Dec 2018 12:48:05 +0000 (13:48 +0100)
committerJeremy Allison <jra@samba.org>
Sat, 12 Jan 2019 02:13:40 +0000 (03:13 +0100)
This is not what Windows returns (at least for \\pipe\lsass).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=7113
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11892

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
selftest/knownfail.d/test_assoc_group_ok2 [deleted file]
source4/rpc_server/dcerpc_server.c

diff --git a/selftest/knownfail.d/test_assoc_group_ok2 b/selftest/knownfail.d/test_assoc_group_ok2
deleted file mode 100644 (file)
index 7d46cce..0000000
+++ /dev/null
@@ -1 +0,0 @@
-^samba.tests.dcerpc.raw_protocol.*.TestDCERPC_BIND.test_assoc_group_ok2
index b34585d..a36d91d 100644 (file)
@@ -958,7 +958,6 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
        uint32_t extra_flags = 0;
        uint16_t max_req = 0;
        uint16_t max_rep = 0;
-       const char *ep_prefix = "";
        const char *endpoint = NULL;
        struct dcesrv_auth *auth = call->auth_state;
        struct dcerpc_ack_ctx *ack_ctx_list = NULL;
@@ -1178,22 +1177,7 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
                endpoint = "";
        }
 
-       if (strncasecmp(endpoint, "\\pipe\\", 6) == 0) {
-               /*
-                * TODO: check if this is really needed
-                *
-                * Or if we should fix this in our idl files.
-                */
-               ep_prefix = "\\PIPE\\";
-               endpoint += 6;
-       }
-
-       pkt->u.bind_ack.secondary_address = talloc_asprintf(call, "%s%s",
-                                                          ep_prefix,
-                                                          endpoint);
-       if (pkt->u.bind_ack.secondary_address == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       pkt->u.bind_ack.secondary_address = endpoint;
        pkt->u.bind_ack.num_results = call->pkt.u.bind.num_contexts;
        pkt->u.bind_ack.ctx_list = ack_ctx_list;
        pkt->u.bind_ack.auth_info = data_blob_null;