Fix a scary "fill_share_mode_lock failed" message
authorVolker Lendecke <vl@samba.org>
Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)
committerVolker Lendecke <vl@samba.org>
Thu, 26 Mar 2009 11:30:44 +0000 (12:30 +0100)
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.

Change the corresponding debug message to level 10 and explain more.

source3/locking/locking.c

index bafb89522affa7752921145fb829dd2f83b093e1..70841225a70db04dc54e4f75f10b538997e3e2ec 100644 (file)
@@ -887,7 +887,8 @@ struct share_mode_lock *fetch_share_mode_unlocked(TALLOC_CTX *mem_ctx,
        }
 
        if (!fill_share_mode_lock(lck, id, servicepath, fname, data, NULL)) {
-               DEBUG(3, ("fill_share_mode_lock failed\n"));
+               DEBUG(10, ("fetch_share_mode_unlocked: no share_mode record "
+                          "around (file not open)\n"));
                TALLOC_FREE(lck);
                return NULL;
        }