s3: smbd: Remove unneeded lp_posix_pathnames() check in SMB2 create.

Add a comment reminding me to re-add the check when SMB2
unix extensions are re-added.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>

diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
index ab37be0fb174355fa48c3aa3a1453c86d2c6df28..4c1b81d96731caa98710f1513aa28aaaae9fbcc1 100644 (file)
--- a/source3/smbd/smb2_create.c
+++ b/source3/smbd/smb2_create.c
@@ -716,8 +716,13 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
                                return tevent_req_post(req, ev);
                        }
 
-                       if (!lp_posix_pathnames() &&
-                                       ea_list_has_invalid_name(ea_list)) {
+                       /*
+                        * NB. When SMB2+ unix extensions are added,
+                        * we need to relax this check in invalid
+                        * names - we used to not do this if
+                        * lp_posix_pathnames() was false.
+                        */
+                       if (ea_list_has_invalid_name(ea_list)) {
                                tevent_req_nterror(req, STATUS_INVALID_EA_NAME);
                                return tevent_req_post(req, ev);
                        }