Ensure EA value is allocated on the right context.

Ensure we free on error condition (tidyup, not a leak).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Apr  2 21:54:33 CEST 2013 on sn-devel-104

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 4cdd2394ca56f7b6d41e2162fdde1bb251dab9da..5781c6194396fc5eab2ce89f752fca98db0e875d 100644 (file)
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -350,11 +350,12 @@ static NTSTATUS get_ea_list_from_file_path(TALLOC_CTX *mem_ctx, connection_struc
                        return NT_STATUS_NO_MEMORY;
                }
 
-               status = get_ea_value(mem_ctx, conn, fsp,
+               status = get_ea_value(listp, conn, fsp,
                                      fname, names[i],
                                      &listp->ea);
 
                if (!NT_STATUS_IS_OK(status)) {
+                       TALLOC_FREE(listp);
                        return status;
                }