Make sure server_role gets initialized in backend provisioning code -

fixes test.

diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py
index 2da54ef14b17ad02409f19971b7414fe8d625832..91cc074031817789b02afb3ef6a715e87e5e9834 100644 (file)
--- a/source4/scripting/python/samba/provision.py
+++ b/source4/scripting/python/samba/provision.py
@@ -1195,6 +1195,9 @@ def provision_backend(setup_dir=None, message=None,
     lp = param.LoadParm()
     lp.load(smbconf)
 
+    if serverrole is None:
+        serverrole = lp.get("server role")
+
     names = guess_names(lp=lp, hostname=hostname, domain=domain, 
                         dnsdomain=realm, serverrole=serverrole, 
                         rootdn=rootdn, domaindn=domaindn, configdn=configdn, 
@@ -1405,7 +1408,20 @@ def provision_backend(setup_dir=None, message=None,
 
     message("LDAP admin password: %s" % adminpass)
     message(slapdcommand)
-    message("Run provision with:  --ldap-backend=ldapi --ldap-backend-type=" + ldap_backend_type + " --password=" + adminpass + " " + ldapuser + "--realm=" + names.dnsdomain + " --domain=" + names.domain + " --server-role='" + serverrole + "'")
+    assert isinstance(ldap_backend_type, str)
+    assert isinstance(ldapuser, str)
+    assert isinstance(adminpass, str)
+    assert isinstance(names.dnsdomain, str)
+    assert isinstance(names.domain, str)
+    assert isinstance(serverrole, str)
+    args = ["--ldap-backend=ldapi",
+            "--ldap-backend-type=" + ldap_backend_type,
+            "--password=" + adminpass,
+            ldapuser,
+            "--realm=" + names.dnsdomain,
+            "--domain=" + names.domain,
+            "--server-role='" + serverrole + "'"]
+    message("Run provision with: " + " ".join(args))
 
 def create_phpldapadmin_config(path, setup_path, ldapi_uri):
     """Create a PHP LDAP admin configuration file.

diff --git a/source4/setup/provision b/source4/setup/provision
index 55535cfd4ac590eed8c3bb8dcd52132698f477b1..d097eb941114af4f59c9ff8b560b5f8a100966a4 100755 (executable)
--- a/source4/setup/provision
+++ b/source4/setup/provision
@@ -160,7 +160,7 @@ if opts.server_role == "dc":
 elif opts.server_role == "member":
        server_role = "member server"
 else:
-        server_role = opts.server_role
+       server_role = opts.server_role
 
 creds = credopts.get_credentials(lp)
 

diff --git a/source4/setup/provision-backend b/source4/setup/provision-backend
index aad7de43271126d28dc8471e5dc211d62e3b4403..756870d5df4246ba59a89ad68464083fe7af4004 100755 (executable)
--- a/source4/setup/provision-backend
+++ b/source4/setup/provision-backend
@@ -90,7 +90,7 @@ if opts.server_role == "dc":
 elif opts.server_role == "member":
        server_role = "member server"
 else:
-        server_role = opts.server_role
+       server_role = opts.server_role
 
 setup_dir = opts.setupdir
 if setup_dir is None: